July 2016 - Wine-commits - list.winehq.org

Józef Kucia : d3d10core/tests: Avoid using -1 in place of unsigned integer.
by Alexandre Julliard 04 Jul '16

04 Jul '16

Module: wine Branch: master Commit: 53126c3e1787da7dc1a2a1952eb54141dcd46172 URL: http://source.winehq.org/git/wine.git/?a=commit;h=53126c3e1787da7dc1a2a1952… Author: Józef Kucia <jkucia(a)codeweavers.com> Date: Mon Jul 4 12:26:25 2016 +0200 d3d10core/tests: Avoid using -1 in place of unsigned integer. Signed-off-by: Józef Kucia <jkucia(a)codeweavers.com> Signed-off-by: Henri Verbeet <hverbeet(a)codeweavers.com> Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- dlls/d3d10core/tests/device.c | 270 +++++++++++++++++++++--------------------- 1 file changed, 135 insertions(+), 135 deletions(-) Diff: http://source.winehq.org/git/wine.git/?a=commitdiff;h=53126c3e1787da7dc1a2a…

1 0

Józef Kucia : d3d11: Avoid signed/ unsigned comparison.
by Alexandre Julliard 04 Jul '16

04 Jul '16

Module: wine Branch: master Commit: abc62dfabb3b07b234c3d273d84f32fccb3f97ec URL: http://source.winehq.org/git/wine.git/?a=commit;h=abc62dfabb3b07b234c3d273d… Author: Józef Kucia <jkucia(a)codeweavers.com> Date: Mon Jul 4 12:26:26 2016 +0200 d3d11: Avoid signed/unsigned comparison. Signed-off-by: Józef Kucia <jkucia(a)codeweavers.com> Signed-off-by: Henri Verbeet <hverbeet(a)codeweavers.com> Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- dlls/d3d11/view.c | 36 ++++++++++++++++++------------------ 1 file changed, 18 insertions(+), 18 deletions(-) diff --git a/dlls/d3d11/view.c b/dlls/d3d11/view.c index d0d1b24..5e48965 100644 --- a/dlls/d3d11/view.c +++ b/dlls/d3d11/view.c @@ -183,17 +183,17 @@ static HRESULT normalize_dsv_desc(D3D11_DEPTH_STENCIL_VIEW_DESC *desc, ID3D11Res switch (desc->ViewDimension) { case D3D11_DSV_DIMENSION_TEXTURE1DARRAY: - if (desc->u.Texture1DArray.ArraySize == -1 && desc->u.Texture1DArray.FirstArraySlice < layer_count) + if (desc->u.Texture1DArray.ArraySize == ~0u && desc->u.Texture1DArray.FirstArraySlice < layer_count) desc->u.Texture1DArray.ArraySize = layer_count - desc->u.Texture1DArray.ArraySize; break; case D3D11_DSV_DIMENSION_TEXTURE2DARRAY: - if (desc->u.Texture2DArray.ArraySize == -1 && desc->u.Texture2DArray.FirstArraySlice < layer_count) + if (desc->u.Texture2DArray.ArraySize == ~0u && desc->u.Texture2DArray.FirstArraySlice < layer_count) desc->u.Texture2DArray.ArraySize = layer_count - desc->u.Texture2DArray.FirstArraySlice; break; case D3D11_DSV_DIMENSION_TEXTURE2DMSARRAY: - if (desc->u.Texture2DMSArray.ArraySize == -1 && desc->u.Texture2DMSArray.FirstArraySlice < layer_count) + if (desc->u.Texture2DMSArray.ArraySize == ~0u && desc->u.Texture2DMSArray.FirstArraySlice < layer_count) desc->u.Texture2DMSArray.ArraySize = layer_count - desc->u.Texture2DMSArray.FirstArraySlice; break; @@ -411,23 +411,23 @@ static HRESULT normalize_rtv_desc(D3D11_RENDER_TARGET_VIEW_DESC *desc, ID3D11Res switch (desc->ViewDimension) { case D3D11_RTV_DIMENSION_TEXTURE1DARRAY: - if (desc->u.Texture1DArray.ArraySize == -1 && desc->u.Texture1DArray.FirstArraySlice < layer_count) + if (desc->u.Texture1DArray.ArraySize == ~0u && desc->u.Texture1DArray.FirstArraySlice < layer_count) desc->u.Texture1DArray.ArraySize = layer_count - desc->u.Texture1DArray.ArraySize; break; case D3D11_RTV_DIMENSION_TEXTURE2DARRAY: - if (desc->u.Texture2DArray.ArraySize == -1 && desc->u.Texture2DArray.FirstArraySlice < layer_count) + if (desc->u.Texture2DArray.ArraySize == ~0u && desc->u.Texture2DArray.FirstArraySlice < layer_count) desc->u.Texture2DArray.ArraySize = layer_count - desc->u.Texture2DArray.FirstArraySlice; break; case D3D11_RTV_DIMENSION_TEXTURE2DMSARRAY: - if (desc->u.Texture2DMSArray.ArraySize == -1 && desc->u.Texture2DMSArray.FirstArraySlice < layer_count) + if (desc->u.Texture2DMSArray.ArraySize == ~0u && desc->u.Texture2DMSArray.FirstArraySlice < layer_count) desc->u.Texture2DMSArray.ArraySize = layer_count - desc->u.Texture2DMSArray.FirstArraySlice; break; case D3D11_RTV_DIMENSION_TEXTURE3D: layer_count = max(1, layer_count >> desc->u.Texture3D.MipSlice); - if (desc->u.Texture3D.WSize == -1 && desc->u.Texture3D.FirstWSlice < layer_count) + if (desc->u.Texture3D.WSize == ~0u && desc->u.Texture3D.FirstWSlice < layer_count) desc->u.Texture3D.WSize = layer_count - desc->u.Texture3D.FirstWSlice; break; @@ -650,48 +650,48 @@ static HRESULT normalize_srv_desc(D3D11_SHADER_RESOURCE_VIEW_DESC *desc, ID3D11R switch (desc->ViewDimension) { case D3D11_SRV_DIMENSION_TEXTURE1D: - if (desc->u.Texture1D.MipLevels == -1 && desc->u.Texture1D.MostDetailedMip < miplevel_count) + if (desc->u.Texture1D.MipLevels == ~0u && desc->u.Texture1D.MostDetailedMip < miplevel_count) desc->u.Texture1D.MipLevels = miplevel_count - desc->u.Texture1D.MostDetailedMip; break; case D3D11_SRV_DIMENSION_TEXTURE1DARRAY: - if (desc->u.Texture1DArray.MipLevels == -1 && desc->u.Texture1DArray.MostDetailedMip < miplevel_count) + if (desc->u.Texture1DArray.MipLevels == ~0u && desc->u.Texture1DArray.MostDetailedMip < miplevel_count) desc->u.Texture1DArray.MipLevels = miplevel_count - desc->u.Texture1DArray.MostDetailedMip; - if (desc->u.Texture1DArray.ArraySize == -1 && desc->u.Texture1DArray.FirstArraySlice < miplevel_count) + if (desc->u.Texture1DArray.ArraySize == ~0u && desc->u.Texture1DArray.FirstArraySlice < miplevel_count) desc->u.Texture1DArray.ArraySize = layer_count - desc->u.Texture1DArray.FirstArraySlice; break; case D3D11_SRV_DIMENSION_TEXTURE2D: - if (desc->u.Texture2D.MipLevels == -1 && desc->u.Texture2D.MostDetailedMip < miplevel_count) + if (desc->u.Texture2D.MipLevels == ~0u && desc->u.Texture2D.MostDetailedMip < miplevel_count) desc->u.Texture2D.MipLevels = miplevel_count - desc->u.Texture2D.MostDetailedMip; break; case D3D11_SRV_DIMENSION_TEXTURE2DARRAY: - if (desc->u.Texture2DArray.MipLevels == -1 && desc->u.Texture2DArray.MostDetailedMip < miplevel_count) + if (desc->u.Texture2DArray.MipLevels == ~0u && desc->u.Texture2DArray.MostDetailedMip < miplevel_count) desc->u.Texture2DArray.MipLevels = miplevel_count - desc->u.Texture2DArray.MostDetailedMip; - if (desc->u.Texture2DArray.ArraySize == -1 && desc->u.Texture2DArray.FirstArraySlice < layer_count) + if (desc->u.Texture2DArray.ArraySize == ~0u && desc->u.Texture2DArray.FirstArraySlice < layer_count) desc->u.Texture2DArray.ArraySize = layer_count - desc->u.Texture2DArray.FirstArraySlice; break; case D3D11_SRV_DIMENSION_TEXTURE2DMSARRAY: - if (desc->u.Texture2DMSArray.ArraySize == -1 && desc->u.Texture2DMSArray.FirstArraySlice < layer_count) + if (desc->u.Texture2DMSArray.ArraySize == ~0u && desc->u.Texture2DMSArray.FirstArraySlice < layer_count) desc->u.Texture2DMSArray.ArraySize = layer_count - desc->u.Texture2DMSArray.FirstArraySlice; break; case D3D11_SRV_DIMENSION_TEXTURE3D: - if (desc->u.Texture3D.MipLevels == -1 && desc->u.Texture3D.MostDetailedMip < miplevel_count) + if (desc->u.Texture3D.MipLevels == ~0u && desc->u.Texture3D.MostDetailedMip < miplevel_count) desc->u.Texture3D.MipLevels = miplevel_count - desc->u.Texture3D.MostDetailedMip; break; case D3D11_SRV_DIMENSION_TEXTURECUBE: - if (desc->u.TextureCube.MipLevels == -1 && desc->u.TextureCube.MostDetailedMip < miplevel_count) + if (desc->u.TextureCube.MipLevels == ~0u && desc->u.TextureCube.MostDetailedMip < miplevel_count) desc->u.TextureCube.MipLevels = miplevel_count - desc->u.TextureCube.MostDetailedMip; break; case D3D11_SRV_DIMENSION_TEXTURECUBEARRAY: - if (desc->u.TextureCubeArray.MipLevels == -1 && desc->u.TextureCubeArray.MostDetailedMip < miplevel_count) + if (desc->u.TextureCubeArray.MipLevels == ~0u && desc->u.TextureCubeArray.MostDetailedMip < miplevel_count) desc->u.TextureCubeArray.MipLevels = miplevel_count - desc->u.TextureCubeArray.MostDetailedMip; - if (desc->u.TextureCubeArray.NumCubes == -1 && desc->u.TextureCubeArray.First2DArrayFace < layer_count) + if (desc->u.TextureCubeArray.NumCubes == ~0u && desc->u.TextureCubeArray.First2DArrayFace < layer_count) desc->u.TextureCubeArray.NumCubes = (layer_count - desc->u.TextureCubeArray.First2DArrayFace) / 6; break;

1 0

Józef Kucia : wined3d: Add missing system-value semantics.
by Alexandre Julliard 04 Jul '16

04 Jul '16

Module: wine Branch: master Commit: 9a2a73780749882ab38e2cc079d4ba947f8d05c6 URL: http://source.winehq.org/git/wine.git/?a=commit;h=9a2a73780749882ab38e2cc07… Author: Józef Kucia <jkucia(a)codeweavers.com> Date: Mon Jul 4 12:26:27 2016 +0200 wined3d: Add missing system-value semantics. Signed-off-by: Józef Kucia <jkucia(a)codeweavers.com> Signed-off-by: Henri Verbeet <hverbeet(a)codeweavers.com> Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- dlls/wined3d/shader.c | 3 +++ include/wine/wined3d.h | 3 +++ 2 files changed, 6 insertions(+) diff --git a/dlls/wined3d/shader.c b/dlls/wined3d/shader.c index 700b7c1..eb95136 100644 --- a/dlls/wined3d/shader.c +++ b/dlls/wined3d/shader.c @@ -253,6 +253,9 @@ sysval_semantic_names[] = { {WINED3D_SV_POSITION, "SV_Position"}, {WINED3D_SV_CLIP_DISTANCE, "SV_ClipDistance"}, + {WINED3D_SV_CULL_DISTANCE, "SV_CullDistance"}, + {WINED3D_SV_RENDER_TARGET_ARRAY_INDEX, "SV_RenderTargetArrayIndex"}, + {WINED3D_SV_VIEWPORT_ARRAY_INDEX, "SV_ViewportArrayIndex"}, {WINED3D_SV_VERTEX_ID, "SV_VertexID"}, {WINED3D_SV_INSTANCE_ID, "SV_InstanceID"}, {WINED3D_SV_PRIMITIVE_ID, "SV_PrimitiveID"}, diff --git a/include/wine/wined3d.h b/include/wine/wined3d.h index 1c0a61b..a425ac5 100644 --- a/include/wine/wined3d.h +++ b/include/wine/wined3d.h @@ -745,6 +745,9 @@ enum wined3d_sysval_semantic { WINED3D_SV_POSITION = 1, WINED3D_SV_CLIP_DISTANCE = 2, + WINED3D_SV_CULL_DISTANCE = 3, + WINED3D_SV_RENDER_TARGET_ARRAY_INDEX = 4, + WINED3D_SV_VIEWPORT_ARRAY_INDEX = 5, WINED3D_SV_VERTEX_ID = 6, WINED3D_SV_PRIMITIVE_ID = 7, WINED3D_SV_INSTANCE_ID = 8,

1 0

Józef Kucia : wined3d: Recognize SM5 emit_stream opcode.
by Alexandre Julliard 04 Jul '16

04 Jul '16

Module: wine Branch: master Commit: 5c5a8256e88b0bb62849dcd55e8ad0df5cdf4dd4 URL: http://source.winehq.org/git/wine.git/?a=commit;h=5c5a8256e88b0bb62849dcd55… Author: Józef Kucia <jkucia(a)codeweavers.com> Date: Mon Jul 4 12:26:28 2016 +0200 wined3d: Recognize SM5 emit_stream opcode. Signed-off-by: Józef Kucia <jkucia(a)codeweavers.com> Signed-off-by: Henri Verbeet <hverbeet(a)codeweavers.com> Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- dlls/wined3d/arb_program_shader.c | 1 + dlls/wined3d/glsl_shader.c | 1 + dlls/wined3d/shader.c | 5 +++++ dlls/wined3d/shader_sm4.c | 29 ++++++++++++++++------------- dlls/wined3d/wined3d_private.h | 2 ++ 5 files changed, 25 insertions(+), 13 deletions(-) diff --git a/dlls/wined3d/arb_program_shader.c b/dlls/wined3d/arb_program_shader.c index 5a0cdba..c8a4c95 100644 --- a/dlls/wined3d/arb_program_shader.c +++ b/dlls/wined3d/arb_program_shader.c @@ -5274,6 +5274,7 @@ static const SHADER_HANDLER shader_arb_instruction_handler_table[WINED3DSIH_TABL /* WINED3DSIH_DSY_FINE */ NULL, /* WINED3DSIH_ELSE */ shader_hw_else, /* WINED3DSIH_EMIT */ NULL, + /* WINED3DSIH_EMIT_STREAM */ NULL, /* WINED3DSIH_ENDIF */ shader_hw_endif, /* WINED3DSIH_ENDLOOP */ shader_hw_endloop, /* WINED3DSIH_ENDREP */ shader_hw_endrep, diff --git a/dlls/wined3d/glsl_shader.c b/dlls/wined3d/glsl_shader.c index c6b3c1b..4bae389 100644 --- a/dlls/wined3d/glsl_shader.c +++ b/dlls/wined3d/glsl_shader.c @@ -8610,6 +8610,7 @@ static const SHADER_HANDLER shader_glsl_instruction_handler_table[WINED3DSIH_TAB /* WINED3DSIH_DSY_FINE */ NULL, /* WINED3DSIH_ELSE */ shader_glsl_else, /* WINED3DSIH_EMIT */ shader_glsl_emit, + /* WINED3DSIH_EMIT_STREAM */ NULL, /* WINED3DSIH_ENDIF */ shader_glsl_end, /* WINED3DSIH_ENDLOOP */ shader_glsl_end, /* WINED3DSIH_ENDREP */ shader_glsl_end, diff --git a/dlls/wined3d/shader.c b/dlls/wined3d/shader.c index eb95136..ebe64ee 100644 --- a/dlls/wined3d/shader.c +++ b/dlls/wined3d/shader.c @@ -104,6 +104,7 @@ static const char * const shader_opcode_names[] = /* WINED3DSIH_DSY_FINE */ "deriv_rty_fine", /* WINED3DSIH_ELSE */ "else", /* WINED3DSIH_EMIT */ "emit", + /* WINED3DSIH_EMIT_STREAM */ "emit_stream", /* WINED3DSIH_ENDIF */ "endif", /* WINED3DSIH_ENDLOOP */ "endloop", /* WINED3DSIH_ENDREP */ "endrep", @@ -1779,6 +1780,10 @@ static void shader_dump_register(struct wined3d_string_buffer *buffer, shader_addline(buffer, "x"); break; + case WINED3DSPR_STREAM: + shader_addline(buffer, "m"); + break; + default: shader_addline(buffer, "<unhandled_rtype(%#x)>", reg->type); break; diff --git a/dlls/wined3d/shader_sm4.c b/dlls/wined3d/shader_sm4.c index c90c2d4..ed4cdc9 100644 --- a/dlls/wined3d/shader_sm4.c +++ b/dlls/wined3d/shader_sm4.c @@ -206,6 +206,7 @@ enum wined3d_sm4_opcode WINED3D_SM5_OP_HS_CONTROL_POINT_PHASE = 0x72, WINED3D_SM5_OP_HS_FORK_PHASE = 0x73, WINED3D_SM5_OP_HS_JOIN_PHASE = 0x74, + WINED3D_SM5_OP_EMIT_STREAM = 0x75, WINED3D_SM5_OP_BUFINFO = 0x79, WINED3D_SM5_OP_DERIV_RTX_COARSE = 0x7a, WINED3D_SM5_OP_DERIV_RTX_FINE = 0x7b, @@ -237,18 +238,19 @@ enum wined3d_sm4_opcode enum wined3d_sm4_register_type { - WINED3D_SM4_RT_TEMP = 0x0, - WINED3D_SM4_RT_INPUT = 0x1, - WINED3D_SM4_RT_OUTPUT = 0x2, - WINED3D_SM4_RT_INDEXABLE_TEMP = 0x3, - WINED3D_SM4_RT_IMMCONST = 0x4, - WINED3D_SM4_RT_SAMPLER = 0x6, - WINED3D_SM4_RT_RESOURCE = 0x7, - WINED3D_SM4_RT_CONSTBUFFER = 0x8, - WINED3D_SM4_RT_IMMCONSTBUFFER = 0x9, - WINED3D_SM4_RT_PRIMID = 0xb, - WINED3D_SM4_RT_DEPTHOUT = 0xc, - WINED3D_SM4_RT_NULL = 0xd, + WINED3D_SM4_RT_TEMP = 0x00, + WINED3D_SM4_RT_INPUT = 0x01, + WINED3D_SM4_RT_OUTPUT = 0x02, + WINED3D_SM4_RT_INDEXABLE_TEMP = 0x03, + WINED3D_SM4_RT_IMMCONST = 0x04, + WINED3D_SM4_RT_SAMPLER = 0x06, + WINED3D_SM4_RT_RESOURCE = 0x07, + WINED3D_SM4_RT_CONSTBUFFER = 0x08, + WINED3D_SM4_RT_IMMCONSTBUFFER = 0x09, + WINED3D_SM4_RT_PRIMID = 0x0b, + WINED3D_SM4_RT_DEPTHOUT = 0x0c, + WINED3D_SM4_RT_NULL = 0x0d, + WINED3D_SM5_RT_STREAM = 0x10, WINED3D_SM5_RT_OUTPUT_CONTROL_POINT_ID = 0x16, WINED3D_SM5_RT_FORK_INSTANCE_ID = 0x17, WINED3D_SM5_RT_INPUT_CONTROL_POINT = 0x19, @@ -795,6 +797,7 @@ static const struct wined3d_sm4_opcode_info opcode_table[] = {WINED3D_SM5_OP_HS_CONTROL_POINT_PHASE, WINED3DSIH_HS_CONTROL_POINT_PHASE, "", ""}, {WINED3D_SM5_OP_HS_FORK_PHASE, WINED3DSIH_HS_FORK_PHASE, "", ""}, {WINED3D_SM5_OP_HS_JOIN_PHASE, WINED3DSIH_HS_JOIN_PHASE, "", ""}, + {WINED3D_SM5_OP_EMIT_STREAM, WINED3DSIH_EMIT_STREAM, "", "f"}, {WINED3D_SM5_OP_BUFINFO, WINED3DSIH_BUFINFO, "i", "U"}, {WINED3D_SM5_OP_DERIV_RTX_COARSE, WINED3DSIH_DSX_COARSE, "f", "f"}, {WINED3D_SM5_OP_DERIV_RTX_FINE, WINED3DSIH_DSX_FINE, "f", "f"}, @@ -854,7 +857,7 @@ static const enum wined3d_shader_register_type register_type_table[] = /* WINED3D_SM4_RT_NULL */ WINED3DSPR_NULL, /* UNKNOWN */ ~0u, /* UNKNOWN */ ~0u, - /* UNKNOWN */ ~0u, + /* WINED3D_SM5_RT_STREAM */ WINED3DSPR_STREAM, /* UNKNOWN */ ~0u, /* UNKNOWN */ ~0u, /* UNKNOWN */ ~0u, diff --git a/dlls/wined3d/wined3d_private.h b/dlls/wined3d/wined3d_private.h index 184d7b5..0e7f87a 100644 --- a/dlls/wined3d/wined3d_private.h +++ b/dlls/wined3d/wined3d_private.h @@ -393,6 +393,7 @@ enum wined3d_shader_register_type WINED3DSPR_LOCALTHREADID, WINED3DSPR_LOCALTHREADINDEX, WINED3DSPR_IDXTEMP, + WINED3DSPR_STREAM, }; enum wined3d_data_type @@ -619,6 +620,7 @@ enum WINED3D_SHADER_INSTRUCTION_HANDLER WINED3DSIH_DSY_FINE, WINED3DSIH_ELSE, WINED3DSIH_EMIT, + WINED3DSIH_EMIT_STREAM, WINED3DSIH_ENDIF, WINED3DSIH_ENDLOOP, WINED3DSIH_ENDREP,

1 0

Józef Kucia : wined3d: Recognize SM5 dcl_stream opcode.
by Alexandre Julliard 04 Jul '16

04 Jul '16

Module: wine Branch: master Commit: 2460d6f3cb2da1f9f07493c834ba26b2c689b8f8 URL: http://source.winehq.org/git/wine.git/?a=commit;h=2460d6f3cb2da1f9f07493c83… Author: Józef Kucia <jkucia(a)codeweavers.com> Date: Mon Jul 4 12:26:29 2016 +0200 wined3d: Recognize SM5 dcl_stream opcode. Signed-off-by: Józef Kucia <jkucia(a)codeweavers.com> Signed-off-by: Henri Verbeet <hverbeet(a)codeweavers.com> Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- dlls/wined3d/arb_program_shader.c | 1 + dlls/wined3d/glsl_shader.c | 1 + dlls/wined3d/shader.c | 1 + dlls/wined3d/shader_sm4.c | 2 ++ dlls/wined3d/wined3d_private.h | 1 + 5 files changed, 6 insertions(+) diff --git a/dlls/wined3d/arb_program_shader.c b/dlls/wined3d/arb_program_shader.c index c8a4c95..0b4c6a0 100644 --- a/dlls/wined3d/arb_program_shader.c +++ b/dlls/wined3d/arb_program_shader.c @@ -5247,6 +5247,7 @@ static const SHADER_HANDLER shader_arb_instruction_handler_table[WINED3DSIH_TABL /* WINED3DSIH_DCL_OUTPUT_TOPOLOGY */ shader_hw_nop, /* WINED3DSIH_DCL_RESOURCE_STRUCTURED */ NULL, /* WINED3DSIH_DCL_SAMPLER */ NULL, + /* WINED3DSIH_DCL_STREAM */ NULL, /* WINED3DSIH_DCL_TEMPS */ NULL, /* WINED3DSIH_DCL_TESSELLATOR_DOMAIN */ NULL, /* WINED3DSIH_DCL_TESSELLATOR_OUTPUT_PRIMITIVE */ NULL, diff --git a/dlls/wined3d/glsl_shader.c b/dlls/wined3d/glsl_shader.c index 4bae389..63442b3 100644 --- a/dlls/wined3d/glsl_shader.c +++ b/dlls/wined3d/glsl_shader.c @@ -8583,6 +8583,7 @@ static const SHADER_HANDLER shader_glsl_instruction_handler_table[WINED3DSIH_TAB /* WINED3DSIH_DCL_OUTPUT_TOPOLOGY */ shader_glsl_nop, /* WINED3DSIH_DCL_RESOURCE_STRUCTURED */ NULL, /* WINED3DSIH_DCL_SAMPLER */ shader_glsl_nop, + /* WINED3DSIH_DCL_STREAM */ NULL, /* WINED3DSIH_DCL_TEMPS */ shader_glsl_nop, /* WINED3DSIH_DCL_TESSELLATOR_DOMAIN */ NULL, /* WINED3DSIH_DCL_TESSELLATOR_OUTPUT_PRIMITIVE */ NULL, diff --git a/dlls/wined3d/shader.c b/dlls/wined3d/shader.c index ebe64ee..d11eeb0 100644 --- a/dlls/wined3d/shader.c +++ b/dlls/wined3d/shader.c @@ -77,6 +77,7 @@ static const char * const shader_opcode_names[] = /* WINED3DSIH_DCL_OUTPUT_TOPOLOGY */ "dcl_outputTopology", /* WINED3DSIH_DCL_RESOURCE_STRUCTURED */ "dcl_resource_structured", /* WINED3DSIH_DCL_SAMPLER */ "dcl_sampler", + /* WINED3DSIH_DCL_STREAM */ "dcl_stream", /* WINED3DSIH_DCL_TEMPS */ "dcl_temps", /* WINED3DSIH_DCL_TESSELLATOR_DOMAIN */ "dcl_tessellator_domain", /* WINED3DSIH_DCL_TESSELLATOR_OUTPUT_PRIMITIVE */ "dcl_tessellator_output_primitive", diff --git a/dlls/wined3d/shader_sm4.c b/dlls/wined3d/shader_sm4.c index ed4cdc9..4c09843 100644 --- a/dlls/wined3d/shader_sm4.c +++ b/dlls/wined3d/shader_sm4.c @@ -214,6 +214,7 @@ enum wined3d_sm4_opcode WINED3D_SM5_OP_DERIV_RTY_FINE = 0x7d, WINED3D_SM5_OP_GATHER4_C = 0x7e, WINED3D_SM5_OP_BFI = 0x8c, + WINED3D_SM5_OP_DCL_STREAM = 0x8f, WINED3D_SM5_OP_DCL_INPUT_CONTROL_POINT_COUNT = 0x93, WINED3D_SM5_OP_DCL_OUTPUT_CONTROL_POINT_COUNT = 0x94, WINED3D_SM5_OP_DCL_TESSELLATOR_DOMAIN = 0x95, @@ -805,6 +806,7 @@ static const struct wined3d_sm4_opcode_info opcode_table[] = {WINED3D_SM5_OP_DERIV_RTY_FINE, WINED3DSIH_DSY_FINE, "f", "f"}, {WINED3D_SM5_OP_GATHER4_C, WINED3DSIH_GATHER4_C, "f", "fRSf"}, {WINED3D_SM5_OP_BFI, WINED3DSIH_BFI, "u", "uuuu"}, + {WINED3D_SM5_OP_DCL_STREAM, WINED3DSIH_DCL_STREAM, "", "f"}, {WINED3D_SM5_OP_DCL_INPUT_CONTROL_POINT_COUNT, WINED3DSIH_DCL_INPUT_CONTROL_POINT_COUNT, "", "", shader_sm5_read_control_point_count}, {WINED3D_SM5_OP_DCL_OUTPUT_CONTROL_POINT_COUNT, WINED3DSIH_DCL_OUTPUT_CONTROL_POINT_COUNT, "", "", diff --git a/dlls/wined3d/wined3d_private.h b/dlls/wined3d/wined3d_private.h index 0e7f87a..c3d5ae8 100644 --- a/dlls/wined3d/wined3d_private.h +++ b/dlls/wined3d/wined3d_private.h @@ -593,6 +593,7 @@ enum WINED3D_SHADER_INSTRUCTION_HANDLER WINED3DSIH_DCL_OUTPUT_TOPOLOGY, WINED3DSIH_DCL_RESOURCE_STRUCTURED, WINED3DSIH_DCL_SAMPLER, + WINED3DSIH_DCL_STREAM, WINED3DSIH_DCL_TEMPS, WINED3DSIH_DCL_TESSELLATOR_DOMAIN, WINED3DSIH_DCL_TESSELLATOR_OUTPUT_PRIMITIVE,

1 0

Józef Kucia : wined3d: Implement SM4 indexable temporary registers in GLSL backend.
by Alexandre Julliard 04 Jul '16

04 Jul '16

Module: wine Branch: master Commit: b18f2f5debba73005ea4c39160715c29f0c360ad URL: http://source.winehq.org/git/wine.git/?a=commit;h=b18f2f5debba73005ea4c3916… Author: Józef Kucia <jkucia(a)codeweavers.com> Date: Mon Jul 4 12:26:30 2016 +0200 wined3d: Implement SM4 indexable temporary registers in GLSL backend. Signed-off-by: Józef Kucia <jkucia(a)codeweavers.com> Signed-off-by: Henri Verbeet <hverbeet(a)codeweavers.com> Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- dlls/wined3d/glsl_shader.c | 18 +++++++++++++++++- dlls/wined3d/shader.c | 27 +++++++++++++++++++++++++-- dlls/wined3d/wined3d_private.h | 16 +++++++++------- 3 files changed, 51 insertions(+), 10 deletions(-) diff --git a/dlls/wined3d/glsl_shader.c b/dlls/wined3d/glsl_shader.c index 63442b3..5c33106 100644 --- a/dlls/wined3d/glsl_shader.c +++ b/dlls/wined3d/glsl_shader.c @@ -1796,6 +1796,7 @@ static void shader_generate_glsl_declarations(const struct wined3d_context *cont const struct vs_compile_args *vs_args = ctx_priv->cur_vs_args; const struct ps_compile_args *ps_args = ctx_priv->cur_ps_args; const struct wined3d_gl_info *gl_info = context->gl_info; + const struct wined3d_shader_indexable_temp *idx_temp_reg; unsigned int i, extra_constants_needed = 0; const struct wined3d_shader_lconst *lconst; const char *prefix; @@ -2172,6 +2173,14 @@ static void shader_generate_glsl_declarations(const struct wined3d_context *cont if (map & 1) shader_addline(buffer, "vec4 R%u;\n", i); } + /* Declare indexable temporary variables */ + LIST_FOR_EACH_ENTRY(idx_temp_reg, &reg_maps->indexable_temps, struct wined3d_shader_indexable_temp, entry) + { + if (idx_temp_reg->component_count != 4) + FIXME("Ignoring component count %u.\n", idx_temp_reg->component_count); + shader_addline(buffer, "vec4 X%u[%u];\n", idx_temp_reg->register_idx, idx_temp_reg->register_size); + } + /* Declare loop registers aLx */ if (version->major < 4) { @@ -2575,6 +2584,13 @@ static void shader_glsl_get_register_name(const struct wined3d_shader_register * sprintf(register_name, "uint(gl_PrimitiveIDIn)"); break; + case WINED3DSPR_IDXTEMP: + if (reg->idx[1].rel_addr) + sprintf(register_name, "X%u[%s + %u]", reg->idx[0].offset, rel_param1.param_str, reg->idx[1].offset); + else + sprintf(register_name, "X%u[%u]", reg->idx[0].offset, reg->idx[1].offset); + break; + default: FIXME("Unhandled register type %#x.\n", reg->type); sprintf(register_name, "unrecognized_register"); @@ -8568,7 +8584,7 @@ static const SHADER_HANDLER shader_glsl_instruction_handler_table[WINED3DSIH_TAB /* WINED3DSIH_DCL_HS_FORK_PHASE_INSTANCE_COUNT */ NULL, /* WINED3DSIH_DCL_HS_MAX_TESSFACTOR */ NULL, /* WINED3DSIH_DCL_IMMEDIATE_CONSTANT_BUFFER */ NULL, - /* WINED3DSIH_DCL_INDEXABLE_TEMP */ NULL, + /* WINED3DSIH_DCL_INDEXABLE_TEMP */ shader_glsl_nop, /* WINED3DSIH_DCL_INPUT */ shader_glsl_nop, /* WINED3DSIH_DCL_INPUT_CONTROL_POINT_COUNT */ NULL, /* WINED3DSIH_DCL_INPUT_PRIMITIVE */ shader_glsl_nop, diff --git a/dlls/wined3d/shader.c b/dlls/wined3d/shader.c index d11eeb0..2a3b9a9 100644 --- a/dlls/wined3d/shader.c +++ b/dlls/wined3d/shader.c @@ -852,6 +852,7 @@ static HRESULT shader_get_registers_used(struct wined3d_shader *shader, const st memset(input_signature_elements, 0, sizeof(input_signature_elements)); memset(output_signature_elements, 0, sizeof(output_signature_elements)); reg_maps->min_rel_offset = ~0U; + list_init(&reg_maps->indexable_temps); fe->shader_read_header(fe_data, &ptr, &shader_version); reg_maps->shader_version = shader_version; @@ -947,6 +948,16 @@ static HRESULT shader_get_registers_used(struct wined3d_shader *shader, const st FIXME("Multiple immediate constant buffers.\n"); reg_maps->icb = ins.declaration.icb; } + else if (ins.handler_idx == WINED3DSIH_DCL_INDEXABLE_TEMP) + { + struct wined3d_shader_indexable_temp *reg; + + if (!(reg = HeapAlloc(GetProcessHeap(), 0, sizeof(*reg)))) + return E_OUTOFMEMORY; + + *reg = ins.declaration.indexable_temp; + list_add_tail(&reg_maps->indexable_temps, &reg->entry); + } else if (ins.handler_idx == WINED3DSIH_DCL_INPUT_PRIMITIVE) { if (shader_version.type == WINED3D_SHADER_TYPE_GEOMETRY) @@ -1331,6 +1342,18 @@ static HRESULT shader_get_registers_used(struct wined3d_shader *shader, const st return WINED3D_OK; } +static void shader_cleanup_reg_maps(struct wined3d_shader_reg_maps *reg_maps) +{ + struct wined3d_shader_indexable_temp *reg, *reg_next; + + HeapFree(GetProcessHeap(), 0, reg_maps->constf); + HeapFree(GetProcessHeap(), 0, reg_maps->sampler_map.entries); + + LIST_FOR_EACH_ENTRY_SAFE(reg, reg_next, &reg_maps->indexable_temps, struct wined3d_shader_indexable_temp, entry) + HeapFree(GetProcessHeap(), 0, reg); + list_init(&reg_maps->indexable_temps); +} + unsigned int shader_find_free_input_register(const struct wined3d_shader_reg_maps *reg_maps, unsigned int max) { DWORD map = 1u << max; @@ -2432,8 +2455,7 @@ static void shader_cleanup(struct wined3d_shader *shader) HeapFree(GetProcessHeap(), 0, shader->input_signature.elements); HeapFree(GetProcessHeap(), 0, shader->signature_strings); shader->device->shader_backend->shader_destroy(shader); - HeapFree(GetProcessHeap(), 0, shader->reg_maps.constf); - HeapFree(GetProcessHeap(), 0, shader->reg_maps.sampler_map.entries); + shader_cleanup_reg_maps(&shader->reg_maps); HeapFree(GetProcessHeap(), 0, shader->function); shader_delete_constant_list(&shader->constantsF); shader_delete_constant_list(&shader->constantsB); @@ -2609,6 +2631,7 @@ static HRESULT shader_set_function(struct wined3d_shader *shader, const DWORD *b list_init(&shader->constantsB); list_init(&shader->constantsI); shader->lconst_inf_or_nan = FALSE; + list_init(&reg_maps->indexable_temps); fe = shader_select_frontend(*byte_code); if (!fe) diff --git a/dlls/wined3d/wined3d_private.h b/dlls/wined3d/wined3d_private.h index c3d5ae8..f592664 100644 --- a/dlls/wined3d/wined3d_private.h +++ b/dlls/wined3d/wined3d_private.h @@ -791,6 +791,14 @@ struct wined3d_shader_immediate_constant_buffer DWORD data[MAX_IMMEDIATE_CONSTANT_BUFFER_SIZE]; }; +struct wined3d_shader_indexable_temp +{ + struct list entry; + unsigned int register_idx; + unsigned int register_size; + unsigned int component_count; +}; + #define WINED3D_SHADER_VERSION(major, minor) (((major) << 8) | (minor)) struct wined3d_shader_reg_maps @@ -801,6 +809,7 @@ struct wined3d_shader_reg_maps WORD labels; /* MAX_LABELS, 16 */ DWORD temporary; /* MAX_REG_TEMP, 32 */ DWORD *constf; /* pixel, vertex */ + struct list indexable_temps; const struct wined3d_shader_immediate_constant_buffer *icb; union { @@ -899,13 +908,6 @@ struct wined3d_shader_src_param enum wined3d_shader_src_modifier modifiers; }; -struct wined3d_shader_indexable_temp -{ - unsigned int register_idx; - unsigned int register_size; - unsigned int component_count; -}; - struct wined3d_shader_semantic { enum wined3d_decl_usage usage;

1 0

Hans Leidekker : webservices/tests: Add tests for WsWriteXmlBuffer.
by Alexandre Julliard 04 Jul '16

04 Jul '16

Module: wine Branch: master Commit: 13faf34b07c7cc4953aa2ce868c5b0083b80184f URL: http://source.winehq.org/git/wine.git/?a=commit;h=13faf34b07c7cc4953aa2ce86… Author: Hans Leidekker <hans(a)codeweavers.com> Date: Mon Jul 4 11:35:37 2016 +0200 webservices/tests: Add tests for WsWriteXmlBuffer. Signed-off-by: Hans Leidekker <hans(a)codeweavers.com> Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- dlls/webservices/tests/writer.c | 58 +++++++++++++++++++++++++++++++++++++++++ 1 file changed, 58 insertions(+) diff --git a/dlls/webservices/tests/writer.c b/dlls/webservices/tests/writer.c index 5314bc8..f4336f6 100644 --- a/dlls/webservices/tests/writer.c +++ b/dlls/webservices/tests/writer.c @@ -1579,6 +1579,63 @@ static void test_WsSetWriterPosition(void) WsFreeHeap( heap ); } +static void test_WsWriteXmlBuffer(void) +{ + WS_XML_STRING localname = {1, (BYTE *)"t"}, ns = {0, NULL}; + WS_XML_WRITER *writer1, *writer2; + WS_XML_BUFFER *buffer1, *buffer2; + WS_HEAP *heap; + HRESULT hr; + + hr = WsCreateHeap( 1 << 16, 0, NULL, 0, &heap, NULL ); + ok( hr == S_OK, "got %08x\n", hr ); + + hr = WsCreateXmlBuffer( NULL, NULL, 0, NULL, NULL ); + ok( hr == E_INVALIDARG, "got %08x\n", hr ); + + hr = WsCreateWriter( NULL, 0, &writer1, NULL ) ; + ok( hr == S_OK, "got %08x\n", hr ); + + hr = WsCreateXmlBuffer( heap, NULL, 0, NULL, NULL ); + ok( hr == E_INVALIDARG, "got %08x\n", hr ); + + hr = WsCreateXmlBuffer( heap, NULL, 0, &buffer1, NULL ); + ok( hr == S_OK, "got %08x\n", hr ); + + hr = WsSetOutputToBuffer( writer1, buffer1, NULL, 0, NULL ); + ok( hr == S_OK, "got %08x\n", hr ); + + hr = WsWriteStartElement( writer1, NULL, &localname, &ns, NULL ); + ok( hr == S_OK, "got %08x\n", hr ); + + hr = WsWriteEndElement( writer1, NULL ); + ok( hr == S_OK, "got %08x\n", hr ); + check_output_buffer( buffer1, "<t/>", __LINE__ ); + + hr = WsCreateWriter( NULL, 0, &writer2, NULL ) ; + ok( hr == S_OK, "got %08x\n", hr ); + + hr = WsCreateXmlBuffer( heap, NULL, 0, &buffer2, NULL ); + ok( hr == S_OK, "got %08x\n", hr ); + + hr = WsSetOutputToBuffer( writer2, buffer2, NULL, 0, NULL ); + ok( hr == S_OK, "got %08x\n", hr ); + + hr = WsWriteXmlBuffer( writer2, buffer1, NULL ); + ok( hr == S_OK, "got %08x\n", hr ); + check_output_buffer( buffer2, "<t/>", __LINE__ ); + + hr = WsMoveWriter( writer2, WS_MOVE_TO_PREVIOUS_ELEMENT, NULL, NULL ); + todo_wine ok( hr == S_OK, "got %08x\n", hr ); + + hr = WsWriteXmlBuffer( writer2, buffer1, NULL ); + todo_wine ok( hr == WS_E_INVALID_FORMAT, "got %08x\n", hr ); + + WsFreeWriter( writer1 ); + WsFreeWriter( writer2 ); + WsFreeHeap( heap ); +} + START_TEST(writer) { test_WsCreateWriter(); @@ -1600,4 +1657,5 @@ START_TEST(writer) test_WsMoveWriter(); test_WsGetWriterPosition(); test_WsSetWriterPosition(); + test_WsWriteXmlBuffer(); }

1 0

Hans Leidekker : webservices: Implement WsGetReaderPosition.
by Alexandre Julliard 04 Jul '16

04 Jul '16

Module: wine Branch: master Commit: 5ad00660685068eb5adf3e721f997be57b59610e URL: http://source.winehq.org/git/wine.git/?a=commit;h=5ad00660685068eb5adf3e721… Author: Hans Leidekker <hans(a)codeweavers.com> Date: Mon Jul 4 11:35:38 2016 +0200 webservices: Implement WsGetReaderPosition. Signed-off-by: Hans Leidekker <hans(a)codeweavers.com> Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- dlls/webservices/reader.c | 28 ++++++++++++++++++++--- dlls/webservices/tests/reader.c | 47 +++++++++++++++++++++++++++++++++++++++ dlls/webservices/webservices.spec | 2 +- 3 files changed, 73 insertions(+), 4 deletions(-) diff --git a/dlls/webservices/reader.c b/dlls/webservices/reader.c index b8dfed4..b326bd8 100644 --- a/dlls/webservices/reader.c +++ b/dlls/webservices/reader.c @@ -432,6 +432,7 @@ struct reader ULONG nb_prefixes; ULONG nb_prefixes_allocated; WS_XML_READER_INPUT_TYPE input_type; + struct xmlbuf *input_buf; const unsigned char *input_data; ULONG input_size; ULONG prop_count; @@ -570,6 +571,7 @@ static HRESULT read_init_state( struct reader *reader ) destroy_nodes( reader->root ); reader->root = NULL; + reader->input_buf = NULL; clear_prefixes( reader->prefixes, reader->nb_prefixes ); reader->nb_prefixes = 1; if (!(node = alloc_node( WS_XML_NODE_TYPE_EOF ))) return E_OUTOFMEMORY; @@ -3823,9 +3825,10 @@ static WS_CHARSET detect_charset( const unsigned char *data, ULONG size, ULONG * return ret; } -static void set_input_buffer( struct reader *reader, const unsigned char *data, ULONG size ) +static void set_input_buffer( struct reader *reader, struct xmlbuf *buf, const unsigned char *data, ULONG size ) { reader->input_type = WS_XML_READER_INPUT_TYPE_BUFFER; + reader->input_buf = buf; reader->input_data = data; reader->input_size = size; @@ -3891,7 +3894,8 @@ HRESULT WINAPI WsSetInput( WS_XML_READER *handle, const WS_XML_READER_ENCODING * case WS_XML_READER_INPUT_TYPE_BUFFER: { WS_XML_READER_BUFFER_INPUT *buf = (WS_XML_READER_BUFFER_INPUT *)input; - set_input_buffer( reader, (const unsigned char *)buf->encodedData + offset, buf->encodedDataSize - offset ); + set_input_buffer( reader, NULL, (const unsigned char *)buf->encodedData + offset, + buf->encodedDataSize - offset ); break; } default: @@ -3937,7 +3941,7 @@ HRESULT WINAPI WsSetInputToBuffer( WS_XML_READER *handle, WS_XML_BUFFER *buffer, &charset, sizeof(charset) ); if (hr != S_OK) return hr; - set_input_buffer( reader, (const unsigned char *)xmlbuf->ptr + offset, xmlbuf->size - offset ); + set_input_buffer( reader, xmlbuf, (const unsigned char *)xmlbuf->ptr + offset, xmlbuf->size - offset ); if (!(node = alloc_node( WS_XML_NODE_TYPE_BOF ))) return E_OUTOFMEMORY; read_insert_bof( reader, node ); return S_OK; @@ -3957,3 +3961,21 @@ HRESULT WINAPI WsXmlStringEquals( const WS_XML_STRING *str1, const WS_XML_STRING if (!memcmp( str1->bytes, str2->bytes, str1->length )) return S_OK; return S_FALSE; } + +/************************************************************************** + * WsGetReaderPosition [webservices.@] + */ +HRESULT WINAPI WsGetReaderPosition( WS_XML_READER *handle, WS_XML_NODE_POSITION *pos, WS_ERROR *error ) +{ + struct reader *reader = (struct reader *)handle; + + TRACE( "%p %p %p\n", handle, pos, error ); + if (error) FIXME( "ignoring error parameter\n" ); + + if (!reader || !pos) return E_INVALIDARG; + if (!reader->input_buf) return WS_E_INVALID_OPERATION; + + pos->buffer = (WS_XML_BUFFER *)reader->input_buf; + pos->node = reader->current; + return S_OK; +} diff --git a/dlls/webservices/tests/reader.c b/dlls/webservices/tests/reader.c index 4997f7a..a613fa2 100644 --- a/dlls/webservices/tests/reader.c +++ b/dlls/webservices/tests/reader.c @@ -3449,6 +3449,52 @@ static void test_WsResetError(void) WsFreeError( error ); } +static void test_WsGetReaderPosition(void) +{ + WS_HEAP *heap; + WS_XML_READER *reader; + WS_XML_BUFFER *buffer; + WS_XML_NODE_POSITION pos; + HRESULT hr; + + hr = WsGetReaderPosition( NULL, NULL, NULL ); + ok( hr == E_INVALIDARG, "got %08x\n", hr ); + + hr = WsCreateHeap( 1 << 16, 0, NULL, 0, &heap, NULL ); + ok( hr == S_OK, "got %08x\n", hr ); + + hr = WsCreateReader( NULL, 0, &reader, NULL ) ; + ok( hr == S_OK, "got %08x\n", hr ); + + /* reader must be set to an XML buffer */ + hr = WsGetReaderPosition( reader, &pos, NULL ); + ok( hr == WS_E_INVALID_OPERATION, "got %08x\n", hr ); + + hr = set_input( reader, "<t/>", sizeof("<t/>") - 1 ); + ok( hr == S_OK, "got %08x\n", hr ); + + hr = WsGetReaderPosition( reader, &pos, NULL ); + ok( hr == WS_E_INVALID_OPERATION, "got %08x\n", hr ); + + hr = WsCreateXmlBuffer( heap, NULL, 0, &buffer, NULL ); + ok( hr == S_OK, "got %08x\n", hr ); + + hr = WsSetInputToBuffer( reader, buffer, NULL, 0, NULL ); + ok( hr == S_OK, "got %08x\n", hr ); + + hr = WsGetReaderPosition( reader, NULL, NULL ); + ok( hr == E_INVALIDARG, "got %08x\n", hr ); + + pos.buffer = pos.node = NULL; + hr = WsGetReaderPosition( reader, &pos, NULL ); + ok( hr == S_OK, "got %08x\n", hr ); + ok( pos.buffer != NULL, "buffer not set\n" ); + ok( pos.node != NULL, "node not set\n" ); + + WsFreeReader( reader ); + WsFreeHeap( heap ); +} + START_TEST(reader) { test_WsCreateError(); @@ -3481,4 +3527,5 @@ START_TEST(reader) test_WsReadElement(); test_WsReadValue(); test_WsResetError(); + test_WsGetReaderPosition(); } diff --git a/dlls/webservices/webservices.spec b/dlls/webservices/webservices.spec index 3a69302..814788f 100644 --- a/dlls/webservices/webservices.spec +++ b/dlls/webservices/webservices.spec @@ -81,7 +81,7 @@ @ stub WsGetPolicyProperty @ stdcall WsGetPrefixFromNamespace(ptr ptr long ptr ptr) @ stdcall WsGetReaderNode(ptr ptr ptr) -@ stub WsGetReaderPosition +@ stdcall WsGetReaderPosition(ptr ptr ptr) @ stdcall WsGetReaderProperty(ptr long ptr long ptr) @ stub WsGetSecurityContextProperty @ stub WsGetSecurityTokenProperty

1 0

Hans Leidekker : webservices: Implement WsSetReaderPosition.
by Alexandre Julliard 04 Jul '16

04 Jul '16

Module: wine Branch: master Commit: f01a209e2b343f5105cdfa510adc0e08902a8945 URL: http://source.winehq.org/git/wine.git/?a=commit;h=f01a209e2b343f5105cdfa510… Author: Hans Leidekker <hans(a)codeweavers.com> Date: Mon Jul 4 11:35:39 2016 +0200 webservices: Implement WsSetReaderPosition. Signed-off-by: Hans Leidekker <hans(a)codeweavers.com> Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- dlls/webservices/reader.c | 17 ++++++++++++++ dlls/webservices/tests/reader.c | 48 +++++++++++++++++++++++++++++++++++++++ dlls/webservices/webservices.spec | 2 +- 3 files changed, 66 insertions(+), 1 deletion(-) diff --git a/dlls/webservices/reader.c b/dlls/webservices/reader.c index b326bd8..eb89af4 100644 --- a/dlls/webservices/reader.c +++ b/dlls/webservices/reader.c @@ -3979,3 +3979,20 @@ HRESULT WINAPI WsGetReaderPosition( WS_XML_READER *handle, WS_XML_NODE_POSITION pos->node = reader->current; return S_OK; } + +/************************************************************************** + * WsSetReaderPosition [webservices.@] + */ +HRESULT WINAPI WsSetReaderPosition( WS_XML_READER *handle, const WS_XML_NODE_POSITION *pos, WS_ERROR *error ) +{ + struct reader *reader = (struct reader *)handle; + + TRACE( "%p %p %p\n", handle, pos, error ); + if (error) FIXME( "ignoring error parameter\n" ); + + if (!reader || !pos || (struct xmlbuf *)pos->buffer != reader->input_buf) return E_INVALIDARG; + if (!reader->input_buf) return WS_E_INVALID_OPERATION; + + reader->current = pos->node; + return S_OK; +} diff --git a/dlls/webservices/tests/reader.c b/dlls/webservices/tests/reader.c index a613fa2..5c4770c 100644 --- a/dlls/webservices/tests/reader.c +++ b/dlls/webservices/tests/reader.c @@ -3495,6 +3495,53 @@ static void test_WsGetReaderPosition(void) WsFreeHeap( heap ); } +static void test_WsSetReaderPosition(void) +{ + WS_HEAP *heap; + WS_XML_READER *reader; + WS_XML_BUFFER *buf1, *buf2; + WS_XML_NODE_POSITION pos; + HRESULT hr; + + hr = WsCreateHeap( 1 << 16, 0, NULL, 0, &heap, NULL ); + ok( hr == S_OK, "got %08x\n", hr ); + + hr = WsSetReaderPosition( NULL, NULL, NULL ); + ok( hr == E_INVALIDARG, "got %08x\n", hr ); + + hr = WsCreateReader( NULL, 0, &reader, NULL ) ; + ok( hr == S_OK, "got %08x\n", hr ); + + hr = WsCreateXmlBuffer( heap, NULL, 0, &buf1, NULL ); + ok( hr == S_OK, "got %08x\n", hr ); + + hr = WsSetInputToBuffer( reader, buf1, NULL, 0, NULL ); + ok( hr == S_OK, "got %08x\n", hr ); + + hr = WsSetReaderPosition( reader, NULL, NULL ); + ok( hr == E_INVALIDARG, "got %08x\n", hr ); + + pos.buffer = pos.node = NULL; + hr = WsGetReaderPosition( reader, &pos, NULL ); + ok( hr == S_OK, "got %08x\n", hr ); + ok( pos.buffer == buf1, "wrong buffer\n" ); + ok( pos.node != NULL, "node not set\n" ); + + hr = WsSetReaderPosition( reader, &pos, NULL ); + ok( hr == S_OK, "got %08x\n", hr ); + + /* different buffer */ + hr = WsCreateXmlBuffer( heap, NULL, 0, &buf2, NULL ); + ok( hr == S_OK, "got %08x\n", hr ); + + pos.buffer = buf2; + hr = WsSetReaderPosition( reader, &pos, NULL ); + ok( hr == E_INVALIDARG, "got %08x\n", hr ); + + WsFreeReader( reader ); + WsFreeHeap( heap ); +} + START_TEST(reader) { test_WsCreateError(); @@ -3528,4 +3575,5 @@ START_TEST(reader) test_WsReadValue(); test_WsResetError(); test_WsGetReaderPosition(); + test_WsSetReaderPosition(); } diff --git a/dlls/webservices/webservices.spec b/dlls/webservices/webservices.spec index 814788f..3f7e644 100644 --- a/dlls/webservices/webservices.spec +++ b/dlls/webservices/webservices.spec @@ -156,7 +156,7 @@ @ stdcall WsSetMessageProperty(ptr long ptr long ptr) @ stdcall WsSetOutput(ptr ptr ptr ptr long ptr) @ stdcall WsSetOutputToBuffer(ptr ptr ptr long ptr) -@ stub WsSetReaderPosition +@ stdcall WsSetReaderPosition(ptr ptr ptr) @ stdcall WsSetWriterPosition(ptr ptr ptr) @ stub WsShutdownSessionChannel @ stub WsSkipNode

1 0

Hans Leidekker : webservices: Decode XML entities.
by Alexandre Julliard 04 Jul '16

04 Jul '16

Module: wine Branch: master Commit: f449b1324f4f71d73910190d4cb6866c06d527aa URL: http://source.winehq.org/git/wine.git/?a=commit;h=f449b1324f4f71d73910190d4… Author: Hans Leidekker <hans(a)codeweavers.com> Date: Mon Jul 4 11:35:40 2016 +0200 webservices: Decode XML entities. Signed-off-by: Hans Leidekker <hans(a)codeweavers.com> Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- dlls/webservices/reader.c | 136 +++++++++++++++++++++++++++++++++++++++- dlls/webservices/tests/reader.c | 115 +++++++++++++++++++++++++++++++++ 2 files changed, 248 insertions(+), 3 deletions(-) Diff: http://source.winehq.org/git/wine.git/?a=commitdiff;h=f449b1324f4f71d739101…

1 0