August 2016 - Wine-commits - list.winehq.org

Józef Kucia : wined3d: Fix window rect restoring.
by Alexandre Julliard 05 Aug '16

05 Aug '16

Module: wine Branch: master Commit: fb2540f8b18cc9c0856c9ccbe66305a4f8a6b3d8 URL: http://source.winehq.org/git/wine.git/?a=commit;h=fb2540f8b18cc9c0856c9ccbe… Author: Józef Kucia <jkucia(a)codeweavers.com> Date: Thu Aug 4 17:23:41 2016 +0200 wined3d: Fix window rect restoring. Signed-off-by: Józef Kucia <jkucia(a)codeweavers.com> Signed-off-by: Henri Verbeet <hverbeet(a)codeweavers.com> Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- dlls/wined3d/device.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/dlls/wined3d/device.c b/dlls/wined3d/device.c index 9a4f0d3..1bafd5e 100644 --- a/dlls/wined3d/device.c +++ b/dlls/wined3d/device.c @@ -954,7 +954,8 @@ void CDECL wined3d_device_restore_fullscreen_window(struct wined3d_device *devic rect = *window_rect; else window_pos_flags |= (SWP_NOMOVE | SWP_NOSIZE); - SetWindowPos(window, 0, rect.left, rect.top, rect.right, rect.bottom, window_pos_flags); + SetWindowPos(window, 0, rect.left, rect.top, + rect.right - rect.left, rect.bottom - rect.top, window_pos_flags); device->filter_messages = filter_messages;

1 0

Józef Kucia : wined3d: Introduce wined3d_swapchain_resize_target().
by Alexandre Julliard 05 Aug '16

05 Aug '16

Module: wine Branch: master Commit: 28f24b9ddf4f4cf848cdafa08508bc5b07a033c1 URL: http://source.winehq.org/git/wine.git/?a=commit;h=28f24b9ddf4f4cf848cdafa08… Author: Józef Kucia <jkucia(a)codeweavers.com> Date: Thu Aug 4 17:23:42 2016 +0200 wined3d: Introduce wined3d_swapchain_resize_target(). Signed-off-by: Józef Kucia <jkucia(a)codeweavers.com> Signed-off-by: Henri Verbeet <hverbeet(a)codeweavers.com> Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- dlls/wined3d/swapchain.c | 49 +++++++++++++++++++++++++++++++++++++++++++++++ dlls/wined3d/wined3d.spec | 1 + include/wine/wined3d.h | 2 ++ 3 files changed, 52 insertions(+) diff --git a/dlls/wined3d/swapchain.c b/dlls/wined3d/swapchain.c index 802e2bc..e405457 100644 --- a/dlls/wined3d/swapchain.c +++ b/dlls/wined3d/swapchain.c @@ -1397,6 +1397,55 @@ HRESULT CDECL wined3d_swapchain_resize_buffers(struct wined3d_swapchain *swapcha return WINED3D_OK; } +HRESULT CDECL wined3d_swapchain_resize_target(struct wined3d_swapchain *swapchain, + const struct wined3d_display_mode *mode) +{ + struct wined3d_device *device = swapchain->device; + struct wined3d_display_mode current_mode; + RECT original_window_rect, window_rect; + HRESULT hr; + + TRACE("swapchain %p, mode %p.\n", swapchain, mode); + + SetRect(&window_rect, 0, 0, mode->width, mode->height); + + if (swapchain->desc.windowed) + { + AdjustWindowRectEx(&window_rect, + GetWindowLongW(swapchain->device_window, GWL_STYLE), FALSE, + GetWindowLongW(swapchain->device_window, GWL_EXSTYLE)); + SetRect(&window_rect, 0, 0, + window_rect.right - window_rect.left, window_rect.bottom - window_rect.top); + GetWindowRect(swapchain->device_window, &original_window_rect); + OffsetRect(&window_rect, original_window_rect.left, original_window_rect.top); + } + else if (swapchain->desc.flags & WINED3D_SWAPCHAIN_ALLOW_MODE_SWITCH) + { + if (FAILED(hr = wined3d_set_adapter_display_mode(device->wined3d, device->adapter->ordinal, mode))) + { + WARN("Failed to set display mode, hr %#x.\n", hr); + return WINED3DERR_INVALIDCALL; + } + } + else + { + if (FAILED(hr = wined3d_get_adapter_display_mode(device->wined3d, device->adapter->ordinal, + &current_mode, NULL))) + { + ERR("Failed to get display mode, hr %#x.\n", hr); + return WINED3DERR_INVALIDCALL; + } + + SetRect(&window_rect, 0, 0, current_mode.width, current_mode.height); + } + + MoveWindow(swapchain->device_window, window_rect.left, window_rect.top, + window_rect.right - window_rect.left, + window_rect.bottom - window_rect.top, TRUE); + + return WINED3D_OK; +} + HRESULT CDECL wined3d_swapchain_set_fullscreen(struct wined3d_swapchain *swapchain, const struct wined3d_swapchain_desc *swapchain_desc, const struct wined3d_display_mode *mode) { diff --git a/dlls/wined3d/wined3d.spec b/dlls/wined3d/wined3d.spec index e0cc501..5b9b12b 100644 --- a/dlls/wined3d/wined3d.spec +++ b/dlls/wined3d/wined3d.spec @@ -242,6 +242,7 @@ @ cdecl wined3d_swapchain_incref(ptr) @ cdecl wined3d_swapchain_present(ptr ptr ptr ptr long) @ cdecl wined3d_swapchain_resize_buffers(ptr long long long long long long) +@ cdecl wined3d_swapchain_resize_target(ptr ptr) @ cdecl wined3d_swapchain_set_fullscreen(ptr ptr ptr) @ cdecl wined3d_swapchain_set_gamma_ramp(ptr long ptr) @ cdecl wined3d_swapchain_set_palette(ptr ptr) diff --git a/include/wine/wined3d.h b/include/wine/wined3d.h index 661191d..166fecc 100644 --- a/include/wine/wined3d.h +++ b/include/wine/wined3d.h @@ -2527,6 +2527,8 @@ HRESULT __cdecl wined3d_swapchain_present(struct wined3d_swapchain *swapchain, HRESULT __cdecl wined3d_swapchain_resize_buffers(struct wined3d_swapchain *swapchain, unsigned int buffer_count, unsigned int width, unsigned int height, enum wined3d_format_id format_id, enum wined3d_multisample_type multisample_type, unsigned int multisample_quality); +HRESULT __cdecl wined3d_swapchain_resize_target(struct wined3d_swapchain *swapchain, + const struct wined3d_display_mode *mode); HRESULT __cdecl wined3d_swapchain_set_fullscreen(struct wined3d_swapchain *swapchain, const struct wined3d_swapchain_desc *desc, const struct wined3d_display_mode *mode); HRESULT __cdecl wined3d_swapchain_set_gamma_ramp(const struct wined3d_swapchain *swapchain,

1 0

Józef Kucia : dxgi: Implement IDXGISwapChain_ResizeTarget().
by Alexandre Julliard 05 Aug '16

05 Aug '16

Module: wine Branch: master Commit: 537bd43ea843fb1419c1a744065c79ee185767e4 URL: http://source.winehq.org/git/wine.git/?a=commit;h=537bd43ea843fb1419c1a7440… Author: Józef Kucia <jkucia(a)codeweavers.com> Date: Thu Aug 4 17:23:43 2016 +0200 dxgi: Implement IDXGISwapChain_ResizeTarget(). Signed-off-by: Józef Kucia <jkucia(a)codeweavers.com> Signed-off-by: Henri Verbeet <hverbeet(a)codeweavers.com> Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- dlls/dxgi/dxgi_private.h | 4 ++++ dlls/dxgi/factory.c | 8 -------- dlls/dxgi/swapchain.c | 26 ++++++++++++++++++++++++-- dlls/dxgi/utils.c | 30 ++++++++++++++++++++++++++++++ 4 files changed, 58 insertions(+), 10 deletions(-) diff --git a/dlls/dxgi/dxgi_private.h b/dlls/dxgi/dxgi_private.h index 7148811..987370f1 100644 --- a/dlls/dxgi/dxgi_private.h +++ b/dlls/dxgi/dxgi_private.h @@ -79,10 +79,14 @@ struct dxgi_device_layer /* TRACE helper functions */ const char *debug_dxgi_format(DXGI_FORMAT format) DECLSPEC_HIDDEN; +const char *debug_dxgi_mode(const DXGI_MODE_DESC *desc) DECLSPEC_HIDDEN; void dump_feature_levels(const D3D_FEATURE_LEVEL *feature_levels, unsigned int level_count) DECLSPEC_HIDDEN; DXGI_FORMAT dxgi_format_from_wined3dformat(enum wined3d_format_id format) DECLSPEC_HIDDEN; enum wined3d_format_id wined3dformat_from_dxgi_format(DXGI_FORMAT format) DECLSPEC_HIDDEN; +UINT dxgi_rational_to_uint(const DXGI_RATIONAL *rational) DECLSPEC_HIDDEN; +enum wined3d_scanline_ordering wined3d_scanline_ordering_from_dxgi( + DXGI_MODE_SCANLINE_ORDER scanline_order) DECLSPEC_HIDDEN; void dxgi_sample_desc_from_wined3d(DXGI_SAMPLE_DESC *desc, enum wined3d_multisample_type wined3d_type, unsigned int wined3d_quality) DECLSPEC_HIDDEN; void wined3d_sample_desc_from_dxgi(enum wined3d_multisample_type *wined3d_type, diff --git a/dlls/dxgi/factory.c b/dlls/dxgi/factory.c index 3aa8597..d54eea9 100644 --- a/dlls/dxgi/factory.c +++ b/dlls/dxgi/factory.c @@ -180,14 +180,6 @@ static HRESULT STDMETHODCALLTYPE dxgi_factory_GetWindowAssociation(IDXGIFactory1 return E_NOTIMPL; } -static UINT dxgi_rational_to_uint(const DXGI_RATIONAL *rational) -{ - if (rational->Denominator) - return rational->Numerator / rational->Denominator; - else - return rational->Numerator; -} - static HRESULT STDMETHODCALLTYPE dxgi_factory_CreateSwapChain(IDXGIFactory1 *iface, IUnknown *device, DXGI_SWAP_CHAIN_DESC *desc, IDXGISwapChain **swapchain) { diff --git a/dlls/dxgi/swapchain.c b/dlls/dxgi/swapchain.c index 869c799..172b0f4 100644 --- a/dlls/dxgi/swapchain.c +++ b/dlls/dxgi/swapchain.c @@ -337,9 +337,31 @@ static HRESULT STDMETHODCALLTYPE dxgi_swapchain_ResizeBuffers(IDXGISwapChain *if static HRESULT STDMETHODCALLTYPE dxgi_swapchain_ResizeTarget(IDXGISwapChain *iface, const DXGI_MODE_DESC *target_mode_desc) { - FIXME("iface %p, target_mode_desc %p stub!\n", iface, target_mode_desc); + struct dxgi_swapchain *swapchain = impl_from_IDXGISwapChain(iface); + struct wined3d_display_mode mode; + HRESULT hr; - return E_NOTIMPL; + TRACE("iface %p, target_mode_desc %p.\n", iface, target_mode_desc); + + if (!target_mode_desc) + return DXGI_ERROR_INVALID_CALL; + + TRACE("Mode: %s.\n", debug_dxgi_mode(target_mode_desc)); + + if (target_mode_desc->Scaling) + FIXME("Ignoring scaling %#x.\n", target_mode_desc->Scaling); + + mode.width = target_mode_desc->Width; + mode.height = target_mode_desc->Height; + mode.refresh_rate = dxgi_rational_to_uint(&target_mode_desc->RefreshRate); + mode.format_id = wined3dformat_from_dxgi_format(target_mode_desc->Format); + mode.scanline_ordering = wined3d_scanline_ordering_from_dxgi(target_mode_desc->ScanlineOrdering); + + wined3d_mutex_lock(); + hr = wined3d_swapchain_resize_target(swapchain->wined3d_swapchain, &mode); + wined3d_mutex_unlock(); + + return hr; } static HRESULT STDMETHODCALLTYPE dxgi_swapchain_GetContainingOutput(IDXGISwapChain *iface, IDXGIOutput **output) diff --git a/dlls/dxgi/utils.c b/dlls/dxgi/utils.c index 5c6c5bd..9371de1 100644 --- a/dlls/dxgi/utils.c +++ b/dlls/dxgi/utils.c @@ -364,6 +364,14 @@ enum wined3d_format_id wined3dformat_from_dxgi_format(DXGI_FORMAT format) } } +const char *debug_dxgi_mode(const DXGI_MODE_DESC *desc) +{ + return wine_dbg_sprintf("resolution %ux%u, refresh rate %u / %u, " + "format %s, scanline ordering %#x, scaling %#x", + desc->Width, desc->Height, desc->RefreshRate.Numerator, desc->RefreshRate.Denominator, + debug_dxgi_format(desc->Format), desc->ScanlineOrdering, desc->Scaling); +} + void dump_feature_levels(const D3D_FEATURE_LEVEL *feature_levels, unsigned int level_count) { unsigned int i; @@ -379,6 +387,28 @@ void dump_feature_levels(const D3D_FEATURE_LEVEL *feature_levels, unsigned int l TRACE(" [%u] = %s.\n", i, debug_feature_level(feature_levels[i])); } +UINT dxgi_rational_to_uint(const DXGI_RATIONAL *rational) +{ + if (rational->Denominator) + return rational->Numerator / rational->Denominator; + else + return rational->Numerator; +} + +enum wined3d_scanline_ordering wined3d_scanline_ordering_from_dxgi(DXGI_MODE_SCANLINE_ORDER scanline_order) +{ + switch (scanline_order) + { + case DXGI_MODE_SCANLINE_ORDER_UNSPECIFIED: + return WINED3D_SCANLINE_ORDERING_UNKNOWN; + case DXGI_MODE_SCANLINE_ORDER_PROGRESSIVE: + return WINED3D_SCANLINE_ORDERING_PROGRESSIVE; + default: + FIXME("Unhandled scanline ordering %#x.\n", scanline_order); + return WINED3D_SCANLINE_ORDERING_UNKNOWN; + } +} + void dxgi_sample_desc_from_wined3d(DXGI_SAMPLE_DESC *desc, enum wined3d_multisample_type wined3d_type, unsigned int wined3d_quality) {

1 0

Józef Kucia : dxgi/tests: Add test for IDXGISwapChain_ResizeTarget().
by Alexandre Julliard 05 Aug '16

05 Aug '16

Module: wine Branch: master Commit: 37661a3bd192b9c24f0d15650554429703bb8259 URL: http://source.winehq.org/git/wine.git/?a=commit;h=37661a3bd192b9c24f0d15650… Author: Józef Kucia <jkucia(a)codeweavers.com> Date: Thu Aug 4 17:35:56 2016 +0200 dxgi/tests: Add test for IDXGISwapChain_ResizeTarget(). Signed-off-by: Józef Kucia <jkucia(a)codeweavers.com> Signed-off-by: Henri Verbeet <hverbeet(a)codeweavers.com> Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- dlls/dxgi/tests/device.c | 369 +++++++++++++++++++++++++++++++++++++++-------- 1 file changed, 312 insertions(+), 57 deletions(-) Diff: http://source.winehq.org/git/wine.git/?a=commitdiff;h=37661a3bd192b9c24f0d1…

1 0

Michael Stefaniuc : d3d10core/tests: Make use of todo_wine_if().
by Alexandre Julliard 05 Aug '16

05 Aug '16

Module: wine Branch: master Commit: e75df0210465f483521489717bf5bc9ae80f2fea URL: http://source.winehq.org/git/wine.git/?a=commit;h=e75df0210465f483521489717… Author: Michael Stefaniuc <mstefani(a)redhat.de> Date: Thu Aug 4 23:42:03 2016 +0200 d3d10core/tests: Make use of todo_wine_if(). Signed-off-by: Michael Stefaniuc <mstefani(a)redhat.de> Signed-off-by: Henri Verbeet <hverbeet(a)codeweavers.com> Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- dlls/d3d10core/tests/device.c | 14 ++------------ 1 file changed, 2 insertions(+), 12 deletions(-) diff --git a/dlls/d3d10core/tests/device.c b/dlls/d3d10core/tests/device.c index f3c4ac8..e574005 100644 --- a/dlls/d3d10core/tests/device.c +++ b/dlls/d3d10core/tests/device.c @@ -4648,11 +4648,7 @@ float4 main(float4 color : COLOR) : SV_TARGET ID3D10Device_RSGetScissorRects(device, &count, tmp_rect); for (i = 0; i < D3D10_VIEWPORT_AND_SCISSORRECT_OBJECT_COUNT_PER_PIPELINE; ++i) { - if (!i) - todo_wine ok(!tmp_rect[i].left && !tmp_rect[i].top && !tmp_rect[i].right && !tmp_rect[i].bottom, - "Got unexpected scissor rect %s in slot %u.\n", - wine_dbgstr_rect(&tmp_rect[i]), i); - else + todo_wine_if(!i) ok(!tmp_rect[i].left && !tmp_rect[i].top && !tmp_rect[i].right && !tmp_rect[i].bottom, "Got unexpected scissor rect %s in slot %u.\n", wine_dbgstr_rect(&tmp_rect[i]), i); @@ -4664,13 +4660,7 @@ float4 main(float4 color : COLOR) : SV_TARGET ID3D10Device_RSGetViewports(device, &count, tmp_viewport); for (i = 0; i < D3D10_VIEWPORT_AND_SCISSORRECT_OBJECT_COUNT_PER_PIPELINE; ++i) { - if (!i) - todo_wine ok(!tmp_viewport[i].TopLeftX && !tmp_viewport[i].TopLeftY && !tmp_viewport[i].Width - && !tmp_viewport[i].Height && !tmp_viewport[i].MinDepth && !tmp_viewport[i].MaxDepth, - "Got unexpected viewport {%d, %d, %u, %u, %.8e, %.8e} in slot %u.\n", - tmp_viewport[i].TopLeftX, tmp_viewport[i].TopLeftY, tmp_viewport[i].Width, - tmp_viewport[i].Height, tmp_viewport[i].MinDepth, tmp_viewport[i].MaxDepth, i); - else + todo_wine_if(!i) ok(!tmp_viewport[i].TopLeftX && !tmp_viewport[i].TopLeftY && !tmp_viewport[i].Width && !tmp_viewport[i].Height && !tmp_viewport[i].MinDepth && !tmp_viewport[i].MaxDepth, "Got unexpected viewport {%d, %d, %u, %u, %.8e, %.8e} in slot %u.\n",

1 0

Michael Stefaniuc : mmdevapi/tests: Make use of todo_wine_if().
by Alexandre Julliard 05 Aug '16

05 Aug '16

Module: wine Branch: master Commit: d7b7bdae1db7baee933cb2a3aa6e6c64ea405734 URL: http://source.winehq.org/git/wine.git/?a=commit;h=d7b7bdae1db7baee933cb2a3a… Author: Michael Stefaniuc <mstefani(a)redhat.de> Date: Thu Aug 4 23:43:27 2016 +0200 mmdevapi/tests: Make use of todo_wine_if(). Signed-off-by: Michael Stefaniuc <mstefani(a)redhat.de> Signed-off-by: Andrew Eikum <aeikum(a)codeweavers.com> Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- dlls/mmdevapi/tests/capture.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/dlls/mmdevapi/tests/capture.c b/dlls/mmdevapi/tests/capture.c index e68c38d..749272a 100644 --- a/dlls/mmdevapi/tests/capture.c +++ b/dlls/mmdevapi/tests/capture.c @@ -244,10 +244,8 @@ static void test_capture(IAudioClient *ac, HANDLE handle, WAVEFORMATEX *wfx) ok(hr == S_OK, "Valid IAudioCaptureClient_GetBuffer returns %08x\n", hr); ok(frames2 == frames, "GetBuffer after ReleaseBuffer(0) %u/%u\n", frames2, frames); ok(pos2 == pos, "Position after ReleaseBuffer(0) %u/%u\n", (UINT)pos2, (UINT)pos); - if(qpc2 != qpc) + todo_wine_if(qpc2 != qpc) /* FIXME: Some drivers fail */ - todo_wine ok(qpc2 == qpc, "HPC after ReleaseBuffer(0) %u vs. %u\n", (UINT)qpc2, (UINT)qpc); - else ok(qpc2 == qpc, "HPC after ReleaseBuffer(0) %u vs. %u\n", (UINT)qpc2, (UINT)qpc); }

1 0

Michael Stefaniuc : comctl32/tests: Make use of todo_wine_if().
by Alexandre Julliard 04 Aug '16

04 Aug '16

Module: wine Branch: master Commit: ce17196995dd1a065c80e756eedc2c2421f65053 URL: http://source.winehq.org/git/wine.git/?a=commit;h=ce17196995dd1a065c80e756e… Author: Michael Stefaniuc <mstefani(a)redhat.de> Date: Thu Aug 4 23:39:25 2016 +0200 comctl32/tests: Make use of todo_wine_if(). Signed-off-by: Michael Stefaniuc <mstefani(a)redhat.de> Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- dlls/comctl32/tests/listview.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/dlls/comctl32/tests/listview.c b/dlls/comctl32/tests/listview.c index 811800c..ec87e3b 100644 --- a/dlls/comctl32/tests/listview.c +++ b/dlls/comctl32/tests/listview.c @@ -1830,9 +1830,7 @@ static LRESULT WINAPI cd_wndproc(HWND hwnd, UINT message, WPARAM wParam, LPARAM clr = GetBkColor(nmlvcd->nmcd.hdc); ok(nmlvcd->clrTextBk == CLR_DEFAULT, "got 0x%x\n", nmlvcd->clrTextBk); ok(nmlvcd->clrText == RGB(0, 255, 0), "got 0x%x\n", nmlvcd->clrText); - if (nmlvcd->iSubItem) - todo_wine ok(clr == c0ffee, "clr=%.8x\n", clr); - else + todo_wine_if(nmlvcd->iSubItem) ok(clr == c0ffee, "clr=%.8x\n", clr); return CDRF_NOTIFYPOSTPAINT; case CDDS_ITEMPOSTPAINT | CDDS_SUBITEM:

1 0

Michael Stefaniuc : user32/tests: Make use of todo_wine_if().
by Alexandre Julliard 04 Aug '16

04 Aug '16

Module: wine Branch: master Commit: c80ba5386443f664a19b5ecbf18d091f1cc8b2be URL: http://source.winehq.org/git/wine.git/?a=commit;h=c80ba5386443f664a19b5ecbf… Author: Michael Stefaniuc <mstefani(a)redhat.de> Date: Thu Aug 4 23:45:19 2016 +0200 user32/tests: Make use of todo_wine_if(). Signed-off-by: Michael Stefaniuc <mstefani(a)redhat.de> Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- dlls/user32/tests/msg.c | 6 +----- 1 file changed, 1 insertion(+), 5 deletions(-) diff --git a/dlls/user32/tests/msg.c b/dlls/user32/tests/msg.c index 2823f06..07d10b4 100644 --- a/dlls/user32/tests/msg.c +++ b/dlls/user32/tests/msg.c @@ -12125,11 +12125,7 @@ static void test_ShowWindow(void) "expected %d,%d got %d,%d\n", sw[i].wp_min.x, sw[i].wp_min.y, wp.ptMinPosition.x, wp.ptMinPosition.y); } - if (wp.ptMaxPosition.x != sw[i].wp_max.x || wp.ptMaxPosition.y != sw[i].wp_max.y) - todo_wine - ok(wp.ptMaxPosition.x == sw[i].wp_max.x && wp.ptMaxPosition.y == sw[i].wp_max.y, - "expected %d,%d got %d,%d\n", sw[i].wp_max.x, sw[i].wp_max.y, wp.ptMaxPosition.x, wp.ptMaxPosition.y); - else + todo_wine_if(wp.ptMaxPosition.x != sw[i].wp_max.x || wp.ptMaxPosition.y != sw[i].wp_max.y) ok(wp.ptMaxPosition.x == sw[i].wp_max.x && wp.ptMaxPosition.y == sw[i].wp_max.y, "expected %d,%d got %d,%d\n", sw[i].wp_max.x, sw[i].wp_max.y, wp.ptMaxPosition.x, wp.ptMaxPosition.y);

1 0

Michael Stefaniuc : urlmon/tests: Make use of todo_wine_if().
by Alexandre Julliard 04 Aug '16

04 Aug '16

Module: wine Branch: master Commit: 0b49495b8ed9e725b47b7ca791312a2a3c3e3c97 URL: http://source.winehq.org/git/wine.git/?a=commit;h=0b49495b8ed9e725b47b7ca79… Author: Michael Stefaniuc <mstefani(a)redhat.de> Date: Thu Aug 4 23:46:30 2016 +0200 urlmon/tests: Make use of todo_wine_if(). Signed-off-by: Michael Stefaniuc <mstefani(a)redhat.de> Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- dlls/urlmon/tests/protocol.c | 4 +--- dlls/urlmon/tests/url.c | 8 ++------ 2 files changed, 3 insertions(+), 9 deletions(-) diff --git a/dlls/urlmon/tests/protocol.c b/dlls/urlmon/tests/protocol.c index a55db96..dad87ed 100644 --- a/dlls/urlmon/tests/protocol.c +++ b/dlls/urlmon/tests/protocol.c @@ -2574,9 +2574,7 @@ static void test_file_protocol_url(LPCWSTR url) hres = IInternetProtocol_UnlockRequest(protocol); ok(hres == S_OK, "UnlockRequest failed: %08x\n", hres); hres = IInternetProtocol_Read(protocol, buf, 2, &cb); - if(file_with_hash) /* FIXME: An effect of UnlockRequest call? */ - todo_wine ok(hres == S_OK, "Read failed: %08x\n", hres); - else + todo_wine_if(file_with_hash) /* FIXME: An effect of UnlockRequest call? */ ok(hres == S_OK, "Read failed: %08x\n", hres); hres = IInternetProtocol_Terminate(protocol, 0); ok(hres == S_OK, "Terminate failed: %08x\n", hres); diff --git a/dlls/urlmon/tests/url.c b/dlls/urlmon/tests/url.c index ad27c3d..4fa11c7 100644 --- a/dlls/urlmon/tests/url.c +++ b/dlls/urlmon/tests/url.c @@ -3087,14 +3087,10 @@ static void test_BindToStorage(int protocol, DWORD flags, DWORD t) if(!no_callback) { CLEAR_CALLED(QueryInterface_IBindStatusCallbackEx); /* IE 8 */ CHECK_CALLED(GetBindInfo); - if(abort_start) - todo_wine CHECK_CALLED(QueryInterface_IInternetProtocol); - else + todo_wine_if(abort_start) CHECK_CALLED(QueryInterface_IInternetProtocol); if(!emulate_protocol) { - if(abort_start) - todo_wine CHECK_CALLED(QueryService_IInternetProtocol); - else + todo_wine_if(abort_start) CHECK_CALLED(QueryService_IInternetProtocol); } CHECK_CALLED(OnStartBinding);

1 0

Nikolay Sivov : comctl32/listview: Return earlier on allocation failure ( Coverity).
by Alexandre Julliard 04 Aug '16

04 Aug '16

Module: wine Branch: master Commit: 622a24046f9c06078e1e7b27726f90b6fa9b1e0f URL: http://source.winehq.org/git/wine.git/?a=commit;h=622a24046f9c06078e1e7b277… Author: Nikolay Sivov <nsivov(a)codeweavers.com> Date: Thu Aug 4 10:57:47 2016 +0300 comctl32/listview: Return earlier on allocation failure (Coverity). Signed-off-by: Nikolay Sivov <nsivov(a)codeweavers.com> Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- dlls/comctl32/listview.c | 14 ++++++++------ 1 file changed, 8 insertions(+), 6 deletions(-) diff --git a/dlls/comctl32/listview.c b/dlls/comctl32/listview.c index 6ab360b..cc1721b 100644 --- a/dlls/comctl32/listview.c +++ b/dlls/comctl32/listview.c @@ -5863,13 +5863,15 @@ static BOOL LISTVIEW_EndEditLabelT(LISTVIEW_INFO *infoPtr, BOOL storeText, BOOL { DWORD len = isW ? GetWindowTextLengthW(infoPtr->hwndEdit) : GetWindowTextLengthA(infoPtr->hwndEdit); - if (len) + if (len++) { - if ((pszText = Alloc((len+1) * (isW ? sizeof(WCHAR) : sizeof(CHAR))))) - { - if (isW) GetWindowTextW(infoPtr->hwndEdit, pszText, len+1); - else GetWindowTextA(infoPtr->hwndEdit, (CHAR*)pszText, len+1); - } + if (!(pszText = Alloc(len * (isW ? sizeof(WCHAR) : sizeof(CHAR))))) + return FALSE; + + if (isW) + GetWindowTextW(infoPtr->hwndEdit, pszText, len); + else + GetWindowTextA(infoPtr->hwndEdit, (CHAR*)pszText, len); } }

1 0