March 2018 - Wine-commits - list.winehq.org

Jacek Caban : mshtml: Use nsIDOMEvent directly to prevent default event handling in dispatch_event_object.
by Alexandre Julliard 08 Mar '18

08 Mar '18

Module: wine Branch: master Commit: 39766bcded650cec23c0c288dde12fe1e46e43cc URL: https://source.winehq.org/git/wine.git/?a=commit;h=39766bcded650cec23c0c288… Author: Jacek Caban <jacek(a)codeweavers.com> Date: Thu Mar 8 08:56:28 2018 -0600 mshtml: Use nsIDOMEvent directly to prevent default event handling in dispatch_event_object. Signed-off-by: Jacek Caban <jacek(a)codeweavers.com> Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- dlls/mshtml/htmlevent.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/dlls/mshtml/htmlevent.c b/dlls/mshtml/htmlevent.c index 3e0dfa5..dd63b39 100644 --- a/dlls/mshtml/htmlevent.c +++ b/dlls/mshtml/htmlevent.c @@ -2593,8 +2593,8 @@ static HRESULT dispatch_event_object(EventTarget *event_target, DOMEvent *event, } if(event->event_id != EVENTID_LAST && (event_info[event->event_id].flags & EVENT_HASDEFAULTHANDLERS)) { - for(i = 0; !event->prevent_default && i < chain_cnt; i++) { - BOOL prevent_default = FALSE; + BOOL prevent_default = event->prevent_default; + for(i = 0; !prevent_default && i < chain_cnt; i++) { vtbl = dispex_get_vtbl(&target_chain[i]->dispex); if(!vtbl || !vtbl->handle_event_default) continue; @@ -2603,7 +2603,7 @@ static HRESULT dispatch_event_object(EventTarget *event_target, DOMEvent *event, if(FAILED(hres) || event->stop_propagation) break; if(prevent_default) - IDOMEvent_preventDefault(&event->IDOMEvent_iface); + nsIDOMEvent_PreventDefault(event->nsevent); } }

1 0

Jacek Caban : mshtml/tests: Added more IDOMEvent::preventDefault tests.
by Alexandre Julliard 08 Mar '18

08 Mar '18

Module: wine Branch: master Commit: e36b765be44e1f76508648da6f9673057aeaf335 URL: https://source.winehq.org/git/wine.git/?a=commit;h=e36b765be44e1f76508648da… Author: Jacek Caban <jacek(a)codeweavers.com> Date: Thu Mar 8 08:56:38 2018 -0600 mshtml/tests: Added more IDOMEvent::preventDefault tests. Signed-off-by: Jacek Caban <jacek(a)codeweavers.com> Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- dlls/mshtml/tests/events.js | 14 ++++++++++++++ 1 file changed, 14 insertions(+) diff --git a/dlls/mshtml/tests/events.js b/dlls/mshtml/tests/events.js index 3836e13..dc9ce5a 100644 --- a/dlls/mshtml/tests/events.js +++ b/dlls/mshtml/tests/events.js @@ -358,6 +358,7 @@ function test_prevent_default() { elem.onclick = function(event) { event.preventDefault(); + ok(event.defaultPrevented === false, "defaultPrevented"); } e = document.createEvent("Event"); e.initEvent("click", true, false); @@ -372,6 +373,19 @@ function test_prevent_default() { r = elem.dispatchEvent(e); ok(r === true, "dispatchEvent returned " + r); + e = document.createEvent("Event"); + e.initEvent("click", false, true); + e.preventDefault(); + ok(e.defaultPrevented === false, "defaultPrevented = " + e.defaultPrevented); + + e = document.createEvent("Event"); + e.initEvent("click", false, true); + elem.onclick = null; + r = elem.dispatchEvent(e); + ok(r === true, "dispatchEvent returned " + r); + e.preventDefault(); + ok(e.defaultPrevented === false, "defaultPrevented = " + e.defaultPrevented); + next_test(); }

1 0

Anton Romanov : wmp: Add IWMPMedia stub.
by Alexandre Julliard 08 Mar '18

08 Mar '18

Module: wine Branch: master Commit: 9a89db9897eec5b3e0e7e6e5e33f7261f503f765 URL: https://source.winehq.org/git/wine.git/?a=commit;h=9a89db9897eec5b3e0e7e6e5… Author: Anton Romanov <theli.ua(a)gmail.com> Date: Thu Mar 8 08:42:07 2018 -0800 wmp: Add IWMPMedia stub. Signed-off-by: Anton Romanov <theli.ua(a)gmail.com> Signed-off-by: Jacek Caban <jacek(a)codeweavers.com> Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- dlls/wmp/oleobj.c | 1 + dlls/wmp/player.c | 293 +++++++++++++++++++++++++++++++++++++++++++-- dlls/wmp/tests/Makefile.in | 3 + dlls/wmp/tests/av.mp4 | Bin 0 -> 1493 bytes dlls/wmp/tests/oleobj.c | 86 +++++++++++++ dlls/wmp/tests/rsrc.rc | 22 ++++ dlls/wmp/wmp_private.h | 29 +++++ 7 files changed, 426 insertions(+), 8 deletions(-) Diff: https://source.winehq.org/git/wine.git/?a=commitdiff;h=9a89db9897eec5b3e0e7…

1 0

Anton Romanov : wmp: Add IWMPNetwork stub.
by Alexandre Julliard 08 Mar '18

08 Mar '18

Module: wine Branch: master Commit: 0c58f0ed39fa3bfb4c246e603d9b1a4999625704 URL: https://source.winehq.org/git/wine.git/?a=commit;h=0c58f0ed39fa3bfb4c246e60… Author: Anton Romanov <theli.ua(a)gmail.com> Date: Thu Mar 8 08:42:08 2018 -0800 wmp: Add IWMPNetwork stub. Signed-off-by: Anton Romanov <theli.ua(a)gmail.com> Signed-off-by: Jacek Caban <jacek(a)codeweavers.com> Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- dlls/wmp/player.c | 308 +++++++++++++++++++++++++++++++++++++++++++++++- dlls/wmp/tests/oleobj.c | 14 +++ dlls/wmp/wmp_private.h | 1 + 3 files changed, 321 insertions(+), 2 deletions(-) Diff: https://source.winehq.org/git/wine.git/?a=commitdiff;h=0c58f0ed39fa3bfb4c24…

1 0

Johann Frei : dinput: Implement X/Y axis granularity and add test.
by Alexandre Julliard 08 Mar '18

08 Mar '18

Module: wine Branch: master Commit: 4bc1e172ecba43dd8a5eb341cdd8e705a314b44d URL: https://source.winehq.org/git/wine.git/?a=commit;h=4bc1e172ecba43dd8a5eb341… Author: Johann Frei <johann_frei(a)yahoo.de> Date: Tue Mar 6 20:03:41 2018 +0100 dinput: Implement X/Y axis granularity and add test. Signed-off-by: Johann Frei <johann_frei(a)yahoo.de> Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- dlls/dinput/mouse.c | 17 +++++++++++++++-- dlls/dinput/tests/mouse.c | 23 ++++++++++++++++++++++- 2 files changed, 37 insertions(+), 3 deletions(-) diff --git a/dlls/dinput/mouse.c b/dlls/dinput/mouse.c index eaec6b1..6d3eff5 100644 --- a/dlls/dinput/mouse.c +++ b/dlls/dinput/mouse.c @@ -616,8 +616,21 @@ static HRESULT WINAPI SysMouseWImpl_GetProperty(LPDIRECTINPUTDEVICE8W iface, REF case (DWORD_PTR) DIPROP_GRANULARITY: { LPDIPROPDWORD pr = (LPDIPROPDWORD) pdiph; - /* We'll just assume that the app asks about the Z axis */ - pr->dwData = WHEEL_DELTA; + if ( + ((pdiph->dwHow == DIPH_BYOFFSET) && + ((pdiph->dwObj == DIMOFS_X) || + (pdiph->dwObj == DIMOFS_Y))) + || + ((pdiph->dwHow == DIPH_BYID) && + ((pdiph->dwObj == (DIDFT_MAKEINSTANCE(WINE_MOUSE_X_AXIS_INSTANCE) | DIDFT_RELAXIS)) || + (pdiph->dwObj == (DIDFT_MAKEINSTANCE(WINE_MOUSE_Y_AXIS_INSTANCE) | DIDFT_RELAXIS)))) + ){ + /* Set granularity of X/Y Axis to 1. See MSDN on DIPROP_GRANULARITY */ + pr->dwData = 1; + } else { + /* We'll just assume that the app asks about the Z axis */ + pr->dwData = WHEEL_DELTA; + } break; } diff --git a/dlls/dinput/tests/mouse.c b/dlls/dinput/tests/mouse.c index dac7d8d..c2d0226 100644 --- a/dlls/dinput/tests/mouse.c +++ b/dlls/dinput/tests/mouse.c @@ -161,7 +161,7 @@ static void test_acquire(IDirectInputA *pDI, HWND hwnd) hr = IDirectInputDevice_GetDeviceData(pMouse, sizeof(mouse_state), &mouse_state, &cnt, 0); ok(hr == S_OK && cnt > 0, "GetDeviceData() failed: %08x cnt:%d\n", hr, cnt); - /* Check for buffer owerflow */ + /* Check for buffer overflow */ for (i = 0; i < 6; i++) mouse_event(MOUSEEVENTF_MOVE, 10 + i, 10 + i, 0, 0); @@ -172,6 +172,27 @@ static void test_acquire(IDirectInputA *pDI, HWND hwnd) hr = IDirectInputDevice_GetDeviceData(pMouse, sizeof(mouse_state), &mouse_state, &cnt, 0); ok(hr == DI_OK && cnt == 1, "GetDeviceData() failed: %08x cnt:%d\n", hr, cnt); + /* Check for granularity property using BYOFFSET */ + memset(&di_op, 0, sizeof(di_op)); + di_op.diph.dwHow = DIPH_BYOFFSET; + di_op.diph.dwObj = DIMOFS_Y; + di_op.diph.dwSize = sizeof(DIPROPDWORD); + di_op.diph.dwHeaderSize = sizeof(DIPROPHEADER); + hr = IDirectInputDevice_GetProperty(pMouse, DIPROP_GRANULARITY, &di_op.diph); + /* Granularity of Y axis should be 1! */ + ok(hr == S_OK && di_op.dwData == 1, "GetProperty(): %08x, dwData: %i but should be 1.\n", hr, di_op.dwData); + + /* Check for granularity property using BYID */ + memset(&di_op, 0, sizeof(di_op)); + di_op.diph.dwHow = DIPH_BYID; + /* WINE_MOUSE_Y_AXIS_INSTANCE := 1 */ + di_op.diph.dwObj = (DIDFT_MAKEINSTANCE(1) | DIDFT_RELAXIS); + di_op.diph.dwSize = sizeof(DIPROPDWORD); + di_op.diph.dwHeaderSize = sizeof(DIPROPHEADER); + hr = IDirectInputDevice_GetProperty(pMouse, DIPROP_GRANULARITY, &di_op.diph); + /* Granularity of Y axis should be 1! */ + ok(hr == S_OK && di_op.dwData == 1, "GetProperty(): %08x, dwData: %i but should be 1.\n", hr, di_op.dwData); + if (pMouse) IUnknown_Release(pMouse); DestroyWindow( hwnd2 );

1 0

Andrew Wesie : ntdll: Implement NtCreateThreadEx.
by Alexandre Julliard 08 Mar '18

08 Mar '18

Module: wine Branch: master Commit: 4fda0463237d395fbee5d955e72a7c13ed125416 URL: https://source.winehq.org/git/wine.git/?a=commit;h=4fda0463237d395fbee5d955… Author: Andrew Wesie <awesie(a)gmail.com> Date: Tue Mar 6 03:10:30 2018 +0000 ntdll: Implement NtCreateThreadEx. Signed-off-by: Andrew Wesie <awesie(a)gmail.com> Signed-off-by: Alistair Leslie-Hughes <leslie_alistair(a)hotmail.com> Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- dlls/ntdll/ntdll.spec | 1 + dlls/ntdll/thread.c | 17 +++++++++++++++++ include/winternl.h | 7 +++++++ 3 files changed, 25 insertions(+) diff --git a/dlls/ntdll/ntdll.spec b/dlls/ntdll/ntdll.spec index 6e996a5..b63e335 100644 --- a/dlls/ntdll/ntdll.spec +++ b/dlls/ntdll/ntdll.spec @@ -152,6 +152,7 @@ @ stdcall NtCreateSemaphore(ptr long ptr long long) @ stdcall NtCreateSymbolicLinkObject(ptr long ptr ptr) @ stub NtCreateThread +@ stdcall NtCreateThreadEx(ptr long ptr long ptr ptr long long long long ptr) @ stdcall NtCreateTimer(ptr long ptr long) @ stub NtCreateToken # @ stub NtCreateWaitablePort diff --git a/dlls/ntdll/thread.c b/dlls/ntdll/thread.c index 9ec94d6..35e23d2 100644 --- a/dlls/ntdll/thread.c +++ b/dlls/ntdll/thread.c @@ -525,6 +525,23 @@ static void start_thread( struct startup_info *info ) /*********************************************************************** + * NtCreateThreadEx (NTDLL.@) + */ +NTSTATUS WINAPI NtCreateThreadEx( HANDLE *handle_ptr, ACCESS_MASK access, OBJECT_ATTRIBUTES *attr, + HANDLE process, LPTHREAD_START_ROUTINE start, void *param, + ULONG flags, ULONG zero_bits, ULONG stack_commit, + ULONG stack_reserve, void *attribute_list ) +{ + FIXME( "%p, %x, %p, %p, %p, %p, %x, %x, %x, %x, %p semi-stub!\n", handle_ptr, access, attr, + process, start, param, flags, zero_bits, stack_commit, stack_reserve, attribute_list ); + + return RtlCreateUserThread( process, NULL, flags & THREAD_CREATE_FLAGS_CREATE_SUSPENDED, + NULL, stack_reserve, stack_commit, (PRTL_THREAD_START_ROUTINE)start, + param, handle_ptr, NULL ); +} + + +/*********************************************************************** * RtlCreateUserThread (NTDLL.@) */ NTSTATUS WINAPI RtlCreateUserThread( HANDLE process, const SECURITY_DESCRIPTOR *descr, diff --git a/include/winternl.h b/include/winternl.h index 6733977..98bf201 100644 --- a/include/winternl.h +++ b/include/winternl.h @@ -2200,6 +2200,13 @@ typedef struct _SYSTEM_MODULE_INFORMATION SYSTEM_MODULE Modules[1]; /* FIXME: should be Modules[0] */ } SYSTEM_MODULE_INFORMATION, *PSYSTEM_MODULE_INFORMATION; +#define THREAD_CREATE_FLAGS_CREATE_SUSPENDED 0x00000001 +#define THREAD_CREATE_FLAGS_SKIP_THREAD_ATTACH 0x00000002 +#define THREAD_CREATE_FLAGS_HIDE_FROM_DEBUGGER 0x00000004 +#define THREAD_CREATE_FLAGS_HAS_SECURITY_DESCRIPTOR 0x00000010 +#define THREAD_CREATE_FLAGS_ACCESS_CHECK_IN_TARGET 0x00000020 +#define THREAD_CREATE_FLAGS_INITIAL_THREAD 0x00000080 + /*********************************************************************** * Function declarations */

1 0

Jeremy Newman : update RSVP form for 2018
by Jeremy Newman 08 Mar '18

08 Mar '18

Module: website Branch: master Commit: 4291f80f6e50a6d3b091d1f7e1609d97a1631ead URL: https://source.winehq.org/git/website.git/?a=commit;h=4291f80f6e50a6d3b091d… Author: Jeremy Newman <jnewman(a)codeweavers.com> Date: Thu Mar 8 13:26:45 2018 -0600 update RSVP form for 2018 --- templates/en/wineconf/rsvp.template | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/templates/en/wineconf/rsvp.template b/templates/en/wineconf/rsvp.template index 5891b75..59bbeb7 100644 --- a/templates/en/wineconf/rsvp.template +++ b/templates/en/wineconf/rsvp.template @@ -1,3 +1,3 @@ - + -<iframe src="https://docs.google.com/forms/d/e/1FAIpQLSf5eAdYjHyQg13cndWcQFTIS4Wym5fyjV0…" width="90%" height="1200" frameborder="0" marginheight="0" marginwidth="0">Loading...</iframe> +<iframe src="https://docs.google.com/forms/d/e/1FAIpQLSebJ5QBhB7SRn2e9qB7FdDrrqGZykdb4bU…" width="90%" height="1500" frameborder="0" marginheight="0" marginwidth="0">Loading...</iframe>

1 0

Francois Gouget : testbot: Remove unneeded ObjectModel:: PropertyDescriptor imports.
by Alexandre Julliard 08 Mar '18

08 Mar '18

Module: tools Branch: master Commit: 8a665a3b1807e19d348d138657bb07b445d6a9ad URL: https://source.winehq.org/git/tools.git/?a=commit;h=8a665a3b1807e19d348d138… Author: Francois Gouget <fgouget(a)codeweavers.com> Date: Thu Mar 8 17:48:42 2018 +0100 testbot: Remove unneeded ObjectModel::PropertyDescriptor imports. ObjectModel::PropertyDescriptor is only used as a base class and should not be used directly. Signed-off-by: Francois Gouget <fgouget(a)codeweavers.com> Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- testbot/lib/ObjectModel/Collection.pm | 1 - testbot/lib/ObjectModel/Item.pm | 1 - testbot/lib/WineTestBot/Branches.pm | 1 - testbot/lib/WineTestBot/Jobs.pm | 1 - testbot/lib/WineTestBot/Patches.pm | 1 - testbot/lib/WineTestBot/PendingPatches.pm | 1 - testbot/lib/WineTestBot/RecordGroups.pm | 1 - testbot/lib/WineTestBot/Records.pm | 1 - testbot/lib/WineTestBot/Roles.pm | 1 - testbot/lib/WineTestBot/Steps.pm | 1 - testbot/lib/WineTestBot/StepsTasks.pm | 1 - testbot/lib/WineTestBot/Tasks.pm | 1 - testbot/lib/WineTestBot/UserRoles.pm | 1 - testbot/lib/WineTestBot/Users.pm | 1 - testbot/lib/WineTestBot/VMs.pm | 1 - testbot/web/JobDetails.pl | 1 - testbot/web/PatchesList.pl | 1 - testbot/web/admin/BranchesList.pl | 1 - testbot/web/admin/UsersList.pl | 1 - testbot/web/admin/VMsList.pl | 1 - 20 files changed, 20 deletions(-) diff --git a/testbot/lib/ObjectModel/Collection.pm b/testbot/lib/ObjectModel/Collection.pm index 7fa977c..a57a329 100644 --- a/testbot/lib/ObjectModel/Collection.pm +++ b/testbot/lib/ObjectModel/Collection.pm @@ -46,7 +46,6 @@ require Exporter; use Scalar::Util qw(weaken); use ObjectModel::BackEnd; use ObjectModel::Item; -use ObjectModel::PropertyDescriptor; sub ComputeMasterKey($) diff --git a/testbot/lib/ObjectModel/Item.pm b/testbot/lib/ObjectModel/Item.pm index e1385b8..e90ebbe 100644 --- a/testbot/lib/ObjectModel/Item.pm +++ b/testbot/lib/ObjectModel/Item.pm @@ -29,7 +29,6 @@ ObjectModel::Item - Base class for items use Scalar::Util qw(weaken); use ObjectModel::BackEnd; use ObjectModel::Collection; -use ObjectModel::PropertyDescriptor; use vars qw(@ISA @EXPORT_OK); diff --git a/testbot/lib/WineTestBot/Branches.pm b/testbot/lib/WineTestBot/Branches.pm index bfd24dd..f5bd9d9 100644 --- a/testbot/lib/WineTestBot/Branches.pm +++ b/testbot/lib/WineTestBot/Branches.pm @@ -51,7 +51,6 @@ WineTestBot::Branches - A collection of WineTestBot::Branch objects =cut use ObjectModel::BasicPropertyDescriptor; -use ObjectModel::PropertyDescriptor; use WineTestBot::WineTestBotObjects; use vars qw (@ISA @EXPORT @PropertyDescriptors); diff --git a/testbot/lib/WineTestBot/Jobs.pm b/testbot/lib/WineTestBot/Jobs.pm index b870d7b..1d0f8bb 100644 --- a/testbot/lib/WineTestBot/Jobs.pm +++ b/testbot/lib/WineTestBot/Jobs.pm @@ -395,7 +395,6 @@ use ObjectModel::BasicPropertyDescriptor; use ObjectModel::EnumPropertyDescriptor; use ObjectModel::DetailrefPropertyDescriptor; use ObjectModel::ItemrefPropertyDescriptor; -use ObjectModel::PropertyDescriptor; use WineTestBot::WineTestBotObjects; use WineTestBot::Branches; use WineTestBot::Config; diff --git a/testbot/lib/WineTestBot/Patches.pm b/testbot/lib/WineTestBot/Patches.pm index d572ec4..a1d9635 100644 --- a/testbot/lib/WineTestBot/Patches.pm +++ b/testbot/lib/WineTestBot/Patches.pm @@ -366,7 +366,6 @@ WineTestBot::Patches - A collection of WineTestBot::Patch objects =cut use ObjectModel::BasicPropertyDescriptor; -use ObjectModel::PropertyDescriptor; use WineTestBot::Config; use WineTestBot::WineTestBotObjects; diff --git a/testbot/lib/WineTestBot/PendingPatches.pm b/testbot/lib/WineTestBot/PendingPatches.pm index 67d19a7..d63ff7e 100644 --- a/testbot/lib/WineTestBot/PendingPatches.pm +++ b/testbot/lib/WineTestBot/PendingPatches.pm @@ -48,7 +48,6 @@ WineTestBot::PendingPatches - A collection of WineTestBot::PendingPatch objects use ObjectModel::BasicPropertyDescriptor; use ObjectModel::ItemrefPropertyDescriptor; -use ObjectModel::PropertyDescriptor; use WineTestBot::Patches; use WineTestBot::WineTestBotObjects; diff --git a/testbot/lib/WineTestBot/RecordGroups.pm b/testbot/lib/WineTestBot/RecordGroups.pm index 707d0ac..cde1a8d 100644 --- a/testbot/lib/WineTestBot/RecordGroups.pm +++ b/testbot/lib/WineTestBot/RecordGroups.pm @@ -59,7 +59,6 @@ WineTestBot::RecordGroups - A collection of WineTestBot::RecordGroup objects use ObjectModel::BasicPropertyDescriptor; use ObjectModel::EnumPropertyDescriptor; use ObjectModel::DetailrefPropertyDescriptor; -use ObjectModel::PropertyDescriptor; use WineTestBot::WineTestBotObjects; use WineTestBot::Records; diff --git a/testbot/lib/WineTestBot/Records.pm b/testbot/lib/WineTestBot/Records.pm index ac1c0fa..46cf1fe 100644 --- a/testbot/lib/WineTestBot/Records.pm +++ b/testbot/lib/WineTestBot/Records.pm @@ -64,7 +64,6 @@ WineTestBot::Records - A collection of WineTestBot::Record objects use ObjectModel::BasicPropertyDescriptor; use ObjectModel::EnumPropertyDescriptor; -use ObjectModel::PropertyDescriptor; use WineTestBot::WineTestBotObjects; use vars qw (@ISA @EXPORT @PropertyDescriptors @FlatPropertyDescriptors); diff --git a/testbot/lib/WineTestBot/Roles.pm b/testbot/lib/WineTestBot/Roles.pm index 7c59e6a..eed13c3 100644 --- a/testbot/lib/WineTestBot/Roles.pm +++ b/testbot/lib/WineTestBot/Roles.pm @@ -45,7 +45,6 @@ WineTestBot::Roles - A collection of WineTestBot::Role objects =cut -use ObjectModel::PropertyDescriptor; use ObjectModel::BasicPropertyDescriptor; use WineTestBot::WineTestBotObjects; diff --git a/testbot/lib/WineTestBot/Steps.pm b/testbot/lib/WineTestBot/Steps.pm index 45ec635..23e02cb 100644 --- a/testbot/lib/WineTestBot/Steps.pm +++ b/testbot/lib/WineTestBot/Steps.pm @@ -192,7 +192,6 @@ WineTestBot::Steps - A collection of Job Steps use ObjectModel::BasicPropertyDescriptor; use ObjectModel::EnumPropertyDescriptor; use ObjectModel::DetailrefPropertyDescriptor; -use ObjectModel::PropertyDescriptor; use WineTestBot::Tasks; use WineTestBot::WineTestBotObjects; diff --git a/testbot/lib/WineTestBot/StepsTasks.pm b/testbot/lib/WineTestBot/StepsTasks.pm index 33f99b0..79216d4 100644 --- a/testbot/lib/WineTestBot/StepsTasks.pm +++ b/testbot/lib/WineTestBot/StepsTasks.pm @@ -97,7 +97,6 @@ WineTestBot::StepsTasks - A collection of StepsTasks objects use ObjectModel::BasicPropertyDescriptor; use ObjectModel::ItemrefPropertyDescriptor; -use ObjectModel::PropertyDescriptor; use WineTestBot::Steps; use WineTestBot::Tasks; use WineTestBot::VMs; diff --git a/testbot/lib/WineTestBot/Tasks.pm b/testbot/lib/WineTestBot/Tasks.pm index e0b5192..373da53 100644 --- a/testbot/lib/WineTestBot/Tasks.pm +++ b/testbot/lib/WineTestBot/Tasks.pm @@ -206,7 +206,6 @@ WineTestBot::Tasks - A collection of WineTestBot::Task objects use ObjectModel::BasicPropertyDescriptor; use ObjectModel::EnumPropertyDescriptor; use ObjectModel::ItemrefPropertyDescriptor; -use ObjectModel::PropertyDescriptor; use WineTestBot::VMs; use WineTestBot::WineTestBotObjects; diff --git a/testbot/lib/WineTestBot/UserRoles.pm b/testbot/lib/WineTestBot/UserRoles.pm index 2d1fab2..8f7899a 100644 --- a/testbot/lib/WineTestBot/UserRoles.pm +++ b/testbot/lib/WineTestBot/UserRoles.pm @@ -41,7 +41,6 @@ WineTestBot::UserRoles - A collection of WineTestBot::UserRole objects =cut use ObjectModel::ItemrefPropertyDescriptor; -use ObjectModel::PropertyDescriptor; use WineTestBot::Roles; use WineTestBot::WineTestBotObjects; diff --git a/testbot/lib/WineTestBot/Users.pm b/testbot/lib/WineTestBot/Users.pm index 7b18df9..b9745d8 100644 --- a/testbot/lib/WineTestBot/Users.pm +++ b/testbot/lib/WineTestBot/Users.pm @@ -299,7 +299,6 @@ use Net::LDAP; use ObjectModel::BasicPropertyDescriptor; use ObjectModel::EnumPropertyDescriptor; use ObjectModel::DetailrefPropertyDescriptor; -use ObjectModel::PropertyDescriptor; use WineTestBot::Config; use WineTestBot::UserRoles; use WineTestBot::WineTestBotObjects; diff --git a/testbot/lib/WineTestBot/VMs.pm b/testbot/lib/WineTestBot/VMs.pm index afc7af9..7a35ba7 100644 --- a/testbot/lib/WineTestBot/VMs.pm +++ b/testbot/lib/WineTestBot/VMs.pm @@ -632,7 +632,6 @@ role or status. use ObjectModel::BasicPropertyDescriptor; use ObjectModel::EnumPropertyDescriptor; -use ObjectModel::PropertyDescriptor; use WineTestBot::WineTestBotObjects; use vars qw (@ISA @EXPORT @PropertyDescriptors); diff --git a/testbot/web/JobDetails.pl b/testbot/web/JobDetails.pl index 10a0d7c..70fb0fe 100644 --- a/testbot/web/JobDetails.pl +++ b/testbot/web/JobDetails.pl @@ -22,7 +22,6 @@ use strict; package JobDetailsPage; use URI::Escape; -use ObjectModel::PropertyDescriptor; use ObjectModel::CGI::CollectionPage; use WineTestBot::Config; use WineTestBot::Jobs; diff --git a/testbot/web/PatchesList.pl b/testbot/web/PatchesList.pl index 39e9dc1..f0571b1 100644 --- a/testbot/web/PatchesList.pl +++ b/testbot/web/PatchesList.pl @@ -22,7 +22,6 @@ use strict; package PatchesListPage; use URI::Escape; -use ObjectModel::PropertyDescriptor; use ObjectModel::CGI::CollectionPage; use WineTestBot::Patches; diff --git a/testbot/web/admin/BranchesList.pl b/testbot/web/admin/BranchesList.pl index 48916cf..716fbd7 100644 --- a/testbot/web/admin/BranchesList.pl +++ b/testbot/web/admin/BranchesList.pl @@ -21,7 +21,6 @@ use strict; package BranchesListPage; -use ObjectModel::PropertyDescriptor; use ObjectModel::CGI::CollectionPage; use WineTestBot::Config; use WineTestBot::Branches; diff --git a/testbot/web/admin/UsersList.pl b/testbot/web/admin/UsersList.pl index d6ac868..eb6c324 100644 --- a/testbot/web/admin/UsersList.pl +++ b/testbot/web/admin/UsersList.pl @@ -22,7 +22,6 @@ use strict; package UsersListPage; -use ObjectModel::PropertyDescriptor; use ObjectModel::CGI::CollectionPage; use WineTestBot::CGI::Sessions; use WineTestBot::Config; diff --git a/testbot/web/admin/VMsList.pl b/testbot/web/admin/VMsList.pl index 9984771..652fc8e 100644 --- a/testbot/web/admin/VMsList.pl +++ b/testbot/web/admin/VMsList.pl @@ -21,7 +21,6 @@ use strict; package VMsListPage; -use ObjectModel::PropertyDescriptor; use ObjectModel::CGI::CollectionPage; use WineTestBot::VMs;

1 0

Francois Gouget : testbot: Simplify updating a Step's status.
by Alexandre Julliard 08 Mar '18

08 Mar '18

Module: tools Branch: master Commit: 497bad412434293d907e96e73cfc4b7287d86e0e URL: https://source.winehq.org/git/tools.git/?a=commit;h=497bad412434293d907e96e… Author: Francois Gouget <fgouget(a)codeweavers.com> Date: Thu Mar 8 17:48:56 2018 +0100 testbot: Simplify updating a Step's status. Signed-off-by: Francois Gouget <fgouget(a)codeweavers.com> Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- testbot/lib/WineTestBot/Steps.pm | 7 +------ 1 file changed, 1 insertion(+), 6 deletions(-) diff --git a/testbot/lib/WineTestBot/Steps.pm b/testbot/lib/WineTestBot/Steps.pm index 23e02cb..b8dbaec 100644 --- a/testbot/lib/WineTestBot/Steps.pm +++ b/testbot/lib/WineTestBot/Steps.pm @@ -146,12 +146,7 @@ sub UpdateStatus($$) return $Status if ($Status ne "queued" && $Status ne "running"); my %Has; - my $Tasks = $self->Tasks; - foreach my $TaskKey (@{$Tasks->GetKeys()}) - { - my $Task = $Tasks->GetItem($TaskKey); - $Has{$Task->UpdateStatus($Skip)} = 1; - } + map { $Has{$_->UpdateStatus($Skip)} = 1 } (@{$self->Tasks->GetItems()}); # Inherit the tasks most significant status. # Note that one or more tasks may have been requeued during the cleanup phase

1 0

Alexandre Julliard : Add WineConf 2018 news.
by Alexandre Julliard 08 Mar '18

08 Mar '18

Module: website Branch: master Commit: ec191f09899f499b6e1dd35b6879dec4c8e9346a URL: https://source.winehq.org/git/website.git/?a=commit;h=ec191f09899f499b6e1dd… Author: Alexandre Julliard <julliard(a)winehq.org> Date: Thu Mar 8 11:09:02 2018 -0600 Add WineConf 2018 news. Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- news/en/2018030801.xml | 15 +++++++++++++++ 1 file changed, 15 insertions(+) diff --git a/news/en/2018030801.xml b/news/en/2018030801.xml new file mode 100644 index 0000000..9d278e3 --- /dev/null +++ b/news/en/2018030801.xml @@ -0,0 +1,15 @@ +<news> +<date>March 8, 2018</date> +<title>WineConf 2018 - 25th anniversary</title> +<body> +<p>The Wine Project is pleased to announce that WineConf 2018 will +take place on June 29 - July 1 2018 in The Hague, The +Netherlands. This will coincide with the 25th anniversary of Wine.</p> +<p>WineConf is the Wine Project's annual conference, where members of +the Wine community, the broader Free Software community and interested +users meet up over food and beverages. We traditionally also have a +number of talks by attendees, as well as some formal and informal +discussions about anything vaguely Wine related.</p> +<p>Please see the <a href="https://wiki.winehq.org/WineConf2018">WineConf2018 page</a> +for further details.</p> +</body></news>

1 0