January 2019 - Wine-commits

Nikolay Sivov : ntdll: Make LdrFindResource_U() and LdrFindResourceDirectory_U() patchable.
by Alexandre Julliard 28 Jan '19

28 Jan '19

Module: wine Branch: master Commit: 9b90cfc2817e171e7a9698605deecc3438712af8 URL: https://source.winehq.org/git/wine.git/?a=commit;h=9b90cfc2817e171e7a969860… Author: Nikolay Sivov <nsivov(a)codeweavers.com> Date: Sun Jan 27 08:58:09 2019 +0300 ntdll: Make LdrFindResource_U() and LdrFindResourceDirectory_U() patchable. Signed-off-by: Nikolay Sivov <nsivov(a)codeweavers.com> Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- dlls/ntdll/resource.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/dlls/ntdll/resource.c b/dlls/ntdll/resource.c index 0d5172a..0322a92 100644 --- a/dlls/ntdll/resource.c +++ b/dlls/ntdll/resource.c @@ -259,7 +259,7 @@ done: /********************************************************************** * LdrFindResourceDirectory_U (NTDLL.@) */ -NTSTATUS WINAPI LdrFindResourceDirectory_U( HMODULE hmod, const LDR_RESOURCE_INFO *info, +NTSTATUS WINAPI DECLSPEC_HOTPATCH LdrFindResourceDirectory_U( HMODULE hmod, const LDR_RESOURCE_INFO *info, ULONG level, const IMAGE_RESOURCE_DIRECTORY **dir ) { const void *res; @@ -287,7 +287,7 @@ NTSTATUS WINAPI LdrFindResourceDirectory_U( HMODULE hmod, const LDR_RESOURCE_INF /********************************************************************** * LdrFindResource_U (NTDLL.@) */ -NTSTATUS WINAPI LdrFindResource_U( HMODULE hmod, const LDR_RESOURCE_INFO *info, +NTSTATUS WINAPI DECLSPEC_HOTPATCH LdrFindResource_U( HMODULE hmod, const LDR_RESOURCE_INFO *info, ULONG level, const IMAGE_RESOURCE_DATA_ENTRY **entry ) { const void *res;

1 0

Nikolay Sivov : shell32: Remove duplicated assignment (Coverity).
by Alexandre Julliard 28 Jan '19

28 Jan '19

Module: wine Branch: master Commit: 1a98e6538655cb7b6c9ad7a567f4a25d6674c309 URL: https://source.winehq.org/git/wine.git/?a=commit;h=1a98e6538655cb7b6c9ad7a5… Author: Nikolay Sivov <nsivov(a)codeweavers.com> Date: Sun Jan 27 09:33:02 2019 +0300 shell32: Remove duplicated assignment (Coverity). Signed-off-by: Nikolay Sivov <nsivov(a)codeweavers.com> Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- dlls/shell32/brsfolder.c | 1 - 1 file changed, 1 deletion(-) diff --git a/dlls/shell32/brsfolder.c b/dlls/shell32/brsfolder.c index d771d0b..37363a1 100644 --- a/dlls/shell32/brsfolder.c +++ b/dlls/shell32/brsfolder.c @@ -647,7 +647,6 @@ static LRESULT BrsFolder_Treeview_Keydown(browse_info *info, LPNMTVKEYDOWN keydo TV_ITEMDATA *item_data; item.mask = TVIF_PARAM; - item.mask = TVIF_HANDLE|TVIF_PARAM; item.hItem = selected_item; SendMessageW(info->hwndTreeView, TVM_GETITEMW, 0, (LPARAM)&item); item_data = (TV_ITEMDATA *)item.lParam;

1 0

Nikolay Sivov : usp10/tests: Add missing return value checks (Coverity).
by Alexandre Julliard 28 Jan '19

28 Jan '19

Module: wine Branch: master Commit: 64edf6f79d1523cdf68225d350762a60a0c89792 URL: https://source.winehq.org/git/wine.git/?a=commit;h=64edf6f79d1523cdf68225d3… Author: Nikolay Sivov <nsivov(a)codeweavers.com> Date: Sun Jan 27 09:41:15 2019 +0300 usp10/tests: Add missing return value checks (Coverity). Signed-off-by: Nikolay Sivov <nsivov(a)codeweavers.com> Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- dlls/usp10/tests/usp10.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/dlls/usp10/tests/usp10.c b/dlls/usp10/tests/usp10.c index e907c8c..4c16df5 100644 --- a/dlls/usp10/tests/usp10.c +++ b/dlls/usp10/tests/usp10.c @@ -3019,6 +3019,7 @@ static void test_ScriptXtoX(void) WORD clust = 0; INT advance = 16; hr = ScriptXtoCP(iX, 1, 1, &clust, psva, &advance, &sa, &piCP, &piTrailing); + ok(hr == S_OK, "ScriptXtoCP failed, hr %#x.\n", hr); ok(piCP==0 && piTrailing==0,"%i should return 0(%i) and 0(%i)\n",iX, piCP,piTrailing); } for (iX = 8; iX < 16; iX++) @@ -3026,6 +3027,7 @@ static void test_ScriptXtoX(void) WORD clust = 0; INT advance = 16; hr = ScriptXtoCP(iX, 1, 1, &clust, psva, &advance, &sa, &piCP, &piTrailing); + ok(hr == S_OK, "ScriptXtoCP failed, hr %#x.\n", hr); ok(piCP==0 && piTrailing==1,"%i should return 0(%i) and 1(%i)\n",iX, piCP,piTrailing); }

1 0

Nikolay Sivov : include: Fix a typo in D2D1_WINDOW_STATE values.
by Alexandre Julliard 28 Jan '19

28 Jan '19

Module: wine Branch: master Commit: 34eb4ab4c661e5e72d95fe8ec52dddae686afd11 URL: https://source.winehq.org/git/wine.git/?a=commit;h=34eb4ab4c661e5e72d95fe8e… Author: Nikolay Sivov <nsivov(a)codeweavers.com> Date: Sun Jan 27 22:14:48 2019 +0300 include: Fix a typo in D2D1_WINDOW_STATE values. Signed-off-by: Nikolay Sivov <nsivov(a)codeweavers.com> Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- include/d2d1.idl | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/include/d2d1.idl b/include/d2d1.idl index c9fb8f0..08487fa 100644 --- a/include/d2d1.idl +++ b/include/d2d1.idl @@ -274,8 +274,8 @@ typedef enum D2D1_FEATURE_LEVEL typedef enum D2D1_WINDOW_STATE { - D2D1_WINDOW_STATE_NONE = 0x0000000, - D2D1_WINDOW_STATE_OCCLUDED = 0x0000001, + D2D1_WINDOW_STATE_NONE = 0, + D2D1_WINDOW_STATE_OCCLUDED = 1, D2D1_WINDOW_STATE_FORCE_DWORD = 0xffffffff, } D2D1_WINDOW_STATE;

1 0

Zebediah Figura : ntoskrnl.exe/tests: Open the test file for synchronous I /O.
by Alexandre Julliard 28 Jan '19

28 Jan '19

Module: wine Branch: master Commit: e07d25c799a528c933031666278ddf5666b94372 URL: https://source.winehq.org/git/wine.git/?a=commit;h=e07d25c799a528c933031666… Author: Zebediah Figura <z.figura12(a)gmail.com> Date: Sat Jan 26 12:53:00 2019 -0600 ntoskrnl.exe/tests: Open the test file for synchronous I/O. Especially to avoid a panic when we close the file before a write has completed. Signed-off-by: Zebediah Figura <z.figura12(a)gmail.com> Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- dlls/ntoskrnl.exe/tests/driver.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/dlls/ntoskrnl.exe/tests/driver.c b/dlls/ntoskrnl.exe/tests/driver.c index 6ab5c3e..5c34b41 100644 --- a/dlls/ntoskrnl.exe/tests/driver.c +++ b/dlls/ntoskrnl.exe/tests/driver.c @@ -53,12 +53,10 @@ extern int CDECL _vsnprintf(char *str, size_t len, const char *format, __ms_va_l static void kvprintf(const char *format, __ms_va_list ap) { static char buffer[512]; - LARGE_INTEGER offset; IO_STATUS_BLOCK io; _vsnprintf(buffer, sizeof(buffer), format, ap); - offset.QuadPart = -1; - ZwWriteFile(okfile, NULL, NULL, NULL, &io, buffer, strlen(buffer), &offset, NULL); + ZwWriteFile(okfile, NULL, NULL, NULL, &io, buffer, strlen(buffer), NULL, NULL); } static void WINAPIV kprintf(const char *format, ...) @@ -522,7 +520,7 @@ static NTSTATUS main_test(IRP *irp, IO_STACK_LOCATION *stack, ULONG_PTR *info) winetest_report_success = test_input->winetest_report_success; attr.ObjectName = &pathU; attr.Attributes = OBJ_KERNEL_HANDLE; /* needed to be accessible from system threads */ - ZwOpenFile(&okfile, FILE_APPEND_DATA, &attr, &io, 0, 0); + ZwOpenFile(&okfile, FILE_APPEND_DATA | SYNCHRONIZE, &attr, &io, 0, FILE_SYNCHRONOUS_IO_NONALERT); test_currentprocess(); test_mdl_map();

1 0

Gijs Vermeulen : kernel32/tests: Add CopyFile[Ex]A NULL handling tests.
by Alexandre Julliard 28 Jan '19

28 Jan '19

Module: wine Branch: master Commit: 9b7113bcecd3281d3b558bd512dcf5a015d92632 URL: https://source.winehq.org/git/wine.git/?a=commit;h=9b7113bcecd3281d3b558bd5… Author: Gijs Vermeulen <gijsvrm(a)gmail.com> Date: Sat Jan 26 22:17:54 2019 +0100 kernel32/tests: Add CopyFile[Ex]A NULL handling tests. Signed-off-by: Gijs Vermeulen <gijsvrm(a)gmail.com> Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- dlls/kernel32/tests/file.c | 15 +++++++++++++++ 1 file changed, 15 insertions(+) diff --git a/dlls/kernel32/tests/file.c b/dlls/kernel32/tests/file.c index d1b76bb..b47b2b9 100644 --- a/dlls/kernel32/tests/file.c +++ b/dlls/kernel32/tests/file.c @@ -738,6 +738,14 @@ static void test_CopyFileA(void) ret = CopyFileA(source, dest, FALSE); ok(ret, "CopyFileA: error %d\n", GetLastError()); + /* NULL checks */ + retok = CopyFileA(NULL, dest, TRUE); + ok(!retok && GetLastError() == ERROR_PATH_NOT_FOUND, + "CopyFileA: ret = %d, unexpected error %d\n", retok, GetLastError()); + retok = CopyFileA(source, NULL, TRUE); + ok(!retok && GetLastError() == ERROR_PATH_NOT_FOUND, + "CopyFileA: ret = %d, unexpected error %d\n", retok, GetLastError()); + /* copying from a read-locked source fails */ hfile = CreateFileA(source, GENERIC_READ, FILE_SHARE_WRITE, NULL, OPEN_EXISTING, 0, 0); ok(hfile != INVALID_HANDLE_VALUE, "failed to open source file, error %d\n", GetLastError()); @@ -1174,6 +1182,13 @@ static void test_CopyFileEx(void) todo_wine ok(GetFileAttributesA(dest) == INVALID_FILE_ATTRIBUTES, "file was not deleted\n"); + retok = CopyFileExA(source, NULL, copy_progress_cb, hfile, NULL, 0); + ok(!retok, "CopyFileExA unexpectedly succeeded\n"); + ok(GetLastError() == ERROR_PATH_NOT_FOUND, "expected ERROR_PATH_NOT_FOUND, got %d\n", GetLastError()); + retok = CopyFileExA(NULL, dest, copy_progress_cb, hfile, NULL, 0); + ok(!retok, "CopyFileExA unexpectedly succeeded\n"); + ok(GetLastError() == ERROR_PATH_NOT_FOUND, "expected ERROR_PATH_NOT_FOUND, got %d\n", GetLastError()); + ret = DeleteFileA(source); ok(ret, "DeleteFileA failed with error %d\n", GetLastError()); ret = DeleteFileA(dest);

1 0

Zhiyi Zhang : msacm32: Reference count local drivers.
by Alexandre Julliard 28 Jan '19

28 Jan '19

Module: wine Branch: master Commit: bbdf6d5e21cfe1ef5e317d01978310bac614e6a0 URL: https://source.winehq.org/git/wine.git/?a=commit;h=bbdf6d5e21cfe1ef5e317d01… Author: Zhiyi Zhang <zzhang(a)codeweavers.com> Date: Sat Jan 26 16:20:10 2019 +0800 msacm32: Reference count local drivers. One local driver can be assigned to multiple driver ids. When releasing the driver id, check if the reference count of a local driver is one before actually releasing the local driver. Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=46520 Signed-off-by: Zhiyi Zhang <zzhang(a)codeweavers.com> Signed-off-by: Andrew Eikum <aeikum(a)codeweavers.com> Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- dlls/msacm32/internal.c | 12 +++++++++++- dlls/msacm32/wineacm.h | 1 + 2 files changed, 12 insertions(+), 1 deletion(-) diff --git a/dlls/msacm32/internal.c b/dlls/msacm32/internal.c index aad071e..7d324a8 100644 --- a/dlls/msacm32/internal.c +++ b/dlls/msacm32/internal.c @@ -737,12 +737,17 @@ static PWINE_ACMLOCALDRIVER MSACM_pLastACMLocalDriver; static PWINE_ACMLOCALDRIVER MSACM_UnregisterLocalDriver(PWINE_ACMLOCALDRIVER paldrv) { PWINE_ACMLOCALDRIVER pNextACMLocalDriver; + LONG ref; if (paldrv->pACMInstList) { ERR("local driver instances still present after closing all drivers - memory leak\n"); return NULL; } + ref = InterlockedDecrement(&paldrv->ref); + if (ref) + return paldrv; + if (paldrv == MSACM_pFirstACMLocalDriver) MSACM_pFirstACMLocalDriver = paldrv->pNextACMLocalDrv; if (paldrv == MSACM_pLastACMLocalDriver) @@ -883,7 +888,11 @@ PWINE_ACMLOCALDRIVER MSACM_RegisterLocalDriver(HMODULE hModule, DRIVERPROC lpDri /* look up previous instance of local driver module */ for (paldrv = MSACM_pFirstACMLocalDriver; paldrv; paldrv = paldrv->pNextACMLocalDrv) { - if (paldrv->hModule == hModule && paldrv->lpDrvProc == lpDriverProc) return paldrv; + if (paldrv->hModule == hModule && paldrv->lpDrvProc == lpDriverProc) + { + InterlockedIncrement(&paldrv->ref); + return paldrv; + } } paldrv = HeapAlloc(MSACM_hHeap, 0, sizeof(WINE_ACMLOCALDRIVER)); @@ -892,6 +901,7 @@ PWINE_ACMLOCALDRIVER MSACM_RegisterLocalDriver(HMODULE hModule, DRIVERPROC lpDri paldrv->hModule = hModule; paldrv->lpDrvProc = lpDriverProc; paldrv->pACMInstList = NULL; + paldrv->ref = 1; paldrv->pNextACMLocalDrv = NULL; paldrv->pPrevACMLocalDrv = MSACM_pLastACMLocalDriver; diff --git a/dlls/msacm32/wineacm.h b/dlls/msacm32/wineacm.h index 406e01b..98d1ab5 100644 --- a/dlls/msacm32/wineacm.h +++ b/dlls/msacm32/wineacm.h @@ -52,6 +52,7 @@ typedef struct _WINE_ACMLOCALDRIVER PWINE_ACMLOCALDRIVERINST pACMInstList; PWINE_ACMLOCALDRIVER pNextACMLocalDrv; PWINE_ACMLOCALDRIVER pPrevACMLocalDrv; + LONG ref; } WINE_ACMLOCALDRIVER; typedef struct _WINE_ACMLOCALDRIVERINST

1 0

Orhan Kavrakoğlu : crypt32: Add CryptImportPublicKeyInfoEx2 stub.
by Alexandre Julliard 28 Jan '19

28 Jan '19

Module: wine Branch: master Commit: 7ab111aabbc24454d54691651667b9583fe2d377 URL: https://source.winehq.org/git/wine.git/?a=commit;h=7ab111aabbc24454d5469165… Author: Orhan Kavrakoğlu <aibok42(a)gmail.com> Date: Fri Jan 25 21:13:54 2019 +0300 crypt32: Add CryptImportPublicKeyInfoEx2 stub. Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=46516 Signed-off-by: Orhan Kavrakoğlu <aibok42(a)gmail.com> Signed-off-by: Hans Leidekker <hans(a)codeweavers.com> Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- dlls/crypt32/crypt32.spec | 1 + dlls/crypt32/encode.c | 10 ++++++++++ include/wincrypt.h | 3 +++ 3 files changed, 14 insertions(+) diff --git a/dlls/crypt32/crypt32.spec b/dlls/crypt32/crypt32.spec index fc32570..1815a1d 100644 --- a/dlls/crypt32/crypt32.spec +++ b/dlls/crypt32/crypt32.spec @@ -142,6 +142,7 @@ @ stub CryptImportPKCS8 @ stdcall CryptImportPublicKeyInfo(long long ptr ptr) @ stdcall CryptImportPublicKeyInfoEx(long long ptr long long ptr ptr) +@ stdcall CryptImportPublicKeyInfoEx2(long ptr long ptr ptr) @ stdcall CryptInitOIDFunctionSet(str long) @ stdcall CryptInstallOIDFunctionAddress(ptr long str long ptr long) @ stub CryptLoadSip diff --git a/dlls/crypt32/encode.c b/dlls/crypt32/encode.c index 9d052b6..16a50dc 100644 --- a/dlls/crypt32/encode.c +++ b/dlls/crypt32/encode.c @@ -5065,3 +5065,13 @@ BOOL WINAPI CryptImportPublicKeyInfoEx(HCRYPTPROV hCryptProv, CryptFreeOIDFunctionAddress(hFunc, 0); return ret; } + +BOOL WINAPI CryptImportPublicKeyInfoEx2(DWORD dwCertEncodingType, + PCERT_PUBLIC_KEY_INFO pInfo, DWORD dwFlags, void *pvAuxInfo, + BCRYPT_KEY_HANDLE *phKey) +{ + FIXME_(crypt)("(%d, %p, %08x, %p, %p): stub\n", dwCertEncodingType, pInfo, + dwFlags, pvAuxInfo, phKey); + SetLastError(ERROR_FILE_NOT_FOUND); + return FALSE; +} diff --git a/include/wincrypt.h b/include/wincrypt.h index a1b1305..d68c955 100644 --- a/include/wincrypt.h +++ b/include/wincrypt.h @@ -4461,6 +4461,9 @@ BOOL WINAPI CryptImportPublicKeyInfo(HCRYPTPROV hCryptProv, BOOL WINAPI CryptImportPublicKeyInfoEx(HCRYPTPROV hCryptProv, DWORD dwCertEncodingType, PCERT_PUBLIC_KEY_INFO pInfo, ALG_ID aiKeyAlg, DWORD dwFlags, void *pvAuxInfo, HCRYPTKEY *phKey); +BOOL WINAPI CryptImportPublicKeyInfoEx2(DWORD dwCertEncodingType, + PCERT_PUBLIC_KEY_INFO pInfo, DWORD dwFlags, void *pvAuxInfo, + BCRYPT_KEY_HANDLE *phKey); BOOL WINAPI CryptAcquireCertificatePrivateKey(PCCERT_CONTEXT pCert, DWORD dwFlags, void *pvReserved, HCRYPTPROV_OR_NCRYPT_KEY_HANDLE *phCryptProv, DWORD *pdwKeySpec,

1 0

Zebediah Figura : msi: Factor out int_to_table_storage().
by Alexandre Julliard 28 Jan '19

28 Jan '19

Module: wine Branch: master Commit: 99425f272f7807aea068629ef3e5fda6640b2845 URL: https://source.winehq.org/git/wine.git/?a=commit;h=99425f272f7807aea068629e… Author: Zebediah Figura <z.figura12(a)gmail.com> Date: Sat Jan 26 16:58:57 2019 -0600 msi: Factor out int_to_table_storage(). Signed-off-by: Zebediah Figura <z.figura12(a)gmail.com> Signed-off-by: Hans Leidekker <hans(a)codeweavers.com> Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- dlls/msi/table.c | 53 ++++++++++++++++++++++++++--------------------------- 1 file changed, 26 insertions(+), 27 deletions(-) diff --git a/dlls/msi/table.c b/dlls/msi/table.c index b507268..e4f6b56 100644 --- a/dlls/msi/table.c +++ b/dlls/msi/table.c @@ -1201,6 +1201,26 @@ static UINT TABLE_set_int( MSITABLEVIEW *tv, UINT row, UINT col, UINT val ) return ERROR_SUCCESS; } +static UINT int_to_table_storage( const MSITABLEVIEW *tv, UINT col, int val, UINT *ret ) +{ + if ((tv->columns[col-1].type & MSI_DATASIZEMASK) == 2) + { + if (val == MSI_NULL_INTEGER) + *ret = 0; + else if ((val + 0x8000) & 0xffff0000) + { + ERR("value %d out of range\n", val); + return ERROR_FUNCTION_FAILED; + } + else + *ret = val + 0x8000; + } + else + *ret = val ^ 0x80000000; + + return ERROR_SUCCESS; +} + static UINT TABLE_get_row( struct tagMSIVIEW *view, UINT row, MSIRECORD **rec ) { MSITABLEVIEW *tv = (MSITABLEVIEW *)view; @@ -1276,7 +1296,6 @@ static UINT get_table_value_from_record( MSITABLEVIEW *tv, MSIRECORD *rec, UINT { MSICOLUMNINFO columninfo; UINT r; - int ival; if (!iField || iField > tv->num_cols || MSI_RecordIsNull( rec, iField )) return ERROR_FUNCTION_FAILED; @@ -1299,25 +1318,8 @@ static UINT get_table_value_from_record( MSITABLEVIEW *tv, MSIRECORD *rec, UINT } else *pvalue = 0; } - else if ( bytes_per_column( tv->db, &columninfo, LONG_STR_BYTES ) == 2 ) - { - ival = MSI_RecordGetInteger( rec, iField ); - if (ival == 0x80000000) *pvalue = 0x8000; - else - { - *pvalue = 0x8000 + MSI_RecordGetInteger( rec, iField ); - if (*pvalue & 0xffff0000) - { - ERR("field %u value %d out of range\n", iField, *pvalue - 0x8000); - return ERROR_FUNCTION_FAILED; - } - } - } else - { - ival = MSI_RecordGetInteger( rec, iField ); - *pvalue = ival ^ 0x80000000; - } + return int_to_table_storage( tv, iField, MSI_RecordGetInteger( rec, iField ), pvalue ); return ERROR_SUCCESS; } @@ -2370,14 +2372,11 @@ static UINT* msi_record_to_row( const MSITABLEVIEW *tv, MSIRECORD *rec ) } else { - data[i] = MSI_RecordGetInteger( rec, i+1 ); - - if (data[i] == MSI_NULL_INTEGER) - data[i] = 0; - else if ((tv->columns[i].type&0xff) == 2) - data[i] += 0x8000; - else - data[i] += 0x80000000; + if (int_to_table_storage( tv, i + 1, MSI_RecordGetInteger( rec, i + 1 ), &data[i] )) + { + msi_free( data ); + return NULL; + } } } return data;

1 0

Zebediah Figura : msi: Set table values directly in msi_select_update().
by Alexandre Julliard 28 Jan '19

28 Jan '19

Module: wine Branch: master Commit: f45a7b04a6caca4eed1d08f4e69884b119f3aa17 URL: https://source.winehq.org/git/wine.git/?a=commit;h=f45a7b04a6caca4eed1d08f4… Author: Zebediah Figura <z.figura12(a)gmail.com> Date: Sat Jan 26 16:58:58 2019 -0600 msi: Set table values directly in msi_select_update(). In order to avoid the need to create a temporary record and copy values back and forth. Signed-off-by: Zebediah Figura <z.figura12(a)gmail.com> Signed-off-by: Hans Leidekker <hans(a)codeweavers.com> Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- dlls/msi/alter.c | 2 ++ dlls/msi/create.c | 2 ++ dlls/msi/delete.c | 2 ++ dlls/msi/distinct.c | 2 ++ dlls/msi/drop.c | 2 ++ dlls/msi/insert.c | 2 ++ dlls/msi/msipriv.h | 14 +++++++++++ dlls/msi/select.c | 26 +++++++------------- dlls/msi/storages.c | 8 ++++++ dlls/msi/streams.c | 8 ++++++ dlls/msi/table.c | 71 +++++++++++++++++++++++++++++++++++++++++++++++++++-- dlls/msi/update.c | 2 ++ dlls/msi/where.c | 42 +++++++++++++++++++++++++++++++ 13 files changed, 164 insertions(+), 19 deletions(-) Diff: https://source.winehq.org/git/wine.git/?a=commitdiff;h=f45a7b04a6caca4eed1d…

1 0