March 2020 - Wine-commits - list.winehq.org

Alexandre Julliard : unicode: Add compression flags to the sortkey table.
by Alexandre Julliard 18 Mar '20

18 Mar '20

Module: wine Branch: master Commit: 94397d96bb473e3d987e8ea778c52dc2ec78fc59 URL: https://source.winehq.org/git/wine.git/?a=commit;h=94397d96bb473e3d987e8ea7… Author: Alexandre Julliard <julliard(a)winehq.org> Date: Wed Mar 18 16:03:33 2020 +0100 unicode: Add compression flags to the sortkey table. Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- nls/sortdefault.nls | Bin 3316820 -> 3354708 bytes tools/make_unicode | 33 +++++++++++++++++++++------------ 2 files changed, 21 insertions(+), 12 deletions(-) diff --git a/nls/sortdefault.nls b/nls/sortdefault.nls index fcd92d90c4..8d6cc62209 100644 Binary files a/nls/sortdefault.nls and b/nls/sortdefault.nls differ diff --git a/tools/make_unicode b/tools/make_unicode index 9acc87e9c8..86a180259f 100755 --- a/tools/make_unicode +++ b/tools/make_unicode @@ -2371,13 +2371,13 @@ sub dump_sortkey_table($$) my ($filename, $download) = @_; my @keys; - my ($part, $section, $subsection, $guid, $version); + my ($part, $section, $subsection, $guid, $version, $ling_flag); my @multiple_weights; my @expansions; my @compressions; - my @exceptions; - my @except_guid; + my %exceptions; my %guids; + my %compr_flags; my %locales; my $default_guid = "00000001-57ee-1e5c-00b4-d0000bb1e11e"; my $jamostr = ""; @@ -2488,6 +2488,8 @@ sub dump_sortkey_table($$) $guids{$guid} = { } unless defined $guids{$guid}; $guids{$guid}->{flags} |= $flags{$2} if $2; $guids{$guid}->{compr} = @compressions; + $exceptions{"$guid-"} = [ ] unless defined $exceptions{"$guid-"}; + $compr_flags{$guid} = [ ] unless defined $compr_flags{$guid}; push @compressions, [ ]; } else # merge with current one @@ -2495,6 +2497,7 @@ sub dump_sortkey_table($$) $guids{lc $1} = { } unless defined $guids{lc $1}; $guids{lc $1}->{flags} |= $flags{$2} if $2; $guids{lc $1}->{compr} = $guids{$guid}->{compr}; + $compr_flags{lc $1} = $compr_flags{$guid}; } next; } @@ -2510,7 +2513,10 @@ sub dump_sortkey_table($$) } if ($subsection && /^\s*(($re_hex\s+){2,8})$re_key/) { - push @{$compressions[$#compressions]}, [ split(/\s+/,$3), map { hex $_; } split(/\s+/,$1) ]; + my @comp = map { hex $_; } split(/\s+/,$1); + push @{$compressions[$#compressions]}, [ split(/\s+/,$3), @comp ]; + # add compression flags + $compr_flags{$guid}->[$comp[0]] |= @comp >= 6 ? 0xc0 : @comp >= 4 ? 0x80 : 0x40; next; } } @@ -2520,8 +2526,8 @@ sub dump_sortkey_table($$) { $guid = lc $1; $guids{$guid} = { } unless defined $guids{lc $1}; - push @except_guid, ($2 ? "+" : "-") . $guid; - push @exceptions, [ ]; + $ling_flag = ($2 ? "+" : "-"); + $exceptions{"$guid$ling_flag"} = [ ] unless defined $exceptions{"$guid$ling_flag"}; next; } if (/^\s*LOCALENAME\s+([A-Za-z0-9-_]+)/) @@ -2531,7 +2537,7 @@ sub dump_sortkey_table($$) } if (/^\s*($re_hex)\s+$re_key/) { - ${$exceptions[$#exceptions]}[hex $1] = [ split(/\s+/,$2) ]; + $exceptions{"$guid$ling_flag"}->[hex $1] = [ split(/\s+/,$2) ]; next; } } @@ -2556,17 +2562,19 @@ sub dump_sortkey_table($$) $table .= pack "C4", $k[1], $k[0], $k[2], $k[3]; } - for (my $i = 0; $i < @exceptions; $i++) + foreach my $id (sort keys %exceptions) { my $pos = length($table) / 4; - my @exc = @{$exceptions[$i]}; + my @exc = @{$exceptions{$id}}; my @filled; - my $key = (substr($except_guid[$i],0,1) eq "+" ? "ling_except" : "except"); - $guids{substr( $except_guid[$i], 1 )}->{$key} = $pos; + my $key = (substr( $id, -1 ) eq "+" ? "ling_except" : "except"); + my $guid = substr( $id, 0, -1 ); + $guids{$guid}->{$key} = $pos; $pos += 0x100; + my @flags = @{$compr_flags{$guid}} if defined $compr_flags{$guid}; for (my $j = 0; $j < 0x10000; $j++) { - next unless defined $exc[$j]; + next unless defined $exc[$j] || defined $flags[$j]; $filled[$j >> 8] = 1; $j |= 0xff; } @@ -2579,6 +2587,7 @@ sub dump_sortkey_table($$) { next unless $filled[$j >> 8]; my @k = defined $exc[$j] ? @{$exc[$j]} : defined $keys[$j] ? @{$keys[$j]} : (0) x 4; + $k[3] |= $flags[$j] || 0; $table .= pack "C4", $k[1], $k[0], $k[2], $k[3]; } }

1 0

Alexandre Julliard : make_makefiles: Remove updating codepage list, this is done by make_unicode now.
by Alexandre Julliard 18 Mar '20

18 Mar '20

Module: wine Branch: master Commit: 134074e553ac37ff54459e6fdda5673ffe30f725 URL: https://source.winehq.org/git/wine.git/?a=commit;h=134074e553ac37ff54459e6f… Author: Alexandre Julliard <julliard(a)winehq.org> Date: Wed Mar 18 16:39:47 2020 +0100 make_makefiles: Remove updating codepage list, this is done by make_unicode now. Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- tools/make_makefiles | 9 --------- 1 file changed, 9 deletions(-) diff --git a/tools/make_makefiles b/tools/make_makefiles index bae52dfdba..79b18778a5 100755 --- a/tools/make_makefiles +++ b/tools/make_makefiles @@ -498,15 +498,6 @@ sub update_wine_inf() push @lines, "\n[SortFiles]", sort grep(/^sort/, @nls_files); push @lines, "\n[WineSourceDirs]\n"; replace_in_file "loader/wine.inf.in", '^\[InfFiles\]', '^\[WineSourceDirs\]', join( "\n", @lines ); - - my @codepages = grep /c_\d+\.nls/, @nls_files; - @lines = ( "[Nls]" ); - foreach my $cp (sort { $a <=> $b; } map { /c_(\d+)\.nls/ && $1; } @codepages) - { - push @lines, sprintf "HKLM,System\\CurrentControlSet\\Control\\Nls\\Codepage,\"%u\",,\"c_%03u.nls\"", $cp, $cp; - } - push @lines, "\n"; - replace_in_file "loader/wine.inf.in", '^\[Nls\]', '^$', join( "\n", @lines ); } my $git_dir = $ENV{GIT_DIR} || ".git";

1 0

Jeff Smith : jscript: Fix typo in Object_toString fixme message.
by Alexandre Julliard 17 Mar '20

17 Mar '20

Module: wine Branch: master Commit: f2e4955d5a0c131fd59c54754527883faa9c55b9 URL: https://source.winehq.org/git/wine.git/?a=commit;h=f2e4955d5a0c131fd59c5475… Author: Jeff Smith <whydoubt(a)gmail.com> Date: Mon Mar 16 23:36:38 2020 -0500 jscript: Fix typo in Object_toString fixme message. Signed-off-by: Jeff Smith <whydoubt(a)gmail.com> Signed-off-by: Jacek Caban <jacek(a)codeweavers.com> Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- dlls/jscript/object.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/dlls/jscript/object.c b/dlls/jscript/object.c index 268cfaa1c3..bfc1a892df 100644 --- a/dlls/jscript/object.c +++ b/dlls/jscript/object.c @@ -81,7 +81,7 @@ static HRESULT Object_toString(script_ctx_t *ctx, vdisp_t *jsthis, WORD flags, u str = names[jsdisp->builtin_info->class]; }else { assert(jsdisp->builtin_info->class != JSCLASS_NONE); - FIXME("jdisp->builtin_info->class = %d\n", jsdisp->builtin_info->class); + FIXME("jsdisp->builtin_info->class = %d\n", jsdisp->builtin_info->class); return E_FAIL; }

1 0

Jacek Caban : mshtml/tests: Remove file protocol tests from htmllocation.c.
by Alexandre Julliard 17 Mar '20

17 Mar '20

Module: wine Branch: master Commit: fff82ac268dd305eb6631d02dfc61b8fb24d3951 URL: https://source.winehq.org/git/wine.git/?a=commit;h=fff82ac268dd305eb6631d02… Author: Jacek Caban <jacek(a)codeweavers.com> Date: Tue Mar 17 17:57:05 2020 +0100 mshtml/tests: Remove file protocol tests from htmllocation.c. It's broken on modern IEs anyway. Signed-off-by: Jacek Caban <jacek(a)codeweavers.com> Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- dlls/mshtml/tests/htmllocation.c | 12 ------------ 1 file changed, 12 deletions(-) diff --git a/dlls/mshtml/tests/htmllocation.c b/dlls/mshtml/tests/htmllocation.c index 120ab7e25c..0b1db9d2c7 100644 --- a/dlls/mshtml/tests/htmllocation.c +++ b/dlls/mshtml/tests/htmllocation.c @@ -87,18 +87,6 @@ static const struct location_test location_tests[] = { NULL, NULL }, - { - "FILE", - "file://C:\\windows\\win.ini", - "file:///C:/windows/win.ini", - "file:", - NULL, - NULL, - "", - "C:\\windows\\win.ini", - NULL, - NULL - } }; static int str_eq_wa(LPCWSTR strw, const char *stra)

1 0

Jacek Caban : dbghelp: Check checksum before mapping elf file.
by Alexandre Julliard 17 Mar '20

17 Mar '20

Module: wine Branch: master Commit: c1d867fa872fafe1e6cc54ba6da63868fb7a4a6f URL: https://source.winehq.org/git/wine.git/?a=commit;h=c1d867fa872fafe1e6cc54ba… Author: Jacek Caban <jacek(a)codeweavers.com> Date: Tue Mar 17 17:20:54 2020 +0100 dbghelp: Check checksum before mapping elf file. Signed-off-by: Jacek Caban <jacek(a)codeweavers.com> Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- dlls/dbghelp/elf_module.c | 40 +++++++++++++++++++++++++++++----------- 1 file changed, 29 insertions(+), 11 deletions(-) diff --git a/dlls/dbghelp/elf_module.c b/dlls/dbghelp/elf_module.c index 6bfd58b917..1ad37a24ed 100644 --- a/dlls/dbghelp/elf_module.c +++ b/dlls/dbghelp/elf_module.c @@ -326,7 +326,7 @@ static inline void elf_reset_file_map(struct image_file_map* fmap) struct elf_map_file_data { - enum {from_file, from_process} kind; + enum {from_file, from_process, from_handle} kind; union { struct @@ -338,6 +338,7 @@ struct elf_map_file_data HANDLE handle; void* load_addr; } process; + HANDLE handle; } u; }; @@ -351,6 +352,7 @@ static BOOL elf_map_file_read(struct image_file_map* fmap, struct elf_map_file_d switch (emfd->kind) { case from_file: + case from_handle: li.QuadPart = off; if (!SetFilePointerEx(fmap->u.elf.handle, li, NULL, FILE_BEGIN)) return FALSE; return ReadFile(fmap->u.elf.handle, buf, len, &bytes_read, NULL); @@ -444,6 +446,10 @@ static BOOL elf_map_file(struct elf_map_file_data* emfd, struct image_file_map* heap_free(dos_path); if (fmap->u.elf.handle == INVALID_HANDLE_VALUE) return FALSE; break; + case from_handle: + if (!DuplicateHandle(GetCurrentProcess(), emfd->u.handle, GetCurrentProcess(), &fmap->u.elf.handle, GENERIC_READ, FALSE, 0)) + return FALSE; + break; case from_process: break; } @@ -539,6 +545,7 @@ static BOOL elf_map_file(struct elf_map_file_data* emfd, struct image_file_map* switch (emfd->kind) { + case from_handle: case from_file: break; case from_process: if (!(fmap->u.elf.target_copy = HeapAlloc(GetProcessHeap(), 0, fmap->u.elf.elf_size))) @@ -558,6 +565,14 @@ static BOOL elf_map_file(struct elf_map_file_data* emfd, struct image_file_map* return TRUE; } +static BOOL elf_map_handle(HANDLE handle, struct image_file_map* fmap) +{ + struct elf_map_file_data emfd; + emfd.kind = from_handle; + emfd.u.handle = handle; + return elf_map_file(&emfd, fmap); +} + static void elf_module_remove(struct process* pcs, struct module_format* modfmt) { image_unmap_file(&modfmt->u.elf_info->file_map); @@ -968,21 +983,24 @@ static int elf_new_public_symbols(struct module* module, const struct hash_table static BOOL elf_check_debug_link(const WCHAR* file, struct image_file_map* fmap, DWORD link_crc) { - struct elf_map_file_data emfd; + HANDLE handle; + WCHAR *path; DWORD crc; + BOOL ret = FALSE; - emfd.kind = from_file; - emfd.u.file.filename = file; - if (!elf_map_file(&emfd, fmap)) return FALSE; + path = get_dos_file_name(file); + handle = CreateFileW(path, GENERIC_READ, FILE_SHARE_READ, NULL, OPEN_EXISTING, 0, NULL); + heap_free(path); + if (handle == INVALID_HANDLE_VALUE) return FALSE; - crc = calc_crc32(fmap->u.elf.handle); + crc = calc_crc32(handle); if (crc != link_crc) - { WARN("Bad CRC for file %s (got %08x while expecting %08x)\n", debugstr_w(file), crc, link_crc); - image_unmap_file(fmap); - return FALSE; - } - return TRUE; + else + ret = elf_map_handle(handle, fmap); + + CloseHandle(handle); + return ret; } /******************************************************************

1 0

Jacek Caban : dbghelp: Use elf_check_debug_link in elf_locate_build_id_target.
by Alexandre Julliard 17 Mar '20

17 Mar '20

Module: wine Branch: master Commit: 171c6fadab8eb444968c1b3a4b364e2e978a639a URL: https://source.winehq.org/git/wine.git/?a=commit;h=171c6fadab8eb444968c1b3a… Author: Jacek Caban <jacek(a)codeweavers.com> Date: Tue Mar 17 17:21:06 2020 +0100 dbghelp: Use elf_check_debug_link in elf_locate_build_id_target. Signed-off-by: Jacek Caban <jacek(a)codeweavers.com> Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- dlls/dbghelp/elf_module.c | 24 +++++++++++++----------- 1 file changed, 13 insertions(+), 11 deletions(-) diff --git a/dlls/dbghelp/elf_module.c b/dlls/dbghelp/elf_module.c index 1ad37a24ed..c89292a644 100644 --- a/dlls/dbghelp/elf_module.c +++ b/dlls/dbghelp/elf_module.c @@ -985,20 +985,25 @@ static BOOL elf_check_debug_link(const WCHAR* file, struct image_file_map* fmap, { HANDLE handle; WCHAR *path; - DWORD crc; - BOOL ret = FALSE; + BOOL ret; path = get_dos_file_name(file); handle = CreateFileW(path, GENERIC_READ, FILE_SHARE_READ, NULL, OPEN_EXISTING, 0, NULL); heap_free(path); if (handle == INVALID_HANDLE_VALUE) return FALSE; - crc = calc_crc32(handle); - if (crc != link_crc) - WARN("Bad CRC for file %s (got %08x while expecting %08x)\n", debugstr_w(file), crc, link_crc); - else - ret = elf_map_handle(handle, fmap); + if (link_crc) + { + DWORD crc = calc_crc32(handle); + if (crc != link_crc) + { + WARN("Bad CRC for file %s (got %08x while expecting %08x)\n", debugstr_w(file), crc, link_crc); + CloseHandle(handle); + return FALSE; + } + } + ret = elf_map_handle(handle, fmap); CloseHandle(handle); return ret; } @@ -1094,7 +1099,6 @@ static BOOL elf_locate_build_id_target(struct image_file_map* fmap, const BYTE* WCHAR* p; WCHAR* z; const BYTE* idend = id + idlen; - struct elf_map_file_data emfd; fmap_link = HeapAlloc(GetProcessHeap(), 0, sizeof(*fmap_link)); if (!fmap_link) return FALSE; @@ -1125,9 +1129,7 @@ static BOOL elf_locate_build_id_target(struct image_file_map* fmap, const BYTE* memcpy(z, dotDebug0W, sizeof(dotDebug0W)); TRACE("checking %s\n", wine_dbgstr_w(p)); - emfd.kind = from_file; - emfd.u.file.filename = p; - if (elf_map_file(&emfd, fmap_link)) + if (elf_check_debug_link(p, fmap_link, 0)) { struct image_section_map buildid_sect; if (image_find_section(fmap_link, ".note.gnu.build-id", &buildid_sect))

1 0

Jacek Caban : dbghelp: Move get_dos_file_name to path.c.
by Alexandre Julliard 17 Mar '20

17 Mar '20

Module: wine Branch: master Commit: d38682397997c56359f6d161467a56ffe5bfa9fa URL: https://source.winehq.org/git/wine.git/?a=commit;h=d38682397997c56359f6d161… Author: Jacek Caban <jacek(a)codeweavers.com> Date: Tue Mar 17 17:21:17 2020 +0100 dbghelp: Move get_dos_file_name to path.c. Signed-off-by: Jacek Caban <jacek(a)codeweavers.com> Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- dlls/dbghelp/dbghelp_private.h | 1 + dlls/dbghelp/elf_module.c | 23 ----------------------- dlls/dbghelp/path.c | 24 ++++++++++++++++++++++++ 3 files changed, 25 insertions(+), 23 deletions(-) diff --git a/dlls/dbghelp/dbghelp_private.h b/dlls/dbghelp/dbghelp_private.h index b143216dd0..d55b018fa7 100644 --- a/dlls/dbghelp/dbghelp_private.h +++ b/dlls/dbghelp/dbghelp_private.h @@ -668,6 +668,7 @@ extern BOOL pdb_virtual_unwind(struct cpu_stack_walk *csw, DWORD_PTR ip, extern BOOL path_find_symbol_file(const struct process* pcs, const struct module* module, PCSTR full_path, const GUID* guid, DWORD dw1, DWORD dw2, WCHAR *buffer, BOOL* is_unmatched) DECLSPEC_HIDDEN; +extern WCHAR *get_dos_file_name(const WCHAR *filename) DECLSPEC_HIDDEN; /* pe_module.c */ extern BOOL pe_load_nt_header(HANDLE hProc, DWORD64 base, IMAGE_NT_HEADERS* nth) DECLSPEC_HIDDEN; diff --git a/dlls/dbghelp/elf_module.c b/dlls/dbghelp/elf_module.c index c89292a644..75f046105c 100644 --- a/dlls/dbghelp/elf_module.c +++ b/dlls/dbghelp/elf_module.c @@ -396,29 +396,6 @@ static BOOL elf_map_shdr(struct elf_map_file_data* emfd, struct image_file_map* return TRUE; } -static WCHAR *get_dos_file_name(const WCHAR *filename) -{ - WCHAR *dos_path; - size_t len; - - if (*filename == '/') - { - char *unix_path; - len = WideCharToMultiByte(CP_UNIXCP, 0, filename, -1, NULL, 0, NULL, NULL); - unix_path = heap_alloc(len * sizeof(WCHAR)); - WideCharToMultiByte(CP_UNIXCP, 0, filename, -1, unix_path, len, NULL, NULL); - dos_path = wine_get_dos_file_name(unix_path); - heap_free(unix_path); - } - else - { - len = lstrlenW(filename); - dos_path = heap_alloc((len + 1) * sizeof(WCHAR)); - memcpy(dos_path, filename, (len + 1) * sizeof(WCHAR)); - } - return dos_path; -} - /****************************************************************** * elf_map_file * diff --git a/dlls/dbghelp/path.c b/dlls/dbghelp/path.c index 014c79c479..feb951ad55 100644 --- a/dlls/dbghelp/path.c +++ b/dlls/dbghelp/path.c @@ -27,6 +27,7 @@ #include "winnls.h" #include "winternl.h" #include "wine/debug.h" +#include "wine/heap.h" WINE_DEFAULT_DEBUG_CHANNEL(dbghelp); @@ -696,3 +697,26 @@ BOOL path_find_symbol_file(const struct process* pcs, const struct module* modul } return FALSE; } + +WCHAR *get_dos_file_name(const WCHAR *filename) +{ + WCHAR *dos_path; + size_t len; + + if (*filename == '/') + { + char *unix_path; + len = WideCharToMultiByte(CP_UNIXCP, 0, filename, -1, NULL, 0, NULL, NULL); + unix_path = heap_alloc(len * sizeof(WCHAR)); + WideCharToMultiByte(CP_UNIXCP, 0, filename, -1, unix_path, len, NULL, NULL); + dos_path = wine_get_dos_file_name(unix_path); + heap_free(unix_path); + } + else + { + len = lstrlenW(filename); + dos_path = heap_alloc((len + 1) * sizeof(WCHAR)); + memcpy(dos_path, filename, (len + 1) * sizeof(WCHAR)); + } + return dos_path; +}

1 0

Jacek Caban : dbghelp: Move elf_check_alternate implementation to module.c.
by Alexandre Julliard 17 Mar '20

17 Mar '20

Module: wine Branch: master Commit: 4694801e4f58f0e856327d251ac98cfb573fd83b URL: https://source.winehq.org/git/wine.git/?a=commit;h=4694801e4f58f0e856327d25… Author: Jacek Caban <jacek(a)codeweavers.com> Date: Tue Mar 17 20:10:40 2020 +0100 dbghelp: Move elf_check_alternate implementation to module.c. Signed-off-by: Jacek Caban <jacek(a)codeweavers.com> Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- dlls/dbghelp/elf_module.c | 247 ++----------------------------------------- dlls/dbghelp/image_private.h | 7 ++ dlls/dbghelp/module.c | 239 +++++++++++++++++++++++++++++++++++++++++ 3 files changed, 253 insertions(+), 240 deletions(-) Diff: https://source.winehq.org/git/wine.git/?a=commitdiff;h=4694801e4f58f0e85632…

1 0

Jacek Caban : dbghelp: Support GNU debug link and build id in PE files.
by Alexandre Julliard 17 Mar '20

17 Mar '20

Module: wine Branch: master Commit: 0dd495868846f30d9bb8f15f389d2b1ff6f383cb URL: https://source.winehq.org/git/wine.git/?a=commit;h=0dd495868846f30d9bb8f15f… Author: Jacek Caban <jacek(a)codeweavers.com> Date: Tue Mar 17 17:21:45 2020 +0100 dbghelp: Support GNU debug link and build id in PE files. Signed-off-by: Jacek Caban <jacek(a)codeweavers.com> Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- dlls/dbghelp/pe_module.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/dlls/dbghelp/pe_module.c b/dlls/dbghelp/pe_module.c index 17db805515..8c120e00dc 100644 --- a/dlls/dbghelp/pe_module.c +++ b/dlls/dbghelp/pe_module.c @@ -723,7 +723,8 @@ BOOL pe_load_debug_info(const struct process* pcs, struct module* module) if (!(dbghelp_options & SYMOPT_PUBLICS_ONLY)) { - ret = pe_load_stabs(pcs, module); + ret = image_check_alternate(&module->format_info[DFI_PE]->u.pe_info->fmap, module); + ret = pe_load_stabs(pcs, module) || ret; ret = pe_load_dwarf(module) || ret; ret = pe_load_msc_debug_info(pcs, module) || ret; ret = ret || pe_load_coff_symbol_table(module); /* FIXME */

1 0

Jacek Caban : dbghelp: Support PE debug link files.
by Alexandre Julliard 17 Mar '20

17 Mar '20

Module: wine Branch: master Commit: 2642f43eabe6c61341daee24487372b57723894d URL: https://source.winehq.org/git/wine.git/?a=commit;h=2642f43eabe6c61341daee24… Author: Jacek Caban <jacek(a)codeweavers.com> Date: Tue Mar 17 17:21:58 2020 +0100 dbghelp: Support PE debug link files. Signed-off-by: Jacek Caban <jacek(a)codeweavers.com> Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- dlls/dbghelp/image_private.h | 1 + dlls/dbghelp/module.c | 8 +++++++- 2 files changed, 8 insertions(+), 1 deletion(-) diff --git a/dlls/dbghelp/image_private.h b/dlls/dbghelp/image_private.h index a219427d46..2e1d9299e5 100644 --- a/dlls/dbghelp/image_private.h +++ b/dlls/dbghelp/image_private.h @@ -136,6 +136,7 @@ struct image_section_map BOOL image_check_alternate(struct image_file_map* fmap, const struct module* module) DECLSPEC_HIDDEN; BOOL elf_map_handle(HANDLE handle, struct image_file_map* fmap) DECLSPEC_HIDDEN; +BOOL pe_map_file(HANDLE file, struct image_file_map* fmap, enum module_type mt) DECLSPEC_HIDDEN; struct image_file_map_ops { diff --git a/dlls/dbghelp/module.c b/dlls/dbghelp/module.c index 32cb1caf32..9c8fb662f0 100644 --- a/dlls/dbghelp/module.c +++ b/dlls/dbghelp/module.c @@ -540,8 +540,10 @@ static BOOL refresh_module_list(struct process* pcs) static BOOL image_check_debug_link(const WCHAR* file, struct image_file_map* fmap, DWORD link_crc) { + DWORD read_bytes; HANDLE handle; WCHAR *path; + WORD magic; BOOL ret; path = get_dos_file_name(file); @@ -560,7 +562,11 @@ static BOOL image_check_debug_link(const WCHAR* file, struct image_file_map* fma } } - ret = elf_map_handle(handle, fmap); + SetFilePointer(handle, 0, 0, FILE_BEGIN); + if (ReadFile(handle, &magic, sizeof(magic), &read_bytes, NULL) && magic == IMAGE_DOS_SIGNATURE) + ret = pe_map_file(handle, fmap, DMT_PE); + else + ret = elf_map_handle(handle, fmap); CloseHandle(handle); return ret; }

1 0