March 2021 - Wine-commits - list.winehq.org

Owen Rudge : winspool: Filter invalid characters when creating the PPD filename.
by Alexandre Julliard 10 Mar '21

10 Mar '21

Module: wine Branch: master Commit: 6b906e82371513e9f5b94fa2d67ad8e0ee865335 URL: https://source.winehq.org/git/wine.git/?a=commit;h=6b906e82371513e9f5b94fa2… Author: Owen Rudge <orudge(a)codeweavers.com> Date: Wed Mar 10 12:26:50 2021 +0000 winspool: Filter invalid characters when creating the PPD filename. Fixes potential crash when trying to print if a CUPS printer name contains an asterisk. Signed-off-by: Owen Rudge <orudge(a)codeweavers.com> Signed-off-by: Huw Davies <huw(a)codeweavers.com> Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- dlls/winspool.drv/info.c | 15 ++++++++++----- 1 file changed, 10 insertions(+), 5 deletions(-) diff --git a/dlls/winspool.drv/info.c b/dlls/winspool.drv/info.c index fb9c1599d38..4d0542d20e3 100644 --- a/dlls/winspool.drv/info.c +++ b/dlls/winspool.drv/info.c @@ -721,13 +721,18 @@ fail: static WCHAR *get_ppd_filename( const WCHAR *dir, const WCHAR *file_name ) { static const WCHAR dot_ppd[] = {'.','p','p','d',0}; - int len = (strlenW( dir ) + strlenW( file_name )) * sizeof(WCHAR) + sizeof(dot_ppd); - WCHAR *ppd = HeapAlloc( GetProcessHeap(), 0, len ); + static const WCHAR invalid_chars[] = {'*','?','<','>','|','"','/','\\',0}; + int dir_len = strlenW( dir ), file_len = strlenW( file_name ); + int len = (dir_len + file_len + ARRAY_SIZE( dot_ppd )) * sizeof(WCHAR); + WCHAR *ppd = HeapAlloc( GetProcessHeap(), 0, len ), *p; if (!ppd) return NULL; - strcpyW( ppd, dir ); - strcatW( ppd, file_name ); - strcatW( ppd, dot_ppd ); + memcpy( ppd, dir, dir_len * sizeof(WCHAR) ); + memcpy( ppd + dir_len, file_name, file_len * sizeof(WCHAR) ); + memcpy( ppd + dir_len + file_len, dot_ppd, sizeof(dot_ppd) ); + + p = ppd + dir_len; + while ((p = strpbrkW( p, invalid_chars ))) *p++ = '_'; return ppd; }

1 0

Jacek Caban : include: Add IHTMLElement7 declaration.
by Alexandre Julliard 10 Mar '21

10 Mar '21

Module: wine Branch: master Commit: 48e65244e0cabce8194b738eb93dddca664ac568 URL: https://source.winehq.org/git/wine.git/?a=commit;h=48e65244e0cabce8194b738e… Author: Jacek Caban <jacek(a)codeweavers.com> Date: Wed Mar 10 14:57:52 2021 +0100 include: Add IHTMLElement7 declaration. Signed-off-by: Jacek Caban <jacek(a)codeweavers.com> Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- include/mshtmdid.h | 35 ++++++ include/mshtml.idl | 353 ++++++++++++++++++++++++++++++++++++++++++++++++++++- 2 files changed, 382 insertions(+), 6 deletions(-) Diff: https://source.winehq.org/git/wine.git/?a=commitdiff;h=48e65244e0cabce8194b…

1 0

Jacek Caban : mshtml: Add IHTMLElement7 stub implementation.
by Alexandre Julliard 10 Mar '21

10 Mar '21

Module: wine Branch: master Commit: 097ca893357b393c4eeb270ace86cad8779c3658 URL: https://source.winehq.org/git/wine.git/?a=commit;h=097ca893357b393c4eeb270a… Author: Jacek Caban <jacek(a)codeweavers.com> Date: Wed Mar 10 14:58:05 2021 +0100 mshtml: Add IHTMLElement7 stub implementation. Signed-off-by: Jacek Caban <jacek(a)codeweavers.com> Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- dlls/mshtml/htmlelem.c | 499 +++++++++++++++++++++++++++++++++++++++++++ dlls/mshtml/mshtml_private.h | 2 + 2 files changed, 501 insertions(+) Diff: https://source.winehq.org/git/wine.git/?a=commitdiff;h=097ca893357b393c4eeb…

1 0

Jacek Caban : mshtml: Expose IHTMLElement7 to scripts.
by Alexandre Julliard 10 Mar '21

10 Mar '21

Module: wine Branch: master Commit: 926d662e3607bfb7b7cc59fb98460f36466f6858 URL: https://source.winehq.org/git/wine.git/?a=commit;h=926d662e3607bfb7b7cc59fb… Author: Jacek Caban <jacek(a)codeweavers.com> Date: Wed Mar 10 14:58:17 2021 +0100 mshtml: Expose IHTMLElement7 to scripts. Signed-off-by: Jacek Caban <jacek(a)codeweavers.com> Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- dlls/mshtml/htmlelem.c | 3 +++ dlls/mshtml/tests/documentmode.js | 2 ++ 2 files changed, 5 insertions(+) diff --git a/dlls/mshtml/htmlelem.c b/dlls/mshtml/htmlelem.c index 2d4a8e8113f..b7aca01c3c1 100644 --- a/dlls/mshtml/htmlelem.c +++ b/dlls/mshtml/htmlelem.c @@ -6273,6 +6273,9 @@ void HTMLElement_init_dispex_info(dispex_data_t *info, compat_mode_t mode) dispex_info_add_interface(info, IHTMLElement6_tid, NULL); dispex_info_add_interface(info, IElementTraversal_tid, NULL); } + + if(mode >= COMPAT_MODE_IE10) + dispex_info_add_interface(info, IHTMLElement7_tid, NULL); } static const tid_t HTMLElement_iface_tids[] = { diff --git a/dlls/mshtml/tests/documentmode.js b/dlls/mshtml/tests/documentmode.js index 75ebe082ce0..d61d3658151 100644 --- a/dlls/mshtml/tests/documentmode.js +++ b/dlls/mshtml/tests/documentmode.js @@ -42,6 +42,8 @@ sync_test("elem_props", function() { test_exposed("addEventListener", v >= 9); test_exposed("removeEventListener", v >= 9); test_exposed("dispatchEvent", v >= 9); + test_exposed("msSetPointerCapture", v >= 10); + if (v >= 9) test_exposed("spellcheck", v >= 10); }); sync_test("doc_props", function() {

1 0

Jacek Caban : mshtml: Add IHTMLElement7::spellcheck property implementation.
by Alexandre Julliard 10 Mar '21

10 Mar '21

Module: wine Branch: master Commit: 44dbb88ce417deb8515991aa0a82bc7b344185e2 URL: https://source.winehq.org/git/wine.git/?a=commit;h=44dbb88ce417deb8515991aa… Author: Jacek Caban <jacek(a)codeweavers.com> Date: Wed Mar 10 14:58:29 2021 +0100 mshtml: Add IHTMLElement7::spellcheck property implementation. Signed-off-by: Jacek Caban <jacek(a)codeweavers.com> Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- dlls/mshtml/htmlelem.c | 35 +++++++++++++++++++++++++++++++---- dlls/mshtml/tests/dom.c | 43 +++++++++++++++++++++++++++++++++++++++++++ 2 files changed, 74 insertions(+), 4 deletions(-) diff --git a/dlls/mshtml/htmlelem.c b/dlls/mshtml/htmlelem.c index b7aca01c3c1..f93e015f559 100644 --- a/dlls/mshtml/htmlelem.c +++ b/dlls/mshtml/htmlelem.c @@ -5414,15 +5414,42 @@ static HRESULT WINAPI HTMLElement7_get_xmsAcceleratorKey(IHTMLElement7 *iface, B static HRESULT WINAPI HTMLElement7_put_spellcheck(IHTMLElement7 *iface, VARIANT v) { HTMLElement *This = impl_from_IHTMLElement7(iface); - FIXME("(%p)->(%s)\n", This, debugstr_variant(&v)); - return E_NOTIMPL; + + TRACE("(%p)->(%s)\n", This, debugstr_variant(&v)); + + if(!This->html_element) { + FIXME("non-HTML element\n"); + return E_NOTIMPL; + } + + if(V_VT(&v) != VT_BOOL) { + FIXME("unsupported argument %s\n", debugstr_variant(&v)); + return E_NOTIMPL; + } + + return map_nsresult(nsIDOMHTMLElement_SetSpellcheck(This->html_element, !!V_BOOL(&v))); } static HRESULT WINAPI HTMLElement7_get_spellcheck(IHTMLElement7 *iface, VARIANT *p) { HTMLElement *This = impl_from_IHTMLElement7(iface); - FIXME("(%p)->(%p)\n", This, p); - return E_NOTIMPL; + cpp_bool spellcheck; + nsresult nsres; + + TRACE("(%p)->(%p)\n", This, p); + + if(!This->html_element) { + FIXME("non-HTML element\n"); + return E_NOTIMPL; + } + + nsres = nsIDOMHTMLElement_GetSpellcheck(This->html_element, &spellcheck); + if(NS_FAILED(nsres)) + return map_nsresult(nsres); + + V_VT(p) = VT_BOOL; + V_BOOL(p) = spellcheck ? VARIANT_TRUE : VARIANT_FALSE; + return S_OK; } static HRESULT WINAPI HTMLElement7_put_onmsmanipulationstatechanged(IHTMLElement7 *iface, VARIANT v) diff --git a/dlls/mshtml/tests/dom.c b/dlls/mshtml/tests/dom.c index 94923d83add..ebed27b48e8 100644 --- a/dlls/mshtml/tests/dom.c +++ b/dlls/mshtml/tests/dom.c @@ -8369,6 +8369,48 @@ static void test_iframe_elem(IHTMLElement *elem) IHTMLDocument2_Release(content_doc); } +static void test_elem_spellcheck(IHTMLElement *iface) +{ + IHTMLElement7 *elem; + VARIANT v; + HRESULT hres; + + hres = IUnknown_QueryInterface(iface, &IID_IHTMLElement7, (void**)&elem); + if(hres == E_NOINTERFACE) { + win_skip("IHTMLElement7 not supported\n"); + return; + } + ok(hres == S_OK, "Could not get IHTMLElement7 interface: %08x\n", hres); + + V_VT(&v) = VT_ERROR; + hres = IHTMLElement7_get_spellcheck(elem, &v); + ok(hres == S_OK, "get_spellcheck failed: %08x\n", hres); + ok(V_VT(&v) == VT_BOOL && !V_BOOL(&v), "spellcheck = %s\n", wine_dbgstr_variant(&v)); + + V_VT(&v) = VT_BOOL; + V_BOOL(&v) = VARIANT_TRUE; + hres = IHTMLElement7_put_spellcheck(elem, v); + ok(hres == S_OK, "put_spellcheck failed: %08x\n", hres); + + V_VT(&v) = VT_ERROR; + hres = IHTMLElement7_get_spellcheck(elem, &v); + ok(hres == S_OK, "get_spellcheck failed: %08x\n", hres); + ok(V_VT(&v) == VT_BOOL && V_BOOL(&v) == VARIANT_TRUE, "spellcheck = %s\n", + wine_dbgstr_variant(&v)); + + V_VT(&v) = VT_BOOL; + V_BOOL(&v) = VARIANT_FALSE; + hres = IHTMLElement7_put_spellcheck(elem, v); + ok(hres == S_OK, "put_spellcheck failed: %08x\n", hres); + + V_VT(&v) = VT_ERROR; + hres = IHTMLElement7_get_spellcheck(elem, &v); + ok(hres == S_OK, "get_spellcheck failed: %08x\n", hres); + ok(V_VT(&v) == VT_BOOL && !V_BOOL(&v), "spellcheck = %s\n", wine_dbgstr_variant(&v)); + + IHTMLElement7_Release(elem); +} + #define test_stylesheet_csstext(a,b,c) _test_stylesheet_csstext(__LINE__,a,b,c) static void _test_stylesheet_csstext(unsigned line, IHTMLStyleSheet *stylesheet, const WCHAR *exstr, BOOL is_todo) { @@ -8981,6 +9023,7 @@ static void test_elems(IHTMLDocument2 *doc) test_elem_client_size((IUnknown*)elem); test_input_type(input, L"text"); test_elem_istextedit(elem, VARIANT_TRUE); + test_elem_spellcheck(elem); test_node_get_value_str((IUnknown*)elem, NULL); test_node_put_value_str((IUnknown*)elem, L"test");

1 0

Jacek Caban : mshtml/tests: Use more winetest.js helpers in more places.
by Alexandre Julliard 10 Mar '21

10 Mar '21

Module: wine Branch: master Commit: e06c541cb6ccaf9140c9b7637170194d1f8041c6 URL: https://source.winehq.org/git/wine.git/?a=commit;h=e06c541cb6ccaf9140c9b763… Author: Jacek Caban <jacek(a)codeweavers.com> Date: Wed Mar 10 14:59:02 2021 +0100 mshtml/tests: Use more winetest.js helpers in more places. Signed-off-by: Jacek Caban <jacek(a)codeweavers.com> Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- dlls/mshtml/tests/dom.js | 113 +++++++++++------------------------ dlls/mshtml/tests/events.js | 142 ++++++++++++++------------------------------ 2 files changed, 80 insertions(+), 175 deletions(-) Diff: https://source.winehq.org/git/wine.git/?a=commitdiff;h=e06c541cb6ccaf9140c9…

1 0

Jacek Caban : mshtml: Add animationstart and animationend event support.
by Alexandre Julliard 10 Mar '21

10 Mar '21

Module: wine Branch: master Commit: cdb264e871c273abb70022a40dbf890de45bc483 URL: https://source.winehq.org/git/wine.git/?a=commit;h=cdb264e871c273abb70022a4… Author: Jacek Caban <jacek(a)codeweavers.com> Date: Wed Mar 10 14:59:20 2021 +0100 mshtml: Add animationstart and animationend event support. Signed-off-by: Jacek Caban <jacek(a)codeweavers.com> Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- dlls/mshtml/htmlevent.c | 6 ++++++ dlls/mshtml/htmlevent.h | 2 ++ dlls/mshtml/tests/dom.js | 14 ++++++++++++++ 3 files changed, 22 insertions(+) diff --git a/dlls/mshtml/htmlevent.c b/dlls/mshtml/htmlevent.c index 1befd94c742..da2d59bc894 100644 --- a/dlls/mshtml/htmlevent.c +++ b/dlls/mshtml/htmlevent.c @@ -109,6 +109,10 @@ typedef struct { static const event_info_t event_info[] = { {L"abort", EVENT_TYPE_EVENT, DISPID_EVMETH_ONABORT, EVENT_BIND_TO_TARGET}, + {L"animationend", EVENT_TYPE_EVENT, DISPID_EVPROP_ONANIMATIONEND, + EVENT_DEFAULTLISTENER | EVENT_BUBBLES}, + {L"animationstart", EVENT_TYPE_EVENT, DISPID_EVPROP_ONANIMATIONSTART, + EVENT_DEFAULTLISTENER | EVENT_BUBBLES}, {L"beforeactivate", EVENT_TYPE_EVENT, DISPID_EVMETH_ONBEFOREACTIVATE, EVENT_FIXME | EVENT_BUBBLES | EVENT_CANCELABLE}, {L"beforeunload", EVENT_TYPE_EVENT, DISPID_EVMETH_ONBEFOREUNLOAD, @@ -185,6 +189,8 @@ static const event_info_t event_info[] = { EVENT_FIXME} }; +C_ASSERT(ARRAY_SIZE(event_info) == EVENTID_LAST); + static eventid_t str_to_eid(const WCHAR *str) { int i; diff --git a/dlls/mshtml/htmlevent.h b/dlls/mshtml/htmlevent.h index c5d9753722a..69655d2a4ee 100644 --- a/dlls/mshtml/htmlevent.h +++ b/dlls/mshtml/htmlevent.h @@ -18,6 +18,8 @@ typedef enum { EVENTID_ABORT, + EVENTID_ANIMATIONEND, + EVENTID_ANIMATIONSTART, EVENTID_BEFOREACTIVATE, EVENTID_BEFOREUNLOAD, EVENTID_BLUR, diff --git a/dlls/mshtml/tests/dom.js b/dlls/mshtml/tests/dom.js index 0064690ee36..7fc6b87882c 100644 --- a/dlls/mshtml/tests/dom.js +++ b/dlls/mshtml/tests/dom.js @@ -401,3 +401,17 @@ sync_test("storage", function() { ok(typeof(window.localStorage) === "object", "typeof(window.localStorage) = " + typeof(window.localStorage)); }); + +async_test("animation", function() { + document.body.innerHTML = + "<style>" + + " @keyframes testAnimation {0% { opacity: 0; } 100% { opacity: 1; }}" + + " .testAnimation { animation-name: testAnimation; animation-duration: 0.01s; }" + + "</style>"; + var div = document.createElement("div"); + div.addEventListener("animationstart", function() { + div.addEventListener("animationend", next_test); + }); + document.body.appendChild(div); + div.className = "testAnimation"; +});

1 0

Jacek Caban : jscript: Print source location in backtraces.
by Alexandre Julliard 10 Mar '21

10 Mar '21

Module: wine Branch: master Commit: 2986821b933c239b1b16def8eb87bc0df3ed1d91 URL: https://source.winehq.org/git/wine.git/?a=commit;h=2986821b933c239b1b16def8… Author: Jacek Caban <jacek(a)codeweavers.com> Date: Wed Mar 10 14:59:57 2021 +0100 jscript: Print source location in backtraces. Signed-off-by: Jacek Caban <jacek(a)codeweavers.com> Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- dlls/jscript/compile.c | 14 ++++++++++++++ dlls/jscript/engine.c | 5 +++-- dlls/jscript/engine.h | 2 ++ dlls/jscript/jscript.c | 14 ++++---------- 4 files changed, 23 insertions(+), 12 deletions(-) diff --git a/dlls/jscript/compile.c b/dlls/jscript/compile.c index a1d1171e2ec..dea8db1f37e 100644 --- a/dlls/jscript/compile.c +++ b/dlls/jscript/compile.c @@ -2236,6 +2236,20 @@ static void resolve_labels(compiler_ctx_t *ctx, unsigned off) ctx->labels_cnt = 0; } +unsigned get_location_line(bytecode_t *code, unsigned loc, unsigned *char_pos) +{ + unsigned line = code->start_line; + const WCHAR *nl, *p; + + for(nl = p = code->source; p < code->source + loc; p++) { + if(*p != '\n') continue; + line++; + nl = p + 1; + } + *char_pos = loc - (nl - code->source); + return line; +} + void release_bytecode(bytecode_t *code) { unsigned i; diff --git a/dlls/jscript/engine.c b/dlls/jscript/engine.c index 0fdcb13f142..e1c3783196f 100644 --- a/dlls/jscript/engine.c +++ b/dlls/jscript/engine.c @@ -2703,7 +2703,7 @@ static void pop_call_frame(script_ctx_t *ctx) static void print_backtrace(script_ctx_t *ctx) { - unsigned depth = 0, i; + unsigned depth = 0, i, line, char_pos; call_frame_t *frame; for(frame = ctx->call_ctx; frame; frame = frame->prev_frame) { @@ -2724,7 +2724,8 @@ static void print_backtrace(script_ctx_t *ctx) }else { WARN("[detached frame]"); } - WARN(")\n"); + line = get_location_line(frame->bytecode, frame->bytecode->instrs[frame->ip].loc, &char_pos); + WARN(") context %s line %u char %u\n", wine_dbgstr_longlong(frame->bytecode->source_context), line, char_pos); if(!(frame->flags & EXEC_RETURN_TO_INTERP)) { WARN("%u\t[native code]\n", depth); diff --git a/dlls/jscript/engine.h b/dlls/jscript/engine.h index 2a8e405a28f..eca27cb1460 100644 --- a/dlls/jscript/engine.h +++ b/dlls/jscript/engine.h @@ -201,6 +201,8 @@ struct _bytecode_t { HRESULT compile_script(script_ctx_t*,const WCHAR*,UINT64,unsigned,const WCHAR*,const WCHAR*,BOOL,BOOL,named_item_t*,bytecode_t**) DECLSPEC_HIDDEN; void release_bytecode(bytecode_t*) DECLSPEC_HIDDEN; +unsigned get_location_line(bytecode_t *code, unsigned loc, unsigned *char_pos) DECLSPEC_HIDDEN; + static inline bytecode_t *bytecode_addref(bytecode_t *code) { code->ref++; diff --git a/dlls/jscript/jscript.c b/dlls/jscript/jscript.c index 8e729a04324..c5c23889f04 100644 --- a/dlls/jscript/jscript.c +++ b/dlls/jscript/jscript.c @@ -257,8 +257,7 @@ static HRESULT WINAPI JScriptError_GetSourcePosition(IActiveScriptError *iface, { JScriptError *This = impl_from_IActiveScriptError(iface); bytecode_t *code = This->ei.code; - const WCHAR *nl, *p; - unsigned l; + unsigned line_pos, char_pos; TRACE("(%p)->(%p %p %p)\n", This, source_context, line, character); @@ -272,16 +271,11 @@ static HRESULT WINAPI JScriptError_GetSourcePosition(IActiveScriptError *iface, if(!line && !character) return S_OK; - l = code->start_line; - for(nl = p = code->source; p < code->source + This->ei.loc; p++) { - if(*p != '\n') continue; - l++; - nl = p + 1; - } + line_pos = get_location_line(code, This->ei.loc, &char_pos); if(line) - *line = l; + *line = line_pos; if(character) - *character = code->source + This->ei.loc - nl; + *character = char_pos; return S_OK; }

1 0

Zebediah Figura : strmbase: Do not pretend to drop samples.
by Alexandre Julliard 10 Mar '21

10 Mar '21

Module: wine Branch: master Commit: b9393d08e1491d5fcd36ee926bb891a0326bf52c URL: https://source.winehq.org/git/wine.git/?a=commit;h=b9393d08e1491d5fcd36ee92… Author: Zebediah Figura <z.figura12(a)gmail.com> Date: Tue Mar 9 16:19:54 2021 -0600 strmbase: Do not pretend to drop samples. Signed-off-by: Zebediah Figura <z.figura12(a)gmail.com> Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- dlls/strmbase/renderer.c | 38 +++----------------------------------- include/wine/strmbase.h | 3 +-- 2 files changed, 4 insertions(+), 37 deletions(-) diff --git a/dlls/strmbase/renderer.c b/dlls/strmbase/renderer.c index ec915a95ef8..ed815097a0f 100644 --- a/dlls/strmbase/renderer.c +++ b/dlls/strmbase/renderer.c @@ -59,39 +59,9 @@ WINE_DEFAULT_DEBUG_CHANNEL(strmbase); static void QualityControlRender_Start(struct strmbase_qc *This, REFERENCE_TIME tStart) { - This->last_in_time = This->last_left = This->avg_duration = This->avg_pt = -1; + This->last_left = This->avg_duration = This->avg_pt = -1; This->clockstart = tStart; This->avg_rate = -1.0; - This->is_dropped = FALSE; -} - -static BOOL QualityControlRender_IsLate(struct strmbase_qc *This, REFERENCE_TIME jitter, - REFERENCE_TIME start, REFERENCE_TIME stop) -{ - REFERENCE_TIME max_lateness = 200000; - - TRACE("jitter %s, start %s, stop %s.\n", debugstr_time(jitter), - debugstr_time(start), debugstr_time(stop)); - - /* we can add a valid stop time */ - if (stop >= start) - max_lateness += stop; - else - max_lateness += start; - - /* if the jitter bigger than duration and lateness we are too late */ - if (start + jitter > max_lateness) { - WARN("buffer is too late %i > %i\n", (int)((start + jitter)/10000), (int)(max_lateness/10000)); - /* !!emergency!!, if we did not receive anything valid for more than a - * second, render it anyway so the user sees something */ - if (This->last_in_time < 0 || - start - This->last_in_time < 10000000) - return TRUE; - FIXME("A lot of buffers are being dropped.\n"); - FIXME("There may be a timestamping problem, or this computer is too slow.\n"); - } - This->last_in_time = start; - return FALSE; } static void QualityControlRender_DoQOS(struct strmbase_qc *priv) @@ -170,7 +140,7 @@ static void QualityControlRender_DoQOS(struct strmbase_qc *priv) if (priv->last_left >= 0) { - if (priv->is_dropped || priv->avg_rate < 0.0) + if (priv->avg_rate < 0.0) { priv->avg_rate = rate; } @@ -231,9 +201,7 @@ static void QualityControlRender_BeginRender(struct strmbase_qc *This, REFERENCE This->current_jitter = 0; } - /* FIXME: This isn't correct; we don't drop samples, nor should. */ - This->is_dropped = QualityControlRender_IsLate(This, This->current_jitter, start, stop); - TRACE("dropped %d, start %s, stop %s, jitter %s.\n", This->is_dropped, + TRACE("start %s, stop %s, jitter %s.\n", debugstr_time(start), debugstr_time(stop), debugstr_time(This->current_jitter)); } diff --git a/include/wine/strmbase.h b/include/wine/strmbase.h index 9df0437dd9a..c45e2a4513e 100644 --- a/include/wine/strmbase.h +++ b/include/wine/strmbase.h @@ -279,10 +279,9 @@ struct strmbase_qc IQualityControl *tonotify; /* Render stuff */ - REFERENCE_TIME last_in_time, last_left, avg_duration, avg_pt; + REFERENCE_TIME last_left, avg_duration, avg_pt; REFERENCE_TIME current_jitter, current_rstart, current_rstop, clockstart; double avg_rate; - BOOL is_dropped; }; struct strmbase_renderer

1 0

Zebediah Figura : strmbase: Inline the strmbase_qc structure into struct strmbase_renderer.
by Alexandre Julliard 10 Mar '21

10 Mar '21

Module: wine Branch: master Commit: 1564d658681822c3f34adfd16e3124922393286a URL: https://source.winehq.org/git/wine.git/?a=commit;h=1564d658681822c3f34adfd1… Author: Zebediah Figura <z.figura12(a)gmail.com> Date: Tue Mar 9 16:19:55 2021 -0600 strmbase: Inline the strmbase_qc structure into struct strmbase_renderer. Signed-off-by: Zebediah Figura <z.figura12(a)gmail.com> Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- dlls/strmbase/renderer.c | 152 ++++++++++++++++++++++------------------------- include/wine/strmbase.h | 19 ++---- 2 files changed, 78 insertions(+), 93 deletions(-) Diff: https://source.winehq.org/git/wine.git/?a=commitdiff;h=1564d658681822c3f34a…

1 0