September 2022 - Wine-commits

Zebediah Figura : tests: Mark test_hull_shader_relative_addressing() as broken on radv.
by Alexandre Julliard 19 Sep '22

19 Sep '22

Module: vkd3d Branch: master Commit: 53d6966a5df60402aae43ec362ccf547711d7bee URL: https://gitlab.winehq.org/wine/vkd3d/-/commit/53d6966a5df60402aae43ec362ccf… Author: Zebediah Figura <zfigura(a)codeweavers.com> Date: Sun Sep 11 18:35:59 2022 -0500 tests: Mark test_hull_shader_relative_addressing() as broken on radv. Broken for me with "AMD Radeon RX 560 Series (RADV POLARIS11)" (1002:67ef) but works with llvmpipe; Mesa 22.2.0-rc3. --- tests/d3d12.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tests/d3d12.c b/tests/d3d12.c index 531ea1a4..89bfab79 100644 --- a/tests/d3d12.c +++ b/tests/d3d12.c @@ -35338,7 +35338,7 @@ static void test_hull_shader_relative_addressing(void) transition_resource_state(command_list, so_buffer, D3D12_RESOURCE_STATE_STREAM_OUT, D3D12_RESOURCE_STATE_COPY_SOURCE); get_buffer_readback_with_command_list(so_buffer, DXGI_FORMAT_UNKNOWN, &rb, queue, command_list); - check_triangles(&rb.rb, &expected_triangle, 1); + bug_if(is_radv_device(context.device)) check_triangles(&rb.rb, &expected_triangle, 1); release_resource_readback(&rb); ID3D12Resource_Release(so_buffer);

1 0

Zebediah Figura : tests: Check for failure from init_test_context() in the d3d11 runner.
by Alexandre Julliard 19 Sep '22

19 Sep '22

Module: vkd3d Branch: master Commit: b7c94b02139e8f26a892f52b61d4451b6723dbd4 URL: https://gitlab.winehq.org/wine/vkd3d/-/commit/b7c94b02139e8f26a892f52b61d44… Author: Zebediah Figura <zfigura(a)codeweavers.com> Date: Fri Apr 22 13:56:30 2022 -0500 tests: Check for failure from init_test_context() in the d3d11 runner. --- tests/shader_runner_d3d11.c | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/tests/shader_runner_d3d11.c b/tests/shader_runner_d3d11.c index 8999622d..2314f6d7 100644 --- a/tests/shader_runner_d3d11.c +++ b/tests/shader_runner_d3d11.c @@ -627,9 +627,11 @@ void run_shader_tests_d3d11(int argc, char **argv) parse_args(argc, argv); enable_d3d11_debug_layer(argc, argv); init_adapter_info(); - init_test_context(&runner); - run_shader_tests(&runner.r, argc, argv, &d3d11_runner_ops); - destroy_test_context(&runner); + if (init_test_context(&runner)) + { + run_shader_tests(&runner.r, argc, argv, &d3d11_runner_ops); + destroy_test_context(&runner); + } } FreeLibrary(d3d11_module); FreeLibrary(dxgi_module);

1 0

Alistair Leslie-Hughes : wininet: Clear cached credentials after the first failed attempt.
by Alexandre Julliard 16 Sep '22

16 Sep '22

Module: wine Branch: master Commit: b9d07d6cb4d8a8b6bf70601ffc6628ff0169719d URL: https://gitlab.winehq.org/wine/wine/-/commit/b9d07d6cb4d8a8b6bf70601ffc6628… Author: Alistair Leslie-Hughes <leslie_alistair(a)hotmail.com> Date: Mon Oct 4 12:41:33 2021 +1100 wininet: Clear cached credentials after the first failed attempt. Windows when using cached credentials will use them on the first challenge, if then a second 403 (ACCESS_DENIED) is received, the user is prompted again but this time with the password and save checkbox cleared. Signed-off-by: Alistair Leslie-Hughes <leslie_alistair(a)hotmail.com> --- dlls/wininet/dialogs.c | 24 +++++++++++++++++++++++- dlls/wininet/internet.h | 1 + 2 files changed, 24 insertions(+), 1 deletion(-) diff --git a/dlls/wininet/dialogs.c b/dlls/wininet/dialogs.c index abd8621e76c..6b53a9f3272 100644 --- a/dlls/wininet/dialogs.c +++ b/dlls/wininet/dialogs.c @@ -152,9 +152,25 @@ static BOOL WININET_GetSetPassword( HWND hdlg, LPCWSTR szServer, p = wcschr( szUserPass, ':' ); if( p ) { + struct WININET_ErrorDlgParams *params; + HWND hwnd; + + params = (struct WININET_ErrorDlgParams*) + GetWindowLongPtrW( hdlg, GWLP_USERDATA ); + *p = 0; SetWindowTextW( hUserItem, szUserPass ); - SetWindowTextW( hPassItem, p+1 ); + + if (!params->req->clear_auth) + { + SetWindowTextW( hPassItem, p+1 ); + + hwnd = GetDlgItem( hdlg, IDC_SAVEPASSWORD ); + if (hwnd) + SendMessageW(hwnd, BM_SETCHECK, BST_CHECKED, 0); + } + else + WININET_GetSetPassword( hdlg, szServer, szRealm, TRUE ); } return TRUE; @@ -264,6 +280,8 @@ static INT_PTR WINAPI WININET_ProxyPasswordDialog( WININET_GetSetPassword( hdlg, params->req->session->appInfo->proxy, szRealm, TRUE ); WININET_SetAuthorization( params->req, username, password, TRUE ); + params->req->clear_auth = TRUE; + EndDialog( hdlg, ERROR_INTERNET_FORCE_RETRY ); return TRUE; } @@ -340,6 +358,7 @@ static INT_PTR WINAPI WININET_PasswordDialog( WININET_GetSetPassword( hdlg, params->req->session->hostName, szRealm, TRUE ); } WININET_SetAuthorization( params->req, username, password, FALSE ); + params->req->clear_auth = TRUE; EndDialog( hdlg, ERROR_INTERNET_FORCE_RETRY ); return TRUE; @@ -509,6 +528,9 @@ DWORD WINAPI InternetErrorDlg(HWND hWnd, HINTERNET hRequest, res = DialogBoxParamW( WININET_hModule, MAKEINTRESOURCEW( IDD_AUTHDLG ), hWnd, WININET_PasswordDialog, (LPARAM) &params ); break; + case HTTP_STATUS_OK: + req->clear_auth = FALSE; + break; default: WARN("unhandled status %lu\n", req->status_code); } diff --git a/dlls/wininet/internet.h b/dlls/wininet/internet.h index b361c0d1b4d..141613dd120 100644 --- a/dlls/wininet/internet.h +++ b/dlls/wininet/internet.h @@ -361,6 +361,7 @@ typedef struct LPWSTR statusText; DWORD bytesToWrite; DWORD bytesWritten; + BOOL clear_auth; /* Flag to clear the password field on the authorization dialog */ CRITICAL_SECTION headers_section; /* section to protect the headers array */ HTTPHEADERW *custHeaders;

1 0

Eric Pouech : glu32: Fix GCC 12.2 warnings.
by Alexandre Julliard 16 Sep '22

16 Sep '22

Module: wine Branch: master Commit: af0fa4b8a80c716471bf0b1f1874c1b6c3782e1a URL: https://gitlab.winehq.org/wine/wine/-/commit/af0fa4b8a80c716471bf0b1f1874c1… Author: Eric Pouech <eric.pouech(a)gmail.com> Date: Fri Sep 16 16:54:02 2022 +0200 glu32: Fix GCC 12.2 warnings. GCC complains about writing 4x4 floats into a pointer to a float. Signed-off-by: Eric Pouech <eric.pouech(a)gmail.com> --- dlls/glu32/project.c | 24 ++++++++++++------------ 1 file changed, 12 insertions(+), 12 deletions(-) diff --git a/dlls/glu32/project.c b/dlls/glu32/project.c index dc104541b8f..0a71eabd98c 100644 --- a/dlls/glu32/project.c +++ b/dlls/glu32/project.c @@ -37,20 +37,20 @@ /* ** Make m an identity matrix */ -static void __gluMakeIdentityd(GLdouble m[16]) +static void __gluMakeIdentityd(GLdouble m[4][4]) { - m[0+4*0] = 1; m[0+4*1] = 0; m[0+4*2] = 0; m[0+4*3] = 0; - m[1+4*0] = 0; m[1+4*1] = 1; m[1+4*2] = 0; m[1+4*3] = 0; - m[2+4*0] = 0; m[2+4*1] = 0; m[2+4*2] = 1; m[2+4*3] = 0; - m[3+4*0] = 0; m[3+4*1] = 0; m[3+4*2] = 0; m[3+4*3] = 1; + m[0][0] = 1; m[0][1] = 0; m[0][2] = 0; m[0][3] = 0; + m[1][0] = 0; m[1][1] = 1; m[1][2] = 0; m[1][3] = 0; + m[2][0] = 0; m[2][1] = 0; m[2][2] = 1; m[2][3] = 0; + m[3][0] = 0; m[3][1] = 0; m[3][2] = 0; m[3][3] = 1; } -static void __gluMakeIdentityf(GLfloat m[16]) +static void __gluMakeIdentityf(GLfloat m[4][4]) { - m[0+4*0] = 1; m[0+4*1] = 0; m[0+4*2] = 0; m[0+4*3] = 0; - m[1+4*0] = 0; m[1+4*1] = 1; m[1+4*2] = 0; m[1+4*3] = 0; - m[2+4*0] = 0; m[2+4*1] = 0; m[2+4*2] = 1; m[2+4*3] = 0; - m[3+4*0] = 0; m[3+4*1] = 0; m[3+4*2] = 0; m[3+4*3] = 1; + m[0][0] = 1; m[0][1] = 0; m[0][2] = 0; m[0][3] = 0; + m[1][0] = 0; m[1][1] = 1; m[1][2] = 0; m[1][3] = 0; + m[2][0] = 0; m[2][1] = 0; m[2][2] = 1; m[2][3] = 0; + m[3][0] = 0; m[3][1] = 0; m[3][2] = 0; m[3][3] = 1; } /*********************************************************************** @@ -77,7 +77,7 @@ void WINAPI gluPerspective( GLdouble fovy, GLdouble aspect, GLdouble zNear, GLdo } cotangent = cos(radians) / sine; - __gluMakeIdentityd(&m[0][0]); + __gluMakeIdentityd(m); m[0][0] = cotangent / aspect; m[1][1] = cotangent; m[2][2] = -(zFar + zNear) / deltaZ; @@ -133,7 +133,7 @@ void WINAPI gluLookAt( GLdouble eyex, GLdouble eyey, GLdouble eyez, /* Recompute up as: up = side x forward */ cross(side, forward, up); - __gluMakeIdentityf(&m[0][0]); + __gluMakeIdentityf(m); m[0][0] = side[0]; m[1][0] = side[1]; m[2][0] = side[2];

1 0

Rémi Bernon : winegstreamer: Wake thread when async reader user clock is modified.
by Alexandre Julliard 16 Sep '22

16 Sep '22

Module: wine Branch: master Commit: 4a1e95c814d2bffe20957937a95df56e7192ca7c URL: https://gitlab.winehq.org/wine/wine/-/commit/4a1e95c814d2bffe20957937a95df5… Author: Rémi Bernon <rbernon(a)codeweavers.com> Date: Mon Aug 22 14:00:09 2022 +0200 winegstreamer: Wake thread when async reader user clock is modified. --- dlls/winegstreamer/wm_asyncreader.c | 1 + 1 file changed, 1 insertion(+) diff --git a/dlls/winegstreamer/wm_asyncreader.c b/dlls/winegstreamer/wm_asyncreader.c index b4750592778..b882d205220 100644 --- a/dlls/winegstreamer/wm_asyncreader.c +++ b/dlls/winegstreamer/wm_asyncreader.c @@ -560,6 +560,7 @@ static HRESULT WINAPI WMReaderAdvanced_SetUserProvidedClock(IWMReaderAdvanced6 * EnterCriticalSection(&reader->callback_cs); reader->user_clock = !!user_clock; LeaveCriticalSection(&reader->callback_cs); + WakeConditionVariable(&reader->callback_cv); return S_OK; }

1 0

Rémi Bernon : winegstreamer: Introduce a new async_reader_deliver_sample helper.
by Alexandre Julliard 16 Sep '22

16 Sep '22

Module: wine Branch: master Commit: daf10989f876bdff048b40d9e66eb5376d353193 URL: https://gitlab.winehq.org/wine/wine/-/commit/daf10989f876bdff048b40d9e66eb5… Author: Rémi Bernon <rbernon(a)codeweavers.com> Date: Fri Sep 9 08:20:42 2022 +0200 winegstreamer: Introduce a new async_reader_deliver_sample helper. --- dlls/winegstreamer/wm_asyncreader.c | 67 +++++++++++++++++++++++++------------ 1 file changed, 45 insertions(+), 22 deletions(-) diff --git a/dlls/winegstreamer/wm_asyncreader.c b/dlls/winegstreamer/wm_asyncreader.c index b882d205220..27195f2e094 100644 --- a/dlls/winegstreamer/wm_asyncreader.c +++ b/dlls/winegstreamer/wm_asyncreader.c @@ -44,6 +44,14 @@ struct async_op struct list entry; }; +struct sample +{ + INSSBuffer *buffer; + QWORD pts, duration; + DWORD flags; + WORD stream; +}; + struct async_reader { struct wm_reader reader; @@ -121,42 +129,57 @@ static bool async_reader_wait_pts(struct async_reader *reader, QWORD pts) return false; } +static void async_reader_deliver_sample(struct async_reader *reader, struct sample *sample) +{ + IWMReaderCallbackAdvanced *callback_advanced = reader->callback_advanced; + IWMReaderCallback *callback = reader->callback; + struct wm_stream *stream; + BOOL read_compressed; + HRESULT hr; + + TRACE("reader %p, stream %u, pts %s, duration %s, flags %#lx, buffer %p.\n", + reader, sample->stream, debugstr_time(sample->pts), debugstr_time(sample->duration), + sample->flags, sample->buffer); + + stream = wm_reader_get_stream_by_stream_number(&reader->reader, sample->stream); + read_compressed = stream->read_compressed; + + LeaveCriticalSection(&reader->callback_cs); + if (read_compressed) + hr = IWMReaderCallbackAdvanced_OnStreamSample(callback_advanced, sample->stream, + sample->pts, sample->duration, sample->flags, sample->buffer, reader->context); + else + hr = IWMReaderCallback_OnSample(callback, sample->stream - 1, sample->pts, sample->duration, + sample->flags, sample->buffer, reader->context); + EnterCriticalSection(&reader->callback_cs); + + TRACE("Callback returned %#lx.\n", hr); + + INSSBuffer_Release(sample->buffer); +} + static void callback_thread_run(struct async_reader *reader) { IWMReaderCallbackAdvanced *callback_advanced = reader->callback_advanced; IWMReaderCallback *callback = reader->callback; static const DWORD zero; - QWORD pts, duration; - WORD stream_number; - INSSBuffer *sample; HRESULT hr = S_OK; - DWORD flags; while (reader->running && list_empty(&reader->async_ops)) { + struct sample sample; + LeaveCriticalSection(&reader->callback_cs); - hr = wm_reader_get_stream_sample(&reader->reader, callback_advanced, 0, &sample, &pts, &duration, &flags, &stream_number); + hr = wm_reader_get_stream_sample(&reader->reader, callback_advanced, 0, &sample.buffer, + &sample.pts, &sample.duration, &sample.flags, &sample.stream); EnterCriticalSection(&reader->callback_cs); if (hr != S_OK) break; - if (async_reader_wait_pts(reader, pts)) - { - struct wm_stream *stream = wm_reader_get_stream_by_stream_number(&reader->reader, stream_number); - - LeaveCriticalSection(&reader->callback_cs); - if (stream->read_compressed) - hr = IWMReaderCallbackAdvanced_OnStreamSample(callback_advanced, - stream_number, pts, duration, flags, sample, reader->context); - else - hr = IWMReaderCallback_OnSample(callback, stream_number - 1, pts, duration, - flags, sample, reader->context); - EnterCriticalSection(&reader->callback_cs); - - TRACE("Callback returned %#lx.\n", hr); - } - - INSSBuffer_Release(sample); + if (async_reader_wait_pts(reader, sample.pts)) + async_reader_deliver_sample(reader, &sample); + else + INSSBuffer_Release(sample.buffer); } if (hr == NS_E_NO_MORE_SAMPLES)

1 0

Rémi Bernon : winegstreamer: Use a dedicated CS to serialize async reader commands.
by Alexandre Julliard 16 Sep '22

16 Sep '22

Module: wine Branch: master Commit: 359258560e9957a8762e7aaca549e604739f5b7a URL: https://gitlab.winehq.org/wine/wine/-/commit/359258560e9957a8762e7aaca549e6… Author: Rémi Bernon <rbernon(a)codeweavers.com> Date: Mon Aug 22 14:21:07 2022 +0200 winegstreamer: Use a dedicated CS to serialize async reader commands. --- dlls/winegstreamer/wm_asyncreader.c | 24 ++++++++++++++++++------ 1 file changed, 18 insertions(+), 6 deletions(-) diff --git a/dlls/winegstreamer/wm_asyncreader.c b/dlls/winegstreamer/wm_asyncreader.c index 27195f2e094..54c601d109a 100644 --- a/dlls/winegstreamer/wm_asyncreader.c +++ b/dlls/winegstreamer/wm_asyncreader.c @@ -64,6 +64,8 @@ struct async_reader IWMReaderTypeNegotiation IWMReaderTypeNegotiation_iface; IReferenceClock IReferenceClock_iface; + CRITICAL_SECTION cs; + IWMReaderCallbackAdvanced *callback_advanced; IWMReaderCallback *callback; void *context; @@ -390,11 +392,13 @@ static HRESULT WINAPI WMReader_Open(IWMReader *iface, const WCHAR *url, TRACE("reader %p, url %s, callback %p, context %p.\n", reader, debugstr_w(url), callback, context); + EnterCriticalSection(&reader->cs); EnterCriticalSection(&reader->reader.cs); if (reader->reader.wg_parser) { LeaveCriticalSection(&reader->reader.cs); + LeaveCriticalSection(&reader->cs); WARN("Stream is already open; returning E_UNEXPECTED.\n"); return E_UNEXPECTED; } @@ -404,6 +408,7 @@ static HRESULT WINAPI WMReader_Open(IWMReader *iface, const WCHAR *url, wm_reader_close(&reader->reader); LeaveCriticalSection(&reader->reader.cs); + LeaveCriticalSection(&reader->cs); return hr; } @@ -414,7 +419,7 @@ static HRESULT WINAPI WMReader_Close(IWMReader *iface) TRACE("reader %p.\n", reader); - EnterCriticalSection(&reader->reader.cs); + EnterCriticalSection(&reader->cs); if (SUCCEEDED(hr = async_reader_queue_op(reader, ASYNC_OP_CLOSE, NULL))) { @@ -422,7 +427,7 @@ static HRESULT WINAPI WMReader_Close(IWMReader *iface) hr = wm_reader_close(&reader->reader); } - LeaveCriticalSection(&reader->reader.cs); + LeaveCriticalSection(&reader->cs); return hr; } @@ -489,14 +494,14 @@ static HRESULT WINAPI WMReader_Start(IWMReader *iface, if (rate != 1.0f) FIXME("Ignoring rate %.8e.\n", rate); - EnterCriticalSection(&reader->reader.cs); + EnterCriticalSection(&reader->cs); if (!reader->callback_thread) hr = NS_E_INVALID_REQUEST; else hr = async_reader_queue_op(reader, ASYNC_OP_START, &data); - LeaveCriticalSection(&reader->reader.cs); + LeaveCriticalSection(&reader->cs); return hr; } @@ -508,14 +513,14 @@ static HRESULT WINAPI WMReader_Stop(IWMReader *iface) TRACE("reader %p.\n", reader); - EnterCriticalSection(&reader->reader.cs); + EnterCriticalSection(&reader->cs); if (!reader->callback_thread) hr = E_UNEXPECTED; else hr = async_reader_queue_op(reader, ASYNC_OP_STOP, NULL); - LeaveCriticalSection(&reader->reader.cs); + LeaveCriticalSection(&reader->cs); return hr; } @@ -867,11 +872,13 @@ static HRESULT WINAPI WMReaderAdvanced2_OpenStream(IWMReaderAdvanced6 *iface, TRACE("reader %p, stream %p, callback %p, context %p.\n", reader, stream, callback, context); + EnterCriticalSection(&reader->cs); EnterCriticalSection(&reader->reader.cs); if (reader->reader.wg_parser) { LeaveCriticalSection(&reader->reader.cs); + LeaveCriticalSection(&reader->cs); WARN("Stream is already open; returning E_UNEXPECTED.\n"); return E_UNEXPECTED; } @@ -881,6 +888,7 @@ static HRESULT WINAPI WMReaderAdvanced2_OpenStream(IWMReaderAdvanced6 *iface, wm_reader_close(&reader->reader); LeaveCriticalSection(&reader->reader.cs); + LeaveCriticalSection(&reader->cs); return hr; } @@ -1742,6 +1750,8 @@ static void async_reader_destroy(struct wm_reader *iface) reader->callback_cs.DebugInfo->Spare[0] = 0; DeleteCriticalSection(&reader->callback_cs); + reader->cs.DebugInfo->Spare[0] = 0; + DeleteCriticalSection(&reader->cs); wm_reader_close(&reader->reader); @@ -1774,6 +1784,8 @@ HRESULT WINAPI winegstreamer_create_wm_async_reader(IWMReader **reader) object->IWMReaderStreamClock_iface.lpVtbl = &WMReaderStreamClockVtbl; object->IWMReaderTypeNegotiation_iface.lpVtbl = &WMReaderTypeNegotiationVtbl; + InitializeCriticalSection(&object->cs); + object->cs.DebugInfo->Spare[0] = (DWORD_PTR)(__FILE__ ": async_reader.cs"); InitializeCriticalSection(&object->callback_cs); object->callback_cs.DebugInfo->Spare[0] = (DWORD_PTR)(__FILE__ ": async_reader.callback_cs");

1 0

Rémi Bernon : winegstreamer: Check for already opened stream in wm_reader_open*.
by Alexandre Julliard 16 Sep '22

16 Sep '22

Module: wine Branch: master Commit: ed0d100ec9e090641dcd61b79872a4b59e5b52f4 URL: https://gitlab.winehq.org/wine/wine/-/commit/ed0d100ec9e090641dcd61b79872a4… Author: Rémi Bernon <rbernon(a)codeweavers.com> Date: Mon Aug 22 14:26:39 2022 +0200 winegstreamer: Check for already opened stream in wm_reader_open*. --- dlls/winegstreamer/wm_asyncreader.c | 20 -------------------- dlls/winegstreamer/wm_reader.c | 15 +++++++++++++++ 2 files changed, 15 insertions(+), 20 deletions(-) diff --git a/dlls/winegstreamer/wm_asyncreader.c b/dlls/winegstreamer/wm_asyncreader.c index 54c601d109a..5b09bc616a6 100644 --- a/dlls/winegstreamer/wm_asyncreader.c +++ b/dlls/winegstreamer/wm_asyncreader.c @@ -393,21 +393,11 @@ static HRESULT WINAPI WMReader_Open(IWMReader *iface, const WCHAR *url, reader, debugstr_w(url), callback, context); EnterCriticalSection(&reader->cs); - EnterCriticalSection(&reader->reader.cs); - - if (reader->reader.wg_parser) - { - LeaveCriticalSection(&reader->reader.cs); - LeaveCriticalSection(&reader->cs); - WARN("Stream is already open; returning E_UNEXPECTED.\n"); - return E_UNEXPECTED; - } if (SUCCEEDED(hr = wm_reader_open_file(&reader->reader, url)) && FAILED(hr = async_reader_open(reader, callback, context))) wm_reader_close(&reader->reader); - LeaveCriticalSection(&reader->reader.cs); LeaveCriticalSection(&reader->cs); return hr; } @@ -873,21 +863,11 @@ static HRESULT WINAPI WMReaderAdvanced2_OpenStream(IWMReaderAdvanced6 *iface, TRACE("reader %p, stream %p, callback %p, context %p.\n", reader, stream, callback, context); EnterCriticalSection(&reader->cs); - EnterCriticalSection(&reader->reader.cs); - - if (reader->reader.wg_parser) - { - LeaveCriticalSection(&reader->reader.cs); - LeaveCriticalSection(&reader->cs); - WARN("Stream is already open; returning E_UNEXPECTED.\n"); - return E_UNEXPECTED; - } if (SUCCEEDED(hr = wm_reader_open_stream(&reader->reader, stream)) && FAILED(hr = async_reader_open(reader, callback, context))) wm_reader_close(&reader->reader); - LeaveCriticalSection(&reader->reader.cs); LeaveCriticalSection(&reader->cs); return hr; } diff --git a/dlls/winegstreamer/wm_reader.c b/dlls/winegstreamer/wm_reader.c index 156f9d79446..243ebb20335 100644 --- a/dlls/winegstreamer/wm_reader.c +++ b/dlls/winegstreamer/wm_reader.c @@ -1558,6 +1558,13 @@ HRESULT wm_reader_open_stream(struct wm_reader *reader, IStream *stream) EnterCriticalSection(&reader->cs); + if (reader->wg_parser) + { + LeaveCriticalSection(&reader->cs); + WARN("Stream is already open; returning E_UNEXPECTED.\n"); + return E_UNEXPECTED; + } + IStream_AddRef(reader->source_stream = stream); if (FAILED(hr = init_stream(reader, stat.cbSize.QuadPart))) { @@ -1591,6 +1598,14 @@ HRESULT wm_reader_open_file(struct wm_reader *reader, const WCHAR *filename) EnterCriticalSection(&reader->cs); + if (reader->wg_parser) + { + LeaveCriticalSection(&reader->cs); + WARN("Stream is already open; returning E_UNEXPECTED.\n"); + CloseHandle(file); + return E_UNEXPECTED; + } + reader->file = file; if (FAILED(hr = init_stream(reader, size.QuadPart)))

1 0

Zebediah Figura : ntdll: Do not check for malloc() failure in get_initial_environment.
by Alexandre Julliard 16 Sep '22

16 Sep '22

Module: wine Branch: master Commit: f5b92137257b9564dca623ee9578c49b4495e220 URL: https://gitlab.winehq.org/wine/wine/-/commit/f5b92137257b9564dca623ee9578c4… Author: Zebediah Figura <zfigura(a)codeweavers.com> Date: Fri Sep 16 12:30:43 2022 -0500 ntdll: Do not check for malloc() failure in get_initial_environment. This is called early in process startup; malloc() should definitely never fail here. This fixes an uninitialized variable warning with gcc 12.2: In function ‘build_initial_params’, inlined from ‘init_startup_info’ at ../wine/dlls/ntdll/unix/env.c:2004:18: ../wine/dlls/ntdll/unix/env.c:1910:12: error: ‘env_pos’ may be used uninitialized [-Werror=maybe-uninitialized] 1910 | path = get_env_var( env, env_pos, pathW, 4 ); | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ ../wine/dlls/ntdll/unix/env.c: In function ‘init_startup_info’: ../wine/dlls/ntdll/unix/env.c:1903:18: note: ‘env_pos’ declared here 1903 | SIZE_T size, env_pos, env_size; | ^~~~~~~ --- dlls/ntdll/unix/env.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/dlls/ntdll/unix/env.c b/dlls/ntdll/unix/env.c index 105038a34cb..6e5004a6e11 100644 --- a/dlls/ntdll/unix/env.c +++ b/dlls/ntdll/unix/env.c @@ -920,7 +920,7 @@ static WCHAR *get_initial_environment( SIZE_T *pos, SIZE_T *size ) *size = 1; for (e = main_envp; *e; e++) *size += strlen(*e) + 1; - if (!(env = malloc( *size * sizeof(WCHAR) ))) return NULL; + env = malloc( *size * sizeof(WCHAR) ); ptr = env; end = env + *size - 1; for (e = main_envp; *e && ptr < end; e++)

1 0

Nikolay Sivov : xmllite/writer: Enable some more tests for WriteNode().
by Alexandre Julliard 16 Sep '22

16 Sep '22

Module: wine Branch: master Commit: 2821d9cb4115b7f8dca8bc2502e8df969de20bcc URL: https://gitlab.winehq.org/wine/wine/-/commit/2821d9cb4115b7f8dca8bc2502e8df… Author: Nikolay Sivov <nsivov(a)codeweavers.com> Date: Fri Sep 16 11:19:54 2022 +0300 xmllite/writer: Enable some more tests for WriteNode(). Signed-off-by: Nikolay Sivov <nsivov(a)codeweavers.com> --- dlls/xmllite/tests/writer.c | 40 ++++++++++++++++++++++++++++++++++++---- dlls/xmllite/writer.c | 6 ++++++ 2 files changed, 42 insertions(+), 4 deletions(-) diff --git a/dlls/xmllite/tests/writer.c b/dlls/xmllite/tests/writer.c index 25dc9e3b8c1..7b98f61a207 100644 --- a/dlls/xmllite/tests/writer.c +++ b/dlls/xmllite/tests/writer.c @@ -136,8 +136,12 @@ static void writer_set_property(IXmlWriter *writer, XmlWriterProperty property) /* used to test all Write* methods for consistent error state */ static void check_writer_state(IXmlWriter *writer, HRESULT exp_hr) { + IXmlReader *reader; HRESULT hr; + hr = CreateXmlReader(&IID_IXmlReader, (void **)&reader, NULL); + ok(hr == S_OK, "Unexpected hr %#lx.\n", hr); + /* FIXME: add WriteAttributes */ hr = IXmlWriter_WriteAttributeString(writer, NULL, L"a", NULL, L"a"); @@ -179,8 +183,18 @@ static void check_writer_state(IXmlWriter *writer, HRESULT exp_hr) hr = IXmlWriter_WriteNmToken(writer, L"a"); ok(hr == exp_hr, "Unexpected hr %#lx, expected %#lx.\n", hr, exp_hr); - /* FIXME: add WriteNode */ - /* FIXME: add WriteNodeShallow */ + hr = IXmlWriter_WriteNode(writer, NULL, FALSE); + ok(hr == E_INVALIDARG, "Unexpected hr %#lx, expected %#lx.\n", hr, exp_hr); + + reader_set_input(reader, "<a/>"); + hr = IXmlWriter_WriteNode(writer, reader, FALSE); + ok(hr == exp_hr, "Unexpected hr %#lx, expected %#lx.\n", hr, exp_hr); + + reader_set_input(reader, "<a/>"); + hr = IXmlReader_Read(reader, NULL); + ok(hr == S_OK, "Unexpected hr %#lx.\n", hr); + hr = IXmlWriter_WriteNodeShallow(writer, reader, FALSE); + ok(hr == exp_hr, "Unexpected hr %#lx, expected %#lx.\n", hr, exp_hr); hr = IXmlWriter_WriteProcessingInstruction(writer, L"a", L"a"); ok(hr == exp_hr, "Unexpected hr %#lx, expected %#lx.\n", hr, exp_hr); @@ -207,6 +221,8 @@ static void check_writer_state(IXmlWriter *writer, HRESULT exp_hr) hr = IXmlWriter_WriteWhitespace(writer, L" "); ok(hr == exp_hr, "Unexpected hr %#lx, expected %#lx.\n", hr, exp_hr); + + IXmlReader_Release(reader); } static IStream *writer_set_output(IXmlWriter *writer) @@ -354,8 +370,12 @@ static void test_writer_create(void) static void test_invalid_output_encoding(IXmlWriter *writer, IUnknown *output) { + IXmlReader *reader; HRESULT hr; + hr = CreateXmlReader(&IID_IXmlReader, (void **)&reader, NULL); + ok(hr == S_OK, "Unexpected hr %#lx.\n", hr); + hr = IXmlWriter_SetOutput(writer, output); ok(hr == S_OK, "Failed to set output, hr %#lx.\n", hr); @@ -400,8 +420,12 @@ static void test_invalid_output_encoding(IXmlWriter *writer, IUnknown *output) hr = IXmlWriter_WriteNmToken(writer, L"a"); ok(hr == MX_E_ENCODING, "Unexpected hr %#lx.\n", hr); - /* TODO: WriteNode */ - /* TODO: WriteNodeShallow */ + reader_set_input(reader, "<a/>"); + hr = IXmlWriter_WriteNode(writer, reader, FALSE); + ok(hr == MX_E_ENCODING, "Unexpected hr %#lx.\n", hr); + + hr = IXmlWriter_WriteNodeShallow(writer, reader, FALSE); + ok(hr == MX_E_ENCODING, "Unexpected hr %#lx.\n", hr); hr = IXmlWriter_WriteProcessingInstruction(writer, L"a", L"a"); ok(hr == MX_E_ENCODING, "Unexpected hr %#lx.\n", hr); @@ -431,6 +455,8 @@ static void test_invalid_output_encoding(IXmlWriter *writer, IUnknown *output) hr = IXmlWriter_Flush(writer); ok(hr == S_OK, "Failed to flush, hr %#lx.\n", hr); + + IXmlReader_Release(reader); } static void test_writeroutput(void) @@ -2295,6 +2321,9 @@ static void test_WriteNode(void) hr = CreateXmlWriter(&IID_IXmlWriter, (void **)&writer, NULL); ok(hr == S_OK, "Unexpected hr %#lx.\n", hr); + hr = IXmlWriter_WriteNode(writer, NULL, FALSE); + ok(hr == E_INVALIDARG, "Unexpected hr %#lx.\n", hr); + hr = CreateXmlReader(&IID_IXmlReader, (void **)&reader, NULL); ok(hr == S_OK, "Unexpected hr %#lx.\n", hr); @@ -2445,6 +2474,9 @@ static void test_WriteNodeShallow(void) hr = CreateXmlWriter(&IID_IXmlWriter, (void **)&writer, NULL); ok(hr == S_OK, "Unexpected hr %#lx.\n", hr); + hr = IXmlWriter_WriteNodeShallow(writer, NULL, FALSE); + ok(hr == E_INVALIDARG, "Unexpected hr %#lx.\n", hr); + hr = CreateXmlReader(&IID_IXmlReader, (void **)&reader, NULL); ok(hr == S_OK, "Unexpected hr %#lx.\n", hr); diff --git a/dlls/xmllite/writer.c b/dlls/xmllite/writer.c index fb2784ab439..1e1a8e8ddb8 100644 --- a/dlls/xmllite/writer.c +++ b/dlls/xmllite/writer.c @@ -1600,6 +1600,9 @@ static HRESULT WINAPI xmlwriter_WriteNode(IXmlWriter *iface, IXmlReader *reader, TRACE("%p, %p, %d.\n", iface, reader, write_default_attributes); + if (!reader) + return E_INVALIDARG; + if (SUCCEEDED(hr = writer_write_node(iface, reader, FALSE, write_default_attributes))) hr = IXmlReader_Read(reader, NULL); @@ -1610,6 +1613,9 @@ static HRESULT WINAPI xmlwriter_WriteNodeShallow(IXmlWriter *iface, IXmlReader * { TRACE("%p, %p, %d.\n", iface, reader, write_default_attributes); + if (!reader) + return E_INVALIDARG; + return writer_write_node(iface, reader, TRUE, write_default_attributes); }

1 0