September 2022 - Wine-commits

Henri Verbeet : d3d11/tests: Move the is_warp_device() call out of the loop in check_format_support().
by Alexandre Julliard 15 Sep '22

15 Sep '22

Module: wine Branch: master Commit: e5f5bea390d263e2119e25ee8802864409719941 URL: https://gitlab.winehq.org/wine/wine/-/commit/e5f5bea390d263e2119e25ee880286… Author: Henri Verbeet <hverbeet(a)codeweavers.com> Date: Wed Sep 14 11:34:27 2022 +0200 d3d11/tests: Move the is_warp_device() call out of the loop in check_format_support(). There's no point in querying this multiple times, it's not going to change. Perhaps more importantly, calling is_warp_device() inside a todo_wine block will cause "Test succeeded inside todo block: ..." messages from get_device_adapter_desc(). These appear to have been introduced by commit fcc276ecb1508d5217ec977ca530ee7d30d355b9. Arguably get_device_adapter_desc() shouldn't use ok() in the first place. --- dlls/d3d11/tests/d3d11.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/dlls/d3d11/tests/d3d11.c b/dlls/d3d11/tests/d3d11.c index 5e00bc7a336..bc7f8fd971d 100644 --- a/dlls/d3d11/tests/d3d11.c +++ b/dlls/d3d11/tests/d3d11.c @@ -20961,6 +20961,7 @@ static void check_format_support(ID3D11Device *device, const unsigned int *forma D3D_FEATURE_LEVEL feature_level, const struct format_support *formats, unsigned int format_count, unsigned int feature_flag, const char *feature_name) { + BOOL warp = is_warp_device(device); unsigned int i; for (i = 0; i < format_count; ++i) @@ -20971,7 +20972,7 @@ static void check_format_support(ID3D11Device *device, const unsigned int *forma if (formats[i].fl_required <= feature_level) { todo_wine_if (feature_flag == D3D11_FORMAT_SUPPORT_DISPLAY) - ok(supported || broken(is_warp_device(device)), + ok(supported || broken(warp), "Format %#x - %s not supported, format support %#x.\n", format, feature_name, format_support[format]); continue;

1 0

Henri Verbeet : wined3d: Return bools from all return paths in wined3d_cs_map_upload_bo().
by Alexandre Julliard 15 Sep '22

15 Sep '22

Module: wine Branch: master Commit: 030c37ceae9ab3370ed0d135471b825588a2b3b2 URL: https://gitlab.winehq.org/wine/wine/-/commit/030c37ceae9ab3370ed0d135471b82… Author: Henri Verbeet <hverbeet(a)codeweavers.com> Date: Wed Sep 14 11:34:28 2022 +0200 wined3d: Return bools from all return paths in wined3d_cs_map_upload_bo(). --- dlls/wined3d/cs.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/dlls/wined3d/cs.c b/dlls/wined3d/cs.c index 9fd67cf0045..8ddcb95ddcc 100644 --- a/dlls/wined3d/cs.c +++ b/dlls/wined3d/cs.c @@ -2968,13 +2968,13 @@ static bool wined3d_cs_map_upload_bo(struct wined3d_device_context *context, str if (!d3d_info->xyzrhw || !d3d_info->vertex_bgra || !d3d_info->ffp_generic_attributes) { TRACE("Not returning a persistent buffer because we might need to do vertex attribute conversion.\n"); - return NULL; + return false; } if (resource->pin_sysmem) { TRACE("Not allocating an upload buffer because system memory is pinned for this resource.\n"); - return NULL; + return false; } if ((flags & WINED3D_MAP_NOOVERWRITE) && client->addr.buffer_object == CLIENT_BO_DISCARDED)

1 0

Eric Pouech : d3d10core/tests: Fix erroneous color parameter.
by Alexandre Julliard 15 Sep '22

15 Sep '22

Module: wine Branch: master Commit: ae890d5442d74c16b2b7916734674e5fc1bdbbf8 URL: https://gitlab.winehq.org/wine/wine/-/commit/ae890d5442d74c16b2b7916734674e… Author: Eric Pouech <eric.pouech(a)gmail.com> Date: Thu Sep 15 19:37:19 2022 +0200 d3d10core/tests: Fix erroneous color parameter. (Spotted by warnings emitted by GCC 12.2). Signed-off-by: Eric Pouech <eric.pouech(a)gmail.com> --- dlls/d3d10core/tests/d3d10core.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/dlls/d3d10core/tests/d3d10core.c b/dlls/d3d10core/tests/d3d10core.c index acc85f03b23..7d0e3601403 100644 --- a/dlls/d3d10core/tests/d3d10core.c +++ b/dlls/d3d10core/tests/d3d10core.c @@ -17466,7 +17466,7 @@ static void test_generate_mips(void) ID3D10Device_GenerateMips(device, srv); - ID3D10Device_ClearRenderTargetView(device, test_context.backbuffer_rtv, &white.w); + ID3D10Device_ClearRenderTargetView(device, test_context.backbuffer_rtv, &white.x); srv_desc.Format = DXGI_FORMAT_R8G8B8A8_UNORM; srv_desc.ViewDimension = D3D10_SRV_DIMENSION_TEXTURE2D; @@ -17498,7 +17498,7 @@ static void test_generate_mips(void) ID3D10Device_GenerateMips(device, srv); - ID3D10Device_ClearRenderTargetView(device, test_context.backbuffer_rtv, &white.w); + ID3D10Device_ClearRenderTargetView(device, test_context.backbuffer_rtv, &white.x); srv_desc.Format = DXGI_FORMAT_R8G8B8A8_UNORM; srv_desc.ViewDimension = D3D10_SRV_DIMENSION_TEXTURE2D;

1 0

Eric Pouech : d3d10core/tests: Introduce a clear_backbuffer_rtv() helper.
by Alexandre Julliard 15 Sep '22

15 Sep '22

Module: wine Branch: master Commit: 6ba6f54f56c4ac3e23eba998813ed9b8a4e51499 URL: https://gitlab.winehq.org/wine/wine/-/commit/6ba6f54f56c4ac3e23eba998813ed9… Author: Eric Pouech <eric.pouech(a)gmail.com> Date: Thu Sep 15 19:37:20 2022 +0200 d3d10core/tests: Introduce a clear_backbuffer_rtv() helper. This fixes warnings with gcc 12.2. Signed-off-by: Eric Pouech <eric.pouech(a)gmail.com> --- dlls/d3d10core/tests/d3d10core.c | 45 +++++++++++++++++++++++----------------- 1 file changed, 26 insertions(+), 19 deletions(-) diff --git a/dlls/d3d10core/tests/d3d10core.c b/dlls/d3d10core/tests/d3d10core.c index 7d0e3601403..908b11b7435 100644 --- a/dlls/d3d10core/tests/d3d10core.c +++ b/dlls/d3d10core/tests/d3d10core.c @@ -1406,6 +1406,13 @@ static void release_test_context_(unsigned int line, struct d3d10core_test_conte ok_(__FILE__, line)(!ref, "Device has %lu references left.\n", ref); } +static void clear_backbuffer_rtv(struct d3d10core_test_context *test_context, const struct vec4 *v) +{ + /* Cast to (const float *) instead of passing &v->x, since gcc warns about + * overreading a float[4] from a float otherwise. */ + ID3D10Device_ClearRenderTargetView(test_context->device, test_context->backbuffer_rtv, (const float *)v); +} + #define draw_quad(context) draw_quad_vs_(__LINE__, context, NULL, 0) #define draw_quad_vs(a, b, c) draw_quad_vs_(__LINE__, a, b, c) static void draw_quad_vs_(unsigned int line, struct d3d10core_test_context *context, @@ -13443,7 +13450,7 @@ static void test_face_culling(void) device = test_context.device; - ID3D10Device_ClearRenderTargetView(device, test_context.backbuffer_rtv, &red.x); + clear_backbuffer_rtv(&test_context, &red); draw_color_quad(&test_context, &green); check_texture_color(test_context.backbuffer, 0xff00ff00, 0); @@ -13451,7 +13458,7 @@ static void test_face_culling(void) ccw_vb = create_buffer(device, D3D10_BIND_VERTEX_BUFFER, sizeof(ccw_quad), ccw_quad); test_context.vb = ccw_vb; - ID3D10Device_ClearRenderTargetView(device, test_context.backbuffer_rtv, &red.x); + clear_backbuffer_rtv(&test_context, &red); draw_color_quad(&test_context, &green); check_texture_color(test_context.backbuffer, 0xff0000ff, 0); @@ -13476,12 +13483,12 @@ static void test_face_culling(void) ID3D10Device_RSSetState(device, state); test_context.vb = cw_vb; - ID3D10Device_ClearRenderTargetView(device, test_context.backbuffer_rtv, &red.x); + clear_backbuffer_rtv(&test_context, &red); draw_color_quad(&test_context, &green); check_texture_color(test_context.backbuffer, tests[i].expected_cw ? 0xff00ff00 : 0xff0000ff, 0); test_context.vb = ccw_vb; - ID3D10Device_ClearRenderTargetView(device, test_context.backbuffer_rtv, &red.x); + clear_backbuffer_rtv(&test_context, &red); draw_color_quad(&test_context, &green); check_texture_color(test_context.backbuffer, tests[i].expected_ccw ? 0xff00ff00 : 0xff0000ff, 0); @@ -13502,11 +13509,11 @@ static void test_face_culling(void) ID3D10Device_RSSetState(device, state); test_context.vb = cw_vb; - ID3D10Device_ClearRenderTargetView(device, test_context.backbuffer_rtv, &red.x); + clear_backbuffer_rtv(&test_context, &red); draw_color_quad(&test_context, &green); check_texture_color(test_context.backbuffer, 0xff00ff00, 0); test_context.vb = ccw_vb; - ID3D10Device_ClearRenderTargetView(device, test_context.backbuffer_rtv, &red.x); + clear_backbuffer_rtv(&test_context, &red); draw_color_quad(&test_context, &green); if (!broken_warp) check_texture_color(test_context.backbuffer, 0xffff0000, 0); @@ -13522,14 +13529,14 @@ static void test_face_culling(void) ID3D10Device_RSSetState(device, state); test_context.vb = cw_vb; - ID3D10Device_ClearRenderTargetView(device, test_context.backbuffer_rtv, &red.x); + clear_backbuffer_rtv(&test_context, &red); draw_color_quad(&test_context, &green); if (!broken_warp) check_texture_color(test_context.backbuffer, 0xffff0000 , 0); else win_skip("Broken WARP.\n"); test_context.vb = ccw_vb; - ID3D10Device_ClearRenderTargetView(device, test_context.backbuffer_rtv, &red.x); + clear_backbuffer_rtv(&test_context, &red); draw_color_quad(&test_context, &green); check_texture_color(test_context.backbuffer, 0xff00ff00, 0); @@ -13573,22 +13580,22 @@ static void test_line_antialiasing_blending(void) ok(SUCCEEDED(hr), "Failed to create blend state, hr %#lx.\n", hr); ID3D10Device_OMSetBlendState(device, blend_state, NULL, D3D10_DEFAULT_SAMPLE_MASK); - ID3D10Device_ClearRenderTargetView(device, test_context.backbuffer_rtv, &red.x); + clear_backbuffer_rtv(&test_context, &red); draw_color_quad(&test_context, &green); check_texture_color(test_context.backbuffer, 0xe2007fcc, 1); - ID3D10Device_ClearRenderTargetView(device, test_context.backbuffer_rtv, &green.x); + clear_backbuffer_rtv(&test_context, &green); draw_color_quad(&test_context, &red); check_texture_color(test_context.backbuffer, 0xe2007fcc, 1); ID3D10Device_OMSetBlendState(device, NULL, NULL, D3D10_DEFAULT_SAMPLE_MASK); ID3D10BlendState_Release(blend_state); - ID3D10Device_ClearRenderTargetView(device, test_context.backbuffer_rtv, &red.x); + clear_backbuffer_rtv(&test_context, &red); draw_color_quad(&test_context, &green); check_texture_color(test_context.backbuffer, 0x7f00ff00, 1); - ID3D10Device_ClearRenderTargetView(device, test_context.backbuffer_rtv, &green.x); + clear_backbuffer_rtv(&test_context, &green); draw_color_quad(&test_context, &red); check_texture_color(test_context.backbuffer, 0xcc0000ff, 1); @@ -13607,11 +13614,11 @@ static void test_line_antialiasing_blending(void) ok(SUCCEEDED(hr), "Failed to create rasterizer state, hr %#lx.\n", hr); ID3D10Device_RSSetState(device, rasterizer_state); - ID3D10Device_ClearRenderTargetView(device, test_context.backbuffer_rtv, &red.x); + clear_backbuffer_rtv(&test_context, &red); draw_color_quad(&test_context, &green); check_texture_color(test_context.backbuffer, 0x7f00ff00, 1); - ID3D10Device_ClearRenderTargetView(device, test_context.backbuffer_rtv, &green.x); + clear_backbuffer_rtv(&test_context, &green); draw_color_quad(&test_context, &red); check_texture_color(test_context.backbuffer, 0xcc0000ff, 1); @@ -15636,7 +15643,7 @@ static void test_stream_output_resume(void) ID3D10Device_GSSetShader(device, gs); ID3D10Device_GSSetConstantBuffers(device, 0, 1, &cb); - ID3D10Device_ClearRenderTargetView(device, test_context.backbuffer_rtv, &white.x); + clear_backbuffer_rtv(&test_context, &white); check_texture_color(test_context.backbuffer, 0xffffffff, 0); /* Draw into a SO buffer and then immediately destroy it, to make sure that @@ -17384,7 +17391,7 @@ static void test_generate_mips(void) ID3D10Device_GenerateMips(device, srv); - ID3D10Device_ClearRenderTargetView(device, test_context.backbuffer_rtv, &white.x); + clear_backbuffer_rtv(&test_context, &white); srv_desc.Format = tests[j].texture_format == DXGI_FORMAT_R8G8B8A8_UINT ? DXGI_FORMAT_R8G8B8A8_UINT : DXGI_FORMAT_R8G8B8A8_UNORM; @@ -17466,7 +17473,7 @@ static void test_generate_mips(void) ID3D10Device_GenerateMips(device, srv); - ID3D10Device_ClearRenderTargetView(device, test_context.backbuffer_rtv, &white.x); + clear_backbuffer_rtv(&test_context, &white); srv_desc.Format = DXGI_FORMAT_R8G8B8A8_UNORM; srv_desc.ViewDimension = D3D10_SRV_DIMENSION_TEXTURE2D; @@ -17498,7 +17505,7 @@ static void test_generate_mips(void) ID3D10Device_GenerateMips(device, srv); - ID3D10Device_ClearRenderTargetView(device, test_context.backbuffer_rtv, &white.x); + clear_backbuffer_rtv(&test_context, &white); srv_desc.Format = DXGI_FORMAT_R8G8B8A8_UNORM; srv_desc.ViewDimension = D3D10_SRV_DIMENSION_TEXTURE2D; @@ -19183,7 +19190,7 @@ static void test_dynamic_map_synchronization(void) hr = ID3D10Device_CreateBuffer(device, &buffer_desc, NULL, &test_context.vb); ok(hr == S_OK, "Failed to create vertex buffer, hr %#lx.\n", hr); - ID3D10Device_ClearRenderTargetView(device, test_context.backbuffer_rtv, &red.x); + clear_backbuffer_rtv(&test_context, &red); for (y = 0; y < 200; ++y) {

1 0

Eric Pouech : d3d11/tests: Introduce a clear_rtv() helper.
by Alexandre Julliard 15 Sep '22

15 Sep '22

Module: wine Branch: master Commit: 5fa25d00d7edca295e38030006b14f4059276116 URL: https://gitlab.winehq.org/wine/wine/-/commit/5fa25d00d7edca295e38030006b14f… Author: Eric Pouech <eric.pouech(a)gmail.com> Date: Thu Sep 15 19:37:20 2022 +0200 d3d11/tests: Introduce a clear_rtv() helper. This fixes warnings with gcc 12.2. Signed-off-by: Eric Pouech <eric.pouech(a)gmail.com> --- dlls/d3d11/tests/d3d11.c | 69 ++++++++++++++++++++++++++---------------------- 1 file changed, 38 insertions(+), 31 deletions(-)

1 0

Nikolay Sivov : xmllite/reader: Improve xml declaration node parsing.
by Alexandre Julliard 15 Sep '22

15 Sep '22

Module: wine Branch: master Commit: 31aac84ad0271e9cf3c0d4d7f39f9a51b386c5a7 URL: https://gitlab.winehq.org/wine/wine/-/commit/31aac84ad0271e9cf3c0d4d7f39f9a… Author: Nikolay Sivov <nsivov(a)codeweavers.com> Date: Wed Sep 14 23:29:27 2022 +0300 xmllite/reader: Improve xml declaration node parsing. Signed-off-by: Nikolay Sivov <nsivov(a)codeweavers.com> --- dlls/xmllite/reader.c | 16 ++++++++-------- dlls/xmllite/tests/reader.c | 21 +++++++++++++++++++++ 2 files changed, 29 insertions(+), 8 deletions(-) diff --git a/dlls/xmllite/reader.c b/dlls/xmllite/reader.c index 118b7bd5ea2..6e5e08734bc 100644 --- a/dlls/xmllite/reader.c +++ b/dlls/xmllite/reader.c @@ -1296,13 +1296,13 @@ static HRESULT reader_parse_encname(xmlreader *reader, strval *val) } /* [80] EncodingDecl ::= S 'encoding' Eq ('"' EncName '"' | "'" EncName "'" ) */ -static HRESULT reader_parse_encdecl(xmlreader *reader) +static HRESULT reader_parse_encdecl(xmlreader *reader, BOOL *spaces) { struct reader_position position; strval name, val; HRESULT hr; - if (!reader_skipspaces(reader)) return S_FALSE; + if (!(*spaces = reader_skipspaces(reader))) return S_FALSE; position = reader->position; if (reader_cmp(reader, L"encoding")) return S_FALSE; @@ -1328,19 +1328,20 @@ static HRESULT reader_parse_encdecl(xmlreader *reader) /* skip "'"|'"' */ reader_skipn(reader, 1); + *spaces = FALSE; return reader_add_attr(reader, NULL, &name, NULL, &val, &position, 0); } /* [32] SDDecl ::= S 'standalone' Eq (("'" ('yes' | 'no') "'") | ('"' ('yes' | 'no') '"')) */ -static HRESULT reader_parse_sddecl(xmlreader *reader) +static HRESULT reader_parse_sddecl(xmlreader *reader, BOOL spaces) { struct reader_position position; strval name, val; UINT start; HRESULT hr; - if (!reader_skipspaces(reader)) return S_FALSE; + if (!spaces && !reader_skipspaces(reader)) return S_FALSE; position = reader->position; if (reader_cmp(reader, L"standalone")) return S_FALSE; @@ -1377,6 +1378,7 @@ static HRESULT reader_parse_sddecl(xmlreader *reader) static HRESULT reader_parse_xmldecl(xmlreader *reader) { struct reader_position position; + BOOL spaces; HRESULT hr; if (reader_cmp(reader, L"<?xml ")) @@ -1389,12 +1391,10 @@ static HRESULT reader_parse_xmldecl(xmlreader *reader) if (FAILED(hr)) return hr; - hr = reader_parse_encdecl(reader); - if (FAILED(hr)) + if (FAILED(hr = reader_parse_encdecl(reader, &spaces))) return hr; - hr = reader_parse_sddecl(reader); - if (FAILED(hr)) + if (FAILED(hr = reader_parse_sddecl(reader, spaces))) return hr; reader_skipspaces(reader); diff --git a/dlls/xmllite/tests/reader.c b/dlls/xmllite/tests/reader.c index 2ea781ce992..8bb30f730a4 100644 --- a/dlls/xmllite/tests/reader.c +++ b/dlls/xmllite/tests/reader.c @@ -1019,6 +1019,27 @@ todo_wine { TEST_READER_STATE(reader, XmlReadState_Error); IStream_Release(stream); + + /* No encoding attribute. */ + set_input_string(reader, "<?xml version=\"1.0\" standalone=\"yes\"?><a/>"); + hr = IXmlReader_Read(reader, &type); + ok(hr == S_OK, "Unexpected hr %#lx.\n", hr); + ok(type == XmlNodeType_XmlDeclaration, "got %d\n", type); + + /* Just version attribute, no spaces. */ + set_input_string(reader, "<?xml version=\"1.0\"?><a/>"); + hr = IXmlReader_Read(reader, &type); + ok(hr == S_OK, "Unexpected hr %#lx.\n", hr); + ok(type == XmlNodeType_XmlDeclaration, "got %d\n", type); + + set_input_string(reader, "<?xml version=\"1.0\"encoding=\"UTF-8\"?><a/>"); + hr = IXmlReader_Read(reader, &type); + ok(hr == WC_E_XMLDECL, "Unexpected hr %#lx.\n", hr); + + set_input_string(reader, "<?xml version=\"1.0\"standalone=\"yes\"?><a/>"); + hr = IXmlReader_Read(reader, &type); + ok(hr == WC_E_XMLDECL, "Unexpected hr %#lx.\n", hr); + IXmlReader_Release(reader); }

1 0

Nikolay Sivov : xmllite/writer: Implement WriteWhitespace().
by Alexandre Julliard 15 Sep '22

15 Sep '22

Module: wine Branch: master Commit: 225e7b34a927011faec4a61d933a31f7ebed284e URL: https://gitlab.winehq.org/wine/wine/-/commit/225e7b34a927011faec4a61d933a31… Author: Nikolay Sivov <nsivov(a)codeweavers.com> Date: Wed Sep 14 23:37:34 2022 +0300 xmllite/writer: Implement WriteWhitespace(). Signed-off-by: Nikolay Sivov <nsivov(a)codeweavers.com> --- dlls/xmllite/reader.c | 5 ----- dlls/xmllite/tests/writer.c | 51 ++++++++++++++++++++++++++++++++++-------- dlls/xmllite/writer.c | 31 +++++++++++++++++++++---- dlls/xmllite/xmllite_private.h | 5 +++++ 4 files changed, 74 insertions(+), 18 deletions(-) diff --git a/dlls/xmllite/reader.c b/dlls/xmllite/reader.c index 6e5e08734bc..d747e36e623 100644 --- a/dlls/xmllite/reader.c +++ b/dlls/xmllite/reader.c @@ -1159,11 +1159,6 @@ static void reader_skipn(xmlreader *reader, int n) } } -static inline BOOL is_wchar_space(WCHAR ch) -{ - return ch == ' ' || ch == '\t' || ch == '\r' || ch == '\n'; -} - /* [3] S ::= (#x20 | #x9 | #xD | #xA)+ */ static int reader_skipspaces(xmlreader *reader) { diff --git a/dlls/xmllite/tests/writer.c b/dlls/xmllite/tests/writer.c index 3e1c362664e..a000bde6d80 100644 --- a/dlls/xmllite/tests/writer.c +++ b/dlls/xmllite/tests/writer.c @@ -148,28 +148,30 @@ static void check_writer_state(IXmlWriter *writer, HRESULT exp_hr) /* FIXME: add WriteNodeShallow */ hr = IXmlWriter_WriteProcessingInstruction(writer, L"a", L"a"); - ok(hr == exp_hr, "Unexpected hr %#lx., expected %#lx.\n", hr, exp_hr); + ok(hr == exp_hr, "Unexpected hr %#lx, expected %#lx.\n", hr, exp_hr); hr = IXmlWriter_WriteQualifiedName(writer, L"a", NULL); - ok(hr == exp_hr, "Unexpected hr %#lx., expected %#lx.\n", hr, exp_hr); + ok(hr == exp_hr, "Unexpected hr %#lx, expected %#lx.\n", hr, exp_hr); hr = IXmlWriter_WriteRaw(writer, L"a"); - ok(hr == exp_hr, "Unexpected hr %#lx., expected %#lx.\n", hr, exp_hr); + ok(hr == exp_hr, "Unexpected hr %#lx, expected %#lx.\n", hr, exp_hr); hr = IXmlWriter_WriteRawChars(writer, L"a", 1); - ok(hr == exp_hr, "Unexpected hr %#lx., expected %#lx.\n", hr, exp_hr); + ok(hr == exp_hr, "Unexpected hr %#lx, expected %#lx.\n", hr, exp_hr); hr = IXmlWriter_WriteStartDocument(writer, XmlStandalone_Omit); - ok(hr == exp_hr, "Unexpected hr %#lx., expected %#lx.\n", hr, exp_hr); + ok(hr == exp_hr, "Unexpected hr %#lx, expected %#lx.\n", hr, exp_hr); hr = IXmlWriter_WriteStartElement(writer, NULL, L"a", NULL); - ok(hr == exp_hr, "Unexpected hr %#lx., expected %#lx.\n", hr, exp_hr); + ok(hr == exp_hr, "Unexpected hr %#lx, expected %#lx.\n", hr, exp_hr); hr = IXmlWriter_WriteString(writer, L"a"); - ok(hr == exp_hr, "Unexpected hr %#lx., expected %#lx.\n", hr, exp_hr); + ok(hr == exp_hr, "Unexpected hr %#lx, expected %#lx.\n", hr, exp_hr); /* FIXME: add WriteSurrogateCharEntity */ - /* FIXME: add WriteWhitespace */ + + hr = IXmlWriter_WriteWhitespace(writer, L" "); + ok(hr == exp_hr, "Unexpected hr %#lx, expected %#lx.\n", hr, exp_hr); } static IStream *writer_set_output(IXmlWriter *writer) @@ -388,7 +390,9 @@ static void test_invalid_output_encoding(IXmlWriter *writer, IUnknown *output) ok(hr == MX_E_ENCODING, "Unexpected hr %#lx.\n", hr); /* TODO: WriteSurrogateCharEntity */ - /* TODO: WriteWhitespace */ + + hr = IXmlWriter_WriteWhitespace(writer, L" "); + ok(hr == MX_E_ENCODING, "Unexpected hr %#lx.\n", hr); hr = IXmlWriter_Flush(writer); ok(hr == S_OK, "Failed to flush, hr %#lx.\n", hr); @@ -2063,6 +2067,34 @@ static void test_WriteDocType(void) IXmlWriter_Release(writer); } +static void test_WriteWhitespace(void) +{ + IXmlWriter *writer; + IStream *stream; + HRESULT hr; + + hr = CreateXmlWriter(&IID_IXmlWriter, (void **)&writer, NULL); + ok(hr == S_OK, "Unexpected hr %#lx.\n", hr); + + stream = writer_set_output(writer); + + hr = IXmlWriter_WriteWhitespace(writer, L" "); + ok(hr == S_OK, "Unexpected hr %#lx.\n", hr); + hr = IXmlWriter_WriteWhitespace(writer, L"ab"); + ok(hr == WR_E_NONWHITESPACE, "Unexpected hr %#lx.\n", hr); + hr = IXmlWriter_WriteStartElement(writer, NULL, L"w", NULL); + ok(hr == S_OK, "Unexpected hr %#lx.\n", hr); + hr = IXmlWriter_WriteWhitespace(writer, L"\t"); + ok(hr == S_OK, "Unexpected hr %#lx.\n", hr); + + hr = IXmlWriter_Flush(writer); + ok(hr == S_OK, "Failed to flush, hr %#lx.\n", hr); + CHECK_OUTPUT(stream, " <w>\t"); + IStream_Release(stream); + + IXmlWriter_Release(writer); +} + START_TEST(writer) { test_writer_create(); @@ -2085,4 +2117,5 @@ START_TEST(writer) test_WriteCharEntity(); test_WriteString(); test_WriteDocType(); + test_WriteWhitespace(); } diff --git a/dlls/xmllite/writer.c b/dlls/xmllite/writer.c index 6f455ffcb19..0a3717d426e 100644 --- a/dlls/xmllite/writer.c +++ b/dlls/xmllite/writer.c @@ -1752,13 +1752,36 @@ static HRESULT WINAPI xmlwriter_WriteSurrogateCharEntity(IXmlWriter *iface, WCHA return E_NOTIMPL; } -static HRESULT WINAPI xmlwriter_WriteWhitespace(IXmlWriter *iface, LPCWSTR pwszWhitespace) +static HRESULT WINAPI xmlwriter_WriteWhitespace(IXmlWriter *iface, LPCWSTR text) { - xmlwriter *This = impl_from_IXmlWriter(iface); + xmlwriter *writer = impl_from_IXmlWriter(iface); + size_t length = 0; - FIXME("%p %s\n", This, wine_dbgstr_w(pwszWhitespace)); + TRACE("%p, %s.\n", iface, wine_dbgstr_w(text)); - return E_NOTIMPL; + switch (writer->state) + { + case XmlWriterState_Initial: + return E_UNEXPECTED; + case XmlWriterState_ElemStarted: + writer_close_starttag(writer); + break; + case XmlWriterState_InvalidEncoding: + return MX_E_ENCODING; + case XmlWriterState_Ready: + break; + default: + return WR_E_INVALIDACTION; + } + + while (text[length]) + { + if (!is_wchar_space(text[length])) return WR_E_NONWHITESPACE; + length++; + } + + write_output_buffer(writer->output, text, length); + return S_OK; } static HRESULT WINAPI xmlwriter_Flush(IXmlWriter *iface) diff --git a/dlls/xmllite/xmllite_private.h b/dlls/xmllite/xmllite_private.h index 03653bbe371..bd53fca575f 100644 --- a/dlls/xmllite/xmllite_private.h +++ b/dlls/xmllite/xmllite_private.h @@ -63,4 +63,9 @@ BOOL is_pubchar(WCHAR ch) DECLSPEC_HIDDEN; BOOL is_namestartchar(WCHAR ch) DECLSPEC_HIDDEN; BOOL is_namechar(WCHAR ch) DECLSPEC_HIDDEN; +static inline BOOL is_wchar_space(WCHAR ch) +{ + return ch == ' ' || ch == '\t' || ch == '\r' || ch == '\n'; +} + #endif /* __XMLLITE_PRIVATE__ */

1 0

Nikolay Sivov : xmllite/writer: Handle empty prefix and uri correctly in WriteStartElement().
by Alexandre Julliard 15 Sep '22

15 Sep '22

Module: wine Branch: master Commit: 57497d1262c966bdb0c50c03717e56ad586abfb3 URL: https://gitlab.winehq.org/wine/wine/-/commit/57497d1262c966bdb0c50c03717e56… Author: Nikolay Sivov <nsivov(a)codeweavers.com> Date: Wed Sep 14 23:43:50 2022 +0300 xmllite/writer: Handle empty prefix and uri correctly in WriteStartElement(). Signed-off-by: Nikolay Sivov <nsivov(a)codeweavers.com> --- dlls/xmllite/tests/writer.c | 26 +++++++++++++++++++++++++- dlls/xmllite/writer.c | 20 ++++++++++---------- 2 files changed, 35 insertions(+), 11 deletions(-) diff --git a/dlls/xmllite/tests/writer.c b/dlls/xmllite/tests/writer.c index a000bde6d80..c76f3708fca 100644 --- a/dlls/xmllite/tests/writer.c +++ b/dlls/xmllite/tests/writer.c @@ -1736,9 +1736,33 @@ static void test_WriteFullEndElement(void) "<a>\r\n" " <a></a>\r\n" "</a>"); + IStream_Release(stream); - IXmlWriter_Release(writer); + /* Empty strings for prefix and uri. */ + stream = writer_set_output(writer); + + hr = IXmlWriter_SetProperty(writer, XmlWriterProperty_Indent, FALSE); + ok(hr == S_OK, "Failed to set property, hr %#lx.\n", hr); + + hr = IXmlWriter_WriteStartElement(writer, L"", L"a", NULL); + ok(hr == S_OK, "Unexpected hr %#lx.\n", hr); + hr = IXmlWriter_WriteStartElement(writer, NULL, L"b", L""); + ok(hr == S_OK, "Unexpected hr %#lx.\n", hr); + hr = IXmlWriter_WriteStartElement(writer, L"", L"c", L""); + ok(hr == S_OK, "Unexpected hr %#lx.\n", hr); + hr = IXmlWriter_WriteFullEndElement(writer); + ok(hr == S_OK, "Unexpected hr %#lx.\n", hr); + hr = IXmlWriter_WriteFullEndElement(writer); + ok(hr == S_OK, "Unexpected hr %#lx.\n", hr); + hr = IXmlWriter_WriteFullEndElement(writer); + ok(hr == S_OK, "Unexpected hr %#lx.\n", hr); + + hr = IXmlWriter_Flush(writer); + ok(hr == S_OK, "Unexpected hr %#lx.\n", hr); + CHECK_OUTPUT(stream, "<a><b><c></c></b></a>"); IStream_Release(stream); + + IXmlWriter_Release(writer); } static void test_WriteCharEntity(void) diff --git a/dlls/xmllite/writer.c b/dlls/xmllite/writer.c index 0a3717d426e..2ec1a3b12da 100644 --- a/dlls/xmllite/writer.c +++ b/dlls/xmllite/writer.c @@ -168,6 +168,11 @@ static inline void writer_free(const xmlwriter *writer, void *mem) m_free(writer->imalloc, mem); } +static BOOL is_empty_string(const WCHAR *str) +{ + return !str || !*str; +} + static struct element *alloc_element(xmlwriter *writer, const WCHAR *prefix, const WCHAR *local) { struct element *ret; @@ -176,7 +181,7 @@ static struct element *alloc_element(xmlwriter *writer, const WCHAR *prefix, con ret = writer_alloc(writer, sizeof(*ret)); if (!ret) return ret; - len = prefix ? lstrlenW(prefix) + 1 /* ':' */ : 0; + len = is_empty_string(prefix) ? 0 : lstrlenW(prefix) + 1 /* ':' */; len += lstrlenW(local); ret->qname = writer_alloc(writer, (len + 1)*sizeof(WCHAR)); @@ -188,13 +193,13 @@ static struct element *alloc_element(xmlwriter *writer, const WCHAR *prefix, con } ret->len = len; - if (prefix) + if (is_empty_string(prefix)) + ret->qname[0] = 0; + else { lstrcpyW(ret->qname, prefix); lstrcatW(ret->qname, L":"); } - else - ret->qname[0] = 0; lstrcatW(ret->qname, local); list_init(&ret->ns); @@ -288,11 +293,6 @@ static struct ns *writer_push_ns(xmlwriter *writer, const WCHAR *prefix, int pre return ns; } -static BOOL is_empty_string(const WCHAR *str) -{ - return !str || !*str; -} - static struct ns *writer_find_ns_current(const xmlwriter *writer, const WCHAR *prefix, const WCHAR *uri) { struct element *element; @@ -1676,7 +1676,7 @@ static HRESULT WINAPI xmlwriter_WriteStartElement(IXmlWriter *iface, LPCWSTR pre writer_push_element(This, element); - if (!ns && uri) + if (!ns && !is_empty_string(uri)) writer_push_ns(This, prefix, prefix_len, uri); write_output_buffer_char(This->output, '<');

1 0

Nikolay Sivov : xmllite/writer: Close open tag on WriteRaw().
by Alexandre Julliard 15 Sep '22

15 Sep '22

Module: wine Branch: master Commit: cd55a67424ed75d6356e5b42d4cc22eaab2a0f58 URL: https://gitlab.winehq.org/wine/wine/-/commit/cd55a67424ed75d6356e5b42d4cc22… Author: Nikolay Sivov <nsivov(a)codeweavers.com> Date: Wed Sep 14 23:48:07 2022 +0300 xmllite/writer: Close open tag on WriteRaw(). Signed-off-by: Nikolay Sivov <nsivov(a)codeweavers.com> --- dlls/xmllite/tests/writer.c | 16 ++++++++++++++-- dlls/xmllite/writer.c | 3 +++ 2 files changed, 17 insertions(+), 2 deletions(-) diff --git a/dlls/xmllite/tests/writer.c b/dlls/xmllite/tests/writer.c index c76f3708fca..72ca7309355 100644 --- a/dlls/xmllite/tests/writer.c +++ b/dlls/xmllite/tests/writer.c @@ -1320,11 +1320,23 @@ static void test_WriteRaw(void) hr = IXmlWriter_Flush(writer); ok(hr == S_OK, "Unexpected hr %#lx.\n", hr); - CHECK_OUTPUT(stream, "<?xml version=\"1.0\" encoding=\"UTF-8\"?>a<:a<:a<:<a>a</a>"); + IStream_Release(stream); - IXmlWriter_Release(writer); + /* With open element. */ + stream = writer_set_output(writer); + + hr = IXmlWriter_WriteStartElement(writer, NULL, L"w", NULL); + ok(hr == S_OK, "Unexpected hr %#lx.\n", hr); + hr = IXmlWriter_WriteRaw(writer, L"text"); + ok(hr == S_OK, "Unexpected hr %#lx.\n", hr); + + hr = IXmlWriter_Flush(writer); + ok(hr == S_OK, "Unexpected hr %#lx.\n", hr); + CHECK_OUTPUT(stream, "<w>text"); IStream_Release(stream); + + IXmlWriter_Release(writer); } static void test_writer_state(void) diff --git a/dlls/xmllite/writer.c b/dlls/xmllite/writer.c index 2ec1a3b12da..99dfff3c918 100644 --- a/dlls/xmllite/writer.c +++ b/dlls/xmllite/writer.c @@ -1563,6 +1563,9 @@ static HRESULT WINAPI xmlwriter_WriteRaw(IXmlWriter *iface, LPCWSTR data) break; case XmlWriterState_InvalidEncoding: return MX_E_ENCODING; + case XmlWriterState_ElemStarted: + writer_close_starttag(This); + break; default: This->state = XmlWriterState_DocClosed; return WR_E_INVALIDACTION;

1 0

Nikolay Sivov : xmllite/writer: Close open tag on WriteProcessingInstruction().
by Alexandre Julliard 15 Sep '22

15 Sep '22

Module: wine Branch: master Commit: 5de86e12ade42a3f37c62aee343bce88cf24601f URL: https://gitlab.winehq.org/wine/wine/-/commit/5de86e12ade42a3f37c62aee343bce… Author: Nikolay Sivov <nsivov(a)codeweavers.com> Date: Wed Sep 14 23:53:13 2022 +0300 xmllite/writer: Close open tag on WriteProcessingInstruction(). Signed-off-by: Nikolay Sivov <nsivov(a)codeweavers.com> --- dlls/xmllite/tests/writer.c | 25 +++++++++++++++++++++++++ dlls/xmllite/writer.c | 2 ++ 2 files changed, 27 insertions(+) diff --git a/dlls/xmllite/tests/writer.c b/dlls/xmllite/tests/writer.c index 72ca7309355..f01f6194a4d 100644 --- a/dlls/xmllite/tests/writer.c +++ b/dlls/xmllite/tests/writer.c @@ -2131,6 +2131,30 @@ static void test_WriteWhitespace(void) IXmlWriter_Release(writer); } +static void test_WriteProcessingInstruction(void) +{ + IXmlWriter *writer; + IStream *stream; + HRESULT hr; + + hr = CreateXmlWriter(&IID_IXmlWriter, (void **)&writer, NULL); + ok(hr == S_OK, "Unexpected hr %#lx.\n", hr); + + stream = writer_set_output(writer); + + hr = IXmlWriter_WriteStartElement(writer, NULL, L"w", NULL); + ok(hr == S_OK, "Unexpected hr %#lx.\n", hr); + hr = IXmlWriter_WriteProcessingInstruction(writer, L"pi", L"content"); + ok(hr == S_OK, "Unexpected hr %#lx.\n", hr); + + hr = IXmlWriter_Flush(writer); + ok(hr == S_OK, "Failed to flush, hr %#lx.\n", hr); + CHECK_OUTPUT(stream, "<w><?pi content?>"); + IStream_Release(stream); + + IXmlWriter_Release(writer); +} + START_TEST(writer) { test_writer_create(); @@ -2154,4 +2178,5 @@ START_TEST(writer) test_WriteString(); test_WriteDocType(); test_WriteWhitespace(); + test_WriteProcessingInstruction(); } diff --git a/dlls/xmllite/writer.c b/dlls/xmllite/writer.c index 99dfff3c918..1df4c1dc922 100644 --- a/dlls/xmllite/writer.c +++ b/dlls/xmllite/writer.c @@ -1500,6 +1500,8 @@ static HRESULT WINAPI xmlwriter_WriteProcessingInstruction(IXmlWriter *iface, LP return WR_E_INVALIDACTION; break; case XmlWriterState_ElemStarted: + writer_close_starttag(This); + break; case XmlWriterState_DocClosed: return WR_E_INVALIDACTION; default:

1 0