January 2023 - Wine-commits

Eric Pouech : user32/tests: Retry when opening the clipboard.
by Alexandre Julliard 09 Jan '23

09 Jan '23

Module: wine Branch: master Commit: e439611d100603d02fdb586b8e6cbce9822e24e8 URL: https://gitlab.winehq.org/wine/wine/-/commit/e439611d100603d02fdb586b8e6cbc… Author: Eric Pouech <eric.pouech(a)gmail.com> Date: Mon Jan 9 09:31:02 2023 +0100 user32/tests: Retry when opening the clipboard. As the clipboard is a shared resource, we cannot expect that no other app hasn't openeded it. So wrap clipboard access with a retry feature in case of failure. Signed-off-by: Eric Pouech <eric.pouech(a)gmail.com> --- dlls/user32/tests/edit.c | 35 ++++++++++++++++++++++++++++++++--- 1 file changed, 32 insertions(+), 3 deletions(-) diff --git a/dlls/user32/tests/edit.c b/dlls/user32/tests/edit.c index 2afbbd5bea4..1918d1c10e9 100644 --- a/dlls/user32/tests/edit.c +++ b/dlls/user32/tests/edit.c @@ -32,6 +32,35 @@ #define ID_EDITTEST2 99 #define MAXLEN 200 +static BOOL open_clipboard(HWND hwnd) +{ + DWORD start = GetTickCount(); + while (1) + { + BOOL ret = OpenClipboard(hwnd); + if (ret || GetLastError() != ERROR_ACCESS_DENIED) + return ret; + if (GetTickCount() - start > 100) + { + char classname[256]; + DWORD le = GetLastError(); + HWND clipwnd = GetOpenClipboardWindow(); + /* Provide a hint as to the source of interference: + * - The class name would typically be CLIPBRDWNDCLASS if the + * clipboard was opened by a Windows application using the + * ole32 API. + * - And it would be __wine_clipboard_manager if it was opened in + * response to a native application. + */ + GetClassNameA(clipwnd, classname, ARRAY_SIZE(classname)); + trace("%p (%s) opened the clipboard\n", clipwnd, classname); + SetLastError(le); + return ret; + } + Sleep(15); + } +} + struct edit_notify { int en_change, en_maxtext, en_update; }; @@ -2192,7 +2221,7 @@ static void test_espassword(void) ok(r == strlen(password), "Expected: %s, got len %ld\n", password, r); ok(strcmp(buffer, password) == 0, "expected %s, got %s\n", password, buffer); - r = OpenClipboard(hwEdit); + r = open_clipboard(hwEdit); ok(r == TRUE, "expected %d, got %ld le=%lu\n", TRUE, r, GetLastError()); r = EmptyClipboard(); ok(r == TRUE, "expected %d, got %ld\n", TRUE, r); @@ -3195,7 +3224,7 @@ static void test_paste(void) strcpy(buffer, str); GlobalUnlock(hmem); - r = OpenClipboard(hEdit); + r = open_clipboard(hEdit); ok(r == TRUE, "expected %d, got %d le=%lu\n", TRUE, r, GetLastError()); r = EmptyClipboard(); ok(r == TRUE, "expected %d, got %d\n", TRUE, r); @@ -3218,7 +3247,7 @@ static void test_paste(void) strcpy(buffer, str2); GlobalUnlock(hmem); - r = OpenClipboard(hEdit); + r = open_clipboard(hEdit); ok(r == TRUE, "expected %d, got %d le=%lu\n", TRUE, r, GetLastError()); r = EmptyClipboard(); ok(r == TRUE, "expected %d, got %d\n", TRUE, r);

1 0

Eric Pouech : user32/tests: Fix failing WM_PASTE tests for edit control on Win10+.
by Alexandre Julliard 09 Jan '23

09 Jan '23

Module: wine Branch: master Commit: ce78e293fd10bdd4f2dcf5c1df3c4b4a6beed430 URL: https://gitlab.winehq.org/wine/wine/-/commit/ce78e293fd10bdd4f2dcf5c1df3c4b… Author: Eric Pouech <eric.pouech(a)gmail.com> Date: Mon Jan 9 09:31:04 2023 +0100 user32/tests: Fix failing WM_PASTE tests for edit control on Win10+. There are cases in Windows10+ where the WM_PASTE message doesn't paste the content of the clipboard. This appeared in testing: - almost always just after (for a couple of milliseconds) setting new content into the clipboard and closing it. - in some unrelated rare occasions (like once for 400 runs). It looks like another (installed) process had opened the clipboard and forbids the paste command. As WM_PASTE doesn't return success/error status, workaround it by wrapping the WM_PASTE command into a helper, and retry when the clipboard's content hasn't been pasted. Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=53276 Signed-off-by: Eric Pouech <eric.pouech(a)gmail.com> --- dlls/user32/tests/edit.c | 37 ++++++++++++++++++++++++------------- 1 file changed, 24 insertions(+), 13 deletions(-) diff --git a/dlls/user32/tests/edit.c b/dlls/user32/tests/edit.c index 1918d1c10e9..b70cf2d6e06 100644 --- a/dlls/user32/tests/edit.c +++ b/dlls/user32/tests/edit.c @@ -3204,12 +3204,32 @@ static void test_EM_GETHANDLE(void) DestroyWindow(hEdit); } +/* In Windows 10+, the WM_PASTE message isn't always successful. + * So retry in case of failure. + */ +#define check_paste(a, b) _check_paste(__LINE__, (a), (b)) +static void _check_paste(unsigned int line, HWND hedit, const char *content) +{ + /* only retry on windows platform */ + int tries = strcmp(winetest_platform, "wine") ? 3 : 1; + int len = 0; + + SendMessageA(hedit, WM_SETTEXT, 0, (LPARAM)""); + do + { + SendMessageA(hedit, WM_PASTE, 0, 0); + if ((len = SendMessageA(hedit, WM_GETTEXTLENGTH, 0, 0))) break; + Sleep(1); + } while (--tries > 0); + ok_(__FILE__, line)(len == strlen(content), "Unexpected len %u in edit\n", len); +} + static void test_paste(void) { HWND hEdit, hMultilineEdit; HANDLE hmem, hmem_ret; char *buffer; - int r, len; + int r; static const char *str = "this is a simple text"; static const char *str2 = "first line\r\nsecond line"; @@ -3234,10 +3254,7 @@ static void test_paste(void) ok(r == TRUE, "expected %d, got %d\n", TRUE, r); /* Paste single line */ - SendMessageA(hEdit, WM_SETTEXT, 0, (LPARAM)""); - r = SendMessageA(hEdit, WM_PASTE, 0, 0); - len = SendMessageA(hEdit, WM_GETTEXTLENGTH, 0, 0); - ok(strlen(str) == len, "got %d\n", len); + check_paste(hEdit, str); /* Prepare clipboard data with multiline text */ hmem = GlobalAlloc(GMEM_MOVEABLE, 255); @@ -3257,16 +3274,10 @@ static void test_paste(void) ok(r == TRUE, "expected %d, got %d\n", TRUE, r); /* Paste multiline text in singleline edit - should be cut */ - SendMessageA(hEdit, WM_SETTEXT, 0, (LPARAM)""); - r = SendMessageA(hEdit, WM_PASTE, 0, 0); - len = SendMessageA(hEdit, WM_GETTEXTLENGTH, 0, 0); - ok(strlen("first line") == len, "got %d\n", len); + check_paste(hEdit, "first line"); /* Paste multiline text in multiline edit */ - SendMessageA(hMultilineEdit, WM_SETTEXT, 0, (LPARAM)""); - r = SendMessageA(hMultilineEdit, WM_PASTE, 0, 0); - len = SendMessageA(hMultilineEdit, WM_GETTEXTLENGTH, 0, 0); - ok(strlen(str2) == len, "got %d\n", len); + check_paste(hMultilineEdit, str2); /* Cleanup */ DestroyWindow(hEdit);

1 0

Eric Pouech : comctl32/tests: Retry when opening the clipboard.
by Alexandre Julliard 09 Jan '23

09 Jan '23

Module: wine Branch: master Commit: e9a32c6a8d472756595b6d07e97364ccc73a84a1 URL: https://gitlab.winehq.org/wine/wine/-/commit/e9a32c6a8d472756595b6d07e97364… Author: Eric Pouech <eric.pouech(a)gmail.com> Date: Mon Jan 9 09:31:05 2023 +0100 comctl32/tests: Retry when opening the clipboard. As the clipboard is a shared resource, we cannot expect that no other app hasn't openeded it. So wrap clipboard access with a retry feature in case of failure. Signed-off-by: Eric Pouech <eric.pouech(a)gmail.com> --- dlls/comctl32/tests/edit.c | 35 ++++++++++++++++++++++++++++++++--- 1 file changed, 32 insertions(+), 3 deletions(-) diff --git a/dlls/comctl32/tests/edit.c b/dlls/comctl32/tests/edit.c index 23caf877aa5..fae3091533b 100644 --- a/dlls/comctl32/tests/edit.c +++ b/dlls/comctl32/tests/edit.c @@ -72,6 +72,35 @@ static void flush_events(void) } } +static BOOL open_clipboard(HWND hwnd) +{ + DWORD start = GetTickCount(); + while (1) + { + BOOL ret = OpenClipboard(hwnd); + if (ret || GetLastError() != ERROR_ACCESS_DENIED) + return ret; + if (GetTickCount() - start > 100) + { + char classname[256]; + DWORD le = GetLastError(); + HWND clipwnd = GetOpenClipboardWindow(); + /* Provide a hint as to the source of interference: + * - The class name would typically be CLIPBRDWNDCLASS if the + * clipboard was opened by a Windows application using the + * ole32 API. + * - And it would be __wine_clipboard_manager if it was opened in + * response to a native application. + */ + GetClassNameA(clipwnd, classname, ARRAY_SIZE(classname)); + trace("%p (%s) opened the clipboard\n", clipwnd, classname); + SetLastError(le); + return ret; + } + Sleep(15); + } +} + static INT_PTR CALLBACK multi_edit_dialog_proc(HWND hdlg, UINT msg, WPARAM wparam, LPARAM lparam) { static int num_ok_commands = 0; @@ -2264,7 +2293,7 @@ static void test_espassword(void) ok(r == strlen(password), "Expected: %s, got len %ld\n", password, r); ok(strcmp(buffer, password) == 0, "expected %s, got %s\n", password, buffer); - r = OpenClipboard(hwEdit); + r = open_clipboard(hwEdit); ok(r == TRUE, "expected %d, got %ld\n", TRUE, r); r = EmptyClipboard(); ok(r == TRUE, "expected %d, got %ld\n", TRUE, r); @@ -3237,7 +3266,7 @@ static void test_paste(void) strcpy(buffer, str); GlobalUnlock(hmem); - r = OpenClipboard(hEdit); + r = open_clipboard(hEdit); ok(r == TRUE, "expected %d, got %d\n", TRUE, r); r = EmptyClipboard(); ok(r == TRUE, "expected %d, got %d\n", TRUE, r); @@ -3260,7 +3289,7 @@ static void test_paste(void) strcpy(buffer, str2); GlobalUnlock(hmem); - r = OpenClipboard(hEdit); + r = open_clipboard(hEdit); ok(r == TRUE, "expected %d, got %d\n", TRUE, r); r = EmptyClipboard(); ok(r == TRUE, "expected %d, got %d\n", TRUE, r);

1 0

Eric Pouech : comctl32/tests: Fix failing WM_PASTE tests for edit control on Win10+.
by Alexandre Julliard 09 Jan '23

09 Jan '23

Module: wine Branch: master Commit: ee5cdea92206050776753c6ac49cc156407be7ad URL: https://gitlab.winehq.org/wine/wine/-/commit/ee5cdea92206050776753c6ac49cc1… Author: Eric Pouech <eric.pouech(a)gmail.com> Date: Mon Jan 9 09:31:07 2023 +0100 comctl32/tests: Fix failing WM_PASTE tests for edit control on Win10+. There are cases in Windows10+ where the WM_PASTE message doesn't paste the content of the clipboard. This appeared in testing: - almost always just after (for a couple of milliseconds) setting new content into the clipboard and closing it. - in some unrelated rare occasions (like once for 400 runs). It looks like another (installed) process had opened the clipboard and forbids the paste command. As WM_PASTE doesn't return success/error status, workaround it by wrapping the WM_PASTE command into a helper, and retry when the clipboard's content hasn't been pasted. Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=53276 Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=53277 Signed-off-by: Eric Pouech <eric.pouech(a)gmail.com> --- dlls/comctl32/tests/edit.c | 36 ++++++++++++++++++++++++------------ 1 file changed, 24 insertions(+), 12 deletions(-) diff --git a/dlls/comctl32/tests/edit.c b/dlls/comctl32/tests/edit.c index fae3091533b..f45b898dc12 100644 --- a/dlls/comctl32/tests/edit.c +++ b/dlls/comctl32/tests/edit.c @@ -3246,6 +3246,26 @@ static void test_EM_GETHANDLE(void) DestroyWindow(hEdit); } +/* In Windows 10+, the WM_PASTE message isn't always successful. + * So retry in case of failure. + */ +#define check_paste(a, b) _check_paste(__LINE__, (a), (b)) +static void _check_paste(unsigned int line, HWND hedit, const char *content) +{ + /* only retry on windows platform */ + int tries = strcmp(winetest_platform, "wine") ? 3 : 1; + int len = 0; + + SendMessageA(hedit, WM_SETTEXT, 0, (LPARAM)""); + do + { + SendMessageA(hedit, WM_PASTE, 0, 0); + if ((len = SendMessageA(hedit, WM_GETTEXTLENGTH, 0, 0))) break; + Sleep(1); + } while (--tries > 0); + ok_(__FILE__, line)(len == strlen(content), "Unexpected len %u in edit\n", len); +} + static void test_paste(void) { static const char *str = "this is a simple text"; @@ -3253,7 +3273,7 @@ static void test_paste(void) HWND hEdit, hMultilineEdit; HANDLE hmem, hmem_ret; char *buffer; - int r, len; + int r; hEdit = create_editcontrol(ES_AUTOHSCROLL | ES_AUTOVSCROLL, 0); hMultilineEdit = create_editcontrol(ES_AUTOHSCROLL | ES_AUTOVSCROLL | ES_MULTILINE, 0); @@ -3276,10 +3296,7 @@ static void test_paste(void) ok(r == TRUE, "expected %d, got %d\n", TRUE, r); /* Paste single line */ - SendMessageA(hEdit, WM_SETTEXT, 0, (LPARAM)""); - r = SendMessageA(hEdit, WM_PASTE, 0, 0); - len = SendMessageA(hEdit, WM_GETTEXTLENGTH, 0, 0); - ok(strlen(str) == len, "got %d\n", len); + check_paste(hEdit, str); /* Prepare clipboard data with multiline text */ hmem = GlobalAlloc(GMEM_MOVEABLE, 255); @@ -3300,15 +3317,10 @@ static void test_paste(void) /* Paste multiline text in singleline edit - should be cut */ SendMessageA(hEdit, WM_SETTEXT, 0, (LPARAM)""); - r = SendMessageA(hEdit, WM_PASTE, 0, 0); - len = SendMessageA(hEdit, WM_GETTEXTLENGTH, 0, 0); - ok(strlen("first line") == len, "got %d\n", len); + check_paste(hEdit, "first line"); /* Paste multiline text in multiline edit */ - SendMessageA(hMultilineEdit, WM_SETTEXT, 0, (LPARAM)""); - r = SendMessageA(hMultilineEdit, WM_PASTE, 0, 0); - len = SendMessageA(hMultilineEdit, WM_GETTEXTLENGTH, 0, 0); - ok(strlen(str2) == len, "got %d\n", len); + check_paste(hMultilineEdit, str2); /* Cleanup */ DestroyWindow(hEdit);

1 0

Alistair Leslie-Hughes : faudio: Purge and clear notifications on ShutDown.
by Alexandre Julliard 09 Jan '23

09 Jan '23

Module: wine Branch: master Commit: 8e9763871b6f33e298c4c24627c490b1b46dda7e URL: https://gitlab.winehq.org/wine/wine/-/commit/8e9763871b6f33e298c4c24627c490… Author: Alistair Leslie-Hughes <leslie_alistair(a)hotmail.com> Date: Mon Jan 9 07:06:11 2023 +1100 faudio: Purge and clear notifications on ShutDown. Cherry-picked from upstream commit 16f86bffec36b6e82e5c93d5f04ebc4ee4f980ab. Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=54264 --- libs/faudio/src/FACT.c | 10 ++++++++++ 1 file changed, 10 insertions(+) diff --git a/libs/faudio/src/FACT.c b/libs/faudio/src/FACT.c index 649abf2111c..d40e56f12e6 100644 --- a/libs/faudio/src/FACT.c +++ b/libs/faudio/src/FACT.c @@ -352,6 +352,16 @@ uint32_t FACTAudioEngine_ShutDown(FACTAudioEngine *pEngine) FAudio_StopEngine(pEngine->audio); } + /* Purge All pending notifactions */ + while (pEngine->wb_notifications_list) + { + FACTNotification *note = (FACTNotification*) pEngine->wb_notifications_list->entry; + pEngine->notificationCallback(note); + LinkedList_RemoveEntry(&pEngine->wb_notifications_list, note, pEngine->apiLock, pEngine->pFree); + } + + pEngine->notifications = 0; + /* This method destroys all existing cues, sound banks, and wave banks. * It blocks until all cues are destroyed. */

1 0

Alexandre Julliard : Update copyright info for 2023.
by Alexandre Julliard 09 Jan '23

09 Jan '23

Module: wine Branch: master Commit: 1c83f47893af5344a817a536b36c04ff5b4418ac URL: https://gitlab.winehq.org/wine/wine/-/commit/1c83f47893af5344a817a536b36c04… Author: Alexandre Julliard <julliard(a)winehq.org> Date: Sun Jan 8 12:12:25 2023 +0100 Update copyright info for 2023. --- LICENSE | 2 +- dlls/opengl32/version.rc | 2 +- include/wine/wine_common_ver.rc | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/LICENSE b/LICENSE index e8275c2cfc9..f8aa2b9658d 100644 --- a/LICENSE +++ b/LICENSE @@ -1,4 +1,4 @@ -Copyright (c) 1993-2022 the Wine project authors (see the file AUTHORS +Copyright (c) 1993-2023 the Wine project authors (see the file AUTHORS for a complete list) Wine is free software; you can redistribute it and/or modify it under diff --git a/dlls/opengl32/version.rc b/dlls/opengl32/version.rc index b8e01166a44..63d526ffe00 100644 --- a/dlls/opengl32/version.rc +++ b/dlls/opengl32/version.rc @@ -20,7 +20,7 @@ #define WINE_FILENAME_STR "opengl32.dll" #define WINE_FILEVERSION 5,1,2600,2082 #define WINE_FILEVERSION_STR "5.1.2600.2082" -#define WINE_LEGALCOPYRIGHT "Copyright (c) 1993-2022 the Wine project. Not Microsoft" /* CATIA needs 'Microsoft' in both CompanyName _and_ LegalCopyright */ +#define WINE_LEGALCOPYRIGHT "Copyright (c) 1993-2023 the Wine project. Not Microsoft" /* CATIA needs 'Microsoft' in both CompanyName _and_ LegalCopyright */ #define WINE_PRODUCTVERSION 5,1,2600,2082 #define WINE_PRODUCTVERSION_STR "5.1" diff --git a/include/wine/wine_common_ver.rc b/include/wine/wine_common_ver.rc index a70dee3b678..95ab04666e8 100644 --- a/include/wine/wine_common_ver.rc +++ b/include/wine/wine_common_ver.rc @@ -80,7 +80,7 @@ never complain. #endif #ifndef WINE_LEGALCOPYRIGHT -#define WINE_LEGALCOPYRIGHT "Copyright (c) 1993-2022 the Wine project authors (see the file AUTHORS for a complete list)" +#define WINE_LEGALCOPYRIGHT "Copyright (c) 1993-2023 the Wine project authors (see the file AUTHORS for a complete list)" #endif #ifndef WINE_PRODUCTVERSION

1 0

Alexandre Julliard : gitlab: Add a daily win10 test run.
by Alexandre Julliard 09 Jan '23

09 Jan '23

Module: wine Branch: master Commit: 1bc133a3d34cbf89a772c50bc423205eaa0cdb9e URL: https://gitlab.winehq.org/wine/wine/-/commit/1bc133a3d34cbf89a772c50bc42320… Author: Alexandre Julliard <julliard(a)winehq.org> Date: Mon Jan 9 16:43:33 2023 +0100 gitlab: Add a daily win10 test run. --- tools/gitlab/build.yml | 2 +- tools/gitlab/test.yml | 28 ++++++++++++++++++++++++++++ 2 files changed, 29 insertions(+), 1 deletion(-) diff --git a/tools/gitlab/build.yml b/tools/gitlab/build.yml index 6bc253b2c77..12ffe86dd62 100644 --- a/tools/gitlab/build.yml +++ b/tools/gitlab/build.yml @@ -63,7 +63,7 @@ build-daily-linux: build-winetest: stage: build - image: $CI_DEPENDENCY_PROXY_DIRECT_GROUP_IMAGE_PREFIX/debian:bullseye + image: $CI_REGISTRY/wine/wine:debian-bullseye rules: - if: $CI_PIPELINE_SOURCE == 'trigger' && $CI_COMMIT_BRANCH == $CI_DEFAULT_BRANCH needs: diff --git a/tools/gitlab/test.yml b/tools/gitlab/test.yml index d2b1966ad6e..da34390bc1f 100644 --- a/tools/gitlab/test.yml +++ b/tools/gitlab/test.yml @@ -71,3 +71,31 @@ debian-64: - job: build-daily-linux script: - wine usr/local/lib/wine/x86_64-windows/winetest.exe -q -t gitlab-$CI_JOB_NAME -u $CI_JOB_URL + +win10-21h2-32: + stage: test + interruptible: true + variables: + GIT_STRATEGY: none + rules: + - if: $CI_PIPELINE_SOURCE == 'trigger' && $CI_COMMIT_BRANCH == $CI_DEFAULT_BRANCH + needs: + - job: build-winetest + tags: + - win10-21h2 + script: + - ./winetest.exe -q -t gitlab-$CI_JOB_NAME -u $CI_JOB_URL + +win10-21h2-64: + stage: test + interruptible: true + variables: + GIT_STRATEGY: none + rules: + - if: $CI_PIPELINE_SOURCE == 'trigger' && $CI_COMMIT_BRANCH == $CI_DEFAULT_BRANCH + needs: + - job: build-winetest + tags: + - win10-21h2 + script: + - ./winetest64.exe -q -t gitlab-$CI_JOB_NAME -u $CI_JOB_URL

1 0

Alexandre Julliard : kernelbase: Fix FindNLSStringEx for strings with no primary weights.
by Alexandre Julliard 09 Jan '23

09 Jan '23

Module: wine Branch: master Commit: 448e68ab5b937d168f5d091d8f65a7de534a9891 URL: https://gitlab.winehq.org/wine/wine/-/commit/448e68ab5b937d168f5d091d8f65a7… Author: Alexandre Julliard <julliard(a)winehq.org> Date: Mon Jan 9 11:50:20 2023 +0100 kernelbase: Fix FindNLSStringEx for strings with no primary weights. Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=53583 Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=53837 --- dlls/kernel32/tests/locale.c | 10 +++++++ dlls/kernelbase/locale.c | 66 +++++++++++++++++++++++--------------------- 2 files changed, 45 insertions(+), 31 deletions(-) diff --git a/dlls/kernel32/tests/locale.c b/dlls/kernel32/tests/locale.c index 40706c15755..886240cc22c 100644 --- a/dlls/kernel32/tests/locale.c +++ b/dlls/kernel32/tests/locale.c @@ -6741,6 +6741,16 @@ static void test_FindNLSStringEx(void) { localeW, FIND_ENDSWITH, L"SimpleSimple", L"Simp", -1, 0xdeadbeef}, { localeW, FIND_FROMSTART, comb_s_accent1W, comb_s_accent2W, 0, 6 }, { localeW, FIND_FROMSTART, comb_q_accent1W, comb_q_accent2W, 2, 7 }, + { localeW, FIND_STARTSWITH, L"--Option", L"--", 0, 2}, + { localeW, FIND_ENDSWITH, L"Option--", L"--", 6, 2}, + { localeW, FIND_FROMSTART, L"----", L"--", 0, 2}, + { localeW, FIND_FROMEND, L"----", L"--", 2, 2}, + { localeW, FIND_FROMSTART, L"opt1--opt2--opt3", L"--", 4, 2}, + { localeW, FIND_FROMEND, L"opt1--opt2--opt3", L"--", 10, 2}, + { localeW, FIND_FROMSTART, L"x-oss-security", L"x-oss-", 0, 6}, + { localeW, FIND_FROMSTART, L"x-oss-security", L"-oss", 1, 4}, + { localeW, FIND_FROMSTART, L"x-oss-security", L"-oss--", -1, 0xdeadbeef}, + { localeW, FIND_FROMEND, L"x-oss-oss2", L"-oss", 5, 4}, }; unsigned int i; diff --git a/dlls/kernelbase/locale.c b/dlls/kernelbase/locale.c index 5cc4152e491..1e96e49622e 100644 --- a/dlls/kernelbase/locale.c +++ b/dlls/kernelbase/locale.c @@ -3892,7 +3892,7 @@ static int find_substring( const struct sortguid *sortid, DWORD flags, const WCH struct sortkey_state val; BYTE primary[32]; BYTE primary_val[256]; - int i, start, found = -1, foundlen, pos = 0; + int i, start, len, found = -1, foundlen = 0, pos = 0; BOOL have_extra, have_extra_val; BYTE case_mask = 0x3f; UINT except = sortid->except; @@ -3915,43 +3915,47 @@ static int find_substring( const struct sortguid *sortid, DWORD flags, const WCH for (start = 0; start < srclen; start++) { - pos = start; - while (pos < srclen && s.primary_pos < val.key_primary.len) + for (len = start + 1; len <= srclen; len++) { - while (pos < srclen && !s.key_primary.len) - pos += append_weights( sortid, flags, src, srclen, pos, - case_mask, except, compr_tables, &s, TRUE ); - - if (s.primary_pos + s.key_primary.len > val.key_primary.len) goto next; - if (memcmp( primary, val.key_primary.buf + s.primary_pos, s.key_primary.len )) goto next; - s.primary_pos += s.key_primary.len; - s.key_primary.len = 0; - } - if (s.primary_pos < val.key_primary.len) goto next; + pos = start; + while (pos < len && s.primary_pos <= val.key_primary.len) + { + while (pos < len && !s.key_primary.len) + pos += append_weights( sortid, flags, src, srclen, pos, + case_mask, except, compr_tables, &s, TRUE ); + + if (s.primary_pos + s.key_primary.len > val.key_primary.len) goto next; + if (memcmp( primary, val.key_primary.buf + s.primary_pos, s.key_primary.len )) goto next; + s.primary_pos += s.key_primary.len; + s.key_primary.len = 0; + } + if (s.primary_pos < val.key_primary.len) goto next; - have_extra = remove_unneeded_weights( sortid, &s ); - if (compare_sortkeys( &s.key_diacritic, &val.key_diacritic, FALSE )) goto next; - if (compare_sortkeys( &s.key_case, &val.key_case, FALSE )) goto next; + have_extra = remove_unneeded_weights( sortid, &s ); + if (compare_sortkeys( &s.key_diacritic, &val.key_diacritic, FALSE )) goto next; + if (compare_sortkeys( &s.key_case, &val.key_case, FALSE )) goto next; - if (have_extra && have_extra_val) - { - for (i = 0; i < 4; i++) - if (compare_sortkeys( &s.key_extra[i], &val.key_extra[i], i != 1 )) goto next; - } - else if (have_extra || have_extra_val) goto next; + if (have_extra && have_extra_val) + { + for (i = 0; i < 4; i++) + if (compare_sortkeys( &s.key_extra[i], &val.key_extra[i], i != 1 )) goto next; + } + else if (have_extra || have_extra_val) goto next; - if (compare_sortkeys( &s.key_special, &val.key_special, FALSE )) goto next; + if (compare_sortkeys( &s.key_special, &val.key_special, FALSE )) goto next; - found = start; - foundlen = pos - start; - if (flags & FIND_FROMSTART) break; + found = start; + foundlen = pos - start; + len = srclen; /* no need to continue checking longer strings */ - next: + next: + /* reset state */ + s.key_primary.len = s.key_diacritic.len = s.key_case.len = s.key_special.len = 0; + s.key_extra[0].len = s.key_extra[1].len = s.key_extra[2].len = s.key_extra[3].len = 0; + s.primary_pos = 0; + } if (flags & FIND_STARTSWITH) break; - /* reset state */ - s.key_primary.len = s.key_diacritic.len = s.key_case.len = s.key_special.len = 0; - s.key_extra[0].len = s.key_extra[1].len = s.key_extra[2].len = s.key_extra[3].len = 0; - s.primary_pos = 0; + if (flags & FIND_FROMSTART && found != -1) break; } if (found != -1)

1 0

Jeremy White : gitlab: Add tools for using gitlab-runner with libvirt.
by Alexandre Julliard 09 Jan '23

09 Jan '23

Module: tools Branch: master Commit: aec25a1a92850342768bbb37e514f47e003bd94e URL: https://gitlab.winehq.org/winehq/tools/-/commit/aec25a1a92850342768bbb37e51… Author: Jeremy White <jwhite(a)codeweavers.com> Date: Mon Jan 9 17:00:56 2023 +0100 gitlab: Add tools for using gitlab-runner with libvirt. --- gitlab/virtrunner/README | 57 ++++++++++ gitlab/virtrunner/cleanup.sh | 7 ++ gitlab/virtrunner/config | 20 ++++ gitlab/virtrunner/config.toml.example | 29 ++++++ gitlab/virtrunner/prepare.sh | 27 +++++ gitlab/virtrunner/qemu-agent.py | 190 ++++++++++++++++++++++++++++++++++ gitlab/virtrunner/run.sh | 15 +++ 7 files changed, 345 insertions(+)

1 0

Alexandre Julliard : Wine release 8.0-rc3
by Alexandre Julliard 07 Jan '23

07 Jan '23

Module: website Branch: master Commit: 55e491b7797eaa16d7534162af780a1b973d83a3 URL: https://gitlab.winehq.org/winehq/winehq/-/commit/55e491b7797eaa16d7534162af… Author: Alexandre Julliard <julliard(a)winehq.org> Date: Sat Jan 7 11:42:46 2023 +0100 Wine release 8.0-rc3 --- news/en/2023010701.xml | 13 +++++++++++++ 1 file changed, 13 insertions(+) diff --git a/news/en/2023010701.xml b/news/en/2023010701.xml new file mode 100644 index 00000000..06efd494 --- /dev/null +++ b/news/en/2023010701.xml @@ -0,0 +1,13 @@ +<news> +<date>January 7, 2023</date> +<title>Wine 8.0-rc3 Released</title> +<body> + The Wine development release 8.0-rc3 is now available. + <a href="{$root}/announce/8.0-rc3">What's new</a> in this release: +<ul> + <li>Bug fixes only, we are in code freeze.</li> +</ul> + +The source is <a href="//dl.winehq.org/wine/source/8.0/wine-8.0-rc3.tar.xz">available now</a>. +Binary packages are in the process of being built, and will appear soon at their respective <a href="{$root}/download">download locations</a>. +</body></news>

1 0