October 2023 - Wine-commits

Connor McAdams : uiautomationcore: Use EVENT_OBJECT_FOCUS to advise HWND providers of focus change events in the COM API.
by Alexandre Julliard 10 Oct '23

10 Oct '23

Module: wine Branch: master Commit: a275834bddfbb8d0b5ac3b36d584a839382aa9eb URL: https://gitlab.winehq.org/wine/wine/-/commit/a275834bddfbb8d0b5ac3b36d584a8… Author: Connor McAdams <cmcadams(a)codeweavers.com> Date: Fri Sep 15 15:34:14 2023 -0400 uiautomationcore: Use EVENT_OBJECT_FOCUS to advise HWND providers of focus change events in the COM API. Signed-off-by: Connor McAdams <cmcadams(a)codeweavers.com> --- dlls/uiautomationcore/tests/uiautomation.c | 4 +-- dlls/uiautomationcore/uia_com_client.c | 53 +++++++++++++++++++++++++++++- 2 files changed, 54 insertions(+), 3 deletions(-) diff --git a/dlls/uiautomationcore/tests/uiautomation.c b/dlls/uiautomationcore/tests/uiautomation.c index 5519cbbc312..278958e8562 100644 --- a/dlls/uiautomationcore/tests/uiautomation.c +++ b/dlls/uiautomationcore/tests/uiautomation.c @@ -15436,12 +15436,12 @@ static void test_uia_com_event_handler_event_advisement(IUIAutomation *uia_iface set_uia_hwnd_expects(0, 1, 1, 2, 0); /* Only Win11 sends WM_GETOBJECT 2 times. */ NotifyWinEvent(EVENT_OBJECT_FOCUS, test_child_hwnd, OBJID_CLIENT, CHILDID_SELF); - todo_wine ok(msg_wait_for_all_events(method_event, 1, 2000) != WAIT_TIMEOUT, "Wait for method_event(s) timed out.\n"); + ok(msg_wait_for_all_events(method_event, 1, 2000) != WAIT_TIMEOUT, "Wait for method_event(s) timed out.\n"); if (wait_for_clientside_callbacks(2000)) trace("Kept getting callbacks up until timeout\n"); check_uia_hwnd_expects_at_most(0, 1, 1, 2, 0); CHECK_CALLED_AT_MOST(child_winproc_GETOBJECT_UiaRoot, 3); - test_provider_event_advise_added(&Provider2, UIA_AutomationFocusChangedEventId, TRUE); + test_provider_event_advise_added(&Provider2, UIA_AutomationFocusChangedEventId, FALSE); test_provider_event_advise_added(&Provider_hwnd3, 0, FALSE); test_provider_event_advise_added(&Provider_nc3, 0, FALSE); diff --git a/dlls/uiautomationcore/uia_com_client.c b/dlls/uiautomationcore/uia_com_client.c index 01272f89064..22b55dd5234 100644 --- a/dlls/uiautomationcore/uia_com_client.c +++ b/dlls/uiautomationcore/uia_com_client.c @@ -974,10 +974,43 @@ struct uia_com_event { HUIAEVENT event; BOOL from_cui8; + struct rb_tree focus_hwnd_map; struct list event_handler_map_list_entry; struct uia_event_handler_map_entry *handler_map; }; +static void uia_com_focus_handler_advise_node(struct uia_com_event *event, HUIANODE node, HWND hwnd) +{ + HRESULT hr; + + hr = uia_event_advise_node((struct uia_event *)event->event, node); + if (FAILED(hr)) + { + WARN("uia_event_advise_node failed with hr %#lx\n", hr); + return; + } + + hr = uia_hwnd_map_add_hwnd(&event->focus_hwnd_map, hwnd); + if (FAILED(hr)) + WARN("Failed to add hwnd for focus winevent, hr %#lx\n", hr); +} + +static void uia_com_focus_win_event_handler(HUIANODE node, HWND hwnd, struct uia_event_handler_event_id_map_entry *event_id_map) +{ + struct uia_event_handler_map_entry *entry; + + LIST_FOR_EACH_ENTRY(entry, &event_id_map->handlers_list, struct uia_event_handler_map_entry, handler_event_id_map_list_entry) + { + struct uia_com_event *event; + + LIST_FOR_EACH_ENTRY(event, &entry->handlers_list, struct uia_com_event, event_handler_map_list_entry) + { + if (!uia_hwnd_map_check_hwnd(&event->focus_hwnd_map, hwnd)) + uia_com_focus_handler_advise_node(event, node, hwnd); + } + } +} + HRESULT uia_com_win_event_callback(DWORD event_id, HWND hwnd, LONG obj_id, LONG child_id, DWORD thread_id, DWORD event_time) { LONG handler_count; @@ -1060,11 +1093,13 @@ HRESULT uia_com_win_event_callback(DWORD event_id, HWND hwnd, LONG obj_id, LONG if ((rb_entry = rb_get(&com_event_handlers.handler_event_id_map, &uia_event_id))) { + struct uia_event_handler_event_id_map_entry *event_id_map; HUIANODE node = NULL; + event_id_map = RB_ENTRY_VALUE(rb_entry, struct uia_event_handler_event_id_map_entry, entry); hr = create_uia_node_from_hwnd(hwnd, &node, NODE_FLAG_IGNORE_CLIENTSIDE_HWND_PROVS); if (SUCCEEDED(hr)) - FIXME("EVENT_OBJECT_FOCUS event advisement currently unimplemented\n"); + uia_com_focus_win_event_handler(node, hwnd, event_id_map); UiaNodeRelease(node); } @@ -1155,6 +1190,20 @@ static HRESULT uia_event_handlers_add_handler(IUnknown *handler_iface, SAFEARRAY list_add_tail(&event_map->handlers_list, &event->event_handler_map_list_entry); event->handler_map = event_map; com_event_handlers.handler_count++; + if (event_id == UIA_AutomationFocusChangedEventId) + { + GUITHREADINFO info = { sizeof(info) }; + + if (GetGUIThreadInfo(0, &info) && info.hwndFocus) + { + HUIANODE node = NULL; + + hr = create_uia_node_from_hwnd(info.hwndFocus, &node, NODE_FLAG_IGNORE_CLIENTSIDE_HWND_PROVS); + if (SUCCEEDED(hr)) + uia_com_focus_handler_advise_node(event, node, info.hwndFocus); + UiaNodeRelease(node); + } + } exit: LeaveCriticalSection(&com_event_handlers_cs); @@ -1165,6 +1214,7 @@ exit: static void uia_event_handler_destroy(struct uia_com_event *event) { list_remove(&event->event_handler_map_list_entry); + uia_hwnd_map_destroy(&event->focus_hwnd_map); if (event->event) UiaRemoveEvent(event->event); if (event->git_cookie) @@ -3459,6 +3509,7 @@ static HRESULT uia_add_com_event_handler(IUIAutomation6 *iface, EVENTID event_id com_event->from_cui8 = element->from_cui8; list_init(&com_event->event_handler_map_list_entry); + uia_hwnd_map_init(&com_event->focus_hwnd_map); hr = IUnknown_QueryInterface(handler_unk, handler_riid, (void **)&handler_iface); if (FAILED(hr))

1 0

Connor McAdams : uiautomationcore: Use EVENT_OBJECT_DESTROY to remove HWNDs from the COM API focus change HWND map.
by Alexandre Julliard 10 Oct '23

10 Oct '23

Module: wine Branch: master Commit: 4569157b282f0274bb774795f207a25822105065 URL: https://gitlab.winehq.org/wine/wine/-/commit/4569157b282f0274bb774795f207a2… Author: Connor McAdams <cmcadams(a)codeweavers.com> Date: Tue Oct 10 07:39:11 2023 -0400 uiautomationcore: Use EVENT_OBJECT_DESTROY to remove HWNDs from the COM API focus change HWND map. Signed-off-by: Connor McAdams <cmcadams(a)codeweavers.com> --- dlls/uiautomationcore/tests/uiautomation.c | 24 ++++++++++++++++++++++ dlls/uiautomationcore/uia_com_client.c | 32 ++++++++++++++++++++++++++++++ dlls/uiautomationcore/uia_event.c | 1 + dlls/uiautomationcore/uia_private.h | 1 + dlls/uiautomationcore/uia_utils.c | 17 ++++++++++++++++ 5 files changed, 75 insertions(+) diff --git a/dlls/uiautomationcore/tests/uiautomation.c b/dlls/uiautomationcore/tests/uiautomation.c index 278958e8562..7790907d674 100644 --- a/dlls/uiautomationcore/tests/uiautomation.c +++ b/dlls/uiautomationcore/tests/uiautomation.c @@ -15475,6 +15475,30 @@ static void test_uia_com_event_handler_event_advisement(IUIAutomation *uia_iface check_uia_hwnd_expects_at_most(0, 1, 1, 3, 0); test_hwnd_providers_event_advise_added(&Provider, &Provider_hwnd2, &Provider_nc2, 0, FALSE); + /* HWND destruction is tracked with EVENT_OBJECT_DESTROY/OBJID_WINDOW. */ + NotifyWinEvent(EVENT_OBJECT_DESTROY, test_child_hwnd, OBJID_WINDOW, CHILDID_SELF); + if (wait_for_clientside_callbacks(2000)) trace("Kept getting callbacks up until timeout\n"); + + /* + * EVENT_OBJECT_DESTROY removed this HWND, EVENT_OBJECT_FOCUS will now + * advise it again. + */ + reset_event_advise_values_for_hwnd_providers(&Provider2, &Provider_hwnd3, &Provider_nc3); + set_provider_method_event_data(&Provider2, method_event[0], ADVISE_EVENTS_EVENT_ADDED); + SET_EXPECT_MULTI(child_winproc_GETOBJECT_UiaRoot, 3); /* Only sent 3 times on Win11. */ + set_uia_hwnd_expects(0, 1, 1, 2, 0); /* Only Win11 sends WM_GETOBJECT 2 times. */ + + NotifyWinEvent(EVENT_OBJECT_FOCUS, test_child_hwnd, OBJID_CLIENT, CHILDID_SELF); + ok(msg_wait_for_all_events(method_event, 1, 2000) != WAIT_TIMEOUT, "Wait for method_event(s) timed out.\n"); + if (wait_for_clientside_callbacks(2000)) trace("Kept getting callbacks up until timeout\n"); + + set_provider_method_event_data(&Provider2, NULL, -1); + check_uia_hwnd_expects_at_most(0, 1, 1, 2, 0); + CHECK_CALLED_AT_MOST(child_winproc_GETOBJECT_UiaRoot, 3); + test_provider_event_advise_added(&Provider2, UIA_AutomationFocusChangedEventId, FALSE); + test_provider_event_advise_added(&Provider_hwnd3, 0, FALSE); + test_provider_event_advise_added(&Provider_nc3, 0, FALSE); + set_uia_hwnd_expects(0, 1, 1, 0, 0); hr = IUIAutomation_RemoveFocusChangedEventHandler(uia_iface, &FocusChangedHandler.IUIAutomationFocusChangedEventHandler_iface); diff --git a/dlls/uiautomationcore/uia_com_client.c b/dlls/uiautomationcore/uia_com_client.c index 22b55dd5234..91013dfc4ed 100644 --- a/dlls/uiautomationcore/uia_com_client.c +++ b/dlls/uiautomationcore/uia_com_client.c @@ -1108,6 +1108,38 @@ HRESULT uia_com_win_event_callback(DWORD event_id, HWND hwnd, LONG obj_id, LONG break; } + case EVENT_OBJECT_DESTROY: + { + static const int uia_event_id = UIA_AutomationFocusChangedEventId; + struct rb_entry *rb_entry; + + if (obj_id != OBJID_WINDOW) + break; + + EnterCriticalSection(&com_event_handlers_cs); + + if ((rb_entry = rb_get(&com_event_handlers.handler_event_id_map, &uia_event_id))) + { + struct uia_event_handler_event_id_map_entry *event_id_map; + struct uia_event_handler_map_entry *entry; + + event_id_map = RB_ENTRY_VALUE(rb_entry, struct uia_event_handler_event_id_map_entry, entry); + LIST_FOR_EACH_ENTRY(entry, &event_id_map->handlers_list, struct uia_event_handler_map_entry, + handler_event_id_map_list_entry) + { + struct uia_com_event *event; + + LIST_FOR_EACH_ENTRY(event, &entry->handlers_list, struct uia_com_event, event_handler_map_list_entry) + { + uia_hwnd_map_remove_hwnd(&event->focus_hwnd_map, hwnd); + } + } + } + + LeaveCriticalSection(&com_event_handlers_cs); + break; + } + default: break; } diff --git a/dlls/uiautomationcore/uia_event.c b/dlls/uiautomationcore/uia_event.c index 0e6cf4e000a..2cb61a2062e 100644 --- a/dlls/uiautomationcore/uia_event.c +++ b/dlls/uiautomationcore/uia_event.c @@ -56,6 +56,7 @@ static int win_event_to_uia_event_id(int win_event) case EVENT_OBJECT_FOCUS: return UIA_AutomationFocusChangedEventId; case EVENT_SYSTEM_ALERT: return UIA_SystemAlertEventId; case EVENT_OBJECT_SHOW: return UIA_StructureChangedEventId; + case EVENT_OBJECT_DESTROY: return UIA_StructureChangedEventId; default: break; diff --git a/dlls/uiautomationcore/uia_private.h b/dlls/uiautomationcore/uia_private.h index 0c4f1ee9dda..b55379b459d 100644 --- a/dlls/uiautomationcore/uia_private.h +++ b/dlls/uiautomationcore/uia_private.h @@ -270,5 +270,6 @@ BOOL uia_hwnd_is_visible(HWND hwnd) DECLSPEC_HIDDEN; BOOL uia_is_top_level_hwnd(HWND hwnd) DECLSPEC_HIDDEN; BOOL uia_hwnd_map_check_hwnd(struct rb_tree *hwnd_map, HWND hwnd) DECLSPEC_HIDDEN; HRESULT uia_hwnd_map_add_hwnd(struct rb_tree *hwnd_map, HWND hwnd) DECLSPEC_HIDDEN; +void uia_hwnd_map_remove_hwnd(struct rb_tree *hwnd_map, HWND hwnd) DECLSPEC_HIDDEN; void uia_hwnd_map_init(struct rb_tree *hwnd_map) DECLSPEC_HIDDEN; void uia_hwnd_map_destroy(struct rb_tree *hwnd_map) DECLSPEC_HIDDEN; diff --git a/dlls/uiautomationcore/uia_utils.c b/dlls/uiautomationcore/uia_utils.c index 866358f97c8..f62f85d5883 100644 --- a/dlls/uiautomationcore/uia_utils.c +++ b/dlls/uiautomationcore/uia_utils.c @@ -459,6 +459,23 @@ HRESULT uia_hwnd_map_add_hwnd(struct rb_tree *hwnd_map, HWND hwnd) return S_OK; } +void uia_hwnd_map_remove_hwnd(struct rb_tree *hwnd_map, HWND hwnd) +{ + struct rb_entry *rb_entry = rb_get(hwnd_map, hwnd); + struct uia_hwnd_map_entry *entry; + + if (!rb_entry) + { + TRACE("hwnd %p not in map %p, nothing to remove.\n", hwnd, hwnd_map); + return; + } + + TRACE("Removing hwnd %p from map %p\n", hwnd, hwnd_map); + entry = RB_ENTRY_VALUE(rb_entry, struct uia_hwnd_map_entry, entry); + rb_remove(hwnd_map, &entry->entry); + free(entry); +} + void uia_hwnd_map_init(struct rb_tree *hwnd_map) { rb_init(hwnd_map, uia_hwnd_map_hwnd_compare);

1 0

Alex Henrie : uninstaller: Don't overallocate in FetchFromRootKey.
by Alexandre Julliard 10 Oct '23

10 Oct '23

Module: wine Branch: master Commit: 8943fcbca4963ac6740a5c6e13d5fc9b7748cad2 URL: https://gitlab.winehq.org/wine/wine/-/commit/8943fcbca4963ac6740a5c6e13d5fc… Author: Alex Henrie <alexhenrie24(a)gmail.com> Date: Sat Sep 9 12:06:36 2023 -0600 uninstaller: Don't overallocate in FetchFromRootKey. --- programs/uninstaller/main.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/programs/uninstaller/main.c b/programs/uninstaller/main.c index 027937ba255..15f63976838 100644 --- a/programs/uninstaller/main.c +++ b/programs/uninstaller/main.c @@ -258,7 +258,7 @@ static int FetchFromRootKey(HKEY root) type == REG_DWORD && value == 1) { command = HeapAlloc(GetProcessHeap(), 0, - (lstrlenW(L"msiexec /x%s") + lstrlenW(subKeyName)) * sizeof(WCHAR)); + sizeof(L"msiexec /x") + wcslen(subKeyName) * sizeof(WCHAR)); wsprintfW(command, L"msiexec /x%s", subKeyName); } else if (!RegQueryValueExW(hkeyApp, L"UninstallString", NULL, NULL, NULL, &uninstlen))

1 0

Helix Graziani : winecfg: Change system theme alongside app theme.
by Alexandre Julliard 10 Oct '23

10 Oct '23

1 0

Helix Graziani : uxtheme: Add ShouldSystemUseDarkMode.
by Alexandre Julliard 10 Oct '23

10 Oct '23

Module: wine Branch: master Commit: 91e54e5f6d33ff17ce6ab904fbdcdeb6497de8cb URL: https://gitlab.winehq.org/wine/wine/-/commit/91e54e5f6d33ff17ce6ab904fbdcde… Author: Helix Graziani <helix.graziani(a)hotmail.com> Date: Tue Sep 26 20:03:44 2023 -0400 uxtheme: Add ShouldSystemUseDarkMode. --- dlls/uxtheme/system.c | 17 +++++++++++++++++ dlls/uxtheme/tests/system.c | 33 +++++++++++++++++++++++++++++++++ dlls/uxtheme/uxtheme.spec | 1 + 3 files changed, 51 insertions(+) diff --git a/dlls/uxtheme/system.c b/dlls/uxtheme/system.c index 25f495d29f3..156051406e3 100644 --- a/dlls/uxtheme/system.c +++ b/dlls/uxtheme/system.c @@ -1256,3 +1256,20 @@ BOOL WINAPI ThemeHooksRemove(void) UnregisterUserApiHook(); return TRUE; } + +/********************************************************************** + * ShouldSystemUseDarkMode (UXTHEME.138) + * + * RETURNS + * Whether or not the system should use dark mode. + */ +BOOL WINAPI ShouldSystemUseDarkMode(void) +{ + DWORD light_theme = TRUE, light_theme_size = sizeof(light_theme); + + RegGetValueW(HKEY_CURRENT_USER, + L"Software\\Microsoft\\Windows\\CurrentVersion\\Themes\\Personalize", + L"SystemUsesLightTheme", RRF_RT_REG_DWORD, NULL, &light_theme, &light_theme_size); + + return !light_theme; +} diff --git a/dlls/uxtheme/tests/system.c b/dlls/uxtheme/tests/system.c index 2e769625dab..390baece969 100644 --- a/dlls/uxtheme/tests/system.c +++ b/dlls/uxtheme/tests/system.c @@ -48,6 +48,7 @@ static HDC (WINAPI *pGetBufferedPaintTargetDC)(HPAINTBUFFER); static HRESULT (WINAPI *pGetBufferedPaintTargetRect)(HPAINTBUFFER, RECT *); static HRESULT (WINAPI *pGetThemeIntList)(HTHEME, int, int, int, INTLIST *); static HRESULT (WINAPI *pGetThemeTransitionDuration)(HTHEME, int, int, int, int, DWORD *); +static BOOL (WINAPI *pShouldSystemUseDarkMode)(void); static LONG (WINAPI *pDisplayConfigGetDeviceInfo)(DISPLAYCONFIG_DEVICE_INFO_HEADER *); static LONG (WINAPI *pDisplayConfigSetDeviceInfo)(DISPLAYCONFIG_DEVICE_INFO_HEADER *); @@ -74,6 +75,8 @@ static void init_funcs(void) HMODULE gdi32 = GetModuleHandleA("gdi32.dll"); HMODULE uxtheme = GetModuleHandleA("uxtheme.dll"); + pShouldSystemUseDarkMode = (void *)GetProcAddress(uxtheme, MAKEINTRESOURCEA(138)); + #define GET_PROC(module, func) \ p##func = (void *)GetProcAddress(module, #func); \ if (!p##func) \ @@ -2597,6 +2600,35 @@ static void test_theme(void) DestroyWindow(hwnd); } +static void test_ShouldSystemUseDarkMode(void) +{ + DWORD light_theme, light_theme_size = sizeof(light_theme), last_error; + BOOL result; + LSTATUS ls; + + if (!pShouldSystemUseDarkMode) + { + win_skip("ShouldSystemUseDarkMode() is unavailable.\n"); + return; + } + + ls = RegGetValueW(HKEY_CURRENT_USER, + L"Software\\Microsoft\\Windows\\CurrentVersion\\Themes\\Personalize", + L"SystemUsesLightTheme", RRF_RT_REG_DWORD, NULL, &light_theme, &light_theme_size); + if (ls == ERROR_FILE_NOT_FOUND) + { + light_theme = 1; + ls = 0; + } + ok(ls == 0, "RegGetValue failed: %ld.\n", ls); + + SetLastError(0xdeadbeef); + result = pShouldSystemUseDarkMode(); + last_error = GetLastError(); + ok(last_error == 0xdeadbeef, "ShouldSystemUseDarkMode set last error: %ld.\n", last_error); + ok(result == !light_theme, "Expected value %d, got %d.\n", !light_theme, result); +} + START_TEST(system) { ULONG_PTR ctx_cookie; @@ -2622,6 +2654,7 @@ START_TEST(system) test_DrawThemeBackgroundEx(); test_GetThemeBackgroundRegion(); test_theme(); + test_ShouldSystemUseDarkMode(); if (load_v6_module(&ctx_cookie, &ctx)) { diff --git a/dlls/uxtheme/uxtheme.spec b/dlls/uxtheme/uxtheme.spec index c60254b677d..a5bfb88c49a 100644 --- a/dlls/uxtheme/uxtheme.spec +++ b/dlls/uxtheme/uxtheme.spec @@ -42,6 +42,7 @@ 61 stdcall OpenThemeDataEx(ptr wstr long) 62 stub -noname ServerClearStockObjects 63 stub -noname MarkSelection +138 stdcall -noname ShouldSystemUseDarkMode() # Standard functions @ stdcall BeginBufferedAnimation(ptr ptr ptr long ptr ptr ptr ptr)

1 0

Alexandre Julliard : ws2_32: Make htonl/htons/ntohl/ntohs proper functions.
by Alexandre Julliard 10 Oct '23

10 Oct '23

Module: wine Branch: master Commit: 6b4399e3694e27a703c5b7f7740dc6644a4fb5b0 URL: https://gitlab.winehq.org/wine/wine/-/commit/6b4399e3694e27a703c5b7f7740dc6… Author: Alexandre Julliard <julliard(a)winehq.org> Date: Tue Oct 10 11:05:28 2023 +0200 ws2_32: Make htonl/htons/ntohl/ntohs proper functions. --- dlls/inetmib1/Makefile.in | 2 +- dlls/iphlpapi/Makefile.in | 2 +- dlls/iphlpapi/tests/Makefile.in | 2 +- dlls/ntdll/rtl.c | 3 +++ dlls/ntoskrnl.exe/tests/driver_netio.c | 15 +++++++---- dlls/ws2_32/protocol.c | 16 ++++++------ dlls/ws2_32/ws2_32.spec | 8 +++--- include/winsock.h | 46 +++------------------------------- include/winsock2.h | 44 +++----------------------------- libs/ldap/libldap/sasl_w.c | 1 + 10 files changed, 37 insertions(+), 102 deletions(-)

1 0

Alexandre Julliard : include: Stop pretending to support big-endian.
by Alexandre Julliard 10 Oct '23

10 Oct '23

Module: wine Branch: master Commit: 3bb752736c4743754a6203293dcb62b52a1757c5 URL: https://gitlab.winehq.org/wine/wine/-/commit/3bb752736c4743754a6203293dcb62… Author: Alexandre Julliard <julliard(a)winehq.org> Date: Tue Oct 10 11:11:26 2023 +0200 include: Stop pretending to support big-endian. --- include/basetsd.h | 32 -------------------------------- include/mapidefs.h | 10 ---------- include/winbase.h | 15 --------------- include/windef.h | 10 ---------- include/winnt.h | 28 ++-------------------------- include/winternl.h | 5 ----- include/winuser.h | 6 ------ include/wtypes.idl | 10 ---------- 8 files changed, 2 insertions(+), 114 deletions(-) diff --git a/include/basetsd.h b/include/basetsd.h index 55e900d4f8e..c16d55422bb 100644 --- a/include/basetsd.h +++ b/include/basetsd.h @@ -295,38 +295,6 @@ typedef ULONG_PTR KAFFINITY, *PKAFFINITY; #define MINLONGLONG ((LONGLONG)~MAXLONGLONG) -/* Some Wine-specific definitions */ - -/* Architecture dependent settings. */ -/* These are hardcoded to avoid dependencies on config.h in Winelib apps. */ -#if defined(__i386__) -# undef WORDS_BIGENDIAN -#elif defined(__x86_64__) -# undef WORDS_BIGENDIAN -#elif defined(__powerpc64__) && defined(__BIG_ENDIAN__) -# define WORDS_BIGENDIAN -#elif defined(__powerpc64__) -# undef WORDS_BIGENDIAN -#elif defined(__powerpc__) -# define WORDS_BIGENDIAN -#elif defined(__ALPHA__) -# undef WORDS_BIGENDIAN -#elif defined(__ARMEB__) -# define WORDS_BIGENDIAN -#elif defined(__ARMEL__) || defined(__arm__) -# undef WORDS_BIGENDIAN -#elif defined(__AARCH64EB__) -# define WORDS_BIGENDIAN -#elif defined(__AARCH64EL__) || defined(__aarch64__) -# undef WORDS_BIGENDIAN -#elif defined(__MIPSEB__) -# define WORDS_BIGENDIAN -#elif defined(__MIPSEL__) -# undef WORDS_BIGENDIAN -#elif !defined(RC_INVOKED) && !defined(__WIDL__) && !defined(__midl) -# error Unknown CPU architecture! -#endif - #ifdef __cplusplus } /* extern "C" */ #endif /* defined(__cplusplus) */ diff --git a/include/mapidefs.h b/include/mapidefs.h index 84e0f2d7447..e3e2bd40b5f 100644 --- a/include/mapidefs.h +++ b/include/mapidefs.h @@ -37,13 +37,8 @@ typedef union tagCY { struct { -#ifdef WORDS_BIGENDIAN - LONG Hi; - ULONG Lo; -#else ULONG Lo; LONG Hi; -#endif } DUMMYSTRUCTNAME; LONGLONG int64; } CY; @@ -55,13 +50,8 @@ typedef CY CURRENCY; #define _FILETIME_ typedef struct _FILETIME { -#ifdef WORDS_BIGENDIAN - DWORD dwHighDateTime; - DWORD dwLowDateTime; -#else DWORD dwLowDateTime; DWORD dwHighDateTime; -#endif } FILETIME, *PFILETIME, *LPFILETIME; #endif diff --git a/include/winbase.h b/include/winbase.h index 4429fac21c7..5f005fcd82b 100644 --- a/include/winbase.h +++ b/include/winbase.h @@ -252,13 +252,8 @@ typedef struct _SECURITY_ATTRIBUTES /* 64 bit number of 100 nanoseconds intervals since January 1, 1601 */ typedef struct _FILETIME { -#ifdef WORDS_BIGENDIAN - DWORD dwHighDateTime; - DWORD dwLowDateTime; -#else DWORD dwLowDateTime; DWORD dwHighDateTime; -#endif } FILETIME, *PFILETIME, *LPFILETIME; #endif /* _FILETIME_ */ @@ -556,22 +551,12 @@ typedef struct _SYSTEMTIME{ /* The 'overlapped' data structure used by async I/O functions. */ typedef struct _OVERLAPPED { -#ifdef WORDS_BIGENDIAN - ULONG_PTR InternalHigh; - ULONG_PTR Internal; -#else ULONG_PTR Internal; ULONG_PTR InternalHigh; -#endif union { struct { -#ifdef WORDS_BIGENDIAN - DWORD OffsetHigh; - DWORD Offset; -#else DWORD Offset; DWORD OffsetHigh; -#endif } DUMMYSTRUCTNAME; PVOID Pointer; } DUMMYUNIONNAME; diff --git a/include/windef.h b/include/windef.h index cce3dbb36f4..b22e15c4dbf 100644 --- a/include/windef.h +++ b/include/windef.h @@ -390,23 +390,13 @@ typedef struct _POINTL typedef struct tagPOINTS { -#ifdef WORDS_BIGENDIAN - SHORT y; - SHORT x; -#else SHORT x; SHORT y; -#endif } POINTS, *PPOINTS, *LPPOINTS; typedef struct _FILETIME { -#ifdef WORDS_BIGENDIAN - DWORD dwHighDateTime; - DWORD dwLowDateTime; -#else DWORD dwLowDateTime; DWORD dwHighDateTime; -#endif } FILETIME, *PFILETIME, *LPFILETIME; #define _FILETIME_ diff --git a/include/winnt.h b/include/winnt.h index d8690d313ba..6ff508215dd 100644 --- a/include/winnt.h +++ b/include/winnt.h @@ -4788,49 +4788,25 @@ typedef struct _TOKEN_GROUPS { typedef union _LARGE_INTEGER { struct { -#ifdef WORDS_BIGENDIAN - LONG HighPart; - DWORD LowPart; -#else DWORD LowPart; LONG HighPart; -#endif } u; -#ifndef NONAMELESSSTRUCT struct { -#ifdef WORDS_BIGENDIAN - LONG HighPart; - DWORD LowPart; -#else DWORD LowPart; LONG HighPart; -#endif - }; -#endif + } DUMMYSTRUCTNAME; LONGLONG QuadPart; } LARGE_INTEGER, *PLARGE_INTEGER; typedef union _ULARGE_INTEGER { struct { -#ifdef WORDS_BIGENDIAN - DWORD HighPart; - DWORD LowPart; -#else DWORD LowPart; DWORD HighPart; -#endif } u; -#ifndef NONAMELESSSTRUCT struct { -#ifdef WORDS_BIGENDIAN - DWORD HighPart; - DWORD LowPart; -#else DWORD LowPart; DWORD HighPart; -#endif - }; -#endif + } DUMMYSTRUCTNAME; ULONGLONG QuadPart; } ULARGE_INTEGER, *PULARGE_INTEGER; diff --git a/include/winternl.h b/include/winternl.h index d50bc730660..40d4ca4716a 100644 --- a/include/winternl.h +++ b/include/winternl.h @@ -76,13 +76,8 @@ typedef const UNICODE_STRING *PCUNICODE_STRING; /* 64 bit number of 100 nanoseconds intervals since January 1, 1601 */ typedef struct _FILETIME { -#ifdef WORDS_BIGENDIAN - DWORD dwHighDateTime; - DWORD dwLowDateTime; -#else DWORD dwLowDateTime; DWORD dwHighDateTime; -#endif } FILETIME, *PFILETIME, *LPFILETIME; #endif /* _FILETIME_ */ diff --git a/include/winuser.h b/include/winuser.h index 4ed29e86616..c0736502a2e 100644 --- a/include/winuser.h +++ b/include/winuser.h @@ -1625,15 +1625,9 @@ typedef struct tagCURSORINFO /* this is the 6 byte accel struct used in Win32 when presented to the user */ typedef struct tagACCEL { -#ifdef WORDS_BIGENDIAN - WORD fVirt; - WORD key; - DWORD cmd; -#else BYTE fVirt; WORD key; WORD cmd; -#endif } ACCEL, *LPACCEL; diff --git a/include/wtypes.idl b/include/wtypes.idl index d08148dc840..77a9f1c761a 100644 --- a/include/wtypes.idl +++ b/include/wtypes.idl @@ -646,13 +646,8 @@ cpp_quote("#ifndef _tagCY_DEFINED") cpp_quote("#define _tagCY_DEFINED") cpp_quote("typedef union tagCY {") cpp_quote(" struct {") -cpp_quote("#ifdef WORDS_BIGENDIAN") -cpp_quote(" LONG Hi;") -cpp_quote(" ULONG Lo;") -cpp_quote("#else") cpp_quote(" ULONG Lo;") cpp_quote(" LONG Hi;") -cpp_quote("#endif") cpp_quote(" } DUMMYSTRUCTNAME;") cpp_quote(" LONGLONG int64;") cpp_quote("} CY;") @@ -682,13 +677,8 @@ cpp_quote(" } DUMMYUNIONNAME;") cpp_quote(" ULONG Hi32;") cpp_quote(" union {") cpp_quote(" struct {") -cpp_quote("#ifdef WORDS_BIGENDIAN") -cpp_quote(" ULONG Mid32;") -cpp_quote(" ULONG Lo32;") -cpp_quote("#else") cpp_quote(" ULONG Lo32;") cpp_quote(" ULONG Mid32;") -cpp_quote("#endif") cpp_quote(" } DUMMYSTRUCTNAME1;") cpp_quote(" ULONGLONG Lo64;") cpp_quote(" } DUMMYUNIONNAME1;")

1 0

Alexandre Julliard : winebuild: Add a helper to output an asm function header.
by Alexandre Julliard 10 Oct '23

10 Oct '23

Module: wine Branch: master Commit: 945883438a31eda151bf19484619eb1a2d3cf63a URL: https://gitlab.winehq.org/wine/wine/-/commit/945883438a31eda151bf19484619eb… Author: Alexandre Julliard <julliard(a)winehq.org> Date: Tue Oct 10 20:46:40 2023 +0200 winebuild: Add a helper to output an asm function header. --- tools/winebuild/build.h | 2 +- tools/winebuild/import.c | 47 ++++++++++------------------------------------- tools/winebuild/relay.c | 18 +++++------------- tools/winebuild/spec16.c | 4 +--- tools/winebuild/utils.c | 28 ++++++++++++++++------------ 5 files changed, 33 insertions(+), 66 deletions(-)

1 0

Mohamad Al-Jaf : include: Add windows.security.credentials.ui.idl file.
by Alexandre Julliard 10 Oct '23

10 Oct '23

Module: wine Branch: master Commit: 5ff9ffb3684c8b7b42dceff446dfa2e50e3b8c67 URL: https://gitlab.winehq.org/wine/wine/-/commit/5ff9ffb3684c8b7b42dceff446dfa2… Author: Mohamad Al-Jaf <mohamadaljaf(a)gmail.com> Date: Sun Oct 8 00:38:52 2023 -0400 include: Add windows.security.credentials.ui.idl file. --- include/Makefile.in | 1 + include/windows.security.credentials.ui.idl | 91 +++++++++++++++++++++++++++++ 2 files changed, 92 insertions(+) diff --git a/include/Makefile.in b/include/Makefile.in index 5f61344324d..ef0c48ed9ef 100644 --- a/include/Makefile.in +++ b/include/Makefile.in @@ -855,6 +855,7 @@ SOURCES = \ windows.perception.spatial.idl \ windows.perception.spatial.surfaces.idl \ windows.security.credentials.idl \ + windows.security.credentials.ui.idl \ windows.security.cryptography.idl \ windows.security.isolation.idl \ windows.storage.fileproperties.idl \ diff --git a/include/windows.security.credentials.ui.idl b/include/windows.security.credentials.ui.idl new file mode 100644 index 00000000000..3457ea1ec33 --- /dev/null +++ b/include/windows.security.credentials.ui.idl @@ -0,0 +1,91 @@ +/* + * Copyright (C) 2023 Mohamad Al-Jaf + * + * This library is free software; you can redistribute it and/or + * modify it under the terms of the GNU Lesser General Public + * License as published by the Free Software Foundation; either + * version 2.1 of the License, or (at your option) any later version. + * + * This library is distributed in the hope that it will be useful, + * but WITHOUT ANY WARRANTY; without even the implied warranty of + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU + * Lesser General Public License for more details. + * + * You should have received a copy of the GNU Lesser General Public + * License along with this library; if not, write to the Free Software + * Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301, USA + */ + +#ifdef __WIDL__ +#pragma winrt ns_prefix +#endif + +import "inspectable.idl"; +import "asyncinfo.idl"; +import "eventtoken.idl"; +import "windowscontracts.idl"; +import "windows.foundation.idl"; +import "windows.storage.streams.idl"; + +namespace Windows.Security.Credentials.UI { + typedef enum UserConsentVerificationResult UserConsentVerificationResult; + typedef enum UserConsentVerifierAvailability UserConsentVerifierAvailability; + + interface IUserConsentVerifierStatics; + + runtimeclass UserConsentVerifier; + + declare { + interface Windows.Foundation.AsyncOperationCompletedHandler<Windows.Security.Credentials.UI.UserConsentVerificationResult>; + interface Windows.Foundation.AsyncOperationCompletedHandler<Windows.Security.Credentials.UI.UserConsentVerifierAvailability>; + interface Windows.Foundation.IAsyncOperation<Windows.Security.Credentials.UI.UserConsentVerificationResult>; + interface Windows.Foundation.IAsyncOperation<Windows.Security.Credentials.UI.UserConsentVerifierAvailability>; + } + + [ + contract(Windows.Foundation.UniversalApiContract, 1.0) + ] + enum UserConsentVerificationResult + { + Verified = 0, + DeviceNotPresent = 1, + NotConfiguredForUser = 2, + DisabledByPolicy = 3, + DeviceBusy = 4, + RetriesExhausted = 5, + Canceled = 6, + }; + + [ + contract(Windows.Foundation.UniversalApiContract, 1.0) + ] + enum UserConsentVerifierAvailability + { + Available = 0, + DeviceNotPresent = 1, + NotConfiguredForUser = 2, + DisabledByPolicy = 3, + DeviceBusy = 4, + }; + + [ + contract(Windows.Foundation.UniversalApiContract, 1.0), + exclusiveto(Windows.Security.Credentials.UI.UserConsentVerifier), + uuid(af4f3f91-564c-4ddc-b8b5-973447627c65) + ] + interface IUserConsentVerifierStatics : IInspectable + { + HRESULT CheckAvailabilityAsync([out, retval] Windows.Foundation.IAsyncOperation<Windows.Security.Credentials.UI.UserConsentVerifierAvailability> **result); + HRESULT RequestVerificationAsync([in] HSTRING message, [out, retval] Windows.Foundation.IAsyncOperation<Windows.Security.Credentials.UI.UserConsentVerificationResult> **result); + } + + [ + contract(Windows.Foundation.UniversalApiContract, 1.0), + marshaling_behavior(agile), + static(Windows.Security.Credentials.UI.IUserConsentVerifierStatics, Windows.Foundation.UniversalApiContract, 1.0), + threading(both) + ] + runtimeclass UserConsentVerifier + { + } +}

1 0

Mohamad Al-Jaf : windows.security.credentials.ui.userconsentverifier: Add stub DLL.
by Alexandre Julliard 10 Oct '23

10 Oct '23

Module: wine Branch: master Commit: d7b7114dd958adb3feea79eb86d29e1b8546f3b7 URL: https://gitlab.winehq.org/wine/wine/-/commit/d7b7114dd958adb3feea79eb86d29e… Author: Mohamad Al-Jaf <mohamadaljaf(a)gmail.com> Date: Sun Oct 8 00:39:01 2023 -0400 windows.security.credentials.ui.userconsentverifier: Add stub DLL. --- configure | 3 + configure.ac | 2 + .../Makefile.in | 8 ++ .../classes.idl | 23 ++++ .../main.c | 138 +++++++++++++++++++++ .../private.h | 38 ++++++ .../tests/Makefile.in | 5 + .../tests/verifier.c | 85 +++++++++++++ ...ecurity.credentials.ui.userconsentverifier.spec | 3 + 9 files changed, 305 insertions(+)

1 0