February 2023 - Wine-commits

Hans Leidekker : winscard: Implement SCardListReaderGroupsA/W().
by Alexandre Julliard 22 Feb '23

22 Feb '23

Module: wine Branch: master Commit: abb7f7500235db362376634256490fbdd391cd00 URL: https://gitlab.winehq.org/wine/wine/-/commit/abb7f7500235db362376634256490f… Author: Hans Leidekker <hans(a)codeweavers.com> Date: Thu Feb 16 12:13:48 2023 +0100 winscard: Implement SCardListReaderGroupsA/W(). --- dlls/winscard/unixlib.c | 8 ++++++ dlls/winscard/unixlib.h | 8 ++++++ dlls/winscard/winscard.c | 69 +++++++++++++++++++++++++++++++++++++++++++++ dlls/winscard/winscard.spec | 4 +-- 4 files changed, 87 insertions(+), 2 deletions(-) diff --git a/dlls/winscard/unixlib.c b/dlls/winscard/unixlib.c index 61f179b2eb9..aa223382514 100644 --- a/dlls/winscard/unixlib.c +++ b/dlls/winscard/unixlib.c @@ -37,6 +37,7 @@ LONG SCardIsValidContext( UINT64 ); LONG SCardGetStatusChange( UINT64, UINT64, struct reader_state *, UINT64 ); LONG SCardCancel( UINT64 ); LONG SCardListReaders( UINT64, const char *, char *, UINT64 * ); +LONG SCardListReaderGroups( UINT64, char *, UINT64 * ); static NTSTATUS scard_establish_context( void *args ) { @@ -74,6 +75,12 @@ static NTSTATUS scard_list_readers( void *args ) return SCardListReaders( params->handle, params->groups, params->readers, params->readers_len ); } +static NTSTATUS scard_list_reader_groups( void *args ) +{ + struct scard_list_reader_groups_params *params = args; + return SCardListReaderGroups( params->handle, params->groups, params->groups_len ); +} + const unixlib_entry_t __wine_unix_call_funcs[] = { scard_establish_context, @@ -82,4 +89,5 @@ const unixlib_entry_t __wine_unix_call_funcs[] = scard_get_status_change, scard_cancel, scard_list_readers, + scard_list_reader_groups, }; diff --git a/dlls/winscard/unixlib.h b/dlls/winscard/unixlib.h index 1be9fe7cf77..05514d3f68b 100644 --- a/dlls/winscard/unixlib.h +++ b/dlls/winscard/unixlib.h @@ -67,6 +67,13 @@ struct scard_list_readers_params UINT64 *readers_len; }; +struct scard_list_reader_groups_params +{ + UINT64 handle; + char *groups; + UINT64 *groups_len; +}; + enum winscard_funcs { unix_scard_establish_context, @@ -75,4 +82,5 @@ enum winscard_funcs unix_scard_get_status_change, unix_scard_cancel, unix_scard_list_readers, + unix_scard_list_reader_groups, }; diff --git a/dlls/winscard/winscard.c b/dlls/winscard/winscard.c index a242de9ccce..92c621baed0 100644 --- a/dlls/winscard/winscard.c +++ b/dlls/winscard/winscard.c @@ -369,6 +369,75 @@ LONG WINAPI SCardCancel( SCARDCONTEXT context ) return ret; } +LONG WINAPI SCardListReaderGroupsA( SCARDCONTEXT context, char *groups, DWORD *groups_len ) +{ + struct handle *handle = (struct handle *)context; + struct scard_list_reader_groups_params params; + UINT64 groups_len_utf8; + LONG ret; + + TRACE( "%Ix, %p, %p\n", context, groups, groups_len ); + + if (!handle || handle->magic != CONTEXT_MAGIC) return ERROR_INVALID_HANDLE; + if (!groups_len) return SCARD_E_INVALID_PARAMETER; + if (*groups_len == SCARD_AUTOALLOCATE) + { + FIXME( "SCARD_AUTOALLOCATE not supported\n" ); + return SCARD_F_INTERNAL_ERROR; + } + + params.handle = handle->unix_handle; + params.groups = NULL; + params.groups_len = &groups_len_utf8; + if ((ret = UNIX_CALL( scard_list_reader_groups, &params ))) goto done; + + params.handle = handle->unix_handle; + if (!(params.groups = malloc( groups_len_utf8 ))) return SCARD_E_NO_MEMORY; + if (!(ret = UNIX_CALL( scard_list_reader_groups, &params ))) + { + ret = copy_multiszA( params.groups, groups, groups_len ); + } + +done: + free( params.groups ); + TRACE( "returning %#lx\n", ret ); + return ret; +} + +LONG WINAPI SCardListReaderGroupsW( SCARDCONTEXT context, WCHAR *groups, DWORD *groups_len ) +{ + struct handle *handle = (struct handle *)context; + struct scard_list_reader_groups_params params; + UINT64 groups_len_utf8; + LONG ret; + + TRACE( "%Ix, %p, %p\n", context, groups, groups_len ); + + if (!handle || handle->magic != CONTEXT_MAGIC) return ERROR_INVALID_HANDLE; + if (!groups_len) return SCARD_E_INVALID_PARAMETER; + if (*groups_len == SCARD_AUTOALLOCATE) + { + FIXME( "SCARD_AUTOALLOCATE not supported\n" ); + return SCARD_F_INTERNAL_ERROR; + } + + params.handle = handle->unix_handle; + params.groups = NULL; + params.groups_len = &groups_len_utf8; + if ((ret = UNIX_CALL( scard_list_reader_groups, &params ))) goto done; + + if (!(params.groups = malloc( groups_len_utf8 ))) return SCARD_E_NO_MEMORY; + if (!(ret = UNIX_CALL( scard_list_reader_groups, &params ))) + { + ret = copy_multiszW( params.groups, groups, groups_len ); + } + +done: + TRACE( "returning %#lx\n", ret ); + free( params.groups ); + return ret; +} + static LONG map_states_inA( const SCARD_READERSTATEA *src, struct reader_state *dst, DWORD count ) { DWORD i; diff --git a/dlls/winscard/winscard.spec b/dlls/winscard/winscard.spec index ff320bae424..6eb70ffa325 100644 --- a/dlls/winscard/winscard.spec +++ b/dlls/winscard/winscard.spec @@ -38,8 +38,8 @@ @ stub SCardListCardsW @ stub SCardListInterfacesA @ stub SCardListInterfacesW -@ stub SCardListReaderGroupsA -@ stub SCardListReaderGroupsW +@ stdcall SCardListReaderGroupsA(long ptr ptr) +@ stdcall SCardListReaderGroupsW(long ptr ptr) @ stdcall SCardListReadersA(long str ptr ptr) @ stdcall SCardListReadersW(long wstr ptr ptr) @ stub SCardLocateCardsA

1 0

Hans Leidekker : winscard: Implement SCardConnectA/W().
by Alexandre Julliard 22 Feb '23

22 Feb '23

Module: wine Branch: master Commit: fd3ce00a220927863def999fd1ab2039d4b964cb URL: https://gitlab.winehq.org/wine/wine/-/commit/fd3ce00a220927863def999fd1ab20… Author: Hans Leidekker <hans(a)codeweavers.com> Date: Thu Feb 16 12:26:52 2023 +0100 winscard: Implement SCardConnectA/W(). --- dlls/winscard/unixlib.c | 9 +++++ dlls/winscard/unixlib.h | 11 ++++++ dlls/winscard/winscard.c | 85 +++++++++++++++++++++++++++++++++++++++++++++ dlls/winscard/winscard.spec | 4 +-- 4 files changed, 107 insertions(+), 2 deletions(-) diff --git a/dlls/winscard/unixlib.c b/dlls/winscard/unixlib.c index aa223382514..df852548805 100644 --- a/dlls/winscard/unixlib.c +++ b/dlls/winscard/unixlib.c @@ -38,6 +38,7 @@ LONG SCardGetStatusChange( UINT64, UINT64, struct reader_state *, UINT64 ); LONG SCardCancel( UINT64 ); LONG SCardListReaders( UINT64, const char *, char *, UINT64 * ); LONG SCardListReaderGroups( UINT64, char *, UINT64 * ); +LONG SCardConnect( UINT64, const char *, UINT64, UINT64, UINT64 *, UINT64 * ); static NTSTATUS scard_establish_context( void *args ) { @@ -81,6 +82,13 @@ static NTSTATUS scard_list_reader_groups( void *args ) return SCardListReaderGroups( params->handle, params->groups, params->groups_len ); } +static NTSTATUS scard_connect( void *args ) +{ + struct scard_connect_params *params = args; + return SCardConnect( params->context_handle, params->reader, params->share_mode, params->preferred_protocols, + params->connect_handle, params->protocol ); +} + const unixlib_entry_t __wine_unix_call_funcs[] = { scard_establish_context, @@ -90,4 +98,5 @@ const unixlib_entry_t __wine_unix_call_funcs[] = scard_cancel, scard_list_readers, scard_list_reader_groups, + scard_connect, }; diff --git a/dlls/winscard/unixlib.h b/dlls/winscard/unixlib.h index 05514d3f68b..d750c23f07b 100644 --- a/dlls/winscard/unixlib.h +++ b/dlls/winscard/unixlib.h @@ -74,6 +74,16 @@ struct scard_list_reader_groups_params UINT64 *groups_len; }; +struct scard_connect_params +{ + UINT64 context_handle; + const char *reader; + UINT64 share_mode; + UINT64 preferred_protocols; + UINT64 *connect_handle; + UINT64 *protocol; +}; + enum winscard_funcs { unix_scard_establish_context, @@ -83,4 +93,5 @@ enum winscard_funcs unix_scard_cancel, unix_scard_list_readers, unix_scard_list_reader_groups, + unix_scard_connect, }; diff --git a/dlls/winscard/winscard.c b/dlls/winscard/winscard.c index 92c621baed0..aff6012cb83 100644 --- a/dlls/winscard/winscard.c +++ b/dlls/winscard/winscard.c @@ -140,6 +140,7 @@ LONG WINAPI SCardAddReaderToGroupW(SCARDCONTEXT context, LPCWSTR reader, LPCWSTR } #define CONTEXT_MAGIC (('C' << 24) | ('T' << 16) | ('X' << 8) | '0') +#define CONNECT_MAGIC (('C' << 24) | ('O' << 16) | ('N' << 8) | '0') struct handle { DWORD magic; @@ -551,6 +552,90 @@ LONG WINAPI SCardGetStatusChangeW( SCARDCONTEXT context, DWORD timeout, SCARD_RE return ret; } +LONG WINAPI SCardConnectA( SCARDCONTEXT context, const char *reader, DWORD share_mode, DWORD preferred_protocols, + SCARDHANDLE *connect, DWORD *protocol ) +{ + struct handle *context_handle = (struct handle *)context, *connect_handle; + struct scard_connect_params params; + char *reader_utf8; + UINT64 protocol64; + LONG ret; + + TRACE( "%Ix, %s, %#lx, %#lx, %p, %p\n", context, debugstr_a(reader), share_mode, preferred_protocols, connect, + protocol ); + + if (!context_handle || context_handle->magic != CONTEXT_MAGIC) return ERROR_INVALID_HANDLE; + if (!connect) return SCARD_E_INVALID_PARAMETER; + + if (!(connect_handle = malloc( sizeof(*connect_handle) ))) return SCARD_E_NO_MEMORY; + connect_handle->magic = CONNECT_MAGIC; + + if (!(reader_utf8 = ansi_to_utf8( reader ))) + { + free( connect_handle ); + return SCARD_E_NO_MEMORY; + } + + params.context_handle = context_handle->unix_handle; + params.reader = reader_utf8; + params.share_mode = share_mode; + params.preferred_protocols = preferred_protocols; + params.connect_handle = &connect_handle->unix_handle; + params.protocol = &protocol64; + if ((ret = UNIX_CALL( scard_connect, &params ))) free( connect_handle ); + else + { + *connect = (SCARDHANDLE)connect_handle; + if (protocol) *protocol = protocol64; + } + + free( reader_utf8 ); + TRACE( "returning %#lx\n", ret ); + return ret; +} + +LONG WINAPI SCardConnectW( SCARDCONTEXT context, const WCHAR *reader, DWORD share_mode, DWORD preferred_protocols, + SCARDHANDLE *connect, DWORD *protocol ) +{ + struct handle *context_handle = (struct handle *)context, *connect_handle; + struct scard_connect_params params; + char *reader_utf8; + UINT64 protocol64; + LONG ret; + + TRACE( "%Ix, %s, %#lx, %#lx, %p, %p\n", context, debugstr_w(reader), share_mode, preferred_protocols, connect, + protocol ); + + if (!context_handle || context_handle->magic != CONTEXT_MAGIC) return ERROR_INVALID_HANDLE; + if (!connect) return SCARD_E_INVALID_PARAMETER; + + if (!(connect_handle = malloc( sizeof(*connect_handle) ))) return SCARD_E_NO_MEMORY; + connect_handle->magic = CONNECT_MAGIC; + + if (!(reader_utf8 = utf16_to_utf8( reader ))) + { + free( connect_handle ); + return SCARD_E_NO_MEMORY; + } + + params.context_handle = context_handle->unix_handle; + params.reader = reader_utf8; + params.share_mode = share_mode; + params.preferred_protocols = preferred_protocols; + params.connect_handle = &connect_handle->unix_handle; + params.protocol = &protocol64; + if ((ret = UNIX_CALL( scard_connect, &params ))) free( connect_handle ); + else + { + *connect = (SCARDHANDLE)connect_handle; + if (protocol) *protocol = protocol64; + } + + free( reader_utf8 ); + TRACE( "returning %#lx\n", ret ); + return ret; +} + BOOL WINAPI DllMain( HINSTANCE hinst, DWORD reason, void *reserved ) { switch (reason) diff --git a/dlls/winscard/winscard.spec b/dlls/winscard/winscard.spec index 6eb70ffa325..40db017a7d1 100644 --- a/dlls/winscard/winscard.spec +++ b/dlls/winscard/winscard.spec @@ -7,8 +7,8 @@ @ stdcall SCardAddReaderToGroupW(long wstr wstr) @ stub SCardBeginTransaction @ stdcall SCardCancel(long) -@ stub SCardConnectA -@ stub SCardConnectW +@ stdcall SCardConnectA(long str long long ptr ptr) +@ stdcall SCardConnectW(long wstr long long ptr ptr) @ stub SCardControl @ stub SCardDisconnect @ stub SCardEndTransaction

1 0

Hans Leidekker : winscard: Implement SCardStatusA/W().
by Alexandre Julliard 22 Feb '23

22 Feb '23

Module: wine Branch: master Commit: 836974d4d8f506391b76e0d4e10cb4b14bbe56e7 URL: https://gitlab.winehq.org/wine/wine/-/commit/836974d4d8f506391b76e0d4e10cb4… Author: Hans Leidekker <hans(a)codeweavers.com> Date: Thu Feb 16 12:36:13 2023 +0100 winscard: Implement SCardStatusA/W(). --- dlls/winscard/unixlib.c | 9 +++++ dlls/winscard/unixlib.h | 12 +++++++ dlls/winscard/winscard.c | 90 +++++++++++++++++++++++++++++++++++++++++++----- 3 files changed, 103 insertions(+), 8 deletions(-) diff --git a/dlls/winscard/unixlib.c b/dlls/winscard/unixlib.c index df852548805..4f975ef40f9 100644 --- a/dlls/winscard/unixlib.c +++ b/dlls/winscard/unixlib.c @@ -39,6 +39,7 @@ LONG SCardCancel( UINT64 ); LONG SCardListReaders( UINT64, const char *, char *, UINT64 * ); LONG SCardListReaderGroups( UINT64, char *, UINT64 * ); LONG SCardConnect( UINT64, const char *, UINT64, UINT64, UINT64 *, UINT64 * ); +LONG SCardStatus( UINT64, char *, UINT64 *, UINT64 *, UINT64 *, BYTE *, UINT64 * ); static NTSTATUS scard_establish_context( void *args ) { @@ -89,6 +90,13 @@ static NTSTATUS scard_connect( void *args ) params->connect_handle, params->protocol ); } +static NTSTATUS scard_status( void *args ) +{ + struct scard_status_params *params = args; + return SCardStatus( params->handle, params->names, params->names_len, params->state, params->protocol, + params->atr, params->atr_len ); +} + const unixlib_entry_t __wine_unix_call_funcs[] = { scard_establish_context, @@ -99,4 +107,5 @@ const unixlib_entry_t __wine_unix_call_funcs[] = scard_list_readers, scard_list_reader_groups, scard_connect, + scard_status, }; diff --git a/dlls/winscard/unixlib.h b/dlls/winscard/unixlib.h index d750c23f07b..dd069efab58 100644 --- a/dlls/winscard/unixlib.h +++ b/dlls/winscard/unixlib.h @@ -84,6 +84,17 @@ struct scard_connect_params UINT64 *protocol; }; +struct scard_status_params +{ + UINT64 handle; + char *names; + UINT64 *names_len; + UINT64 *state; + UINT64 *protocol; + BYTE *atr; + UINT64 *atr_len; +}; + enum winscard_funcs { unix_scard_establish_context, @@ -94,4 +105,5 @@ enum winscard_funcs unix_scard_list_readers, unix_scard_list_reader_groups, unix_scard_connect, + unix_scard_status, }; diff --git a/dlls/winscard/winscard.c b/dlls/winscard/winscard.c index aff6012cb83..6cded4387f6 100644 --- a/dlls/winscard/winscard.c +++ b/dlls/winscard/winscard.c @@ -231,11 +231,48 @@ static LONG copy_multiszA( const char *src, char *dst, DWORD *dst_len ) return SCARD_S_SUCCESS; } -LONG WINAPI SCardStatusA(SCARDHANDLE context, LPSTR szReaderName, LPDWORD pcchReaderLen, LPDWORD pdwState, LPDWORD pdwProtocol, LPBYTE pbAtr, LPDWORD pcbAtrLen) +LONG WINAPI SCardStatusA( SCARDHANDLE connect, char *names, DWORD *names_len, DWORD *state, DWORD *protocol, + BYTE *atr, DWORD *atr_len ) { - FIXME("(%Ix) stub\n", context); - SetLastError(ERROR_CALL_NOT_IMPLEMENTED); - return SCARD_F_INTERNAL_ERROR; + struct handle *handle = (struct handle *)connect; + struct scard_status_params params; + UINT64 state64, protocol64, atr_len64, names_len_utf8 = 0; + LONG ret; + + TRACE( "%Ix, %p, %p, %p, %p, %p, %p\n", connect, names, names_len, state, protocol, atr, atr_len ); + + if (!handle || handle->magic != CONNECT_MAGIC) return ERROR_INVALID_HANDLE; + if ((names_len && *names_len == SCARD_AUTOALLOCATE) || (atr_len && *atr_len == SCARD_AUTOALLOCATE)) + { + FIXME( "SCARD_AUTOALLOCATE not supported\n" ); + return SCARD_F_INTERNAL_ERROR; + } + + params.handle = handle->unix_handle; + params.names = NULL; + params.names_len = &names_len_utf8; + params.state = &state64; + params.protocol = &protocol64; + params.atr = NULL; + if (!atr_len) params.atr_len = NULL; + else + { + atr_len64 = *atr_len; + params.atr_len = &atr_len64; + } + if ((ret = UNIX_CALL( scard_status, &params ))) return ret; + + if (!(params.names = malloc( names_len_utf8 ))) return SCARD_E_NO_MEMORY; + if (!(ret = UNIX_CALL( scard_status, &params )) && !(ret = copy_multiszA( params.names, names, names_len ))) + { + if (state) *state = state64; + if (protocol) *protocol = protocol64; + if (atr_len) *atr_len = atr_len64; + } + + free( params.names ); + TRACE( "returning %#lx\n", ret ); + return ret; } static LONG copy_multiszW( const char *src, WCHAR *dst, DWORD *dst_len ) @@ -259,11 +296,48 @@ static LONG copy_multiszW( const char *src, WCHAR *dst, DWORD *dst_len ) return SCARD_S_SUCCESS; } -LONG WINAPI SCardStatusW(SCARDHANDLE context, LPWSTR szReaderName, LPDWORD pcchReaderLen, LPDWORD pdwState,LPDWORD pdwProtocol,LPBYTE pbAtr,LPDWORD pcbArtLen) +LONG WINAPI SCardStatusW( SCARDHANDLE connect, WCHAR *names, DWORD *names_len, DWORD *state, DWORD *protocol, + BYTE *atr, DWORD *atr_len ) { - FIXME("(%Ix) stub\n", context); - SetLastError(ERROR_CALL_NOT_IMPLEMENTED); - return SCARD_F_INTERNAL_ERROR; + struct handle *handle = (struct handle *)connect; + struct scard_status_params params; + UINT64 state64, protocol64, atr_len64, names_len_utf8 = 0; + LONG ret; + + TRACE( "%Ix, %p, %p, %p, %p, %p, %p\n", connect, names, names_len, state, protocol, atr, atr_len ); + + if (!handle || handle->magic != CONNECT_MAGIC) return ERROR_INVALID_HANDLE; + if ((names_len && *names_len == SCARD_AUTOALLOCATE) || (atr_len && *atr_len == SCARD_AUTOALLOCATE)) + { + FIXME( "SCARD_AUTOALLOCATE not supported\n" ); + return SCARD_F_INTERNAL_ERROR; + } + + params.handle = handle->unix_handle; + params.names = NULL; + params.names_len = &names_len_utf8; + params.state = &state64; + params.protocol = &protocol64; + params.atr = atr; + if (!atr_len) params.atr_len = NULL; + else + { + atr_len64 = *atr_len; + params.atr_len = &atr_len64; + } + if ((ret = UNIX_CALL( scard_status, &params ))) return ret; + + if (!(params.names = malloc( names_len_utf8 ))) return SCARD_E_NO_MEMORY; + if (!(ret = UNIX_CALL( scard_status, &params )) && !(ret = copy_multiszW( params.names, names, names_len ))) + { + if (state) *state = state64; + if (protocol) *protocol = protocol64; + if (atr_len) *atr_len = atr_len64; + } + + free( params.names ); + TRACE( "returning %#lx\n", ret ); + return ret; } void WINAPI SCardReleaseStartedEvent(void)

1 0

Hans Leidekker : winscard: Implement SCardRe/Disconnect().
by Alexandre Julliard 22 Feb '23

22 Feb '23

Module: wine Branch: master Commit: ba2010a02a7b6ee9403b4e7f3a074dac6f06ffed URL: https://gitlab.winehq.org/wine/wine/-/commit/ba2010a02a7b6ee9403b4e7f3a074d… Author: Hans Leidekker <hans(a)codeweavers.com> Date: Thu Feb 16 12:43:43 2023 +0100 winscard: Implement SCardRe/Disconnect(). --- dlls/winscard/unixlib.c | 17 +++++++++++++++++ dlls/winscard/unixlib.h | 17 +++++++++++++++++ dlls/winscard/winscard.c | 43 +++++++++++++++++++++++++++++++++++++++++++ dlls/winscard/winscard.spec | 4 ++-- 4 files changed, 79 insertions(+), 2 deletions(-) diff --git a/dlls/winscard/unixlib.c b/dlls/winscard/unixlib.c index 4f975ef40f9..c9afe13d796 100644 --- a/dlls/winscard/unixlib.c +++ b/dlls/winscard/unixlib.c @@ -40,6 +40,8 @@ LONG SCardListReaders( UINT64, const char *, char *, UINT64 * ); LONG SCardListReaderGroups( UINT64, char *, UINT64 * ); LONG SCardConnect( UINT64, const char *, UINT64, UINT64, UINT64 *, UINT64 * ); LONG SCardStatus( UINT64, char *, UINT64 *, UINT64 *, UINT64 *, BYTE *, UINT64 * ); +LONG SCardDisconnect( UINT64, UINT64 ); +LONG SCardReconnect( UINT64, UINT64, UINT64, UINT64, UINT64 * ); static NTSTATUS scard_establish_context( void *args ) { @@ -97,6 +99,19 @@ static NTSTATUS scard_status( void *args ) params->atr, params->atr_len ); } +static NTSTATUS scard_reconnect( void *args ) +{ + struct scard_reconnect_params *params = args; + return SCardReconnect( params->handle, params->share_mode, params->preferred_protocols, + params->initialization, params->protocol ); +} + +static NTSTATUS scard_disconnect( void *args ) +{ + struct scard_disconnect_params *params = args; + return SCardDisconnect( params->handle, params->disposition ); +} + const unixlib_entry_t __wine_unix_call_funcs[] = { scard_establish_context, @@ -108,4 +123,6 @@ const unixlib_entry_t __wine_unix_call_funcs[] = scard_list_reader_groups, scard_connect, scard_status, + scard_reconnect, + scard_disconnect, }; diff --git a/dlls/winscard/unixlib.h b/dlls/winscard/unixlib.h index dd069efab58..2c7007a1f12 100644 --- a/dlls/winscard/unixlib.h +++ b/dlls/winscard/unixlib.h @@ -95,6 +95,21 @@ struct scard_status_params UINT64 *atr_len; }; +struct scard_reconnect_params +{ + UINT64 handle; + UINT64 share_mode; + UINT64 preferred_protocols; + UINT64 initialization; + UINT64 *protocol; +}; + +struct scard_disconnect_params +{ + UINT64 handle; + UINT64 disposition; +}; + enum winscard_funcs { unix_scard_establish_context, @@ -106,4 +121,6 @@ enum winscard_funcs unix_scard_list_reader_groups, unix_scard_connect, unix_scard_status, + unix_scard_reconnect, + unix_scard_disconnect, }; diff --git a/dlls/winscard/winscard.c b/dlls/winscard/winscard.c index 6cded4387f6..d6bf81ecbc0 100644 --- a/dlls/winscard/winscard.c +++ b/dlls/winscard/winscard.c @@ -710,6 +710,49 @@ LONG WINAPI SCardConnectW( SCARDCONTEXT context, const WCHAR *reader, DWORD shar return ret; } +LONG WINAPI SCardReconnect( SCARDHANDLE connect, DWORD share_mode, DWORD preferred_protocols, DWORD initalization, + DWORD *protocol ) +{ + struct handle *handle = (struct handle *)connect; + struct scard_reconnect_params params; + UINT64 protocol64; + LONG ret; + + TRACE( "%Ix, %#lx, %#lx, %#lx, %p\n", connect, share_mode, preferred_protocols, initalization, protocol ); + + if (!handle || handle->magic != CONNECT_MAGIC) return ERROR_INVALID_HANDLE; + + params.handle = handle->unix_handle; + params.share_mode = share_mode; + params.preferred_protocols = preferred_protocols; + params.initialization = initalization; + params.protocol = &protocol64; + if (!(ret = UNIX_CALL( scard_reconnect, &params )) && protocol) *protocol = protocol64; + TRACE( "returning %#lx\n", ret ); + return ret; +} + +LONG WINAPI SCardDisconnect( SCARDHANDLE connect, DWORD disposition ) +{ + struct handle *handle = (struct handle *)connect; + struct scard_disconnect_params params; + LONG ret; + + TRACE( "%Ix, %#lx\n", connect, disposition ); + + if (!handle || handle->magic != CONNECT_MAGIC) return ERROR_INVALID_HANDLE; + + params.handle = handle->unix_handle; + params.disposition = disposition; + if (!(ret = UNIX_CALL( scard_disconnect, &params ))) + { + handle->magic = 0; + free( handle ); + } + TRACE( "returning %#lx\n", ret ); + return ret; +} + BOOL WINAPI DllMain( HINSTANCE hinst, DWORD reason, void *reserved ) { switch (reason) diff --git a/dlls/winscard/winscard.spec b/dlls/winscard/winscard.spec index 40db017a7d1..c9f903ed483 100644 --- a/dlls/winscard/winscard.spec +++ b/dlls/winscard/winscard.spec @@ -10,7 +10,7 @@ @ stdcall SCardConnectA(long str long long ptr ptr) @ stdcall SCardConnectW(long wstr long long ptr ptr) @ stub SCardControl -@ stub SCardDisconnect +@ stdcall SCardDisconnect(long long) @ stub SCardEndTransaction @ stdcall SCardEstablishContext(long ptr ptr ptr) @ stub SCardForgetCardTypeA @@ -46,7 +46,7 @@ @ stub SCardLocateCardsByATRA @ stub SCardLocateCardsByATRW @ stub SCardLocateCardsW -@ stub SCardReconnect +@ stdcall SCardReconnect(long long long long ptr) @ stdcall SCardReleaseContext(long) @ stdcall SCardReleaseStartedEvent() @ stub SCardRemoveReaderFromGroupA

1 0

Hans Leidekker : winscard: Implement SCardBegin/EndTransaction().
by Alexandre Julliard 22 Feb '23

22 Feb '23

Module: wine Branch: master Commit: 094161f33f6bc8d6fcb33f4c67da9cc822f01973 URL: https://gitlab.winehq.org/wine/wine/-/commit/094161f33f6bc8d6fcb33f4c67da9c… Author: Hans Leidekker <hans(a)codeweavers.com> Date: Thu Feb 16 12:54:22 2023 +0100 winscard: Implement SCardBegin/EndTransaction(). --- dlls/winscard/unixlib.c | 16 ++++++++++++++++ dlls/winscard/unixlib.h | 13 +++++++++++++ dlls/winscard/winscard.c | 33 +++++++++++++++++++++++++++++++++ dlls/winscard/winscard.spec | 4 ++-- 4 files changed, 64 insertions(+), 2 deletions(-) diff --git a/dlls/winscard/unixlib.c b/dlls/winscard/unixlib.c index c9afe13d796..e1cdf673c92 100644 --- a/dlls/winscard/unixlib.c +++ b/dlls/winscard/unixlib.c @@ -42,6 +42,8 @@ LONG SCardConnect( UINT64, const char *, UINT64, UINT64, UINT64 *, UINT64 * ); LONG SCardStatus( UINT64, char *, UINT64 *, UINT64 *, UINT64 *, BYTE *, UINT64 * ); LONG SCardDisconnect( UINT64, UINT64 ); LONG SCardReconnect( UINT64, UINT64, UINT64, UINT64, UINT64 * ); +LONG SCardBeginTransaction( UINT64 ); +LONG SCardEndTransaction( UINT64, UINT64 ); static NTSTATUS scard_establish_context( void *args ) { @@ -112,6 +114,18 @@ static NTSTATUS scard_disconnect( void *args ) return SCardDisconnect( params->handle, params->disposition ); } +static NTSTATUS scard_begin_transaction( void *args ) +{ + struct scard_begin_transaction_params *params = args; + return SCardBeginTransaction( params->handle ); +} + +static NTSTATUS scard_end_transaction( void *args ) +{ + struct scard_end_transaction_params *params = args; + return SCardEndTransaction( params->handle, params->disposition ); +} + const unixlib_entry_t __wine_unix_call_funcs[] = { scard_establish_context, @@ -125,4 +139,6 @@ const unixlib_entry_t __wine_unix_call_funcs[] = scard_status, scard_reconnect, scard_disconnect, + scard_begin_transaction, + scard_end_transaction, }; diff --git a/dlls/winscard/unixlib.h b/dlls/winscard/unixlib.h index 2c7007a1f12..6c7576220f9 100644 --- a/dlls/winscard/unixlib.h +++ b/dlls/winscard/unixlib.h @@ -110,6 +110,17 @@ struct scard_disconnect_params UINT64 disposition; }; +struct scard_begin_transaction_params +{ + UINT64 handle; +}; + +struct scard_end_transaction_params +{ + UINT64 handle; + UINT64 disposition; +}; + enum winscard_funcs { unix_scard_establish_context, @@ -123,4 +134,6 @@ enum winscard_funcs unix_scard_status, unix_scard_reconnect, unix_scard_disconnect, + unix_scard_begin_transaction, + unix_scard_end_transaction, }; diff --git a/dlls/winscard/winscard.c b/dlls/winscard/winscard.c index d6bf81ecbc0..a5b9cc75af5 100644 --- a/dlls/winscard/winscard.c +++ b/dlls/winscard/winscard.c @@ -753,6 +753,39 @@ LONG WINAPI SCardDisconnect( SCARDHANDLE connect, DWORD disposition ) return ret; } +LONG WINAPI SCardBeginTransaction( SCARDHANDLE connect ) +{ + struct handle *handle = (struct handle *)connect; + struct scard_begin_transaction_params params; + LONG ret; + + TRACE( "%Ix\n", connect ); + + if (!handle || handle->magic != CONNECT_MAGIC) return ERROR_INVALID_HANDLE; + + params.handle = handle->unix_handle; + ret = UNIX_CALL( scard_begin_transaction, &params ); + TRACE( "returning %#lx\n", ret ); + return ret; +} + +LONG WINAPI SCardEndTransaction( SCARDHANDLE connect, DWORD disposition ) +{ + struct handle *handle = (struct handle *)connect; + struct scard_end_transaction_params params; + LONG ret; + + TRACE( "%Ix, %#lx\n", connect, disposition ); + + if (!handle || handle->magic != CONNECT_MAGIC) return ERROR_INVALID_HANDLE; + + params.handle = handle->unix_handle; + params.disposition = disposition; + ret = UNIX_CALL( scard_end_transaction, &params ); + TRACE( "returning %#lx\n", ret ); + return ret; +} + BOOL WINAPI DllMain( HINSTANCE hinst, DWORD reason, void *reserved ) { switch (reason) diff --git a/dlls/winscard/winscard.spec b/dlls/winscard/winscard.spec index c9f903ed483..828df2416c9 100644 --- a/dlls/winscard/winscard.spec +++ b/dlls/winscard/winscard.spec @@ -5,13 +5,13 @@ @ stdcall SCardAccessStartedEvent() @ stdcall SCardAddReaderToGroupA(long str str) @ stdcall SCardAddReaderToGroupW(long wstr wstr) -@ stub SCardBeginTransaction +@ stdcall SCardBeginTransaction(long) @ stdcall SCardCancel(long) @ stdcall SCardConnectA(long str long long ptr ptr) @ stdcall SCardConnectW(long wstr long long ptr ptr) @ stub SCardControl @ stdcall SCardDisconnect(long long) -@ stub SCardEndTransaction +@ stdcall SCardEndTransaction(long long) @ stdcall SCardEstablishContext(long ptr ptr ptr) @ stub SCardForgetCardTypeA @ stub SCardForgetCardTypeW

1 0

Hans Leidekker : winscard: Implement SCardTransmit().
by Alexandre Julliard 22 Feb '23

22 Feb '23

Module: wine Branch: master Commit: 26c72e911e2b6fadf6d0e0d34cc331f294e57569 URL: https://gitlab.winehq.org/wine/wine/-/commit/26c72e911e2b6fadf6d0e0d34cc331… Author: Hans Leidekker <hans(a)codeweavers.com> Date: Thu Feb 16 13:03:01 2023 +0100 winscard: Implement SCardTransmit(). --- dlls/winscard/unixlib.c | 9 +++++++++ dlls/winscard/unixlib.h | 18 ++++++++++++++++++ dlls/winscard/winscard.c | 36 ++++++++++++++++++++++++++++++++++++ dlls/winscard/winscard.spec | 2 +- 4 files changed, 64 insertions(+), 1 deletion(-) diff --git a/dlls/winscard/unixlib.c b/dlls/winscard/unixlib.c index e1cdf673c92..50f6e348e97 100644 --- a/dlls/winscard/unixlib.c +++ b/dlls/winscard/unixlib.c @@ -44,6 +44,7 @@ LONG SCardDisconnect( UINT64, UINT64 ); LONG SCardReconnect( UINT64, UINT64, UINT64, UINT64, UINT64 * ); LONG SCardBeginTransaction( UINT64 ); LONG SCardEndTransaction( UINT64, UINT64 ); +LONG SCardTransmit( UINT64, const struct io_request *, const BYTE *, UINT64, struct io_request *, BYTE *, UINT64 * ); static NTSTATUS scard_establish_context( void *args ) { @@ -126,6 +127,13 @@ static NTSTATUS scard_end_transaction( void *args ) return SCardEndTransaction( params->handle, params->disposition ); } +static NTSTATUS scard_transmit( void *args ) +{ + struct scard_transmit_params *params = args; + return SCardTransmit( params->handle, params->send, params->send_buf, params->send_buflen, params->recv, + params->recv_buf, params->recv_buflen ); +} + const unixlib_entry_t __wine_unix_call_funcs[] = { scard_establish_context, @@ -141,4 +149,5 @@ const unixlib_entry_t __wine_unix_call_funcs[] = scard_disconnect, scard_begin_transaction, scard_end_transaction, + scard_transmit, }; diff --git a/dlls/winscard/unixlib.h b/dlls/winscard/unixlib.h index 6c7576220f9..33b1d295509 100644 --- a/dlls/winscard/unixlib.h +++ b/dlls/winscard/unixlib.h @@ -121,6 +121,23 @@ struct scard_end_transaction_params UINT64 disposition; }; +struct io_request +{ + UINT64 protocol; + UINT64 pci_len; +}; + +struct scard_transmit_params +{ + UINT64 handle; + const struct io_request *send; + const BYTE *send_buf; + UINT64 send_buflen; + struct io_request *recv; + BYTE *recv_buf; + UINT64 *recv_buflen; +}; + enum winscard_funcs { unix_scard_establish_context, @@ -136,4 +153,5 @@ enum winscard_funcs unix_scard_disconnect, unix_scard_begin_transaction, unix_scard_end_transaction, + unix_scard_transmit, }; diff --git a/dlls/winscard/winscard.c b/dlls/winscard/winscard.c index a5b9cc75af5..7ef0a3fc9ba 100644 --- a/dlls/winscard/winscard.c +++ b/dlls/winscard/winscard.c @@ -786,6 +786,42 @@ LONG WINAPI SCardEndTransaction( SCARDHANDLE connect, DWORD disposition ) return ret; } +LONG WINAPI SCardTransmit( SCARDHANDLE connect, const SCARD_IO_REQUEST *send, const BYTE *send_buf, + DWORD send_buflen, SCARD_IO_REQUEST *recv, BYTE *recv_buf, DWORD *recv_buflen ) +{ + struct handle *handle = (struct handle *)connect; + struct scard_transmit_params params; + struct io_request send64 = { send->dwProtocol, send->cbPciLength }, recv64; + UINT64 recv_buflen64; + LONG ret; + + TRACE( "%Ix, %p, %p, %lu, %p, %p, %p\n", connect, send, send_buf, send_buflen, recv, recv_buf, recv_buflen ); + + if (!handle || handle->magic != CONNECT_MAGIC) return ERROR_INVALID_HANDLE; + if (!recv_buflen) return SCARD_E_INVALID_PARAMETER; + + params.handle = handle->unix_handle; + params.send = &send64; + params.send_buf = send_buf; + params.send_buflen = send_buflen; + params.recv = &recv64; + params.recv_buf = recv_buf; + recv_buflen64 = *recv_buflen; + params.recv_buflen = &recv_buflen64; + if (!(ret = UNIX_CALL( scard_transmit, &params ))) + { + if (recv) + { + recv->dwProtocol = recv64.protocol; + recv->cbPciLength = recv64.pci_len; + } + *recv_buflen = recv_buflen64; + } + + TRACE( "returning %#lx\n", ret ); + return ret; +} + BOOL WINAPI DllMain( HINSTANCE hinst, DWORD reason, void *reserved ) { switch (reason) diff --git a/dlls/winscard/winscard.spec b/dlls/winscard/winscard.spec index 828df2416c9..6de6c9036dd 100644 --- a/dlls/winscard/winscard.spec +++ b/dlls/winscard/winscard.spec @@ -57,7 +57,7 @@ @ stub SCardState @ stdcall SCardStatusA(long str ptr ptr ptr ptr ptr) @ stdcall SCardStatusW(long wstr ptr ptr ptr ptr ptr) -@ stub SCardTransmit +@ stdcall SCardTransmit(long ptr ptr long ptr ptr ptr) @ extern g_rgSCardRawPci @ extern g_rgSCardT0Pci @ extern g_rgSCardT1Pci

1 0

Hans Leidekker : winscard: Implement SCardControl().
by Alexandre Julliard 22 Feb '23

22 Feb '23

Module: wine Branch: master Commit: c53a2044e0bc0d8833b33351fb4b1f4a4175b4c7 URL: https://gitlab.winehq.org/wine/wine/-/commit/c53a2044e0bc0d8833b33351fb4b1f… Author: Hans Leidekker <hans(a)codeweavers.com> Date: Thu Feb 16 13:07:41 2023 +0100 winscard: Implement SCardControl(). --- dlls/winscard/unixlib.c | 9 +++++++++ dlls/winscard/unixlib.h | 12 ++++++++++++ dlls/winscard/winscard.c | 25 +++++++++++++++++++++++++ dlls/winscard/winscard.spec | 2 +- 4 files changed, 47 insertions(+), 1 deletion(-) diff --git a/dlls/winscard/unixlib.c b/dlls/winscard/unixlib.c index 50f6e348e97..b9ca68e40b9 100644 --- a/dlls/winscard/unixlib.c +++ b/dlls/winscard/unixlib.c @@ -45,6 +45,7 @@ LONG SCardReconnect( UINT64, UINT64, UINT64, UINT64, UINT64 * ); LONG SCardBeginTransaction( UINT64 ); LONG SCardEndTransaction( UINT64, UINT64 ); LONG SCardTransmit( UINT64, const struct io_request *, const BYTE *, UINT64, struct io_request *, BYTE *, UINT64 * ); +LONG SCardControl( UINT64, UINT64, const void *, UINT64, void *, UINT64, UINT64 * ); static NTSTATUS scard_establish_context( void *args ) { @@ -134,6 +135,13 @@ static NTSTATUS scard_transmit( void *args ) params->recv_buf, params->recv_buflen ); } +static NTSTATUS scard_control( void *args ) +{ + struct scard_control_params *params = args; + return SCardControl( params->handle, params->code, params->in_buf, params->in_buflen, params->out_buf, + params->out_buflen, params->ret_len ); +} + const unixlib_entry_t __wine_unix_call_funcs[] = { scard_establish_context, @@ -150,4 +158,5 @@ const unixlib_entry_t __wine_unix_call_funcs[] = scard_begin_transaction, scard_end_transaction, scard_transmit, + scard_control, }; diff --git a/dlls/winscard/unixlib.h b/dlls/winscard/unixlib.h index 33b1d295509..cdc7efe1b05 100644 --- a/dlls/winscard/unixlib.h +++ b/dlls/winscard/unixlib.h @@ -138,6 +138,17 @@ struct scard_transmit_params UINT64 *recv_buflen; }; +struct scard_control_params +{ + UINT64 handle; + UINT64 code; + const void *in_buf; + UINT64 in_buflen; + void *out_buf; + UINT64 out_buflen; + UINT64 *ret_len; +}; + enum winscard_funcs { unix_scard_establish_context, @@ -154,4 +165,5 @@ enum winscard_funcs unix_scard_begin_transaction, unix_scard_end_transaction, unix_scard_transmit, + unix_scard_control, }; diff --git a/dlls/winscard/winscard.c b/dlls/winscard/winscard.c index 7ef0a3fc9ba..09b5734c802 100644 --- a/dlls/winscard/winscard.c +++ b/dlls/winscard/winscard.c @@ -822,6 +822,31 @@ LONG WINAPI SCardTransmit( SCARDHANDLE connect, const SCARD_IO_REQUEST *send, co return ret; } +LONG WINAPI SCardControl( SCARDHANDLE connect, DWORD code, const void *in_buf, DWORD in_buflen, void *out_buf, + DWORD out_buflen, DWORD *ret_len ) +{ + struct handle *handle = (struct handle *)connect; + struct scard_control_params params; + UINT64 ret_len64; + LONG ret; + + TRACE( "%Ix, %#lx, %p, %lu, %p, %lu, %p\n", connect, code, in_buf, in_buflen, out_buf, out_buflen, ret_len ); + + if (!handle || handle->magic != CONNECT_MAGIC) return ERROR_INVALID_HANDLE; + if (!ret_len) return SCARD_E_INVALID_PARAMETER; + + params.handle = handle->unix_handle; + params.code = code; + params.in_buf = in_buf; + params.in_buflen = in_buflen; + params.out_buf = out_buf; + params.out_buflen = out_buflen; + params.ret_len = &ret_len64; + if (!(ret = UNIX_CALL( scard_control, &params ))) *ret_len = ret_len64; + TRACE( "returning %#lx\n", ret ); + return ret; +} + BOOL WINAPI DllMain( HINSTANCE hinst, DWORD reason, void *reserved ) { switch (reason) diff --git a/dlls/winscard/winscard.spec b/dlls/winscard/winscard.spec index 6de6c9036dd..bc9b0fd40da 100644 --- a/dlls/winscard/winscard.spec +++ b/dlls/winscard/winscard.spec @@ -9,7 +9,7 @@ @ stdcall SCardCancel(long) @ stdcall SCardConnectA(long str long long ptr ptr) @ stdcall SCardConnectW(long wstr long long ptr ptr) -@ stub SCardControl +@ stdcall SCardControl(long long ptr long ptr long ptr) @ stdcall SCardDisconnect(long long) @ stdcall SCardEndTransaction(long long) @ stdcall SCardEstablishContext(long ptr ptr ptr)

1 0

Hans Leidekker : winscard: Implement SCardGet/SetAttrib().
by Alexandre Julliard 22 Feb '23

22 Feb '23

Module: wine Branch: master Commit: 7de85fc6fa1dc6fd4205ccd4f826f7f074be8dcb URL: https://gitlab.winehq.org/wine/wine/-/commit/7de85fc6fa1dc6fd4205ccd4f826f7… Author: Hans Leidekker <hans(a)codeweavers.com> Date: Thu Feb 16 13:17:40 2023 +0100 winscard: Implement SCardGet/SetAttrib(). --- dlls/winscard/unixlib.c | 16 ++++++++++++++++ dlls/winscard/unixlib.h | 18 ++++++++++++++++++ dlls/winscard/winscard.c | 41 +++++++++++++++++++++++++++++++++++++++++ dlls/winscard/winscard.spec | 4 ++-- 4 files changed, 77 insertions(+), 2 deletions(-) diff --git a/dlls/winscard/unixlib.c b/dlls/winscard/unixlib.c index b9ca68e40b9..4fb17b8ad6f 100644 --- a/dlls/winscard/unixlib.c +++ b/dlls/winscard/unixlib.c @@ -46,6 +46,8 @@ LONG SCardBeginTransaction( UINT64 ); LONG SCardEndTransaction( UINT64, UINT64 ); LONG SCardTransmit( UINT64, const struct io_request *, const BYTE *, UINT64, struct io_request *, BYTE *, UINT64 * ); LONG SCardControl( UINT64, UINT64, const void *, UINT64, void *, UINT64, UINT64 * ); +LONG SCardGetAttrib( UINT64, UINT64, BYTE *, UINT64 * ); +LONG SCardSetAttrib( UINT64, UINT64, const BYTE *, UINT64 ); static NTSTATUS scard_establish_context( void *args ) { @@ -142,6 +144,18 @@ static NTSTATUS scard_control( void *args ) params->out_buflen, params->ret_len ); } +static NTSTATUS scard_get_attrib( void *args ) +{ + struct scard_get_attrib_params *params = args; + return SCardGetAttrib( params->handle, params->id, params->attr, params->attr_len ); +} + +static NTSTATUS scard_set_attrib( void *args ) +{ + struct scard_set_attrib_params *params = args; + return SCardSetAttrib( params->handle, params->id, params->attr, params->attr_len ); +} + const unixlib_entry_t __wine_unix_call_funcs[] = { scard_establish_context, @@ -159,4 +173,6 @@ const unixlib_entry_t __wine_unix_call_funcs[] = scard_end_transaction, scard_transmit, scard_control, + scard_get_attrib, + scard_set_attrib, }; diff --git a/dlls/winscard/unixlib.h b/dlls/winscard/unixlib.h index cdc7efe1b05..ecb1b40ef68 100644 --- a/dlls/winscard/unixlib.h +++ b/dlls/winscard/unixlib.h @@ -149,6 +149,22 @@ struct scard_control_params UINT64 *ret_len; }; +struct scard_get_attrib_params +{ + UINT64 handle; + UINT64 id; + void *attr; + UINT64 *attr_len; +}; + +struct scard_set_attrib_params +{ + UINT64 handle; + UINT64 id; + const void *attr; + UINT64 attr_len; +}; + enum winscard_funcs { unix_scard_establish_context, @@ -166,4 +182,6 @@ enum winscard_funcs unix_scard_end_transaction, unix_scard_transmit, unix_scard_control, + unix_scard_get_attrib, + unix_scard_set_attrib, }; diff --git a/dlls/winscard/winscard.c b/dlls/winscard/winscard.c index 09b5734c802..dd588992a44 100644 --- a/dlls/winscard/winscard.c +++ b/dlls/winscard/winscard.c @@ -847,6 +847,47 @@ LONG WINAPI SCardControl( SCARDHANDLE connect, DWORD code, const void *in_buf, D return ret; } +LONG WINAPI SCardGetAttrib( SCARDHANDLE connect, DWORD id, BYTE *attr, DWORD *attr_len ) +{ + struct handle *handle = (struct handle *)connect; + struct scard_get_attrib_params params; + UINT64 attr_len64; + LONG ret; + + TRACE( "%Ix, %#lx, %p, %p\n", connect, id, attr, attr_len ); + + if (!handle || handle->magic != CONNECT_MAGIC) return ERROR_INVALID_HANDLE; + if (!attr_len) return SCARD_E_INVALID_PARAMETER; + + params.handle = handle->unix_handle; + params.id = id; + params.attr = attr; + attr_len64 = *attr_len; + params.attr_len = &attr_len64; + if (!(ret = UNIX_CALL( scard_get_attrib, &params ))) *attr_len = attr_len64; + TRACE( "returning %#lx\n", ret ); + return ret; +} + +LONG WINAPI SCardSetAttrib( SCARDHANDLE connect, DWORD id, const BYTE *attr, DWORD attr_len ) +{ + struct handle *handle = (struct handle *)connect; + struct scard_set_attrib_params params; + LONG ret; + + TRACE( "%Ix, %#lx, %p, %lu\n", connect, id, attr, attr_len ); + + if (!handle || handle->magic != CONNECT_MAGIC) return ERROR_INVALID_HANDLE; + + params.handle = handle->unix_handle; + params.id = id; + params.attr = attr; + params.attr_len = attr_len; + ret = UNIX_CALL( scard_set_attrib, &params ); + TRACE( "returning %#lx\n", ret ); + return ret; +} + BOOL WINAPI DllMain( HINSTANCE hinst, DWORD reason, void *reserved ) { switch (reason) diff --git a/dlls/winscard/winscard.spec b/dlls/winscard/winscard.spec index bc9b0fd40da..e9b6fbb9d41 100644 --- a/dlls/winscard/winscard.spec +++ b/dlls/winscard/winscard.spec @@ -20,7 +20,7 @@ @ stub SCardForgetReaderGroupW @ stub SCardForgetReaderW @ stub SCardFreeMemory -@ stub SCardGetAttrib +@ stdcall SCardGetAttrib(long long ptr ptr) @ stub SCardGetCardTypeProviderNameA @ stub SCardGetCardTypeProviderNameW @ stub SCardGetProviderIdA @@ -51,7 +51,7 @@ @ stdcall SCardReleaseStartedEvent() @ stub SCardRemoveReaderFromGroupA @ stub SCardRemoveReaderFromGroupW -@ stub SCardSetAttrib +@ stdcall SCardSetAttrib(long long ptr long) @ stub SCardSetCardTypeProviderNameA @ stub SCardSetCardTypeProviderNameW @ stub SCardState

1 0

Hans Leidekker : winscard: Implement SCardFreeMemory().
by Alexandre Julliard 22 Feb '23

22 Feb '23

Module: wine Branch: master Commit: 906977f59a7ed6677ab7ad4c69fb7d847bc30cff URL: https://gitlab.winehq.org/wine/wine/-/commit/906977f59a7ed6677ab7ad4c69fb7d… Author: Hans Leidekker <hans(a)codeweavers.com> Date: Thu Feb 16 13:28:01 2023 +0100 winscard: Implement SCardFreeMemory(). --- dlls/winscard/winscard.c | 8 ++++++++ dlls/winscard/winscard.spec | 2 +- 2 files changed, 9 insertions(+), 1 deletion(-) diff --git a/dlls/winscard/winscard.c b/dlls/winscard/winscard.c index dd588992a44..f4d924be549 100644 --- a/dlls/winscard/winscard.c +++ b/dlls/winscard/winscard.c @@ -888,6 +888,14 @@ LONG WINAPI SCardSetAttrib( SCARDHANDLE connect, DWORD id, const BYTE *attr, DWO return ret; } +LONG WINAPI SCardFreeMemory( SCARDCONTEXT context, const void *mem ) +{ + TRACE( "%Ix, %p\n", context, mem ); + + free( (void *)mem ); + return SCARD_S_SUCCESS; +} + BOOL WINAPI DllMain( HINSTANCE hinst, DWORD reason, void *reserved ) { switch (reason) diff --git a/dlls/winscard/winscard.spec b/dlls/winscard/winscard.spec index e9b6fbb9d41..34bf1c67950 100644 --- a/dlls/winscard/winscard.spec +++ b/dlls/winscard/winscard.spec @@ -19,7 +19,7 @@ @ stub SCardForgetReaderGroupA @ stub SCardForgetReaderGroupW @ stub SCardForgetReaderW -@ stub SCardFreeMemory +@ stdcall SCardFreeMemory(long ptr) @ stdcall SCardGetAttrib(long long ptr ptr) @ stub SCardGetCardTypeProviderNameA @ stub SCardGetCardTypeProviderNameW

1 0

Hans Leidekker : winscard: Use string conversion helpers in SCardAddReaderToGroupA().
by Alexandre Julliard 22 Feb '23

22 Feb '23

Module: wine Branch: master Commit: 40c013206aaaac64985d8c74bedaa0af69fb335d URL: https://gitlab.winehq.org/wine/wine/-/commit/40c013206aaaac64985d8c74bedaa0… Author: Hans Leidekker <hans(a)codeweavers.com> Date: Thu Feb 16 13:32:45 2023 +0100 winscard: Use string conversion helpers in SCardAddReaderToGroupA(). --- dlls/winscard/winscard.c | 31 ++++++++++++++++--------------- 1 file changed, 16 insertions(+), 15 deletions(-) diff --git a/dlls/winscard/winscard.c b/dlls/winscard/winscard.c index f4d924be549..b2dd7d5f8e9 100644 --- a/dlls/winscard/winscard.c +++ b/dlls/winscard/winscard.c @@ -115,27 +115,28 @@ HANDLE WINAPI SCardAccessStartedEvent(void) return g_startedEvent; } -LONG WINAPI SCardAddReaderToGroupA(SCARDCONTEXT context, LPCSTR reader, LPCSTR group) +LONG WINAPI SCardAddReaderToGroupA( SCARDCONTEXT context, const char *reader, const char *group ) { - LONG retval; - UNICODE_STRING readerW, groupW; - - if(reader) RtlCreateUnicodeStringFromAsciiz(&readerW,reader); - else readerW.Buffer = NULL; - if(group) RtlCreateUnicodeStringFromAsciiz(&groupW,group); - else groupW.Buffer = NULL; - - retval = SCardAddReaderToGroupW(context, readerW.Buffer, groupW.Buffer); + WCHAR *readerW = NULL, *groupW = NULL; + LONG ret; - RtlFreeUnicodeString(&readerW); - RtlFreeUnicodeString(&groupW); + TRACE( "%Ix, %s, %s\n", context, debugstr_a(reader), debugstr_a(group) ); - return retval; + if (reader && !(readerW = ansi_to_utf16( reader ))) return SCARD_E_NO_MEMORY; + if (group && !(groupW = ansi_to_utf16( group ))) + { + free( readerW ); + return SCARD_E_NO_MEMORY; + } + ret = SCardAddReaderToGroupW( context, readerW, groupW ); + free( readerW ); + free( groupW ); + return ret; } -LONG WINAPI SCardAddReaderToGroupW(SCARDCONTEXT context, LPCWSTR reader, LPCWSTR group) +LONG WINAPI SCardAddReaderToGroupW( SCARDCONTEXT context, const WCHAR *reader, const WCHAR *group ) { - FIXME("%x %s %s\n", (unsigned int) context, debugstr_w(reader), debugstr_w(group)); + FIXME( "%Ix, %s, %s\n", context, debugstr_w(reader), debugstr_w(group) ); return SCARD_S_SUCCESS; }

1 0