February 2023 - Wine-commits

Hans Leidekker : include: Add missing smart card defines.
by Alexandre Julliard 22 Feb '23

22 Feb '23

Module: wine Branch: master Commit: 210596600c60f29137d8cebda74891c3cd7dd03b URL: https://gitlab.winehq.org/wine/wine/-/commit/210596600c60f29137d8cebda74891… Author: Hans Leidekker <hans(a)codeweavers.com> Date: Thu Feb 16 09:28:02 2023 +0100 include: Add missing smart card defines. --- include/winscard.h | 9 +++++++++ include/winsmcrd.h | 26 ++++++++++++++++++++++++++ 2 files changed, 35 insertions(+) diff --git a/include/winscard.h b/include/winscard.h index 5aee1b3e548..0ce473b6bf1 100644 --- a/include/winscard.h +++ b/include/winscard.h @@ -85,6 +85,15 @@ DECL_WINELIB_TYPE_AW(LPSCARD_READERSTATE) #define SCARD_STATE_MUTE 0x00000200 #define SCARD_STATE_UNPOWERED 0x00000400 +#define SCARD_SHARE_EXCLUSIVE 1 +#define SCARD_SHARE_SHARED 2 +#define SCARD_SHARE_DIRECT 3 + +#define SCARD_LEAVE_CARD 0 +#define SCARD_RESET_CARD 1 +#define SCARD_UNPOWER_CARD 2 +#define SCARD_EJECT_CARD 3 + #ifdef __cplusplus extern "C" { #endif diff --git a/include/winsmcrd.h b/include/winsmcrd.h index 60fdd3e492c..15c427c48da 100644 --- a/include/winsmcrd.h +++ b/include/winsmcrd.h @@ -27,6 +27,32 @@ #define SCARD_PROTOCOL_DEFAULT 0x80000000 #define SCARD_PROTOCOL_Tx (SCARD_PROTOCOL_T0 | SCARD_PROTOCOL_T1) +#define SCARD_UNKNOWN 0 +#define SCARD_ABSENT 1 +#define SCARD_PRESENT 2 +#define SCARD_SWALLOWED 3 +#define SCARD_POWERED 4 +#define SCARD_NEGOTIABLE 5 +#define SCARD_SPECIFIC 6 + +#define SCARD_ATTR_VALUE(class, tag) ((((ULONG)(class)) << 16) | ((ULONG)(tag))) + +#define SCARD_CLASS_VENDOR_INFO 1 +#define SCARD_CLASS_COMMUNICATIONS 2 +#define SCARD_CLASS_PROTOCOL 3 +#define SCARD_CLASS_POWER_MGMT 4 +#define SCARD_CLASS_SECURITY 5 +#define SCARD_CLASS_MECHANICAL 6 +#define SCARD_CLASS_VENDOR_DEFINED 7 +#define SCARD_CLASS_IFD_PROTOCOL 8 +#define SCARD_CLASS_ICC_STATE 9 +#define SCARD_CLASS_PERF 0x7ffe +#define SCARD_CLASS_SYSTEM 0x7fff + +#define SCARD_ATTR_VENDOR_NAME SCARD_ATTR_VALUE(SCARD_CLASS_VENDOR_INFO, 0x0100) + +#define SCARD_CTL_CODE(code) CTL_CODE(FILE_DEVICE_SMARTCARD, (code), METHOD_BUFFERED, FILE_ANY_ACCESS) + typedef struct _SCARD_IO_REQUEST { DWORD dwProtocol;

1 0

Hans Leidekker : winscard: Implement SCardEstablish/ReleaseContext() on top of libpcsclite.
by Alexandre Julliard 22 Feb '23

22 Feb '23

Module: wine Branch: master Commit: 8490c43f38e306fef7b5fed3ffcb256efd73af58 URL: https://gitlab.winehq.org/wine/wine/-/commit/8490c43f38e306fef7b5fed3ffcb25… Author: Hans Leidekker <hans(a)codeweavers.com> Date: Thu Feb 16 09:56:12 2023 +0100 winscard: Implement SCardEstablish/ReleaseContext() on top of libpcsclite. --- configure | 74 +++++++++++++++++++++++++++++++-- configure.ac | 10 +++++ dlls/winscard/Makefile.in | 3 ++ dlls/winscard/unixlib.c | 53 ++++++++++++++++++++++++ dlls/winscard/unixlib.h | 37 +++++++++++++++++ dlls/winscard/winscard.c | 103 ++++++++++++++++++++++++++++++++-------------- 6 files changed, 244 insertions(+), 36 deletions(-)

1 0

Hans Leidekker : winscard: Implement SCardIsValidContext().
by Alexandre Julliard 22 Feb '23

22 Feb '23

Module: wine Branch: master Commit: 9d40ac4635989f76b16384f15f01220fdec4d51a URL: https://gitlab.winehq.org/wine/wine/-/commit/9d40ac4635989f76b16384f15f0122… Author: Hans Leidekker <hans(a)codeweavers.com> Date: Thu Feb 16 10:27:22 2023 +0100 winscard: Implement SCardIsValidContext(). --- dlls/winscard/unixlib.c | 8 ++++++++ dlls/winscard/unixlib.h | 6 ++++++ dlls/winscard/winscard.c | 17 +++++++++++++---- 3 files changed, 27 insertions(+), 4 deletions(-) diff --git a/dlls/winscard/unixlib.c b/dlls/winscard/unixlib.c index 76f2d5cd60b..032b148af8f 100644 --- a/dlls/winscard/unixlib.c +++ b/dlls/winscard/unixlib.c @@ -33,6 +33,7 @@ LONG SCardEstablishContext( UINT64, const void *, const void *, UINT64 * ); LONG SCardReleaseContext( UINT64 ); +LONG SCardIsValidContext( UINT64 ); static NTSTATUS scard_establish_context( void *args ) { @@ -46,8 +47,15 @@ static NTSTATUS scard_release_context( void *args ) return SCardReleaseContext( params->handle ); } +static NTSTATUS scard_is_valid_context( void *args ) +{ + struct scard_is_valid_context_params *params = args; + return SCardIsValidContext( params->handle ); +} + const unixlib_entry_t __wine_unix_call_funcs[] = { scard_establish_context, scard_release_context, + scard_is_valid_context, }; diff --git a/dlls/winscard/unixlib.h b/dlls/winscard/unixlib.h index 08b907f76fe..b8ba940f5b2 100644 --- a/dlls/winscard/unixlib.h +++ b/dlls/winscard/unixlib.h @@ -30,8 +30,14 @@ struct scard_release_context_params UINT64 handle; }; +struct scard_is_valid_context_params +{ + UINT64 handle; +}; + enum winscard_funcs { unix_scard_establish_context, unix_scard_release_context, + unix_scard_is_valid_context, }; diff --git a/dlls/winscard/winscard.c b/dlls/winscard/winscard.c index 0f7edb56c91..4f4cbcfed2f 100644 --- a/dlls/winscard/winscard.c +++ b/dlls/winscard/winscard.c @@ -94,11 +94,20 @@ LONG WINAPI SCardEstablishContext( DWORD scope, const void *reserved1, const voi return ret; } -LONG WINAPI SCardIsValidContext(SCARDCONTEXT context) +LONG WINAPI SCardIsValidContext( SCARDCONTEXT context ) { - FIXME("(%Ix) stub\n", context); - SetLastError(ERROR_CALL_NOT_IMPLEMENTED); - return SCARD_F_INTERNAL_ERROR; + struct handle *handle = (struct handle *)context; + struct scard_is_valid_context_params params; + LONG ret; + + TRACE( "%Ix\n", context ); + + if (!handle || handle->magic != CONTEXT_MAGIC) return ERROR_INVALID_HANDLE; + + params.handle = handle->unix_handle; + ret = UNIX_CALL( scard_is_valid_context, &params ); + TRACE( "returning %#lx\n", ret ); + return ret; } LONG WINAPI SCardListCardsA(SCARDCONTEXT hContext, LPCBYTE pbAtr, LPCGUID rgguidInterfaces, DWORD cguidInterfaceCount, LPSTR mszCards, LPDWORD pcchCards)

1 0

Hans Leidekker : winscard: Implement SCardGetStatusChangeA/W().
by Alexandre Julliard 22 Feb '23

22 Feb '23

Module: wine Branch: master Commit: 3f325721c3b1d72dca475dc1fa2ad4063f663f69 URL: https://gitlab.winehq.org/wine/wine/-/commit/3f325721c3b1d72dca475dc1fa2ad4… Author: Hans Leidekker <hans(a)codeweavers.com> Date: Thu Feb 16 10:50:32 2023 +0100 winscard: Implement SCardGetStatusChangeA/W(). --- dlls/winscard/unixlib.c | 8 +++ dlls/winscard/unixlib.h | 20 ++++++ dlls/winscard/winscard.c | 147 ++++++++++++++++++++++++++++++++++++++++++++ dlls/winscard/winscard.spec | 4 +- 4 files changed, 177 insertions(+), 2 deletions(-) diff --git a/dlls/winscard/unixlib.c b/dlls/winscard/unixlib.c index 032b148af8f..98de78a6d2b 100644 --- a/dlls/winscard/unixlib.c +++ b/dlls/winscard/unixlib.c @@ -34,6 +34,7 @@ LONG SCardEstablishContext( UINT64, const void *, const void *, UINT64 * ); LONG SCardReleaseContext( UINT64 ); LONG SCardIsValidContext( UINT64 ); +LONG SCardGetStatusChange( UINT64, UINT64, struct reader_state *, UINT64 ); static NTSTATUS scard_establish_context( void *args ) { @@ -53,9 +54,16 @@ static NTSTATUS scard_is_valid_context( void *args ) return SCardIsValidContext( params->handle ); } +static NTSTATUS scard_get_status_change( void *args ) +{ + struct scard_get_status_change_params *params = args; + return SCardGetStatusChange( params->handle, params->timeout, params->states, params->count ); +} + const unixlib_entry_t __wine_unix_call_funcs[] = { scard_establish_context, scard_release_context, scard_is_valid_context, + scard_get_status_change, }; diff --git a/dlls/winscard/unixlib.h b/dlls/winscard/unixlib.h index b8ba940f5b2..0607596bf2c 100644 --- a/dlls/winscard/unixlib.h +++ b/dlls/winscard/unixlib.h @@ -35,9 +35,29 @@ struct scard_is_valid_context_params UINT64 handle; }; +#define MAX_ATR_SIZE 33 +struct reader_state +{ + UINT64 reader; + UINT64 userdata; + UINT64 current_state; + UINT64 event_state; + UINT64 atr_size; + unsigned char atr[MAX_ATR_SIZE]; +}; + +struct scard_get_status_change_params +{ + UINT64 handle; + UINT64 timeout; + struct reader_state *states; + UINT64 count; +}; + enum winscard_funcs { unix_scard_establish_context, unix_scard_release_context, unix_scard_is_valid_context, + unix_scard_get_status_change, }; diff --git a/dlls/winscard/winscard.c b/dlls/winscard/winscard.c index 4f4cbcfed2f..3fefff5f755 100644 --- a/dlls/winscard/winscard.c +++ b/dlls/winscard/winscard.c @@ -37,6 +37,40 @@ const SCARD_IO_REQUEST g_rgSCardT0Pci = { SCARD_PROTOCOL_T0, 8 }; const SCARD_IO_REQUEST g_rgSCardT1Pci = { SCARD_PROTOCOL_T1, 8 }; const SCARD_IO_REQUEST g_rgSCardRawPci = { SCARD_PROTOCOL_RAW, 8 }; +static inline char *utf16_to_utf8( const WCHAR *src ) +{ + char *dst = NULL; + if (src) + { + int len = WideCharToMultiByte( CP_UTF8, 0, src, -1, NULL, 0, NULL, NULL ); + if ((dst = malloc( len ))) WideCharToMultiByte( CP_UTF8, 0, src, -1, dst, len, NULL, NULL ); + } + return dst; +} + +static inline WCHAR *ansi_to_utf16( const char *src ) +{ + WCHAR *dst = NULL; + if (src) + { + int len = MultiByteToWideChar( CP_ACP, 0, src, -1, NULL, 0 ); + if ((dst = malloc( len * sizeof(WCHAR) ))) MultiByteToWideChar( CP_ACP, 0, src, -1, dst, len ); + } + return dst; +} + +static inline char *ansi_to_utf8( const char *src ) +{ + char *dst = NULL; + if (src) + { + WCHAR *tmp; + if ((tmp = ansi_to_utf16( src ))) dst = utf16_to_utf8( tmp ); + free( tmp ); + } + return dst; +} + HANDLE WINAPI SCardAccessStartedEvent(void) { return g_startedEvent; @@ -174,6 +208,119 @@ LONG WINAPI SCardCancel(SCARDCONTEXT context) return SCARD_F_INTERNAL_ERROR; } +static LONG map_states_inA( const SCARD_READERSTATEA *src, struct reader_state *dst, DWORD count ) +{ + DWORD i; + for (i = 0; i < count; i++) + { + if (src[i].szReader && !(dst[i].reader = (UINT64)(ULONG_PTR)ansi_to_utf8( src[i].szReader ))) + return SCARD_E_NO_MEMORY; + dst[i].current_state = src[i].dwCurrentState; + dst[i].event_state = src[i].dwEventState; + dst[i].atr_size = src[i].cbAtr; + memcpy( dst[i].atr, src[i].rgbAtr, src[i].cbAtr ); + } + return SCARD_S_SUCCESS; +} + +static void map_states_out( const struct reader_state *src, SCARD_READERSTATEA *dst, DWORD count ) +{ + DWORD i; + for (i = 0; i < count; i++) + { + dst[i].dwCurrentState = src[i].current_state; + dst[i].dwEventState = src[i].event_state; + dst[i].cbAtr = src[i].atr_size; + memcpy( dst[i].rgbAtr, src[i].atr, src[i].atr_size ); + } +} + +static void free_states( struct reader_state *states, DWORD count ) +{ + DWORD i; + for (i = 0; i < count; i++) free( (void *)(ULONG_PTR)states[i].reader ); + free( states ); +} + +LONG WINAPI SCardGetStatusChangeA( SCARDCONTEXT context, DWORD timeout, SCARD_READERSTATEA *states, DWORD count ) +{ + struct handle *handle = (struct handle *)context; + struct scard_get_status_change_params params; + struct reader_state *states_utf8 = NULL; + LONG ret; + + TRACE( "%Ix, %lu, %p, %lu\n", context, timeout, states, count ); + + if (!handle || handle->magic != CONTEXT_MAGIC) return ERROR_INVALID_HANDLE; + + if (!(states_utf8 = calloc( count, sizeof(*states_utf8) ))) return SCARD_E_NO_MEMORY; + if ((ret = map_states_inA( states, states_utf8, count ))) + { + free_states( states_utf8, count ); + return ret; + } + + params.handle = handle->unix_handle; + params.timeout = timeout; + params.states = states_utf8; + params.count = count; + if (!(ret = UNIX_CALL( scard_get_status_change, &params )) && states) + { + map_states_out( states_utf8, states, count ); + } + + free_states( states_utf8, count ); + TRACE( "returning %#lx\n", ret ); + return ret; +} + +static LONG map_states_inW( SCARD_READERSTATEW *src, struct reader_state *dst, DWORD count ) +{ + DWORD i; + for (i = 0; i < count; i++) + { + if (src[i].szReader && !(dst[i].reader = (UINT64)(ULONG_PTR)utf16_to_utf8( src[i].szReader ))) + return SCARD_E_NO_MEMORY; + dst[i].current_state = src[i].dwCurrentState; + dst[i].event_state = src[i].dwEventState; + dst[i].atr_size = src[i].cbAtr; + memcpy( dst[i].atr, src[i].rgbAtr, src[i].cbAtr ); + } + return SCARD_S_SUCCESS; +} + +LONG WINAPI SCardGetStatusChangeW( SCARDCONTEXT context, DWORD timeout, SCARD_READERSTATEW *states, DWORD count ) +{ + struct handle *handle = (struct handle *)context; + struct scard_get_status_change_params params; + struct reader_state *states_utf8; + LONG ret; + + TRACE( "%Ix, %lu, %p, %lu\n", context, timeout, states, count ); + + if (!handle || handle->magic != CONTEXT_MAGIC) return ERROR_INVALID_HANDLE; + + if (!(states_utf8 = calloc( count, sizeof(*states_utf8) ))) return SCARD_E_NO_MEMORY; + if ((ret = map_states_inW( states, states_utf8, count ))) + { + free_states( states_utf8, count ); + return ret; + } + + params.handle = handle->unix_handle; + params.timeout = timeout; + params.states = states_utf8; + params.count = count; + if (!(ret = UNIX_CALL( scard_get_status_change, &params ))) + { + map_states_out( states_utf8, (SCARD_READERSTATEA *)states, count ); + } + + free_states( states_utf8, count ); + TRACE( "returning %#lx\n", ret ); + return ret; +} + BOOL WINAPI DllMain( HINSTANCE hinst, DWORD reason, void *reserved ) { switch (reason) diff --git a/dlls/winscard/winscard.spec b/dlls/winscard/winscard.spec index 037d3bef903..ff320bae424 100644 --- a/dlls/winscard/winscard.spec +++ b/dlls/winscard/winscard.spec @@ -25,8 +25,8 @@ @ stub SCardGetCardTypeProviderNameW @ stub SCardGetProviderIdA @ stub SCardGetProviderIdW -@ stub SCardGetStatusChangeA -@ stub SCardGetStatusChangeW +@ stdcall SCardGetStatusChangeA(long long ptr long) +@ stdcall SCardGetStatusChangeW(long long ptr long) @ stub SCardIntroduceCardTypeA @ stub SCardIntroduceCardTypeW @ stub SCardIntroduceReaderA

1 0

Hans Leidekker : winscard: Implement SCardCancel().
by Alexandre Julliard 22 Feb '23

22 Feb '23

Module: wine Branch: master Commit: 4295b90ce15560823205e3f4e53e1d83ab4d8536 URL: https://gitlab.winehq.org/wine/wine/-/commit/4295b90ce15560823205e3f4e53e1d… Author: Hans Leidekker <hans(a)codeweavers.com> Date: Thu Feb 16 11:47:45 2023 +0100 winscard: Implement SCardCancel(). --- dlls/winscard/unixlib.c | 8 ++++++++ dlls/winscard/unixlib.h | 6 ++++++ dlls/winscard/winscard.c | 17 +++++++++++++---- 3 files changed, 27 insertions(+), 4 deletions(-) diff --git a/dlls/winscard/unixlib.c b/dlls/winscard/unixlib.c index 98de78a6d2b..6aca020cd4e 100644 --- a/dlls/winscard/unixlib.c +++ b/dlls/winscard/unixlib.c @@ -35,6 +35,7 @@ LONG SCardEstablishContext( UINT64, const void *, const void *, UINT64 * ); LONG SCardReleaseContext( UINT64 ); LONG SCardIsValidContext( UINT64 ); LONG SCardGetStatusChange( UINT64, UINT64, struct reader_state *, UINT64 ); +LONG SCardCancel( UINT64 ); static NTSTATUS scard_establish_context( void *args ) { @@ -60,10 +61,17 @@ static NTSTATUS scard_get_status_change( void *args ) return SCardGetStatusChange( params->handle, params->timeout, params->states, params->count ); } +static NTSTATUS scard_cancel( void *args ) +{ + struct scard_cancel_params *params = args; + return SCardCancel( params->handle ); +} + const unixlib_entry_t __wine_unix_call_funcs[] = { scard_establish_context, scard_release_context, scard_is_valid_context, scard_get_status_change, + scard_cancel, }; diff --git a/dlls/winscard/unixlib.h b/dlls/winscard/unixlib.h index 0607596bf2c..c2151a7573e 100644 --- a/dlls/winscard/unixlib.h +++ b/dlls/winscard/unixlib.h @@ -54,10 +54,16 @@ struct scard_get_status_change_params UINT64 count; }; +struct scard_cancel_params +{ + UINT64 handle; +}; + enum winscard_funcs { unix_scard_establish_context, unix_scard_release_context, unix_scard_is_valid_context, unix_scard_get_status_change, + unix_scard_cancel, }; diff --git a/dlls/winscard/winscard.c b/dlls/winscard/winscard.c index 3fefff5f755..af822b8aef2 100644 --- a/dlls/winscard/winscard.c +++ b/dlls/winscard/winscard.c @@ -201,11 +201,20 @@ LONG WINAPI SCardListReadersW(SCARDCONTEXT context, const WCHAR *groups, WCHAR * return SCARD_E_NO_READERS_AVAILABLE; } -LONG WINAPI SCardCancel(SCARDCONTEXT context) +LONG WINAPI SCardCancel( SCARDCONTEXT context ) { - FIXME("(%Ix) stub\n", context); - SetLastError(ERROR_CALL_NOT_IMPLEMENTED); - return SCARD_F_INTERNAL_ERROR; + struct handle *handle = (struct handle *)context; + struct scard_cancel_params params; + LONG ret; + + TRACE( "%Ix\n", context ); + + if (!handle || handle->magic != CONTEXT_MAGIC) return ERROR_INVALID_HANDLE; + + params.handle = handle->unix_handle; + ret = UNIX_CALL( scard_cancel, &params ); + TRACE( "returning %#lx\n", ret ); + return ret; } static LONG map_states_inA( const SCARD_READERSTATEA *src, struct reader_state *dst, DWORD count )

1 0

Hans Leidekker : winscard: Implement SCardListReadersA/W().
by Alexandre Julliard 22 Feb '23

22 Feb '23

Module: wine Branch: master Commit: f7c66e642ea83d40fb6306e010ba57257b8d344c URL: https://gitlab.winehq.org/wine/wine/-/commit/f7c66e642ea83d40fb6306e010ba57… Author: Hans Leidekker <hans(a)codeweavers.com> Date: Thu Feb 16 12:01:43 2023 +0100 winscard: Implement SCardListReadersA/W(). --- dlls/winscard/unixlib.c | 8 +++ dlls/winscard/unixlib.h | 9 +++ dlls/winscard/winscard.c | 164 +++++++++++++++++++++++++++++++++++++++++++++-- 3 files changed, 175 insertions(+), 6 deletions(-) diff --git a/dlls/winscard/unixlib.c b/dlls/winscard/unixlib.c index 6aca020cd4e..61f179b2eb9 100644 --- a/dlls/winscard/unixlib.c +++ b/dlls/winscard/unixlib.c @@ -36,6 +36,7 @@ LONG SCardReleaseContext( UINT64 ); LONG SCardIsValidContext( UINT64 ); LONG SCardGetStatusChange( UINT64, UINT64, struct reader_state *, UINT64 ); LONG SCardCancel( UINT64 ); +LONG SCardListReaders( UINT64, const char *, char *, UINT64 * ); static NTSTATUS scard_establish_context( void *args ) { @@ -67,6 +68,12 @@ static NTSTATUS scard_cancel( void *args ) return SCardCancel( params->handle ); } +static NTSTATUS scard_list_readers( void *args ) +{ + struct scard_list_readers_params *params = args; + return SCardListReaders( params->handle, params->groups, params->readers, params->readers_len ); +} + const unixlib_entry_t __wine_unix_call_funcs[] = { scard_establish_context, @@ -74,4 +81,5 @@ const unixlib_entry_t __wine_unix_call_funcs[] = scard_is_valid_context, scard_get_status_change, scard_cancel, + scard_list_readers, }; diff --git a/dlls/winscard/unixlib.h b/dlls/winscard/unixlib.h index c2151a7573e..1be9fe7cf77 100644 --- a/dlls/winscard/unixlib.h +++ b/dlls/winscard/unixlib.h @@ -59,6 +59,14 @@ struct scard_cancel_params UINT64 handle; }; +struct scard_list_readers_params +{ + UINT64 handle; + const char *groups; + char *readers; + UINT64 *readers_len; +}; + enum winscard_funcs { unix_scard_establish_context, @@ -66,4 +74,5 @@ enum winscard_funcs unix_scard_is_valid_context, unix_scard_get_status_change, unix_scard_cancel, + unix_scard_list_readers, }; diff --git a/dlls/winscard/winscard.c b/dlls/winscard/winscard.c index af822b8aef2..a242de9ccce 100644 --- a/dlls/winscard/winscard.c +++ b/dlls/winscard/winscard.c @@ -71,6 +71,45 @@ static inline char *ansi_to_utf8( const char *src ) return dst; } +static inline WCHAR *utf8_to_utf16( const char *src ) +{ + WCHAR *dst = NULL; + if (src) + { + int len = MultiByteToWideChar( CP_UTF8, 0, src, -1, NULL, 0 ); + if ((dst = malloc( len * sizeof(WCHAR) ))) MultiByteToWideChar( CP_UTF8, 0, src, -1, dst, len ); + } + return dst; +} + +static inline char *utf16_to_ansi( const WCHAR *src ) +{ + char *dst = NULL; + if (src) + { + int len = WideCharToMultiByte( CP_ACP, WC_NO_BEST_FIT_CHARS, src, -1, NULL, 0, NULL, NULL ); + if (*src && !len) + { + FIXME( "can't convert %s to ANSI codepage\n", debugstr_w(src) ); + return NULL; + } + if ((dst = malloc( len ))) WideCharToMultiByte( CP_ACP, WC_NO_BEST_FIT_CHARS, src, -1, dst, len, NULL, NULL ); + } + return dst; +} + +static inline char *utf8_to_ansi( const char *src ) +{ + char *dst = NULL; + if (src) + { + WCHAR *tmp; + if ((tmp = utf8_to_utf16( src ))) dst = utf16_to_ansi( tmp ); + free( tmp ); + } + return dst; +} + HANDLE WINAPI SCardAccessStartedEvent(void) { return g_startedEvent; @@ -170,6 +209,27 @@ LONG WINAPI SCardReleaseContext( SCARDCONTEXT context ) return ret; } +static LONG copy_multiszA( const char *src, char *dst, DWORD *dst_len ) +{ + DWORD len, total_len = 0; + const char *ptr = src; + + while (*ptr) + { + char *str; + if (!(str = utf8_to_ansi( ptr ))) return SCARD_E_NO_MEMORY; + len = strlen( str ) + 1; + if (dst && dst_len && *dst_len > total_len + len) strcpy( dst + total_len, str ); + total_len += len; + ptr += strlen( ptr ) + 1; + free( str ); + } + + if (dst && dst_len && *dst_len > total_len + 1) dst[total_len] = 0; + if (dst_len) *dst_len = total_len + 1; + return SCARD_S_SUCCESS; +} + LONG WINAPI SCardStatusA(SCARDHANDLE context, LPSTR szReaderName, LPDWORD pcchReaderLen, LPDWORD pdwState, LPDWORD pdwProtocol, LPBYTE pbAtr, LPDWORD pcbAtrLen) { FIXME("(%Ix) stub\n", context); @@ -177,6 +237,27 @@ LONG WINAPI SCardStatusA(SCARDHANDLE context, LPSTR szReaderName, LPDWORD pcchRe return SCARD_F_INTERNAL_ERROR; } +static LONG copy_multiszW( const char *src, WCHAR *dst, DWORD *dst_len ) +{ + DWORD len, total_len = 0; + const char *ptr = src; + + while (*ptr) + { + WCHAR *str; + if (!(str = utf8_to_utf16( ptr ))) return SCARD_E_NO_MEMORY; + len = wcslen( str ) + 1; + if (dst && dst_len && *dst_len > total_len + len) wcscpy( dst + total_len, str ); + total_len += len; + ptr += strlen( ptr ) + 1; + free( str ); + } + + if (dst && dst_len && *dst_len > total_len + 1) dst[total_len] = 0; + if (dst_len) *dst_len = total_len + 1; + return SCARD_S_SUCCESS; +} + LONG WINAPI SCardStatusW(SCARDHANDLE context, LPWSTR szReaderName, LPDWORD pcchReaderLen, LPDWORD pdwState,LPDWORD pdwProtocol,LPBYTE pbAtr,LPDWORD pcbArtLen) { FIXME("(%Ix) stub\n", context); @@ -189,16 +270,87 @@ void WINAPI SCardReleaseStartedEvent(void) FIXME("stub\n"); } -LONG WINAPI SCardListReadersA(SCARDCONTEXT context, const CHAR *groups, CHAR *readers, DWORD *buflen) +LONG WINAPI SCardListReadersA( SCARDCONTEXT context, const char *groups, char *readers, DWORD *readers_len ) { - FIXME("(%Ix, %s, %p, %p) stub\n", context, debugstr_a(groups), readers, buflen); - return SCARD_E_NO_READERS_AVAILABLE; + struct handle *handle = (struct handle *)context; + struct scard_list_readers_params params; + UINT64 readers_len_utf8; + LONG ret; + + TRACE( "%Ix, %s, %p, %p\n", context, debugstr_a(groups), readers, readers_len ); + + if (!handle || handle->magic != CONTEXT_MAGIC) return ERROR_INVALID_HANDLE; + if (!readers_len) return SCARD_E_INVALID_PARAMETER; + if (*readers_len == SCARD_AUTOALLOCATE) + { + FIXME( "SCARD_AUTOALLOCATE not supported\n" ); + return SCARD_F_INTERNAL_ERROR; + } + + params.handle = handle->unix_handle; + if (!groups) params.groups = NULL; + else if (!(params.groups = ansi_to_utf8( groups ))) return SCARD_E_NO_MEMORY; + params.readers = NULL; + params.readers_len = &readers_len_utf8; + if ((ret = UNIX_CALL( scard_list_readers, &params ))) goto done; + + if (!(params.readers = malloc( readers_len_utf8 ))) + { + free( (void *)params.groups ); + return SCARD_E_NO_MEMORY; + } + if (!(ret = UNIX_CALL( scard_list_readers, &params ))) + { + ret = copy_multiszA( params.readers, readers, readers_len ); + } + +done: + free( (void *)params.groups ); + free( params.readers ); + TRACE( "returning %#lx\n", ret ); + return ret; } -LONG WINAPI SCardListReadersW(SCARDCONTEXT context, const WCHAR *groups, WCHAR *readers, DWORD *buflen) +LONG WINAPI SCardListReadersW( SCARDCONTEXT context, const WCHAR *groups, WCHAR *readers, DWORD *readers_len ) { - FIXME("(%Ix, %s, %p, %p) stub\n", context, debugstr_w(groups), readers, buflen); - return SCARD_E_NO_READERS_AVAILABLE; + struct handle *handle = (struct handle *)context; + struct scard_list_readers_params params; + UINT64 readers_len_utf8; + LONG ret; + + TRACE( "%Ix, %s, %p, %p\n", context, debugstr_w(groups), readers, readers_len ); + + if (!handle || handle->magic != CONTEXT_MAGIC) return ERROR_INVALID_HANDLE; + if (!readers_len) return SCARD_E_INVALID_PARAMETER; + if (*readers_len == SCARD_AUTOALLOCATE) + { + FIXME( "SCARD_AUTOALLOCATE not supported\n" ); + return SCARD_F_INTERNAL_ERROR; + } + + params.handle = handle->unix_handle; + if (!groups) params.groups = NULL; + else if (!(params.groups = utf16_to_utf8( groups ))) return SCARD_E_NO_MEMORY; + params.readers = NULL; + params.readers_len = &readers_len_utf8; + if ((ret = UNIX_CALL( scard_list_readers, &params ))) goto done; + + params.handle = handle->unix_handle; + if (!(params.readers = malloc( readers_len_utf8 ))) + { + free( (void *)params.groups ); + return SCARD_E_NO_MEMORY; + } + if (!(ret = UNIX_CALL( scard_list_readers, &params ))) + { + ret = copy_multiszW( params.readers, readers, readers_len ); + } + +done: + free( (void *)params.groups ); + free( params.readers ); + TRACE( "returning %#lx\n", ret ); + return ret; } LONG WINAPI SCardCancel( SCARDCONTEXT context )

1 0

Zebediah Figura : vkd3d-shader: Avoid underflowing the indentation level.
by Alexandre Julliard 22 Feb '23

22 Feb '23

Module: vkd3d Branch: master Commit: e10e12a10ca0968e5faadef0a9d92435eab73091 URL: https://gitlab.winehq.org/wine/vkd3d/-/commit/e10e12a10ca0968e5faadef0a9d92… Author: Zebediah Figura <zfigura(a)codeweavers.com> Date: Wed Nov 9 18:24:50 2022 -0600 vkd3d-shader: Avoid underflowing the indentation level. Any shader that would underflow is invalid, but it is helpful to allow tracing even invalid shaders. --- libs/vkd3d-shader/trace.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/libs/vkd3d-shader/trace.c b/libs/vkd3d-shader/trace.c index 8e2cac16..f32f26a7 100644 --- a/libs/vkd3d-shader/trace.c +++ b/libs/vkd3d-shader/trace.c @@ -1930,7 +1930,8 @@ enum vkd3d_result vkd3d_dxbc_binary_to_text(struct vkd3d_shader_parser *parser, case VKD3DSIH_ENDIF: case VKD3DSIH_ENDLOOP: case VKD3DSIH_ENDSWITCH: - --indent; + if (indent) + --indent; break; default:

1 0

Giovanni Mascellani : vkd3d-shader: Fix the Doxygen documentation for vkd3d_shader.h.
by Alexandre Julliard 22 Feb '23

22 Feb '23

Module: vkd3d Branch: master Commit: 6bdb0abf680b791134e7e9238cbd0dd20a28c3a4 URL: https://gitlab.winehq.org/wine/vkd3d/-/commit/6bdb0abf680b791134e7e9238cbd0… Author: Giovanni Mascellani <gmascellani(a)codeweavers.com> Date: Wed Feb 15 15:23:32 2023 +0100 vkd3d-shader: Fix the Doxygen documentation for vkd3d_shader.h. The \since field was too early, and prevented Doxygen from really parsing the synopsis for vkd3d_shader.h. --- include/vkd3d_shader.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/include/vkd3d_shader.h b/include/vkd3d_shader.h index 86ffb9d5..49725ff9 100644 --- a/include/vkd3d_shader.h +++ b/include/vkd3d_shader.h @@ -30,12 +30,12 @@ extern "C" { /** * \file vkd3d_shader.h * - * \since 1.2 - * * This file contains definitions for the vkd3d-shader library. * * The vkd3d-shader library provides multiple utilities related to the * compilation, transformation, and reflection of GPU shaders. + * + * \since 1.2 */ /** \since 1.3 */

1 0

Giovanni Mascellani : vkd3d: Generate Doxygen documentation for vkd3d.h.
by Alexandre Julliard 22 Feb '23

22 Feb '23

Module: vkd3d Branch: master Commit: e5bbd05c987a932dd25d63289372215204f346ff URL: https://gitlab.winehq.org/wine/vkd3d/-/commit/e5bbd05c987a932dd25d632893722… Author: Giovanni Mascellani <gmascellani(a)codeweavers.com> Date: Tue Jan 17 13:32:49 2023 +0100 vkd3d: Generate Doxygen documentation for vkd3d.h. --- include/vkd3d.h | 12 ++++++++++++ 1 file changed, 12 insertions(+) diff --git a/include/vkd3d.h b/include/vkd3d.h index b44f0084..76b1ba65 100644 --- a/include/vkd3d.h +++ b/include/vkd3d.h @@ -34,6 +34,18 @@ extern "C" { #endif /* __cplusplus */ +/** + * \file vkd3d.h + * + * This file contains definitions for the vkd3d library. + * + * The vkd3d library is a 3D graphics library built on top of + * Vulkan. It has an API very similar, but not identical, to + * Direct3D 12. + * + * \since 1.0 + */ + enum vkd3d_structure_type { /* 1.0 */

1 0

Giovanni Mascellani : vkd3d-utils: Generate Doxygen documentation for vkd3d_utils.h.
by Alexandre Julliard 22 Feb '23

22 Feb '23

Module: vkd3d Branch: master Commit: 5f904e5022e4f8c167415d14bf1eb0f00639427e URL: https://gitlab.winehq.org/wine/vkd3d/-/commit/5f904e5022e4f8c167415d14bf1eb… Author: Giovanni Mascellani <gmascellani(a)codeweavers.com> Date: Wed Feb 15 15:28:43 2023 +0100 vkd3d-utils: Generate Doxygen documentation for vkd3d_utils.h. --- include/vkd3d_utils.h | 11 +++++++++++ 1 file changed, 11 insertions(+) diff --git a/include/vkd3d_utils.h b/include/vkd3d_utils.h index 6e84b176..e8462563 100644 --- a/include/vkd3d_utils.h +++ b/include/vkd3d_utils.h @@ -29,6 +29,17 @@ extern "C" { #endif /* __cplusplus */ +/** + * \file vkd3d_utils.h + * + * This file contains definitions for the vkd3d-utils library. + * + * The vkd3d-utils library is a collections of routines to ease the + * porting of a Direct3D 12 application to vkd3d. + * + * \since 1.0 + */ + #define VKD3D_WAIT_OBJECT_0 (0) #define VKD3D_WAIT_TIMEOUT (1) #define VKD3D_WAIT_FAILED (~0u)

1 0