August 2023 - Wine-commits - list.winehq.org

Rémi Bernon : include: Add Windows.Management.Deployment.PackageUserInformation runtimeclass definition.
by Alexandre Julliard 22 Aug '23

22 Aug '23

Module: wine Branch: master Commit: cdf3355dc8aedc4800cc5ae0904682f5a800583e URL: https://gitlab.winehq.org/wine/wine/-/commit/cdf3355dc8aedc4800cc5ae0904682… Author: Rémi Bernon <rbernon(a)codeweavers.com> Date: Fri Aug 18 09:13:54 2023 +0200 include: Add Windows.Management.Deployment.PackageUserInformation runtimeclass definition. --- include/windows.management.deployment.idl | 34 +++++++++++++++++++++++++++++++ 1 file changed, 34 insertions(+) diff --git a/include/windows.management.deployment.idl b/include/windows.management.deployment.idl index 91a7488f650..07a6c9b711e 100644 --- a/include/windows.management.deployment.idl +++ b/include/windows.management.deployment.idl @@ -25,9 +25,23 @@ import "windows.applicationmodel.idl"; namespace Windows.Management.Deployment { + typedef enum PackageInstallState PackageInstallState; + interface IDeploymentResult; + interface IPackageUserInformation; runtimeclass DeploymentResult; + runtimeclass PackageUserInformation; + + [contract(Windows.Foundation.UniversalApiContract, 1.0)] + enum PackageInstallState + { + NotInstalled = 0, + Staged = 1, + Installed = 2, + [contract(Windows.Foundation.UniversalApiContract, 2.0)] + Paused = 6, + }; [ contract(Windows.Foundation.UniversalApiContract, 1.0), @@ -41,6 +55,17 @@ namespace Windows.Management.Deployment { [propget] HRESULT ExtendedErrorCode([out, retval] HRESULT *value); } + [ + contract(Windows.Foundation.UniversalApiContract, 1.0), + exclusiveto(Windows.Management.Deployment.PackageUserInformation), + uuid(f6383423-fa09-4cbc-9055-15ca275e2e7e) + ] + interface IPackageUserInformation : IInspectable + { + [propget] HRESULT UserSecurityId([out, retval] HSTRING *value); + [propget] HRESULT InstallState([out, retval] Windows.Management.Deployment.PackageInstallState *value); + } + [ contract(Windows.Foundation.UniversalApiContract, 1.0), marshaling_behavior(agile) @@ -51,4 +76,13 @@ namespace Windows.Management.Deployment { [contract(Windows.Foundation.UniversalApiContract, 4.0)] interface Windows.Management.Deployment.IDeploymentResult2; } + [ + contract(Windows.Foundation.UniversalApiContract, 1.0), + marshaling_behavior(agile) + ] + runtimeclass PackageUserInformation + { + [default] interface Windows.Management.Deployment.IPackageUserInformation; + } + }

1 0

Rémi Bernon : include: Add Windows.Management.Deployment.PackageManager runtimeclass definition.
by Alexandre Julliard 22 Aug '23

22 Aug '23

Module: wine Branch: master Commit: f6fd79a3b9926c9c3dfefd64fefbccbe2f60527c URL: https://gitlab.winehq.org/wine/wine/-/commit/f6fd79a3b9926c9c3dfefd64fefbcc… Author: Rémi Bernon <rbernon(a)codeweavers.com> Date: Fri Aug 11 10:15:22 2023 +0200 include: Add Windows.Management.Deployment.PackageManager runtimeclass definition. --- include/windows.management.deployment.idl | 121 ++++++++++++++++++++++++++++++ 1 file changed, 121 insertions(+)

1 0

Rémi Bernon : include: Add Windows.Storage.Streams.RandomAccessStreamReference runtimeclass definition.
by Alexandre Julliard 22 Aug '23

22 Aug '23

Module: wine Branch: master Commit: d48a1d15d62f7497de8ef6f3e09136b6983df163 URL: https://gitlab.winehq.org/wine/wine/-/commit/d48a1d15d62f7497de8ef6f3e09136… Author: Rémi Bernon <rbernon(a)codeweavers.com> Date: Fri Aug 11 10:15:22 2023 +0200 include: Add Windows.Storage.Streams.RandomAccessStreamReference runtimeclass definition. --- include/windows.storage.streams.idl | 12 ++++++++++++ 1 file changed, 12 insertions(+) diff --git a/include/windows.storage.streams.idl b/include/windows.storage.streams.idl index 5bdeb3689ff..8e8aba3b377 100644 --- a/include/windows.storage.streams.idl +++ b/include/windows.storage.streams.idl @@ -34,10 +34,12 @@ namespace Windows.Storage.Streams { interface IOutputStream; interface IRandomAccessStream; interface IRandomAccessStreamReference; + interface IRandomAccessStreamReferenceStatics; interface IRandomAccessStreamStatics; interface IRandomAccessStreamWithContentType; runtimeclass Buffer; runtimeclass RandomAccessStream; + runtimeclass RandomAccessStreamReference; declare { interface Windows.Foundation.Collections.IIterable<Windows.Storage.Streams.IRandomAccessStream *>; @@ -138,4 +140,14 @@ namespace Windows.Storage.Streams { { [default] interface Windows.Storage.Streams.IBuffer; } + + [ + contract(Windows.Foundation.UniversalApiContract, 1.0), + marshaling_behavior(agile), + static(Windows.Storage.Streams.IRandomAccessStreamReferenceStatics, Windows.Foundation.UniversalApiContract, 1.0) + ] + runtimeclass RandomAccessStreamReference + { + [default] interface Windows.Storage.Streams.IRandomAccessStreamReference; + } }

1 0

Rémi Bernon : include: Add Windows.ApplicationModel.AppDisplayInfo runtimeclass definition.
by Alexandre Julliard 22 Aug '23

22 Aug '23

Module: wine Branch: master Commit: ff6333c2b3ddc326d76a1c301214976650477382 URL: https://gitlab.winehq.org/wine/wine/-/commit/ff6333c2b3ddc326d76a1c30121497… Author: Rémi Bernon <rbernon(a)codeweavers.com> Date: Fri Aug 11 10:15:22 2023 +0200 include: Add Windows.ApplicationModel.AppDisplayInfo runtimeclass definition. --- include/windows.applicationmodel.idl | 24 ++++++++++++++++++++++++ 1 file changed, 24 insertions(+) diff --git a/include/windows.applicationmodel.idl b/include/windows.applicationmodel.idl index 9514c06a60e..73dcb32d93b 100644 --- a/include/windows.applicationmodel.idl +++ b/include/windows.applicationmodel.idl @@ -27,11 +27,13 @@ import "windows.system.idl"; namespace Windows.ApplicationModel { typedef struct PackageVersion PackageVersion; + interface IAppDisplayInfo; interface IPackage; interface IPackageId; interface IPackageIdWithMetadata; interface IPackageStatics; + runtimeclass AppDisplayInfo; runtimeclass Package; runtimeclass PackageId; @@ -52,6 +54,18 @@ namespace Windows.ApplicationModel { UINT16 Revision; }; + [ + contract(Windows.Foundation.UniversalApiContract, 1.0), + exclusiveto(Windows.ApplicationModel.AppDisplayInfo), + uuid(1aeb1103-e4d4-41aa-a4f6-c4a276e79eac) + ] + interface IAppDisplayInfo : IInspectable + { + [propget] HRESULT DisplayName([out, retval] HSTRING *value); + [propget] HRESULT Description([out, retval] HSTRING *value); + HRESULT GetLogo([in] Windows.Foundation.Size size, [out, retval] Windows.Storage.Streams.RandomAccessStreamReference **value); + } + [ contract(Windows.Foundation.UniversalApiContract, 1.0), exclusiveto(Windows.ApplicationModel.Package), @@ -103,6 +117,16 @@ namespace Windows.ApplicationModel { [propget] HRESULT Current([out, retval] Windows.ApplicationModel.Package **value); } + [ + contract(Windows.Foundation.UniversalApiContract, 1.0), + marshaling_behavior(agile), + threading(both) + ] + runtimeclass AppDisplayInfo + { + [default] interface Windows.ApplicationModel.IAppDisplayInfo; + } + [ contract(Windows.Foundation.UniversalApiContract, 1.0), marshaling_behavior(agile),

1 0

Rémi Bernon : include: Add Windows.ApplicationModel.PackageStatus runtimeclass definition.
by Alexandre Julliard 22 Aug '23

22 Aug '23

Module: wine Branch: master Commit: 3395ce23ee54af52db1e128d3e9563410c026b9f URL: https://gitlab.winehq.org/wine/wine/-/commit/3395ce23ee54af52db1e128d3e9563… Author: Rémi Bernon <rbernon(a)codeweavers.com> Date: Fri Aug 11 10:15:22 2023 +0200 include: Add Windows.ApplicationModel.PackageStatus runtimeclass definition. --- include/windows.applicationmodel.idl | 33 +++++++++++++++++++++++++++++++++ 1 file changed, 33 insertions(+) diff --git a/include/windows.applicationmodel.idl b/include/windows.applicationmodel.idl index 73dcb32d93b..70cf9178de8 100644 --- a/include/windows.applicationmodel.idl +++ b/include/windows.applicationmodel.idl @@ -29,6 +29,7 @@ namespace Windows.ApplicationModel { interface IAppDisplayInfo; interface IPackage; + interface IPackageStatus; interface IPackageId; interface IPackageIdWithMetadata; interface IPackageStatics; @@ -36,6 +37,7 @@ namespace Windows.ApplicationModel { runtimeclass AppDisplayInfo; runtimeclass Package; runtimeclass PackageId; + runtimeclass PackageStatus; declare { interface Windows.Foundation.Collections.IIterable<Windows.ApplicationModel.Package *>; @@ -79,6 +81,27 @@ namespace Windows.ApplicationModel { [propget] HRESULT Dependencies([out, retval] Windows.Foundation.Collections.IVectorView<Windows.ApplicationModel.Package *> **value); } + [ + contract(Windows.Foundation.UniversalApiContract, 1.0), + exclusiveto(Windows.ApplicationModel.PackageStatus), + uuid(5fe74f71-a365-4c09-a02d-046d525ea1da) + ] + interface IPackageStatus : IInspectable + { + HRESULT VerifyIsOK([out, retval] boolean *value); + [propget] HRESULT NotAvailable([out, retval] boolean *value); + [propget] HRESULT PackageOffline([out, retval] boolean *value); + [propget] HRESULT DataOffline([out, retval] boolean *value); + [propget] HRESULT Disabled([out, retval] boolean *value); + [propget] HRESULT NeedsRemediation([out, retval] boolean *value); + [propget] HRESULT LicenseIssue([out, retval] boolean *value); + [propget] HRESULT Modified([out, retval] boolean *value); + [propget] HRESULT Tampered([out, retval] boolean *value); + [propget] HRESULT DependencyIssue([out, retval] boolean *value); + [propget] HRESULT Servicing([out, retval] boolean *value); + [propget] HRESULT DeploymentInProgress([out, retval] boolean *value); + } + [ contract(Windows.Foundation.UniversalApiContract, 1.0), exclusiveto(Windows.ApplicationModel.PackageId), @@ -146,6 +169,16 @@ namespace Windows.ApplicationModel { [contract(Windows.Foundation.UniversalApiContract, 10.0)] interface Windows.ApplicationModel.IPackage8; } + [ + contract(Windows.Foundation.UniversalApiContract, 1.0), + marshaling_behavior(agile) + ] + runtimeclass PackageStatus + { + [default] interface Windows.ApplicationModel.IPackageStatus; + [contract(Windows.Foundation.UniversalApiContract, 4.0)] interface Windows.ApplicationModel.IPackageStatus2; + } + [ contract(Windows.Foundation.UniversalApiContract, 1.0), marshaling_behavior(agile)

1 0

Rémi Bernon : widl: Guard against re-import of the main input file.
by Alexandre Julliard 22 Aug '23

22 Aug '23

Module: wine Branch: master Commit: 3b7398b403347e9a127e08afb79b03394aaa5b12 URL: https://gitlab.winehq.org/wine/wine/-/commit/3b7398b403347e9a127e08afb79b03… Author: Rémi Bernon <rbernon(a)codeweavers.com> Date: Fri Aug 18 09:35:41 2023 +0200 widl: Guard against re-import of the main input file. --- tools/widl/parser.l | 1 + tools/widl/parser.y | 2 +- tools/widl/widl.c | 9 ++++++--- tools/widl/widl.h | 2 +- 4 files changed, 9 insertions(+), 5 deletions(-) diff --git a/tools/widl/parser.l b/tools/widl/parser.l index 951998de381..61266efb9e3 100644 --- a/tools/widl/parser.l +++ b/tools/widl/parser.l @@ -520,6 +520,7 @@ void push_import( const char *import_name, struct location *where ) LIST_FOR_EACH_ENTRY( import, &imports, struct import, entry ) if (!strcmp( import->name, import_name )) return; /* already imported */ + if (!strcmp( idl_name, import_name )) return; /* already imported */ import = xmalloc( sizeof(struct import) ); import->name = xstrdup( import_name ); diff --git a/tools/widl/parser.y b/tools/widl/parser.y index f66dc62492f..bfd41aa9807 100644 --- a/tools/widl/parser.y +++ b/tools/widl/parser.y @@ -2270,7 +2270,7 @@ char *gen_name(void) if (! file_id) { - char *dst = replace_extension( get_basename(input_idl_name), ".idl", "" ); + char *dst = replace_extension( idl_name, ".idl", "" ); file_id = dst; for (; *dst; ++dst) diff --git a/tools/widl/widl.c b/tools/widl/widl.c index 5bbaeb970fb..e37160e3869 100644 --- a/tools/widl/widl.c +++ b/tools/widl/widl.c @@ -114,7 +114,7 @@ static int stdinc = 1; static enum stub_mode stub_mode = MODE_Os; char *input_name; -char *input_idl_name; +char *idl_name; char *acf_name; char *header_name; char *local_stubs_name; @@ -435,7 +435,7 @@ void write_id_data(const statement_list_t *stmts) } fprintf(idfile, "/*** Autogenerated by WIDL %s ", PACKAGE_VERSION); - fprintf(idfile, "from %s - Do not edit ***/\n\n", input_idl_name); + fprintf(idfile, "from %s - Do not edit ***/\n\n", idl_name); fprintf(idfile, "#include <rpc.h>\n"); fprintf(idfile, "#include <rpcndr.h>\n\n"); @@ -782,7 +782,10 @@ int main(int argc,char *argv[]) return 1; } else - input_idl_name = input_name = xstrdup(files.str[0]); + { + input_name = xstrdup( files.str[0] ); + idl_name = get_basename( input_name ); + } } else { fprintf(stderr, "%s", usage); diff --git a/tools/widl/widl.h b/tools/widl/widl.h index 518ae613f83..7595cfe7311 100644 --- a/tools/widl/widl.h +++ b/tools/widl/widl.h @@ -52,7 +52,7 @@ extern int winrt_mode; extern int use_abi_namespace; extern char *input_name; -extern char *input_idl_name; +extern char *idl_name; extern char *acf_name; extern char *header_name; extern char *header_token;

1 0

Gabriel Ivăncescu : mshtml: Implement Cycle Collection for HTMLSelectionObject.
by Alexandre Julliard 22 Aug '23

22 Aug '23

Module: wine Branch: master Commit: f888c91bd96207dc47fddff50945988098688841 URL: https://gitlab.winehq.org/wine/wine/-/commit/f888c91bd96207dc47fddff5094598… Author: Gabriel Ivăncescu <gabrielopcode(a)gmail.com> Date: Tue Aug 22 16:21:48 2023 +0300 mshtml: Implement Cycle Collection for HTMLSelectionObject. Signed-off-by: Gabriel Ivăncescu <gabrielopcode(a)gmail.com> --- dlls/mshtml/selection.c | 20 +++++++++++--------- 1 file changed, 11 insertions(+), 9 deletions(-) diff --git a/dlls/mshtml/selection.c b/dlls/mshtml/selection.c index ae53d83f642..97f65a2b22c 100644 --- a/dlls/mshtml/selection.c +++ b/dlls/mshtml/selection.c @@ -36,8 +36,6 @@ typedef struct { IHTMLSelectionObject IHTMLSelectionObject_iface; IHTMLSelectionObject2 IHTMLSelectionObject2_iface; - LONG ref; - nsISelection *nsselection; HTMLDocumentNode *doc; @@ -64,7 +62,7 @@ static HRESULT WINAPI HTMLSelectionObject_QueryInterface(IHTMLSelectionObject *i *ppv = &This->IHTMLSelectionObject_iface; }else if(IsEqualGUID(&IID_IHTMLSelectionObject2, riid)) { *ppv = &This->IHTMLSelectionObject2_iface; - }else if(dispex_query_interface_no_cc(&This->dispex, riid, ppv)) { + }else if(dispex_query_interface(&This->dispex, riid, ppv)) { return *ppv ? S_OK : E_NOINTERFACE; }else { *ppv = NULL; @@ -79,7 +77,7 @@ static HRESULT WINAPI HTMLSelectionObject_QueryInterface(IHTMLSelectionObject *i static ULONG WINAPI HTMLSelectionObject_AddRef(IHTMLSelectionObject *iface) { HTMLSelectionObject *This = impl_from_IHTMLSelectionObject(iface); - LONG ref = InterlockedIncrement(&This->ref); + LONG ref = dispex_ref_incr(&This->dispex); TRACE("(%p) ref=%ld\n", This, ref); @@ -89,13 +87,10 @@ static ULONG WINAPI HTMLSelectionObject_AddRef(IHTMLSelectionObject *iface) static ULONG WINAPI HTMLSelectionObject_Release(IHTMLSelectionObject *iface) { HTMLSelectionObject *This = impl_from_IHTMLSelectionObject(iface); - LONG ref = InterlockedDecrement(&This->ref); + LONG ref = dispex_ref_decr(&This->dispex); TRACE("(%p) ref=%ld\n", This, ref); - if(!ref) - release_dispex(&This->dispex); - return ref; } @@ -328,6 +323,13 @@ static inline HTMLSelectionObject *impl_from_DispatchEx(DispatchEx *iface) return CONTAINING_RECORD(iface, HTMLSelectionObject, dispex); } +static void HTMLSelectionObject_traverse(DispatchEx *dispex, nsCycleCollectionTraversalCallback *cb) +{ + HTMLSelectionObject *This = impl_from_DispatchEx(dispex); + if(This->nsselection) + note_cc_edge((nsISupports*)This->nsselection, "nsselection", cb); +} + static void HTMLSelectionObject_unlink(DispatchEx *dispex) { HTMLSelectionObject *This = impl_from_DispatchEx(dispex); @@ -346,6 +348,7 @@ static void HTMLSelectionObject_destructor(DispatchEx *dispex) static const dispex_static_data_vtbl_t HTMLSelectionObject_dispex_vtbl = { .destructor = HTMLSelectionObject_destructor, + .traverse = HTMLSelectionObject_traverse, .unlink = HTMLSelectionObject_unlink }; @@ -374,7 +377,6 @@ HRESULT HTMLSelectionObject_Create(HTMLDocumentNode *doc, nsISelection *nsselect selection->IHTMLSelectionObject_iface.lpVtbl = &HTMLSelectionObjectVtbl; selection->IHTMLSelectionObject2_iface.lpVtbl = &HTMLSelectionObject2Vtbl; - selection->ref = 1; selection->nsselection = nsselection; /* We shouldn't call AddRef here */ selection->doc = doc;

1 0

Gabriel Ivăncescu : mshtml: Implement Cycle Collection for HTMLEventObj.
by Alexandre Julliard 22 Aug '23

22 Aug '23

Module: wine Branch: master Commit: 81c681fc171553cf89eb79870562fd545b6ec085 URL: https://gitlab.winehq.org/wine/wine/-/commit/81c681fc171553cf89eb79870562fd… Author: Gabriel Ivăncescu <gabrielopcode(a)gmail.com> Date: Tue Aug 22 16:21:48 2023 +0300 mshtml: Implement Cycle Collection for HTMLEventObj. Signed-off-by: Gabriel Ivăncescu <gabrielopcode(a)gmail.com> --- dlls/mshtml/htmlevent.c | 20 +++++++++++--------- 1 file changed, 11 insertions(+), 9 deletions(-) diff --git a/dlls/mshtml/htmlevent.c b/dlls/mshtml/htmlevent.c index 9f3dbae81d7..22fe681abda 100644 --- a/dlls/mshtml/htmlevent.c +++ b/dlls/mshtml/htmlevent.c @@ -335,8 +335,6 @@ typedef struct { DispatchEx dispex; IHTMLEventObj IHTMLEventObj_iface; - LONG ref; - DOMEvent *event; VARIANT return_value; } HTMLEventObj; @@ -356,7 +354,7 @@ static HRESULT WINAPI HTMLEventObj_QueryInterface(IHTMLEventObj *iface, REFIID r *ppv = &This->IHTMLEventObj_iface; }else if(IsEqualGUID(&IID_IHTMLEventObj, riid)) { *ppv = &This->IHTMLEventObj_iface; - }else if(dispex_query_interface_no_cc(&This->dispex, riid, ppv)) { + }else if(dispex_query_interface(&This->dispex, riid, ppv)) { return *ppv ? S_OK : E_NOINTERFACE; }else { *ppv = NULL; @@ -371,7 +369,7 @@ static HRESULT WINAPI HTMLEventObj_QueryInterface(IHTMLEventObj *iface, REFIID r static ULONG WINAPI HTMLEventObj_AddRef(IHTMLEventObj *iface) { HTMLEventObj *This = impl_from_IHTMLEventObj(iface); - LONG ref = InterlockedIncrement(&This->ref); + LONG ref = dispex_ref_incr(&This->dispex); TRACE("(%p) ref=%ld\n", This, ref); @@ -381,13 +379,10 @@ static ULONG WINAPI HTMLEventObj_AddRef(IHTMLEventObj *iface) static ULONG WINAPI HTMLEventObj_Release(IHTMLEventObj *iface) { HTMLEventObj *This = impl_from_IHTMLEventObj(iface); - LONG ref = InterlockedDecrement(&This->ref); + LONG ref = dispex_ref_decr(&This->dispex); TRACE("(%p) ref=%ld\n", This, ref); - if(!ref) - release_dispex(&This->dispex); - return ref; } @@ -873,6 +868,13 @@ static inline HTMLEventObj *HTMLEventObj_from_DispatchEx(DispatchEx *iface) return CONTAINING_RECORD(iface, HTMLEventObj, dispex); } +static void HTMLEventObj_traverse(DispatchEx *dispex, nsCycleCollectionTraversalCallback *cb) +{ + HTMLEventObj *This = HTMLEventObj_from_DispatchEx(dispex); + if(This->event) + note_cc_edge((nsISupports*)&This->event->IDOMEvent_iface, "event", cb); +} + static void HTMLEventObj_unlink(DispatchEx *dispex) { HTMLEventObj *This = HTMLEventObj_from_DispatchEx(dispex); @@ -891,6 +893,7 @@ static void HTMLEventObj_destructor(DispatchEx *dispex) static const dispex_static_data_vtbl_t HTMLEventObj_dispex_vtbl = { .destructor = HTMLEventObj_destructor, + .traverse = HTMLEventObj_traverse, .unlink = HTMLEventObj_unlink }; @@ -915,7 +918,6 @@ static HTMLEventObj *alloc_event_obj(DOMEvent *event, compat_mode_t compat_mode) return NULL; event_obj->IHTMLEventObj_iface.lpVtbl = &HTMLEventObjVtbl; - event_obj->ref = 1; event_obj->event = event; if(event) IDOMEvent_AddRef(&event->IDOMEvent_iface);

1 0

Gabriel Ivăncescu : mshtml: Implement Cycle Collection for DOM Events.
by Alexandre Julliard 22 Aug '23

22 Aug '23

Module: wine Branch: master Commit: f6d9eb6712c6e0f4b25b29427f7435ade490cf8b URL: https://gitlab.winehq.org/wine/wine/-/commit/f6d9eb6712c6e0f4b25b29427f7435… Author: Gabriel Ivăncescu <gabrielopcode(a)gmail.com> Date: Tue Aug 22 16:21:48 2023 +0300 mshtml: Implement Cycle Collection for DOM Events. Signed-off-by: Gabriel Ivăncescu <gabrielopcode(a)gmail.com> --- dlls/mshtml/htmlevent.c | 73 ++++++++++++++++++++++++++++++++++++++++++++----- dlls/mshtml/htmlevent.h | 1 - 2 files changed, 66 insertions(+), 8 deletions(-) diff --git a/dlls/mshtml/htmlevent.c b/dlls/mshtml/htmlevent.c index 22fe681abda..13fa4e5b505 100644 --- a/dlls/mshtml/htmlevent.c +++ b/dlls/mshtml/htmlevent.c @@ -960,7 +960,7 @@ static HRESULT WINAPI DOMEvent_QueryInterface(IDOMEvent *iface, REFIID riid, voi *ppv = &This->IDOMEvent_iface; else if(IsEqualGUID(&IID_IDOMEvent, riid)) *ppv = &This->IDOMEvent_iface; - else if(dispex_query_interface_no_cc(&This->dispex, riid, ppv)) + else if(dispex_query_interface(&This->dispex, riid, ppv)) return *ppv ? S_OK : E_NOINTERFACE; else if(!This->query_interface || !(*ppv = This->query_interface(This, riid))) { *ppv = NULL; @@ -975,7 +975,7 @@ static HRESULT WINAPI DOMEvent_QueryInterface(IDOMEvent *iface, REFIID riid, voi static ULONG WINAPI DOMEvent_AddRef(IDOMEvent *iface) { DOMEvent *This = impl_from_IDOMEvent(iface); - LONG ref = InterlockedIncrement(&This->ref); + LONG ref = dispex_ref_incr(&This->dispex); TRACE("(%p) ref=%lu\n", This, ref); @@ -985,13 +985,10 @@ static ULONG WINAPI DOMEvent_AddRef(IDOMEvent *iface) static ULONG WINAPI DOMEvent_Release(IDOMEvent *iface) { DOMEvent *This = impl_from_IDOMEvent(iface); - LONG ref = InterlockedDecrement(&This->ref); + LONG ref = dispex_ref_decr(&This->dispex); TRACE("(%p) ref=%lu\n", This, ref); - if(!ref) - release_dispex(&This->dispex); - return ref; } @@ -1255,6 +1252,15 @@ static inline DOMEvent *DOMEvent_from_DispatchEx(DispatchEx *iface) return CONTAINING_RECORD(iface, DOMEvent, dispex); } +static void DOMEvent_traverse(DispatchEx *dispex, nsCycleCollectionTraversalCallback *cb) +{ + DOMEvent *This = DOMEvent_from_DispatchEx(dispex); + if(This->target) + note_cc_edge((nsISupports*)&This->target->IEventTarget_iface, "target", cb); + if(This->nsevent) + note_cc_edge((nsISupports*)This->nsevent, "nsevent", cb); +} + static void DOMEvent_unlink(DispatchEx *dispex) { DOMEvent *This = DOMEvent_from_DispatchEx(dispex); @@ -1421,6 +1427,14 @@ static void *DOMUIEvent_query_interface(DOMEvent *event, REFIID riid) return NULL; } +static void DOMUIEvent_traverse(DispatchEx *dispex, nsCycleCollectionTraversalCallback *cb) +{ + DOMUIEvent *This = DOMUIEvent_from_DOMEvent(DOMEvent_from_DispatchEx(dispex)); + DOMEvent_traverse(&This->event.dispex, cb); + if(This->nsevent) + note_cc_edge((nsISupports*)This->nsevent, "UIEvent.nsevent", cb); +} + static void DOMUIEvent_unlink(DispatchEx *dispex) { DOMUIEvent *This = DOMUIEvent_from_DOMEvent(DOMEvent_from_DispatchEx(dispex)); @@ -1953,6 +1967,14 @@ static void *DOMMouseEvent_query_interface(DOMEvent *event, REFIID riid) return NULL; } +static void DOMMouseEvent_traverse(DispatchEx *dispex, nsCycleCollectionTraversalCallback *cb) +{ + DOMMouseEvent *This = DOMMouseEvent_from_DOMEvent(DOMEvent_from_DispatchEx(dispex)); + DOMUIEvent_traverse(&This->ui_event.event.dispex, cb); + if(This->nsevent) + note_cc_edge((nsISupports*)This->nsevent, "MouseEvent.nsevent", cb); +} + static void DOMMouseEvent_unlink(DispatchEx *dispex) { DOMMouseEvent *This = DOMMouseEvent_from_DOMEvent(DOMEvent_from_DispatchEx(dispex)); @@ -2252,6 +2274,14 @@ static void *DOMKeyboardEvent_query_interface(DOMEvent *event, REFIID riid) return NULL; } +static void DOMKeyboardEvent_traverse(DispatchEx *dispex, nsCycleCollectionTraversalCallback *cb) +{ + DOMKeyboardEvent *This = DOMKeyboardEvent_from_DOMEvent(DOMEvent_from_DispatchEx(dispex)); + DOMUIEvent_traverse(&This->ui_event.event.dispex, cb); + if(This->nsevent) + note_cc_edge((nsISupports*)This->nsevent, "KeyboardEvent.nsevent", cb); +} + static void DOMKeyboardEvent_unlink(DispatchEx *dispex) { DOMKeyboardEvent *This = DOMKeyboardEvent_from_DOMEvent(DOMEvent_from_DispatchEx(dispex)); @@ -2460,6 +2490,13 @@ static void *DOMCustomEvent_query_interface(DOMEvent *event, REFIID riid) return NULL; } +static void DOMCustomEvent_traverse(DispatchEx *dispex, nsCycleCollectionTraversalCallback *cb) +{ + DOMCustomEvent *custom_event = DOMCustomEvent_from_DOMEvent(DOMEvent_from_DispatchEx(dispex)); + DOMEvent_traverse(&custom_event->event.dispex, cb); + traverse_variant(&custom_event->detail, "detail", cb); +} + static void DOMCustomEvent_unlink(DispatchEx *dispex) { DOMCustomEvent *custom_event = DOMCustomEvent_from_DOMEvent(DOMEvent_from_DispatchEx(dispex)); @@ -2612,6 +2649,13 @@ static void *DOMMessageEvent_query_interface(DOMEvent *event, REFIID riid) return NULL; } +static void DOMMessageEvent_traverse(DispatchEx *dispex, nsCycleCollectionTraversalCallback *cb) +{ + DOMMessageEvent *message_event = DOMMessageEvent_from_DOMEvent(DOMEvent_from_DispatchEx(dispex)); + DOMEvent_traverse(&message_event->event.dispex, cb); + traverse_variant(&message_event->data, "data", cb); +} + static void DOMMessageEvent_unlink(DispatchEx *dispex) { DOMMessageEvent *message_event = DOMMessageEvent_from_DOMEvent(DOMEvent_from_DispatchEx(dispex)); @@ -2793,6 +2837,14 @@ static void *DOMProgressEvent_query_interface(DOMEvent *event, REFIID riid) return NULL; } +static void DOMProgressEvent_traverse(DispatchEx *dispex, nsCycleCollectionTraversalCallback *cb) +{ + DOMProgressEvent *This = DOMProgressEvent_from_DOMEvent(DOMEvent_from_DispatchEx(dispex)); + DOMEvent_traverse(&This->event.dispex, cb); + if(This->nsevent) + note_cc_edge((nsISupports*)This->nsevent, "ProgressEvent.nsevent", cb); +} + static void DOMProgressEvent_unlink(DispatchEx *dispex) { DOMProgressEvent *This = DOMProgressEvent_from_DOMEvent(DOMEvent_from_DispatchEx(dispex)); @@ -2968,6 +3020,7 @@ static void DOMStorageEvent_destructor(DispatchEx *dispex) static const dispex_static_data_vtbl_t DOMEvent_dispex_vtbl = { .destructor = DOMEvent_destructor, + .traverse = DOMEvent_traverse, .unlink = DOMEvent_unlink }; @@ -2985,6 +3038,7 @@ static dispex_static_data_t DOMEvent_dispex = { static const dispex_static_data_vtbl_t DOMUIEvent_dispex_vtbl = { .destructor = DOMEvent_destructor, + .traverse = DOMUIEvent_traverse, .unlink = DOMUIEvent_unlink }; @@ -3003,6 +3057,7 @@ static dispex_static_data_t DOMUIEvent_dispex = { static const dispex_static_data_vtbl_t DOMMouseEvent_dispex_vtbl = { .destructor = DOMEvent_destructor, + .traverse = DOMMouseEvent_traverse, .unlink = DOMMouseEvent_unlink }; @@ -3022,6 +3077,7 @@ static dispex_static_data_t DOMMouseEvent_dispex = { static const dispex_static_data_vtbl_t DOMKeyboardEvent_dispex_vtbl = { .destructor = DOMEvent_destructor, + .traverse = DOMKeyboardEvent_traverse, .unlink = DOMKeyboardEvent_unlink }; @@ -3055,6 +3111,7 @@ static dispex_static_data_t DOMPageTransitionEvent_dispex = { static const dispex_static_data_vtbl_t DOMCustomEvent_dispex_vtbl = { .destructor = DOMCustomEvent_destructor, + .traverse = DOMCustomEvent_traverse, .unlink = DOMCustomEvent_unlink }; @@ -3073,6 +3130,7 @@ static dispex_static_data_t DOMCustomEvent_dispex = { static const dispex_static_data_vtbl_t DOMMessageEvent_dispex_vtbl = { .destructor = DOMMessageEvent_destructor, + .traverse = DOMMessageEvent_traverse, .unlink = DOMMessageEvent_unlink }; @@ -3091,6 +3149,7 @@ static dispex_static_data_t DOMMessageEvent_dispex = { static const dispex_static_data_vtbl_t DOMProgressEvent_dispex_vtbl = { .destructor = DOMEvent_destructor, + .traverse = DOMProgressEvent_traverse, .unlink = DOMProgressEvent_unlink }; @@ -3109,6 +3168,7 @@ static dispex_static_data_t DOMProgressEvent_dispex = { static const dispex_static_data_vtbl_t DOMStorageEvent_dispex_vtbl = { .destructor = DOMStorageEvent_destructor, + .traverse = DOMEvent_traverse, .unlink = DOMEvent_unlink }; @@ -3134,7 +3194,6 @@ static void *event_ctor(unsigned size, dispex_static_data_t *dispex_data, void * return NULL; event->IDOMEvent_iface.lpVtbl = &DOMEventVtbl; event->query_interface = query_interface; - event->ref = 1; event->event_id = event_id; if(event_id != EVENTID_LAST) { event->type = wcsdup(event_info[event_id].name); diff --git a/dlls/mshtml/htmlevent.h b/dlls/mshtml/htmlevent.h index f6c7cbc381b..cf33daa4709 100644 --- a/dlls/mshtml/htmlevent.h +++ b/dlls/mshtml/htmlevent.h @@ -76,7 +76,6 @@ typedef struct DOMEvent { DispatchEx dispex; IDOMEvent IDOMEvent_iface; - LONG ref; void *(*query_interface)(struct DOMEvent*,REFIID); nsIDOMEvent *nsevent;

1 0

Alex Henrie : activeds: Use CRT allocation functions.
by Alexandre Julliard 22 Aug '23

22 Aug '23

Module: wine Branch: master Commit: e8b8a80b3cbafded6110cd8b555d6c5daeede7c5 URL: https://gitlab.winehq.org/wine/wine/-/commit/e8b8a80b3cbafded6110cd8b555d6c… Author: Alex Henrie <alexhenrie24(a)gmail.com> Date: Mon Aug 21 21:21:56 2023 -0600 activeds: Use CRT allocation functions. --- dlls/activeds/activeds_main.c | 19 +++++-------------- dlls/activeds/pathname.c | 9 ++++----- 2 files changed, 9 insertions(+), 19 deletions(-) diff --git a/dlls/activeds/activeds_main.c b/dlls/activeds/activeds_main.c index e04485b4e36..0f13a5629b6 100644 --- a/dlls/activeds/activeds_main.c +++ b/dlls/activeds/activeds_main.c @@ -233,7 +233,7 @@ HRESULT WINAPI ADsGetLastError(LPDWORD perror, LPWSTR errorbuf, DWORD errorbufle */ LPVOID WINAPI AllocADsMem(DWORD cb) { - return HeapAlloc(GetProcessHeap(), 0, cb); + return malloc(cb); } /***************************************************** @@ -241,7 +241,8 @@ LPVOID WINAPI AllocADsMem(DWORD cb) */ BOOL WINAPI FreeADsMem(LPVOID pMem) { - return HeapFree(GetProcessHeap(), 0, pMem); + free(pMem); + return TRUE; } /***************************************************** @@ -249,7 +250,7 @@ BOOL WINAPI FreeADsMem(LPVOID pMem) */ LPVOID WINAPI ReallocADsMem(LPVOID pOldMem, DWORD cbOld, DWORD cbNew) { - return HeapReAlloc(GetProcessHeap(), 0, pOldMem, cbNew); + return realloc(pOldMem, cbNew); } /***************************************************** @@ -257,18 +258,8 @@ LPVOID WINAPI ReallocADsMem(LPVOID pOldMem, DWORD cbOld, DWORD cbNew) */ LPWSTR WINAPI AllocADsStr(LPWSTR pStr) { - LPWSTR ret; - SIZE_T len; - TRACE("(%p)\n", pStr); - - if (!pStr) return NULL; - - len = (wcslen(pStr) + 1) * sizeof(WCHAR); - ret = AllocADsMem(len); - if (ret) memcpy(ret, pStr, len); - - return ret; + return wcsdup(pStr); } /***************************************************** diff --git a/dlls/activeds/pathname.c b/dlls/activeds/pathname.c index 05db9bc8071..8142e47e244 100644 --- a/dlls/activeds/pathname.c +++ b/dlls/activeds/pathname.c @@ -28,7 +28,6 @@ #include "iads.h" #include "adserr.h" -#include "wine/heap.h" #include "wine/debug.h" WINE_DEFAULT_DEBUG_CHANNEL(activeds); @@ -84,7 +83,7 @@ static ULONG WINAPI path_Release(IADsPathname *iface) SysFreeString(path->provider); SysFreeString(path->server); SysFreeString(path->dn); - heap_free(path); + free(path); } return ref; @@ -416,7 +415,7 @@ static HRESULT Pathname_create(REFIID riid, void **obj) Pathname *path; HRESULT hr; - path = heap_alloc(sizeof(*path)); + path = malloc(sizeof(*path)); if (!path) return E_OUTOFMEMORY; path->IADsPathname_iface.lpVtbl = &IADsPathname_vtbl; @@ -489,7 +488,7 @@ static ULONG WINAPI factory_Release(IClassFactory *iface) TRACE("(%p) ref %lu\n", iface, ref); if (!ref) - heap_free(factory); + free(factory); return ref; } @@ -528,7 +527,7 @@ static HRESULT factory_constructor(const struct class_info *info, REFIID riid, v class_factory *factory; HRESULT hr; - factory = heap_alloc(sizeof(*factory)); + factory = malloc(sizeof(*factory)); if (!factory) return E_OUTOFMEMORY; factory->IClassFactory_iface.lpVtbl = &factory_vtbl;

1 0