April 2024 - Wine-commits - list.winehq.org

Henri Verbeet : vkd3d-common: Introduce vkd3d_atomic_exchange_u32().
by Alexandre Julliard 24 Apr '24

24 Apr '24

Module: vkd3d Branch: master Commit: b1c326ce564280638212d7602138ce21a6ab4ba5 URL: https://gitlab.winehq.org/wine/vkd3d/-/commit/b1c326ce564280638212d7602138c… Author: Henri Verbeet <hverbeet(a)codeweavers.com> Date: Thu Apr 18 18:59:20 2024 +0200 vkd3d-common: Introduce vkd3d_atomic_exchange_u32(). --- include/private/vkd3d_common.h | 18 ++++++++++++++++++ libs/vkd3d/resource.c | 12 ++++++------ libs/vkd3d/vkd3d_private.h | 20 -------------------- 3 files changed, 24 insertions(+), 26 deletions(-) diff --git a/include/private/vkd3d_common.h b/include/private/vkd3d_common.h index 88c563eb..3e853b06 100644 --- a/include/private/vkd3d_common.h +++ b/include/private/vkd3d_common.h @@ -442,6 +442,24 @@ static inline bool vkd3d_atomic_compare_exchange_u32(uint32_t volatile *x, uint3 #endif } +static inline uint32_t vkd3d_atomic_exchange_u32(uint32_t volatile *x, uint32_t val) +{ +#if HAVE_ATOMIC_EXCHANGE_N + return __atomic_exchange_n(x, val, __ATOMIC_SEQ_CST); +#elif defined(_WIN32) + return InterlockedExchange((LONG *)x, val); +#else + uint32_t expected; + + do + { + expected = *x; + } while (!vkd3d_atomic_compare_exchange_u32(x, expected, val)); + + return expected; +#endif +} + struct vkd3d_mutex { #ifdef _WIN32 diff --git a/libs/vkd3d/resource.c b/libs/vkd3d/resource.c index ff9721fb..e3d1661a 100644 --- a/libs/vkd3d/resource.c +++ b/libs/vkd3d/resource.c @@ -2356,10 +2356,10 @@ static void *vkd3d_desc_object_cache_get(struct vkd3d_desc_object_cache *cache) { vkd3d_atomic_decrement_u32(&cache->free_count); cache->heads[i].head = u.header->next; - vkd3d_atomic_exchange(&cache->heads[i].spinlock, 0); + vkd3d_atomic_exchange_u32(&cache->heads[i].spinlock, 0); return u.object; } - vkd3d_atomic_exchange(&cache->heads[i].spinlock, 0); + vkd3d_atomic_exchange_u32(&cache->heads[i].spinlock, 0); } /* Keeping a free count avoids uncertainty over when this loop should terminate, * which could result in excess allocations gradually increasing without limit. */ @@ -2389,7 +2389,7 @@ static void vkd3d_desc_object_cache_push(struct vkd3d_desc_object_cache *cache, head = cache->heads[i].head; u.header->next = head; cache->heads[i].head = u.object; - vkd3d_atomic_exchange(&cache->heads[i].spinlock, 0); + vkd3d_atomic_exchange_u32(&cache->heads[i].spinlock, 0); vkd3d_atomic_increment_u32(&cache->free_count); } @@ -2652,7 +2652,7 @@ void d3d12_desc_flush_vk_heap_updates_locked(struct d3d12_descriptor_heap *descr union d3d12_desc_object u; unsigned int i, next; - if ((i = vkd3d_atomic_exchange(&descriptor_heap->dirty_list_head, UINT_MAX)) == UINT_MAX) + if ((i = vkd3d_atomic_exchange_u32(&descriptor_heap->dirty_list_head, UINT_MAX)) == UINT_MAX) return; writes.null_vk_cbv_info.buffer = VK_NULL_HANDLE; @@ -2667,7 +2667,7 @@ void d3d12_desc_flush_vk_heap_updates_locked(struct d3d12_descriptor_heap *descr for (; i != UINT_MAX; i = next) { src = &descriptors[i]; - next = vkd3d_atomic_exchange(&src->next, 0); + next = vkd3d_atomic_exchange_u32(&src->next, 0); next = (int)next >> 1; /* A race exists here between updating src->next and getting the current object. The best @@ -2701,7 +2701,7 @@ static void d3d12_desc_mark_as_modified(struct d3d12_desc *dst, struct d3d12_des while (!vkd3d_atomic_compare_exchange_u32(&descriptor_heap->dirty_list_head, head, i)) { head = descriptor_heap->dirty_list_head; - vkd3d_atomic_exchange(&dst->next, (head << 1) | 1); + vkd3d_atomic_exchange_u32(&dst->next, (head << 1) | 1); } } diff --git a/libs/vkd3d/vkd3d_private.h b/libs/vkd3d/vkd3d_private.h index f9b0a093..efe049a2 100644 --- a/libs/vkd3d/vkd3d_private.h +++ b/libs/vkd3d/vkd3d_private.h @@ -204,11 +204,6 @@ union vkd3d_thread_handle void *handle; }; -static inline unsigned int vkd3d_atomic_exchange(unsigned int volatile *x, unsigned int val) -{ - return InterlockedExchange((LONG volatile *)x, val); -} - static inline void *vkd3d_atomic_exchange_pointer(void * volatile *x, void *val) { return InterlockedExchangePointer(x, val); @@ -225,26 +220,11 @@ union vkd3d_thread_handle }; # if HAVE_ATOMIC_EXCHANGE_N -static inline unsigned int vkd3d_atomic_exchange(unsigned int volatile *x, unsigned int val) -{ - return __atomic_exchange_n(x, val, __ATOMIC_SEQ_CST); -} - static inline void *vkd3d_atomic_exchange_pointer(void * volatile *x, void *val) { return __atomic_exchange_n(x, val, __ATOMIC_SEQ_CST); } # elif HAVE_SYNC_BOOL_COMPARE_AND_SWAP -static inline unsigned int vkd3d_atomic_exchange(unsigned int volatile *x, unsigned int val) -{ - unsigned int i; - do - { - i = *x; - } while (!__sync_bool_compare_and_swap(x, i, val)); - return i; -} - static inline void *vkd3d_atomic_exchange_pointer(void * volatile *x, void *val) { void *p;

1 0

Henri Verbeet : vkd3d-common: Introduce vkd3d_atomic_exchange_ptr().
by Alexandre Julliard 24 Apr '24

24 Apr '24

Module: vkd3d Branch: master Commit: af33caf036a49b2f88a9cc4f671498270ec2e3cd URL: https://gitlab.winehq.org/wine/vkd3d/-/commit/af33caf036a49b2f88a9cc4f67149… Author: Henri Verbeet <hverbeet(a)codeweavers.com> Date: Thu Apr 18 19:15:52 2024 +0200 vkd3d-common: Introduce vkd3d_atomic_exchange_ptr(). --- include/private/vkd3d_common.h | 29 +++++++++++++++++++++++++++++ libs/vkd3d/resource.c | 2 +- libs/vkd3d/vkd3d_private.h | 39 ++------------------------------------- 3 files changed, 32 insertions(+), 38 deletions(-) diff --git a/include/private/vkd3d_common.h b/include/private/vkd3d_common.h index 3e853b06..4b7da0a1 100644 --- a/include/private/vkd3d_common.h +++ b/include/private/vkd3d_common.h @@ -442,6 +442,17 @@ static inline bool vkd3d_atomic_compare_exchange_u32(uint32_t volatile *x, uint3 #endif } +static inline bool vkd3d_atomic_compare_exchange_ptr(void * volatile *x, void *expected, void *val) +{ +#if HAVE_SYNC_BOOL_COMPARE_AND_SWAP + return __sync_bool_compare_and_swap(x, expected, val); +#elif defined(_WIN32) + return InterlockedCompareExchangePointer(x, val, expected) == expected; +#else +# error "vkd3d_atomic_compare_exchange_ptr() not implemented for this platform" +#endif +} + static inline uint32_t vkd3d_atomic_exchange_u32(uint32_t volatile *x, uint32_t val) { #if HAVE_ATOMIC_EXCHANGE_N @@ -460,6 +471,24 @@ static inline uint32_t vkd3d_atomic_exchange_u32(uint32_t volatile *x, uint32_t #endif } +static inline void *vkd3d_atomic_exchange_ptr(void * volatile *x, void *val) +{ +#if HAVE_ATOMIC_EXCHANGE_N + return __atomic_exchange_n(x, val, __ATOMIC_SEQ_CST); +#elif defined(_WIN32) + return InterlockedExchangePointer(x, val); +#else + void *expected; + + do + { + expected = *x; + } while (!vkd3d_atomic_compare_exchange_ptr(x, expected, val)); + + return expected; +#endif +} + struct vkd3d_mutex { #ifdef _WIN32 diff --git a/libs/vkd3d/resource.c b/libs/vkd3d/resource.c index e3d1661a..7a2f464c 100644 --- a/libs/vkd3d/resource.c +++ b/libs/vkd3d/resource.c @@ -2473,7 +2473,7 @@ void vkd3d_view_decref(void *view, struct d3d12_device *device) static inline void d3d12_desc_replace(struct d3d12_desc *dst, void *view, struct d3d12_device *device) { - if ((view = vkd3d_atomic_exchange_pointer(&dst->s.u.object, view))) + if ((view = vkd3d_atomic_exchange_ptr(&dst->s.u.object, view))) vkd3d_view_decref(view, device); } diff --git a/libs/vkd3d/vkd3d_private.h b/libs/vkd3d/vkd3d_private.h index efe049a2..4d0c4a3c 100644 --- a/libs/vkd3d/vkd3d_private.h +++ b/libs/vkd3d/vkd3d_private.h @@ -197,49 +197,14 @@ struct vkd3d_instance unsigned int refcount; }; -#ifdef _WIN32 - -union vkd3d_thread_handle -{ - void *handle; -}; - -static inline void *vkd3d_atomic_exchange_pointer(void * volatile *x, void *val) -{ - return InterlockedExchangePointer(x, val); -} - -#else /* _WIN32 */ - -#include <pthread.h> - union vkd3d_thread_handle { +#ifndef _WIN32 pthread_t pthread; +#endif void *handle; }; -# if HAVE_ATOMIC_EXCHANGE_N -static inline void *vkd3d_atomic_exchange_pointer(void * volatile *x, void *val) -{ - return __atomic_exchange_n(x, val, __ATOMIC_SEQ_CST); -} -# elif HAVE_SYNC_BOOL_COMPARE_AND_SWAP -static inline void *vkd3d_atomic_exchange_pointer(void * volatile *x, void *val) -{ - void *p; - do - { - p = *x; - } while (!__sync_bool_compare_and_swap(x, p, val)); - return p; -} -# else -# error "vkd3d_atomic_exchange() not implemented for this platform" -# endif - -#endif /* _WIN32 */ - HRESULT vkd3d_create_thread(struct vkd3d_instance *instance, PFN_vkd3d_thread thread_main, void *data, union vkd3d_thread_handle *thread); HRESULT vkd3d_join_thread(struct vkd3d_instance *instance, union vkd3d_thread_handle *thread);

1 0

Stefan Dösinger : vkd3d: Implement vkd3d_shader_cache_put.
by Alexandre Julliard 24 Apr '24

24 Apr '24

Module: vkd3d Branch: master Commit: aad76f4ed2f6d8cfb1ea6b1578b7290b7862edc1 URL: https://gitlab.winehq.org/wine/vkd3d/-/commit/aad76f4ed2f6d8cfb1ea6b1578b72… Author: Stefan Dösinger <stefan(a)codeweavers.com> Date: Sat Dec 23 21:44:39 2023 +0300 vkd3d: Implement vkd3d_shader_cache_put. --- include/private/vkd3d_common.h | 5 ++ include/vkd3d_types.h | 2 + libs/vkd3d-common/error.c | 2 + libs/vkd3d/cache.c | 122 +++++++++++++++++++++++++++++++++++++++++ libs/vkd3d/device.c | 16 +++++- libs/vkd3d/vkd3d_private.h | 2 + 6 files changed, 146 insertions(+), 3 deletions(-) diff --git a/include/private/vkd3d_common.h b/include/private/vkd3d_common.h index 4b7da0a1..79682483 100644 --- a/include/private/vkd3d_common.h +++ b/include/private/vkd3d_common.h @@ -340,6 +340,11 @@ static inline int vkd3d_u32_compare(uint32_t x, uint32_t y) return (x > y) - (x < y); } +static inline int vkd3d_u64_compare(uint64_t x, uint64_t y) +{ + return (x > y) - (x < y); +} + #define VKD3D_BITMAP_SIZE(x) (((x) + 0x1f) >> 5) static inline bool bitmap_clear(uint32_t *map, unsigned int idx) diff --git a/include/vkd3d_types.h b/include/vkd3d_types.h index 9060fa08..18aa118f 100644 --- a/include/vkd3d_types.h +++ b/include/vkd3d_types.h @@ -53,6 +53,8 @@ enum vkd3d_result VKD3D_ERROR_INVALID_SHADER = -4, /** The operation is not implemented in this version of vkd3d. */ VKD3D_ERROR_NOT_IMPLEMENTED = -5, + /** The object or entry already exists. \since 1.12 */ + VKD3D_ERROR_KEY_ALREADY_EXISTS = -6, VKD3D_FORCE_32_BIT_ENUM(VKD3D_RESULT), }; diff --git a/libs/vkd3d-common/error.c b/libs/vkd3d-common/error.c index b8350a54..a6efedde 100644 --- a/libs/vkd3d-common/error.c +++ b/libs/vkd3d-common/error.c @@ -35,6 +35,8 @@ HRESULT hresult_from_vkd3d_result(int vkd3d_result) return E_INVALIDARG; case VKD3D_ERROR_NOT_IMPLEMENTED: return E_NOTIMPL; + case VKD3D_ERROR_KEY_ALREADY_EXISTS: + return DXGI_ERROR_ALREADY_EXISTS; default: FIXME("Unhandled vkd3d result %d.\n", vkd3d_result); return E_FAIL; diff --git a/libs/vkd3d/cache.c b/libs/vkd3d/cache.c index 56ba6990..05b717ba 100644 --- a/libs/vkd3d/cache.c +++ b/libs/vkd3d/cache.c @@ -18,11 +18,58 @@ #include "vkd3d_private.h" +struct vkd3d_cache_entry_header +{ + uint64_t hash; + uint64_t key_size; + uint64_t value_size; +}; + struct vkd3d_shader_cache { unsigned int refcount; + struct rb_tree tree; +}; + +struct shader_cache_entry +{ + struct vkd3d_cache_entry_header h; + struct rb_entry entry; + uint8_t *payload; }; +struct shader_cache_key +{ + uint64_t hash; + const void *key; + uint64_t key_size; +}; + +static int vkd3d_shader_cache_compare_key(const void *key, const struct rb_entry *entry) +{ + const struct shader_cache_entry *e = RB_ENTRY_VALUE(entry, struct shader_cache_entry, entry); + const struct shader_cache_key *k = key; + int ret; + + if ((ret = vkd3d_u64_compare(k->hash, e->h.hash))) + return ret; + if ((ret = vkd3d_u64_compare(k->key_size, e->h.key_size))) + return ret; + + /* Until now we have not seen an actual hash collision. If the key didn't match it was always + * due to a bug in the serialization code or memory corruption. If you see this FIXME please + * investigate. */ + if ((ret = memcmp(k->key, e->payload, k->key_size))) + FIXME("Actual case of a hash collision found.\n"); + return ret; +} + +static void vkd3d_shader_cache_add_entry(struct vkd3d_shader_cache *cache, + struct shader_cache_entry *e) +{ + rb_put(&cache->tree, &e->h.hash, &e->entry); +} + int vkd3d_shader_open_cache(struct vkd3d_shader_cache **cache) { struct vkd3d_shader_cache *object; @@ -34,6 +81,8 @@ int vkd3d_shader_open_cache(struct vkd3d_shader_cache **cache) return VKD3D_ERROR_OUT_OF_MEMORY; object->refcount = 1; + rb_init(&object->tree, vkd3d_shader_cache_compare_key); + *cache = object; return VKD3D_OK; @@ -46,6 +95,13 @@ unsigned int vkd3d_shader_cache_incref(struct vkd3d_shader_cache *cache) return refcount; } +static void vkd3d_shader_cache_destroy_entry(struct rb_entry *entry, void *context) +{ + struct shader_cache_entry *e = RB_ENTRY_VALUE(entry, struct shader_cache_entry, entry); + vkd3d_free(e->payload); + vkd3d_free(e); +} + unsigned int vkd3d_shader_cache_decref(struct vkd3d_shader_cache *cache) { unsigned int refcount = vkd3d_atomic_decrement_u32(&cache->refcount); @@ -54,6 +110,72 @@ unsigned int vkd3d_shader_cache_decref(struct vkd3d_shader_cache *cache) if (refcount) return refcount; + rb_destroy(&cache->tree, vkd3d_shader_cache_destroy_entry, NULL); + vkd3d_free(cache); return 0; } + +static uint64_t vkd3d_shader_cache_hash_key(const void *key, size_t size) +{ + static const uint64_t fnv_prime = 0x00000100000001b3; + uint64_t hash = 0xcbf29ce484222325; + const uint8_t *k = key; + size_t i; + + for (i = 0; i < size; ++i) + hash = (hash ^ k[i]) * fnv_prime; + + return hash; +} + +int vkd3d_shader_cache_put(struct vkd3d_shader_cache *cache, + const void *key, size_t key_size, const void *value, size_t value_size) +{ + struct shader_cache_entry *e; + struct shader_cache_key k; + struct rb_entry *entry; + enum vkd3d_result ret; + + TRACE("%p, %p, %#zx, %p, %#zx.\n", cache, key, key_size, value, value_size); + + k.hash = vkd3d_shader_cache_hash_key(key, key_size); + k.key = key; + k.key_size = key_size; + entry = rb_get(&cache->tree, &k); + e = entry ? RB_ENTRY_VALUE(entry, struct shader_cache_entry, entry) : NULL; + + if (e) + { + WARN("Key already exists, returning VKD3D_ERROR_KEY_ALREADY_EXISTS.\n"); + ret = VKD3D_ERROR_KEY_ALREADY_EXISTS; + goto done; + } + + e = vkd3d_malloc(sizeof(*e)); + if (!e) + { + ret = VKD3D_ERROR_OUT_OF_MEMORY; + goto done; + } + e->payload = vkd3d_malloc(key_size + value_size); + if (!e->payload) + { + vkd3d_free(e); + ret = VKD3D_ERROR_OUT_OF_MEMORY; + goto done; + } + + e->h.key_size = key_size; + e->h.value_size = value_size; + e->h.hash = k.hash; + memcpy(e->payload, key, key_size); + memcpy(e->payload + key_size, value, value_size); + + vkd3d_shader_cache_add_entry(cache, e); + TRACE("Cache entry %#"PRIx64" stored.\n", k.hash); + ret = VKD3D_OK; + +done: + return ret; +} diff --git a/libs/vkd3d/device.c b/libs/vkd3d/device.c index 13d354a7..fe2669b2 100644 --- a/libs/vkd3d/device.c +++ b/libs/vkd3d/device.c @@ -2694,10 +2694,20 @@ static HRESULT STDMETHODCALLTYPE d3d12_cache_session_FindValue(ID3D12ShaderCache static HRESULT STDMETHODCALLTYPE d3d12_cache_session_StoreValue(ID3D12ShaderCacheSession *iface, const void *key, UINT key_size, const void *value, UINT value_size) { - FIXME("iface %p, key %p, key_size %#x, value %p, value_size %u stub!\n", iface, key, key_size, - value, value_size); + struct d3d12_cache_session *session = impl_from_ID3D12ShaderCacheSession(iface); + enum vkd3d_result ret; - return E_NOTIMPL; + TRACE("iface %p, key %p, key_size %#x, value %p, value_size %u.\n", + iface, key, key_size, value, value_size); + + if (!key || !key_size || !value || !value_size) + { + WARN("Invalid input parameters, returning E_INVALIDARG.\n"); + return E_INVALIDARG; + } + + ret = vkd3d_shader_cache_put(session->cache, key, key_size, value, value_size); + return hresult_from_vkd3d_result(ret); } static void STDMETHODCALLTYPE d3d12_cache_session_SetDeleteOnDestroy(ID3D12ShaderCacheSession *iface) diff --git a/libs/vkd3d/vkd3d_private.h b/libs/vkd3d/vkd3d_private.h index 4d0c4a3c..63bfce7d 100644 --- a/libs/vkd3d/vkd3d_private.h +++ b/libs/vkd3d/vkd3d_private.h @@ -1776,5 +1776,7 @@ struct vkd3d_shader_cache; int vkd3d_shader_open_cache(struct vkd3d_shader_cache **cache); unsigned int vkd3d_shader_cache_incref(struct vkd3d_shader_cache *cache); unsigned int vkd3d_shader_cache_decref(struct vkd3d_shader_cache *cache); +int vkd3d_shader_cache_put(struct vkd3d_shader_cache *cache, + const void *key, size_t key_size, const void *value, size_t value_size); #endif /* __VKD3D_PRIVATE_H */

1 0

Stefan Dösinger : vkd3d: Implement vkd3d_shader_cache_get.
by Alexandre Julliard 24 Apr '24

24 Apr '24

Module: vkd3d Branch: master Commit: 71f1955cd64bcb1f61138fca2428f0a71f167d55 URL: https://gitlab.winehq.org/wine/vkd3d/-/commit/71f1955cd64bcb1f61138fca2428f… Author: Stefan Dösinger <stefan(a)codeweavers.com> Date: Fri Apr 5 17:21:53 2024 +0300 vkd3d: Implement vkd3d_shader_cache_get. --- include/vkd3d_types.h | 4 ++++ libs/vkd3d-common/error.c | 4 ++++ libs/vkd3d/cache.c | 51 ++++++++++++++++++++++++++++++++++++++++++++++ libs/vkd3d/device.c | 18 ++++++++++++++-- libs/vkd3d/vkd3d_private.h | 2 ++ 5 files changed, 77 insertions(+), 2 deletions(-) diff --git a/include/vkd3d_types.h b/include/vkd3d_types.h index 18aa118f..420dd787 100644 --- a/include/vkd3d_types.h +++ b/include/vkd3d_types.h @@ -55,6 +55,10 @@ enum vkd3d_result VKD3D_ERROR_NOT_IMPLEMENTED = -5, /** The object or entry already exists. \since 1.12 */ VKD3D_ERROR_KEY_ALREADY_EXISTS = -6, + /** The requested object was not found. \since 1.12 */ + VKD3D_ERROR_NOT_FOUND = -7, + /** The output buffer is larger than the requested object \since 1.12. */ + VKD3D_ERROR_MORE_DATA = -8, VKD3D_FORCE_32_BIT_ENUM(VKD3D_RESULT), }; diff --git a/libs/vkd3d-common/error.c b/libs/vkd3d-common/error.c index a6efedde..2f978c49 100644 --- a/libs/vkd3d-common/error.c +++ b/libs/vkd3d-common/error.c @@ -37,6 +37,10 @@ HRESULT hresult_from_vkd3d_result(int vkd3d_result) return E_NOTIMPL; case VKD3D_ERROR_KEY_ALREADY_EXISTS: return DXGI_ERROR_ALREADY_EXISTS; + case VKD3D_ERROR_NOT_FOUND: + return DXGI_ERROR_NOT_FOUND; + case VKD3D_ERROR_MORE_DATA: + return DXGI_ERROR_MORE_DATA; default: FIXME("Unhandled vkd3d result %d.\n", vkd3d_result); return E_FAIL; diff --git a/libs/vkd3d/cache.c b/libs/vkd3d/cache.c index 05b717ba..448dfc6d 100644 --- a/libs/vkd3d/cache.c +++ b/libs/vkd3d/cache.c @@ -179,3 +179,54 @@ int vkd3d_shader_cache_put(struct vkd3d_shader_cache *cache, done: return ret; } + +int vkd3d_shader_cache_get(struct vkd3d_shader_cache *cache, + const void *key, size_t key_size, void *value, size_t *value_size) +{ + struct shader_cache_entry *e; + struct shader_cache_key k; + struct rb_entry *entry; + enum vkd3d_result ret; + size_t size_in; + + TRACE("%p, %p, %#zx, %p, %p.\n", cache, key, key_size, value, value_size); + + size_in = *value_size; + + k.hash = vkd3d_shader_cache_hash_key(key, key_size); + k.key = key; + k.key_size = key_size; + entry = rb_get(&cache->tree, &k); + if (!entry) + { + WARN("Entry not found.\n"); + ret = VKD3D_ERROR_NOT_FOUND; + goto done; + } + + e = RB_ENTRY_VALUE(entry, struct shader_cache_entry, entry); + + *value_size = e->h.value_size; + if (!value) + { + TRACE("Found item %#"PRIx64", returning needed size %#"PRIx64".\n", + e->h.hash, e->h.value_size); + ret = VKD3D_OK; + goto done; + } + + if (size_in < e->h.value_size) + { + WARN("Output buffer is too small for item %#"PRIx64", got %#zx want %#"PRIx64".\n", + e->h.hash, size_in, e->h.value_size); + ret = VKD3D_ERROR_MORE_DATA; + goto done; + } + + memcpy(value, e->payload + e->h.key_size, e->h.value_size); + ret = VKD3D_OK; + TRACE("Returning cached item %#"PRIx64".\n", e->h.hash); + +done: + return ret; +} diff --git a/libs/vkd3d/device.c b/libs/vkd3d/device.c index fe2669b2..cb2b6ad0 100644 --- a/libs/vkd3d/device.c +++ b/libs/vkd3d/device.c @@ -2685,10 +2685,24 @@ static HRESULT STDMETHODCALLTYPE d3d12_cache_session_GetDevice(ID3D12ShaderCache static HRESULT STDMETHODCALLTYPE d3d12_cache_session_FindValue(ID3D12ShaderCacheSession *iface, const void *key, UINT key_size, void *value, UINT *value_size) { - FIXME("iface %p, key %p, key_size %#x, value %p, value_size %p stub!\n", + struct d3d12_cache_session *session = impl_from_ID3D12ShaderCacheSession(iface); + enum vkd3d_result ret; + size_t size; + + TRACE("iface %p, key %p, key_size %#x, value %p, value_size %p.\n", iface, key, key_size, value, value_size); - return DXGI_ERROR_NOT_FOUND; + if (!value_size) + { + WARN("value_size is NULL, returning E_INVALIDARG.\n"); + return E_INVALIDARG; + } + + size = *value_size; + ret = vkd3d_shader_cache_get(session->cache, key, key_size, value, &size); + *value_size = size; + + return hresult_from_vkd3d_result(ret); } static HRESULT STDMETHODCALLTYPE d3d12_cache_session_StoreValue(ID3D12ShaderCacheSession *iface, diff --git a/libs/vkd3d/vkd3d_private.h b/libs/vkd3d/vkd3d_private.h index 63bfce7d..84bdee92 100644 --- a/libs/vkd3d/vkd3d_private.h +++ b/libs/vkd3d/vkd3d_private.h @@ -1778,5 +1778,7 @@ unsigned int vkd3d_shader_cache_incref(struct vkd3d_shader_cache *cache); unsigned int vkd3d_shader_cache_decref(struct vkd3d_shader_cache *cache); int vkd3d_shader_cache_put(struct vkd3d_shader_cache *cache, const void *key, size_t key_size, const void *value, size_t value_size); +int vkd3d_shader_cache_get(struct vkd3d_shader_cache *cache, + const void *key, size_t key_size, void *value, size_t *value_size); #endif /* __VKD3D_PRIVATE_H */

1 0

Stefan Dösinger : vkd3d: Implement cache locking.
by Alexandre Julliard 24 Apr '24

24 Apr '24

Module: vkd3d Branch: master Commit: cb6c868460cb045d52c780092cc38e4a8a90a15b URL: https://gitlab.winehq.org/wine/vkd3d/-/commit/cb6c868460cb045d52c780092cc38… Author: Stefan Dösinger <stefan(a)codeweavers.com> Date: Sun Apr 14 21:23:10 2024 +0300 vkd3d: Implement cache locking. --- libs/vkd3d/cache.c | 22 ++++++++++++++++++++++ 1 file changed, 22 insertions(+) diff --git a/libs/vkd3d/cache.c b/libs/vkd3d/cache.c index 448dfc6d..a0a29ed3 100644 --- a/libs/vkd3d/cache.c +++ b/libs/vkd3d/cache.c @@ -28,6 +28,8 @@ struct vkd3d_cache_entry_header struct vkd3d_shader_cache { unsigned int refcount; + struct vkd3d_mutex lock; + struct rb_tree tree; }; @@ -82,6 +84,7 @@ int vkd3d_shader_open_cache(struct vkd3d_shader_cache **cache) object->refcount = 1; rb_init(&object->tree, vkd3d_shader_cache_compare_key); + vkd3d_mutex_init(&object->lock); *cache = object; @@ -111,6 +114,7 @@ unsigned int vkd3d_shader_cache_decref(struct vkd3d_shader_cache *cache) return refcount; rb_destroy(&cache->tree, vkd3d_shader_cache_destroy_entry, NULL); + vkd3d_mutex_destroy(&cache->lock); vkd3d_free(cache); return 0; @@ -129,6 +133,16 @@ static uint64_t vkd3d_shader_cache_hash_key(const void *key, size_t size) return hash; } +static void vkd3d_shader_cache_lock(struct vkd3d_shader_cache *cache) +{ + vkd3d_mutex_lock(&cache->lock); +} + +static void vkd3d_shader_cache_unlock(struct vkd3d_shader_cache *cache) +{ + vkd3d_mutex_unlock(&cache->lock); +} + int vkd3d_shader_cache_put(struct vkd3d_shader_cache *cache, const void *key, size_t key_size, const void *value, size_t value_size) { @@ -142,6 +156,9 @@ int vkd3d_shader_cache_put(struct vkd3d_shader_cache *cache, k.hash = vkd3d_shader_cache_hash_key(key, key_size); k.key = key; k.key_size = key_size; + + vkd3d_shader_cache_lock(cache); + entry = rb_get(&cache->tree, &k); e = entry ? RB_ENTRY_VALUE(entry, struct shader_cache_entry, entry) : NULL; @@ -177,6 +194,7 @@ int vkd3d_shader_cache_put(struct vkd3d_shader_cache *cache, ret = VKD3D_OK; done: + vkd3d_shader_cache_unlock(cache); return ret; } @@ -196,6 +214,9 @@ int vkd3d_shader_cache_get(struct vkd3d_shader_cache *cache, k.hash = vkd3d_shader_cache_hash_key(key, key_size); k.key = key; k.key_size = key_size; + + vkd3d_shader_cache_lock(cache); + entry = rb_get(&cache->tree, &k); if (!entry) { @@ -228,5 +249,6 @@ int vkd3d_shader_cache_get(struct vkd3d_shader_cache *cache, TRACE("Returning cached item %#"PRIx64".\n", e->h.hash); done: + vkd3d_shader_cache_unlock(cache); return ret; }

1 0

Stefan Dösinger : tests/d3d12: Add tests for storing and retrieving cache values.
by Alexandre Julliard 24 Apr '24

24 Apr '24

Module: vkd3d Branch: master Commit: 13e1491941a1af32ddfc1019fa304231fd121c4d URL: https://gitlab.winehq.org/wine/vkd3d/-/commit/13e1491941a1af32ddfc1019fa304… Author: Stefan Dösinger <stefan(a)codeweavers.com> Date: Tue Apr 9 15:10:20 2024 +0300 tests/d3d12: Add tests for storing and retrieving cache values. --- tests/d3d12.c | 162 +++++++++++++++++++++++++++++++++++++++++++++++++++++++++- 1 file changed, 161 insertions(+), 1 deletion(-)

1 0

Paul Gofman : ntdll: Remove entries from queue in RtlWakeAddressAll().
by Alexandre Julliard 24 Apr '24

24 Apr '24

Module: wine Branch: master Commit: 56d56ec6295d43ed076a327f0bae1ee8af5a0663 URL: https://gitlab.winehq.org/wine/wine/-/commit/56d56ec6295d43ed076a327f0bae1e… Author: Paul Gofman <pgofman(a)codeweavers.com> Date: Thu Sep 21 16:23:33 2023 -0600 ntdll: Remove entries from queue in RtlWakeAddressAll(). --- dlls/ntdll/sync.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/dlls/ntdll/sync.c b/dlls/ntdll/sync.c index a764d2afc09..495514a1298 100644 --- a/dlls/ntdll/sync.c +++ b/dlls/ntdll/sync.c @@ -916,8 +916,8 @@ NTSTATUS WINAPI RtlWaitOnAddress( const void *addr, const void *cmp, SIZE_T size void WINAPI RtlWakeAddressAll( const void *addr ) { struct futex_queue *queue = get_futex_queue( addr ); + struct futex_entry *entry, *next; unsigned int count = 0, i; - struct futex_entry *entry; DWORD tids[256]; TRACE("%p\n", addr); @@ -929,10 +929,12 @@ void WINAPI RtlWakeAddressAll( const void *addr ) if (!queue->queue.next) list_init(&queue->queue); - LIST_FOR_EACH_ENTRY( entry, &queue->queue, struct futex_entry, entry ) + LIST_FOR_EACH_ENTRY_SAFE( entry, next, &queue->queue, struct futex_entry, entry ) { if (entry->addr == addr) { + entry->addr = NULL; + list_remove( &entry->entry ); /* Try to buffer wakes, so that we don't make a system call while * holding a spinlock. */ if (count < ARRAY_SIZE(tids))

1 0

Paul Gofman : ntdll: Pre-check entry->addr before taking a spin lock in RtlWaitOnAddress().
by Alexandre Julliard 24 Apr '24

24 Apr '24

Module: wine Branch: master Commit: e00cbef06d8df1c5aeed3bcabc3dfe660a21fa1d URL: https://gitlab.winehq.org/wine/wine/-/commit/e00cbef06d8df1c5aeed3bcabc3dfe… Author: Paul Gofman <pgofman(a)codeweavers.com> Date: Thu Sep 21 16:29:14 2023 -0600 ntdll: Pre-check entry->addr before taking a spin lock in RtlWaitOnAddress(). --- dlls/ntdll/sync.c | 11 +++++++---- 1 file changed, 7 insertions(+), 4 deletions(-) diff --git a/dlls/ntdll/sync.c b/dlls/ntdll/sync.c index 495514a1298..efc820624bb 100644 --- a/dlls/ntdll/sync.c +++ b/dlls/ntdll/sync.c @@ -898,11 +898,14 @@ NTSTATUS WINAPI RtlWaitOnAddress( const void *addr, const void *cmp, SIZE_T size ret = NtWaitForAlertByThreadId( NULL, timeout ); - spin_lock( &queue->lock ); - /* We may have already been removed by a call to RtlWakeAddressSingle(). */ + /* We may have already been removed by a call to RtlWakeAddressSingle() or RtlWakeAddressAll(). */ if (entry.addr) - list_remove( &entry.entry ); - spin_unlock( &queue->lock ); + { + spin_lock( &queue->lock ); + if (entry.addr) + list_remove( &entry.entry ); + spin_unlock( &queue->lock ); + } TRACE("returning %#lx\n", ret);

1 0

Alexandros Frantzis : winex11.drv: Rename wgl_pixel_format to glx_pixel_format.
by Alexandre Julliard 24 Apr '24

24 Apr '24

Module: wine Branch: master Commit: 76aa8668bdc7e0f1fd8b2172def454ab68772e5d URL: https://gitlab.winehq.org/wine/wine/-/commit/76aa8668bdc7e0f1fd8b2172def454… Author: Alexandros Frantzis <alexandros.frantzis(a)collabora.com> Date: Thu Mar 14 16:15:59 2024 +0200 winex11.drv: Rename wgl_pixel_format to glx_pixel_format. We want to use wgl_pixel_format in the wgl driver API. --- dlls/winex11.drv/opengl.c | 28 ++++++++++++++-------------- 1 file changed, 14 insertions(+), 14 deletions(-) diff --git a/dlls/winex11.drv/opengl.c b/dlls/winex11.drv/opengl.c index 68c8214b835..2482a07212a 100644 --- a/dlls/winex11.drv/opengl.c +++ b/dlls/winex11.drv/opengl.c @@ -184,7 +184,7 @@ static char wglExtensions[4096]; static int glxVersion[2]; static int glx_opcode; -struct wgl_pixel_format +struct glx_pixel_format { GLXFBConfig fbconfig; XVisualInfo *visual; @@ -199,7 +199,7 @@ struct wgl_context BOOL has_been_current; BOOL sharing; BOOL gl3_context; - const struct wgl_pixel_format *fmt; + const struct glx_pixel_format *fmt; int numAttribs; /* This is needed for delaying wglCreateContextAttribsARB */ int attribList[16]; /* This is needed for delaying wglCreateContextAttribsARB */ GLXContext ctx; @@ -226,7 +226,7 @@ struct gl_drawable Window window; /* window if drawable is a GLXWindow */ Colormap colormap; /* colormap for the client window */ Pixmap pixmap; /* base pixmap if drawable is a GLXPixmap */ - const struct wgl_pixel_format *format; /* pixel format for the drawable */ + const struct glx_pixel_format *format; /* pixel format for the drawable */ SIZE pixmap_size; /* pixmap size for GLXPixmap drawables */ int swap_interval; BOOL refresh_swap_interval; @@ -236,7 +236,7 @@ struct gl_drawable struct wgl_pbuffer { struct gl_drawable *gl; - const struct wgl_pixel_format* fmt; + const struct glx_pixel_format* fmt; int width; int height; int* attribList; @@ -268,7 +268,7 @@ static XContext gl_pbuffer_context; static struct list context_list = LIST_INIT( context_list ); static struct list pbuffer_list = LIST_INIT( pbuffer_list ); -static struct wgl_pixel_format *pixel_formats; +static struct glx_pixel_format *pixel_formats; static int nb_pixel_formats, nb_onscreen_formats; static BOOL use_render_texture_emulation = TRUE; @@ -1000,7 +1000,7 @@ static BOOL check_fbconfig_bitmap_capability(Display *display, GLXFBConfig fbcon static void init_pixel_formats( Display *display ) { - struct wgl_pixel_format *list; + struct glx_pixel_format *list; int size = 0, onscreen_size = 0; int fmt_id, nCfgs, i, run, bmp_formats; GLXFBConfig* cfgs; @@ -1119,7 +1119,7 @@ static inline BOOL is_onscreen_pixel_format( int format ) return format > 0 && format <= nb_onscreen_formats; } -static inline int pixel_format_index( const struct wgl_pixel_format *format ) +static inline int pixel_format_index( const struct glx_pixel_format *format ) { return format - pixel_formats + 1; } @@ -1129,7 +1129,7 @@ static inline int pixel_format_index( const struct wgl_pixel_format *format ) * Wine's main visual and offscreen formats (if they are available). * This function converts a WGL format to its corresponding GLX one. */ -static const struct wgl_pixel_format *get_pixel_format(Display *display, int iPixelFormat, BOOL AllowOffscreen) +static const struct glx_pixel_format *get_pixel_format(Display *display, int iPixelFormat, BOOL AllowOffscreen) { /* Check if the pixelformat is valid. Note that it is legal to pass an invalid * iPixelFormat in case of probing the number of pixelformats. @@ -1308,7 +1308,7 @@ static GLXContext create_glxcontext(Display *display, struct wgl_context *contex /*********************************************************************** * create_gl_drawable */ -static struct gl_drawable *create_gl_drawable( HWND hwnd, const struct wgl_pixel_format *format, BOOL known_child, +static struct gl_drawable *create_gl_drawable( HWND hwnd, const struct glx_pixel_format *format, BOOL known_child, BOOL mutable_pf ) { struct gl_drawable *gl, *prev; @@ -1400,7 +1400,7 @@ static struct gl_drawable *create_gl_drawable( HWND hwnd, const struct wgl_pixel /*********************************************************************** * set_win_format */ -static BOOL set_win_format( HWND hwnd, const struct wgl_pixel_format *format, BOOL internal ) +static BOOL set_win_format( HWND hwnd, const struct glx_pixel_format *format, BOOL internal ) { struct gl_drawable *old, *gl; @@ -1431,7 +1431,7 @@ static BOOL set_win_format( HWND hwnd, const struct wgl_pixel_format *format, BO static BOOL set_pixel_format( HDC hdc, int format, BOOL internal ) { - const struct wgl_pixel_format *fmt; + const struct glx_pixel_format *fmt; int value; HWND hwnd = NtUserWindowFromDC( hdc ); int prev; @@ -1562,7 +1562,7 @@ static int describe_pixel_format( int iPixelFormat, PIXELFORMATDESCRIPTOR *ppfd, /*XVisualInfo *vis;*/ int value; int rb,gb,bb,ab; - const struct wgl_pixel_format *fmt; + const struct glx_pixel_format *fmt; if (!has_opengl()) return 0; @@ -2165,7 +2165,7 @@ static struct wgl_pbuffer *X11DRV_wglCreatePbufferARB( HDC hdc, int iPixelFormat const int *piAttribList ) { struct wgl_pbuffer* object; - const struct wgl_pixel_format *fmt; + const struct glx_pixel_format *fmt; int attribs[256]; int nAttribs = 0; @@ -2708,7 +2708,7 @@ static BOOL X11DRV_wglGetPixelFormatAttribivARB( HDC hdc, int iPixelFormat, int UINT nAttributes, const int *piAttributes, int *piValues ) { UINT i; - const struct wgl_pixel_format *fmt; + const struct glx_pixel_format *fmt; int hTest; int tmp; int curGLXAttr = 0;

1 0

Alexandros Frantzis : opengl32: Implement wglDescribePixelFormat using new driver API get_pixel_formats.
by Alexandre Julliard 24 Apr '24

24 Apr '24

Module: wine Branch: master Commit: 9943ab6e208112d1b98a412fc759a1a9a60807ac URL: https://gitlab.winehq.org/wine/wine/-/commit/9943ab6e208112d1b98a412fc759a1… Author: Alexandros Frantzis <alexandros.frantzis(a)collabora.com> Date: Fri Apr 19 12:55:02 2024 +0300 opengl32: Implement wglDescribePixelFormat using new driver API get_pixel_formats. Introduce a new wgl driver callback function to allow the driver to provide a complete list of all pixel formats and their attributes. If the driver provides the information use it to implement wglDescribePixelFormat. --- dlls/opengl32/make_opengl | 24 ++++++++++++++++++++++- dlls/opengl32/thunks.c | 9 --------- dlls/opengl32/unix_thunks.c | 4 ++++ dlls/opengl32/unix_wgl.c | 35 +++++++++++++++++++++++++++++++++ dlls/opengl32/unixlib.h | 11 +++++++++++ dlls/opengl32/wgl.c | 47 +++++++++++++++++++++++++++++++++++++++++++++ include/wine/wgl_driver.h | 8 +++++++- 7 files changed, 127 insertions(+), 11 deletions(-)

1 0