June 2024 - Wine-commits - list.winehq.org

Piotr Caban : ucrtbase: Fix _iobuf struct layout.
by Alexandre Julliard 12 Jun '24

12 Jun '24

Module: wine Branch: master Commit: fc8121d05fc18ca827d01767ae94072b68c9a28c URL: https://gitlab.winehq.org/wine/wine/-/commit/fc8121d05fc18ca827d01767ae9407… Author: Piotr Caban <piotr(a)codeweavers.com> Date: Tue Jun 11 19:25:37 2024 +0200 ucrtbase: Fix _iobuf struct layout. --- dlls/msvcrt/msvcrt.h | 17 +++++++++++++++++ include/msvcrt/corecrt_wstdio.h | 4 ++++ 2 files changed, 21 insertions(+) diff --git a/dlls/msvcrt/msvcrt.h b/dlls/msvcrt/msvcrt.h index dd7fb5895a0..d35412ee6b8 100644 --- a/dlls/msvcrt/msvcrt.h +++ b/dlls/msvcrt/msvcrt.h @@ -20,6 +20,23 @@ #ifndef __WINE_MSVCRT_H #define __WINE_MSVCRT_H +#if _MSVCR_VER >= 140 +#ifndef _FILE_DEFINED +#define _FILE_DEFINED +typedef struct _iobuf +{ + char* _ptr; + char* _base; + int _cnt; + int _flag; + int _file; + int _charbuf; + int _bufsiz; + char* _tmpfname; +} FILE; +#endif +#endif + #include <errno.h> #include <stdarg.h> #include <stdint.h> diff --git a/include/msvcrt/corecrt_wstdio.h b/include/msvcrt/corecrt_wstdio.h index 404f7345c8e..c5c9f180fd9 100644 --- a/include/msvcrt/corecrt_wstdio.h +++ b/include/msvcrt/corecrt_wstdio.h @@ -25,6 +25,9 @@ extern "C" { #include <pshpack8.h> typedef struct _iobuf { +#ifdef _UCRT + void *_Placeholder; +#else char* _ptr; int _cnt; char* _base; @@ -33,6 +36,7 @@ typedef struct _iobuf int _charbuf; int _bufsiz; char* _tmpfname; +#endif } FILE; #include <poppack.h> #endif /* _FILE_DEFINED */

1 0

Alexandre Julliard : tests: Use ARM64 as architecture in manifests on ARM64EC.
by Alexandre Julliard 12 Jun '24

12 Jun '24

Module: wine Branch: master Commit: bf84534793e601c8e9b397c469c5ebd447bdbd1d URL: https://gitlab.winehq.org/wine/wine/-/commit/bf84534793e601c8e9b397c469c5eb… Author: Alexandre Julliard <julliard(a)winehq.org> Date: Wed Jun 12 09:55:08 2024 +0200 tests: Use ARM64 as architecture in manifests on ARM64EC. --- dlls/comctl32/tests/v6util.h | 4 ++-- dlls/kernel32/tests/actctx.c | 4 ++-- dlls/kernel32/tests/path.c | 4 ++-- dlls/oleaut32/tests/typelib.c | 4 ++-- dlls/user32/tests/class.c | 4 ++-- dlls/user32/tests/msg.c | 4 ++-- dlls/uxtheme/tests/v6util.h | 4 ++-- dlls/vcomp/tests/vcomp.c | 4 ++-- 8 files changed, 16 insertions(+), 16 deletions(-) diff --git a/dlls/comctl32/tests/v6util.h b/dlls/comctl32/tests/v6util.h index fc32616d777..a4e928f51bf 100644 --- a/dlls/comctl32/tests/v6util.h +++ b/dlls/comctl32/tests/v6util.h @@ -22,12 +22,12 @@ #ifdef __i386__ #define ARCH "x86" +#elif defined __aarch64__ || defined__arm64ec__ +#define ARCH "arm64" #elif defined __x86_64__ #define ARCH "amd64" #elif defined __arm__ #define ARCH "arm" -#elif defined __aarch64__ -#define ARCH "arm64" #else #define ARCH "none" #endif diff --git a/dlls/kernel32/tests/actctx.c b/dlls/kernel32/tests/actctx.c index 20e5e42b620..b6f43b12f1a 100644 --- a/dlls/kernel32/tests/actctx.c +++ b/dlls/kernel32/tests/actctx.c @@ -37,12 +37,12 @@ static VOID (NTAPI *pRtlFreeUnicodeString)(PUNICODE_STRING); #ifdef __i386__ #define ARCH "x86" +#elif defined __aarch64__ || defined__arm64ec__ +#define ARCH "arm64" #elif defined __x86_64__ #define ARCH "amd64" #elif defined __arm__ #define ARCH "arm" -#elif defined __aarch64__ -#define ARCH "arm64" #else #define ARCH "none" #endif diff --git a/dlls/kernel32/tests/path.c b/dlls/kernel32/tests/path.c index 7e122780602..46eef74bce3 100644 --- a/dlls/kernel32/tests/path.c +++ b/dlls/kernel32/tests/path.c @@ -47,12 +47,12 @@ #ifdef __i386__ #define ARCH "x86" +#elif defined __aarch64__ || defined__arm64ec__ +#define ARCH "arm64" #elif defined __x86_64__ #define ARCH "amd64" #elif defined __arm__ #define ARCH "arm" -#elif defined __aarch64__ -#define ARCH "arm64" #else #define ARCH "none" #endif diff --git a/dlls/oleaut32/tests/typelib.c b/dlls/oleaut32/tests/typelib.c index eb5407f034f..153964e17d5 100644 --- a/dlls/oleaut32/tests/typelib.c +++ b/dlls/oleaut32/tests/typelib.c @@ -64,12 +64,12 @@ #ifdef __i386__ #define ARCH "x86" +#elif defined __aarch64__ || defined__arm64ec__ +#define ARCH "arm64" #elif defined __x86_64__ #define ARCH "amd64" #elif defined __arm__ #define ARCH "arm" -#elif defined __aarch64__ -#define ARCH "arm64" #else #define ARCH "none" #endif diff --git a/dlls/user32/tests/class.c b/dlls/user32/tests/class.c index 686fced55ee..03f6b0c549b 100644 --- a/dlls/user32/tests/class.c +++ b/dlls/user32/tests/class.c @@ -37,12 +37,12 @@ #ifdef __i386__ #define ARCH "x86" +#elif defined __aarch64__ || defined__arm64ec__ +#define ARCH "arm64" #elif defined __x86_64__ #define ARCH "amd64" #elif defined __arm__ #define ARCH "arm" -#elif defined __aarch64__ -#define ARCH "arm64" #else #define ARCH "none" #endif diff --git a/dlls/user32/tests/msg.c b/dlls/user32/tests/msg.c index 60067b7ab02..edfd8e5eb3f 100644 --- a/dlls/user32/tests/msg.c +++ b/dlls/user32/tests/msg.c @@ -63,12 +63,12 @@ #ifdef __i386__ #define ARCH "x86" +#elif defined __aarch64__ || defined__arm64ec__ +#define ARCH "arm64" #elif defined __x86_64__ #define ARCH "amd64" #elif defined __arm__ #define ARCH "arm" -#elif defined __aarch64__ -#define ARCH "arm64" #else #define ARCH "none" #endif diff --git a/dlls/uxtheme/tests/v6util.h b/dlls/uxtheme/tests/v6util.h index fc32616d777..a4e928f51bf 100644 --- a/dlls/uxtheme/tests/v6util.h +++ b/dlls/uxtheme/tests/v6util.h @@ -22,12 +22,12 @@ #ifdef __i386__ #define ARCH "x86" +#elif defined __aarch64__ || defined__arm64ec__ +#define ARCH "arm64" #elif defined __x86_64__ #define ARCH "amd64" #elif defined __arm__ #define ARCH "arm" -#elif defined __aarch64__ -#define ARCH "arm64" #else #define ARCH "none" #endif diff --git a/dlls/vcomp/tests/vcomp.c b/dlls/vcomp/tests/vcomp.c index 43a9cc7ce16..3542581a565 100644 --- a/dlls/vcomp/tests/vcomp.c +++ b/dlls/vcomp/tests/vcomp.c @@ -153,12 +153,12 @@ static void (CDECL *pomp_unset_nest_lock)(omp_nest_lock_t *lock); #ifdef __i386__ #define ARCH "x86" +#elif defined __aarch64__ || defined__arm64ec__ +#define ARCH "arm64" #elif defined(__x86_64__) #define ARCH "amd64" #elif defined __arm__ #define ARCH "arm" -#elif defined __aarch64__ -#define ARCH "arm64" #else #define ARCH "none" #endif

1 0

Alexandre Julliard : ntdll: Also load arm64 manifests for amd64 architecture on ARM64EC.
by Alexandre Julliard 12 Jun '24

12 Jun '24

Module: wine Branch: master Commit: 6e6450fd96f2ab3ab1535a2c0a9b0efd8e84802d URL: https://gitlab.winehq.org/wine/wine/-/commit/6e6450fd96f2ab3ab1535a2c0a9b0e… Author: Alexandre Julliard <julliard(a)winehq.org> Date: Wed Jun 12 09:55:52 2024 +0200 ntdll: Also load arm64 manifests for amd64 architecture on ARM64EC. --- dlls/ntdll/actctx.c | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/dlls/ntdll/actctx.c b/dlls/ntdll/actctx.c index 06d5b2f7937..a4581d05b91 100644 --- a/dlls/ntdll/actctx.c +++ b/dlls/ntdll/actctx.c @@ -596,12 +596,12 @@ static const xmlstr_t empty_xmlstr; #ifdef __i386__ static const WCHAR current_archW[] = L"x86"; +#elif defined __aarch64__ || defined __arm64ec__ +static const WCHAR current_archW[] = L"arm64"; #elif defined __x86_64__ static const WCHAR current_archW[] = L"amd64"; #elif defined __arm__ static const WCHAR current_archW[] = L"arm"; -#elif defined __aarch64__ -static const WCHAR current_archW[] = L"arm64"; #else static const WCHAR current_archW[] = L"none"; #endif @@ -3176,6 +3176,10 @@ static WCHAR *lookup_manifest_file( HANDLE dir, struct assembly_identity *ai ) ai->version.major, ai->version.minor, lang ); RtlInitUnicodeString( &lookup_us, lookup ); +#ifdef __arm64ec__ + if (!wcsncmp( lookup, L"amd64_", 6 )) memcpy( lookup, L"a??", 3 * sizeof(WCHAR) ); +#endif + if (!NtQueryDirectoryFile( dir, 0, NULL, NULL, &io, buffer, sizeof(buffer), FileBothDirectoryInformation, FALSE, &lookup_us, TRUE )) {

1 0

Alexandre Julliard : ntdll: Reimplement __os_arm64x_check_call in assembly.
by Alexandre Julliard 12 Jun '24

12 Jun '24

Module: wine Branch: master Commit: 93f11ad21eb1f9465122ab55e8e54e25c3c595a3 URL: https://gitlab.winehq.org/wine/wine/-/commit/93f11ad21eb1f9465122ab55e8e54e… Author: Alexandre Julliard <julliard(a)winehq.org> Date: Wed Jun 12 10:21:07 2024 +0200 ntdll: Reimplement __os_arm64x_check_call in assembly. To avoid saving a bunch of registers on every function call. --- dlls/ntdll/signal_arm64ec.c | 183 ++++++++++++++++++++++---------------------- 1 file changed, 92 insertions(+), 91 deletions(-) diff --git a/dlls/ntdll/signal_arm64ec.c b/dlls/ntdll/signal_arm64ec.c index fd1c235c546..fa73a0f512c 100644 --- a/dlls/ntdll/signal_arm64ec.c +++ b/dlls/ntdll/signal_arm64ec.c @@ -60,6 +60,7 @@ enum syscall_ids #define SYSCALL_ENTRY(id,name,args) __id_##name = id, ALL_SYSCALLS64 #undef SYSCALL_ENTRY + __nb_syscalls }; #define SYSCALL_API __attribute__((naked)) @@ -1463,7 +1464,7 @@ NTSTATUS SYSCALL_API wine_unix_to_nt_file_name( const char *name, WCHAR *buffer, SYSCALL_FUNC( wine_unix_to_nt_file_name ); } -static void * const arm64ec_syscalls[] = +void * const arm64ec_syscalls[] = { #define SYSCALL_ENTRY(id,name,args) name, ALL_SYSCALLS64 @@ -2246,98 +2247,98 @@ NTSTATUS __attribute__((naked)) __wine_unix_call_arm64ec( unixlib_handle_t handl NTSTATUS (WINAPI *__wine_unix_call_dispatcher_arm64ec)( unixlib_handle_t, unsigned int, void * ) = __wine_unix_call_arm64ec; -static int code_match( BYTE *code, const BYTE *seq, size_t len ) -{ - for ( ; len; len--, code++, seq++) if (*seq && *code != *seq) return 0; - return 1; -} - -void *check_call( void **target, void *exit_thunk, void *dest ) -{ - static const BYTE jmp_sequence[] = - { - 0xff, 0x25 /* jmp *xxx(%rip) */ - }; - static const BYTE fast_forward_sequence[] = - { - 0x48, 0x8b, 0xc4, /* mov %rsp,%rax */ - 0x48, 0x89, 0x58, 0x20, /* mov %rbx,0x20(%rax) */ - 0x55, /* push %rbp */ - 0x5d, /* pop %rbp */ - 0xe9 /* jmp arm_code */ - }; - static const BYTE syscall_sequence[] = - { - 0x4c, 0x8b, 0xd1, /* mov %rcx,%r10 */ - 0xb8, 0, 0, 0, 0, /* mov $xxx,%eax */ - 0xf6, 0x04, 0x25, 0x08, /* testb $0x1,0x7ffe0308 */ - 0x03, 0xfe, 0x7f, 0x01, - 0x75, 0x03, /* jne 1f */ - 0x0f, 0x05, /* syscall */ - 0xc3, /* ret */ - 0xcd, 0x2e, /* 1: int $0x2e */ - 0xc3 /* ret */ - }; - - for (;;) - { - if (RtlIsEcCode( (ULONG_PTR)dest )) return dest; - if (code_match( dest, jmp_sequence, sizeof(jmp_sequence) )) - { - int *off_ptr = (int *)((char *)dest + sizeof(jmp_sequence)); - void **addr_ptr = (void **)((char *)(off_ptr + 1) + *off_ptr); - dest = *addr_ptr; - continue; - } - if (!((ULONG_PTR)dest & 15)) /* fast-forward and syscall thunks are always aligned */ - { - if (code_match( dest, fast_forward_sequence, sizeof(fast_forward_sequence) )) - { - int *off_ptr = (int *)((char *)dest + sizeof(fast_forward_sequence)); - return (char *)(off_ptr + 1) + *off_ptr; - } - if (code_match( dest, syscall_sequence, sizeof(syscall_sequence) )) - { - ULONG id = ((ULONG *)dest)[1]; - if (id < ARRAY_SIZE(arm64ec_syscalls)) return arm64ec_syscalls[id]; - } - } - *target = dest; - return exit_thunk; - } -} - +/************************************************************************** + * arm64x_check_call + * + * Implementation of __os_arm64x_check_call. + */ static void __attribute__((naked)) arm64x_check_call(void) { - asm( "stp x29, x30, [sp,#-0xb0]!\n\t" - "mov x29, sp\n\t" - "stp x0, x1, [sp, #0x10]\n\t" - "stp x2, x3, [sp, #0x20]\n\t" - "stp x4, x5, [sp, #0x30]\n\t" - "stp x6, x7, [sp, #0x40]\n\t" - "stp x8, x9, [sp, #0x50]\n\t" - "stp x10, x15, [sp, #0x60]\n\t" - "stp d0, d1, [sp, #0x70]\n\t" - "stp d2, d3, [sp, #0x80]\n\t" - "stp d4, d5, [sp, #0x90]\n\t" - "stp d6, d7, [sp, #0xa0]\n\t" - "add x0, sp, #0x58\n\t" /* x9 = &target */ - "mov x1, x10\n\t" /* x10 = exit_thunk */ - "mov x2, x11\n\t" /* x11 = dest */ - "bl \"#check_call\"\n\t" - "mov x11, x0\n\t" - "ldp x0, x1, [sp, #0x10]\n\t" - "ldp x2, x3, [sp, #0x20]\n\t" - "ldp x4, x5, [sp, #0x30]\n\t" - "ldp x6, x7, [sp, #0x40]\n\t" - "ldp x8, x9, [sp, #0x50]\n\t" - "ldp x10, x15, [sp, #0x60]\n\t" - "ldp d0, d1, [sp, #0x70]\n\t" - "ldp d2, d3, [sp, #0x80]\n\t" - "ldp d4, d5, [sp, #0x90]\n\t" - "ldp d6, d7, [sp, #0xa0]\n\t" - "ldp x29, x30, [sp], #0xb0\n\t" - "ret" ); + asm( ".seh_proc \"#arm64x_check_call\"\n\t" + ".seh_endprologue\n\t" + /* check for EC code */ + "ldr x16, [x18, #0x60]\n\t" /* peb */ + "lsr x17, x11, #18\n\t" /* dest / page_size / 64 */ + "ldr x16, [x16, #0x368]\n\t" /* peb->EcCodeBitMap */ + "lsr x9, x11, #12\n\t" /* dest / page_size */ + "ldr x16, [x16, x17, lsl #3]\n\t" + "lsr x16, x16, x9\n\t" + "tbnz x16, #0, .Ldone\n\t" + /* check if dest is aligned */ + "tst x11, #15\n\t" /* dest & 15 */ + "b.ne .Ljmp\n\t" + "ldr x16, [x11]\n\t" /* dest code */ + /* check for fast-forward sequence */ + "ldr x17, .Lffwd_seq\n\t" + "cmp x16, x17\n\t" + "b.ne .Lsyscall\n\t" + "ldr x16, [x11, #8]\n\t" + "ldr x17, .Lffwd_seq + 8\n\t" + "eor x17, x16, x17\n\t" /* compare only first two bytes */ + "tst x17, #0xffff\n\t" + "b.ne .Lexit\n\t" + "add x11, x11, #14\n\t" /* address after jump */ + "lsr x9, x16, #16\n\t" + "add x11, x11, w9, sxtw\n\t" /* add offset */ + "ret\n" + /* check for syscall sequence */ + ".Lsyscall:\n\t" + "ldr w17, .Lsyscall_seq\n\t" + "cmp w16, w17\n\t" + "b.ne .Ljmp\n\t" + "ubfx x9, x16, #32, #12\n\t" /* syscall number */ + "ldr x16, [x11, #8]\n\t" + "ldr x17, .Lsyscall_seq + 8\n\t" + "cmp x16, x17\n\t" + "b.ne .Lexit\n\t" + "ldr x16, [x11, #16]\n\t" + "ldr x17, .Lsyscall_seq + 16\n\t" + "cmp x16, x17\n\t" + "b.ne .Lexit\n\t" + "cmp x9, #%0\n\t" + "b.hs .Lexit\n\t" + "adr x11, arm64ec_syscalls\n\t" + "ldr x11, [x11, x9, lsl #3]\n\t" + "ret\n" + /* check for jmp sequence */ + ".Ljmp:\n\t" + "ldrb w16, [x11]\n\t" + "cmp w16, #0xff\n\t" + "b.ne .Lexit\n\t" + "ldrb w16, [x11, #1]\n\t" + "cmp w16, #0x25\n\t" /* ff 25 jmp *xxx(%rip) */ + "b.ne .Lexit\n\t" + "ldr w9, [x11, #2]\n\t" + "add x16, x11, #6\n\t" /* address after jump */ + "ldr x11, [x16, w9, sxtw]\n\t" + "b \"#arm64x_check_call\"\n" /* restart checks with jump destination */ + /* not a special sequence, call the exit thunk */ + ".Lexit:\n\t" + "mov x9, x11\n\t" + "mov x11, x10\n\t" + ".Ldone:\n\t" + "ret\n" + ".seh_endproc\n\t" + + ".Lffwd_seq:\n\t" + ".byte 0x48, 0x8b, 0xc4\n\t" /* mov %rsp,%rax */ + ".byte 0x48, 0x89, 0x58, 0x20\n\t" /* mov %rbx,0x20(%rax) */ + ".byte 0x55\n" /* push %rbp */ + ".byte 0x5d\n\t" /* pop %rbp */ + ".byte 0xe9\n\t" /* jmp arm_code */ + ".byte 0, 0, 0, 0, 0, 0\n" + + ".Lsyscall_seq:\n\t" + ".byte 0x4c, 0x8b, 0xd1\n\t" /* mov %rcx,%r10 */ + ".byte 0xb8, 0, 0, 0, 0\n\t" /* mov $xxx,%eax */ + ".byte 0xf6, 0x04, 0x25, 0x08\n\t" /* testb $0x1,0x7ffe0308 */ + ".byte 0x03, 0xfe, 0x7f, 0x01\n\t" + ".byte 0x75, 0x03\n\t" /* jne 1f */ + ".byte 0x0f, 0x05\n\t" /* syscall */ + ".byte 0xc3\n\t" /* ret */ + ".byte 0xcd, 0x2e\n\t" /* 1: int $0x2e */ + ".byte 0xc3" /* ret */ + :: "i" (__nb_syscalls) ); }

1 0

Yuxuan Shui : tests: Pass the correct buffer size to vsnprintf() in vkd3d_test_push_context().
by Alexandre Julliard 12 Jun '24

12 Jun '24

Module: vkd3d Branch: master Commit: 8a459f59039d68c1181acf5fde86e588b6dc4242 URL: https://gitlab.winehq.org/wine/vkd3d/-/commit/8a459f59039d68c1181acf5fde86e… Author: Yuxuan Shui <yshui(a)codeweavers.com> Date: Wed May 29 17:10:45 2024 +0100 tests: Pass the correct buffer size to vsnprintf() in vkd3d_test_push_context(). --- include/private/vkd3d_test.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/include/private/vkd3d_test.h b/include/private/vkd3d_test.h index bd6bafa9..e1b9b969 100644 --- a/include/private/vkd3d_test.h +++ b/include/private/vkd3d_test.h @@ -412,7 +412,7 @@ static inline void vkd3d_test_push_context(const char *fmt, ...) { va_start(args, fmt); vsnprintf(vkd3d_test_state.context[vkd3d_test_state.context_count], - sizeof(vkd3d_test_state.context), fmt, args); + sizeof(*vkd3d_test_state.context), fmt, args); va_end(args); vkd3d_test_state.context[vkd3d_test_state.context_count][sizeof(vkd3d_test_state.context[0]) - 1] = '\0'; }

1 0

Nikolay Sivov : vkd3d-shader/fx: Set EXPLICIT_BIND_POINT flag for packoffset() reservations as well.
by Alexandre Julliard 12 Jun '24

12 Jun '24

Module: vkd3d Branch: master Commit: 402dc942599f6aa05f780fa49dc98767e562a910 URL: https://gitlab.winehq.org/wine/vkd3d/-/commit/402dc942599f6aa05f780fa49dc98… Author: Nikolay Sivov <nsivov(a)codeweavers.com> Date: Sun Jun 2 00:15:48 2024 +0200 vkd3d-shader/fx: Set EXPLICIT_BIND_POINT flag for packoffset() reservations as well. Signed-off-by: Nikolay Sivov <nsivov(a)codeweavers.com> --- libs/vkd3d-shader/fx.c | 3 +-- libs/vkd3d-shader/hlsl.h | 1 + libs/vkd3d-shader/hlsl_codegen.c | 2 ++ 3 files changed, 4 insertions(+), 2 deletions(-) diff --git a/libs/vkd3d-shader/fx.c b/libs/vkd3d-shader/fx.c index bd3bba6a..54cf1020 100644 --- a/libs/vkd3d-shader/fx.c +++ b/libs/vkd3d-shader/fx.c @@ -989,8 +989,7 @@ static void write_fx_4_numeric_variable(struct hlsl_ir_var *var, bool shared, st }; struct hlsl_ctx *ctx = fx->ctx; - /* Explicit bind point. */ - if (var->reg_reservation.reg_type) + if (var->has_explicit_bind_point) flags |= HAS_EXPLICIT_BIND_POINT; type_offset = write_type(var->data_type, fx); diff --git a/libs/vkd3d-shader/hlsl.h b/libs/vkd3d-shader/hlsl.h index 669ab551..5f6ed34f 100644 --- a/libs/vkd3d-shader/hlsl.h +++ b/libs/vkd3d-shader/hlsl.h @@ -492,6 +492,7 @@ struct hlsl_ir_var uint32_t is_param : 1; uint32_t is_separated_resource : 1; uint32_t is_synthetic : 1; + uint32_t has_explicit_bind_point : 1; }; /* This struct is used to represent assignments in state block entries: diff --git a/libs/vkd3d-shader/hlsl_codegen.c b/libs/vkd3d-shader/hlsl_codegen.c index fb108ad9..09066a61 100644 --- a/libs/vkd3d-shader/hlsl_codegen.c +++ b/libs/vkd3d-shader/hlsl_codegen.c @@ -4791,6 +4791,7 @@ static void hlsl_calculate_buffer_offset(struct hlsl_ctx *ctx, struct hlsl_ir_va if (register_reservation) { var->buffer_offset = 4 * var->reg_reservation.reg_index; + var->has_explicit_bind_point = 1; } else { @@ -4823,6 +4824,7 @@ static void hlsl_calculate_buffer_offset(struct hlsl_ctx *ctx, struct hlsl_ir_va } } var->buffer_offset = var->reg_reservation.offset_index; + var->has_explicit_bind_point = 1; } else {

1 0

Nikolay Sivov : vkd3d-shader/fx: Fix variable buffer offset value.
by Alexandre Julliard 12 Jun '24

12 Jun '24

Module: vkd3d Branch: master Commit: 222c52380bac026fca1db57c2a4c524e613f28b6 URL: https://gitlab.winehq.org/wine/vkd3d/-/commit/222c52380bac026fca1db57c2a4c5… Author: Nikolay Sivov <nsivov(a)codeweavers.com> Date: Sun Jun 2 00:23:12 2024 +0200 vkd3d-shader/fx: Fix variable buffer offset value. Signed-off-by: Nikolay Sivov <nsivov(a)codeweavers.com> --- libs/vkd3d-shader/fx.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libs/vkd3d-shader/fx.c b/libs/vkd3d-shader/fx.c index 54cf1020..3ba0a9ba 100644 --- a/libs/vkd3d-shader/fx.c +++ b/libs/vkd3d-shader/fx.c @@ -1000,7 +1000,7 @@ static void write_fx_4_numeric_variable(struct hlsl_ir_var *var, bool shared, st put_u32(buffer, type_offset); semantic_offset = put_u32(buffer, semantic_offset); /* Semantic */ - put_u32(buffer, var->buffer_offset); /* Offset in the constant buffer */ + put_u32(buffer, var->buffer_offset * 4); /* Offset in the constant buffer, in bytes. */ value_offset = put_u32(buffer, 0); /* Default value offset */ put_u32(buffer, flags); /* Flags */

1 0

Alex Henrie : ntdll/tests: Delete the WineTest registry key when the tests finish.
by Alexandre Julliard 11 Jun '24

11 Jun '24

Module: wine Branch: master Commit: 07737513148cbd2d251a1def9847ad6ed50f302b URL: https://gitlab.winehq.org/wine/wine/-/commit/07737513148cbd2d251a1def9847ad… Author: Alex Henrie <alexhenrie24(a)gmail.com> Date: Sun May 26 22:41:16 2024 -0600 ntdll/tests: Delete the WineTest registry key when the tests finish. --- dlls/ntdll/tests/reg.c | 14 +++++++++----- 1 file changed, 9 insertions(+), 5 deletions(-) diff --git a/dlls/ntdll/tests/reg.c b/dlls/ntdll/tests/reg.c index 0b61d06fdf7..4ebcdb1814d 100644 --- a/dlls/ntdll/tests/reg.c +++ b/dlls/ntdll/tests/reg.c @@ -2659,15 +2659,16 @@ static void test_NtRegLoadKeyEx(void) START_TEST(reg) { - static const WCHAR winetest[] = {'\\','W','i','n','e','T','e','s','t',0}; + LSTATUS status; + if(!InitFunctionPtrs()) return; + pRtlFormatCurrentUserKeyPath(&winetestpath); + winetestpath.MaximumLength = winetestpath.MaximumLength + sizeof(L"\\WineTest"); winetestpath.Buffer = pRtlReAllocateHeap(GetProcessHeap(), HEAP_ZERO_MEMORY, winetestpath.Buffer, - winetestpath.MaximumLength + sizeof(winetest)*sizeof(WCHAR)); - winetestpath.MaximumLength = winetestpath.MaximumLength + sizeof(winetest)*sizeof(WCHAR); - - pRtlAppendUnicodeToString(&winetestpath, winetest); + winetestpath.MaximumLength); + pRtlAppendUnicodeToString(&winetestpath, L"\\WineTest"); test_NtCreateKey(); test_NtOpenKey(); @@ -2689,6 +2690,9 @@ START_TEST(reg) test_NtRenameKey(); test_NtRegLoadKeyEx(); + status = RegDeleteTreeW(HKEY_CURRENT_USER, L"WineTest"); + ok(status == ERROR_SUCCESS, "Failed to delete the WineTest registry key: %lu\n", status); + pRtlFreeUnicodeString(&winetestpath); FreeLibrary(hntdll);

1 0

Alex Henrie : ntdll/tests: Rewrite the RtlQueryRegistryValues tests and add more of them.
by Alexandre Julliard 11 Jun '24

11 Jun '24

Module: wine Branch: master Commit: 0a5c98207de3bd5f268afd65c118269fd36cd5bd URL: https://gitlab.winehq.org/wine/wine/-/commit/0a5c98207de3bd5f268afd65c11826… Author: Alex Henrie <alexhenrie24(a)gmail.com> Date: Sun May 26 22:41:16 2024 -0600 ntdll/tests: Rewrite the RtlQueryRegistryValues tests and add more of them. The original code was very aspirational and didn't actually test much. --- dlls/ntdll/tests/reg.c | 474 ++++++++++++++++++++++++++++++++++++------------- 1 file changed, 347 insertions(+), 127 deletions(-)

1 0

Alex Henrie : ntdll: Succeed in RtlQueryRegistryValues on direct query of nonexistent value.
by Alexandre Julliard 11 Jun '24

11 Jun '24

Module: wine Branch: master Commit: bc0cd8052edb8065d50a764b23c9610627288efe URL: https://gitlab.winehq.org/wine/wine/-/commit/bc0cd8052edb8065d50a764b23c961… Author: Alex Henrie <alexhenrie24(a)gmail.com> Date: Sun May 26 22:41:16 2024 -0600 ntdll: Succeed in RtlQueryRegistryValues on direct query of nonexistent value. Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=49703 --- dlls/ntdll/reg.c | 14 ++++++++++---- dlls/ntdll/tests/reg.c | 6 +++--- 2 files changed, 13 insertions(+), 7 deletions(-) diff --git a/dlls/ntdll/reg.c b/dlls/ntdll/reg.c index 57208d5d811..4af8f5edb9b 100644 --- a/dlls/ntdll/reg.c +++ b/dlls/ntdll/reg.c @@ -242,7 +242,7 @@ NTSTATUS WINAPI RtlOpenCurrentUser( static NTSTATUS RTL_ReportRegistryValue(PKEY_VALUE_FULL_INFORMATION pInfo, PRTL_QUERY_REGISTRY_TABLE pQuery, PVOID pContext, PVOID pEnvironment) { - PUNICODE_STRING str; + PUNICODE_STRING str = pQuery->EntryContext; UNICODE_STRING src, dst; LONG *bin; ULONG offset; @@ -256,7 +256,15 @@ static NTSTATUS RTL_ReportRegistryValue(PKEY_VALUE_FULL_INFORMATION pInfo, if (pInfo == NULL) { if (pQuery->Flags & RTL_QUERY_REGISTRY_DIRECT) - return STATUS_INVALID_PARAMETER; + { + ULONG default_size = pQuery->DefaultLength; + if (!default_size && pQuery->DefaultType == REG_SZ && pQuery->DefaultData) + default_size = wcslen(pQuery->DefaultData) + 1; + if (str->MaximumLength < default_size) + return STATUS_BUFFER_TOO_SMALL; + memcpy(str->Buffer, pQuery->DefaultData, default_size); + return STATUS_SUCCESS; + } else { status = pQuery->QueryRoutine(pQuery->Name, pQuery->DefaultType, pQuery->DefaultData, @@ -268,8 +276,6 @@ static NTSTATUS RTL_ReportRegistryValue(PKEY_VALUE_FULL_INFORMATION pInfo, if (pQuery->Flags & RTL_QUERY_REGISTRY_DIRECT) { - str = pQuery->EntryContext; - switch(pInfo->Type) { case REG_EXPAND_SZ: diff --git a/dlls/ntdll/tests/reg.c b/dlls/ntdll/tests/reg.c index 7c4518bb79d..3785070c962 100644 --- a/dlls/ntdll/tests/reg.c +++ b/dlls/ntdll/tests/reg.c @@ -2726,17 +2726,17 @@ static struct query_reg_values_test query_reg_values_tests[] = { {{ NULL, RTL_QUERY_REGISTRY_DIRECT, (WCHAR*)L"I don't exist", &query_reg_values_direct_str, REG_SZ, (WCHAR*)L"Some default", 4 * sizeof(WCHAR) }}, - STATUS_SUCCESS, 0, EXPECT_DEFAULT_DATA | WINE_TODO_RET | WINE_TODO_DATA + STATUS_SUCCESS, 0, EXPECT_DEFAULT_DATA }, { {{ NULL, RTL_QUERY_REGISTRY_DIRECT, (WCHAR*)L"I don't exist", &query_reg_values_direct_str, REG_SZ, (WCHAR*)L"%SYSTEMDRIVE%" }}, - STATUS_SUCCESS, 0, EXPECT_DEFAULT_DATA | WINE_TODO_RET | WINE_TODO_DATA + STATUS_SUCCESS, 0, EXPECT_DEFAULT_DATA | WINE_TODO_DATA }, { {{ NULL, RTL_QUERY_REGISTRY_DIRECT, (WCHAR*)L"I don't exist", &query_reg_values_direct_str, REG_EXPAND_SZ, (WCHAR*)L"%SYSTEMDRIVE%" }}, - STATUS_SUCCESS, 0, WINE_TODO_RET | WINE_TODO_DATA, REG_EXPAND_SZ, L"C:" + STATUS_SUCCESS, 0, WINE_TODO_DATA, REG_EXPAND_SZ, L"C:" }, /* DIRECT with a multi-string default value crashes on Windows */ /* {

1 0