January 2002 - Wine-devel - list.winehq.org

Re: Fix for overlapped I/O using ReadFile/WriteFile
by lawson_whitney＠juno.com 27 Jan '02

27 Jan '02

On Sun, 27 Jan 2002, Tony Bryant wrote: > This patch fixes 2 problems ... > diff -r1.131 file.c > 1359c1359,1360 > < LPOVERLAPPED_COMPLETION_ROUTINE lpCompletionRoutine) > --- > > LPOVERLAPPED_COMPLETION_ROUTINE lpCompletionRoutine, Welcome to the "I didn't read the README" club. | If you add something, or fix a bug, please send a patch ('diff -u' | format preferred) to julliard(a)winehq.com or to the | wine-patches(a)winehq.com mailing list for inclusion in the next | release. | | -- | Alexandre Julliard | julliard(a)winehq.com Lawson

1 0

Re: SetEndOfFile fix
by Guy L. Albertelli 27 Jan '02

27 Jan '02

----- Original Message ----- From: "Rein Klazes" <rklazes(a)xs4all.nl> To: <wine-patches(a)winehq.com> Sent: Sunday, January 20, 2002 2:13 PM Subject: SetEndOfFile fix > hi, > > This fixes office 97 MSword error (disk full or write protected) when > saving files on a vfat partition. MSword calls SetEndOfFile() which > uses ftruncate() that, in Linux, cannot grow files in this filesystem. > > BTW. A google search shows that the ftruncate problem has been > mentioned at least 3 times on c.e.m.w. in the last 6 months Since > nobody entered a fix, I could be overlooking something... This was a great catch. It was the reason Scandisk complained about OutlookExpress's files (see my message from 1/11/2001). However your fix still fails on my outdated kernel (2.2.12-20). The attached version seems to work better on this kernel. Guy

4 5

wine debug question
by Shane Shields 27 Jan '02

27 Jan '02

hi all im trying to debug a program in wine but im not having any luck as to where the problem is. most probably due to my inexperience with wine:-P. maybe you can help. i know this program works on another wine developers computer with no problems but not on mine. attached is the output from the wine debugger and the last few lines from -debugmsg +all (the original log is 20+mb). i cant decide whether its a memory read problem or file write problem or ole problem or my problem ;-). if you want to test the program its at locutus.all.at and is called superlotto. the program is in turkish but the instructions on the web site are in english (im an aussie living in turkey). i wrote this program in vb5. ive been having this problem from cvs 26122001 and have been trying that long to debug it. if you can help me with some pointers or solutions it would be greatly appreciated. i would like to fix it myself but im stuck. thanks in advance Shane Shields To drink the WINE of success you must first seek the sayings of source ps im seeking the source but im nowhere near getting drunk ;-P

1 0

Re: Once again - this time with feeling - and no wrapping...
by Francois Gouget 27 Jan '02

27 Jan '02

On Sun, 27 Jan 2002, Tony Bryant wrote: > ? patch.diff > Index: files/file.c > =================================================================== > RCS file: /home/wine/wine/files/file.c,v > retrieving revision 1.131 > diff -r1.131 file.c > 1359c1359,1360 > < LPOVERLAPPED_COMPLETION_ROUTINE lpCompletionRoutine) > --- > > LPOVERLAPPED_COMPLETION_ROUTINE lpCompletionRoutine, > > HANDLE hCompletionEvent) Please use unified diff. It's much more readable, more robust and the recommended format for Wine patches. See: http://wine.codeweavers.com/docs/wine-devel/patches.shtml#PATCH-FORMAT -- Francois Gouget fgouget(a)free.fr http://fgouget.free.fr/ 1 + e ^ ( i * pi ) = 0

1 0

ReactOS/Mingw Patches
by Isolation 26 Jan '02

26 Jan '02

I have submitted diffs to wine-patches to build mingw/reactos. These diffs are only the makefiles and dll def's. I will working on extracting the patches need to compile in the next week. Thanks Steven

1 0

license issue: winebuild->libbfd
by clemens 26 Jan '02

26 Jan '02

hi! winebuild parses an nm symbol dump in order to get the lists of exported dll symbols from shared libraries. 1) nm isn't called with the -D option. without -D it will just dump regular symbols. this will work when winebuild is used when compiling wine, because the generated .so files will include both, regular symbols, and dynamic symbols. prepackaged wine installations will have their shared libraries stripped from any regular symbols leaving just dynamic symbols making winebuild useless on those systems. I modified tools/winebuild/import.c:read_export_symbols to call nm with the -D option. works fine for stripped shared libraries, but crashes for some reasons in the regular wine building process. 2) instead of touching ugly C parsing code and fixing the bug, i would have liked to do it the right way: utilize libbfd. the problem: libbfd is GPL. not LGPL. as far as i can see I'm unable to use libbfd from winebuild now unless winebuild would become GPL too. any hints to resolve this? clemens

1 0

Re: Tab Ctrl fix
by Dimitrie O. Paun 26 Jan '02

26 Jan '02

On Sat, 26 Jan 2002, Dimitrie O. Paun wrote: > [extracted from office2.diff] > > ChangeLog > Tab Control: forward the notification message to the parent. Oops, never mind this one, it's already in the tree. -- Dimi.

1 0

Re: int 33
by Andreas Mohr 26 Jan '02

26 Jan '02

On Sat, Jan 26, 2002 at 05:34:33PM +0200, Nog wrote: > With this patch I can get into the copy protection screen in monkey > island 2 but the keyboard still doesn't work. > > Changelog: > * dlls/winedos/int33.c > Implement function number 0x5 (Return mouse button press information) > > nog > > P.S. Does anyone know how the Mouse motion counters (function 0xb) work? >From Ralf Brown's Intlist: --------M-33000B----------------------------- INT 33 - MS MOUSE v1.0+ - READ MOTION COUNTERS AX = 000Bh Return: CX = number of mickeys mouse moved horizontally since last call DX = number of mickeys mouse moved vertically Notes: a mickey is the smallest increment the mouse can sense positive values indicate down/right SeeAlso: AX=0003h,AX=001Bh,AX=0027h -- Andreas Mohr Stauferstr. 6, D-71272 Renningen, Germany Tel. +49 7159 800604 http://home.nexgo.de/andi.mohr/

1 0

Re: int 33
by Nog 26 Jan '02

26 Jan '02

Sorry forgot the file. Nog wrote: > With this patch I can get into the copy protection screen in monkey > island 2 but the keyboard still doesn't work. > > Changelog: > * dlls/winedos/int33.c > Implement function number 0x5 (Return mouse button press > information) > > nog > > P.S. Does anyone know how the Mouse motion counters (function 0xb) work? > > > > > Index: dlls/winedos/int33.c =================================================================== RCS file: /home/wine/wine/dlls/winedos/int33.c,v retrieving revision 1.1 diff -u -r1.1 int33.c --- dlls/winedos/int33.c 2001/12/04 19:54:45 1.1 +++ dlls/winedos/int33.c 2002/01/26 15:17:29 @@ -19,6 +19,7 @@ static struct { DWORD x, y, but; + WORD lbcount, rbcount, rlastx, rlasty, llastx, llasty; FARPROC16 callback; WORD callmask; } mouse_info; @@ -52,6 +53,22 @@ case 0x04: FIXME("Position mouse cursor\n"); break; + case 0x05: + TRACE("Return Mouse button press Information for %s mouse button\n", + BX_reg(context) ? "right" : "left"); + if (BX_reg(context)) { + BX_reg(context) = mouse_info.rbcount; + mouse_info.rbcount = 0; + CX_reg(context) = mouse_info.rlastx; + DX_reg(context) = mouse_info.rlasty; + } else { + BX_reg(context) = mouse_info.lbcount; + mouse_info.lbcount = 0; + CX_reg(context) = mouse_info.llastx; + DX_reg(context) = mouse_info.llasty; + } + AX_reg(context) = mouse_info.but; + break; case 0x07: FIXME("Define horizontal mouse cursor range\n"); break; @@ -106,7 +123,8 @@ if (!VGA_GetMode(&Height,&Width,NULL)) { /* may need to do some coordinate scaling */ - SX = 640/Width; + if (Width) + SX = 640/Width; if (!SX) SX=1; } mouse_info.x = LOWORD(lParam) * SX; @@ -119,6 +137,9 @@ case WM_LBUTTONDBLCLK: mouse_info.but |= 0x01; mask |= 0x02; + mouse_info.llastx = mouse_info.x; + mouse_info.llasty = mouse_info.y; + mouse_info.lbcount++; break; case WM_LBUTTONUP: mouse_info.but &= ~0x01; @@ -128,6 +149,9 @@ case WM_RBUTTONDBLCLK: mouse_info.but |= 0x02; mask |= 0x08; + mouse_info.rlastx = mouse_info.x; + mouse_info.rlasty = mouse_info.y; + mouse_info.rbcount++; break; case WM_RBUTTONUP: mouse_info.but &= ~0x02;

1 0

Filename parsing
by Duane Clark 26 Jan '02

26 Jan '02

Modified files: dlls/commdlg : file.c Log message: Codeweavers Add SHGDN_FORPARSING flag when looking for filenames. Index: dlls/commdlg/filedlg95.c =================================================================== RCS file: /home/wine/wine/dlls/commdlg/filedlg95.c,v retrieving revision 1.62 diff -u -r1.62 filedlg95.c --- dlls/commdlg/filedlg95.c 2001/12/04 19:39:33 1.62 +++ dlls/commdlg/filedlg95.c 2002/01/26 14:54:17 @@ -2374,7 +2374,7 @@ { /* get the total length of the selected file names*/ lpstrTemp[0] = '\0'; - GetName( fodInfos->Shell.FOIShellFolder, pidl, SHGDN_INFOLDER, lpstrTemp ); + GetName( fodInfos->Shell.FOIShellFolder, pidl, SHGDN_INFOLDER|SHGDN_FORPARSING, lpstrTemp ); if ( ! IsPidlFolder(fodInfos->Shell.FOIShellFolder, pidl) ) /* Ignore folders */ { @@ -2403,7 +2403,7 @@ { /* get the file name */ lpstrTemp[0] = '\0'; - GetName( fodInfos->Shell.FOIShellFolder, pidl, SHGDN_INFOLDER, lpstrTemp ); + GetName( fodInfos->Shell.FOIShellFolder, pidl, SHGDN_INFOLDER|SHGDN_FORPARSING, lpstrTemp ); if (! IsPidlFolder(fodInfos->Shell.FOIShellFolder, pidl)) /* Ignore folders */ {

1 0