October 2003 - Wine-devel - list.winehq.org

Re: [Toolbar] Fixes for IE Favourites 'menu'
by Sylvain Petreolle 27 Oct '03

27 Oct '03

This patch makes IE work beautifully. Its much better than with the native comctl32. It also uncovers another misbehaviour in our comctl32. IE crashes because TOOLTIPS_GetTipText isnt protected against NULL read attempts. 180 if (HIWORD((UINT)toolPtr->lpszText) == 0) { Wine-dbg>p toolPtr 0x00000000 Wine-dbg>list - 170 if (oldBkMode != TRANSPARENT) 171 SetBkMode (hdc, oldBkMode); 172 } 173 174 175 static VOID 176 TOOLTIPS_GetTipText (HWND hwnd, TOOLTIPS_INFO *infoPtr, INT nTool) 177 { 178 TTTOOL_INFO *toolPtr = &infoPtr->tools[nTool]; 179 180 if (HIWORD((UINT)toolPtr->lpszText) == 0) { Wine-dbg> Quick fix attached. ===== Sylvain Petreolle (spetreolle_at_users_dot_sourceforge_dot_net) ICQ #170597259 Say NO to software patents Dites NON aux brevets logiciels "What if tomorrow the War could be over ?" Morpheus, in "Reloaded". ___________________________________________________________ Do You Yahoo!? -- Une adresse @yahoo.fr gratuite et en français ! Yahoo! Mail : http://fr.mail.yahoo.com

1 0

DMUSIC: some dmloader/dsound fixes
by Raphaël Junqueira 27 Oct '03

27 Oct '03

-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 Hi all, I'm back again :) And trying again to get Unreal2 demo working, this time with that patch the dmusic part only fail on a the CreateFile (on ILoaderStream::Attach) because we not use the specified IDirectMusicLoader8Impl::wzSearchPath. Rok, any idea how to get a proper solution for that ? dmusic log: trace:dmloader:DMLOADER_DllGetClassObject (0x4024b00f,0x4024afe8,0x408fd804) trace:dmloader:LoaderCF_CreateInstance (0x49b08458)->((nil), {19e7c08c-0a44-4e6a-a116-595a7cd5de8c},0x53c98ff4) trace:dmloader:DMUSIC_CreateDirectMusicLoader (0x1053ffb0,0x53c98ff4,(nil)) trace:dmime:DMIME_DllGetClassObject (0x4024b084,0x4024b05d,0x408fd800) trace:dmime:PerformanceCF_CreateInstance (0x49f86a18)->((nil), {679c4137-c62e-4147-b2b4-9d569acb254c},0x53c98ff8) trace:dmime:DMUSIC_CreateDirectMusicPerformance (0x1053ffa0,0x53c98ff8,(nil)) fixme:dmime:IDirectMusicPerformance8ImplInitAudio (0x403c2f90, (nil), 0x53c98ffc, (nil), 8, 128, 3f, (nil)): to check fixme:wave:IDsDriverBufferImpl_SetVolumePan (0x4e690850,0x4e690424): stub! fixme:dmime:IDirectMusicPerformance8Impl_Init (iface = 0x403c2f90, dmusic = (nil), dsound = 0x4e690020, hwnd = (nil)) trace:dmusic:DMUSIC_DllGetClassObject (0x4024b0f9,0x4024b0d2,0x408fd790) trace:dmusic:DirectMusicCF_CreateInstance (0x49b344ec)->((nil), {2d3629f7-813d-4939-8508-f05c6b75fd97},0x403c2f98) trace:dmusic:DMUSIC_CreateDirectMusic (0x49f823a4,0x403c2f98,(nil)) fixme:dmime:IDirectMusicPerformance8ImplCreateStandardAudioPath (0x403c2f90)->(8, 128, 0, 0x403c2fe8): semi-stub trace:dmime:IDirectMusicPerformance8ImplCreateStandardAudioPath returning IDirectMusicPerformance interface at 0x4e695f70. trace:dmloader:IDirectMusicLoader8Impl_SetSearchDirectory (0x403c3140, {d2ac2893-b39b-11d1-8704-00600893b1bd}, L"..\\music\\", 0) fixme:dmime:IDirectMusicPerformance8ImplGetDefaultAudioPath (0x403c2f90, 0x408fd804): semi-stub trace:dmime:IDirectMusicAudioPathImpl_AddRef (0x4e695f70) : AddRef from 1 fixme:dmime:IDirectMusicAudioPathImpl_GetObjectInPath (0x4e695f70, 0, 12800, 0, {00000000-0000-0000-0000-000000000000}, 0, {2befc277-5497-11d2-bccb-00a0c922e6eb}, 0x408fd824): stub fixme:dmime:IDirectMusicPerformance8Impl_GetGraph (0x403c2f90, 0x408fd7d0): to check fixme:dmime:IDirectMusicPerformance8Impl_SetGraph (0x403c2f90, 0x4e6963e8): to check trace:dmime:IDirectMusicGraphImpl_AddRef (0x4e6963e8) : AddRef from 1 trace:dmime:IDirectMusicGraphImpl_Release (0x4e6963e8) : ReleaseRef to 1 fixme:dmime:IDirectMusicGraphImpl_InsertTool (0x4e6963e8, 0x48691a40, (nil), 0, 0): use of pdwPChannels trace:dmime:IDirectMusicGraphImpl_Release (0x4e6963e8) : ReleaseRef to 0 trace:dmloader:IDirectMusicLoader8Impl_LoadObjectFromFile (0x403c3140, {9301e380-1f22-11d3-8226-d2fa76255d47}, {9301e386-1f22-11d3-8226-d2fa76255d47}, L"M08.con", 0x408fd2c4): wrapping to IDirectMusicLoader8Impl_GetObject trace:dmloader:IDirectMusicLoader8Impl_GetObject (0x403c3140, 0x408fcf44, {9301e386-1f22-11d3-8226-d2fa76255d47}, 0x408fd2c4) trace:dmloader:IDirectMusicLoader8Impl_GetObject looking up cache... trace:dmloader:IDirectMusicLoader8Impl_GetObject : object does not exist in cache trace:dmloader:DMLOADER_DllGetClassObject (0x4024b272,0x4024b24b,0x408fcaa0) trace:dmloader:ContainerCF_CreateInstance (0x49b08474)->((nil), {d2ac28b5-b39b-11d1-8704-00600893b1bd},0x408fcf18) trace:dmloader:DMUSIC_CreateDirectMusicContainerObject (0x49b04154,0x408fcf18, (nil)) trace:dmloader:IDirectMusicLoader8Impl_GetObject : loading from file (L"M08.con") trace:dmloader:DMUSIC_CreateLoaderStream (0x408fcefc) trace:dmloader:ILoaderStream_Attach (0x4e696490, L"M08.con", 0x403c3140) trace:dmloader:ILoaderStream_Attach : failed trace:dmime:IDirectMusicPerformance8Impl_SetGlobalParam (0x403c2f90, {d2ac28b1-b39b-11d1-8704-00600893b1bd}, 0x408fd878, 4) trace:dmime:IDirectMusicPerformance8Impl_SetGlobalParam => MasterVolume set to - -10000 fixme:seh:EXC_RtlRaiseException call to unimplemented function ntdll.dll.RtlCreateQueryDebugBuffer Changelog: - some fixes on DirectSound init (need SetCooperativeLevel as seen in msdn) on IDirectMusicPerformance8::InitAudio - some logic fixes on IDirectMusicPerformance8ImplCreateStandardAudioPath (not perfect yet, need to understand/fix the channel init/use) - fix typo on CreateDirectMusicContainer - add missing define on dsound.h - better traces on IDirectMusicLoader8::SetSearchDirectory Best Regards, Raphael -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.2.3 (GNU/Linux) iD8DBQE/nGOcp7NA3AmQTU4RAphDAJ94meGfa5FK6hO0F5cBaChRZH9PjwCgi7m3 Q7VsDoxbAzA0pog7e2KH0T0= =2OfH -----END PGP SIGNATURE-----

1 0

Re: Fix tab size (3) take 2
by Vitaliy Margolen 26 Oct '03

26 Oct '03

This time with more fixes and tests. Experimenting with tab control I found this differences between MSDN and actual implementation: - TCS_OWNERDRAWFIXED style has nothing to do with fixed with tabs. It should me named TCS_OWNERDRAW instead. Unless there is some apps that think otherwise, this should work (tested on eMule and test program). In other words, this quote from MSDN is not true: "Because all tabs in an owner-drawn tab control are the same size..." - It looks like there is not such thing as not set tab width. According to this: "To give all tabs the same width, you can specify the TCS_FIXEDWIDTH style. The control sizes all the tabs to fit the widest label, or you can assign a specific width and height by using the TCM_SETITEMSIZE message." one can assume that if tab width is not explicitly set with TCM_SETITEMSIZE message "The control sizes all the tabs to fit the widest label". Not true. Native uses default tab size of 96. - The minimum size of a tab is at least icon width + 4 if icon is present. - Prior observation that "under Windows, there seems to be a minimum width of 2x the height for button style tabs" is not true. Vitaliy Margolen changelog: - Fix tab size for TCS_OWNERDRAWFIXED style - Correct size recalculation after setting tab width - Fix button sizes to match native. - Center both vertically and horizontally tab text & icon - Use correct left/center alignment flags to-do (currently working on): - Correct text & icon position within each tab/button to match native - Fix hot-track - Correct tab sizes for vertical styles

1 0

Re: wave device name patch
by Sylvain Petreolle 26 Oct '03

26 Oct '03

Hi Robert, your winmm patch seems to need a winnls.h include to compile (it defines CP_ACP.) I actually get : make[2]: Entre dans le répertoire `/home/wine/dlls/winmm/winealsa' gcc -c -I. -I. -I../../../include -I../../../include -D__WINESRC__ -D_REENTRANT -fPIC -Wall -mpreferred-stack-boundary=2 -fno-strict-aliasing -gstabs+ -Wpointer-arith -g -O2 -o audio.o audio.c audio.c: Dans la fonction « wodDevInterface »: audio.c:1614: structure n'a pas de membre nommé « dev_name » audio.c:1617: AVERTISSEMENT: déclaration implicite de la fonction « MultiByteToWideChar » audio.c:1617: « CP_ACP » non déclaré (première utilisation dans cette fonction) audio.c:1617: (Chaque identificateur non déclaré est rapporté une seule fois audio.c:1617: pour chaque fonction dans laquelle il apparaît.) audio.c:1617: structure n'a pas de membre nommé « dev_name » make[2]: *** [audio.o] Erreur 1 Looking into wineoss '#include's, I dont see which header includes winnls.h. None of the includes unique to each one dont seem to import winnls.h : [syl(a)wine winmm]$ grep -h include wineoss/audio.c winealsa/audio.c |sort -k 2 | uniq -u #include "alsa.h" # include <sys/poll.h> #include <limits.h> #include "oss.h" #include "wine/library.h" #include "wine/winuser16.h" #include "winuser.h" ===== Sylvain Petreolle (spetreolle_at_users_dot_sourceforge_dot_net) ICQ #170597259 Say NO to software patents Dites NON aux brevets logiciels "What if tomorrow the War could be over ?" Morpheus, in "Reloaded". ___________________________________________________________ Do You Yahoo!? -- Une adresse @yahoo.fr gratuite et en français ! Yahoo! Mail : http://fr.mail.yahoo.com

2 3

WineConf 2004
by Tom 26 Oct '03

26 Oct '03

Hello, I think we should have a nice page on winehq about WineConf 2004. And include the date? (still waiting to buy my airfair), location, attendies, speakers :-) with subject, I am verrrrrrrrrrrrry #$#%$# (-) #$%% excited about WineConf 2004!, even tho ive been very quiet about it... I personally think 04 could be the year for wine.. a .9 release and who the heck knows maybe even a 1.0 by 04 years end........ And this Conf will give us all the chance to discuss the road ahead.. The future of wine for the next 12 to 18 months....(untill the next Conf)...... So I take this Conf very seriouse.. So can we start working on a page to post on winehq about this event??? Jer, do you have a page in the works????? If not, I think we should start one ASAP.. So attendies will have the chance to volunteer to do a talk on a subject of there choice.. We also need to archive these talks so we can post them in a audio/video format so others can enjoy there content as we will........ Comments/suggestions about this?? Tom

3 2

Re: Get Back Relay Debugging for NTDLL and Kernel32
by Dimitrie O. Paun 26 Oct '03

26 Oct '03

On October 26, 2003 11:48 am, Uwe Bonnes wrote: > + if (TRACE_ON(relay)) > + { Not yet another formatting style, please... -- Dimi.

1 0

Janitorial: Another possible strlenW missuse
by Uwe Bonnes 26 Oct '03

26 Oct '03

Hallo, wine/tools/wrc/y.tab.c countains: WCHAR *wptr; /* Remove escaped backslash and convert to forward */ for(wptr = str->str.wstr; (wptr = strchrW(wptr, '\\')) != NULL; wptr++) if(wptr[1] == '\\') { memmove(wptr, wptr+1, strlenW(wptr)); str->size--; } I am quite sure that strlenW returns the number of characters in the string and so it needs to be multiplied by sizeof(WCHAR). Can anybody confirm? Bye -- Uwe Bonnes bon(a)elektron.ikp.physik.tu-darmstadt.de Institut fuer Kernphysik Schlossgartenstrasse 9 64289 Darmstadt --------- Tel. 06151 162516 -------- Fax. 06151 164321 ----------

1 0

wine-20031016:err:dinput:SysMouseAImpl_Unacquire Unacquiring a not-acquired device !!!
by Pavel S. Khmelinsky 26 Oct '03

26 Oct '03

Hi! I try to play some DX game. It's started but mouse not work with this message: err:dinput:SysMouseAImpl_Unacquire Unacquiring a not-acquired device !!! I try to play with DXGrab, Managed, Desktop parameters but nothing help. Also I try to run games in Windowed and Fullscreen modes with the same result. May be you can give some advice for workaround. I try to look in dlls/dinput/mouse/main.c but can't understand it. Thanx and sorry for my English.

1 0

Relay Debugging NTDLL/Kernel32
by Uwe Bonnes 26 Oct '03

26 Oct '03

Hallo, current reordering of the wine initialisation process has made relay traces for ntdll and kernel vanish. What are chances and priority to bring that feature back? An what are chances to keep the --debugmsg option on the commandline with the nescessary changes? Bye -- Uwe Bonnes bon(a)elektron.ikp.physik.tu-darmstadt.de Institut fuer Kernphysik Schlossgartenstrasse 9 64289 Darmstadt --------- Tel. 06151 162516 -------- Fax. 06151 164321 ----------

1 0

Bug handling mouse in x11drv
by Carlos Lozano 26 Oct '03

26 Oct '03

Hello, Does anyone know why "update_key_state" is called in the mouse related functions: GetCursorPos, SetCursorPos, ButtonPress, ButtonRelease, MotionNotify and EnterNotify?? In gnome (+metacity), i use the key shift+left or shift+right to change of desktop. Then for example using WinMX, with the search input selected and writing in it, if i type shift+right then it will go the right desktop, when i press later shift+left, it goes back to the original desktop (where the winmx window is), but now every letter what i type, will be uppercase (even when shift is disabled). update_key_state does: static void update_key_state( unsigned int state ) { pKeyStateTable[VK_SHIFT] = (state & ShiftMask ? 0x80 : 0); pKeyStateTable[VK_CONTROL] = (state & ControlMask ? 0x80 : 0); } Removing the VK_SHIFT line, the problem is fixed, but i think that this function should be removed, except that someone knows why this 2 keys/states must be updated here (in mouse functions) :/ Regards, Carlos. -- ___ _ \ | / Consulting | . |._ _ _| | ___ ___ ___ http://www.andago.com | || ' |/ . |<_> |/ . |/ . \__ GNU/Linux |_|_||_|_|\___|<___|\_. |\___/ _ \ __|\ \ / Carlos A. Lozano <___'/ | \ -_) __/\__ \ > < -_) [ carlos.lozano(a)andago.com ]\___|_| ____/ _/\_\___| [ calb(a)epsxe.com ] http://www.ePSXe.com

1 0