January 2005 - Wine-devel - list.winehq.org

DIB direct drawing - Bug 412: Implementing a DIB engine
by Alejandro Bonet 15 Jan '05

15 Jan '05

Well, i'm a novice here (in wine and linux), but i think i could help with this task. I'm a good windows application developer (www.babel7.com) and i wrote two programs with some of the semantics you are looking for: painting over BMPs (or better DIBs). The 2 programs are for 256 colors and true RGB. They write on file BMPs. The painting functions were written to generate pie graphs, poligonals, rectangles, and so on, but they can be readapted to write on DIBs in memory. The sintax help (comm line wo parms) is in Spanish, but i will not ask for excuses for it. The use is very simple. I will rewrite an english sintax help if i begin with the task. You can download it and test if i could help. If yes, i will begin with the task... And time will say!! http://www.babel7.com/bmps.zip Regards... Aljandro Bonet Babel Informatica SL Madrid alex(a)winbabel.org

1 0

Re: PSAPI: stub implementations (#2)
by Rob Shearman 15 Jan '05

15 Jan '05

Hans Leidekker wrote: >Call SetLastError() on failure, as suggested by Juan Lang. > > -Hans > >Changelog: > Stub implementations for EnumPageFiles{A,W}, GetProcessImageFileName{A,W}. > Implement GetPerformanceInfo, GetProcessMemoryInfo on top of > NtQueryInformationProcess and GetWsChanges, QueryWorkingSet{,Ex} on top > of NtQueryVirtualMemory. > > >------------------------------------------------------------------------ > >@@ -443,15 +461,85 @@ > } > > /*********************************************************************** >+ * GetPerformanceInfo (PSAPI.@) >+ */ >+BOOL WINAPI GetPerformanceInfo( PPERFORMANCE_INFORMATION info, DWORD size ) >+{ >+ NTSTATUS status; >+ >+ TRACE( "(%p, %ld)\n", info, size ); >+ >+ if (size < sizeof(PERFORMANCE_INFORMATION)) >+ { >+ SetLastError( ERROR_INSUFFICIENT_BUFFER ); >+ return FALSE; >+ } >+ > > This check is redundant. All NtQueryInformation* functions check the buffer size for you. >+ status = NtQueryInformationProcess( GetCurrentProcess(), SystemPerformanceInformation, info, size, NULL ); >+ >+ if (status) >+ { >+ SetLastError( RtlNtStatusToDosError( status )); >+ return FALSE >+ } >+ return FALSE; >+} > > >@@ -459,14 +547,25 @@ > /*********************************************************************** > * GetWsChanges (PSAPI.@) > */ >-BOOL WINAPI GetWsChanges(HANDLE hProcess, >- PPSAPI_WS_WATCH_INFORMATION lpWatchInfo, DWORD cb) >+BOOL WINAPI GetWsChanges( HANDLE process, PPSAPI_WS_WATCH_INFORMATION watchinfo, DWORD size ) > { >- FIXME("(hProcess=%p, %p, %ld): stub\n", >- hProcess, lpWatchInfo, cb); >+ NTSTATUS status; >+ >+ TRACE( "(%p, %p, %ld)\n", process, watchinfo, size ); >+ >+ if (size < sizeof(PSAPI_WS_WATCH_INFORMATION)) >+ { >+ SetLastError( ERROR_INSUFFICIENT_BUFFER ); >+ return FALSE; >+ } > > So is this. > >- memset(lpWatchInfo, 0, cb); >+ status = NtQueryVirtualMemory( process, NULL, ProcessWorkingSetWatch, watchinfo, size, NULL ); > >+ if (status) >+ { >+ SetLastError( RtlNtStatusToDosError( status )); >+ return FALSE >+ } > return TRUE; > } > > > Could you also make sure that the NtDll functions that you are calling give out a useful fixme message when called from these functions? At the moment you are mostly replacing some good fixme messages with bad fixme messages. Rob

1 0

Re: PSAPI: stub implementations
by Juan Lang 15 Jan '05

15 Jan '05

Hi Hans, + status = NtQueryInformationProcess( GetCurrentProcess(), SystemPerformanceInformation, info, size, NULL ); + if (status != STATUS_SUCCESS) return FALSE; without a test case I don't know for sure, but it seems likely you should do the something like following on failure: if (status) { SetLastError( RtlNtStatusToDosError( status )); return FALSE; } You might take a look at how advapi32's security.c does it. --Juan __________________________________ Do you Yahoo!? Meet the all-new My Yahoo! - Try it today! http://my.yahoo.com

1 0

Re: WineHQ:winetest: produce valid HTML
by Dimitrie O. Paun 15 Jan '05

15 Jan '05

On Wed, Jan 12, 2005 at 05:29:18PM +0100, Ferenc Wagner wrote: > ChangeLog: * Generate valid HTML 4.01 Strict. > * Underline vis_note class links, too. Cool stuff Feri. Anyone knows what happened to the tests? The last one at http://test.winehq.org/data/ is 2004-12-28. Also, the last tests build at SF is winetest-200409111000 which is a bit outdated :) What gives? -- Dimi.

8 20

file associations in wine
by Rainer Haake 15 Jan '05

15 Jan '05

hi there first of all, please excuse my poor english... I know I can associate a file extension in wine with a linux application like i did for .sxw in this .reg-file: REGEDIT4 [HKEY_CLASSES_ROOT\.sxw] @="sxw.document" [HKEY_CLASSES_ROOT\sxw.document] @="sxw.document" [HKEY_CLASSES_ROOT\sxw.document\shell] [HKEY_CLASSES_ROOT\sxw.document\shell\open] [HKEY_CLASSES_ROOT\sxw.document\shell\open\command] @="C:\\windows\\command\\start.exe kdestart.exe \"%1\"" where kdestart.exe is a link to the following script: #!/bin/bash i=`winepath -u "$*"` kfmclient exec "$i" so now sxw-files open in OpenOffice like I wanted. But now I would like to have a file association to each filetype unknown to wine, so that all these files will be openend with the corresponding KDE programs. I tried: [HKEY_CLASSES_ROOT\*] [HKEY_CLASSES_ROOT\*\shell] [HKEY_CLASSES_ROOT\*\shell\open] [HKEY_CLASSES_ROOT\*\shell\open\command] @="C:\\windows\\command\\start.exe kdestart.exe \"%1\"" because i thought that would be the default file association, but it doesn't work... Is this possible? It would be a great step for the integration of wine with KDE (or GNOME, because a similar script could be developed) thanks for any help Rainer

1 0

Sharing files between users
by Vitaly Lipatov 14 Jan '05

14 Jan '05

I am looking for any resolve a problem with sharing open files. When one user calls CreateFile with sharing=FILE_SHARE_READ, other user can open the same file with sharing=FILE_SHARE_WRITE wthout any fails. I know sharing control done in wine-server, but it resolves problem only when single user sharing files, not two or more. I guess to move sharing support in kernel in some way. Any suggestions? -- Vitaly Lipatov, ALT Linux Team Russia, Saint-Petersburg, www.etersoft.ru

1 0

Re: Janitorial : add missing declarations ( #3 )
by Dmitry Timoshkov 14 Jan '05

14 Jan '05

"Rémi Assailly" <remi.assailly(a)free.fr> wrote: > diff -u dlls/x11drv/x11drv_main.c dlls/x11drv/x11drv_main.c > --- dlls/x11drv/x11drv_main.c 2004-12-08 18:27:53.000000000 +0100 > +++ dlls/x11drv/x11drv_main.c 2005-01-12 21:23:02.000000000 +0100 > @@ -119,6 +119,8 @@ > #define IS_OPTION_FALSE(ch) \ > ((ch) == 'n' || (ch) == 'N' || (ch) == 'f' || (ch) == 'F' || (ch) == '0') > > +BOOL WINAPI DllMain( HINSTANCE hinst, DWORD reason, LPVOID reserved ); This one should not be needed. -- Dmitry.

2 1

WineConf 2005
by Brian Vincent 14 Jan '05

14 Jan '05

WINECONF 2005 GOES TO EUROPE! We have a tentative reservation for Wineconf and we'd like some feedback regarding dates and times: WHERE: Stuttgart, Germany WHEN: April 30 / May 1st (plan on arriving April 29th) We realize it's not possible to accomodate everyone's schedule, but these dates seem to work nicely for a lot of people. In addition, SambaXP will be held May 2nd and 3rd near the area, so this event may attract some other folks interested in this stuff. Can anyone foresee any glaring problems with the location and dates? Otherwise, we'll move forward with firming up the plans and send an official announcement later in the week. -Brian

2 1

Re: Add WM_GETOBJECT definition, remove WM_OTHERWINDOWCREATED define
by Robert North 14 Jan '05

14 Jan '05

Dmitry Timoshkov dmitry-at-baikal.ru |Wine Mailing Lists| wrote: > Hello, > > Platform SDK defines WM_GETOBJECT as 0x003d and doesn't have a > message with value 0x003c at all. WM_GETOBJECT is used by Active > Accessibility to retrieve an interface pointer from a window. > > Changelog: Dmitry Timoshkov <dmitry(a)codeweavers.com> Add WM_GETOBJECT > definition, remove WM_OTHERWINDOWCREATED define. > > diff -up cvs/hq/wine/include/winuser.h wine/include/winuser.h --- > cvs/hq/wine/include/winuser.h 2005-01-10 13:55:58.000000000 +0800 +++ > wine/include/winuser.h 2005-01-14 16:23:38.000000000 +0800 @@ -985,8 > +985,8 @@ BOOL WINAPI SetSysColors(INT,cons #define > WM_COMPAREITEM 0x0039 #define WM_TESTING 0x003a > > > -#define WM_OTHERWINDOWCREATED 0x003c -#define > WM_OTHERWINDOWDESTROYED 0x003d I thought this removal looked a bit suspicious... So, I did a quick google for WM_OTHERWINDOWCREATED , and there seems to be a consensus that these two messages are defined as follows: WM_OTHERWINDOWCREATED 0x00000042 WM_OTHERWINDOWDESTROYED 0x00000043 What do you think? Should google be trusted? P.S. If yo do the google search, there's a link to a Russian windows internals book that may shed further light on these methods. Bye -Rob.

2 1

Re: advpack: add two missing stubs
by Robert Reif 14 Jan '05

14 Jan '05

Robert Reif wrote: > Add stubs for NeedReboot and NeedRebootInit. > without FIXME bug Index: dlls/advpack/advpack.c =================================================================== RCS file: /home/wine/wine/dlls/advpack/advpack.c,v retrieving revision 1.6 diff -u -r1.6 advpack.c --- dlls/advpack/advpack.c 15 Dec 2004 10:52:57 -0000 1.6 +++ dlls/advpack/advpack.c 11 Jan 2005 00:57:39 -0000 @@ -96,3 +96,28 @@ return ret; } + +/*********************************************************************** + * NeedRebootInit (ADVPACK.@) + */ +DWORD WINAPI NeedRebootInit(VOID) +{ + FIXME("() stub!\n"); + + SetLastError(ERROR_CALL_NOT_IMPLEMENTED); + + return 0; +} + +/*********************************************************************** + * NeedReboot (ADVPACK.@) + */ + +BOOL WINAPI NeedReboot(DWORD dwRebootCheck) +{ + FIXME("(0x%08lx) stub!\n", dwRebootCheck); + + SetLastError(ERROR_CALL_NOT_IMPLEMENTED); + + return FALSE; +} Index: dlls/advpack/advpack.spec =================================================================== RCS file: /home/wine/wine/dlls/advpack/advpack.spec,v retrieving revision 1.4 diff -u -r1.4 advpack.spec --- dlls/advpack/advpack.spec 15 Dec 2004 10:52:57 -0000 1.4 +++ dlls/advpack/advpack.spec 11 Jan 2005 00:57:39 -0000 @@ -15,8 +15,8 @@ @ stub IsNTAdmin @ stdcall LaunchINFSection(ptr ptr str long) @ stdcall LaunchINFSectionEx(ptr ptr str long) -@ stub NeedReboot -@ stub NeedRebootInit +@ stdcall NeedReboot(long) +@ stdcall NeedRebootInit() @ stub OpenINFEngine @ stub RebootCheckOnInstall @ stdcall RegInstall(ptr str ptr)

4 7