January 2005 - Wine-devel - list.winehq.org

Best DLLs to write conformance tests for?
by Dan Kegel 13 Jan '05

13 Jan '05

Recently, I helped a student at Harvey Mudd college write and submit a conformance test for the lzexpand dll: http://www.winehq.com/hypermail/wine-cvs/2004/11/0164.html I picked lzexpand.dll since (lacking a GUI) it seemed simple to test. Now I'm putting together a reusable lab project for other colleges, at http://kegel.com/wine/sweng, and am trying to pick a few good DLLs for the students to write tests for. (I plan ask the students to send me their patches so I can review them before they post them on wine-patches.) Clearly, I shouldn't ask anyone to write a conformance test for a huge DLL in a term, so I guess I'll focus on on the DLLs with under 100 functions. And I'd like to skip DLLs that have GUIs, so I guess I'll omit any where the word HWND occurs. That leaves the following 53 DLLs or VxDs: amstream atl cabinet capi2032 cards cfgmgr32 comcat crypt32 d3dx8 d3dxof dbghelp devenum dinput8 dmband dmcompos dmscript dmsynth dmusic32 dplayx dpnet dpnhpast dswave dxdiagn dxerr8 dxerr9 glu32 iccvid icmp ifsmgr.vxd imagehlp itss mmdevldr.vxd monodebg.vxd msdmo mshtml msimg32 msisys msnet32 msvidc32 mswsock olepro32 olesvr qcap secur32 vdhcp.vxd vmm.vxd vnbt.vxd vnetbios.vxd vtdapi.vxd vwin32.vxd win32s winaspi wsock32 That's a small enough list that I can start guessing at which ones are worth writing tests for. Let's see, how 'bout the following 12: amstream atl cabinet crypt32 dplayx dpnet icmp imagehlp itss mswsock winaspi wsock32 Are any of those obviously poor choices for writing a conformance test? Or are there others that are obviously good choices, but that I missed? Thanks, Dan -- Trying to get a job as a c++ developer? See http://kegel.com/academy/getting-hired.html

3 3

Re: USER32: Implement SPI_{GET,SET}MINIMIZEDMETRICS
by Mike McCormack 13 Jan '05

13 Jan '05

jchevrier(a)nexicom.net wrote: > *Implemented SPI_GETMINIMIZEDMETRICS calculated from values returned by > GetSystemMetrics. The math applied to the values returned from > GetSystemMetrics was verified against Windows 98 and XP using a simple test > program. Yey for test programs :) Would you mind sending it to the list or adding some tests in dlls/user/tests/sysparams.c ? thanks, Mike

1 0

[AppDB] script to clean duplicate users
by Jonathan Ernst 12 Jan '05

12 Jan '05

This script will remove duplicate users from the appdb (same email address), give their data to the most recently logged user that has the same email address and then fix the db structure so that it's not possible anymore to have two time the same email address. Usage: 1)chmod u+x ./clean.php 2)edit clean.php to set up the database connection (line 11 and 12) 3)./clean.php (if php is not in /usr/bin/php you'll have to edit the first line too)

1 0

Re: [QUARTZ] Revert regsvr.c patch
by Robert Shearman 12 Jan '05

12 Jan '05

Paul Vriens wrote: >Hi, > >Christian made me aware of the following: > >--- >As long as this object is not implemented, the FIXME should remain to >remind us that something is missing from quartz. >--- > >As 'Seeking' is not yet implemented I would like to have this patch >reverted. > >Sorry for any inconvenience. > >Cheers, > >Paul > >Changelog > Remove CLSID for registration as it's not implemented yet. > > There is no need to revert the patch because, although the CLSID is not implement yet, it will still print out a fixme in DllGetClassObject (line 181 in dlls/quartz/main.c). Rob

1 0

Re: Palm OS Desktop & Wine
by Stefan Dösinger 12 Jan '05

12 Jan '05

> > The palm Desktop > > installer requires some playing with MSI, I don't remember exactly what I > > did. Note that you can't run the Palm Desktop application, but you can > > run hotsync.exe which is enought to get PDF files onto the palm. > > hotsync.exe: I guess you mean running the HotSync icon on the PDA. No, it's an Win32 binary in the Palm Desktop install directory (usually C: \program files\palm\) It's the "Hotsync Manager". Of course you'll need the HotSync programs on the PalmOS side too. > > No, it doesn't work with USB. > > OK that, it is clear. Well, I didn't try, it might work but I don't think so. Especially because visor.c claims the device. > Here I am lost: Sorry for that. > Could you please explain me this a little more in detail. Should I use > infrared connection or USB connection for what you just described (network > sync with 127.0.0.1)? I do have pi-nredir & pilot-link on my linux laptop > but I do not see what I should configure on my PDA. Moroever, which port > should I provide to pi-nredir ? Could give me the right command to use for > "pi-nredir" to install > /mnt/cdrom/essential_software/acrobatreader_for_palmos/adobereader-palmos.e >xe as example ? A small step-for-step howto: *Install Palm Desktop. *install the Adobe Reader for PalmOS converter. This means running adobereader-palmos.exe with wine *Launch hotsync.exe from the directory where Palm.exe is installed. You'll get the hotsync icon in your Desktop's systray *Double-click it with the right mouse button. You'll always have to double click the hotsync icon to open the menu, I don't know why *Select the "Setup..." menu item or whatever it is called. I have the German version and it's labeled "Einrichten..." *Open the network tab, press "TCP/IP Settings". Check if the ip is correct and enter a correct subnet mask, e.g. 255.255.255.0 *Press OK to close the windows *terminate any Linux app which might access the Palm. Connect the Palm to your PC with the USB cable *Launch the Hotsync program on your PalmOS device *Open the menu and select "LANSync-Setup" or what it's called. The german version labels it "LANSync-Einst..." *Select LANSync and tab OK to close the dialog *Start the Hotsync over the usb cable. *Run pi-nredir -p /dev/pilot on your Computer 3 or 4 secounds later. The Hotsync dialog should pop up and the Device should perform a hotsync with the Win32 Palm Desktop. (replace /dev/pilot with the hotsync port visor.c provides to you. Usually /dev/ttyUSBX or /dev/usb/tts/X) To upload a pdf launch the pdf converter from it's install directory, and select the pdf file to upload. Then perform a hotsync. I hope this is correct, I wrote it down from memory. Cheers, Stefan

1 0

Janitorial : check all refcounts in Wine?
by Paul Vriens 12 Jan '05

12 Jan '05

Hi, for the described Janitorial task 'Use Interlocked functions in AddRef and Release methods' I'm currently looking at This->ref. If I however do a wider search I find a bit more, for example: kernel/atom.c:256: entryPtr->refCount++; msi/handle.c:188: ret = info->refcount--; rpcrt4/cproxy.c:219: This->RefCount++; setupapi/virtcopy.c:106: vhstrlist[n]->refcount++; and so on. I only looked at names containing 'ref'. But there are more around where 'ref' is not in the name: ole32/compobj.c: COM_CurrentInfo()->inits++; I know it's a hell of a job, but should these also be 'fixed'/changed? Of course it's a bit hard to tell which are thread unsafe. Cheers, Paul.

2 1

[AVIFIL32] question about ACMStream_fn[AddRef|Release] in acmstream.c
by Paul Vriens 12 Jan '05

12 Jan '05

Hi, during my code cleanup I came to acmstream.c and found the following: static ULONG WINAPI ACMStream_fnAddRef(IAVIStream *iface) { IAVIStreamImpl *This = (IAVIStreamImpl *)iface; TRACE("(%p) -> %ld\n", iface, This->ref + 1); /* also add reference to the nested stream */ if (This->pStream != NULL) IAVIStream_AddRef(This->pStream); return ++(This->ref); } the AddRef can be cleaned up. the Release however looks buggy: static ULONG WINAPI ACMStream_fnRelease(IAVIStream* iface) { IAVIStreamImpl *This = (IAVIStreamImpl *)iface; TRACE("(%p) -> %ld\n", iface, This->ref - 1); if (This->ref == 0) { /* destruct */ This means I have to do a Release twice before it actually goes into the if statement, because the decrementing takes place at the end of the Release function. Can anybody confirm my finding. Cheers, Paul.

2 3

Request for Sourceforge Upload Access
by Scott Ritchie 12 Jan '05

12 Jan '05

I need to upload the Debian packages into the Sourceforge HTTP space in order for our APT server to be up to date. It'd be nice if I could do it myself. My sourceforge name is yokozar If someone could add me that would be great. Thanks, Scott Ritchie

1 0

[Fwd: msttcorefonts are missing I think]
by Scott Ritchie 12 Jan '05

12 Jan '05

A user sent me this. I'm not exactly sure what she's referring to. Any ideas?

2 1

import stubs
by Dan Notestein 12 Jan '05

12 Jan '05

Instead of directly using native methods to export functions from wine shared libs, Wine and WineLib emulate the windows methodology for exporting/importing these functions. Is this just to enable the use of native Windows dlls in Wine, or is it needed for other reasons? I ask because we're currently using WineLib to port to Solaris and HPUX, where native Windows dlls wouldn't work anyways, and it might be nice if we can remove this overhead on these platforms (and save us some porting headaches). However, before we started this work, we want to be sure there are no "gotchas" associated with removing it.

1 0