November 2005 - Wine-devel - list.winehq.org

Re: [msvcrt] I64 and ll support
by Jesse Allen 10 Nov '05

10 Nov '05

On 11/8/05, Raphael <fenix(a)club-internet.fr> wrote: > Hi, > > Changelog: > - add I64 modifier support on msvcrt *printf functions > - correct ll modifier support on msvcrt *printf functions > - correct tests > > this should correct bug 3759 and 2075 (and many others) > > Now for libc who don't support %ll modifiers (which one?) > Jesse Allen provide the patch (see bug 2075 content) > > Regards, > Raphael > > > > > > > I sent a patch just like that long ago. I think Solaris or BSD might be different. I've now done portable integer conversions. I need to work on float conversions and integrating the two functions better into wcs.c. I think the following is the better way to go. I just need some time free from school =/ http://www.winehq.org/pipermail/wine-patches/2005-September/021007.html http://www.winehq.org/pipermail/wine-devel/2005-September/040402.html

2 1

Re: [winternl.h]Add missing header file
by Andreas Mohr 10 Nov '05

10 Nov '05

Hi, On Thu, Nov 10, 2005 at 06:29:41PM +0100, Süt? Gergely wrote: > ChangeLog: > Add a missing stdarg.h includes. > > This is my first patch please check it! :) Call me stupid, but where exactly do you see Wine's stdarg.h header file implementation? I don't see nothing anywhere... ;) (except in some weird Windows SDK maybe) Andreas

1 0

tabs to throw off from an indentation
by Saulius Krasuckas 10 Nov '05

10 Nov '05

Hello, I'd like to get rid of tabs I encounter when reading existing Wine code. Will my patches be let into the tree if I will submit such no-op changes (one patch for one file) from time to time just before normal, operational patches.

5 9

Re: [wininet]add implementation of few more options - try6
by Juan Lang 10 Nov '05

10 Nov '05

Hi Vijay, sorry I wasn't more explicit. This is what I mean: + hurl = InternetConnectA(hinet,"www.winehq.com",INTERNET_DEFAULT_HTTP_PORT,NULL,NULL,INTERNET_SERVICE_HTTP,0,0); This could fail for many reasons other than that InternetConnectA has a flaw (the test machine may be offline, winehq.com may be down, etc.) Therefore you must deal with the failure, but using ok() is not correct--a failure doesn't necessarily indicate a failure in the test. So you must something like the following: if (hurl) { /* do tests that depend on hurl here */ InternetCloseHandle(hurl); } --Juan __________________________________ Yahoo! FareChase: Search multiple travel sites in one click. http://farechase.yahoo.com

1 0

Re: [wininet]add implementation of few more options - try6
by Dmitry Timoshkov 10 Nov '05

10 Nov '05

"Vijay Kiran Kamuju" <infyquest(a)gmail.com> wrote: > I hope this is the last try Sorry, but it is not. Do you ever read the suggestions? -- Dmitry.

1 0

[Fwd: joystickinput fixes (attempt number 4)]
by Jakob Eriksson 10 Nov '05

10 Nov '05

1 0

Re: [wininet]add implementation of few more options - try5
by Dmitry Timoshkov 10 Nov '05

10 Nov '05

"Vijay Kiran Kamuju" <infyquest(a)gmail.com> wrote: > as previous implementation had some bugs use this version and > implements some suggestions > more tests to come > > ChangeLog > ---------------- > Added implementation for INTERNET_OPTION_VERSION > Added implementation for INTERNET_OPTION_USER_AGENT > Fixed behavior for INTERNET_OPTION_HTTP_VERSION > Added implementation for unsupported options > Added some minimalist testcases You could send your patch billion times, but there is no point in that if you don't fix the pointed out problems. -- Dmitry.

4 3

Re: XEmbed Systray Support
by James Liggett 10 Nov '05

10 Nov '05

On Wed, 2005-11-09 at 15:26 +0530, Vijay Kiran Kamuju wrote: > I have tested googletalk with the patch of yours, i am attaching the > screenshot of it. > whenever i ve closed an googletalk instance its present on the screen > (in the picture i have labelled it as zombie), in ps -ef its not > killing the wine-pthread process. even if i kill that process > manually, i see some artifacts of it left on the screen see to top > most marking. Yeah I get that with Steam and Hotsync as well, in addition to a test program that I slapped together. This sort of behavior only shows itself in GNOME, not in other XEmbed compliant desktops i tested. (I tried XFce and IceWM, in those environments the patches don't show this behavior) It's been suggested that this is some sort of bug in GNOME's implementation of the spec, and I have to agree. So I don't think there's much I can do on the Wine side of this. But I'm not sure about zombie processes though. I'll take a look at that. Thanks for the feedback. James

2 3

compile error: server/event.c
by Sütő Gergely 09 Nov '05

09 Nov '05

Hello! (Sorry for my bad English.) I have problem with compiling after cvs update. Please help! $ tar xvjf wine-0.9.tar.bz2 $ mv wine-0.9 wine $ tar xvzf wine-cvsdirs-0.9.tar.gz $ cd wine $ export CVSROOT=:pserver:cvs(a)cvs.winehq.org:/home/wine $ cvs login $ cvs update -PAd $ ./configure $ make depend $ make make[1]: Entering directory `/home/geri/src/wine/server' gcc -c -I. -I. -I../include -I../include -D__WINESRC__ -Wall -pipe -mpreferred-stack-boundary=2 \ -fno-strict-aliasing -gstabs+ -Wpointer-arith -g -O2 -o event.o event.c In file included from event.c:29: ../include/winternl.h:2040: error: parse error before "va_list" ../include/winternl.h:2211: error: parse error before "va_list" ../include/winternl.h:2212: error: parse error before "va_list" make[1]: *** [event.o] Error 1 make[1]: Leaving directory `/home/geri/src/wine/server' make: *** [server] Error 2 $ Linux: 2.6.19 glibc: 2.3.3 gcc: 3.3.4 Before cvs update the compiling it's right! THX: Geri_

3 4

Re: [user] static.c: PaintIcon fix background colour
by Michael Kaufmann 09 Nov '05

09 Nov '05

Hi Kieran, Icons can have transparent and inverted pixels! This patch is not correct, the background has to be painted always. * dlls/user/static.c: Kieran Clancy <n0dalus+wine at gmail.com <http://www.winehq.org/mailman/listinfo/wine-patches>> Only set background for icon control when the icon is invalid. Regards, Michael

2 3