November 2005 - Wine-devel - list.winehq.org

Re: [wininet]add implementation of few more options
by Dmitry Timoshkov 08 Nov '05

08 Nov '05

"Vijay Kiran Kamuju" infyquest(a)gmail.com wrote: > + retval=InternetQueryOptionA(hinet,INTERNET_OPTION_USER_AGENT,NULL,&len); > + err=GetLastError(); > + ok(len == strlen(useragent)+1,"Got wrong user agent length %ld len instead of %d\n",len,strlen(useragent)); > + ok(retval == 0,"Got wrong return value %d\n",retval); > + ok(err == ERROR_INSUFFICIENT_BUFFER, "Got wrong error code%ld\n",err); You need to set last error to some bogus value before calling an API in order to make sure that the API really changes it. Usually setting last error to 0xdeadbeef works fine for that purpose. -- Dmitry.

1 0

Re: reenable SPI_{GET,SET}BORDER tests and make them pass on wine
by Alexandre Julliard 08 Nov '05

08 Nov '05

Rein Klazes <wijn(a)wanadoo.nl> writes: > source file; > - made the tests pass on wine: > - - non client metric value of iBorderWidth initialized correctly; > - - SPI_SETBORDER updates non client metrics; > - - SPI_SETNONCLIENTMETRICS may save border width value to registry; > - - borderwidth has a minimum value of 1. The tests fail here: sysparams.c:157: Test failed: Missed a message: change_counter=0 sysparams.c:160: Test failed: Wrong action got 0 expected 47 sysparams.c:157: Test failed: Missed a message: change_counter=0 sysparams.c:160: Test failed: Wrong action got 0 expected 47 -- Alexandre Julliard julliard(a)winehq.org

1 0

Help exterminate Solaris issues
by Robert Lunnon 08 Nov '05

08 Nov '05

Could I suggest where someone adds #ifdefs for linux, bsd, etc such as in the recent GlobalMemoryStatusEx issue I just fixed, that the original authors include an #else clause which raises a warning to alert us poor Solaris (and other OS) maintainers to the fact we have to do something. In the meantime I might have to search for OS specific things not flagged with warnings or fixmes.. Thanks Bob

1 0

DirectDrawEnumerateExW calls DirectDrawEnumerateExA
by Saulius Krasuckas 08 Nov '05

08 Nov '05

DirectDrawEnumerateExW (dlls/ddraw/main.c) calls DirectDrawEnumerateExA, which uses ddraw_driver struct (dlls/ddraw/ddraw_private.h), which has a member DDDEVICEIDENTIFIER2 struct (include/ddraw.h), which is defined this way: typedef struct tagDDDEVICEIDENTIFIER2 { char szDriver[MAX_DDDEVICEID_STRING]; char szDescription[MAX_DDDEVICEID_STRING]; LARGE_INTEGER liDriverVersion; DWORD dwVendorId; DWORD dwDeviceId; DWORD dwSubSysId; DWORD dwRevision; GUID guidDeviceIdentifier; DWORD dwWHQLLevel; } DDDEVICEIDENTIFIER2, * LPDDDEVICEIDENTIFIER2; As this struct keeps base information about a driver and it uses char strings, I guess %Subject% cross call should be marked invalid in the wiki. Right?

5 9

Regression in patch 21129
by Michael Jung 08 Nov '05

08 Nov '05

Hi, The patch http://cvs.winehq.org/patch.py?id=21129 caused a regression, which shows in emule's options dialog (v0.46c). I've attached screenshots. A number of "err:imagelist:ImageList_ReplaceIcon no color!" messages are given on the console. Bye, -- Michael Jung mjung(a)iss.tu-darmstadt.de

1 0

Question about contents of STARTUPINFO structure and non WinMain entry points
by James Liggett 08 Nov '05

08 Nov '05

Hi, First, apologies for the length. It's quite a complex issue: A few days ago someone sent to the list asking why a program he'd written on WinXP runs under WineDbg but not under plain wine. Over the weekend I debugged the program and found out that his program doesn't use the standard WinMain entrypoint function. As such, he was using GetStartupInfo to get startup flags. He uses the wShowWindow flag to control the showing of the program's main window. Trouble is, this value is zero unless the program is started as a child process using CreateProcess, given a STARTUPINFO with wShowWindow set to something other than 0 (usually SW_SHOWNORMAL or SW_SHOW.) So my question is, how does the information in STARTUPINFO get set initially? I looked through the code for winecrt0 and found that before WinMain is called, the wShowWindow flag is set to SW_SHOWNORMAL. But because this program does not use WinMain, this value doesn't get set. However, the program works fine on native Windows XP. I looked at ntdll and kernel32 dll code, but I'm not sure I'm looking in the right place. Can someone give me some hints as to how to attack this problem? Thanks a lot, James

1 0

Re: [wininet]add implementation of few more options
by Dmitry Timoshkov 08 Nov '05

08 Nov '05

"Vijay Kiran Kamuju" <infyquest(a)gmail.com> wrote: > ChangeLog > ---------------- > Added implementation for INTERNET_OPTION_VERSION > Added implementation for INTERNET_OPTION_USER_AGENT > Fixed behavior for INTERNET_OPTION_HTTP_VERSION > Added implementation for unsupported options Look like it lacks a test case. -- Dmitry.

2 1

kernel/comm.c - page fault in thread
by Mr Cihan ALTINAY 08 Nov '05

08 Nov '05

Hi, I finally got G-Ware to work flawlessly under wine after some tweaks in the comm.c file. One problem was in the (thread) function COMM_WaitCommEventService(). When I 'disconnect' in the client program it calls purge and sets the event mask to 0 (ie. it is no longer interested in events from the port). But there are still threads running that poll the port. The program crashes when the thread exits the loop (with abort!=0) and tries to set *commio->buffer = rc; (line 2010) but this buffer is already freed by the client. Replacing if (abort) rc = 0; *commio->buffer = rc; by if (!abort) *commio->buffer = rc; fixes this problem. There were other communication errors which I managed to fix but I have to find out first which changes are really necessary to make things work because I tried a lot of things in comm.c. It looks as if there are race conditions when more than one polling thread is running. Currently I check if a thread is already running and don't start a second one if so. But I will find out if that is responsible for the errors or something else and report it on the list. Cheers, Cihan

1 0

DirectX 8 wrapper for wined3d
by Oliver Stieber 07 Nov '05

07 Nov '05

Hi, I've put together a Direct3D 8 wrapper for wined3d which should hopefully replace the current Direct3D 8 code. The patch needs a little bit of tidying, some work of vertex declarations and a hell of a lot of testing before it can go into Wine. So far I've tested Rail Road Tycoon 3, Celebrity Death match, Madden NFL 2004 all the d3d8 demos from http://www.codesampler.com, a few more games I can't remember at the moment and everything's seems to be working as good as or better than the current Direct3D 8 code. I would be greatfull if anyone with DirectX 8 games or applications that currently work or they would like to get working could test the patch and report back any errors they come across. The patch is against Wine cvs 2005-11-05 and can be downloaded from https://sourceforge.net/project/shownotes.php?release_id=368929 for the time being. Oliver. ___________________________________________________________ How much free photo storage do you get? Store your holiday snaps for FREE with Yahoo! Photos http://uk.photos.yahoo.com

7 13

DirectSound, new patch available for testing
by Juergen Wieczorek 07 Nov '05

07 Nov '05

Dear Davin, in the past days I have been testing your 'old' patch with wine-0.9 on my Fedora Core 3 system (kernel-2.6.12-.1381_FC3, alsa-lib-1.0.6-8.FC3, Soundblaster Live PCI = emu10k1), using Diablo2-LoD (patch 1.11b - 3DSound = no) Now I have also tried your new patch. Outcome in short : sound output got worse for me with the new patch. Outcome in detail (for ALSA): A)Old patch - DirectSound settings: 1)EmulDriver=N, HardwareAcceleration=Emulation Blizzard Intro = flawless Game Intro = flawless Game Sound = altogether fluently, some sounds start to miss when in thick melee 2)EmulDriver=N, HardwareAcceleration=Basic/Standard/Full Blizzard Intro = completely jarred Game Intro = with jerks Game Sound = jarred and jerky with large sound holes(dead sound) B)New patch - DirectSound settings: 1)EmulDriver=N, HardwareAcceleration=Emulation Blizzard Intro = flawless Game Intro = flawless Game Sound = persistent audible crackling 2)EmulDriver=N, HardwareAcceleration=Basic/Standard/Full Blizzard Intro = some audible jerks Game Intro = flawless Game Sound = persistent audible crackling The new patch seems to produce less console output of "err:dsound:DSOUND_PhaseCancel length not a multiple of block size" than the old patch and "len" seems to be of shorter size. I have counterchecked with the unpatched wine-0.9 and it is almost the same performance as with the 'new' patch, only that the Blizzard Intro runs flawlessly all the time, no matter what setting I choose for HardwareAcceleration. Hope this helps. -- Juergen Wieczorek Hamburg / Germany

2 1