February 2005 - Wine-devel - list.winehq.org

LPRECT parameters for Main_DirectDrawSurface_Lock
by Andreas Eckstein 18 Feb '05

18 Feb '05

Good morning, wine devs! When playing Icewind Dale II (using wine-20050111), the game sometimes crashed with these messages: trace:ddraw:Main_DirectDrawSurface_Lock lprect: 0x0-0x0 err:ddraw:Main_DirectDrawSurface_Lock Invalid values in LPRECT !!! or, on another occasion: trace:ddraw:Main_DirectDrawSurface_Lock lprect: 0x0-2x0 err:ddraw:Main_DirectDrawSurface_Lock Invalid values in LPRECT !!! As you notice, the game tries to lock a surface with width and/or height equal to zero. Frankly I have no idea what the expected behavior is in this case, however playing the critical passages on Windows worked without crash. A quick patch to let Main_DirectDrawSurface_Lock not choke on zero-width or -height LPRECTs solved the problem with wine. Since I don't plan to dig into wine hacking any time soon, could someone merge it into cvs for me (if the new behavior of the function is acceptable, that is)? Thanks in advance! Andreas Eckstein --- The patch: --- dlls/ddraw/dsurface/main.c 2005-01-09 18:35:44.000000000 +0100 +++ dlls/ddraw/dsurface/main.c 2005-02-14 21:03:36.511738080 +0100 @@ -1111,8 +1111,8 @@ (prect->left < 0) || (prect->bottom < 0) || (prect->right < 0) || - (prect->left >= prect->right) || - (prect->top >= prect->bottom) || + (prect->left > prect->right) || + (prect->top > prect->bottom) || (prect->left >= This->surface_desc.dwWidth) || (prect->right > This->surface_desc.dwWidth) || (prect->top >= This->surface_desc.dwHeight) ||

2 1

Re: advapi32: Add RegOpen/CloseKey test and fixes
by Alexandre Julliard 18 Feb '05

18 Feb '05

James Hawkins <truiken(a)gmail.com> writes: > + ret = RegOpenKeyA(HKEY_CURRENT_USER, "Software\\Wine\\Test", &hkHandle); > + hkPreserve = hkHandle; > + ret = RegCloseKey(hkHandle); > + ok(ret == ERROR_SUCCESS, "expected ERROR_SUCCESS, got %ld\n", ret); > + ok(hkHandle == hkPreserve, "expected hkHandle != hkPreserve\n"); This test is meaningless, since the handle is passed by value to RegCloseKey it cannot possibly be modified. -- Alexandre Julliard julliard(a)winehq.org

1 0

WINE on x86-64 Fedora Core 4 Prerelease Kernels (2.6.10) [Workaround]
by Erich Hoover 18 Feb '05

18 Feb '05

Haven't been able to use WINE for quite a while and have been getting the error: err:seh:EXC_DefaultHandling Unhandled exception code c000013a flags 0 addr 0xffffe403 So I finally found a workaround, hopefully it can help someone else: LD_ASSUME_KERNEL=2.4 setarch i386 -X wine <program>

1 0

Re: advapi32: Add RegOpen/CloseKey test and fixes
by Dmitry Timoshkov 18 Feb '05

18 Feb '05

"James Hawkins" <truiken(a)gmail.com> wrote: > + static const WCHAR emptyW[] = {0}; > + > + if (!name || !strcmpW(name, emptyW)) { > + *retkey = hkey; > + return ERROR_SUCCESS; > + } > + if (!name || !strcmp(name, "")) { > + *retkey = hkey; > + return ERROR_SUCCESS; > + } Instead of introducing emptyW and calling strcmp[W] with an empty string it's much simpler and more readable to use in both cases: if (!name || !*name) { *retkey = hkey; return ERROR_SUCCESS; } -- Dmitry.

1 0

Re: OLEAUT32: Implementation of OleFontImpl_QueryTextMetrics
by Dmitry Timoshkov 18 Feb '05

18 Feb '05

"Alex Villacis Lasso" <a_villacis(a)palosanto.com> wrote: > --- wine-20050211/dlls/oleaut32/olefont.c 2005-01-31 06:34:10.000000000 -0500 > +++ wine-20050211-patch/dlls/oleaut32/olefont.c 2005-02-16 22:56:18.865553128 -0500 > @@ -1068,8 +1068,16 @@ > IFont* iface, > TEXTMETRICOLE* ptm) > { > - FIXME("(%p, %p), stub!\n",iface,ptm); > - return E_NOTIMPL; > + HDC hdcRef; > + HFONT hOldFont, hNewFont; I's suggest to replace a FIXME with a TRACE, not remove it altogether. More logging never hurts. -- Dmitry.

1 0

Winelib and SCons
by Scott Ritchie 18 Feb '05

18 Feb '05

Ok, to be up front and honest I haven't used SCons at all yet, but if it really is an honest to god replacement for autoconf, make, and friends then I'm really excited. Why? Because this has some serious importance for Winelib. Currently, in order to port a program to Linux via Winelib, a developer needs to first make it work in MinGW (a nontrivial amount to do if you use Visual Studio). Then, the developer needs to run some Wine scripts on it to make the code compatible with GCC on Linux - this isn't so hard, and mostly involves things like switching out backslashes for forward ones. Then, the developer needs to write his own makefiles and hammer autoconf and stuff into working right. This is the hard part, and it's where I gave up when trying to port Miranda Instant Messenger with Winelib even though it worked in MinGW. There are many other open source Windows apps out there that I'd like to try porting (say, eMule), but they're currently all written in Visual Studio and getting Visual Studio support into Winelib has been on our perpetual todo list for some years now. SCons might change that. If it really does work with Visual Studio files, we could rip out the Winelib makefile stuff and replace it with SCons. What do you think? Are the SCons developers interested in helping us do this? Do any of you use Wine yourselves? Thanks, Scott Ritchie Wine guy

3 2

Re: How to install Mozilla ActiveX on demand
by Robert Shearman 18 Feb '05

18 Feb '05

Marcelo Duarte wrote: > Hi, > The Wine asks if I want to install the Mozilla ActiveX control, > however it does not give no indication as to make this. > Looking for in the patches, I found failed to meet information. > See: http://www.winehq.org/hypermail/wine-patches/2004/10/0492.html > That indicates: > > [Software\\Wine\\shdocvw] 1089668326 > "Url"="http://www.iol.ie/~locka/mozilla/MozillaControl16.exe > <http://www.iol.ie/%7Elocka/mozilla/MozillaControl16.exe>" > > But the correct is: > [Software\\Wine\\shdocvw] 1089668326 > "MozillaUrl"="http://www.iol.ie/~locka/mozilla/MozillaControl16.exe > <http://www.iol.ie/%7Elocka/mozilla/MozillaControl16.exe>" > So, I decided to show to the user as to make this. > Also I corrected a small error of presentation. > > Changelog: > Marcelo Duarte > Show to the user how to install Mozilla ActiveX on demand Why not fix the key rather than telling the user to do it? Rob

4 5

SCons, Wine, and Winelib
by Scott Ritchie 17 Feb '05

17 Feb '05

Ok, currently Winelib relies on GNU autoconf, makefiles and friends to get a working app. This is a bit difficult, particularly if you're not very good with makefiles (I'm attempting to learn them from scratch in order to port an application.) I just heard about the SCons project, which from what I can tell looks like it aims to be a replacement to the makefiles. Has anyone used this? http://www.scons.org/ I bring this up because it might be easier on developers to have something like Winemaker create a SCons script, rather than rely on the user to piddle around with autoconf and hacking up makefiles. Thoughts? Thanks, Scott Ritchie Usability-developer-wannabe-extrordinaire

5 9

Watcthtower Library 2003 on Mandrake 10.1
by Zane Wickham 17 Feb '05

17 Feb '05

I added these lines to the end of the wine config file to get the Watchtower Library 2003 to load using Winetools and it does open when clicking on icon on desktop (Mandrake 10.1) after reading discussions on wiki :^> Zinger ;Watchtower Library [AppDefaults\\wtlib.exe\\DllOverrides] "*comctl32*" = "native" "*commctrl*" = "native" ;Watchtower Setup [AppDefaults\\Setup.exe\\DllOverrides] "comctl32" = "builtin" ;Watchtower ikernel [AppDefaults\\ikernel.exe\\DllOverrides] "comctl32" = "native" __________________________________ Do you Yahoo!? Yahoo! Mail - Easier than ever with enhanced search. Learn more. http://info.mail.yahoo.com/mail_250

1 0

Silly question about the download page
by Holly Bostick 17 Feb '05

17 Feb '05

Hey, all, Is there some reason that the SuSE section on the download page does not say that it links to a binary RPM for SuSE 9.2? The page says "SuSE binary and source .rpms for SuSE 8.1, 8.2, 9.0, and 9.1", although binaries for 9.2 are in fact on the Sourceforge project page along with the versions mentioned. Hey, I said it was silly, but if we're trying to make things easier for new users who believe exactly what they read, it's misleading. Holly

2 1