February 2005 - Wine-devel - list.winehq.org

Re: add RegOpenKey, RegCloseKey tests
by Alexandre Julliard 16 Feb '05

16 Feb '05

James Hawkins <truiken(a)gmail.com> writes: > The last patch forgot to close the keys opened. Use this one instead. > > Changelog > * Add RegOpenKey, RegCloseKey tests. The tests fail on Wine. You need to add todo_wine blocks. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: portability fixes (yet another attempt)
by Mike McCormack 16 Feb '05

16 Feb '05

Thomas Weidenmueller wrote: > I unfortunately don't know as I couldn't find referencces to the other > HAVE_* definitions, which I guess are somewhere outside of wine sources. The HAVE_* definitions are set by the configure script. You need to add a test into configure.ac that detects the presence or absence of strtoulW and vnsprintf. Mike

1 0

Re: get rid of unnecessary libunicode dependencies in some more places
by Mike McCormack 16 Feb '05

16 Feb '05

Thomas Weidenmueller wrote: > - sz = strlenW(fmt) + 1; > + sz = wcslen(fmt) + 1; libc and wine may have differing interpretations of what wchar_t. Specifically, if -fshort-wchar is not used, wchar_t will be int, won't it? You'd be better off using lstrlenW() than wcslen(), but that will be slow since it has an exception handler. Alexandre was talking about making an inline wine only version of lstrlenW() without the exception handler to solve that problem. Mike

4 4

IDirect3DDevice9Impl_SetVertexShader in d3d9/vertexshader.c
by Paul Vriens 16 Feb '05

16 Feb '05

Hi, I have a demo-app that calls SetVertexShader with a NULL value. According to MSDN this is valid: To set a fixed-function vertex shader (after having set a programmable vertex shader), call IDirect3DDevice9::SetVertexShader(NULL) to release the programmable shader, and then call IDirect3DDevice9::SetFVF with the fixed-function vertex format. The app bails out of course because we do not handle the NULL value. Will this be fixed in the big upcoming d3d updates? Cheers, Paul.

1 0

WM_CREATE failure and SetScrollRange argument validation
by Krzysztof Foltman 16 Feb '05

16 Feb '05

I've noticed another two things where Wine and Windows XP differ: 1. SetScrollRange(hWnd, SB_VERT, 0, -1) does nothing in WinXP, and is equivalent to SetScrollRange(hWnd, SB_VERT, 0, 0) in Wine. I guess it's true for all kinds of invalid arguments. 2. In WinXP, returning -1 from WM_CREATE causes window creation to fail - the newly created window is automatically destroyed (which sends WM_DESTROY to the window). In Wine, WM_DESTROY is not sent (which prevents the example program to finish). The short piece of relevant code can be downloaded from: http://foltman.com/wintest-scroll.zip Krzysztof

1 0

Re: [shell32tests/shelllink.c] Use aliases for ordinals
by Rolf Kalbermatter 16 Feb '05

16 Feb '05

Francois Gouget wrote: >Ok, that would be a good reason. >There's something I don't understand though: when I compile the test >before your changes with Visual C++ 6.0 it compiles just fine but it >turns out the resulting executable imports these three APIs by ordinal. It all depends on the SDK you have installed. The Windows DLLs always exported those functions by ordinal since about Win95. The very early SDKs for Win95 included those APIs in the import libraries so calling them in an app would link fine. Then MS removed all undocumented APIs from their release SDK import libs. Later after the court case they documented most of those formely undocumented APIs and also included them back into the next SDK release. >Is this something that MinGW can / should do too? Yes MinGW libraries should probably include those APIs as well in their link libraries if they want to be compatible with the current SDK. >And for the Winelib side of things, is this something that winebuild can do? With proper definition in Wines spec files this should be no problem at all. Rolf Kalbermatter

1 0

Re: [shell32tests/shelllink.c] Use aliases for ordinals
by Rolf Kalbermatter 16 Feb '05

16 Feb '05

Francois Gouget wrote: >As far as I know, SHILCreateFromPath, ILFree and ILIsEqual are all >exported by name on Windows. So, IMHO, unless we find a problem running >the test on some Windows versions it would be better to fix MinGW. Those functions are all exported by ordinal only from most Windows systems except maybe the Win XP versions and systems updated with the latest IE Explorer version. Rolf Kalbermatter

1 0

Re: wine/ programs/winefile/Pt.rc programs/winecfg ...
by Marcelo Duarte 16 Feb '05

16 Feb '05

Hi, Alexandre Julliard escreveu: >ChangeSet ID: 16090 >CVSROOT: /opt/cvs-commit >Module name: wine >Changes by: julliard(a)wine.codeweavers.com 2005/02/14 05:12:30 > > In this file below, the correct is "usuário", but in cvs is incorrect "usuÃ¡rio" and I dont know how to correct... In my tree it is correct. Index: wine/dlls/mpr/mpr_Pt.rc diff -u -p wine/dlls/mpr/mpr_Pt.rc:1.1 wine/dlls/mpr/mpr_Pt.rc:1.2 --- wine/dlls/mpr/mpr_Pt.rc:1.1 Wed Feb 16 09:36:32 2005 +++ wine/dlls/mpr/mpr_Pt.rc Wed Feb 16 09:36:32 2005 @@ -24,3 +24,23 @@ STRINGTABLE DISCARDABLE { IDS_ENTIRENETWORK "Toda a rede" } + +IDD_PROXYDLG DIALOG LOADONCALL MOVEABLE DISCARDABLE 36, 24, 250, 154 +STYLE DS_MODALFRAME | WS_POPUP | WS_CAPTION | WS_SYSMENU +CAPTION "Entre a senha da rede" +FONT 8, "Helv" +{ + LTEXT "Por favor, entre como o nome de usuÃ¡rio e a senha:", IDC_EXPLAIN, 40, 6, 150, 15 +

2 2

CreateCaret resets caret position (while it shouldn't)
by Krzysztof Foltman 16 Feb '05

16 Feb '05

There seems to be a difference in functionality of CreateCaret between Windows (XP at least) and Wine. You can find a test program at: http://foltman.com/wintest-caret.zip Look at this code snippet: CreateCaret(hWnd, NULL, 0, 20); SetCaretPos(100,100); CreateCaret(hWnd, NULL, 10, 10); In Wine, the 2nd CreateCaret resets caret position to (0, 0). In Windows, caret position doesn't get reset - it's still positioned at (100, 100). Note that calling CreateCaret twice without DestroyCaret is not a bug (after MSDN): - - - - - cut - - - - - CreateCaret automatically destroys the previous caret shape, if any, regardless of the window that owns the caret. The caret is hidden until the application calls the ShowCaret function to make the caret visible. - - - - - cut - - - - - Is it easy to fix for anyone ? Krzysztof

1 0

Re: portability fixes (yet another attempt)
by Dmitry Timoshkov 16 Feb '05

16 Feb '05

"Thomas Weidenmueller" <wine-patches(a)reactsoft.com> wrote: > > My understanding was that Dmitry suggested you modify your headers, > > not ours. > > I did, unfortunately wine's headers were/are also incomplete so porting > code that called vsnprintfW() or strtoulW() in any case would link > against libunicode (unnecessarily). In order to get rid of a dependency on libunicode for vsnprintfW and strtoulW you have to do the same header magic (if I understood Filip correctly) as you already do for strcmpW/wcslen and map them to whatever ntdll equivalent is available. Your very recent version of the patch still has strlenW/wcslen changes not acceptable for Wine code, if you could resend it again without it that would be great. -- Dmitry.

1 0