February 2005 - Wine-devel - list.winehq.org

Use of Favourite instead a Favorite in our regedit
by Paul Vriens 28 Feb '05

28 Feb '05

Hi, while looking through some registries (via regedit) on several windows versions and Wine, I saw that we use Favourites/Favourite etc.. instead of Favorites/Favorite in our regedit implementation. Is this deliberate or should I create a patch for this? The patch will also change ID_FAVOURITES_MENU, ID_FAVOURITES_ADDTOFAVOURITES,ID_FAVOURITES_REMOVEFAVOURITE. I know it's not a functional change, but hey, one has to be busy. Cheers, Paul

1 0

Re: WIDL - Sync to ReactOS 20050227
by Steven Edwards 28 Feb '05

28 Feb '05

--- Steven Edwards <steven_ed4153(a)yahoo.com> wrote: > Changelog: > Eric Kohl <eric.kohl(a)t-online.de> > > Server stubs are void functions. > Fix a warning in the server stub descriptor. > Support multiple interfaces per idl file. > Support explicit binding handles. > Support remaining basic types (float, double, small, wchar_t and handle_t). I forgot to rebuild my whole tree after this patch and am getting a error so hold off. steven(a)steven:/usr/src/wine/dlls/ole32# ../../tools/widl/widl -I. -I. -I../../include -I../../include -D__WINESRC__ -D_OLE32_ -DCOM_NO_WINDOWS_H -h -H dcom.h dcom.idl error: ResolveOxid() must not define a binding handle! Thanks Steven __________________________________ Do you Yahoo!? Read only the mail you want - Yahoo! Mail SpamGuard. http://promotions.yahoo.com/new_mail

1 1

free fonts
by Brian Vincent 27 Feb '05

27 Feb '05

The issue of fonts came up a while ago and I know some people are working on free replacements for some of the core fonts. Anyway, I stumbled on this resource tonight with a huge listing of fonts: http://cgm.cs.mcgill.ca/~luc/originalfonts.html Seems like there's got to be a few decent ones in there the authors would be willing to let us use and relicense. -Brian

1 0

Re: [PATCH] Added 2 functions to shell32
by Dmitry Timoshkov 27 Feb '05

27 Feb '05

"Gianluigi Tiesi" <sherpya(a)netfarm.it> wrote: > +BOOL WINAPI PathIsEqualOrSubFolder(LPCWSTR path1, LPCWSTR path2) > +{ > + int i; > + int len; > + if (!path1 || !path2) return FALSE; > + > + len = strlenW(path1); > + if (len > strlenW(path2)) return FALSE; > + > + for (i=0; i < len; i++) > + if (path1[i] != path2[i]) return FALSE; > + return TRUE; > +} You need to do a case insensitive comparison of paths. Also, if you could use a usual for Wine formatting style with 4 space indentation that would be very nice. -- Dmitry.

2 1

Re: comctl32 - SB_SETBORDERS
by Thomas Weidenmueller 27 Feb '05

27 Feb '05

Steven Edwards wrote: >Filip implemented this for me when I was testing Office97 under ReactOS and I never got around to >merging it to the ros tree. > > SB_SETBORDERS does not exist in current versions of NT. It might be a something from the old 3.x days. NT 5.0 and 5.1 for sure don't implement them. Even though Office tries to use them I oppose implementing it. Best Regards, Thomas

2 2

status of winetest.exe
by Stefan Leichter 27 Feb '05

27 Feb '05

Hello Paul, i have noticed that the winetest are not longer built since the middle of the week. Can you take a look if something is broken? Thanks Stefan

2 1

Re: shell32: formatting and unicodification
by Alexandre Julliard 27 Feb '05

27 Feb '05

Juan Lang <juan_lang(a)yahoo.com> writes: > Mike's formatting changes got in, so here's one of my own. > > ChangeLog: convert tabs to spaces, make indenting consistent, convert more > calls to Unicode Please don't mix formatting changes with other things, it makes it very painful to review. -- Alexandre Julliard julliard(a)winehq.org

2 1

Re: setupapi: enumerate serial ports
by Alexandre Julliard 27 Feb '05

27 Feb '05

Juan Lang <juan_lang(a)yahoo.com> writes: > + /* FIXME: it should be possible for more than four COM ports to exist, not > + * sure why we retain that limit, but winspool does too so go with it. > + */ > + for (i = 0, ret = 0; i < 4; i++) > + { > + if (SETUP_SerialPortExists(i)) > + ret++; > + } There's no reason to limit to 4 serial ports (and winspool should be fixed too). Probably the best way is to do a QueryDosDevice(NULL) which gets you a full device list and the return every COM device in that list. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: Fix a race condtition in the server startup
by Bill Medland 27 Feb '05

27 Feb '05

On February 26, 2005 03:43 pm, Francois Gouget wrote: > There is a race condition in the server startup code which arises if two > I propose the following fix: > > if (lstat( name, st ) == -1) > { > if (errno != ENOENT) fatal_perror( "lstat %s", name ); > if (mkdir( name, 0700 ) == -1 && errno != EEXIST) fatal_perror( > "mkdir %s", name ); > > Using the existing directory is ok because we then check its ownership, > permissions, etc. (which we have to do anyway in case it already existed). How about simply mkdir and if the error is already existed then fine.? Unchecked, but something like: if (mkdir (name, 0700) == -1) { if (errno != EEXIST) fatal_perror ("Ensuring directory %s", name) } > > > Changelog: > > * server/request.c > > Francois Gouget <fgouget(a)codeweavers.com> > Fix a race condition in create_dir(). -- Bill Medland mailto:billmedland(a)mercuryspeed.com http://webhome.idirect.com/~kbmed

1 0

riched20 patch preview
by Krzysztof Foltman 27 Feb '05

27 Feb '05

I've finally managed to make my riched20 code usable (hardly) and compatible with Wine. It's probably not good enough to go to CVS, but, at least, it's something you can try out. Comments are welcome. It should work with all programs that load RICHED20.DLL directly. For programs that load RICHED32.DLL you need a native version of that DLL (which is a wrapper for RICHED20.DLL, providing compatibility with 1.0 version of the control, the most important thing it does is loading RICHED20.DLL, which registers 2.0 window classes). http://foltman.com/riched20.tar.gz http://foltman.com/richeditpatch.diff Note, that EM_STREAMIN and EM_STREAMOUT don't work, so if your program uses RTF to insert text to the control, it won't work ! WinXP WordPad doesn't work either, as it uses RICHEDIT50W window class (what I provide is RichEdit20W control, haven't tried to fake it's 5.0). Have fun! Krzysztof

1 1