February 2005 - Wine-devel - list.winehq.org

How do native win32 apps end up calling into x11drv?
by Adam Connell 25 Feb '05

25 Feb '05

Greetings, I'm trying to understand how windows drawing gets translated into X in wine and so I was looking at the {im,ex}ports of x11drv and gdi32. x11drv depends on gdi32 and just seems to export a good chunk of the api that gdi32 exports (BitBlt etc). gdi32 doesn't depend on x11drv or even Xlib. How do native win32 apps end up calling into x11drv? Cheers, Adam

2 1

Re: setupapi: enumerate serial ports
by Alexandre Julliard 25 Feb '05

25 Feb '05

Juan Lang <juan_lang(a)yahoo.com> writes: > +/* Based on code from winspool's info.c */ > +static UINT SETUP_CountSerialPorts(void) > +{ > + UINT i, ret; > + > + /* FIXME: it should be possible for more than four COM ports to exist, not > + * sure why we retain that limit, but winspool does too so go with it. > + */ > + for (i = 0, ret = 0; i < 4; i++) > + { > + if (SETUP_SerialPortExists(i)) > + ret++; > + } > + TRACE("returning %d\n", ret); > + return ret; > +} It would probably be better to use QueryDosDevice here. -- Alexandre Julliard julliard(a)winehq.org

2 2

using safe string functions in wine
by James Hawkins 25 Feb '05

25 Feb '05

Hey, While perusing msdn recently, I stumbled across string safe functions. These functions were created to replace the standard c string handling routines. The following are some design criteria of string safe functions (msdn): * Always NULL-terminate the string. * Always take a destination buffer size. * Always return consistent return codes (an HRESULT). * Support 32-bit and 64-bit environments. * Flexibility. http://msdn.microsoft.com/library/default.asp?url=/library/en-us/dnsecure/h… What is your opinion on whether we should implement and use either the user-mode or kernel-mode (or both) string safe functions? Using these functions instead of the standard c string functions would promote consistency and security in the wine code base. On the other hand, using these functions adds another layer of calls to the code. What are other pro's and con's of using string safe functions? -- James Hawkins

3 2

Microsoft admits targeting Wine users
by Tom 25 Feb '05

25 Feb '05

Here is the link: http://news.zdnet.co.uk/0,39020330,39189180,00.htm Tom

3 2

While we're saying thanks, another thing that works is...
by Holly Bostick 25 Feb '05

25 Feb '05

... the Neverwinter Nights Toolset. Amazingly enough, after I had followed a whole lot of very complex instructions in order to download and compile some half-ancient version of WineX (3.3.2), patch it to nwwine (which is the common name of the patched version that is supposed to get the toolset working; it's in Portage and everything), and add Registry entries and native dlls, it turned out that the toolset ran 'perfectly well' under regular old Wine 20050211 (and in fact not very well under nwwine; couldn't use the menus, etc.). My wine is all hacked together atm, so I'll have to do a clean install to see if it needs anything special other than a couple of native dlls (that it might not need, but I had installed them to the program folder for nwwine) before attempting to add it to the appdb, but it definitely works. I've added custom content to all 7 of the Original Campaign modules using it (and the game is using the content properly, so it's correctly added). Oh, and by the way, thanks for the fix of the titlebars; it's really really nice to have the same window decorations in Wine programs as on the rest of the desktop. Just noticed it today (can't believe I didn't before) and wanted to let you know I appreciate it. Holly

1 0

WineConf agenda ideas
by Brian Vincent 25 Feb '05

25 Feb '05

Over the the past week or so I've harassed some folks about the agenda for WineConf. At this point there's a lot that remains to be filled in, but I need some feedback. Also, I need more ideas for presentations. Does anyone want to present something? It'd be great if someone would volunteer. I think what we're shooting for is a presentation followed by discussion all contained within about one hour. In total we'll have 10 - 12 different topics. Here's the items that are definitely going to be on the agenda: WRS intro Keynote - Alexandre Road to .9 and 1.0 - Dimi ReactOS update - all the ReactOS guys Wine / networking / Samba issues - Juan Lang We've also got some other items, but I need feedback as to whether any of you find this stuff interesting. (So reply and tell me if any of these items sound interesting.) Windows authentication - Andrew Bartlett (um.. haven't asked him yet though) Something else Samba related? - Samba guys Commercial port of a Winelib app and using Wine - an enterprise user CXTest and regression testing - someone from CodeWeavers Version control - Mike Hearn wearing a fire retardant suit DCOM work - Mike or Rob DirectX update - ? Also, if you need to make hotel reservations, there's just a few weeks left to do that. Check out the WineConf page for details: http://www.winehq.org/site/wineconf As people begin to figure out travel plans, the wineconf mailing list will pick up. How to join: http://www.winehq.org/mailman/listinfo/wineconf Let me know if you have any questions. -Brian

1 0

Re: [winecfg] Drive autodetection
by Mike Hearn 25 Feb '05

25 Feb '05

Paul van Schayck wrote: > Changelog: > As last option for drive type detection we try the device node name. Looks good but please try and use the same code style as in the rest of the program. In particular note that winecfg doesn't use Hungarian notation anywhere, eg "szNode" would just be "node" or "nodename". thanks -mike

2 2

Re: wsock32 conformance test
by Juan Lang 25 Feb '05

25 Feb '05

Hey guys, nice work. Minor comments below: > +/* we often pass this size by reference */ > +int sizeofSOCKADDR_IN = sizeof(SOCKADDR_IN); When you pass it by reference, you don't reinitialize it after a call that might modify it, e.g. here: > + /* get port number */ > + getsockname(*sock, (SOCKADDR *) &tmpAddr, &sizeofSOCKADDR_IN); I think it'd be safer to declare a local int initialized to sizeof(SOCKADDR_IN) and pass this by ref instead. > + for (connIndex = 0; connIndex < NUM_CLIENTS; connIndex++) { > + /* accept connection */ > + tmpSock = accept(*sock, (SOCKADDR *) &tmpSockAddr, &sizeofSOCKADDR_IN); Your indenting's off here. (Do you have to use tabs? Ick.) > + connection->serverThread.Handle = CreateThread(NULL, 0, (LPTHREAD_START_ROUTINE) &BlockingServerConnection_Run, connection, 0, &connection->serverThread.ID); Please wrap long lines. > + const int numTests = 3; Might as well make that static too. Props for first post :) --Juan __________________________________________________ Do You Yahoo!? Tired of spam? Yahoo! Mail has the best spam protection around http://mail.yahoo.com

1 0

Re: SHELL32: implement loading and saving of MSI advertised shortcut info
by Juan Lang 25 Feb '05

25 Feb '05

Hi Mike, > + * in that string is parsed an stored. s/an/and/ > +typedef struct volume_info_t > +{ > + DWORD type; > + DWORD serial; > + WCHAR label[12]; /* assume 8.3 */ Shouldn't label's size be 13? 8+3+'.'+NULL? > + if( (buffer.magic&0xffff0000) != 0xa0000000 ) A symbolic constant would be nice here. Thanks, --Juan __________________________________________________ Do You Yahoo!? Tired of spam? Yahoo! Mail has the best spam protection around http://mail.yahoo.com

1 0

Compiling wine dlls for windows
by Michael Jung 25 Feb '05

25 Feb '05

Hello, I would like to test a wine dll I'm working on on windows. Could you please tell me how the wine dlls are build for windows ? (Or beat me to the the place where it is documented.) Thanks, -- Michael Jung mjung(a)iss.tu-darmstadt.de

4 4