March 2005 - Wine-devel - list.winehq.org

Re: combo - implement GetComboBoxInfo
by Alexandre Julliard 15 Mar '05

15 Mar '05

Steven Edwards <steven_ed4153(a)yahoo.com> writes: > @@ -2296,7 +2295,18 @@ > BOOL WINAPI GetComboBoxInfo(HWND hwndCombo, /* [in] handle to combo box */ > PCOMBOBOXINFO pcbi /* [in/out] combo box information */) > { > - FIXME("\n"); > - return FALSE; > + if (IsWindow(hwndCombo)) > + { > + LPHEADCOMBO lphc = (LPHEADCOMBO)GetWindowLongPtrW( hwndCombo, 0 ); The IsWindow check is useless, what you need is to verify that it's really a combobox. The right way to do that is probably to send a CB_GETCOMBOBOXINFO message instead. -- Alexandre Julliard julliard(a)winehq.org

2 1

Clipboard regression
by Stefan Dösinger 15 Mar '05

15 Mar '05

Hello List, This patch from 2005/03/07 causes a Clipboard regression: http://www.winehq.org/hypermail/wine-cvs/2005/03/0111.html Whenever the clipboard is used the process crashes with an X error. To reproduce it just start notepad and right click into the text area: err:x11drv:error_handler X protocol error: serial=271, request_code=1 - breaking into debugger wine: Unhandled exception (thread 0009), starting debugger... WineDbg starting on pid 0x8 In 32 bit mode. 0x4034e014 DebugBreak+0x4 [/windows/c/wine/dlls/kernel/debugger.c:307] in kernel32: popl %ebp Unable to open file '/windows/c/wine/dlls/kernel/debugger.c' Wine-dbg>bt Backtrace: =>1 0x4034e014 DebugBreak [/windows/c/wine/dlls/kernel/debugger.c:307] in kernel32 (0x4075f5f0) 2 0x40e46f38 error_handler(display=0x780c6938, error_evt=0x4075f654) [x11drv_main.c:194] in x11drv (0x4075f61c) 3 0x40ee33a4 ?? in libx11.so.6 (0x4075f6cc) 4 0x40ee18c3 ?? in libx11.so.6 (0x4075f70c) 5 0x40edc9f4 ?? in libx11.so.6 (0x4075f74c) 6 0x40edcab5 ?? in libx11.so.6 (0x4075f76c) 7 0x40edf0db ?? in libx11.so.6 (0x4075f79c) 8 0x40e11a0f thread_selection_wnd [/windows/c/sonstiges/wine/dlls/x11drv/x11drv.h:521] in x11drv (0x4075f7e0) 9 0x40e14185 X11DRV_CLIPBOARD_QueryAvailableData+0x55(lpcbinfo=0x4075f8e8) [/windows/c/sonstiges/wine/dlls/x11drv/clipboard.c:1636] in x11drv (0x4075f8a4) 10 0x40e12800 X11DRV_CLIPBOARD_UpdateCache(lpcbinfo=0x4075f8e8) [/windows/c/sonstiges/wine/dlls/x11drv/clipboard.c:801] in x11drv (0x4075f8c8) 11 0x40e15935 X11DRV_IsClipboardFormatAvailable+0x35(wFormat=0xd) [/windows/c/sonstiges/wine/dlls/x11drv/clipboard.c:2312] in x11drv (0x4075f914) 12 0x40a21bac IsClipboardFormatAvailable(wFormat=0xd) [/windows/c/sonstiges/wine/dlls/user/../../windows/clipboard.c:614] in user32 (0x4075f940) 13 0x40a6de38 EDIT_WM_ContextMenu+0x138(es=0x4023d968, x=0x2fb, y=0x17d) [/windows/c/sonstiges/wine/dlls/user/edit.c:3900] in user32 (0x4075f97c) 14 0x40a6660c EditWndProc_common+0x3fc(hwnd=0x10024, msg=0x7b, wParam=0x10024, lParam=0x17d02fb, unicode=0x1) [/windows/c/sonstiges/wine/dlls/user/edit.c:835] in user32 (0x4075f9f8) 15 0x40a6759f EditWndProcW(hWnd=0x10024, uMsg=0x7b, wParam=0x10024, lParam=0x17d02fb) [/windows/c/sonstiges/wine/dlls/user/edit.c:1008] in user32 (0x4075fa14) 16 0x40a4b71f WINPROC_wrapper+0x17 in user32 (0x4075fa38) 17 0x40a4ba8d WINPROC_CallWndProc+0x7d(proc=0x40a67570, hwnd=0x10024, msg=0x7b, wParam=0x10024, lParam=0x17d02fb) [/windows/c/sonstiges/wine/dlls/user/../../windows/winproc.c:419] in user32 (0x4075fa74) 18 0x40a52b43 CallWindowProcW+0x103(func=0x40a67570, hwnd=0x10024, msg=0x7b, wParam=0x10024, lParam=0x17d02fb) [/windows/c/sonstiges/wine/dlls/user/../../windows/winproc.c:3283] in user32 (0x4075faa8) 19 0x40a8bb80 call_window_proc+0xe0(hwnd=0x10024, msg=0x7b, wparam=0x10024, lparam=0x17d02fb, unicode=0x1, same_thread=0x1) [/windows/c/sonstiges/wine/dlls/user/message.c:1518] in user32 (0x4075fb04) 20 0x40a8d9d1 SendMessageTimeoutW+0x161(hwnd=0x10024, msg=0x7b, wparam=0x10024, lparam=0x17d02fb, flags=0x0, timeout=0xffffffff, res_ptr=0x4075fb8c) [/windows/c/sonstiges/wine/dlls/user/message.c:2346] in user32 (0x4075fb68) 21 0x40a8dca1 SendMessageW+0x51(hwnd=0x10024, msg=0x7b, wparam=0x10024, lparam=0x17d02fb) [/windows/c/sonstiges/wine/dlls/user/message.c:2427] in user32 (0x4075fb94) 22 0x40a29ef6 DEFWND_DefWinProc+0x6a6(hwnd=0x10024, msg=0x205, wParam=0x0, lParam=0x14c02f4) [/windows/c/sonstiges/wine/dlls/user/../../windows/defwnd.c:696]in user32 (0x4075fc38) 23 0x40a2acbd DefWindowProcW+0x9d(hwnd=0x10024, msg=0x205, wParam=0x0, lParam=0x14c02f4) [/windows/c/sonstiges/wine/dlls/user/../../windows/defwnd.c:946] in user32 (0x4075fc68) 24 0x40a66f64 EditWndProc_common+0xd54(hwnd=0x10024, msg=0x205, wParam=0x0, lParam=0x14c02f4, unicode=0x1) [/windows/c/sonstiges/wine/dlls/user/edit.c:405] in user32 (0x4075fce4) 25 0x40a6759f EditWndProcW(hWnd=0x10024, uMsg=0x205, wParam=0x0, lParam=0x14c02f4) [/windows/c/sonstiges/wine/dlls/user/edit.c:1008] in user32 (0x4075fd00) 26 0x40a4b71f WINPROC_wrapper+0x17 in user32 (0x4075fd24) 27 0x40a4ba8d WINPROC_CallWndProc+0x7d(proc=0x40a67570, hwnd=0x10024, msg=0x205, wParam=0x0, lParam=0x14c02f4) [/windows/c/sonstiges/wine/dlls/user/../../windows/winproc.c:419] in user32 (0x4075fd60) 28 0x40a52b43 CallWindowProcW+0x103(func=0x40b006e8, hwnd=0x10024, msg=0x205,wParam=0x0, lParam=0x14c02f4) [/windows/c/sonstiges/wine/dlls/user/../../windows/winproc.c:3283] in user32 (0x4075fd94) 29 0x40a8f078 DispatchMessageW+0xe8(msg=0x4075fe64) [/windows/c/sonstiges/wine/dlls/user/message.c:2992] in user32 (0x4075fdc8) 30 0x40648c70 WinMain+0x2e0(hInstance=0x40640000, prev=0x0, cmdline=0x4020141b, show=0x1) [main.c:357] in notepad (0x4075fe90) 31 0x40646403 __wine_exe_main+0x13b in notepad (0x4075ff20) 32 0x4037d262 start_process+0xf2(arg=0x0) [/windows/c/sonstiges/wine/dlls/kernel/process.c:1047] in kernel32 (0x4075fff4) 33 0x4001ffa1 ?? +0x11 in libwine.so.1 (0x00000000) Wine-dbg>

1 0

Re: shell32: set %AllUsersProfile%, and fix shell folder registration
by Alexandre Julliard 15 Mar '05

15 Mar '05

Juan Lang <juan_lang(a)yahoo.com> writes: > ChangeLog: > - %AllUsersProfile% was not getting set in the environment, spotted by > Vitaly Lipatov This should be done in wine.inf, not in the code. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: make_ctests - convert make_ctests to C
by Steven Edwards 15 Mar '05

15 Mar '05

Hi, --- Andreas Mohr <andi(a)rhlx01.fht-esslingen.de> wrote: > That one contains DOS line endings (^M). I have asked Royce to make a version that creates the testlist.c file with Unix line endings by default and provides a command line option for dos line endings for people developing on Windows. Thanks Steven __________________________________ Do you Yahoo!? Yahoo! Small Business - Try our new resources site! http://smallbusiness.yahoo.com/resources/

3 2

[badpenguin79@hotmail.com: [Full-disclosure] [ZH2005-02SA] Insecure tmp file creation in Wine]
by Marcus Meissner 15 Mar '05

15 Mar '05

Hi, >From full-disclosure, a security mailing list. Fix seems trivial, just use 0600. (untested, uncompiled ;) Ciao, Marcus Changelog: Temporary registries exported only user read/writeable to avoid information leaks. Index: server/registry.c =================================================================== RCS file: /home/wine/wine/server/registry.c,v retrieving revision 1.63 diff -u -r1.63 registry.c --- server/registry.c 10 Mar 2005 11:18:31 -0000 1.63 +++ server/registry.c 14 Mar 2005 16:38:54 -0000 @@ -1610,7 +1610,7 @@ for (;;) { sprintf( p, "reg%lx%04x.tmp", (long) getpid(), count++ ); - if ((fd = open( tmp, O_CREAT | O_EXCL | O_WRONLY, 0666 )) != -1) break; + if ((fd = open( tmp, O_CREAT | O_EXCL | O_WRONLY, 0600 )) != -1) break; if (errno != EEXIST) goto done; close( fd ); } Index: misc/registry.c =================================================================== RCS file: /home/wine/wine/misc/registry.c,v retrieving revision 1.149 diff -u -r1.149 registry.c --- misc/registry.c 25 Aug 2004 00:48:47 -0000 1.149 +++ misc/registry.c 14 Mar 2005 16:38:55 -0000 @@ -1227,7 +1227,7 @@ ret = _xmalloc(50); for (count = 0;;) { sprintf(ret,"/tmp/reg%lx%04x.tmp",(long)getpid(),count++); - if ((tmp_fd = open(ret,O_CREAT | O_EXCL | O_WRONLY,0666)) != -1) break; + if ((tmp_fd = open(ret,O_CREAT | O_EXCL | O_WRONLY,0600)) != -1) break; if (errno != EEXIST) { ERR("Unexpected error while open() call: %s\n",strerror(errno)); free(ret);

3 4

Re: dinput.diff
by Alexandre Julliard 15 Mar '05

15 Mar '05

Tom Wickline <twickline(a)gmail.com> writes: > Changelog: increase the maximum number of devices to 16 Why do you need this? -- Alexandre Julliard julliard(a)winehq.org

1 0

Are mailslots implemented?
by Kuba Ober 15 Mar '05

15 Mar '05

Hi, Is the one-way mailslot IPC implemented in wine? I'm getting fixme:sync:CreateMailslotW(...): stub messages. Is this a simple thing to implement, or would it require additions to the server protocol? Thanks, Kuba Ober

4 5

Re: make_ctests - convert make_ctests to C
by Andreas Mohr 15 Mar '05

15 Mar '05

Hi, On Mon, Mar 14, 2005 at 08:35:19PM -0800, Steven Edwards wrote: > Convert make_ctests script to C That one contains DOS line endings (^M). Andreas Mohr

1 0

Re: [DSOUND] little patch
by Robert Reif 15 Mar '05

15 Mar '05

Raphael wrote: >Hi > >Changelog: > - try to have better match caps with hw caps so games can active more hw >support > >Regards, >Raphael > > > >- This->lock.DebugInfo->Spare[1] = 0; >+ /*This->lock.DebugInfo->Spare[1] = 0;*/ > DeleteCriticalSection(&(This->lock)); > > You have to zero this out or DeleteCriticalSection will try to delete that static memory. >+ if (pDS->drvcaps.dwFlags | DSCAPS_PRIMARYMONO) pDS->pwfx->nChannels = 1; >+ if (pDS->drvcaps.dwFlags | DSCAPS_PRIMARY16BIT) pDS->pwfx->wBitsPerSample = 16; >+ pDS->pwfx->nBlockAlign = pDS->pwfx->wBitsPerSample * pDS->pwfx->nChannels / 8; >+ pDS->pwfx->nAvgBytesPerSec = pDS->pwfx->nSamplesPerSec * pDS->pwfx->nBlockAlign; >+ > You can't do this and be compatible with windows. > >+#ifndef __WINE_DSOUND_PRIVATE_H >+#define __WINE_DSOUND_PRIVATE_H > You can't include this more than once because there is only one .h file so it's not really necessary. >+#define WINE_SET_CS_NAME(cs, name) (cs)->DebugInfo->Spare[1] = (DWORD) name >+#define WINE_GET_CS_NAME(cs) (const char*) (cs)->lock.DebugInfo->Spare[1] > > This is a wine specific trick and should probably be put somewhere global so all users can be consistent. The name should have DEBUG in it somewhere.

3 5

Re: wine/ misc/registry.c documentation/samples/co ...
by Dimitrie O. Paun 15 Mar '05

15 Mar '05

On Mon, Mar 14, 2005 at 11:18:40AM -0600, Alexandre Julliard wrote: > Log message: > Get rid of the remaining registry configuration parameters. Any plans on getting the global registry back? -- Dimi.

2 1