March 2005 - Wine-devel - list.winehq.org

AppDB Can't delete version
by Scott Ritchie 09 Mar '05

09 Mar '05

Supermaintainers can't delete versions - it asks "Are You Sure?" but then gives a "must be logged in" error. If you could fix this I could clean up the winamp entry and get to work on finding the regression. Thanks, Scott Ritchie

3 3

Re: Menu protocol.
by Scott Ritchie 09 Mar '05

09 Mar '05

On Tue, 2005-03-08 at 21:02 +0000, Mike Hearn wrote: > On Mon, 07 Mar 2005 14:36:03 -0800, George Farris wrote: > > Whats the protocol as far as adding a top level menu under Applications? > > I want to port a number of Ham radio apps over and put them in their own > > menu called.. wait for it.. Amateur Radio. > > > > Would this be frowned upon? The apps would be coming from universe. > > I think it'd be better to formalise a new category as an extension to the > FDO .desktop spec, then adjust the upstream menu XML definition, assuming > there is one (they always look the same on GNOME based distros so I expect > there is). > > That way it's not Ubuntu specific. > > thanks -mike > > On this matter, do we want to create a Wine top-level entry in the Applications menu? We can start it as an Ubuntu-specific extension, include the appropriate .desktop files in the Ubuntu package (I'll write them myself), and then just send changes upstream? I envision the following process for a user after installing the Wine package: a new Wine menu entry will appear under Applications, and within that will be a Program Files subfolder with installed Windows apps and the included apps (like our notepad). Adjacent Program Files will be the GUI configuration tools - winecfg, the uninstaller, etc. Stuff could also be installed here that isn't Wine explicitly, like the Winetools package. Thoughts? -Scott Ritchie

2 1

Re: {Validate|Invalidate}{Rgn|Rect} fix
by Alexandre Julliard 09 Mar '05

09 Mar '05

Rein Klazes <wijn(a)wanadoo.nl> writes: > Changelog: > dlls/user : painting.c > dlls/user/tests : win.c > > {Validate|Invalidate}{Rgn|Rect} should not (in)validate children if the > window has a WS_CLIPCHILDREN style. With tests. This is redundant, RedrawWindow already does that check if you don't specify RDW_ALLCHILDREN. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: [ADVAPI] SetSecurityInfo
by Alexandre Julliard 09 Mar '05

09 Mar '05

Raphael <fenix(a)club-internet.fr> writes: > On Friday 04 March 2005 00:45, Robert Shearman wrote: > > I have made a few comments on the implementation below: > > > SRCDIR = @srcdir@ > > > VPATH = @srcdir@ > > > MODULE = advapi32.dll > > >-IMPORTS = kernel32 ntdll > > >+IMPORTS = winspool kernel32 ntdll > > > > Should be in DELAYIMPORTS. We don't want to slow down the loading of all > > applications because of this one uncommon case. > > I didn't known this wine makefile option :) > Done This doesn't look right at all, even with delayed imports. Do you have evidence that Windows advapi32 calls into winspool? -- Alexandre Julliard julliard(a)winehq.org

2 3

wine style checker.
by Oliver Stieber 09 Mar '05

09 Mar '05

Hi, I've noticed that Alexander has fixed a few compatibility problems in the patches I've been sending in, like moving #directives to the beginning on the line, removing the odd C++ style comment and moving declarations to the top of a function/ code block. Does anyone have or know of something that can check my code before I send it to wine patches? I've egreped out all the #directives's already. Send instant messages to your online friends http://uk.messenger.yahoo.com

3 2

Re: edit control
by Robert Shearman 09 Mar '05

09 Mar '05

Ulrich Czekalla wrote: >Running some tests under WinXP I noticed that if the edit control doesn't >have WS_EX_CLIENTEDGE it looses the WS_BORDER style and it handles painting >the border. This also has the side effect that it's non-client area goes to >zero. > >ChangeLog: > Ulrich Czekalla <ulrich(a)codeweavers.com> > Handle painting the border if WS_EX_CLIENTEDGE is not set > > This changelog doesn't really seem to match the patch. Are you sure it's right? >------------------------------------------------------------------------ > >Index: dlls/user/edit.c >=================================================================== >RCS file: /home/wine/wine/dlls/user/edit.c,v >retrieving revision 1.2 >diff -u -r1.2 edit.c >--- dlls/user/edit.c 9 Sep 2004 19:18:40 -0000 1.2 >+++ dlls/user/edit.c 15 Sep 2004 16:30:50 -0000 >@@ -4423,13 +4423,18 @@ > /* > * In Win95 look and feel, the WS_BORDER style is replaced by the > * WS_EX_CLIENTEDGE style for the edit control. This gives the edit >- * control a non client area. Not always. This coordinates in some >- * way with the window creation code in dialog.c When making >- * modifications please ensure that the code still works for edit >- * controls created directly with style 0x50800000, exStyle 0 ( >- * which should have a single pixel border) >+ * control a nonclient area so we don't need to draw the border. >+ * If WS_BORDER without WS_EX_CLIENTEDGE is specified we shouldn't have >+ * a nonclient area and we should handle painting the border ourselves. >+ * >+ * When making modifications please ensure that the code still works >+ * for edit controls created directly with style 0x50800000, exStyle 0 >+ * (which should have a single pixel border) > */ >- es->style &= ~WS_BORDER; >+ if (lpcs->dwExStyle & WS_EX_CLIENTEDGE) >+ es->style &= ~WS_BORDER; >+ else if (es->style & WS_BORDER) >+ SetWindowLongW(hwnd, GWL_STYLE, es->style & ~WS_BORDER); > > This doesn't seem right at all. The new code should be exactly the same as the old, barring any side effects from SetWindowLong (which shouldn't affect the control anyway since this the function changed is the handler for WM_NCCREATE). Rob

3 3

text edit box not painting text ( on form startup )
by Doug Herbert 09 Mar '05

09 Mar '05

( I have posted a similiar question in wine-users, don't flame me for doing so, just thinking about this some more, perhaps it may be more a developer question ) Ok, I have a windows app, that runs under wine fine - not quite. This app has a form, with many text field edit boxes on. Quite often these edit boxes already have text values, ie. they are not empty - there is a database behind the form. Anyway, the form shows on the screen, but the text within the edit fields is invisible, until you activate each edit box component. When you leave one edit box to the next, the text remains visible. It seems like the repainting is not working, on initial startup of the form. As a way to debug this database app ( I don't have the source code for it ) I wrote a real basic form app in Visual Studio, with two edit boxes, with data in each. Now this basic app shows the text values immediately on startup. So there must be something different that the database app is not doing. I then ran wine using 'wine --debugmsg +edit programname' for both app's. I see both logging 'Creating ANSI edit control, style = xxxxx' but the style reference is different between apps - I am not sure if this the cause or not. The problem app reports style = 54011104 and the basic app shows style = 50010080. Can somebody explain what this style reference means and how do I force an app to use a certain style of edit box ? What other wine class debugmsg types should I use to narrow down the source of this problem ? Is there anyway I can check to see how the database app is repainting text within the text edit components ? Regards Doug Herbert. __________________________________ Do you Yahoo!? Yahoo! SiteBuilder - Free, easy-to-use web site design software http://sitebuilder.yahoo.com

3 4

Re: [HELP] Quartz and FFMpeg question
by Christian Costa 09 Mar '05

09 Mar '05

> Message du 08/03/05 12:05 > De : "Francois Gouget" <fgouget(a)free.fr> > A : "Christian Costa" <titan.costa(a)wanadoo.fr> > Copie à : "wined" <wine-devel(a)winehq.org> > Objet : Re: [HELP] Quartz and FFMpeg question > > On Sun, 6 Mar 2005, Christian Costa wrote: > > > Hi, > > > > I'm working on a video wrapper around libavcodec from FFMpeg. > > > > Currently I can play rle, msvideo1 and mjpeg movies. > > But before submitting anything I must handle the dependency with libavcodec > > (and maybe libavformat in the future). > > AFAIK there is no stable API > > How do other projects that use libavcodec and ffmpeg deal with the > binary compatibility issue? Mplayer and Gstreamer include ffmpeg sources. They are not in their CVS repository but a snapshot is added during the release process. Transcode only check for ffmpeg headers and static libraries. There are several other apps. I will take a look a them. > At least here (Debian) mplayer depends on > the libavcodec package instead of copying the source (but it's a bit of > a special case as they come from a third-party package repository). This is surprising because libavcodec and libavformat are static libraries so once the binary is generated there is no more dependency. Christian

2 1

Re: [DPLAYX] fix bug 872
by Alexandre Julliard 09 Mar '05

09 Mar '05

Raphael <fenix(a)club-internet.fr> writes: > Hi, > > cf http://bugs.winehq.org/show_bug.cgi?id=872 > > Seems he have created events (hTemps) leaks no ? I'm not sure why that code uses global handles at all, since they get duplicated in the target process anyway; it seems to me you could simply get rid of the ConvertToGlobalHandle calls. If that doesn't work the code needs to be fixed, global handles are a Win9x abomination that should never be used. -- Alexandre Julliard julliard(a)winehq.org

3 3

re: Why not build wine server as a linux kernel module?
by Dan Kegel 09 Mar '05

09 Mar '05

su_hang_ab(a)163.com wrote: > May I ask you a question? > Why not build wine server as a linux kernel module? > I think the performance of a kernel module is better than a separate > process. > If anyone can give me a reasonable answer, I would really appreciate it. It's been tried. It will be tried again in the future, I'm sure. For the moment, though, just getting things working properly is a big enough challenge without involving the kernel. See e.g. http://www.winehq.com/site/?issue=178#Viva%20la%20Kernel%20Module%20Idea for previous discussions on the topic. - Dan -- Trying to get a job as a c++ developer? See http://kegel.com/academy/getting-hired.html

1 0