March 2005 - Wine-devel - list.winehq.org

Voodoo3, Banshee and D3D
by Troy Rollo 08 Mar '05

08 Mar '05

---CONTEXT--- <http://dri.sourceforge.net/doc/dri_driver_features.phtml> The Voodoo3/Banshee driver reverts to software rendering under the following conditions: - Setting GL_LIGHT_MODEL_COLOR_CONTROL to GL_SEPARATE_SPECULAR_COLOR. - Enabling line stippling or polygon stippling. - Enabling point smoothing or polygon smoothing. - Enabling line smoothing when line width is not 1.0. That is, antialiased lines are done in hardware only when the line width is 1.0. - Using 1-D or 3-D texture maps. - Using the GL_BLEND texture environment. - Using stencil operations. - Using the accumulation buffer. - Using glBlendEquation(GL_LOGIC_OP). - Using glDrawBuffer(GL_FRONT_AND_BACK). - Using glPolygonMode(face, GL_POINT) or glPolygonMode(face, GL_LINE). - Using point size attenuation (i.e. GL_DISTANCE_ATTENUATION_EXT). - Using glColorMask(r, g, b, a) when r!=g or g!=b. ---END-CONTEXT--- Both wined3d/directx.c and d3d8/directx.c have an IWineD3DImpl_CreateDevice that includes the following call: glLightModeli(GL_LIGHT_MODEL_COLOR_CONTROL, GL_SEPARATE_SPECULAR_COLOR); In effect this prevents WINE from using the Voodoo3 for 3D rendering. Not only does this make D3D games intolerably slow (forget measuring FPS - start measuring FPM or worse), the result for many operations is just plain wrong. Commenting out the offending line makes it work much better (at least until it hits one of the other problems), but with a list of software fallbacks this large, and given that the Voodoo3 is over 5 years old now, there must be some question as to whether this is worth fixing. Is the response to people with this problem "just go pick up an old GeForce card for $30"?

3 3

[HELP] Quartz and FFMpeg question
by Christian Costa 08 Mar '05

08 Mar '05

Hi, I'm working on a video wrapper around libavcodec from FFMpeg. Currently I can play rle, msvideo1 and mjpeg movies. But before submitting anything I must handle the dependency with libavcodec (and maybe libavformat in the future). AFAIK there is no stable API so we need to incorporate FFMpeg source code into the wine tree and update it whenever it's needed. The difficulty here is to add these sources to the build process. There are several solutions : - reuse all FFMpeg build process (configure & makefile) or part of it (makefile only) - add all necessary files in the quartz makefile with slight modifications to FFMpeg sources (IIRC it's what was done in previous quartz code) Currently I use the second solution with all optimizations disabled. This is a bit hackish and not that portable I guess. Enabling optimizations and portability requires using our config.h in FFMpeg sources but also adding additionnal files depending on the platform which complicate things a bit. I'm not a makefile and autoconf expert and before digging deeper I would like some advices. Thansk in advance. Christian

2 1

Re: ScrollDC fixes.
by Alexandre Julliard 08 Mar '05

08 Mar '05

Rein Klazes <wijn(a)wanadoo.nl> writes: > + if(( size = GetRegionData( SrcRgn, 0, NULL )) && > + (rdata = HeapAlloc( GetProcessHeap(), 0, size ))) { > + GetRegionData( SrcRgn, size, rdata ); > + /* the rectangles in the region data are ordered top-to-bottom > + * So if the scrolling is downward, traverse the array backwards > + * to avoid touching pixels that have yet to be scrolled */ > + /* FIXME: implement something similar for left-to-right > + * scrolling. */ > + if( dydev < 0 ) { > + step = 1; > + rect = (RECT *)rdata->Buffer; > + } else { > + step = -1; > + rect = ((RECT *)rdata->Buffer) + rdata->rdh.nCount - 1; > + } > + for( i = 0; i < rdata->rdh.nCount; i++, rect += step) { > + DPtoLP(hdc, (LPPOINT)rect, 2); > + TRACE("Bit blitting %s to %ld,%ld\n", wine_dbgstr_rect(rect), > + rect->left + dx, rect->top + dy); > + BitBlt( hdc, rect->left + dx, rect->top + dy, > + rect->right - rect->left, rect->bottom -rect->top, > + hdc, rect->left, rect->top, SRCCOPY); > + } You really shouldn't need to scroll the region rectangle by rectangle. Selecting the proper clip region and then copying the whole area should have the same effect. > { > XEvent event; > > - XWindowEvent( gdi_display, physDev->drawable, ~0, &event ); > - if (event.type == NoExpose) break; > + if( !XCheckWindowEvent( gdi_display, physDev->drawable, ~0, &event )) > + break; > + if (event.type == NoExpose) continue; You can't use XCheckWindowEvent, you need to wait for the events that haven't arrived yet. -- Alexandre Julliard julliard(a)winehq.org

2 3

documentation for SERVER_START_REQ
by James Hawkins 08 Mar '05

08 Mar '05

Hi, I'm implementing NtLoadKey, but I can't find any documentation on making server requests, ie SERVER_START_REQ, the different tracing abilitites such as using fprintf(stderr,...) instead of the known TRACE, style of code etc. The latter two are not as important to me because I've picked them up while perusing the code, but it might be important to someone who hasn't looked through it before. I do need the semantics for SERVER_START_REQ, so if you could point me in the right direction or tell me I would really appreciate it. -- James Hawkins

3 3

Re: New uninstaller
by Mike McCormack 08 Mar '05

08 Mar '05

Jonathan Ernst wrote: > Here is the new uninstaller. > > I'll be away all this week so I send it already as it works well here > (no regressions found) and has already some more features than the > current one (so Iguess it can be safely committed, but I might be wrong > of course). > > With some help I'll be able to improve it (more unicodification, etc.) > when I'll come back. > > > Changelog: > - new uninstaller > - "find as you type" search > - use dialog instead of window > - internationalization > - more unicodification > - if the uninstaller cannot be found the user can choose to remove the > entry from the registry Hi Jonathan, You'll have more success getting this applied if you send each step as a seperate patch. I suggest starting by sending a single patch that converts the uninstaller to use a dialog instead of a window, adds a dialog resource in English and does nothing else. Once that patch is accepted, move onto the other tasks you have listed above. One step at a time makes the patch easier to review, and reduces the chance that a single line mistake will stop your entire patch from going in. Additionally, there's no need to change the name of main.c to uninstaller.c, that will just make it harder to see what has changed between versions. Mike

2 2

building programs
by Ivan Leo Puoti 08 Mar '05

08 Mar '05

I've got the impression that during program building (clock, notepad etc.) a spec file for them is created on the fly, can someone confirm/dispute this? Ivan.

5 11

Re:avicap32 patch
by luis lenders 08 Mar '05

08 Mar '05

Hi That patch won't work. You forgot to include the changes in the headers in vfw.h I've sent you, e.g. #define WM_CAP_START WM_USER #define WM_CAP_UNICODE_START (WM_USER +100) #define WM_CAP_DRIVER_CONNECT (WM_CAP_START+ 10) #define WM_CAP_DRIVER_DISCONNECT (WM_CAP_START+ 11) etcera and the macros #define capDriverConnect(hwnd, index) SendMessage((hwnd), WM_CAP_DRIVER_CONNECT, (index, 0)) etcetera etcetera furthermore all the v4l stuff has to go into a seperate driver file i think, as wine is also supposed to run on non-Linux distributions. this line in avicap_main : window = CreateWindowExW etc. and the registering of the window contains a lot of crap; i just copied it from a site somewhere on the internet. It was just to get a handle to the window Somehow the dwstyle has to get passed on, and few other things. Futhermore: no need to link to -lpng -ljpeg and -lnetpbm; they're not needed anymore in the code i've sent you. Better think, get more info and be more carefull before you send in a patch i think. Anyway, i smashed together some code with which i can grab an image from my cam, and save it as a DIB (capFileSaveDIB). also i wrote something for cappreview, which looks as if it would be easy to get it running. if someone's interested i could send you the code. Now my question is: maybe one of the developers could just help/hint/write the Capcreatecapturewindow part (that seems to me a very little job), then anyone who wants could try to write a macro; just a thought of me, any thoughts from someone else? Regards Send instant messages to your online friends http://uk.messenger.yahoo.com

1 0

Discussion on Bug tracking database
by Ann and Jason Edmeades 08 Mar '05

08 Mar '05

Hello, I thought I'd try to start a discussion to try to encourage changes in the bug tracking, but it would both require agreement and someone (else) who could physically make the changes. Is it me or is our bug tracking database not really working the way it should? Firstly I'd like to thank Tony - he seems to do a lot of maintaining of the bug database and deserves a lot of credit. Until I started looking through them and monitoring the bug mailing list, I didn't realize how much he did. Bug database problems.. 1. Some problems reports start off as useless. Its not a bug report, its more a call for assistance. 2. Some bug reports are severely out of date. A large number of them have as a last update a request to test on a more recent cvs (which is a fair thing to do if the bugs are left idle for eg. 1 year! 3. We have a large number who due to our inactivity mean the person who raised it no longer cares, so any questions are a waste of time and come back unanswered 4. We have some where the email address of the raise has changed so even if they care they may not notice any changes to the bug report 5. Its hard to tell the bugs you can reproduce with downloadable freeware from those that require expensive software Suggestions.... 1. I would like to get implemented an AUTOMATIC timeout on the bug reports. If they are inactive for eg. 4 months then an automatic update is added to them asking to try latest cvs and confirm the problem still exists. If the problem is not updated within a month, the bug report gets automatically closed with a specific code (eg. CLOSED/inactivity). 2. I would like a clear way to identify if the problem can be reproduced with **free** downloadable software, eg a demo, freeware, shareware etc. This should be searchable for people wanting a quick bug fix 3. I would like there to be a transition from an initial state before being accepted, which basically allows rejection of a bug report if there is not enough information in it. Unfortunately someone would have to actively do this, so this would be a very had one to achieve. 4. I would also like a bug fixing period of time, when all wine developers are encouraged to work on bugs for eg. one day a month. Interestingly, even though most people seem to end up working in a particular area they may not handle bugs in that area (probably because they don't check for them!). How many of the wine developers would consider allocating time once a month (even if its just an hour!) to look at a bug report, perhaps try it or go back asking for appropriate traces etc. I know some of this can be achieved by 'proper' use of the bug states, keywords etc, but we don't...! Anyway, I thought I would start a discussion, so you know my thoughts - what are other peoples. Jason

5 6

Why not build wine server as a linux kernel module?
by 苏杭 08 Mar '05

08 Mar '05

Hi, May I ask you a question? Why not build wine server as a linux kernel module? I think the performance of a kernel module is better than a separate process. If anyone can give me a reasonable answer, I would really appreciate it. Hang Su

1 0

Re: advapi32 registry.c test failures on windows
by James Hawkins 07 Mar '05

07 Mar '05

On Mon, 7 Mar 2005 00:28:13 -0800 (PST), Aaron Arvey <aarvey(a)cs.hmc.edu> wrote: > There were 28 failures when I ran the advapi32 tests on windows. All these > were in registry.c. Please see > http://www.winehq.org/hypermail/wine-devel/2005/02/0045.html and the > following responses to find out where/when/why/how these bugs were > introduced. > > After patch is applied, the registry.c runs without errors on Windows XP > and 98. When ran in wine, there are now 28 todos. > > Aaron > > Changelog: > * dlls/advapi32/tests/registry.c > altered tests so that they run under windows > > Signed-off-by: Aaron Arvey <aarvey_at_cs.hmc.edu> > > Index: dlls/advapi32/tests/registry.c > =================================================================== > RCS file: /home/wine/wine/dlls/advapi32/tests/registry.c,v > retrieving revision 1.11 > diff -u -3 -p -u -r1.11 registry.c > --- dlls/advapi32/tests/registry.c 27 Jan 2005 11:15:00 -0000 1.11 > +++ dlls/advapi32/tests/registry.c 17 Feb 2005 04:00:13 -0000 > @@ -80,6 +80,7 @@ static void test_enum_value(void) > DWORD val_count, data_count, type; > static const WCHAR foobarW[] = {'f','o','o','b','a','r',0}; > static const WCHAR testW[] = {'T','e','s','t',0}; > + static const WCHAR test1W[] = {'T','e','s','t','1',0}; > static const WCHAR xxxW[] = {'x','x','x','x','x','x','x','x',0}; > > /* check NULL data with zero length */ > @@ -105,8 +106,12 @@ static void test_enum_value(void) > res = RegEnumValueA( hkey_main, 0, value, &val_count, NULL, &type, data, &data_count ); > ok( res == ERROR_MORE_DATA, "expected ERROR_MORE_DATA, got %ld\n", res ); > ok( val_count == 2, "val_count set to %ld\n", val_count ); > - ok( data_count == 7, "data_count set to %ld instead of 7\n", data_count ); > - ok( type == REG_SZ, "type %ld is not REG_SZ\n", type ); > + todo_wine{ > + ok( data_count == 24, "data_count set to %ld instead of 24\n", data_count ); > + } > + todo_wine{ > + ok( type == REG_EXPAND_SZ, "type %ld is not REG_EXPAND_SZ\n", type ); > + } > ok( !strcmp( value, "xxxxxxxxxx" ), "value set to '%s'\n", value ); > ok( !strcmp( data, "xxxxxxxxxx" ), "data set to '%s'\n", data ); > > @@ -120,8 +125,12 @@ static void test_enum_value(void) > ok( res == ERROR_MORE_DATA, "expected ERROR_MORE_DATA, got %ld\n", res ); > /* Win9x returns 2 as specified by MSDN but NT returns 3... */ > ok( val_count == 2 || val_count == 3, "val_count set to %ld\n", val_count ); > - ok( data_count == 7, "data_count set to %ld instead of 7\n", data_count ); > - ok( type == REG_SZ, "type %ld is not REG_SZ\n", type ); > + todo_wine{ > + ok( data_count == 24, "data_count set to %ld instead of 24\n", data_count ); > + } > + todo_wine{ > + ok( type == REG_EXPAND_SZ, "type %ld is not REG_EXPAND_SZ\n", type ); > + } > #if 0 > /* v5.1.2600.0 (XP Home) does not touch value or data in this case */ > ok( !strcmp( value, "Te" ), "value set to '%s' instead of 'Te'\n", value ); > @@ -137,8 +146,12 @@ static void test_enum_value(void) > res = RegEnumValueA( hkey_main, 0, value, &val_count, NULL, &type, data, &data_count ); > ok( res == ERROR_MORE_DATA, "expected ERROR_MORE_DATA, got %ld\n", res ); > ok( val_count == 0, "val_count set to %ld\n", val_count ); > - ok( data_count == 7, "data_count set to %ld instead of 7\n", data_count ); > - ok( type == REG_SZ, "type %ld is not REG_SZ\n", type ); > + todo_wine{ > + ok( data_count == 24, "data_count set to %ld instead of 24\n", data_count ); > + } > + todo_wine{ > + ok( type == REG_EXPAND_SZ, "type %ld is not REG_EXPAND_SZ\n", type ); > + } > ok( !strcmp( value, "xxxxxxxxxx" ), "value set to '%s'\n", value ); > #if 0 > /* v5.1.2600.0 (XP Home) does not touch data in this case */ > @@ -154,8 +167,12 @@ static void test_enum_value(void) > res = RegEnumValueA( hkey_main, 0, value, &val_count, NULL, &type, data, &data_count ); > ok( res == ERROR_MORE_DATA, "expected ERROR_MORE_DATA, got %ld\n", res ); > ok( val_count == 20, "val_count set to %ld\n", val_count ); > - ok( data_count == 7, "data_count set to %ld instead of 7\n", data_count ); > - ok( type == REG_SZ, "type %ld is not REG_SZ\n", type ); > + todo_wine{ > + ok( data_count == 24, "data_count set to %ld instead of 24\n", data_count ); > + } > + todo_wine{ > + ok( type == REG_EXPAND_SZ, "type %ld is not REG_EXPAND_SZ\n", type ); > + } > ok( !strcmp( value, "xxxxxxxxxx" ), "value set to '%s'\n", value ); > ok( !strcmp( data, "xxxxxxxxxx" ), "data set to '%s'\n", data ); > > @@ -166,12 +183,25 @@ static void test_enum_value(void) > strcpy( value, "xxxxxxxxxx" ); > strcpy( data, "xxxxxxxxxx" ); > res = RegEnumValueA( hkey_main, 0, value, &val_count, NULL, &type, data, &data_count ); > - ok( res == ERROR_SUCCESS, "expected ERROR_SUCCESS, got %ld\n", res ); > - ok( val_count == 4, "val_count set to %ld instead of 4\n", val_count ); > - ok( data_count == 7, "data_count set to %ld instead of 7\n", data_count ); > - ok( type == REG_SZ, "type %ld is not REG_SZ\n", type ); > - ok( !strcmp( value, "Test" ), "value is '%s' instead of Test\n", value ); > - ok( !strcmp( data, "foobar" ), "data is '%s' instead of foobar\n", data ); > + todo_wine{ > + ok( res == ERROR_MORE_DATA, "expected ERROR_MORE_DATA, got %ld\n", res ); > + } > + todo_wine{ > + ok( val_count == 20, "val_count set to %ld instead of 20\n", val_count ); > + } > + todo_wine{ > + ok( data_count == 24, "data_count set to %ld instead of 24\n", data_count ); > + } > + todo_wine{ > + ok( type == REG_EXPAND_SZ, "type %ld is not REG_EXPAND_SZ\n", type ); > + } > + todo_wine{ > + ok( !strcmp( value, "xxxxxxxxxx" ), "value is '%s' instead of xxxxxxxxxx\n", value ); > + } > + todo_wine{ > + ok( !strcmp( data, "xxxxxxxxxx" ), "data is '%s' instead of xxxxxxxxxx\n", data ); > + } > + > > /* Unicode tests */ > > @@ -190,8 +220,12 @@ static void test_enum_value(void) > res = RegEnumValueW( hkey_main, 0, valueW, &val_count, NULL, &type, (BYTE*)dataW, &data_count ); > ok( res == ERROR_MORE_DATA, "expected ERROR_MORE_DATA, got %ld\n", res ); > ok( val_count == 2, "val_count set to %ld\n", val_count ); > - ok( data_count == 7*sizeof(WCHAR), "data_count set to %ld instead of 7*sizeof(WCHAR)\n", data_count ); > - ok( type == REG_SZ, "type %ld is not REG_SZ\n", type ); > + todo_wine{ > + ok( data_count == 24*sizeof(WCHAR), "data_count set to %ld instead of 24*sizeof(WCHAR)\n", data_count ); > + } > + todo_wine{ > + ok( type == REG_EXPAND_SZ, "type %ld is not REG_EXPAND_SZ\n", type ); > + } > ok( !memcmp( valueW, xxxW, sizeof(xxxW) ), "value modified\n" ); > ok( !memcmp( dataW, xxxW, sizeof(xxxW) ), "data modified\n" ); > > @@ -204,8 +238,12 @@ static void test_enum_value(void) > res = RegEnumValueW( hkey_main, 0, valueW, &val_count, NULL, &type, (BYTE*)dataW, &data_count ); > ok( res == ERROR_MORE_DATA, "expected ERROR_MORE_DATA, got %ld\n", res ); > ok( val_count == 3, "val_count set to %ld\n", val_count ); > - ok( data_count == 7*sizeof(WCHAR), "data_count set to %ld instead of 7*sizeof(WCHAR)\n", data_count ); > - ok( type == REG_SZ, "type %ld is not REG_SZ\n", type ); > + todo_wine{ > + ok( data_count == 24*sizeof(WCHAR), "data_count set to %ld instead of 24*sizeof(WCHAR)\n", data_count ); > + } > + todo_wine{ > + ok( type == REG_EXPAND_SZ, "type %ld is not REG_EXPAND_SZ\n", type ); > + } > ok( !memcmp( valueW, xxxW, sizeof(xxxW) ), "value modified\n" ); > ok( !memcmp( dataW, xxxW, sizeof(xxxW) ), "data modified\n" ); > > @@ -217,10 +255,18 @@ static void test_enum_value(void) > memcpy( dataW, xxxW, sizeof(xxxW) ); > res = RegEnumValueW( hkey_main, 0, valueW, &val_count, NULL, &type, (BYTE*)dataW, &data_count ); > ok( res == ERROR_MORE_DATA, "expected ERROR_MORE_DATA, got %ld\n", res ); > - ok( val_count == 4, "val_count set to %ld instead of 4\n", val_count ); > - ok( data_count == 7*sizeof(WCHAR), "data_count set to %ld instead of 7*sizeof(WCHAR)\n", data_count ); > - ok( type == REG_SZ, "type %ld is not REG_SZ\n", type ); > - ok( !memcmp( valueW, testW, sizeof(testW) ), "value is not 'Test'\n" ); > + todo_wine{ > + ok( val_count == 5, "val_count set to %ld instead of 5\n", val_count ); > + } > + todo_wine{ > + ok( data_count == 24*sizeof(WCHAR), "data_count set to %ld instead of 24*sizeof(WCHAR)\n", data_count ); > + } > + todo_wine{ > + ok( type == REG_EXPAND_SZ, "type %ld is not REG_EXPAND_SZ\n", type ); > + } > + todo_wine{ > + ok( !memcmp( valueW, test1W, sizeof(test1W) ), "value is not 'Test1'\n" ); > + } > ok( !memcmp( dataW, xxxW, sizeof(xxxW) ), "data modified\n" ); > > /* no overflow */ > @@ -230,12 +276,25 @@ static void test_enum_value(void) > memcpy( valueW, xxxW, sizeof(xxxW) ); > memcpy( dataW, xxxW, sizeof(xxxW) ); > res = RegEnumValueW( hkey_main, 0, valueW, &val_count, NULL, &type, (BYTE*)dataW, &data_count ); > - ok( res == ERROR_SUCCESS, "expected ERROR_SUCCESS, got %ld\n", res ); > - ok( val_count == 4, "val_count set to %ld instead of 4\n", val_count ); > - ok( data_count == 7*sizeof(WCHAR), "data_count set to %ld instead of 7*sizeof(WCHAR)\n", data_count ); > - ok( type == REG_SZ, "type %ld is not REG_SZ\n", type ); > - ok( !memcmp( valueW, testW, sizeof(testW) ), "value is not 'Test'\n" ); > - ok( !memcmp( dataW, foobarW, sizeof(foobarW) ), "data is not 'foobar'\n" ); > + todo_wine{ > + ok( res == ERROR_MORE_DATA, "expected ERROR_MORE_DATA, got %ld\n", res ); > + } > + todo_wine{ > + ok( val_count == 5, "val_count set to %ld instead of 5\n", val_count ); > + } > + todo_wine{ > + ok( data_count == 24*sizeof(WCHAR), "data_count set to %ld instead of 24*sizeof(WCHAR)\n", data_count ); > + } > + todo_wine{ > + ok( type == REG_EXPAND_SZ, "type %ld is not REG_EXPAND_SZ\n", type ); > + } > + todo_wine{ > + ok( !memcmp( valueW, test1W, sizeof(test1W) ), "value is not 'Test1'\n" ); > + } > + todo_wine{ > + ok( !memcmp( dataW, xxxW, sizeof(xxxW) ), "data modified\n" ); > + } > + > > CLEANUP: > /* cleanup */ > @@ -252,6 +311,12 @@ static void test_query_value_ex() > ok(ret == ERROR_SUCCESS, "expected ERROR_SUCCESS, got %ld\n", ret); > ok(size == strlen(sTestpath1) + 1, "(%ld,%ld)\n", (DWORD)strlen(sTestpath1) + 1, size); > ok(type == REG_SZ, "type %ld is not REG_SZ\n", type); > + > + > + > + ret = RegQueryValueExA(hkey_main, "TestStringNotIn", NULL, &type, NULL, &size); > + ok(ret == ERROR_FILE_NOT_FOUND, "expected ERROR_FILE_NOT_FOUND, got %ld\n", ret); > + > } > > START_TEST(registry) It would help wine if you could make these tests pass on wine. Also, have a look at the test results at test.winehq.org/data. I see that 26 of the tests fail on 95, 24 fail on 98, and 28 for >= nt4. If you have any questions fixing the reg tests, I'd be glad to help. Make sure to cc wine-devel. -- James Hawkins

1 0