November 2006 - Wine-devel - list.winehq.org

Re: [winetest] Make sure we can send larger files
by Dimi Paun 05 Dec '06

05 Dec '06

On Thu, November 30, 2006 1:01 pm, Paul Vriens wrote: > I'm hitting the 1MB limit already with my win98 tests. Most other tests > are about to reach that threshold as well. I'd make it 2MB, what's 1MB these days... :) -- Dimi Paun <dimi(a)lattica.com> Lattica, Inc.

3 2

Re: make check_no_exec() work reliable
by Peter Beutner 04 Dec '06

04 Dec '06

Peter Beutner wrote: > Before starting to make this whole noexecute override behaviour configurable, > it first must work reliable. In its current form there is no guarantee that > the check_no_exec() function is actually called, because any other installed > exception handler might decide to handle the exception itself. > And as seen by the number of failing applications, this seems to happen > quite a lot. > This patch therefore makes check_no_exec() to be called before any other > exception handler. > > --- Any comments what is wrong with this one?

2 7

Call for DirectPlay captures
by Kai Blin 04 Dec '06

04 Dec '06

Hi folks, As you might know, I'm currently toying with figuring out the MS DirectPlay protocol. I've been making some progress with my wireshark dissector over the weekend, and would be interested in some additional games to get more different data on some of this stuff. Here's what I would like you to do (if you want to help out): Fire up a network sniffer that dumps to libpcap format. Grab TCP and UDP packets. Start a game that uses DirectPlay for networking and start a network game. Start the game on another box and connect to the game. Now, in the game lobby, use the chat to say something from both games. Then, change a setting or two and start the game. After a few moments of playing (or more, your pick), leave the game. After both games are closed, you can stop the capture, zip it up and send it to me. Thanks in advance, Kai -- Kai Blin, <kai Dot blin At gmail Dot com> WorldForge developer http://www.worldforge.org/ Wine developer http://wiki.winehq.org/KaiBlin/ -- Will code for cotton.

4 6

One more go at fixing GetCursorPos()
by Vitaliy Margolen 03 Dec '06

03 Dec '06

Here is one more shot at fixing GetCursorPos() to make it usable in dinput. This time I used a refcount of sorts. Because the problem appears only during processing of hook chain. Just to remind about what is the problem: when hook handler calls GetCursorPos() position returned is the "old" position. While hook parameters contain "new" coordinates. This is on windows. On Wine returned position queried directly from X and might be even "newer" then position in hook parameters. Attached are two tests (out of lots more that I've used to find and fix the problem). test_msg.c - tests major problem that Alexandre pointed out about last fix attempt. Application in question does not process messages while calling GetCursorPos(). It still works properly with proposed patch. di_mouse_2th.c - 2 threads showing that there are no extra thread local position involved (if there is such a thing). Cached cursor position is global to all threads. (Last numbers should stay at dt(0 0) at all times). Inside hook handler d(x y) should show relative mouse move delta. If anyone has any objections, comment, suggestions, please do send them. Vitaliy Margolen. #define COBJMACROS #define _WIN32_WINNT 0x0501 #include <windows.h> #include <windowsx.h> #include <stdio.h> static HANDLE event1, event2; static HINSTANCE g_hInstance; static POINT pt_global; LRESULT CALLBACK hook_proc( int code, WPARAM wparam, LPARAM lparam ) { MSLLHOOKSTRUCT *hook = (MSLLHOOKSTRUCT *)lparam; POINT pt; GetCursorPos(&pt); if (code == HC_ACTION) { fprintf(stderr, "Hook: code=%d w=%x [(%ld %ld) %lx %lx %lx] cur(%ld %ld) d(%ld %ld) ", code, wparam, hook->pt.x, hook->pt.y, hook->mouseData, hook->flags, hook->dwExtraInfo, pt.x, pt.y, hook->pt.x - pt.x, hook->pt.y - pt.y); pt_global = pt; SetEvent(event1); WaitForSingleObject(event2, INFINITE); } return CallNextHookEx( 0, code, wparam, lparam ); } static DWORD CALLBACK thread_proc(LPVOID arg) { while (WaitForSingleObject(event1, INFINITE) == WAIT_OBJECT_0) { POINT pt; GetCursorPos(&pt); fprintf(stderr, "Th: (%ld %ld) dt(%ld %ld)\n", pt.x, pt.y, pt.x - pt_global.x, pt.y - pt_global.y); SetEvent(event2); } return 0; } static DWORD wnd_proc(void) { MSG msg; while (GetMessage(&msg, NULL, 0, 0)) { TranslateMessage(&msg); DispatchMessage(&msg); } return msg.wParam; } #define SEND(x,y) \ i.mi.time = GetCurrentTime(); \ i.mi.dx = x; i.mi.dy = y; \ SendInput(1, &i, sizeof(INPUT)); void send_input(void) { INPUT i; POINT ptorg, pt; GetCursorPos(&ptorg); fprintf(stderr, "Cur pos: %ld %ld\n", ptorg.x, ptorg.y); i.type = INPUT_MOUSE; i.mi.dwFlags = MOUSEEVENTF_MOVE; i.mi.dwExtraInfo = 0; i.mi.mouseData = 0; SEND(-4, -4) GetCursorPos(&pt); fprintf(stderr, "%ld %ld\n", pt.x, pt.y); SetCursorPos(ptorg.x, ptorg.y); Sleep(250); fprintf(stderr, "***DONE***\n"); } void test1(HWND hwnd) { HANDLE thread; HHOOK hook; MSG msg; event1 = CreateEvent(NULL, FALSE, FALSE, NULL); event2 = CreateEvent(NULL, FALSE, FALSE, NULL); thread = CreateThread(NULL, 0, thread_proc, NULL, 0, NULL); Sleep(250); hook = SetWindowsHookExA(WH_MOUSE_LL, hook_proc, g_hInstance, 0); Sleep(250); // send_input(); wnd_proc(); while (PeekMessage( &msg, 0, 0, 0, PM_REMOVE )) DispatchMessage( &msg ); UnhookWindowsHookEx(hook); CloseHandle(event1); CloseHandle(event2); CloseHandle(thread); Sleep(250); } LRESULT CALLBACK WndProc(HWND hWnd, UINT message, WPARAM wParam, LPARAM lParam) { switch (message) { case WM_DESTROY: PostQuitMessage(0); return 0; } return DefWindowProc(hWnd, message, wParam, lParam); } int WINAPI WinMain(HINSTANCE hInstance, HINSTANCE hPrevInstance, LPSTR lpCmdLine, int nCmdShow) { WNDCLASSEX wcex; HWND hwnd; g_hInstance = hInstance; wcex.cbSize = sizeof(WNDCLASSEX); wcex.style = CS_HREDRAW | CS_VREDRAW; wcex.lpfnWndProc = (WNDPROC)WndProc; wcex.cbClsExtra = 0; wcex.cbWndExtra = 0; wcex.hInstance = hInstance; wcex.hIcon = NULL; wcex.hCursor = LoadCursor(NULL, IDC_ARROW); wcex.hbrBackground = (HBRUSH)(COLOR_WINDOW+1); wcex.lpszMenuName = NULL; wcex.lpszClassName = "MainWindow"; wcex.hIconSm = NULL; RegisterClassEx(&wcex); hwnd = CreateWindow("MainWindow", "Title", WS_OVERLAPPEDWINDOW, 10, 10, 200, 200, NULL, NULL, NULL, NULL); ShowWindow(hwnd, SW_SHOW); test1(hwnd); DestroyWindow(hwnd); return 0; } #include <windows.h> #include <stdio.h> int WINAPI WinMain(HINSTANCE hInstance, HINSTANCE hPrevInstance, LPSTR lpCmdLine, int nCmdShow) { LONG started = GetTickCount(); POINT pt, pt_org; HWND hwnd; MSG msg; hwnd = CreateWindow("static", "Title", WS_OVERLAPPEDWINDOW | WS_VISIBLE, 10, 10, 200, 200, NULL, NULL, NULL, NULL); GetCursorPos(&pt_org); while (PeekMessage( &msg, 0, 0, 0, PM_REMOVE )) DispatchMessage( &msg ); while (started + 10000 > GetTickCount()) { GetCursorPos(&pt); if ((pt.x - pt_org.x) || (pt.y - pt_org.y)) printf("(%ld %ld)\n", pt.x - pt_org.x, pt.y - pt_org.y); pt_org = pt; } DestroyWindow(hwnd); return 0; }

2 2

Re: user32: Factorize graphics driver's WindowCreate and ShowWindow in user32.
by Dmitry Timoshkov 01 Dec '06

01 Dec '06

"Pierre d'Herbemont" <pdherbemont(a)free.fr> wrote: > At the same time ShowWindow gets factorized because WindowCreate and > ShowWindow share both the use of WINPOS_MinMaximize, so it is easier to > factorize both functions in a single patch. In fact ShowWindow is > removed entirely from the drivers as it is driver independant. > > To properly factorize WindowCreate we have to export 3 new functions > from the graphics driver which are SetIconicState, SyncWindowStyle, > SystrayDockWindow. I'd suggest to leave ShowWindow in the driver's interface. You already have created 3 new entry points to replace its partial functionality, but still miss ShowWindow functionality for at least SW_RESTORE and SW_MAXIMIZE. Also did you run 'make test' after this patch? -- Dmitry.

2 3

How to embed wine into swt?
by Cloudor Pu 01 Dec '06

01 Dec '06

Hi, all I am developing an swt app only for gtk. I want to embed IE into this app. I can create a SWT.EMBEDDED composite and get its embededHandle (an integer). Then, how to do next? Thanks in advace! regards, cloudor

3 3

Re: msi: Add handling for the StartServices action [try2]
by Robert Shearman 30 Nov '06

30 Nov '06

James Hawkins wrote: > + scm = OpenSCManagerW(NULL, NULL, SC_MANAGER_ALL_ACCESS); This can be just SC_MANAGER_CONNECT instead. -- Rob Shearman

1 0

Re: msi: Add handling for the StartServices action
by Alexandre Julliard 30 Nov '06

30 Nov '06

"James Hawkins" <truiken(a)gmail.com> writes: > + p = args; > + do > + { > + if ((q = strstrW(p, separator))) *q = '\0'; > + > + (*numargs)++; > + vector = msi_realloc(vector, *numargs * sizeof(LPWSTR)); > + vector[*numargs - 1] = p; > + } while (q); This won't work for more than one arg. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: winemenubuilder: Look for supported color depths icons only. [resend]
by Frank Richter 29 Nov '06

29 Nov '06

On 30.11.2006 01:54, Vitaliy Margolen wrote: > Remove all the code simplification. This patch fixes icon extraction for > most steam games. All HL2 based games have .ico file with 32-bit colors. > Since we don't support those, Or write the icons as PNGs. -f.r.

2 4

Re: [AppDB] Allow maintainer request on app submission
by Chris Morgan 29 Nov '06

29 Nov '06

On Wednesday 29 November 2006 1:58 pm, Alexander Nicolaysen Sørnes wrote: > New and improved version. > > > Regards, > > Alexander N. Sørnes Looks a lot better. + // Allow user to apply as super maintainer if this is a new app + if(!$this->iAppId or $this->iAppId == "/") + { + if($this->bSuperMaintainerRequest) Why are you comparing the iAppId against a string containing a forward slash? + /* Approve automatically if submitted by an admin */ + if($_SESSION['current']->AppCreatedMustBeQueued()) + $this->sQueued = 'true'; + else + $this->sQueued = 'false'; + We probably want to make a new interface function here like MaintainerCreatedMustBeQueued() so we don't overload the meaning of this function. Today we aren't very particular about user roles but adding user roles is something we should do and keeping these privilages finely grained is useful. Also, the unit tests don't pass after this change. I suspect something related to the queueing changes: test_user_update_password() starting test_user_update_password() passed test_maintainer_getMaintainerCountForUser() starting test_maintainer_getMaintainerCountForUser() passed test_maintainer_getAppsMaintained() starting aAppsMaintained is null, we expected a non-null return value!<------------- test_maintainer_getAppsMaintained() failed! test_query_parameters() starting test_query_parameters() passed You can run these by going into the appdb/unit_test/ directory and executing ./run_tests from the command line. Make sure you don't have sendmail configured or you may end up sending emails around. We should really disable emailing at the start of the unit tests... Chris

1 0