November 2006 - Wine-devel - list.winehq.org

Re: [AppDB] Allow maintainer request along with app submission
by Chris Morgan 29 Nov '06

29 Nov '06

On Wednesday 29 November 2006 10:08 am, Alexander Nicolaysen Sørnes wrote: > Allow the user to submit a maintainer request along with an application, by > ticking a checkbox. > If the application is accepted, the maintainer request is accepted as well; > and if it is deleted or marked as a duplicate, the request is deleted. > These maintainer requests are not displayed in the queue. > > Also, maintainer requests submitted by an administrator are now > automatically approved. > > > Regards, > > Alexander N. Sørnes + if($hResultMaint) + { + $oMaintainer = mysql_fetch_row($hResultMaint); + $oMaintainer = new Maintainer($oMaintainer[0]); + } We don't want to overload the $oMaintainer variable here. Also, we want to use the name of the field you are accessing and not the index so we aren't asking ourselves what $oMaintainer[0] means. Also you'll want to check that mysql_fetch_row() actually returns a row prior to creating a new maintainer based upon it. This logic isn't quite right: + /* Reject super maintainer request if app is deleted or a duplicate */ + if(($aClean['sSub'] == "Reject" || $aClean['sSub'] == "Delete") && $hResultMaint) + { + $oMaintainter->reject("Deleting super maintainer request along with application entry."); + } + Rejecting an application doesn't mean deleting it so we don't want to delete or reject the maintainer request right there. Users can modify and resubmit applications after they have been rejected. The application class already handles the case where an application is deleted by calling Maintainer::deleteMaintainersForApplication() from Application::Delete(). In application.php: + if(makesafe($_REQUEST['bSmaintainerRequest'])) We should make the variable explicit, bSuperMaintainerRequest makes the purpose of this variable more clear. It's probably better to add a new variable to the class that we document as being used during application creation. That way we can modify Application::GetOutputEditorValues() to retrieve the value from the $aValues array passed in. This avoids having to makesafe() a $_REQUEST value, something that we really don't want to do anymore because eventually I think we'll want to clear out all non-standard entries in $_REQUEST as an additional protection against attacks from poorly checked input. The text here in the queries is too specific: "AND queued = '?' AND maintainReason != 'This user submitted the application; auto-queued.' ORDER by submitTime"; The query will fail if the text changes and we should assume it will. We need to do something like: select count(*) as queued_maintainers from appMaintainers, appFamily where appFamily.queued = 'true' and appMaintainers.queued = 'true' and appMaintainers.appId = appFamily.appId and appMaintainers.iSubmitterId != appMaintainers.iUserId; We also need to add a comment to getQueuedMaintainerCount() and to the sql to note that we are excluding queued maintainers that have applications queued as we will automatically submit them when the application is submitted. Chris

1 0

Re: mlang: Make user32 a delay load import
by Alexandre Julliard 29 Nov '06

29 Nov '06

Dmitry Timoshkov <dmitry(a)codeweavers.com> writes: > the only import from user32 which mlang uses is wsprintfW, and it's only used > by the DllRegisterServer code, so it's reasonable to move user32 to delay load > imports. As long as mlang imports ole32 which imports user32, there is nothing to gain by not importing user32 directly. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: d3d [1]: Remove AddRef from IWineD3DDevice_GetVertexDeclaration.
by H. Verbeet 29 Nov '06

29 Nov '06

On 28/11/06, Markus Amsler <markus.amsler(a)oribi.org> wrote: > The following patches remove refcounting in wined3d Getters. The > Setters/Creaters refcounting can't be removed right now, because of the > way implicit surfaces are currently handled. > > The idea is to simplify the d3dx<->wined3d refcount relation. Ideally > every wined3d object gets created with refcount=1, never AddRef'ed and > destroyed with the first Release call. Rob mentioned this violates COM > rules, but wined3d is wine internal. > > The GetParent patch doesn't remove wined3d refcounting, it seperates > d3dx and wined3d refcounting (Which was the reason I started to remove > AddRefs). > --- I think this is a bad idea, if only for consistency with other COM objects. I don't think wined3d being wine internal is a very good reason to violate COM rules. IMO if we're going to use COM we should stick to its rules. Also see my other mail.

4 10

Mozilla Sunbird install - Mystery bug #6613
by Mike McCormack 29 Nov '06

29 Nov '06

Anybody have time to help triage an install problem? Sunbird (and FireFox 2) installs run in an endless loop for some people. If you have time to try the install out and see if it works on your system, then comment on bug 6613, it would help out. http://bugs.winehq.org/show_bug.cgi?id=6613 I'm interested in which distro you're using, which filesystem, free disk space, locale, timezone, CPU (64bit or 32 bit?), etc. Mike

2 1

Re: ws2_32: Implement SO_GET_MAX_MSG_SIZE for getsockopt.
by Dmitry Timoshkov 28 Nov '06

28 Nov '06

"Kai Blin" <kai.blin(a)gmail.com> wrote: > +static void test_extendedSocketOptions() > +{ > + WSADATA wsa; > + SOCKET sock; > + struct sockaddr_in sa; > + int sa_len = sizeof(struct sockaddr_in); > + ULONG optval, optlen = sizeof(ULONG); Why to use ULONG if what you later cast it to is 'int *', and according to the docs (and your implementation) SO_MAX_MSG_SIZE expects sizeof(int) for the optval? ... > + if(bind(sock, (struct sockaddr *) &sa, (int)sa_len) < 0){ There is not need for a cast, sa_len has the type 'int'. > + trace("Failed to bind socket: 0x%08x\n", WSAGetLastError()); > + closesocket(sock); > + WSACleanup(); > + exit(1); This kills the whole process instead of terminating gracefully just this particular test. > + } > + > + ret = getsockopt(sock, SOL_SOCKET, SO_MAX_MSG_SIZE, (char *)&optval, (int *)&optlen); -- Dmitry.

2 1

Re: d3d [8]: Remove AddRef from IWineD3D*_QueryInterface. This also removes the implicit AddRef in IWineD3D*_GetContainer.
by H. Verbeet 28 Nov '06

28 Nov '06

I thought we discussed on IRC why this is a bad idea? Anyway, you can't do this. Removing the AddRef in QueryInterface is a pretty blatant violation of COM specs, and is pretty sure to cause problems somewhere. The caller of that function won't always know if the object it's called on is a wined3d object or not, and will depend on the behaviour of QueryInterface as defined by COM. Another thing is that know we get a situation where wined3d objects behave differently from all other COM objects. Also, if, as you stated earlier, the idea of these patches is *not* to get rid of COM in wined3d, I think they're a bad idea. Because in that case all it will do is make wined3d violate COM rules.

3 3

Re: [2/8] wined3d: Select the right shader backend when creating the device
by Ivan Gyurdiev 28 Nov '06

28 Nov '06

H. Verbeet wrote: > Changelog: > - Select the right shader backend when creating the device Imho there should be either ps_selected/vs_selected flags, or shader_backend flag, but definitely not both [ does not make sense ]. I'd opt for allowing different backends on pshader vs vshader. Maybe the current drawprim code is implemented to use ARB or GLSL for both, but that's not a good reason to disallow capability by writing future code as if the backend was unified. More importantly, you should be able to mix software shaders, with the other backends. I'm also not sure replacing all if statements with a function table is a good idea - restructuring code is dangerous, better not to do it unless new features are being added, or the code is being rewritten, or it's completely unmaintainable (I think that's a bit hard to argue).

3 9

Re: Vitaliy Margolen : wineshelllink: Use FreeDesktop standard to create Wine menu structure.
by Marcus Meissner 28 Nov '06

28 Nov '06

On Mon, Nov 27, 2006 at 12:51:03PM -0600, Alexandre Julliard wrote: > Module: wine > Branch: master > Commit: da3676229722eb76c8a91bf8165b09cc9e58455c > URL: http://source.winehq.org/git/wine.git/?a=commit;h=da3676229722eb76c8a91bf81… > > Author: Vitaliy Margolen <wine-patches(a)kievinfo.com> > Date: Fri Nov 24 13:53:29 2006 -0700 > > wineshelllink: Use FreeDesktop standard to create Wine menu structure. Umm. This means we (distributor) need to supply xdg utils also for all old distros, right? Ciao, Marcus

1 0

Re: ddraw/device.c: Fixed Thunk_IDirect3DDeviceImpl_1_AddViewport
by Stefan Dösinger 28 Nov '06

28 Nov '06

Am Montag 27 November 2006 11:23 schrieb Christoph Bumiller: > This is my first "patch" - I was trying an old game with wine > (Starfleet Academy), which crashed when using D3D, and I got the > following trace messages: > > trace:ddraw_thunk:Thunk_IDirect3DDeviceImpl_1_AddViewport > (0x1b440c)->(0x1f44f0) thunking to IDirect3DDevice3 interface. > trace:ddraw_thunk:Thunk_IDirect3DDeviceImpl_2_GetStats > (0x1b4408)->(0x1f44f0) thunking to IDirect3DDevice3 interface. > fixme:d3d7:IDirect3DDeviceImpl_3_GetStats (0x1b4408)->(0x1f44f0): Stub! > > This looks like Thunk_IDirect3DDeviceImpl_1_AddViewport called the > GetStats thunk > which called GetStats with the viewport as argument, where it set some > fields to > 0, which resulted in a segfault in IDirect3DViewportImpl_SetBackground > because IDirect3DViewportImpl->ddraw was NULL. Good catch, yeah, your patch is correct. I blamed native d3drm.dll of calling GetStats with a viewport, but it turns out that it was my fault in the end :-)

1 0

Re: riched20: Make ME_StreamIn create undos properly
by Matt Finnicum 28 Nov '06

28 Nov '06

I retract my claim of fixing that bug, but the patch still fixes the test / crashes / has great merit otherwise. --Matt On 11/27/06, Matt Finnicum <mattfinn(a)gmail.com> wrote: > This fixes an occasional crash/assertion in richedit that has been > around for a while. It also fixes a conformance test. I also believe > it fixed bug 6005 but I'll wait for the submitter to check it since I > found testing it confusing. > > Changelog: > Make ME_StreamIn create undos properly > --- > dlls/riched20/editor.c | 20 ++++++++++---------- > dlls/riched20/tests/editor.c | 2 -- > 2 files changed, 10 insertions(+), 12 deletions(-) > > >

1 0