December 2006 - Wine-devel - list.winehq.org

Re: mshtml #1: Added alert implementation. (resend)
by Alexandre Julliard 12 Dec '06

12 Dec '06

Jacek Caban <jacek(a)codeweavers.com> writes: > --- > dlls/mshtml/htmlwindow.c | 14 ++++++++++++-- > 1 files changed, 12 insertions(+), 2 deletions(-) It doesn't compile: gcc -c -I. -I. -I../../include -I../../include -D__WINESRC__ -DCOM_NO_WINDOWS_H -D_REENTRANT -fPIC -Wall -pipe -fno-strict-aliasing -Wdeclaration-after-statement -Wwrite-strings -Wpointer-arith -g -O2 -o htmlwindow.o htmlwindow.c htmlwindow.c: In function ‘HTMLWindow2_alert’: htmlwindow.c:200: error: ‘IDS_MESSAGE_BOX_TITLE’ undeclared (first use in this function) htmlwindow.c:200: error: (Each undeclared identifier is reported only once htmlwindow.c:200: error: for each function it appears in.) make[2]: *** [htmlwindow.o] Error 1 -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: kernel32: Allow the prefered language to be different from the prefered locale on Mac OS X by correctly setting LC_MESSAGES.
by Ken Thomases 12 Dec '06

12 Dec '06

On Dec 11, 2006, at 1:46 PM, Pierre d'Herbemont wrote: > This patch allows Mac OS X Users that set in System Preferences.app > a language (say English) and that don't use the default number and > text formatting currently associated with this language (for > instance if they use French number and text formatting), to have > Wine displaying text in their choosen language. And thus it allows > Wine to behave like 'regular' Mac OS X Applications. > > The only problem is that we have to translate the language id to a > locale id. > > Pierre. > --- > dlls/kernel32/locale.c | 54 +++++++++++++++++++++++++++++++++++++ > ++++++++++- > 1 files changed, 53 insertions(+), 1 deletions(-) > diff --git a/dlls/kernel32/locale.c b/dlls/kernel32/locale.c > index 8792623..345780f 100644 > --- a/dlls/kernel32/locale.c > +++ b/dlls/kernel32/locale.c > @@ -2832,7 +2841,50 @@ void LOCALE_Init(void) > unix_cp = CP_UTF8; /* default to utf-8 even if we don't get a > valid locale */ > setenv( "LANG", user_locale, 0 ); > TRACE( "setting locale to '%s'\n", user_locale ); > -#endif > + > + /* We still want to set the LC_MESSAGES env to what is the > prefered language in > + System Preferences.app, because it can differ from > CFLocaleCopyCurrent(). > + > + However this prefered language is stored using the general > language denotation > + that may not include the country code (en,fr,en-GB,...) > which is not accepted > + by setlocale (setlocale would expect en_US,fr_FR,en_GB,...). > + > + So we retrieve possible locales from /usr/share/locale and > intersect them > + with the prefered languages using > CFBundleCopyLocalizationsForPreferences. */ > + dir = opendir("/usr/share/locale"); > + available_locales = CFArrayCreateMutable(kCFAllocatorDefault, > 0, NULL); > + while ((file = readdir(dir))) > + { > + /* This filters the 'right' locales (xx_xx.UTF-8) */ > + if (strstr(file->d_name, ".UTF-8")) > + CFArrayAppendValue(available_locales, (void*) > CFStringCreateWithCString(kCFAllocatorDefault, > + file- > >d_name, kCFStringEncodingUTF8)); The above should use CFStringCreateWithFileSystemRepresentation instead of CFStringCreateWithCString. Also, you need to CFRelease the created string after adding it to the array. (The array manages its references, but that doesn't relieve you of the responsibility to manage your own.) > + } > + closedir(dir); I think the above code to scan /usr/share/locale is unnecessary. Doesn't CFLocaleCopyAvailableLocaleIdentifiers provide the equivalent? > + > + CFPreferencesAppSynchronize(kCFPreferencesAnyApplication); > + prefered_languages = CFPreferencesCopyValue( CFSTR > ("AppleLanguages"), kCFPreferencesAnyApplication, > + > kCFPreferencesCurrentUser, kCFPreferencesAnyHost); > + if(prefered_languages) > + { > + CFArrayRef intersected_locales = > CFBundleCopyLocalizationsForPreferences(available_locales, > prefered_languages); Do you need prefered_languages? The docs say that if you pass NULL for the second parameter of CFBundleCopyLocalizationsForPreferences, it uses the user's preferences. That would avoid you having to look them up, above. Also, "preferred" is spelled with three R's. > + CFStringRef user_language = NULL; > + > + if(CFArrayGetCount(intersected_locales)) > + user_language = CFArrayGetValueAtIndex > (intersected_locales, 0); > + if(user_language) > + { > + CFStringGetCString( user_language, user_locale, sizeof > (user_locale), kCFStringEncodingUTF8 ); > + CFRelease( user_language ); > + TRACE( "setting LC_MESSAGES to '%s'\n", user_locale ); > + setenv( "LC_MESSAGES", user_locale, 0 ); > + } > + CFRelease(prefered_languages); > + CFRelease(intersected_locales); > + } > + CFRelease(available_locales); > +#endif /* __APPLE__ */ > + > setlocale( LC_ALL, "" ); > > unix_cp = setup_unix_locales(); > >

3 4

Delphi Toolbar Icons not displayed correctly
by viny 12 Dec '06

12 Dec '06

Here http://home.scarlet.be/linux/compteco/test.zip , a little test program (with delphi 5 sources) that demonstrate a wrong display of the toolbar. With native comctl32, it's OK, but not with the builtin one. I would like to run this program (http://home.scarlet.be/linux/compteco/index.html) without native DLL. Thanks.

1 0

Re: comctl32: fix imagelist regression from "comctl32: Remove Nx1 assumptions in ImageList_Read"
by Peter Oberndorfer 11 Dec '06

11 Dec '06

On Sunday 10 December 2006 16:57, Peter Oberndorfer wrote: > The patch comctl32: Remove Nx1 assumptions in ImageList_Read (e74b0ee9102470d1b866e94c54527b34806cf876) > would produce black images on the toolbar of IDA Pro Demo after clicking one of the listviews on the right > > > Changelog: > comctl32: fix imagelist regression from "comctl32: Remove Nx1 assumptions in ImageList_Read" > remove unused HBITMAP hbmColor > It still leaks memory, when it fails to read the bitmap or the mask. I'll try to write a testcase to see what happens if one of them is missing. Greetings Peter

1 0

Re: fonts:add "framework" for tahoma font
by Dmitry Timoshkov 11 Dec '06

11 Dec '06

Louis. Lenders <xerox_xerox2000(a)yahoo.co.uk> wrote: > Hi, as there hasn't been any sign of life from someone who's doing > this now or in near future, and as no-one seems to know how exactly > this font could be added in a legal way, i decided to take the gauntlet > and give it a try. You seem to not be aware of Greenville, another (much more complete and compatible) Tahoma replacement. -- Dmitry.

3 3

Re: mscoree: Take advantage of an installed Mono for Windows to run .NET applications.
by Alexandre Julliard 11 Dec '06

11 Dec '06

Hans Leidekker <hans(a)it.vu.nl> writes: > + memset(&si, 0, sizeof(si)); > + si.cb = sizeof(si); > + if (!CreateProcessW(NULL, cmd_line, NULL, NULL, FALSE, 0, NULL, NULL, &si, &pi)) > + { > + HeapFree(GetProcessHeap(), 0, cmd_line); > + return -1; > + } > + > + if (WAIT_OBJECT_0 != WaitForSingleObject(pi.hProcess, 10000)) > + WARN("Timed out waiting for command to start\n"); This waits for the process to end. If you really want to wait for it to start you have to use something like WaitForInputIdle. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: DDraw: Protect IDirectDrawImpl against race conditions
by Alexandre Julliard 11 Dec '06

11 Dec '06

Stefan Dösinger <stefandoesinger(a)gmx.at> writes: > @@ -356,6 +373,8 @@ IDirectDrawImpl_SetupFullscreenWindow(ID > * Helper function that restores a windows' properties when taking it out > * of fullscreen mode > * > + * Assumes that the critical section is properly held > + * This seems dangerous, changing the window size will potentially send messages to other threads, so doing it inside the lock can cause deadlocks. -- Alexandre Julliard julliard(a)winehq.org

2 3

Re: OpenAL32.dll thunk and OpenAL winmm driver
by Stefan Dösinger 11 Dec '06

11 Dec '06

Am Sonntag 26 November 2006 00:25 schrieb Nick Burns: > dlls/openal32/openal.c: main thunk file > dlls/openal32/Makefile.in: simple thunk makefile > dlls/openal32/openal32.spec: openal+alut spec file > dlls/winmm/wineopenal/audio.c: main winmm driver file > dlls/winmm/wineopenal/Makefile.in: simple winmm makefile > dlls/winmm/wineopenal/openal.c: simple interface > dlls/winmm/wineopenal/openal.h: simple header for simple interface > dlls/winmm/wineopenal/wineopenal.drv.spec: winmm spec file I think you should send the thunk and winmm driver in 2 seperate patches

11 18

Hoiga salaray software
by Mattias Eriksson 11 Dec '06

11 Dec '06

Hi, I'm a user of Hogia salary software under wine. It works fine with wine 0.9.11 but something broke in 0.9.12. It has gotten better with the latest versions but it still has a bug that makes it not work. I have been in contact with the Hogia developers and they are willing to provide a demo version of the software for you to look at but they need some information about who they should contact? So if you just mail me some contact information and I'll forward them to the Hogia developers. //Mattias

3 2

Yet another benchmark: Sandra
by Dan Kegel 11 Dec '06

11 Dec '06

While looking around for windows benchmarks, I ran into http://www.mysimon.com/4520-6603_8-5020816-1.html which mentions a benchmark called Sandra. Sandra Lite is a free download available from http://www.sisoftware.net/?dir=dload&location=sware_dl_all There are two versions available for download: the one for win2k and up (done in 2006), and the one for win98 (done in 2004). The win2k one installs, but fails silently on startup. Wine says: ~/.wine/drive_c/Program Files/SiSoftware/SiSoftware Sandra Lite XIb$ ~/wine-git/wine sandra.exe fixme:actctx:FindActCtxSectionStringW 00000000 (null) 2 L"msvcr80.dll" 0x337acc fixme:actctx:CreateActCtxW 0x33fa30 00000088 ... fixme:wintrust:WinVerifyTrust 0xffffffff {00aac56b-cd44-11d0-8cc2-00c04fc295ee} 0x33edc0 fixme:crypt:CryptVerifyMessageSignature stub: 0x33ede0, 0, 0x6e81d8, 4296, (nil), 0x33edc4, 0x33edc0 fixme:actctx:ReleaseActCtx 0xf00baa ... and exits. The win98 one wants mdac 2.5 installed before installing, and fails to run because winscard.dll is not present. :-( So I guess Sanda doesn't like wine much at the moment. - Dan -- Wine for Windows ISVs: http://kegel.com/wine/isv

1 0