December 2006 - Wine-devel - list.winehq.org

Re: appdb/include application.php
by Tony Lambregts 08 Dec '06

08 Dec '06

WineHQ wrote: > ChangeSet ID: 30409 > CVSROOT: /opt/cvs-commit > Module name: appdb > Changes by: wineowner(a)winehq.org 2006/12/07 21:38:27 > > Modified files: > include : application.php > > Log message: > Alexander Nicolaysen Sørnes <alex(a)thehandofagony.com> > Use $this instead of $oApp since this method is referring to its class > > Patch: http://cvs.winehq.org/patch.py?id=30409 > > Old revision New revision Changes Path > 1.76 1.77 +2 -2 appdb/include/application.php > > Index: appdb/include/application.php > diff -u -p appdb/include/application.php:1.76 appdb/include/application.php:1.77 > --- appdb/include/application.php:1.76 8 Dec 2006 3:38:27 -0000 > +++ appdb/include/application.php 8 Dec 2006 3:38:27 -0000 > @@ -345,12 +345,12 @@ class Application { > { > case "add": > $sSubject = "Submitted application accepted"; > - $sMsg = "The application you submitted (".$oApp->sName." ".$this->sName.") has been accepted by ".$_SESSION['current']->sRealname."."; > + $sMsg = "The application you submitted (".$this->sName." ".$this->sName.") has been accepted by ".$_SESSION['current']->sRealname."."; This is not right. this will print the application name twice. it should be + $sMsg = "The application you submitted (".$this->sName.") has been accepted by .$_SESSION['current']->sRealname."."; > $sMsg .= "Administrators Responce:\n"; > break; > case "reject": > $sSubject = "Submitted application rejected"; > - $sMsg = "The application you submitted (".$oApp->sName." ".$this->sName.") has been rejected by ".$_SESSION['current']->sRealname."."; > + $sMsg = "The application you submitted (".$this->sName." ".$this->sName.") has been rejected by ".$_SESSION['current']->sRealname."."; same thing here > $sMsg .= "Clicking on the link in this email will allow you to modify and resubmit the application. "; > $sMsg .= "A link to your queue of applications and versions will also show up on the left hand side of the Appdb site once you have logged in. "; > $sMsg .= APPDB_ROOT."appsubmit.php?sub=view&apptype=application&appId=".$this->iAppId."\n"; > > >

1 0

Re: mshtml as html parser
by Kirill K. Smirnov 07 Dec '06

07 Dec '06

>> Just a little question: can wine's current implementation of mshtml.dll be >> used as html parser? I need to convert html code into a tree without >> displaying it. >You might want to use tidy and an XML pareser : >http://www-128.ibm.com/developerworks/library/x-tiptidy.shtml This way looks too complicated in the following case: I switched off from winhelp in favor of chmhelp - winhelp works somehow, but chmhelp not. chm content is an simple HTML file, which can be parsered by hands (like xCHM utility does), but if there is a library like mshtml (or msxml) why not use it? The only problem is I am afraid wine's mshtml has E_NOTIMPL in piece of codes looks interesting to me. (I do not understand the architcture of mshtml.dll to be sure). To stop wandering I decided to write a question here. So the question: can the wine's mshtml (as it is now) be used? I looked for smth like CreateHTMLDocument2(...) but failed. -- Kirill K. Smirnov

1 0

Change to fix Mac OS X
by Michael Casadevall 07 Dec '06

07 Dec '06

I've been tracking Wine for sometime in git, and attempting to build it on Mac OS X just to have repetitive failure. I finally had some time to look at the cause, and figured out that it was failing due to a prototype mismatch in dlls/dbghelp/dbghelp_private.h and dlls/ dbghelp/elf_loader.c. The problem is that the function elf_load_module uses a DWORD in elf_loader.c and an unsigned load in the dbghelp_private.h. I changed the header to a DWORD which fixed the compile right up and allowed it to successfully build Wine, but after talking to vitamin, this change might cause issues with Wine on 64-bit systems. Since I only own 32-bit, and know little about differences when programming 64-bit systems, I thought I should ask before I submit the patch to wine-patches. The full prototype and arguments are: dbghelp_private.h: extern struct module* elf_load_module(struct process* pcs, const char* name, unsigned long) elf_loader.c: struct module* elf_load_module(struct process* pcs, const char* name, DWORD addr) For good measure, I've also attached the patch to this email. Regard, Michael

3 4

Question about allocating memory for a Windows PE file
by Stephen Torri 07 Dec '06

07 Dec '06

I am trying to create a custom Windows PE loader (binary & DLL) for the purpose of security research. I am having a difficult time finding how to allocate memory for a binary at the desired address in memory (especially if its non-relocatable). I would like to see why I cannot get memory allocated at the exact address request in the binary headers. Is there a program or system call that allows me to see a list of memory address ranges allocated to the running processes on a system? Stephen

3 2

Re: [Wine] Re: Difference Between WINE and an Emulator
by Edward Savage 07 Dec '06

07 Dec '06

>An emulator is a specific type of program that mimics hardware. Windows > is not a piece of hardware, ergo Wine Is Not an Emulator. It's merely a > clone of the Windows API. This is probably the best answer you will get that is clear and simple. Out of interest the term I use to explain to others the concept is that WINE is a compatibility layer between Linux and Windows. Does that seem an accurate use of the word? It tends to set the right impression in the minds of the people I've explained it too.

3 2

Re: winex11.drv: Update cached cursor position after calling hook.
by Alexandre Julliard 07 Dec '06

07 Dec '06

Vitaliy Margolen <wine-patches(a)kievinfo.com> writes: > @@ -276,10 +274,12 @@ void X11DRV_send_mouse_input( HWND hwnd, > if ((injected_flags & LLMHF_INJECTED) && > ((flags & MOUSEEVENTF_ABSOLUTE) || x || y)) /* we have to actually move the cursor */ > { > - TRACE( "warping to (%d,%d)\n", pt.x, pt.y ); > + X11DRV_SetCursorPos( pt.x, pt.y ); > + } > + else > + { > wine_tsx11_lock(); > - XWarpPointer( thread_display(), root_window, root_window, 0, 0, 0, 0, > - pt.x - virtual_screen_rect.left, pt.y - virtual_screen_rect.top ); > + cursor_pos = pt; > wine_tsx11_unlock(); > } You need to update the position for button events too. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: ole32: Support reading and writing custom clipformats in the data cache.
by Alexandre Julliard 07 Dec '06

07 Dec '06

Robert Shearman <rob(a)codeweavers.com> writes: > --- > dlls/ole32/datacache.c | 106 > +++++++++++++++++++++++++++++++++++++++++------- > 1 files changed, 91 insertions(+), 15 deletions(-) This breaks make test: ../../../tools/runtest -q -P wine -M ole32.dll -T ../../.. -p ole32_test.exe.so ole2.c && touch ole2.ok ole2.c:1257: Test failed: IViewObject_Draw failed with error 0x80040007 ole2.c:1266: Test failed: IViewObject_Draw failed with error 0x80040007 ole2.c:1272: Test failed: IViewObject_Draw failed with error 0x80040007 -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: mshtml #3: Use HTMLWindow::alert in nsPromptService::Alert.
by Alexandre Julliard 07 Dec '06

07 Dec '06

Jacek Caban <jacek(a)codeweavers.com> writes: > @@ -39,6 +39,13 @@ WINE_DEFAULT_DEBUG_CHANNEL(mshtml); > > #define HTMLWINDOW2_THIS(iface) DEFINE_THIS(HTMLWindow, HTMLWindow2, iface) > > +typedef struct { > + struct list entry; > + HTMLWindow *window; > +} window_list_t; > + > +static struct list window_list = LIST_INIT(window_list); > + The right way to build a list of windows is to put the list entry directly in the HTMLWindow structure, there's no need for a separate structure. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: [PATCH] [WineCfg]: a few fixes for the French translation
by Jonathan Ernst 07 Dec '06

07 Dec '06

Le mercredi 06 décembre 2006 à 21:35 +0100, Eric Pouech a écrit : > - remove typos (ortaugraffe) > - set correct size for controls > - used correct space usage (for French) > [...] > - LTEXT "&Nouveau suclassage pour:",IDC_STATIC,16,58,100,8 > + LTEXT "&Nouveau suclassage pour :",IDC_STATIC,16,58,100,8 Could you please fix "suclassage" as well ;-) Thanks. Jonathan

1 0

Re: [PATCH 4/4] ole32: Support reading and writing custom clipformats in the data cache.
by Mike McCormack 07 Dec '06

07 Dec '06

Robert Shearman wrote: > + { > + char *format_name = HeapAlloc(GetProcessHeap(), 0, length); > + if (!format_name) > + return E_OUTOFMEMORY; > + GetClipboardFormatNameA(clipformat, format_name, length); > + hr = IStream_Write(stream, format_name, length, NULL); > + } You might want to free format_name at the end of that block. Mike

2 1