March 2006 - Wine-devel - list.winehq.org

Re: Store GL context in the TEB
by Tomas Carnecky 23 Mar '06

23 Mar '06

Mike Hearn wrote: > Mike Hearn <mike(a)plan99.net> > Optimize thunks by storing GL context in the thread environment block > good job. this fixed the BadMatch error in World of Warcraft and also increased performance, from ~20fps to ~25fps. tom

3 4

Keyboard fix - patch available
by penna＠bb.com.br 23 Mar '06

23 Mar '06

Hi all, Sorry for bothering you guys ..... but .... I saw a patch for bug #2400 (a very old bug) at http://bugs.winehq.org/show_bug.cgi?id=2400 Looking at the comments at the bugzilla tracking, the patch worked flawlessly for lots of keyboard types (croatian, german and russian), including mine: a brazilian abnt2 keyboard. The patch looks fine and very clean. The problem mentioned with remote X-windows access seems not to occur besides someone mention it. Anyway, at least the problem is gone with local access and, *if confirmed*, remains with remote access only. Maybe, just maybe, the patch could be applied for the next version of wine (0.9.11) .... ;-) Thank you very much for the very good piece of work: WINE (I use it since 1999). --------------------------------------------------------- Ulisses de Sousa Penna Analista Consultor - Banco do Brasil Fone: +55-61-3310-6320 Fax: +55-61-3310-6435 --------------------------------------------------------- P.S.: I am not subscribed at wine-devel list (just wine-users list)

1 0

IDE with Winemaker
by Ng, Billy H CIV NAVSEA 23 Mar '06

23 Mar '06

Hi, I am a Windows Developer who is new to the Linux world. Is there any IDE (like Visio Studio) I can use with Winemaker? I am trying to port a Windows App to Linux Fedora. Thanks, Billy.

3 2

Wiki access
by Tom Spear (Dustin Booker, Dustin Navea) 23 Mar '06

23 Mar '06

Could someone give me access to rename and delete pages in the wiki? I can't even rename or delete my own user page (!!) Thanks Tom

1 0

Re: advpack: Forward the remaining advpack.c ansi functions to their unicode counterparts
by Alexandre Julliard 23 Mar '06

23 Mar '06

"James Hawkins" <truiken(a)gmail.com> writes: > +HRESULT WINAPI SetPerUserSecValuesA(PERUSERSECTIONA* pPerUser) > +{ > + PERUSERSECTIONW perUserW; > + > + if (!pPerUser) > + return E_INVALIDARG; > + > + TRACE("(%p)\n", pPerUser); > + > + /* lengths copied from PERUSERSECTION structure definition */ > + MultiByteToWideChar(CP_ACP, 0, pPerUser->szGUID, 59, perUserW.szGUID, 59); > + MultiByteToWideChar(CP_ACP, 0, pPerUser->szDispName, 128, perUserW.szDispName, 128); > + MultiByteToWideChar(CP_ACP, 0, pPerUser->szLocale, 10, perUserW.szLocale, 10); > + MultiByteToWideChar(CP_ACP, 0, pPerUser->szStub, MAX_PATH * 4, perUserW.szStub, MAX_PATH * 4); > + MultiByteToWideChar(CP_ACP, 0, pPerUser->szVersion, 32, perUserW.szVersion, 32); > + MultiByteToWideChar(CP_ACP, 0, pPerUser->szCompID, 128, perUserW.szCompID, 128); The source lengths are wrong, these are null-terminated strings. Also please use sizeof() instead of hardcoding the constants. -- Alexandre Julliard julliard(a)winehq.org

3 2

Re: winedbg: Fix stepping over
by Eric Pouech 22 Mar '06

22 Mar '06

Petr Tesarik wrote: > Hi, > > this patch fixes a bug in winedbg, which caused it to continue > execution at a wrong address when stepping over a function call. > The trouble was that if there was no breakpoint found, the code at the > end of break_should_continue reversed the PC adjustment and later the > debugger resumed program execution AFTER the INT3 instruction, which > is clearly wrong. > Index: break.c > =================================================================== > RCS file: /home/wine/wine/programs/winedbg/break.c,v > retrieving revision 1.17 > diff -u -r1.17 break.c > --- break.c 27 Jan 2006 15:22:15 -0000 1.17 > +++ break.c 21 Mar 2006 10:36:07 -0000 > @@ -731,9 +731,13 @@ > if (code == EXCEPTION_BREAKPOINT) > addr->Offset += be_cpu->adjust_pc_for_break(&dbg_context, TRUE); > > + dbg_curr_thread->stopped_xpoint = find_xpoint(addr, be_xpoint_break); > dbg_curr_process->bp[0].enabled = FALSE; /* disable the step-over breakpoint */ > > - dbg_curr_thread->stopped_xpoint = find_xpoint(addr, be_xpoint_break); this part looks correct > + /* Unconditionally stop on the step-over breakpoint */ > + if (dbg_curr_thread->stopped_xpoint == 0) > + return FALSE; > + but this doesn't... you don't handle the count here... what you should do is only compute dbg_curr_thread->stopped_xpoint (and do the appropriate handling) when its current value is -1 (not found) A+ -- Eric Pouech

1 0

Easy applications to write automated tests for?
by Dan Kegel 22 Mar '06

22 Mar '06

I noticed a probable regression in an app (kid pix 3) tonight. Which got me thinking: what are the easiest set of application regression tests we could throw together that go further than just verifying the installer runs? I'm thinking not just of things that could be automated with cxtest, but also stuff that might not fit into that framework. In the case of Kid Pix 3, a test that simply started the app, waited ten seconds, and made sure an error dialog didn't pop up would have detected the problem. ('Course, only a few people would be able to run that, as Kid Pix 3 is not a free download.) cxtest should be able to handle that. A bit more complex would be to launch WinZip, have it compress one file, and make sure the compressed file was as expected. It shouldn't be too hard to make cxtest handle that. And then on the somewhat ambitious end, now that Sun's JVM basically installs and runs trivial programs, we could run through the Java regression test suite at http://sourceware.org/mauve/ Heck, I might give that a shot myself. There's probably no reason to try to shove that into cxtest, is there? Or would it fit? And beyond the looking glass, one could imagine running the OpenOffice 2.0 automated test suite. (That's unlikely to work well at the moment, given that OpenOffice 2.0's open dialog locks up reliably.) That would probably flush out a few problems. - Dan -- Wine for Windows ISVs: http://kegel.com/wine/isv

4 11

Re: WIDL: Add missing ignore attribute. Check for inapplicable attributes in typedef.
by Alexandre Julliard 22 Mar '06

22 Mar '06

Saveliy Tretiakov <saveliyt(a)mail.ru> writes: > ChangeLog: > Saveliy Tretiakov <saveliyt(a)mail.ru> > - Add missing ignore attribute. > - Check for inapplicable attributes in typedef. Changed attribute > parsing in a way Mike McCormack suggested. > - Register type alias in typelib, if ATTR_PUBLIC is set. I think checking values explicitly is preferable to encoding them in the syntax, since it gives you a chance to provide meaningful errors. If you rely on the parser all you'll get is a generic "syntax error" with no clue to what you did wrong. -- Alexandre Julliard julliard(a)winehq.org

2 1

Re: advpack: Forward AddDelBackupEntryA to its unicode counterpart
by Alexandre Julliard 22 Mar '06

22 Mar '06

"James Hawkins" <truiken(a)gmail.com> writes: > + do > + { > + MultiByteToWideChar(CP_ACP, 0, ansi_list, len, ptr, len); > + > + ansi_list += len; > + ptr += len; > + > + len = lstrlenA(ansi_list) + 1; > + size += len * sizeof(WCHAR); > + list = HeapReAlloc(GetProcessHeap(), 0, list, size); > + } while (*ansi_list); You are assuming that A and W have the same length, that's wrong. Also it will be quite expensive to resize the list all the time. You should determine the full length of the list and then convert everything in one go. -- Alexandre Julliard julliard(a)winehq.org

1 0

linux mmap bug ? not filling in allocation gaps
by Geoff Brimhall 22 Mar '06

22 Mar '06

I've been debugging why an n64 emulator ( Project64 ) gets "Failed to allocate memory" errors under wine 9.9.10 on linux kernel 2.6. The program allocates a large chunk of size 0x20100000, which succeeds, and then another large 0x10100000 chunk, which fails. WINEDEBUG=+relay,+virtual eventually brought me to look at the linux /proc/<pid>/maps to see if the address space was really fully allocated. Here's what I noticed: Address start - end: 00400000-0554000 - Project64.exe address 00554000-20000000 ---p large mem allocation *** <gap> *** 55555000-573e0000 - loaded shared libraries 573e0000-774e0000 ---p mem alloc of 0x20100000 7bf00000-7c003000 - wine-pthread 7c003000-7c1ee000 - [heap] 7ffe0000-fffe0000 ---p large mem allocation ffff7000-fffff000 - [stack] Wrote a test mmap binary to fill a process address space, it created a similar gap between the executable load address and the loaded shared libraries, eventually failing mmap calls when it hit the stack address space. When I updated the test app to explicitly mmap in the gap area via specifying the aligned start address, the mmap call succeeded. I can't be the first person to notice this. Are there any TODO solutions for this ? One linux-centric solution would be to look for gaps like this in /proc/<pid>/maps in the libs/wine/mmap.c and take advantage of this. Or maybe another would be to keep a table of address spaces returned in wine_anon_mmap as a guide, then validate with try_mmap_fixed as to where a next-allocation should occur ( would this solution work outside linux ) ? Thanks, geoff Brimhall __________________________________________________ Do You Yahoo!? Tired of spam? Yahoo! Mail has the best spam protection around http://mail.yahoo.com

3 2