March 2006 - Wine-devel - list.winehq.org

Fwd: Regression: new systray implementation ... - analysis, demo, etc.
by qingdoa daoo 19 Mar '06

19 Mar '06

http://bugs.winehq.org/show_bug.cgi?id=4853 --------------------------------- Yahoo! Mail Use Photomail to share photos without annoying attachments.

1 0

rpaths not working?
by Mike Hearn 19 Mar '06

19 Mar '06

Hi Alexandre, On my system at least it seems DLLs need the rpaths too, from a clean build of HQ git tree I get this when starting: 8697: file=/opt/wine/lib/wine/ntdll.dll.so [0]; needed by /opt/wine/bin/../lib/libwine.so.1 [0] 8697: file=/opt/wine/lib/wine/ntdll.dll.so [0]; generating link map 8697: dynamic: 0x7ffd52dc base: 0x7ff63000 size: 0x0007cb58 8697: entry: 0x7ff6f000 phdr: 0x7ff63034 phnum: 5 8697: 8697: 8697: file=libwine_unicode.so.1 [0]; needed by /opt/wine/lib/wine/ntdll.dll.so [0] 8697: 8697: file=/opt/wine/lib/wine/ntdll.dll.so [0]; destroying link map wine: failed to initialize: libwine_unicode.so.1: cannot open shared object file: No such file or directory And sure enough the .dll.so files don't have an $ORIGIN/../ runpath in them. This seems like winebuild magic, at least, I didn't see any obvious places in the build system to add the flags. Any idea what's going wrong here? thanks -mike

2 2

Re: opengl32: make the old code before the "sync the dibsection to its pixmap" patch be selectable at runtime
by Leon Freitag 19 Mar '06

19 Mar '06

> I don't see any other way to speed this up the way it's being synced now, the > question is however, whether the apps really _should_ modify the bitmap on > windows too (don't know whether they would try to draw controls onto the > window and then it would be overdrawn by the opengl image; application like > Steam are trying to achieve similar, but they seemed to work well before) > Does this very rough&ready patch work any better? I'm getting undefined references to `___tls_get_addr' when trying to build with this patch. However my ld has this symbol for sure... $ nm /lib/ld-2.3.5.so | grep __tls_get_addr 0000dfc0 T ___tls_get_addr 0000d9d0 T __tls_get_addr 0000dfc0 t ___tls_get_addr_internal > If this patch improves performance I'll fix it to use Win32 TLS instead > of ELF TLS, it'll be interesting to see if that changes makes a > difference too. perhaps it will compile on my machine then... Leon

3 3

Function counting script
by Segin 19 Mar '06

19 Mar '06

As my small contribution, attached is a small shell script that, unmodified, finds out how many times certain functions are called in a given sample of files. The default functions are 'malloc', 'realloc', and 'free', and the sample files are all files ending in .c in the current directory. It even prints out the result in a neat manner on ANSI colourized terminals. The script is very flexible, and easy to modify. Current version is 256bytes long.

3 6

How hard would it be to support Java?
by Dan Kegel 19 Mar '06

19 Mar '06

Quite a few apps use embedded JVM's. Case in point: SPSS, one of the apps requested by Munich. So I played around a bit with Sun's latest 1.5 JRE. It can run trivial apps, so I closed http://bugs.winehq.org/show_bug.cgi?id=2953 (ok, maybe that was premature, since the bug was for Sun's 1.4 JRE). But it can't run applets; first, it runs into a nasty glx error, http://bugs.winehq.org/show_bug.cgi?id=4143 Once you patch your way past that, it complains about not finding a native method, see http://bugs.winehq.org/show_bug.cgi?id=4873 And it doesn't show up in Firefox's about:plugins by default, see http://bugs.winehq.org/show_bug.cgi?id=4860 Can anyone shed some light on these, especially bug 4143? Thanks, Dan -- Wine for Windows ISVs: http://kegel.com/wine/isv

4 5

msys on wine - partial success
by Dan Kegel 19 Mar '06

19 Mar '06

Last year, I poked at using msys under wine: http://www.winehq.com/hypermail/wine-devel/2004/04/0149.html but didn't follow up on the hint that wineconsole would help. Finally got around to it. Sure enough, you can run msys's sh.exe in a wineconsole! It's ugly and can't seem to run configure scripts yet, but it does run simple shell scripts and interactive commands like cd, pwd, and ls. Sort of. Here's what I tried: Installing http://easynews.dl.sourceforge.net/sourceforge/mingw/MSYS-1.0.10.exe created c:\msys\1.0. Looking in that directory, I saw a script MSYS.BAT that one uses to start a shell. Rather than figuring out how to invoke that batch file in Wine, I read it, saw that it invoked sh as "sh --login -i", and wrote a little shell script that did something similar: wineconsole ~/.wine/drive_c/msys/1.0/bin/sh.exe --login -i This had problems with the path -- it couldn't find msys's external commands. Running "echo $PATH" showed that it defaulted to including /mingw/bin, so I cheated and added a symlink: ln -s ~/.wine/drive_c/msys/1.0 ~/.wine/drive_c/mingw That worked; I can now use msys's external commands in the msys sh. I probably should have modified the PATH, but that was hard to script. The ugly part is, when you give any command, the first thing that happens is a pair of warnings: sh: fork: No such file or directory sh: child setpgid (-45 to -50): Invalid argument And if you try to run mauve's configure script. it stops after the second statement. It seems that anything involving subshells or eval confuses it greatly. Also, if you're not very careful with the first command you type, it gets into a bad state where it ignores half the keys you type, or something. All in all not very healthy, but that's not too surprising for a first try. - Dan -- Wine for Windows ISVs: http://kegel.com/wine/isv

1 0

Re: patch opengl.c, wgl.c
by Leon Freitag 19 Mar '06

19 Mar '06

> This is not a patch but rather partial reversal of the patch that caused > this regression. It's not a complete reversal though. That doesn't imply that it's not a fix. Perhaps the original patch had a bug in it. > - GLXDrawable drawable; > - enum x11drv_escape_codes escape = X11DRV_GET_GLX_DRAWABLE; > + Drawable drawable; > + enum x11drv_escape_codes escape = X11DRV_GET_DRAWABLE; This part seems to be very interesting. > It works for all my opengl applications, including GoogleEarth, World of > Warcraft (wow -opengl), Warcraft III, 3DEditor, Iconoclast, Glview > & Moray 3.5. Tested on latest CVS with Nvidia > 6800 graphics card on my 64 bit OS, Fedora Core 4_64, AMD64. That's more than an argument. Yet there's no application that has been broken with it. > + if (ppfd->>dwFlags & PFD_DRAW_TO_BITMAP) { > + ERR("Flag not supported !\n"); > + /* Should SetError here... */ > + return 0; > + } Well Wine should report ERRs instead of crashing with an Xlib error, shouldn't it? OK, if you don't like these five lines so much, does the patch work without it? Leon

1 0

Re: kernel/heap: Avoid heap corruption on invalid Parameter in GlobalFree(), with Test
by Dmitry Timoshkov 19 Mar '06

19 Mar '06

"Detlef Riekenberg" <wine.dev(a)web.de> wrote: > --- a/dlls/kernel/tests/heap.c > +++ b/dlls/kernel/tests/heap.c > @@ -25,6 +25,8 @@ > #include "winbase.h" > #include "wine/test.h" > > +#define MAGIC_DEAD 0x00dead00 > + SetLastError(MAGIC_DEAD); > + hsecond = GlobalFree(gbl); /* invalid handle: free memory twice */ There is no need to invent a new magic number, a usual convenience for Wine tests is to use 0xdeadbeef. -- Dmitry.

1 0

Re: WINEFILE: Eliminate use of windowsx.h
by Mike McCormack 19 Mar '06

19 Mar '06

Martin Fuchs wrote: > "Eliminating" windowsx.h sounds like you consider this header file a bad thing. > I don't think so - it provides a bunch of very usefull type safe macro definitions. > (SelectFont, ListBox_SetSel, Button_SetCheck, ...) > > I understand you want to eliminate some useless warnings printed by > newer GCC versions. Wouldn't it be better to correct the wrong warnings > of GCC instead? Please see my previous email for a discussion of the problem: http://www.winehq.org/pipermail/wine-devel/2006-March/045250.html Despite containing some useful macros, those macros are somewhat broken as they are ignorant of UNICODE, so cannot be "fixed" by simple conversion to inline functions. Mike

3 5

Re: patch opengl.c, wgl.c
by Vitaliy Margolen 19 Mar '06

19 Mar '06

Saturday, March 18, 2006, 11:48:12 AM, Henry Kroll wrote: > Changelog: > Henry Kroll, admin(a)comptune.com corrects X "bad match" errors when > running opengl apps. > Ref: http://bugs.winehq.org/show_bug.cgi?id=4143 > ========================== > --- wine/dlls/x11drv/opengl.c.orig 2006-03-11 11:58:01.000000000 -0900 > +++ wine/dlls/x11drv/opengl.c 2006-03-11 11:58:09.000000000 -0900 > @@ -199,6 +199,12 @@ > dump_PIXELFORMATDESCRIPTOR((const PIXELFORMATDESCRIPTOR *) ppfd); > } + if (ppfd->>dwFlags & PFD_DRAW_TO_BITMAP) { > + ERR("Flag not supported !\n"); > + /* Should SetError here... */ > + return 0; > + } > + > /* Now, build the request to GLX */ [skip] This is not a patch but rather partial reversal of the patch that caused this regression. You should fix this and not revert it back to what it was before. Unless you have a prove that this is the way native works. Vitaliy Margolen

1 0