April 2006 - Wine-devel - list.winehq.org

Re: [coverity] fix dereferencing a potential NULL pointer.
by Dimi Paun 08 Apr '06

08 Apr '06

On Sat, 2006-04-08 at 12:48 +0200, Rein Klazes wrote: > dlls/user : menu.c > Fix dereferencing a potential NULL pointer. This patch seems to be doing more than avoiding a NULL dereference. Also, can you also mention which pointer can be NULL? -- Dimi Paun <dimi(a)lattica.com> Lattica, Inc.

2 1

wine-patches archive attachments have strange mime type?
by Dan Kegel 08 Apr '06

08 Apr '06

When I'm looking at the wine-patches archives, e.g. at http://winehq.org/pipermail/wine-patches/2006-April/025521.html and the patch is an attachment, the archive's link to the attachment, e.g. http://www.winehq.org/pipermail/wine-patches/attachments/20060408/64e34006/… can't be displayed by my copy of Firefox; it doesn't recognize the DIFF or PATCH mime types. I tried adding them in /etc/mime.types, and I tried looking for a way to set them in Firefox, but no joy. Should the server be serving these up as mime type text/plain? - Dan -- Wine for Windows ISVs: http://kegel.com/wine/isv

1 0

Dogfood gone runny: fonts awful in firefox
by Dan Kegel 08 Apr '06

08 Apr '06

Seems like the recent font patches have caused trouble in both Firefox. In Firefox, I have to install corefonts for text to be legible at all lately. Is this expected? -- Wine for Windows ISVs: http://kegel.com/wine/isv

2 2

Re: Makefile.in: Fix broken ctags/etags-targets
by Alexandre Julliard 08 Apr '06

08 Apr '06

Detlef Riekenberg <wine.dev(a)web.de> writes: > "make etags" and "make ctags" are broken. What's broken about them? -- Alexandre Julliard julliard(a)winehq.org

2 5

Re: PATCH: makedep warning
by Alexandre Julliard 08 Apr '06

08 Apr '06

Marcus Meissner <marcus(a)jet.franken.de> writes: > glibc 2.4 + FS=2 makes it warn on ftruncate result > handling. The result cannot be -1 actually, but > check for it anyway. > > Ciao, Marcus > > Changelog: > Check result of ftruncate(). Please don't do that, it's useless. -- Alexandre Julliard julliard(a)winehq.org

1 0

msvcrt: handle inheritance problem
by qingdoa daoo 08 Apr '06

08 Apr '06

HI all, Recently I have been trying to improve support for some MinGW based IDEs without native msvcrt. Now I am dealing with a problem with standard io handle redirection which prevents output from gcc tools from being piped to IDE message windows. I have been able to find that the problem is related to this patch on dlls/msvcrt/file.c http://cvs.winehq.org/cvsweb/wine/dlls/msvcrt/file.c.diff?r1=1.59&r2=1.60&f… It has a one line changlog saying: Duplicate stdin/stdout handles to avoid closing them when library is unloaded. If I revert file.c to pre-patch state, redirection works fine. But am not sure if there will be unexpected consequences. So I searched the wine-patch and wine-devel archives but didn't find the patch or any discussion about it. Could someone explain what exactly that changelog line means? A simple test program ------------------------------------------------------------------------ #include "stdio.h" #include "process.h" int main(int argc, char* argv[]) { if( argc == 1 ) { char *argv2[] = { argv[0], "foo", NULL }; _spawnv(_P_NOWAIT, argv[0], argv2); } else { puts("This won't print with builtin msvcrt"); } return 0; } --------------------------------- Love cheap thrills? Enjoy PC-to-Phone calls to 30+ countries for just 2¢/min with Yahoo! Messenger with Voice.

1 0

FFXI Winsock Question
by Andres Mejia 08 Apr '06

08 Apr '06

I'm having a problem with staying connected while logged in to the PlayOnline service of FFXI. The only debug message I keep finding is a warning that goes "warn:winsock: WSAErrno errno 4 (Interrupted system call)." I already submitted a bug for this but I'm wondering if there was anymore I could do. What I'm asking is, have I done enough or is there something more that I can do to help with fixing this bug?

1 0

NtProtectVirtualMemory
by Segin 07 Apr '06

07 Apr '06

Could someone clue me in to just what this means and why it is: err:virtual:NtProtectVirtualMemory Unsupported on other process A quick Google comes up that function is undocumented, so I don't have much info on it. From the wine source: if (!is_current_process( process )) { ERR("Unsupported on other process\n"); return STATUS_ACCESS_DENIED; } And that's self explanitory, but why is it "Unsupported on other process"?

5 8

Re: WineD3D: Allow the inclusion of the wined3d headers when the ddraw headers are included
by Alexandre Julliard 07 Apr '06

07 Apr '06

Stefan Dösinger <stefandoesinger(a)gmx.at> writes: >> Alexandre, if you think >> that it should be in the wined3d headers, you can add >> #define MAKEFOURCC(a,b,c,d) ((a << 0) | (b << 8) | (c << 16) | (d << 24)) >> in line 169 in wined3d_interface.h, or ask me to send a patch for that. > Forget about that, I forgot that wined3d_types is included before that line. > Attached is a patch which creates WINEMAKEFOURCC and uses this. Windows has a MAKEFOURCC in ddraw.h too, probably you should use that instead. -- Alexandre Julliard julliard(a)winehq.org

1 0

server: Fix for possible desktop variable being NULL when set_process_default_desktop is called
by Dan Kegel 07 Apr '06

07 Apr '06

Mike Hearn wrote: >I'm not really convinced a static >analysis can catch things that we "know" cannot happen (eg it'd be a >violation of the X protocol or something) and so rely on them without >explicit checks. To be secure, I think we have to handle X protocol violations, too. - Dan -- Wine for Windows ISVs: http://kegel.com/wine/isv

1 0