April 2006 - Wine-devel - list.winehq.org

Coverity Open Source Defect Scan of Wine
by Ben Chelf 07 Apr '06

07 Apr '06

Hello Wine Developers, As some of you may have heard, last month Coverity set up http://scan.coverity.com as a site dedicated to scanning open source projects for defects. In just 1 month, over 4500 defects have been examined by various open source developers, and from what we can tell, it seems that there have been over 2500 patches to the scanned code bases! Due to popular request, I’m happy to announce that we’ve added Wine to the list of projects scanned on the site. For those of you not familiar with "scan" yet and by way of introduction ... I'm the CTO of Coverity, Inc., a company that has technology that performs static source code analysis to look for defects in code. You may have heard of us or of our technology from its days at Stanford (the "Stanford Checker"). The reason I'm writing is because we have set up a framework internally to continually scan open source projects and provide the results of our analysis back to the developers of those projects. To see the results of the project, check out: http://scan.coverity.com My belief is that we (Coverity) must reach out to the developers of these packages (you) in order to make progress in actually fixing the defects that we happen to find, so this is my first step in that mission. Of course, I think Coverity technology is great, but I want to hear what you think and that's why I worked with folks at Coverity to put this infrastructure in place. The process is simple -- it checks out your code each night from your repository and scans it so you can always see the latest results. Right now, we're guarding access to the actual defects that we report for a couple of reasons: (1) We think that you, as developers of Wine, should have the chance to look at the defects we find to patch them before random other folks get to see what we found and (2) From a support perspective, we want to make sure that we have the appropriate time to engage with those who want to use the results to fix the code. Because of this second point, I'd ask that if you are interested in really digging into the results a bit further for your project, please have a couple of core maintainers and/or developers reach out to us to request access. As this is a new process for us and still involves a small number of packages, I want to make sure that I personally can be involved with the activity that is generated from this effort. So I'm basically asking for people who want to play around with some cool new technology to help make source code better. If this interests you, please feel free to register on our site or email me directly. And of course, if there are other packages you care about that aren't currently on the list, I want to know about those too. If this is the wrong list, my sincerest apologies and please let me know where would be a more appropriate forum for this type of message. Many thanks for reading this far... -ben Ben Chelf Chief Technology Officer Coverity, Inc.

2 1

Building in Unicode mode
by Sergio 06 Apr '06

06 Apr '06

Hi, I am trying to compile something that needs to be compiled defining UNICODE and _UNICODE but I am getting this error: In file included from plugins/yapp/../../include/m_database.h:67, from plugins/yapp/stdafx.h:39, from plugins/yapp/options.cpp:1: /usr/include/wine/windows/tchar.h:27:2: error: #error You must use msvcrt when building in Unicode/MBCS mode I tried defining __WINE_USE_MSVCRT but it did not help. Does anyone have any idea of how to solve this problem? Thank you in advance. Sergio.

1 0

Re: [coverity] Don't close uninitialized handle on VXD error path
by Andrey Turkin 06 Apr '06

06 Apr '06

I thought INVALID_HANDLE_VALUE==-1 and not 0. Moreover, I can't see any code path leading to ERR where handle is allocated (or assigned to) at all so I think there is no need to close it. Mike Hearn wrote: > Mike Hearn <mike(a)plan99.net> > Don't close uninitialized handle on VXD error path > > diff --git a/dlls/kernel/vxd.c b/dlls/kernel/vxd.c > index 5d16684..2a004a0 100644 > --- a/dlls/kernel/vxd.c > +++ b/dlls/kernel/vxd.c > @@ -179,7 +179,7 @@ HANDLE VXD_Open( LPCWSTR filenameW, DWOR > { > static const WCHAR dotVxDW[] = {'.','v','x','d',0}; > int i; > - HANDLE handle; > + HANDLE handle = INVALID_HANDLE_VALUE; > HMODULE module; > WCHAR *p, name[16]; > > @@ -254,10 +254,14 @@ HANDLE VXD_Open( LPCWSTR filenameW, DWOR > } > > ERR("too many open VxD modules, please report\n" ); > - CloseHandle( handle ); > + > + if (handle) > + { > + CloseHandle( handle ); > + handle = 0; > + } > FreeLibrary( module ); > - handle = 0; > - > + > done: > RtlLeaveCriticalSection( &vxd_section ); > if (!DuplicateHandle( GetCurrentProcess(), handle, GetCurrentProcess(), &handle, 0, > > >

1 0

strange win in 2006 SourceForge.net Community Choice Awards
by Marcus Meissner 06 Apr '06

06 Apr '06

Hi, The 2006 SourceForge.net Community Choice Awards have been announced ... and it seems the Desktop Winner is: "WINE ..... for Darwin and Mac OS X" Strangely enough, our project directly does not appear to be listed at all in the "Desktop" category. Still considering whether to be sad or happy. I have now added us to the "Desktop environment" category. Ciao, Marcus

1 0

Re: fonts: Add the Won sign in place of the backslash for Korean fonts
by Huw D M Davies 06 Apr '06

06 Apr '06

On Thu, Apr 06, 2006 at 12:45:01PM +0100, Huw D M Davies wrote: > Huw Davies <huw(a)codeweavers.com> > fonts: Add the Won Sign in place of the backslash for Korean fonts Actually could you ignore this for the moment? Dmitry's got a patch that's about to arrive that'll clash with this, and this one is much easier to regenerate. Huw. -- Huw Davies huw(a)codeweavers.com

1 0

Invisible fonts regression
by Ivan Gyurdiev 06 Apr '06

06 Apr '06

I am no longer able to see fonts in: - the GTA installer - for example on the intial screen ("What language to use?") - Steam (*with* Tahoma previously installed and working). When selecting menus fonts will flash quickly making the menu visible, and then disappear. In addition, when re-creating a new clean wine root, I also lose the ability to see fonts in winecfg. This is Wine 0.9.11 on Fedora Rawhide x86_64. There is no error output. The Steam problem was in the last release as well. What should I do to track down the problem?

5 8

SimCity 4 and hardware rendering -- Not working.
by Segin 06 Apr '06

06 Apr '06

As usual, I went out and found something else to test. SimCity 4 Deluxe works, impeckably well, but it only does software rendering (which can literally bring your system to it's knees). I use a patched .exe cause the default one didn't work for me (and this one has a no-cd deal, plus is smaller). Anyways, when starting in Direct3D mode, it goes to a back window, but quickly flashes back to your desktop, with this debug: err:ddraw:set_render_state Unhandled dwRenderStateType D3DRENDERSTATE_LINEPATTERN (0000000a) value : 00000000 ! err:ddraw:set_render_state Unhandled dwRenderStateType D3DRENDERSTATE_MONOENABLE (0000000b) value : 00000000 ! err:ddraw:set_render_state Unhandled dwRenderStateType D3DRENDERSTATE_ROP2 (0000000c) value : 0000000d ! err:ddraw:set_render_state Unhandled dwRenderStateType D3DRENDERSTATE_PLANEMASK (0000000d) value : ffffffff ! err:ddraw:set_render_state Unhandled dwRenderStateType D3DRENDERSTATE_LASTPIXEL (00000010) value : 00000001 ! err:ddraw:set_render_state Unhandled dwRenderStateType D3DRENDERSTATE_ZVISIBLE (0000001e) value : 00000000 ! err:ddraw:set_render_state Unhandled dwRenderStateType D3DRENDERSTATE_EDGEANTIALIAS (00000028) value : 00000000 ! err:ddraw:set_render_state Unhandled dwRenderStateType D3DRENDERSTATE_RANGEFOGENABLE (00000030) value : 00000000 ! err:ddraw:set_render_state Unhandled dwRenderStateType D3DRENDERSTATE_EXTENTS (0000008a) value : 00000000 ! err:ddraw:set_render_state Unhandled dwRenderStateType D3DRENDERSTATE_VERTEXBLEND (00000097) value : 00000000 ! It then resumes loading in software rendering.

3 2

WINE & Microsoft WGA
by Marcus Meissner 06 Apr '06

06 Apr '06

Hi, Just found by random websearch... http://www.microsoft.com/genuine/downloads/FAQ.aspx?displaylang=en ... Q: Will systems running WINE pass WGA validation? A: Wine is an implementation of the Windows 3.x and Win32 APIs on top of X and Unix. When WGA validation detects WINE running on the system, it will notify users that they are running non-genuine Windows, and it will not allow genuine Windows downloads for that system. Users of WINE should consult the WINE community for WINE updates. It is important to note that WINE users, and other users of non-genuine Windows, can continue to download updates for most Microsoft applications from Microsoft application-specific sites, such as Office Update. Ciao, Marcus

3 2

EU CVS server is not up to date
by Berend Reitsma 05 Apr '06

05 Apr '06

Hello, The EU CVS server is not up to date. The head of the Changelog is 1.110 while on cvs.winehq it is 1.111. $ cvs -n -d:pserver:cvs(a)rhlx01.fht-esslingen.de:/home/wine -q log ChangeLog | head RCS file: /home/wine/wine/ChangeLog,v Working file: ChangeLog head: 1.110 branch: locks: strict access list: symbolic names: Wine-0_9_10: 1.110 Wine-0_9_9: 1.109 Regards, Berend.

1 0

[opengl] Another possible fix for the BadMatch error
by Leon Freitag 05 Apr '06

05 Apr '06

> The BadMatch in X_GLXCreateGLXPixmap is another problem.. here you > should get a BadMatch in X_GLXMakeCurrent. That's true, this patch should only fix the BadMatches in glXMakeCurrent. > BadMatch in X_GLXCreateGLXPixmap is a known problem, I've submitted a > patch but it was rejected. Well, try to resubmit it :) Or post it here, so that others could test it. Perhaps you could merge this one-liner into it and then resubmit it. Leon

2 5