May 2006 - Wine-devel - list.winehq.org

Re: getuname: add stub implementation [try 2]
by Robert Shearman 31 May '06

31 May '06

Vitaly Lipatov wrote: >+/*********************************************************************** >+ * GetUName [ 2000 / XP ] >+ * >+ * undocumented fn: GetUName() >+ * The information is not available by API. The thing MS did >+ * here -- parsing the data from nameslist.txt in the Unicode Character >+ * Database (UCD). >+ * See >+ * http://groups.google.com/groups?hl=en&threadm=ODVecQBoBHA.2416%40tkmsftngp02 >+ * RETURNS >+ * unknown >+ */ >+void WINAPI GetUName(void) >+{ >+ FIXME("stub\n"); >+} > > You should add a test for this function and document at least the number of parameters of the function. Presumably it should take some parameters or return something, or the DLL is useless. If the former is incorrect then the stack will be trashed after the call. -- Rob Shearman

1 0

Re: getuname: add stub implementation [try 2]
by Alexandre Julliard 31 May '06

31 May '06

Vitaly Lipatov <lav(a)etersoft.ru> writes: > +/*********************************************************************** > + * GetUName [ 2000 / XP ] > + * > + * undocumented fn: GetUName() > + * The information is not available by API. The thing MS did > + * here -- parsing the data from nameslist.txt in the Unicode Character > + * Database (UCD). > + * See > + * http://groups.google.com/groups?hl=en&threadm=ODVecQBoBHA.2416%40tkmsftngp02 > + * RETURNS > + * unknown > + */ > +void WINAPI GetUName(void) > +{ > + FIXME("stub\n"); > +} If you don't know the parameters you should leave the function as stub in the spec file, at least this way it will crash cleanly. Also you have to make the dll handle the PREATTACH value to prevent it from getting loaded if native is present. Look at how other stub dlls are doing it. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: urlmon: Use FindMimeFromData to determine MIME type.
by Alexandre Julliard 31 May '06

31 May '06

Jacek Caban <jacek(a)codeweavers.com> writes: > dlls/urlmon/binding.c | 25 ++++++++++++++++++++----- > 1 files changed, 20 insertions(+), 5 deletions(-) This breaks the tests: ../../../tools/runtest -q -P wine -M urlmon.dll -T ../../.. -p urlmon_test.exe.so url.c && touch url.ok url.c:401: Test failed: unexpected call OnProgress_MIMETYPEAVAILABLE url.c:401: Test failed: unexpected call OnProgress_MIMETYPEAVAILABLE make[1]: *** [url.ok] Error 2 -- Alexandre Julliard julliard(a)winehq.org

2 1

Re: Re: World of Warcraft (WoW) patch/more address space layout stuff
by fenix＠club-internet.fr 31 May '06

31 May '06

----Message d'origine---- >Date: Tue, 30 May 2006 16:08:42 +0200 >De: Tomas Carnecky <tom(a)dbservice.com> >A: Mike Hearn <mike(a)plan99.net> >Copie à: wine-devel(a)winehq.com, n0dalus <n0dalus(a)gmail.com> >Sujet: Re: World of Warcraft (WoW) patch/more address space layout stuff > >Mike Hearn wrote: >> It's a bug in WoW itself, it relies upon the exact way NT maps memory >> which is different to how Linux does it. I guess they are storing >> information in the high bits of a pointer somewhere or some similar >> trick. >> > >Since WoW also runs on MacOSX, how does the memory layout on MacOSX >differ from NT and Linux? Maybe that's the reason why they won't do a >Linux port: because they rely on a certain memory layout and the code >can't be changed that easily. No, they have added this regressions after a little patch-set. So they can fix it. And as we can't download a playable demo ... Regards, Raphael

5 4

--without-opengl problems
by Saulius Krasuckas 31 May '06

31 May '06

If I compile Wine by starting with "./configure", it builds dlls/wined3d/wined3d.dll.so file. Then If I run some Ogre (d3d) game, I get all video setup stuff OK. If I connect to my tightvnc server after and run the game here, I get Xlib errors in the output (about missing GLX on :1.0 or a like). Then I decide to disable OpenGL support in Wine and start with "./configure --without-opengl". After this the wined3d.dll.so is left on the disk. And if later I run the game again via vnc server, I get weird errors and see Wine crashing in wined3d.dll (and sometimes wineprefixcreate crashes inside shlwapi.dll or opengl.dll). Isn't this behaviour strange a bit? Shouldn't configure delete dlls/wined3d/wined3d.dll.so or unlink dlls/wined3d.dll.so or at least define code don't try loading wined3d.dll when "--without-opengl" option is given to it? IOW, "make clean" shouldn't be necessary here, right? Well, I just may be missing some information... TIA

4 4

Re: [PATCH] dnsapi: Missing lock release on error path (found by Smatch)
by Hans Leidekker 31 May '06

31 May '06

On Tuesday 30 May 2006 23:39, Michael Stefaniuc wrote: > it looks like the function returns on the error path with the lock held. > Is it supposed to do that? If not the attached patch fixes it. No, that's a bug. Thanks. -Hans

1 0

Re: rpcrt4: Implement NdrClientContext(Un)Marshall.
by Saveliy Tretiakov 31 May '06

31 May '06

NdrClientContext(Un)Marshall shuold add size of context handle to pStubMsg->Buffer and raise exceptions in some cases. NDRCContext(Un)marshall shouldn't, that's the difference. You can see this from my testcases (attached). And this was already implemented in my patch. I can't understand why are you trying to reimplement it. Mike McCormack wrote: > --- > > dlls/rpcrt4/ndr_marshall.c | 11 +++++++++-- > 1 files changed, 9 insertions(+), 2 deletions(-) > > ------------------------------------------------------------------------ > > e834795f1d24b26411d76ba725975216867ae58e > diff --git a/dlls/rpcrt4/ndr_marshall.c b/dlls/rpcrt4/ndr_marshall.c > index 06ce04a..edd1eb2 100644 > --- a/dlls/rpcrt4/ndr_marshall.c > +++ b/dlls/rpcrt4/ndr_marshall.c > @@ -4296,7 +4296,10 @@ void WINAPI NdrClientContextMarshall(PMI > NDR_CCONTEXT ContextHandle, > int fCheck) > { > - FIXME("(%p, %p, %d): stub\n", pStubMsg, ContextHandle, fCheck); > + TRACE("(%p, %p, %d): stub\n", pStubMsg, ContextHandle, fCheck); > + /* FIXME: what does fCheck do? */ > + return NDRCContextMarshall(ContextHandle, > + pStubMsg->Buffer); > } > > /*********************************************************************** > @@ -4306,7 +4309,11 @@ void WINAPI NdrClientContextUnmarshall(P > NDR_CCONTEXT * pContextHandle, > RPC_BINDING_HANDLE BindHandle) > { > - FIXME("(%p, %p, %p): stub\n", pStubMsg, pContextHandle, BindHandle); > + TRACE("(%p, %p, %p): stub\n", pStubMsg, pContextHandle, BindHandle); > + return NDRCContextUnmarshall(pContextHandle, > + BindHandle, > + pStubMsg->Buffer, > + pStubMsg->RpcMsg->DataRepresentation); > } > > void WINAPI NdrServerContextMarshall(PMIDL_STUB_MESSAGE pStubMsg, > > > ------------------------------------------------------------------------ > > >

2 6

how to edit wiki?
by mark cox 31 May '06

31 May '06

When i search in google for 'cxtest', one of the hits is from winenq, but when i open the page http://wiki.winehq.org/CxTest, i get the message '*This page does not exist yet. You can create a new empty page, or use one of the page templates. Before creating the page, please check if a similar page already exists.'. and an option to 'create a new empty page'. If i choose to create a new page, i get the message '*You are not allowed to edit this page.'. No indication is given as to how to sign in or what to do. Most wiki's have an option to 'sign in', or 'create a new account'. I thought that the idea of wiki's was that were meant to be accessible without jumping through hoops, so what's going on? Regards, mark. * *

3 4

Re: Mac OS X Audio driver
by Robert Reif 30 May '06

30 May '06

Emmanuel Maillard wrote: > Hi, > > This patch is the initial Audio Driver for Mac OS X, quiet big > (contain all winecoreaudio dir) tell me if you want i split this in > separated patches. > > Thanks > > Emmanuel > > Authors: > Ken Thomases <ken at codeweavers dot com> > Emmanuel Maillard <mahanuu at opendarwin dot org> > > Changelog: > Initial Audio Driver for Mac OS X. > Could you add this to winecfg? Should be a one line patch.

1 0

Re: Wine 1.0 Tasks
by Dan Kegel 30 May '06

30 May '06

On 5/30/06, Brian Vincent <brian.vincent(a)gmail.com> wrote: > On 5/30/06, Dan Kegel <dank(a)kegel.com> wrote: > > I guess there are two main use cases: > > 1) developer wants to debug an app that misbehaves on Linux/Wine but > > not on Windows > > 2) manager or clueless pundit who are into VB or VC++ wants to say > > Wine is useless, > > and by supporting Visual Studio we convince them otherwise > > 3) Source code management lives in Visual Source Safe and VS .NET or > MSVC++ 6.0 is needed to access it. Oh, good point. Yes, we should include Visual Sourcesafe integration support in our Visual Studio testing. (I used VSS for years with Wine; see http://kegel.com/wine/vss-howto.html, but I seldom used the GUI and never used Visual Studio.) - Dan -- Wine for Windows ISVs: http://kegel.com/wine/isv

1 0