May 2006 - Wine-devel - list.winehq.org

Picasa for Linux available!
by Smith, Leo 28 May '06

28 May '06

Since Wine runs under OS X do you think this build of Picasa would work? Leo Smith City of Concord Information Technology Department 1950 Parkside Dr. Concord, CA 94519 925 671 3277 lsmith(a)ci.concord.ca.us

1 0

return void function
by David Anderson 28 May '06

28 May '06

Your comment about return RpcRaiseException(hr); is quite interesting, but, IMO, it's not a good choice. RpcRaiseException(hr); return; is c-like whereas return RpcRaiseException(hr); is a (slightly arcane) C++-ism which, I gather, really only came about because template/generic programming sort of forces it to be legal else various templates could not be written. The original ANSI C expressly forbids your return statement under 'constraints' of section 6.6.6.4 (ISO/IEC 9899 section numbering in this sentence). I think the original questions demonstrate that it would be better written as simpler C as I suggest (and others hinted). David Anderson: just making a suggestion here. (author of the (first-ever-shipped, possibly) full ANSI C compilation environment, shipped by SGI in 1990 (only usable on SGI MIPS/IRIX machines)).

1 0

Re: DBGHELP: Implement SymGetSymFromAddr64
by Eric Pouech 28 May '06

28 May '06

Thomas Weidenmueller wrote: >The attached patch implements SymGetSymFromAddr64, called by steam. > > a couple of coments: >@@ -996,7 +996,8 @@ > sym = pair.effective->addr_sorttab[idx]; > > symt_fill_sym_info(&pair, &sym->symt, Symbol); >- *Displacement = Address - Symbol->Address; >+ if (Displacement) >+ *Displacement = Address - Symbol->Address; > return TRUE; > } > > > why do you need this ? >@@ -1053,6 +1054,31 @@ > return TRUE; > } > >+/****************************************************************** >+ * SymGetSymFromAddr (DBGHELP.@) >+ * >+ */ >+BOOL WINAPI SymGetSymFromAddr64(HANDLE hProcess, DWORD64 Address, >+ PDWORD64 Displacement, PIMAGEHLP_SYMBOL64 Symbol) >+{ >+ char buffer[sizeof(SYMBOL_INFO) + MAX_SYM_NAME]; >+ SYMBOL_INFO*si = (SYMBOL_INFO*)buffer; >+ size_t len; >+ >+ if (Symbol->SizeOfStruct < sizeof(*Symbol)) return FALSE; >+ si->SizeOfStruct = sizeof(*si); >+ si->MaxNameLen = MAX_SYM_NAME; >+ if (!SymFromAddr(hProcess, Address, &Displacement, si)) > > - you should test that Address can be casted down to a 32 bit entity (see other functions for how to do it) - &Displacement looks pretty wrong: you need a local 32 bit dword, pass its address, and then convert the local 32 bit value into the 64 bit pointer (Displacement) >+ return FALSE; >+ >+ Symbol->Address = si->Address; >+ Symbol->Size = si->Size; >+ Symbol->Flags = si->Flags; >+ len = min(Symbol->MaxNameLength, si->MaxNameLen); >+ lstrcpynA(Symbol->Name, si->Name, len); >+ return TRUE; >+} >+ > static BOOL find_name(struct process* pcs, struct module* module, const char* name, > SYMBOL_INFO* symbol) > { > > >------------------------------------------------------------------------ > > > >

2 2

Re: secur32: Cleaning up the authentication tests.
by Kai Blin 28 May '06

28 May '06

* Kai Blin <kai.blin(a)gmail.com> [27/05/06, 15:45:57]: > + trace("blub\n"); That one slipped me. I'll send an amended patch shortly. Kai -- Kai Blin, (blin at gmx dot net) In spite of everything, I still believe that people are good at heart. -- Ann Frank

1 0

Lotus Notes R7 on Wine
by Roland Kaeser 28 May '06

28 May '06

Hello I currently trying to run the Domino Client (Lotus Notes R7) on Wine 0.9.14 but couldn't get success yet. Does somebody has experience about running the R7 on Wine? I tried a lot of diffrent WINEDLLOVERRIDES settings but all I get is that Lotus brings the crash dialog (which creates a crash error message). I would be very appreciative for any hint. Roland Kaeser

1 0

Re: wined3d: fix R8G8B8 texture upload
by Ivan Gyurdiev 28 May '06

28 May '06

> diff --git a/dlls/wined3d/utils.c b/dlls/wined3d/utils.c > index 77b6b33..d15520b 100644 > --- a/dlls/wined3d/utils.c > +++ b/dlls/wined3d/utils.c > @@ -1741,7 +1741,7 @@ GLenum D3DFmt2GLFmt(IWineD3DDeviceImpl* > /* color buffer */ > case WINED3DFMT_R3G3B2: retVal = GL_RGB; break; > case WINED3DFMT_R5G6B5: retVal = GL_RGB; break; > - case WINED3DFMT_R8G8B8: retVal = GL_RGB; break; > + case WINED3DFMT_R8G8B8: retVal = GL_BGR; break; > case WINED3DFMT_A1R5G5B5: retVal = GL_BGRA; break; > case WINED3DFMT_X1R5G5B5: retVal = GL_BGRA; break; > case WINED3DFMT_A4R4G4B4: retVal = GL_BGRA; break; > Careful, you're getting out-of-sync with surface.c. That should probably be changed also [ UnlockRect ].

1 0

void dispatch_rpc() returns a value
by Bang Jun-Young 27 May '06

27 May '06

Hi, I wonder how this has been possible so far: static void __RPC_STUB dispatch_rpc(RPC_MESSAGE *msg) { struct dispatch_params *params; APARTMENT *apt; IPID ipid; HRESULT hr; RpcBindingInqObject(msg->Handle, &ipid); TRACE("ipid = %s, iMethod = %d\n", debugstr_guid(&ipid), msg->ProcNum); params = HeapAlloc(GetProcessHeap(), 0, sizeof(*params)); if (!params) return RpcRaiseException(E_OUTOFMEMORY); hr = ipid_get_dispatch_params(&ipid, &apt, &params->stub, &params->chan); if (hr != S_OK) { ERR("no apartment found for ipid %s\n", debugstr_guid(&ipid)); return RpcRaiseException(hr); } dispatch_rpc() shouldn't return anything since it's a void function, but it actually does. Jun-Young

3 3

Re: winspool/tests: Use 0xdeadbeef as magic Value
by Andreas Mohr 27 May '06

27 May '06

Hi, On Sat, May 27, 2006 at 12:35:02AM +0200, Detlef Riekenberg wrote: > > I was using 0x00dead00 before, but Dmitry suggested 0xdeadbeef, as this > is used in most Places in wine. First, then you should really write it as such... Second, why does it *ALWAYS* have to be 0xdeadbeef? In that case there's quite some probability that you have to go on a frantic search for the *actual* place that caused Wine to crash with a 0xdeadbeef value that's being used *everywhere*... (noooooo, of couuuuurse that never happened to me...) [andi(a)rhlx01 wine]$ find 2>/dev/null|xargs cat 2>/dev/null|grep 0xdeadbeef|wc -l 1632 !!! Some alternatives: 0xdeadbee0 . . . 0xdeadbee9 0xcafebabe 0xcafed00d 0xdeaddead 0xc001cafe OK, as an invalid error value during winetests there is no way to mix it up, but with vtable values and many, many other places that use it that *is* an issue. Andreas -- No programming skills!? Why not help translate many Linux applications! https://launchpad.ubuntu.com/rosetta (or alternatively buy nicely packaged Linux distros/OSS software to help support Linux developers creating shiny new things for you?)

3 2

Release Information on Fedora Extras!
by Neal Gompa 27 May '06

27 May '06

I have noticed that since my post about how Fedora packages are inaccessible, you have added the string "Currently official Fedora packages lag behind, but you can get Wine-0.9.10 by running yum install wine from Fedora Extras<http://fedoraproject.org/extras/4/i386/repodata/repoview/W.group.html>." Well, that is not totally correct. Usually about a week after Wine Project releases a version, Fedora Extras updates to the newest version! Currently, it is at Wine-0.9.13. I believe it will be a week before Fedora Extras releases Wine-0.9.14 packages... I will reply when Wine packages are updated you that an accurate guage is made of the lag... The links below are to the webview of Fedora Extras: Fedora Extras for Fedora Core 5: http://download.fedora.redhat.com/pub/fedora/linux/extras/5/i386/repodata/r… Fedora Extras for Fedora Core 4: http://download.fedora.redhat.com/pub/fedora/linux/extras/4/i386/repodata/r… Fedora Extras for Fedora Core 3: http://download.fedora.redhat.com/pub/fedora/linux/extras/3/i386/repodata/r… Note that it is viewing the alphabet group of "W". Scroll down a bit and you will see Wine packages. Please keep download form updated, you make people believe that Wine is not being updated by Fedora Extras, when in fact it is...

1 2

config.status: WARNING: Make.rules.in seems to ignore the --datarootdir setting
by Gerald Pfeifer 27 May '06

27 May '06

Starting last night, or the night before, I believe, my automated testers now issue the following warning on SUSE Linux 10.1/i386, and others: config.status: WARNING: Make.rules.in seems to ignore the --datarootdir setting Is this possibly related to the following? date: 2006-05-25 21:19:35 +0200; author: julliard; state: Exp; lines: +4816 -3937 Alexandre Julliard <julliard(a)winehq.org> configure: Regenerated with autoconf 2.59d. And should we worry about it, or is there a way to disable it? Gerald -- Gerald (Jerry) Pfeifer gerald(a)pfeifer.com http://www.pfeifer.com/gerald/

1 0