June 2006 - Wine-devel - list.winehq.org

kernel32.VerSetConditionMask present
by Vitaly Lipatov 10 Jun '06

10 Jun '06

VerSetConditionMask function is introduced in kernel32 science Windows 2000. Some broken applications check VerSetConditionMask present via GetProcAddress for check version of running Windows. What is the preferable method to disable export VerSetConditionMask from kernel32 when we have win98 version? -- Vitaly Lipatov, ALT Linux Team Russia, Saint-Petersburg, www.etersoft.ru

1 0

Re: svrapi: add stub implementation [try 2]
by Robert Shearman 10 Jun '06

10 Jun '06

Vitaly Lipatov wrote: >+1 stub NetAccessAdd >+2 stub NetAccessCheck >+3 stub NetAccessDel >+4 stub NetAccessEnum >+5 stub NetAccessGetInfo >+6 stub NetAccessGetUserPerms >+7 stub NetAccessSetInfo >+8 stub NetConnectionEnum >+9 stub NetFileClose2 >+10 stub NetFileEnum >+11 stub NetSecurityGetInfo >+12 stub NetServerGetInfo >+13 stub NetSessionDel >+14 stub NetSessionEnum >+15 stub NetSessionGetInfo >+16 stub NetShareAdd >+17 stub NetShareDel >+18 stdcall NetShareEnum(str long ptr long ptr ptr) >+19 stub NetShareGetInfo >+20 stub NetShareSetInfo > > These should all be just exported by name (@) not also by ordinal judging by the fact that they are in alphabetical order. -- Rob Shearman

1 0

Re: WineD3D: Fog fixes
by Jesse Allen 10 Jun '06

10 Jun '06

On 6/9/06, Stefan Dösinger <stefan(a)codeweavers.com> wrote: > This patch corrects a few issues with fog on transformed vertices, and > non-pixel-non-vertex fog. > > If WINED3DRS_FOGENABLE is TRUE, but WINED3RS_FOGVERTEXMODE and > WINED3DRS_FOGTABLEMODE are D3DFOG_NONE, then, according to the msdn, the > alpha channel specular color vertex color contains a pre-calculated fog > value. The same applied to transformed vertices if Vertexfog is enabled. This > patch uses glFogCoord to pass it to GL if GL_EXT_fog_coord is supported, and > disables GL fog if it isn't to minimize rendering issues. > > This patch makes Swat3 and Battlezone 2 happy, and the fog in Prince of Persia > 3D looks more correct now. I hoped that patch might solve the disappearing > objects problem in Half-Life 2, but unfortunately it doesn't, this seems not > to be fog-related :-( > > ChangeLog: > Stefan Dösinger(for CodeWeavers): Fog fixes > > This patch doesn't work with the latest fglrx saying missing symbol for glFogCoordf. Mesa is ok though. Jesse

2 1

winspool/tests: Tests for GetPrintProcessorDirectory (resend for current HEAD)
by Detlef Riekenberg 09 Jun '06

09 Jun '06

Am Freitag, den 02.06.2006, 00:11 +0200 schrieb Detlef Riekenberg: > Changelog: > - winspool/tests: Tests for GetPrintProcessorDirectory > Resend for current HEAD -- By By ... ... Detlef

1 0

Re: Yet another round of redundand NULL checks before HeapFree (found by Smatch).
by Michael Stefaniuc 09 Jun '06

09 Jun '06

Please disregard this patch as a false positive crept in. Michael Stefaniuc wrote: > hopefully this should be the last round of redundand NULL checks before > HeapFree removals. I know, famous last words. But this time i have > extended the redundant_null_check.pl Smatch script to find all non-null > variables from arbitrary complex if-expressions and check that any of > them dosn't get HeapFree'd on the truth path. > diff --git a/dlls/msacm32/driver.c b/dlls/msacm32/driver.c > index e537bc4..bec3526 100644 > --- a/dlls/msacm32/driver.c > +++ b/dlls/msacm32/driver.c > @@ -587,7 +587,7 @@ MMRESULT WINAPI acmDriverOpen(PHACMDRIVE > return MMSYSERR_NOERROR; > gotError: > WARN("failed: ret = %08x\n", ret); > - if (pad && !pad->hDrvr) > + if (!pad->hDrvr) nice NULL pointer dereference. > HeapFree(MSACM_hHeap, 0, pad); > return ret; > } bye michael -- Michael Stefaniuc Tel.: +49-711-96437-199 Sr. Network Engineer Fax.: +49-711-96437-111 Red Hat GmbH Email: mstefani(a)redhat.com Hauptstaetterstr. 58 http://www.redhat.de/ D-70178 Stuttgart

3 2

Re: user: Added specific winproc functions for calling dialog procedures.
by James Hawkins 09 Jun '06

09 Jun '06

Hey Alexandre, As of the following commit: Commit: 397bf3c2b133fe36529efcc4c1906bac1aac2da8 URL: http://source.winehq.org/git/?p=wine.git;a=commit;h=397bf3c2b133fe36529efcc… Author: Alexandre Julliard <julliard at winehq.org> Date: Tue May 9 20:33:11 2006 +0200 user: Added specific winproc functions for calling dialog procedures. The VB/VC++ 6 installers crash pretty early in the setup sequence. Two things to keep in mind are that the installer works correctly if I set the win version to win98, or I revert the following part of the patch: @@ -447,14 +441,8 @@ LRESULT WINAPI DefDlgProcA( HWND hwnd, U SetWindowLongPtrW( hwnd, DWLP_MSGRESULT, 0 ); - if ((dlgproc = DEFDLG_GetDlgProc( hwnd ))) - { - /* Call dialog procedure */ - result = CallWindowProcA( dlgproc, hwnd, msg, wParam, lParam ); - /* 16 bit dlg procs only return BOOL16 */ - if( WINPROC_GetProcType( dlgproc ) == WIN_PROC_16 ) - result = LOWORD(result); - } + if ((dlgproc = DEFDLG_GetDlgProc( hwnd ))) /* Call dialog procedure */ + result = WINPROC_CallDlgProcA( dlgproc, hwnd, msg, wParam, lParam ); if (!result && IsWindow(hwnd)) { I've done a fair bit of digging around on this bug, and I've noticed some things that are probably obvious to you, but might help put light on the situation for others. The order of the calls before the patch is applied is: DefDlgProcA -> CallWindowProcA -> WINPROC_CallWndProc and after the patch is applied: DefDlgProcA -> WINPROC_CallDlgProcA -> WINPROC_CallWndProc I've added debug printf's in these functions to see when they're called and what certain pointers contain. With the patch applied and and win version set to win98, the debug output is the same: DefDlgProcA CallWindowProcA func: 0xffff0027 CallWindowProcA proc: 0x40a5e1ac WINPROC_CallWndProc proc: 0x403020 CallWindowProcA func: 0x41ea2020 CallWindowProcA handle_to_proc returned NULL WINPROC_CallWndProc proc: 0x41ea2020 WINPROC_CallWndProc proc: 0x41ea2020 CallWindowProcA func: 0x41ea2020 CallWindowProcA handle_to_proc returned NULL WINPROC_CallWndProc proc: 0x41ea2020 WINPROC_CallWndProc proc: 0x41ea2020 WINPROC_CallWndProc proc: 0x41ea2020 WINPROC_CallWndProc proc: 0x41ea2020 WINPROC_CallWndProc proc: 0x41ea2020 and the installer goes on as usual (we know this because of a richedit trace from the richedit control on the next install screen). Here is the debug output with the patch applied and version set to win2000: DefDlgProcA DefDlgProcA dlgproc: 0xffff0026 WINPROC_CallDlgProcA func: 0xffff0026 WINPROC_CallDlgProcA proc: 0x40a5e1f8 WINPROC_CallDlgProcA proc->thunk.proc: 0x412020 WINPROC_CallWndProc proc: 0x412020 wine: Unhandled page fault on read access to 0x00000000 at address 0x411799 (thread 0009), starting debugger... Any insight you can provide about this bug would be greatly appreciated. -- James Hawkins

1 0

Re: [WINED3D 2/9] Add the bulk of the GLSL string generation functions
by H. Verbeet 09 Jun '06

09 Jun '06

Is making the distinction between rgba and xyzw really needed? xyzw / rgba / stpq should be equivalent and the distinction is mostly for readability if you know the variable type. However, since you can't decided that purely based on whether something is a vertex shader or a pixel shader, the way it's currently done might be misleading in some cases.

2 1

Re: [WINED3D 9/9] Allow drawPrim to create and use the GLSL program
by H. Verbeet 09 Jun '06

09 Jun '06

Does this reset the currently used program to 0 when fixed function is supposed to be used again? I think we should just do glUseProgramObjectARB(programId), since when fixed function is supposed to be used the program id will be 0. That also mean you don't have to do an explicit glUseProgramObjectARB(0) at a later stage, which saves an extra shader switch, in particular if the same shader is used in the next DrawPrimitive call.

1 0

Re: Update the progress control while installing.
by Dmitry Timoshkov 09 Jun '06

09 Jun '06

"Mike McCormack" <mike(a)codeweavers.com> wrote: > --- a/dlls/msi/dialog.c > +++ b/dlls/msi/dialog.c > @@ -62,6 +62,8 @@ struct msi_control_tag > HICON hIcon; > LPWSTR tabnext; > HMODULE hDll; > + float progress_current; > + float progress_max; Is it really necessary to use float instead of long? -- Dmitry.

1 0

Re: notepad patches (search/replace, etc)
by Andreas Mohr 09 Jun '06

09 Jun '06

Hi, On Thu, Jun 08, 2006 at 08:40:33PM -0400, Anoni Moose wrote: > This is my first patch to an open source project... if anyone has any > comments/suggestions, please tell me. :) I can't help but say that your parents must have been giving you a rather "funny" name... Or, IOW, do we have any guidelines about "Anoni Moose" submissions to our project? Are they ok, not ok, ok? Loves me, loves me not, ... Anyway, thanks for a very nice collection of patches! Andreas Mohr

3 3