June 2006 - Wine-devel - list.winehq.org

Feedback requested on an OpenAL audio driver patch
by Nick Burns 07 Jun '06

07 Jun '06

I finally figured out my dsound HEL problem (was making too many buffers) -- now I wait and only use a few buffers. It seemed to work well for GTA3, Tribes2 and FlatOut(requires a binary patch to run) (dsound) -- and for SndRec32 (win/wout) (Games and ...App... tested under Mac OSX x86 -- Mac Book Pro) Remove the disable 'OPENAL_DISABLE_IN' to test wavein. (Forced off due to some issues of my OpenAL framework (I could only record at 44k -- could not figure out how to force 44k only for wavein) -- others may have better luck) So here is my patch -- It adds it to winecfg, the makefile.in, configure.ac And it adds the new files (the actual driver why not) I would like any feedback ppl out there may have. (It is missing a ChangeLog thingy -- that would look like the below) ---- 2006-06-04 Nick Burns <adger44(a)hotmail.com> * configure.ac: Added checks for OpenAL (Mac OSX and linux). * dlls/Makefile.in: Added OpenAL to build thingy. * include/config.h.in: Added OpenAL to config -- using autoheader (may not be needed). * programs/winecfg/audio.c: Added OpenAL to winecfg for choosing. * dlls/winmm/wineopenal/openal.c, dlls/winmm/wineopenal/openal.h, dlls/winmm/wineopenal/audio.c, dlls/winmm/wineopenal/wineopenal.drv.spec, dlls/winmm/wineopenal/Makefile.in: Initial checkin of OpenAL driver. ---- - Nick

2 2

Re: [KERNEL 1/2] changed test for function FindFirstFileA to find dosdevices
by Vitaliy Margolen 07 Jun '06

07 Jun '06

Wednesday, June 7, 2006, 9:03:43 AM, Konstantin Petrov wrote: > changed test for function FindFirstFileA to find dosdevices. > As function FindFirstFile must accept such paths as > "c:\\windows\\win.ini" > "c:\\NUL", > "c:\\COM1", > "c:\\LPT1", > "c:\\LPT9", > "c:\\COM9", > "c:\\CON", > "c:\\AUX", > "c:\\PRN" > and mustn't accept paths: > "\\\\.\\CON", > "c:\\COM0", > "", > "c:\\LPT0", That's because you have only one serial and one parallel port. The special name is the special name. It's different how win9x and winNT handles them. Which system have you ran these tests on? Vitaliy Margolen

1 0

Re: shell32: Write-strings warning fix
by Robert Shearman 07 Jun '06

07 Jun '06

Andrew Talbot wrote: >Changelog: > shell32: Write-strings warning fix. > >diff -urN a/dlls/shell32/shlview.c b/dlls/shell32/shlview.c >--- a/dlls/shell32/shlview.c 2006-05-23 17:24:50.000000000 +0100 >+++ b/dlls/shell32/shlview.c 2006-06-07 19:37:41.000000000 +0100 >@@ -779,7 +779,9 @@ > */ > > static void ShellView_MergeViewMenu(IShellViewImpl * This, HMENU hSubMenu) >-{ MENUITEMINFOA mii; >+{ >+ MENUITEMINFOA mii; >+ static CHAR mii_type_data[] = "View"; > > TRACE("(%p)->(submenu=%p)\n",This,hSubMenu); > >@@ -791,7 +793,7 @@ > mii.cbSize = sizeof(mii); > mii.fMask = MIIM_SUBMENU | MIIM_TYPE | MIIM_DATA; > mii.fType = MFT_STRING; >- mii.dwTypeData = "View"; >+ mii.dwTypeData = mii_type_data; > mii.hSubMenu = LoadMenuA(shell32_hInstance, "MENU_001"); > InsertMenuItemA(hSubMenu, FCIDM_MENU_VIEW_SEP_OPTIONS, FALSE, &mii); > } > Sorry, this is wrong. If InsertMenuItemA writes to the string then it will be corrupted and will display the wrong thing for further uses in the process. It is therefore better to cast it from a "const char *" into a "char *" or to make it a non-static array at the top of the function. I think the first choice of keeping it a "const char *" is the best choice in this case. -- Rob Shearman

2 2

re: lstrlen(A/W) patch
by Dan Kegel 07 Jun '06

07 Jun '06

Clinton wrote: >> Does the Richedit control return an error, or clear itself when passed >> EM_SETTEXTEX with lParam = NULL? >On Windows, it returns 1 and clears itself. Unless the ST_SELECTION >flag is set, in which case it returns 0, and actually replaces the text >with nothing. >My patch to wine results in the same behavior. I'll send it to >wine-patches. Great! Any chance you could include a conformance test in your patch? Thanks, Dan

1 0

Re: [uxtheme/tests] Add initial tests (Second try)
by Paul Vriens 07 Jun '06

07 Jun '06

On Wed, 2006-06-07 at 08:44 +0200, Paul Vriens wrote: > Hi, > > I've added the framework and some initial (simple) tests. No > functionality tests (yet), only parameter and return-value checking. > > This one also 'fixes' the tests for Wine when theming is enabled. > > Changelog > Added framework and initial tests > > Cheers, > > Paul. Anything I can do to improve? This patch will of course be followed up by fixes. Cheers, Paul.

1 0

Hal and functions in setupapi
by Christian Gmeiner 07 Jun '06

07 Jun '06

Hi all... at the momemt i am reading into functions to get some informations about e.g. cdrom drives. At the moment i am loking into SetupDiGetClassDevsW to support GUID_DEVINTERFACE_CDROM and later USB devices. My overall goal is it to get Line 6 software for my guitart effect board (USB) working with wine. Now i thought about a way to get all informations about a singe cdrom device. And i thought that I could use HAL perfectly for this. I thought about this way of doing it: Add hal.c file to setupapi dll, which contains function to get infromations about all needed hardware. This should work very nicly for this case. But as I want to programm RegisterDeviceNotification also we need a central way to handle hal stuff. So how should I go on? Use some own hal.c in setupapi or add an global wine way to interact with hal? Thanks, Christian

3 2

Re: libunicode: Add some more code page tables that are available for download from ftp.unicode.org, most notably the table for the us-ascii encoding, which is quite common.
by Alexandre Julliard 07 Jun '06

07 Jun '06

Robert Shearman <rob(a)codeweavers.com> writes: > libs/unicode/Makefile.in | 3 > libs/unicode/c_1361.c | 5138 > ++++++++++++++++++++++++++++++++++++++++++++++ > libs/unicode/c_20000.c | 3587 ++++++++++++++++++++++++++++++++ > libs/unicode/c_20127.c | 683 ++++++ > libs/unicode/cpmap.pl | 3 > libs/unicode/cptable.c | 8 This won't work, the source files are not in the expected format, so the resulting tables contain garbage. You'll need to teach cpmap.pl to parse these files correctly. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: winecfg: Avoid unnecessary casts
by Detlef Riekenberg 07 Jun '06

07 Jun '06

Am Mittwoch, den 07.06.2006, 16:45 +0900 schrieb Dmitry Timoshkov: > - psh.u3.ppsp = (LPCPROPSHEETPAGEW) & psp; > + psh.u3.ppsp = psp; Where is the "&" ? -- By By ... ... Detlef

1 0

Re: [WINED3D 2/3] Fix missing light recording
by Michael Stefaniuc 07 Jun '06

07 Jun '06

Ivan Gyurdiev wrote: > >> >From nobody Mon Sep 17 00:00:00 2001 >> > > Please delete this line in case the patch is corrupt.. missed it The patch is not corrupted as it starts only with the '---' line. bye michael -- Michael Stefaniuc Tel.: +49-711-96437-199 Sr. Network Engineer Fax.: +49-711-96437-111 Red Hat GmbH Email: mstefani(a)redhat.com Hauptstaetterstr. 58 http://www.redhat.de/ D-70178 Stuttgart

1 0

Re: lstrlen(A/W) patch
by Mike McCormack 06 Jun '06

06 Jun '06

Clinton Stimpson wrote: > The following patch will fix the crash. > MSDN documentation says "*lstrlen* assumes that /lpString/ is a > null-terminated string, or NULL" The inline lstrlenW is used only internally by Wine code, and we want it to crash when passed a NULL pointer. In this case, you should fix the Wine code calling lstrlenW to not use a NULL pointer. Mike

2 3