September 2006 - Wine-devel

Re: [PATCH] local fixes in ioctl for google video.
by Dmitry Timoshkov 30 Sep '06

30 Sep '06

"Marcus Meissner" <marcus(a)jet.franken.de> wrote: > @@ -2125,6 +2125,13 @@ INT WINAPI WSAIoctl(SOCKET s, > > switch( dwIoControlCode ) > { > + case 0x8004667E: > + FIXME("8004667E: stub!\n"); > + break; > + case 0x4004667f: /* FIONREAD */ > + FIXME("4004667f/FIONREAD: stub, returning 1!\n"); > + *(DWORD*)lpbOutBuffer = 1; > + break; 0x8004667e is FIONBIO (set or clear non-blocking I/O). -- Dmitry.

1 0

str{n}casecmp(): unrecognized identifier
by Andrew Talbot 30 Sep '06

30 Sep '06

Hi, It seems that, on my [x86_64] system, at least, string.h is not being included in the files where strcasecmp() or strncasecmp() is used (for example, in crypt32/oid.c), despite HAVE_STRCASECMP and HAVE_STRNCASECMP being defined as 1. I presume, because of the above defines, that just adding #include <string.h> ... in the affected files would not be a proper fix. I imagine it requires expert tweaking of the automake setup (or whatever) to ensure that this is done automatically (if it's not just a fault on my system), in which case I ask for suitable help, please. Thanks, -- Andy.

3 3

Re: [PATCH] Use correct headers for strcasecmp
by Mike McCormack 30 Sep '06

30 Sep '06

Marcus Meissner wrote: > We need to include string.h and also wine/port.h > to get strcasecmp on platforms where it is missing. In Win32 code, shouldn't we be using lstrcmpi instead? Mike

1 0

Re: [Bug 4995] Check for fontforge >= 20060406 as earlier versions fail to build our fonts with catastrophic results.
by Mike McCormack 30 Sep '06

30 Sep '06

Sam Dennis wrote: > +if PKG_CHECK_MINVER(fontforge, 20060406); then configure should check for features, not versions. This avoids problems with patched older versions or newer versions with features removed. To check for fontforge correctly, we need to check that it will generate a ttf file that works with Wine. The alternative is to fix up the sfd2ttf that somebody posted a month or two ago and use that so that we don't depend on fontforge. Mike

1 0

Yesterday's (6/28) Git (gdi32) updates break 64-bit compilation.
by Evil Jay 30 Sep '06

30 Sep '06

The updates in yesterday's Git tree have broken compilation under 64-bit. Previously, it was working. I entered a bugzilla entry for it (http://bugs.winehq.org/show_bug.cgi?id=6304) but thought I would mention it here too - since I think it's a pretty big deal and it doesn't seem that many of the developers here are working under 64-bit (and therefore wouldn't notice the issue). ------------------------ ../../tools/winegcc/winegcc -B../../tools/winebuild -shared ./gdi32.spec dispdib.spec.o gdi.exe.spec.o wing.spec.o bidi16.o dispdib.o env.o gdi16.o metafile16.o wing.o bidi.o bitblt.o bitmap.o brush.o clipping.o dc.o dib.o driver.o enhmetafile.o enhmfdrv/bitblt.o enhmfdrv/dc.o enhmfdrv/graphics.o enhmfdrv/init.o enhmfdrv/mapping.o enhmfdrv/objects.o font.o freetype.o gdi_main.o gdiobj.o icm.o mapping.o metafile.o mfdrv/bitblt.o mfdrv/dc.o mfdrv/graphics.o mfdrv/init.o mfdrv/mapping.o mfdrv/objects.o mfdrv/text.o painting.o palette.o path.o pen.o printdrv.o region.o version.res -o gdi32.dll.so -ladvapi32 -lkernel32 -lntdll /usr/lib/libsicuuc.a /usr/lib/libsicudata.a -lstdc++ -lgcc_s ../../libs/port/libwine_port.a -L/lib32 -L/usr/lib32 -Wl,-rpath,/lib32 -Wl,-rpath,/usr/lib32 ld: Relocatable linking with relocations from format elf64-x86-64 (/usr/lib/libsicuuc.a(ubidi.ao)) to format elf32-i386 (gdi32.n0hnjc.o) is not supported winebuild: ld -m elf_i386 -r failed with status 256 winegcc: ../../tools/winebuild/winebuild failed. make[2]: *** [gdi32.dll.so] Error 2 make[2]: Leaving directory `/data/install/wine/dlls/gdi' make[1]: *** [gdi] Error 2 make[1]: Leaving directory `/data/install/wine/dlls' make: *** [dlls] Error 2 -J

2 1

Re: [D3D9] Remove const qualifier on state_test data.
by Michael Stefaniuc 30 Sep '06

30 Sep '06

Ivan Gyurdiev wrote: > Type: Cleanup > > Why: > The const qualifier is unnecessarily restrictive. > I intend to allocate and free such data on the heap in a future patch. > Instead, const should be primarily used on function parameters. Question: do you realy have to use void pointers? Void pointers are compatible with every pointer type and thus will disable the type checking of the compiler. Also you do not need to to cast a rvalue to void * if the type of the lvalue is void *. bye michael > --- > dlls/d3d9/tests/stateblock.c | 40 ++++++++++++++++++++-------------------- > 1 files changed, 20 insertions(+), 20 deletions(-) > > diff --git a/dlls/d3d9/tests/stateblock.c b/dlls/d3d9/tests/stateblock.c > index 65a11e6..68b431a 100644 > --- a/dlls/d3d9/tests/stateblock.c > +++ b/dlls/d3d9/tests/stateblock.c > @@ -105,20 +105,20 @@ typedef struct state_test { > * as the default data, but a write can have side effects. > * The initial data is tested first, before any writes take place > * The default data can be tested after a write */ > - const void* initial_data; > + void* initial_data; > > /* The default data is the standard state to compare > * against, and restore to */ > - const void* default_data; > + void* default_data; > > /* The test data is the experiment data to try > * in - what we want to write > * out - what windows will actually write (not necessarily the same) */ > - const void* test_data_in; > - const void* test_data_out; > + void* test_data_in; > + void* test_data_out; > > /* The poison data is the data to preinitialize the return buffer to */ > - const void* poison_data; > + void* poison_data; > > /* Return buffer */ > void* return_data; > @@ -562,11 +562,11 @@ static void shader_constants_queue_test( > shader_constant_arg* arg = buffer; > shader_constant_data* return_data = (shader_constant_data*) (arg + 1); > > - test->test_data_in = &shader_constant_test_data; > - test->test_data_out = &shader_constant_test_data; > - test->default_data = &shader_constant_default_data; > - test->initial_data = &shader_constant_default_data; > - test->poison_data = &shader_constant_poison_data; > + test->test_data_in = (void*) &shader_constant_test_data; > + test->test_data_out = (void*) &shader_constant_test_data; > + test->default_data = (void*) &shader_constant_default_data; > + test->initial_data = (void*) &shader_constant_default_data; > + test->poison_data = (void*) &shader_constant_poison_data; > test->return_data = return_data; > test->data_size = sizeof(shader_constant_data); > test->set_handler = shader_constant_set_handler; > @@ -697,11 +697,11 @@ static void lights_queue_test( > light_arg* arg = buffer; > light_data* return_data = (light_data*) (arg + 1); > > - test->test_data_in = &light_test_data_in; > - test->test_data_out = &light_test_data_out; > - test->default_data = &light_default_data; > - test->initial_data = &light_initial_data; > - test->poison_data = &light_poison_data; > + test->test_data_in = (void*) &light_test_data_in; > + test->test_data_out = (void*) &light_test_data_out; > + test->default_data = (void*) &light_default_data; > + test->initial_data = (void*) &light_initial_data; > + test->poison_data = (void*) &light_poison_data; > test->return_data = return_data; > test->data_size = sizeof(light_data); > test->set_handler = light_set_handler; > @@ -856,11 +856,11 @@ static void transform_queue_test( > { > transform_data* return_data = buffer; > > - test->test_data_in = &transform_test_data; > - test->test_data_out = &transform_test_data; > - test->default_data = &transform_default_data; > - test->initial_data = &transform_default_data; > - test->poison_data = &transform_poison_data; > + test->test_data_in = (void*) &transform_test_data; > + test->test_data_out = (void*) &transform_test_data; > + test->default_data = (void*) &transform_default_data; > + test->initial_data = (void*) &transform_default_data; > + test->poison_data = (void*) &transform_poison_data; > test->return_data = return_data; > test->data_size = sizeof(transform_data); > test->set_handler = transform_set_handler; -- Michael Stefaniuc Tel.: +49-711-96437-199 Sr. Network Engineer Fax.: +49-711-96437-111 Red Hat GmbH Email: mstefani(a)redhat.com Hauptstaetterstr. 58 http://www.redhat.de/ D-70178 Stuttgart

2 1

Re: [Bug 4995] Check for fontforge >= 20060406 as earlier versions fail to build our fonts with catastrophic results.
by Vitaliy Margolen 30 Sep '06

30 Sep '06

Sam Dennis wrote: > aclocal.m4 | 16 ++++++++++++++++ > configure.ac | 6 +++++- > 2 files changed, 21 insertions(+), 1 deletions(-) > You missing change log. Please don't forget to include it in the email body not just subject. Also your patch is not correct. It's been discussed on wine-devel that we should not restrict any one particular version of FontForge. Many distros come with old but good versions and this will add extra noise for no good reason. And it will not catch any new versions that are broken either... Vitaliy.

2 1

Vista applications that work & those that don't
by Nick Law 30 Sep '06

30 Sep '06

I thought this may be of interest... applications that work and those that don't in Vista RC1 It would be interesting on how this same list compares with wine 0.9.22 http://www.iexbeta.com/wiki/index.php/Windows_Vista_Software_Compatibility_… and the hardware compatibility list .. http://www.iexbeta.com/wiki/index.php/Windows_Vista_RC_1_Hardware_Compatibi… I don't believe Microsoft's official list has been made public yet, although they said they would sometime! Nick

1 0

Re: shdocvw(2/2): ignore VT_ERROR arguments to WebBrowser_Navigate2
by Michael Stefaniuc 29 Sep '06

29 Sep '06

Juan Lang wrote: > Combined with the first patch, I'm able to log in with Skype 2.6 beta. > > ChangeLog: ignore VT_ERROR arguments to WebBrowser_Navigate2 Ignoring VT_ERROR just masks a previous error. bye michael > Index: dlls/shdocvw/webbrowser.c > =================================================================== > RCS file: /home/wine/wine/dlls/shdocvw/webbrowser.c,v > retrieving revision 1.65 > diff -u -r1.65 webbrowser.c > --- dlls/shdocvw/webbrowser.c 25 Sep 2006 19:46:43 -0000 1.65 > +++ dlls/shdocvw/webbrowser.c 29 Sep 2006 00:55:46 -0000 > @@ -675,7 +675,7 @@ > if(V_VT(URL) != VT_BSTR) > return E_INVALIDARG; > > - if(PostData && V_VT(PostData) != VT_EMPTY) { > + if(PostData && V_VT(PostData) != VT_EMPTY && V_VT(PostData) != VT_ERROR) { > if(V_VT(PostData) != (VT_ARRAY | VT_UI1) > || V_ARRAY(PostData)->cDims != 1) { > WARN("Invalid PostData\n"); > @@ -686,7 +686,7 @@ > post_data_len = V_ARRAY(PostData)->rgsabound[0].cElements; > } > > - if(Headers && V_VT(Headers) != VT_EMPTY) { > + if(Headers && V_VT(Headers) != VT_EMPTY && V_VT(Headers) != VT_ERROR) { > if(V_VT(Headers) != VT_BSTR) > return E_INVALIDARG; > > > > ------------------------------------------------------------------------ > > -- Michael Stefaniuc Tel.: +49-711-96437-199 Sr. Network Engineer Fax.: +49-711-96437-111 Red Hat GmbH Email: mstefani(a)redhat.com Hauptstaetterstr. 58 http://www.redhat.de/ D-70178 Stuttgart

3 3

Re: [PATCH 0/4] Janitorial: Win64 printf format warning fixes
by Michael Stefaniuc 29 Sep '06

29 Sep '06

Michael Stefaniuc wrote: > For all the people wanting to help out with this janitorial task please > wait until Alexandre commits this patch series. After that i'll create a > page for this task on the Wine wiki and link it from > http://wiki.winehq.org/JanitorialProjects Ok, this janitorial task has now a Wiki page: http://wiki.winehq.org/Win64PrintfFormatWarnings This is a good opportunity for anybody that wants to start submitting patches for Wine and get accustomed to this process. > I will put in a download link for my perl script that can automaticly > fix around 20000 out of the remaining 25000 warnings. You realy do not > want to go manualy over 25k warnings. bye michael -- Michael Stefaniuc Tel.: +49-711-96437-199 Sr. Network Engineer Fax.: +49-711-96437-111 Red Hat GmbH Email: mstefani(a)redhat.com Hauptstaetterstr. 58 http://www.redhat.de/ D-70178 Stuttgart

1 0