September 2006 - Wine-devel

Can't open DLL's without sudo
by Paul Wilkinson 29 Sep '06

29 Sep '06

I'm running wine v 0.9.20 under Fedora Core 5. I'm trying to get the Syncrosoft License Control Center to run under wine. for some reason it can only load MFC42.DLL and MSVCRT.DLL if I put 'sudo' on the command line: [paul(a)localhost LCC]$ wine LCC.exe err:module:import_dll Library MFC42.DLL (which is needed by L"C:\\Program Files\\Syncrosoft\\LCC\\LCC.exe") not found err:module:import_dll Library MSVCRT.dll (which is needed by L"C:\\Program Files\\Syncrosoft\\LCC\\LCC.exe") not found err:module:import_dll Library MSVCRT.dll (which is needed by L"C:\\windows\\system32\\MSVCP60.dll") not found err:module:import_dll Library MSVCP60.dll (which is needed by L"C:\\Program Files\\Syncrosoft\\LCC\\LCC.exe") not found err:module:LdrInitializeThunk Main exe initialization for L"C:\\Program Files\\Syncrosoft\\LCC\\LCC.exe" failed, status c0000135 [paul(a)localhost LCC]$ The NtOpenFile that tries to open the DLL (in loader.c) is returning c00000022 (ACCESS_DENIED). But the permissions for these DLL's are wide open. Any idea what's going on? - Paul

4 4

crypt32/sip: new test failures
by Marcus Meissner 29 Sep '06

29 Sep '06

Hi, ../../../tools/runtest -q -P wine -M crypt32.dll -T ../../.. -p crypt32_test.exe.so sip.c && touch sip.ok sip.c:176: Test failed: Expected CryptSIPRetrieveSubjectGuid to succeed sip.c:177: Test failed: Expected ERROR_SUCCESS, got 0x00000002 sip.c:179: Test failed: Expected ({c689aab8-8e78-11d0-8c47-00c04fc295ee}), got ({c689aab8-8e78-11d0-8c47-00c04fc295ee}). sip.c:187: Test failed: Expected CryptSIPRetrieveSubjectGuid to succeed sip.c:188: Test failed: Expected ERROR_SUCCESS, got 0x00000057 sip.c:190: Test failed: Expected ({c689aab8-8e78-11d0-8c47-00c04fc295ee}), got ({c689aab8-8e78-11d0-8c47-00c04fc295ee}). sip.c:199: Test failed: Expected CryptSIPRetrieveSubjectGuid to succeed sip.c:200: Test failed: Expected ERROR_SUCCESS, got 0x00000057 sip.c:202: Test failed: Expected ({c689aab8-8e78-11d0-8c47-00c04fc295ee}), got ({c689aab8-8e78-11d0-8c47-00c04fc295ee}). fixme:crypt:CryptSIPLoad ((null) 0 (nil)) stub! fixme:crypt:CryptSIPLoad ({7b845773-cc00-7ffd-0000-00003b933460} 0 (nil)) stub! fixme:crypt:CryptSIPLoad ({deadbeef-dead-beef-dead-beefdeadbeef} 0 0x33fda0) stub! fixme:crypt:CryptSIPLoad ({deadbeef-dead-beef-dead-beefdeadbeef} 0 0x33fda0) stub! fixme:crypt:CryptSIPLoad ({c689aaba-8e78-11d0-8c47-00c04fc295ee} 0 0x33fda0) stub! fixme:crypt:CryptSIPLoad ({c689aaba-8e78-11d0-8c47-00c04fc295ee} 0 0x33fda0) stub! fixme:crypt:CryptSIPLoad ({c689aaba-8e78-11d0-8c47-00c04fc295ee} 1 0x33fda0) stub! make[2]: *** [sip.ok] Fehler 9 I did run "wineprefixcreate" before (just in case). Ciao, Marcus

1 0

Re: wine-devel Digest, Vol 14, Issue 93
by Anton Litvinov 29 Sep '06

29 Sep '06

----- Original Message ----- From: <wine-devel-request(a)winehq.org> To: <wine-devel(a)winehq.org> Sent: Friday, September 29, 2006 8:58 PM Subject: wine-devel Digest, Vol 14, Issue 93 > Send wine-devel mailing list submissions to > wine-devel(a)winehq.org > > To subscribe or unsubscribe via the World Wide Web, visit > http://www.winehq.org/mailman/listinfo/wine-devel > or, via email, send a message with subject or body 'help' to > wine-devel-request(a)winehq.org > > You can reach the person managing the list at > wine-devel-owner(a)winehq.org > > When replying, please edit your Subject line so it is more specific > than "Re: Contents of wine-devel digest..." > > > Today's Topics: > > 1. Re: Governance Ideas (Mike McCormack) > 2. Re: shdocvw(2/2): ignore VT_ERROR arguments to > WebBrowser_Navigate2 (Michael Stefaniuc) > 3. Re: make test failure (Michael Stefaniuc) > 4. Re: [D3D9] Remove const qualifier on state_test data. > (Michael Stefaniuc) > 5. compiling wine for amd64 on ubuntu dapper 6.06 (Gerald Britton) > 6. Re: make test failure (Vitaliy Margolen) > 7. Re: shdocvw(2/2): ignore VT_ERROR arguments to > WebBrowser_Navigate2 (Juan Lang) > 8. Re: USER32: Stub implementation of BlockInput (Juan Lang) > > > ---------------------------------------------------------------------- > > Message: 1 > Date: Fri, 29 Sep 2006 18:02:08 +0900 > From: Mike McCormack <mike(a)codeweavers.com> > Subject: Re: Governance Ideas > To: bobl(a)optushome.com.au > Cc: wine-devel(a)winehq.com, Alexandre Julliard <julliard(a)winehq.org> > Message-ID: <451CE110.5000708(a)codeweavers.com> > Content-Type: text/plain; charset=us-ascii; format=flowed > > > Robert Lunnon wrote: > > > "Community Focused Process" means what it says, develop a process which is > > centred on the community the project serves. This requires the project to > > answer some introspective questions > > > > 1. Who "owns" Wine, does wine belong to A.) Alexandre, or B) the community > > it serves. > > A) Alexandre is a benelovent dictator. He manages Wine with the > interests of "the community" in mind, as he sees them. > > > 1. Answer the questions about the "ownership" of wine and identify the > > community it serves. Determine the right of the community to be involved is > > setting wines direction IE The Bill of rights I mentioned before (for each > > community Developers VS Users etc). > > Your "bill of rights" is the Wine license, the LGPL. > > > 2. Alexandre documents the exact logic he uses to determine patch > > acceptability which becomes the patch acceptance policy in the interim. > > It's very likely impossible to write that down. If you don't agree with > me, please write down your proposal. > > > 3. The project develops a community process for establishing project direction > > and maintaining the patch acceptance policy which includes stakeholders > > elected from the "owners" IE communities with a stakeholding in wine > > NetBSD is a project that is (was?) run by committees: > > http://mail-index.netbsd.org/netbsd-users/2006/08/30/0016.html > > If you want Wine to be run by a committee, how about creating your own > fork so you can run it as you see fit? > > Mike > > > > ------------------------------ > > Message: 2 > Date: Fri, 29 Sep 2006 10:57:26 +0200 > From: Michael Stefaniuc <mstefani(a)redhat.com> > Subject: Re: shdocvw(2/2): ignore VT_ERROR arguments to > WebBrowser_Navigate2 > To: juan_lang(a)yahoo.com > Cc: wine-devel(a)winehq.org > Message-ID: <451CDFF6.5060904(a)redhat.com> > Content-Type: text/plain; charset=UTF-8 > > Juan Lang wrote: > > Combined with the first patch, I'm able to log in with Skype 2.6 beta. > > > > ChangeLog: ignore VT_ERROR arguments to WebBrowser_Navigate2 > Ignoring VT_ERROR just masks a previous error. > > bye > michael > > > Index: dlls/shdocvw/webbrowser.c > > =================================================================== > > RCS file: /home/wine/wine/dlls/shdocvw/webbrowser.c,v > > retrieving revision 1.65 > > diff -u -r1.65 webbrowser.c > > --- dlls/shdocvw/webbrowser.c 25 Sep 2006 19:46:43 -0000 1.65 > > +++ dlls/shdocvw/webbrowser.c 29 Sep 2006 00:55:46 -0000 > > @@ -675,7 +675,7 @@ > > if(V_VT(URL) != VT_BSTR) > > return E_INVALIDARG; > > > > - if(PostData && V_VT(PostData) != VT_EMPTY) { > > + if(PostData && V_VT(PostData) != VT_EMPTY && V_VT(PostData) != VT_ERROR) { > > if(V_VT(PostData) != (VT_ARRAY | VT_UI1) > > || V_ARRAY(PostData)->cDims != 1) { > > WARN("Invalid PostData\n"); > > @@ -686,7 +686,7 @@ > > post_data_len = V_ARRAY(PostData)->rgsabound[0].cElements; > > } > > > > - if(Headers && V_VT(Headers) != VT_EMPTY) { > > + if(Headers && V_VT(Headers) != VT_EMPTY && V_VT(Headers) != VT_ERROR) { > > if(V_VT(Headers) != VT_BSTR) > > return E_INVALIDARG; > > > > > > > > ------------------------------------------------------------------------ > > > > > > > -- > Michael Stefaniuc Tel.: +49-711-96437-199 > Sr. Network Engineer Fax.: +49-711-96437-111 > Red Hat GmbH Email: mstefani(a)redhat.com > Hauptstaetterstr. 58 http://www.redhat.de/ > D-70178 Stuttgart > > > > ------------------------------ > > Message: 3 > Date: Fri, 29 Sep 2006 10:59:02 +0200 > From: Michael Stefaniuc <mstefani(a)redhat.com> > Subject: Re: make test failure > To: wine-devel(a)winehq.org > Message-ID: <451CE056.5000702(a)redhat.com> > Content-Type: text/plain; charset=UTF-8 > > James Hawkins wrote: > > On 9/28/06, Vitaliy Margolen <wine-devel(a)kievinfo.com> wrote: > > > >> James Hawkins wrote: > >> > On 9/28/06, Paul Vriens <Paul.Vriens(a)xs4all.nl> wrote: > >> >> On Thu, 2006-09-28 at 11:27 -0700, James Hawkins wrote: > >> >> > Hi, > >> >> > > >> >> > Running make test fails with: > >> >> > > >> >> > make[2]: Entering directory > >> `/usr/local/src/wine/dlls/comctl32/tests' > >> >> > ../../../tools/runtest -q -P wine -M comctl32.dll -T ../../.. -p > >> >> > comctl32_test.exe.so tab.c && touch tab.ok > >> >> > tab.c:184: Test failed: no icon, set size: Expected [44,20] got > >> [56,20] > >> >> > tab.c:208: Test failed: no icon, set size: Expected [42,20] got > >> [54,20] > >> >> > tab.c:184: Test failed: no icon, set size: Expected [44,20] got > >> [56,20] > >> >> > tab.c:208: Test failed: no icon, set size: Expected [42,20] got > >> [54,20] > >> >> > tab.c:184: Test failed: no icon, set size: Expected [44,20] got > >> [56,20] > >> >> > tab.c:184: Test failed: no icon, set size: Expected [54,20] got > >> [56,20] > >> >> > make[2]: *** [tab.ok] Error 6 > >> >> > > >> >> Succeeds over here. > >> >> > >> > > >> > I know, it succeeds on a lot of machines, but the point is that it > >> > shouldn't fail on any machine. > >> > > >> Please remove your ~/.wine dir and try again. It seems your metrics are > >> set different. Or your fonts are wrong. > >> > > > > The tests still fail with a clean .wine. > Yes, i used an empty .wine too. > > bye > michael > -- > Michael Stefaniuc Tel.: +49-711-96437-199 > Sr. Network Engineer Fax.: +49-711-96437-111 > Red Hat GmbH Email: mstefani(a)redhat.com > Hauptstaetterstr. 58 http://www.redhat.de/ > D-70178 Stuttgart > > > > ------------------------------ > > Message: 4 > Date: Fri, 29 Sep 2006 12:33:27 +0200 > From: Michael Stefaniuc <mstefani(a)redhat.com> > Subject: Re: [D3D9] Remove const qualifier on state_test data. > To: ivg231(a)gmail.com > Cc: wine-devel(a)winehq.org > Message-ID: <451CF677.1040305(a)redhat.com> > Content-Type: text/plain; charset=UTF-8 > > Ivan Gyurdiev wrote: > > Type: Cleanup > > > > Why: > > The const qualifier is unnecessarily restrictive. > > I intend to allocate and free such data on the heap in a future patch. > > Instead, const should be primarily used on function parameters. > Question: do you realy have to use void pointers? Void pointers are > compatible with every pointer type and thus will disable the type > checking of the compiler. Also you do not need to to cast a rvalue to > void * if the type of the lvalue is void *. > > bye > michael > > > --- > > dlls/d3d9/tests/stateblock.c | 40 ++++++++++++++++++++-------------------- > > 1 files changed, 20 insertions(+), 20 deletions(-) > > > > diff --git a/dlls/d3d9/tests/stateblock.c b/dlls/d3d9/tests/stateblock.c > > index 65a11e6..68b431a 100644 > > --- a/dlls/d3d9/tests/stateblock.c > > +++ b/dlls/d3d9/tests/stateblock.c > > @@ -105,20 +105,20 @@ typedef struct state_test { > > * as the default data, but a write can have side effects. > > * The initial data is tested first, before any writes take place > > * The default data can be tested after a write */ > > - const void* initial_data; > > + void* initial_data; > > > > /* The default data is the standard state to compare > > * against, and restore to */ > > - const void* default_data; > > + void* default_data; > > > > /* The test data is the experiment data to try > > * in - what we want to write > > * out - what windows will actually write (not necessarily the same) */ > > - const void* test_data_in; > > - const void* test_data_out; > > + void* test_data_in; > > + void* test_data_out; > > > > /* The poison data is the data to preinitialize the return buffer to */ > > - const void* poison_data; > > + void* poison_data; > > > > /* Return buffer */ > > void* return_data; > > @@ -562,11 +562,11 @@ static void shader_constants_queue_test( > > shader_constant_arg* arg = buffer; > > shader_constant_data* return_data = (shader_constant_data*) (arg + 1); > > > > - test->test_data_in = &shader_constant_test_data; > > - test->test_data_out = &shader_constant_test_data; > > - test->default_data = &shader_constant_default_data; > > - test->initial_data = &shader_constant_default_data; > > - test->poison_data = &shader_constant_poison_data; > > + test->test_data_in = (void*) &shader_constant_test_data; > > + test->test_data_out = (void*) &shader_constant_test_data; > > + test->default_data = (void*) &shader_constant_default_data; > > + test->initial_data = (void*) &shader_constant_default_data; > > + test->poison_data = (void*) &shader_constant_poison_data; > > test->return_data = return_data; > > test->data_size = sizeof(shader_constant_data); > > test->set_handler = shader_constant_set_handler; > > @@ -697,11 +697,11 @@ static void lights_queue_test( > > light_arg* arg = buffer; > > light_data* return_data = (light_data*) (arg + 1); > > > > - test->test_data_in = &light_test_data_in; > > - test->test_data_out = &light_test_data_out; > > - test->default_data = &light_default_data; > > - test->initial_data = &light_initial_data; > > - test->poison_data = &light_poison_data; > > + test->test_data_in = (void*) &light_test_data_in; > > + test->test_data_out = (void*) &light_test_data_out; > > + test->default_data = (void*) &light_default_data; > > + test->initial_data = (void*) &light_initial_data; > > + test->poison_data = (void*) &light_poison_data; > > test->return_data = return_data; > > test->data_size = sizeof(light_data); > > test->set_handler = light_set_handler; > > @@ -856,11 +856,11 @@ static void transform_queue_test( > > { > > transform_data* return_data = buffer; > > > > - test->test_data_in = &transform_test_data; > > - test->test_data_out = &transform_test_data; > > - test->default_data = &transform_default_data; > > - test->initial_data = &transform_default_data; > > - test->poison_data = &transform_poison_data; > > + test->test_data_in = (void*) &transform_test_data; > > + test->test_data_out = (void*) &transform_test_data; > > + test->default_data = (void*) &transform_default_data; > > + test->initial_data = (void*) &transform_default_data; > > + test->poison_data = (void*) &transform_poison_data; > > test->return_data = return_data; > > test->data_size = sizeof(transform_data); > > test->set_handler = transform_set_handler; > > -- > Michael Stefaniuc Tel.: +49-711-96437-199 > Sr. Network Engineer Fax.: +49-711-96437-111 > Red Hat GmbH Email: mstefani(a)redhat.com > Hauptstaetterstr. 58 http://www.redhat.de/ > D-70178 Stuttgart > > > > ------------------------------ > > Message: 5 > Date: Fri, 29 Sep 2006 09:06:48 -0400 > From: "Gerald Britton" <gerald.britton(a)gmail.com> > Subject: compiling wine for amd64 on ubuntu dapper 6.06 > To: wine-devel(a)winehq.org > Message-ID: > <5d1a32000609290606u56007017t6f8ace8de14bb0ab(a)mail.gmail.com> > Content-Type: text/plain; charset=ISO-8859-1; format=flowed > > Hi -- I'm trying to get wine going on my ubuntu dapper installation on > an amd 64 box. I have followed the wiki instructions in > http://wiki.winehq.org/WineOn64bit for ubuntu and rechecked my work. > Two things go wrong: > > 1. /configure can't find opengl, and produces these messages: > > configure: WARNING: Wine will be build without OpenGL or Direct3D support > configure: WARNING: because something is wrong with the OpenGL setup: > configure: WARNING: No OpenGL library found on this system. > > 2. make depend works, but make all fails with this: > > LD_LIBRARY_PATH="../../libs/wine:$LD_LIBRARY_PATH" ../../tools/wrc/wrc > --nostdinc -I. -I. -I../../include -I../../include > -I/usr/include/freetype2 -D__WINESRC__ -D_GDI32_ -foversion.res > version.rc > ../../tools/winegcc/winegcc -B../../tools/winebuild -shared > ./gdi32.spec dispdib.spec.o gdi.exe.spec.o wing.spec.o bidi16.o > dispdib.o env.o gdi16.o metafile16.o wing.o bidi.o bitblt.o bitmap.o > brush.o clipping.o dc.o dib.o driver.o enhmetafile.o enhmfdrv/bitblt.o > enhmfdrv/dc.o enhmfdrv/graphics.o enhmfdrv/init.o enhmfdrv/mapping.o > enhmfdrv/objects.o font.o freetype.o gdi_main.o gdiobj.o icm.o > mapping.o metafile.o mfdrv/bitblt.o mfdrv/dc.o mfdrv/graphics.o > mfdrv/init.o mfdrv/mapping.o mfdrv/objects.o mfdrv/text.o painting.o > palette.o path.o pen.o printdrv.o region.o version.res -o > gdi32.dll.so -ladvapi32 -lkernel32 -lntdll /usr/lib/libsicuuc.a > /usr/lib/libsicudata.a -lstdc++ -lgcc_s ../../libs/port/libwine_port.a > -L/lib32 -L/usr/lib32 -Wl,-rpath,/lib32 -Wl,-rpath,/usr/lib32 > ld: Relocatable linking with relocations from format elf64-x86-64 > (/usr/lib/libsicuuc.a(ubidi.ao)) to format elf32-i386 (gdi32.ArPHdq.o) > is not supported > winebuild: ld -m elf_i386 -r failed with status 256 > winegcc: ../../tools/winebuild/winebuild failed. > make[2]: *** [gdi32.dll.so] Error 2 > make[2]: Leaving directory `/tmp/wine-0.9.22/dlls/gdi' > make[1]: *** [gdi] Error 2 > make[1]: Leaving directory `/tmp/wine-0.9.22/dlls' > make: *** [dlls] Error 2 > > > > I'm not sure what to do now. Any feedback/suggestions would be appreciated. > > > > ------------------------------ > > Message: 6 > Date: Fri, 29 Sep 2006 07:36:58 -0600 > From: Vitaliy Margolen <wine-devel(a)kievinfo.com> > Subject: Re: make test failure > To: wine-devel(a)winehq.org > Message-ID: <451D217A.4060808(a)kievinfo.com> > Content-Type: text/plain; charset=UTF-8 > > Michael Stefaniuc wrote: > > James Hawkins wrote: > >> On 9/28/06, Vitaliy Margolen <wine-devel(a)kievinfo.com> wrote: > >> > >>> James Hawkins wrote: > >>>> On 9/28/06, Paul Vriens <Paul.Vriens(a)xs4all.nl> wrote: > >>>>> On Thu, 2006-09-28 at 11:27 -0700, James Hawkins wrote: > >>>>>> Hi, > >>>>>> > >>>>>> Running make test fails with: > >>>>>> > >>>>>> make[2]: Entering directory > >>> `/usr/local/src/wine/dlls/comctl32/tests' > >>>>>> ../../../tools/runtest -q -P wine -M comctl32.dll -T ../../.. -p > >>>>>> comctl32_test.exe.so tab.c && touch tab.ok > >>>>>> tab.c:184: Test failed: no icon, set size: Expected [44,20] got > >>> [56,20] > >>>>>> tab.c:208: Test failed: no icon, set size: Expected [42,20] got > >>> [54,20] > >>>>>> tab.c:184: Test failed: no icon, set size: Expected [44,20] got > >>> [56,20] > >>>>>> tab.c:208: Test failed: no icon, set size: Expected [42,20] got > >>> [54,20] > >>>>>> tab.c:184: Test failed: no icon, set size: Expected [44,20] got > >>> [56,20] > >>>>>> tab.c:184: Test failed: no icon, set size: Expected [54,20] got > >>> [56,20] > >>>>>> make[2]: *** [tab.ok] Error 6 > >>>>>> > >>>>> Succeeds over here. > >>>>> > >>>> I know, it succeeds on a lot of machines, but the point is that it > >>>> shouldn't fail on any machine. > >>>> > >>> Please remove your ~/.wine dir and try again. It seems your metrics are > >>> set different. Or your fonts are wrong. > >>> > >> The tests still fail with a clean .wine. > > Yes, i used an empty .wine too. > > > And you guys have windows like "Arial" font? Any test that uses fonts > will not work if you don't have that font or it's not the same metrics > as the native one. > > Vitaliy. > > > > ------------------------------ > > Message: 7 > Date: Fri, 29 Sep 2006 08:36:46 -0700 (PDT) > From: Juan Lang <juan_lang(a)yahoo.com> > Subject: Re: shdocvw(2/2): ignore VT_ERROR arguments to > WebBrowser_Navigate2 > To: Michael Stefaniuc <mstefani(a)redhat.com> > Cc: wine-devel(a)winehq.org > Message-ID: <20060929153646.65850.qmail(a)web30008.mail.mud.yahoo.com> > Content-Type: text/plain; charset=iso-8859-1 > > > Ignoring VT_ERROR just masks a previous error. > > Hm.. are you sure? These are input arguments, not results. This isn't > the only app that gets further with this patch. See also bug 6166. > > I guess a test case is the only answer. > > --Juan > > __________________________________________________ > Do You Yahoo!? > Tired of spam? Yahoo! Mail has the best spam protection around > http://mail.yahoo.com > > > > ------------------------------ > > Message: 8 > Date: Fri, 29 Sep 2006 09:57:35 -0700 (PDT) > From: Juan Lang <juan_lang(a)yahoo.com> > Subject: Re: USER32: Stub implementation of BlockInput > To: Jason Green <jave27(a)gmail.com> > Cc: wine-devel(a)winehq.org > Message-ID: <20060929165735.77898.qmail(a)web30010.mail.mud.yahoo.com> > Content-Type: text/plain; charset=iso-8859-1 > > You forgot the patch.. > > --Juan > > __________________________________________________ > Do You Yahoo!? > Tired of spam? Yahoo! Mail has the best spam protection around > http://mail.yahoo.com > > > > ------------------------------ > > _______________________________________________ > wine-devel mailing list - wine-devel(a)winehq.org > http://www.winehq.org/mailman/listinfo/wine-devel > > > End of wine-devel Digest, Vol 14, Issue 93 > ******************************************

1 0

Re: make test failure #6
by Juan Lang 29 Sep '06

29 Sep '06

Hi James, > make[2]: Entering directory `/usr/local/src/wine/dlls/user/tests' > ../../../tools/runtest -q -P wine -M user32.dll -T ../../.. -p > user32_test.exe.so sysparams.c && touch sysparams.ok > sysparams.c:1471: Test failed: wrong value in registry -1, expected 154 > sysparams.c:1474: Test failed: wrong value in registry -1, expected 0 > sysparams.c:1477: Test failed: wrong value in registry -1, expected 0 > sysparams.c:1480: Test failed: wrong value in registry -1, expected 8 > make[2]: *** [sysparams.ok] Error 4 This, like many other errors, disappears for me when I rerun make test. (I'm not too happy with the 'rerun make test' option, but I don't see people falling all over themselves up to fix the tests, either.) --Juan __________________________________________________ Do You Yahoo!? Tired of spam? Yahoo! Mail has the best spam protection around http://mail.yahoo.com

2 1

[rsaenh-test]: import&export of a plaintext public key + algID check
by Karsten Elfenbein 29 Sep '06

29 Sep '06

* test for importing a PlainPublicKey * test for the correct ALG_ID after the import * test for the correct PlainPublicKey after exporting the key again Karsten

1 0

make test failure (#7?)
by Juan Lang 29 Sep '06

29 Sep '06

After I run make test a bunch of times to get other failures to disappear, I get this: make[2]: Entering directory `/home/juan/src/wine-20050725/dlls/user/tests' ../../../tools/runtest -q -P wine -M user32.dll -T ../../.. -p user32_test.exe.so win.c && touch win.ok fixme:win:WIN_CreateWindowEx Parent is HWND_MESSAGE win.c:2554: Test failed: message 000f available make[2]: *** [win.ok] Error 1 make[2]: Leaving directory `/home/juan/src/wine-20050725/dlls/user/tests' make[1]: *** [user/tests/__test__] Error 2 make[1]: Leaving directory `/home/juan/src/wine-20050725/dlls' make: *** [dlls/__test__] Error 2 --Juan __________________________________________________ Do You Yahoo!? Tired of spam? Yahoo! Mail has the best spam protection around http://mail.yahoo.com

1 0

Re: shdocvw: Make sure BSTR is allocated before calling sink
by Jacek Caban 29 Sep '06

29 Sep '06

Hi Cihan, Cihan Altinay wrote: > This fixes bug 6054 and let's MSN Messenger 7 start up. > http://bugs.winehq.org/show_bug.cgi?id=6054 > > --- > dlls/shdocvw/dochost.c | 3 ++- > 1 files changed, 2 insertions(+), 1 deletions(-) > > diff --git a/dlls/shdocvw/dochost.c b/dlls/shdocvw/dochost.c > index 5bb40e0..8d78a49 100644 > --- a/dlls/shdocvw/dochost.c > +++ b/dlls/shdocvw/dochost.c > @@ -49,11 +49,12 @@ static void navigate_complete(DocHost *T > V_DISPATCH(params+1) = disp; > > V_VT(&url) = VT_BSTR; > - V_BSTR(&url) = This->url; > + V_BSTR(&url) = SysAllocString(This->url); > > call_sink(This->cps.wbe2, DISPID_NAVIGATECOMPLETE2, &dispparams); > call_sink(This->cps.wbe2, DISPID_DOCUMENTCOMPLETE, &dispparams); > > + SysFreeString(This->url); You should free V_BSTR(&url) here, not This->url. Jacek

1 0

make test failure
by James Hawkins 29 Sep '06

29 Sep '06

Hi, Running make test fails with: make[2]: Entering directory `/usr/local/src/wine/dlls/comctl32/tests' ../../../tools/runtest -q -P wine -M comctl32.dll -T ../../.. -p comctl32_test.exe.so tab.c && touch tab.ok tab.c:184: Test failed: no icon, set size: Expected [44,20] got [56,20] tab.c:208: Test failed: no icon, set size: Expected [42,20] got [54,20] tab.c:184: Test failed: no icon, set size: Expected [44,20] got [56,20] tab.c:208: Test failed: no icon, set size: Expected [42,20] got [54,20] tab.c:184: Test failed: no icon, set size: Expected [44,20] got [56,20] tab.c:184: Test failed: no icon, set size: Expected [54,20] got [56,20] make[2]: *** [tab.ok] Error 6 -- James Hawkins

4 8

Re: USER32: Stub implementation of BlockInput
by Juan Lang 29 Sep '06

29 Sep '06

You forgot the patch.. --Juan __________________________________________________ Do You Yahoo!? Tired of spam? Yahoo! Mail has the best spam protection around http://mail.yahoo.com

1 0

Governance Ideas
by Robert Lunnon 29 Sep '06

29 Sep '06

Alexandre said ========================================= To be honest, I have no idea what it is that you are suggesting. All I see is phrases like "community focused process" or "acceptance policy" which frankly are just meaningless buzzwords. If you expect anything to happen, you'll need to make much more concrete suggestions, and provide examples to make us understand how what you are suggesting would work in practice, and how it would be different from what we are doing now. -- Alexandre Julliard julliard(a)winehq.org ========================================== To which I said I would respond soon - well here goes. From the outset I want to say that I am not going to redefine the wine project or make suggestions in the sense of a particular change. I want the communities of developers users and others to define that change. What I will do here is suggest ways in which we could organise to make a change as a collective. Firstly the buzzwords "Community Focused Process" means what it says, develop a process which is centred on the community the project serves. This requires the project to answer some introspective questions 1. Who "owns" Wine, does wine belong to A.) Alexandre, or B) the community it serves. 2 If the answer is B then which community. It may surprise some to realise that a project like this has many communities. We discovered this when setting up the OpenSolaris community process. Some obvious ones are "The Developer Community" and "The User Community" and "Developer + User" Community. There are other less obvious communities, eg the community of distribution maintainers who may be neither developer or user. If we decide that the community "Owns" Wine then it needs to be established whether the community has a right to direct wine's development. As the "Owner" I'd argue the community should have this right. Second Buzzword "Patch Acceptance Policy" means the rules by which a patch is deemed acceptable or not. At the moment this is pretty close to "It's acceptable if Alexandre commits it" This is OK in a community process as long as the community that wine serves supports this approach. I think the recent thread throws significant doubt on this. This particular patch acceptance policy is not Transparent, this is the key reason why dropped patches cause so much argument, why many developers leave the project and possibly why Wine doesn't get the major backing some projects do (EG Gnome, KDE Xorg) dealing with the wine project is risky business. Now what do I propose... 1. Answer the questions about the "ownership" of wine and identify the community it serves. Determine the right of the community to be involved is setting wines direction IE The Bill of rights I mentioned before (for each community Developers VS Users etc). 2. Alexandre documents the exact logic he uses to determine patch acceptability which becomes the patch acceptance policy in the interim. This should be done to the point that someone else could take over from Alexandre and achieve the same result. This opens the way to multiple maintainers as well as allowing Alexandre to take more holidays. 3. The project develops a community process for establishing project direction and maintaining the patch acceptance policy which includes stakeholders elected from the "owners" IE communities with a stakeholding in wine 4. A community process is run to A.) Establish the communities objective for wine - this will actually probably be reasonably argumentative, but that is exactly how it should be. If it's not there is probably something wrong. It was with OpenSolaris and governance was the greatest concern with that project too. B) review the Patch acceptance policy in line with the community objective. For example the policy may be adjusted to favour functionality improvements, or loosen gating on changes leading to solutions that wine critically needs or even establish a "must have" application. 5. A mechanism is created to independently review patches (appeal process) for acceptability IE Whether a patch meets the acceptance policy. Note that if a patch acceptable to the policy is rejected then the policy may need to change (Requiring a new community process to review that change) or an architectural decision needs to be taken. This is done by the architecture review board in the OpenSolaris process. Among other things when a patch is sent to appeal the owner of the patch is guaranteed an explanation of how the patch doesn't meet the acceptance policy. Now if we did all this we would * Have a picture of the needs of the community * Have a way to direct the project toward meeting that need * Have a way to demonstrate we intend to meet that need * Have a consistent review process for patches * Have a way to multistream patches * Have an open transparent, trusting and consistent environment in which to work * Have a way to change and grow * Open ways to allow business to confidently invest in Wine. Even if we ended up with exactly what we have now we will have improved transparency resulting in higher quality of work and less resentment of the process, improving developer retention rates and reducing disputes. Bob

6 5