January 2007 - Wine-devel - list.winehq.org

Using Wine headers on Mac OS X
by Mike 17 Jan '07

17 Jan '07

Hi. I know this is unsupported but I am trying to use the Wine windows headers to port some Windows code to Mac OS X. I'm not really trying to use the Wine functionality - I use the headers more to define and map the existing Win32 defines, and datatypes to Mac OS so that I can make as few changes to the Windows code I am porting as possible. My big question is: when I add the Wine headers to my project, it seems that every datatype in the wine headers is undefined. I noticed that most wine headers don't have any #includes in them. is there some precompiled or metaheader that I should be including in all of the wine files in order to get the compiler to see the data types? Thanks, Mike

3 5

Re: [17/49] wined3d: Rewrite shader_glsl_mov() to properly take the write mask into account, in case of writing to an address register round the source
by Mirek 17 Jan '07

17 Jan '07

Hi, this patch caused regression in TES: Oblivion, some objects like peoples are broken. Mirek Slugen H. Verbeet napsal(a): > Changelog: > - Rewrite shader_glsl_mov() to properly take the write mask into account > - in case of writing to an address register round the source, rather > than just dropping the fractional part > > > ------------------------------------------------------------------------ > > --- > > dlls/wined3d/glsl_shader.c | 33 ++++++++++++++++++++++++--------- > 1 files changed, 24 insertions(+), 9 deletions(-) > > diff --git a/dlls/wined3d/glsl_shader.c b/dlls/wined3d/glsl_shader.c > index 60f74c0..6579e6d 100644 > --- a/dlls/wined3d/glsl_shader.c > +++ b/dlls/wined3d/glsl_shader.c > @@ -963,17 +963,32 @@ void shader_glsl_arith(SHADER_OPCODE_ARG* arg) { > > /* Process the WINED3DSIO_MOV opcode using GLSL (dst = src) */ > void shader_glsl_mov(SHADER_OPCODE_ARG* arg) { > - > + IWineD3DBaseShaderImpl* shader = (IWineD3DBaseShaderImpl*) arg->shader; > SHADER_BUFFER* buffer = arg->buffer; > - char tmpLine[256]; > - char dst_str[100], src0_str[100]; > - char dst_reg[50], src0_reg[50]; > - char dst_mask[6], src0_mask[6]; > + char src0_str[100]; > + char src0_reg[50]; > + char src0_mask[6]; > + DWORD write_mask; > > - shader_glsl_add_dst_param(arg, arg->dst, 0, dst_reg, dst_mask, dst_str); > - shader_glsl_add_src_param_old(arg, arg->src[0], arg->src_addr[0], src0_reg, src0_mask, src0_str); > - shader_glsl_add_dst_old(arg->dst, dst_reg, dst_mask, tmpLine); > - shader_addline(buffer, "%s%s)%s;\n", tmpLine, src0_str, dst_mask); > + write_mask = shader_glsl_append_dst(buffer, arg); > + shader_glsl_add_src_param(arg, arg->src[0], arg->src_addr[0], write_mask, src0_reg, src0_mask, src0_str); > + > + /* In vs_1_1 WINED3DSIO_MOV can write to the adress register. In later > + * shader versions WINED3DSIO_MOVA is used for this. */ > + if ((WINED3DSHADER_VERSION_MAJOR(shader->baseShader.hex_version) == 1 && > + !shader_is_pshader_version(shader->baseShader.hex_version) && > + shader_get_regtype(arg->dst) == WINED3DSPR_ADDR) || > + arg->opcode->opcode == WINED3DSIO_MOVA) { > + /* We need to *round* to the nearest int here. */ > + size_t mask_size = shader_glsl_get_write_mask_size(write_mask); > + if (mask_size > 1) { > + shader_addline(buffer, "ivec%d(floor(%s + vec%d(0.5))));\n", mask_size, src0_str, mask_size); > + } else { > + shader_addline(buffer, "int(floor(%s + 0.5)));\n", src0_str); > + } > + } else { > + shader_addline(buffer, "%s);\n", src0_str); > + } > } > > /* Process the dot product operators DP3 and DP4 in GLSL (dst = dot(src0, src1)) */ > > > ------------------------------------------------------------------------ > >

2 10

Re: ntdll: Declare some functions static
by Marcus Meissner 17 Jan '07

17 Jan '07

On Wed, Jan 17, 2007 at 08:20:32PM +0000, Andrew Talbot wrote: > Changelog: > ntdll: Declare some functions static. > > diff -urN a/dlls/ntdll/exception.c b/dlls/ntdll/exception.c > --- a/dlls/ntdll/exception.c 2007-01-10 22:13:12.000000000 +0000 > +++ b/dlls/ntdll/exception.c 2007-01-17 20:11:06.000000000 +0000 > @@ -374,7 +374,7 @@ > /*********************************************************************** > * RtlRaiseException (NTDLL.@) > */ > -void WINAPI __regs_RtlRaiseException( EXCEPTION_RECORD *rec, CONTEXT *context ) > +static void WINAPI __regs_RtlRaiseException( EXCEPTION_RECORD *rec, CONTEXT *context ) > { > NTSTATUS status = raise_exception( rec, context, TRUE ); > if (status != STATUS_SUCCESS) > @@ -624,7 +624,7 @@ > * ntdll-specific implementation to avoid depending on kernel functions. > * Can be removed once ntdll.spec no longer contains stubs. > */ > -void __wine_spec_unimplemented_stub( const char *module, const char *function ) > +static void __wine_spec_unimplemented_stub( const char *module, const char *function ) > { > EXCEPTION_RECORD record; This is not a good idea, it will optimize those functions away, since gcc cannot look into the DEFINE_REGS_ENTRYPOINT() assembly. Ciao, Marcs

2 1

ntdll: Declare some functions static
by Andrew Talbot 17 Jan '07

17 Jan '07

Sorry. This patch breaks compilation. Please do not apply. -- Andy.

1 0

Re: [kernel32][console][try3] Adds comment for function
by Robert Shearman 17 Jan '07

17 Jan '07

Anatoly Lyutin wrote: > + * NOTES > + * Has appeared, since Windows 2000 Professional > */ > HWND WINAPI GetConsoleWindow(VOID) > { > We don't tend to add notes like this for functions as it is meaningless in the context of Wine. Also, when adding comments you must also add a disclaimer stating that you didn't copy it from MSDN. -- Rob Shearman

1 0

Anonymous structs/unions
by Joel Parker 17 Jan '07

17 Jan '07

As seen here <http://source.winehq.org/source/include/winnt.h#L152>, we seem to be going through a lot of trouble to enable anonymous structs and unions for those compilers that support it. Why do this, especially when we need to name them anyway for those that don't? My reason for asking is that I'm doing a casual ANSI sweep of the code, and anonymous unions are causing problems (they're not allowed). I could just put in a test for __STRICT_ANSI__ and disable them if found, but that feels like gaming the system, and it's not a standard macro anyway. The best way (other than just naming all the structs/unions) is to test for __STDC__, but GCC includes that one even when not using -ansi mode. Thoughts? -- Joel Parker

3 2

[try2] user32/tests: add tests for WM_SETICON - what's wrong?
by Kirill K. Smirnov 17 Jan '07

17 Jan '07

Hi, Traditional questions from rejected patch-sender: 1) What's wrong with the patch: http://www.winehq.org/pipermail/wine-patches/2007-January/034949.html 2) What can be done to improve it? -- Kirill

2 1

Re: [3/3] WineD3D: Implement per stream offsets
by Kovács András 17 Jan '07

17 Jan '07

Call of duty 2 uses steam offsets. 2007. január 17. 00.06 dátummal Stefan Dösinger ezt írta: > Stumbled uppon that while reading up instancing. This is a functionality > technically required for all d3d9 drivers. The new functionality is not > really tested because I have no app that really needs this, but it should > not cause issues with games not using stream offsets. -- ------------------ andras NetClub Lamarr csevego.net andras(a)csevego.net ------------------

3 2

Re: Make.rules.in: Add variables for BISONFLAGS and LEXFLAGS.
by Alexandre Julliard 17 Jan '07

17 Jan '07

Robert Shearman <rob(a)codeweavers.com> writes: > Make BISONFLAGS default to generating debug information so that parser > tracing works in the various tools. You should add this to the makefile of the tool you want to debug. There's no reason to force it for all parsers, and defining it in Make.rules prevents individual makefiles from having their own flags. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: [3/3] WineD3D: Implement per stream offsets
by H. Verbeet 17 Jan '07

17 Jan '07

On 17/01/07, Stefan Dösinger <stefan(a)codeweavers.com> wrote: > really tested because I have no app that really needs this, but it should not > cause issues with games not using stream offsets. > I think Serious Sam 2 required stream offsets. Perhaps I should give that game another try one of these days.

2 1