January 2007 - Wine-devel - list.winehq.org

re: iphlpapi - MacOS / BSD support
by Dan Kegel 16 Jan '07

16 Jan '07

Hi Gav! You wrote: >Author: Mark Adams <mark at transgaming.com> >... Cool... nice to see you on wine-patches again! For completeness, can you specify the license your patches are under? I assume MIT/X11...? - Dan

2 1

Re: user32/tests: add tests for WM_SETICON
by Dmitry Timoshkov 16 Jan '07

16 Jan '07

"Kirill K. Smirnov" <lich(a)math.spbu.ru> wrote: > + /* Message sequences for WM_SETICON */ > + hwnd = CreateWindowExA(0, "TestWindowClass", NULL, > + WS_OVERLAPPEDWINDOW, > + CW_USEDEFAULT, CW_USEDEFAULT, 300, 300, 0, > + NULL, NULL, 0); > + flush_sequence(); > + SendMessage(hwnd, WM_SETICON, ICON_SMALL, (LPARAM)LoadIcon(0, IDI_APPLICATION)); > + ok_sequence(WmSetIcon, "WM_SETICON for window with caption", FALSE); This code doesn't show behaviour of a more interesting case - a visible window. -- Dmitry.

1 0

Re: appdb rating inflation
by Jesse Allen 15 Jan '07

15 Jan '07

Whoever it is that is wanting to update the HOWTO for the Diablo 2 appdb please email me. I don't have my email address on there for nothing. For whatever reason, I can't see who changes things nor does the appdb email me on changes anymore. Quote from new HOWTO note. "THIS IS A DUPLICATE ENTRY. I am making this simply because lots of the information in the original howto is either wrong, invalid or unnecessary. This is the new HOWTO. I'm leaving the old one in place so that the ones that wrote it can see the changes and voice anything before I remove the old one entirely. " I read it and you really did not change anything. But I will say that that YES the HOWTO is mostly unnessecary. However, when I tried going to a skeletal HOWTO, I got a bunch of odd complaints (especially on the CD-ROM info you removed). Also note, that the HOWTO duplicates the War3 one just because it's the same in almost every way. Jesse

1 0

Re: oleaut32: Remove unused items
by Michael Stefaniuc 15 Jan '07

15 Jan '07

Andrew Talbot wrote: > Changelog: > oleaut32: Remove unused items. > > diff -urN a/dlls/oleaut32/vartype.c b/dlls/oleaut32/vartype.c > --- a/dlls/oleaut32/vartype.c 2006-12-22 14:43:36.000000000 +0000 > +++ b/dlls/oleaut32/vartype.c 2007-01-13 20:13:23.000000000 +0000 > @@ -228,7 +228,6 @@ > SIMPLE(LONG64, SHORT, VarI8FromI2); > SIMPLE(LONG64, signed char, VarI8FromI1); > SIMPLE(LONG64, USHORT, VarI8FromUI2); > -SIMPLE(LONG64, LONG, VarI8FromI4); Are you removing a test here? > SIMPLE(LONG64, ULONG, VarI8FromUI4); > POSTST(LONG64, ULONG64, VarI8FromUI8, I8_MAX); bye michael -- Michael Stefaniuc Tel.: +49-711-96437-199 Sr. Network Engineer Fax.: +49-711-96437-111 Red Hat GmbH Email: mstefani(a)redhat.com Hauptstaetterstr. 58 http://www.redhat.de/ D-70178 Stuttgart

2 1

Some stats (Was: Re: Alexandre Julliard : oleaut32/tests: Replace some macros by functions to reduce code size and compile time.)
by Michael Stefaniuc 15 Jan '07

15 Jan '07

Alexandre Julliard wrote: > Module: wine > Branch: master > Commit: 25571d878960cd802aa31f291d473888dc01e035 > URL: http://source.winehq.org/git/wine.git/?a=commit;h=25571d878960cd802aa31f291… > > Author: Alexandre Julliard <julliard(a)winehq.org> > Date: Mon Jan 15 13:01:42 2007 +0100 > > oleaut32/tests: Replace some macros by functions to reduce code size and compile time. Some compile stats for vartest.c on my P4 3GHz HT, 2 GB RAM, FC6, gcc version 4.1.1 20070105 (Red Hat 4.1.1-51) -O0 -O1 -O2 -O3 -Os size vartest.o with -O2 before 9s 38s 60s 870s 750s 1352256 after 3s 23s 35s 41s 42s 474300 I would say impressive, especially the -O3 and -Os changes. bye michael -- Michael Stefaniuc Tel.: +49-711-96437-199 Sr. Network Engineer Fax.: +49-711-96437-111 Red Hat GmbH Email: mstefani(a)redhat.com Hauptstaetterstr. 58 http://www.redhat.de/ D-70178 Stuttgart

1 0

user32: the patches - what's wrong?
by Kirill K. Smirnov 15 Jan '07

15 Jan '07

Hi, Traditional questions from rejected patch-sender: 1) What's wrong with the following patches? http://www.winehq.org/pipermail/wine-patches/2007-January/034758.html http://www.winehq.org/pipermail/wine-patches/2007-January/034790.html 2) What can be done to improve them? Those patches let the window proc repaint NC area instead of calling NCPaint directly. And changes processing of WM_SETICON to be similar with WM_SETTEXT. -- Kirill

2 1

Re: [5] snmpapi: Implement SnmpUtilVarBindListCpy and SnmpUtilVarBindListFree.
by Robert Shearman 15 Jan '07

15 Jan '07

Hans Leidekker wrote: > + > +/*********************************************************************** > + * SnmpUtilVarBindListCpy (SNMPAPI.@) > + */ > +INT WINAPI SnmpUtilVarBindListCpy(SnmpVarBindList *dst, SnmpVarBindList *src) > +{ > + unsigned int i, size; > + SnmpVarBind *src_entry, *dst_entry; > + > + TRACE("(%p, %p)\n", dst, src); > + > + size = sizeof(SnmpVarBindList); > + if (!(dst = HeapAlloc(GetProcessHeap(), 0, size))) return SNMPAPI_ERROR; > Where do you return this memory to the caller? > + > + size = src->len * sizeof(SnmpVarBind *); > + if (!(dst->list = HeapAlloc(GetProcessHeap(), 0, size))) > + { > + HeapFree(GetProcessHeap(), 0, dst); > + return SNMPAPI_ERROR; > + } > + src_entry = src->list; > + dst_entry = dst->list; > + for (i = 0; i < src->len; i++) > + { > + if (SnmpUtilVarBindCpy(dst_entry, src_entry)) > + { > + src_entry++; > + dst_entry++; > + } > + else > + { > + for (--i; i > 0; i--) SnmpUtilVarBindFree(--dst_entry); > + HeapFree(GetProcessHeap(), 0, dst->list); > + HeapFree(GetProcessHeap(), 0, dst); > + return SNMPAPI_ERROR; > + } > + } > + dst->len = src->len; > + return SNMPAPI_NOERROR; > +} > > -- Rob Shearman

1 0

Re: dsound: fix tests for old versions of windows
by Francois Gouget 15 Jan '07

15 Jan '07

On Fri, 12 Jan 2007, Robert Reif wrote: > This patch fixes the tests to they can run without crashing on old versions of > windows that doesn't have dsound.dll. > + hDsound = LoadLibrary("dsound.dll"); + if (hDsound) { [...] + pDirectSoundCaptureEnumerateA=(void*)GetProcAddress(hDsound, + "DirectSoundCaptureEnumerateA"); + if (pDirectSoundCaptureCreate && pDirectSoundCaptureEnumerateA) + { [...] If all dsound.dll implementations are supposed to have these functions (which I believe is the case), then I would test that we found them with an ok() call. Also, if we fail to load dsound.dll, then we should indicate that we are skipping the tests with the new skip() function. This will make it clearer when analysing the logs that a big chunk of functionality was not tested (see the d3d8 tests for instance). -- Francois Gouget <fgouget(a)free.fr> http://fgouget.free.fr/ Computers are like airconditioners They stop working properly if you open WINDOWS

1 0

(Cross)Compile failure for dsound/tests and shlwapi/tests
by Paul Vriens 15 Jan '07

15 Jan '07

Hi, three failures currently prevent winetest.exe from being build. The first one was ole32/tests/marshal.c (where Stefan Leichter sent a MinGW patch for): i386-mingw32-gcc clipboard.cross.o compobj.cross.o hglobalstream.cross.o marshal.cross.o moniker.cross.o ole2.cross.o propvariant.cross.o stg_prop.cross.o storage32.cross.o usrmarshal.cross.o testlist.cross.o -o ole32_crosstest.exe -loleaut32 -lole32 -luser32 -lgdi32 -ladvapi32 -lkernel32 -luuid marshal.cross.o:marshal.c:(.text+0x7a61): undefined reference to `_IID_IChannelHook' collect2: ld returned 1 exit status make: *** [ole32_crosstest.exe] Error 1 The second one is for dsound/tests: i386-mingw32-gcc capture.cross.o ds3d.cross.o ds3d8.cross.o dsound.cross.o dsound8.cross.o duplex.cross.o propset.cross.o testlist.cross.o -o dsound_crosstest.exe -ldsound -lole32 -lversion -luser32 -lkernel32 -ldxguid -luuid -ldxerr8 capture.cross.o:capture.c:(.text+0xcf4): undefined reference to `_CLSID_DirectSoundPrivate' dsound.cross.o:dsound.c:(.text+0xbef): undefined reference to `_CLSID_DirectSoundPrivate' dsound.cross.o:dsound.c:(.text+0xc7a): undefined reference to `_CLSID_DirectSoundPrivate' dsound8.cross.o:dsound8.c:(.text+0xd39): undefined reference to `_CLSID_DirectSoundPrivate' dsound8.cross.o:dsound8.c:(.text+0xdc4): undefined reference to `_CLSID_DirectSoundPrivate' duplex.cross.o:duplex.c:(.text+0x794): more undefined references to `_CLSID_DirectSoundPrivate' follow propset.cross.o:propset.c:(.text+0x122f): undefined reference to `_DSPROPSETID_DirectSoundDevice' propset.cross.o:propset.c:(.text+0x1353): undefined reference to `_DSPROPSETID_DirectSoundDevice' propset.cross.o:propset.c:(.text+0x1477): undefined reference to `_DSPROPSETID_DirectSoundDevice' propset.cross.o:propset.c:(.text+0x159b): undefined reference to `_DSPROPSETID_DirectSoundDevice' propset.cross.o:propset.c:(.text+0x16bf): undefined reference to `_DSPROPSETID_DirectSoundDevice' propset.cross.o:propset.c:(.text+0x179e): more undefined references to `_DSPROPSETID_DirectSoundDevice' follow collect2: ld returned 1 exit status make: *** [dsound_crosstest.exe] Error 1 The third one is for shlwapi/tests: i386-mingw32-gcc clist.cross.o clsid.cross.o generated.cross.o ordinal.cross.o path.cross.o shreg.cross.o string.cross.o testlist.cross.o -o shlwapi_crosstest.exe -lshlwapi -ladvapi32 -lole32 -loleaut32 -lkernel32 -luuid clsid.cross.o:clsid.c:(.data+0x8): undefined reference to `_CATID_BrowsableShellExt' clsid.cross.o:clsid.c:(.data+0xc): undefined reference to `_CATID_BrowseInPlace' clsid.cross.o:clsid.c:(.data+0x10): undefined reference to `_CATID_DeskBand' clsid.cross.o:clsid.c:(.data+0x14): undefined reference to `_CATID_InfoBand' clsid.cross.o:clsid.c:(.data+0x18): undefined reference to `_CATID_CommBand' clsid.cross.o:clsid.c:(.data+0x30): undefined reference to `_CGID_ExplorerBarDoc' clsid.cross.o:clsid.c:(.data+0x50): undefined reference to `_IID_IShellDetails' clsid.cross.o:clsid.c:(.data+0x54): undefined reference to `_IID_IDelayedRelease' clsid.cross.o:clsid.c:(.data+0x94): undefined reference to `_IID_IRemoteComputer' clsid.cross.o:clsid.c:(.data+0x9c): undefined reference to `_IID_IDockingWindow' clsid.cross.o:clsid.c:(.data+0xa0): undefined reference to `_IID_IDockingWindowSite' clsid.cross.o:clsid.c:(.data+0xa8): undefined reference to `_CLSID_NetworkDomain' clsid.cross.o:clsid.c:(.data+0xac): undefined reference to `_CLSID_NetworkServer' clsid.cross.o:clsid.c:(.data+0xb0): undefined reference to `_CLSID_NetworkShare' clsid.cross.o:clsid.c:(.data+0xc8): undefined reference to `_CLSID_Printers' collect2: ld returned 1 exit status make: *** [shlwapi_crosstest.exe] Error 1 Volunteers ? Cheers, Paul.

3 4

vb6 ide getting close...
by Dan Kegel 15 Jan '07

15 Jan '07

OK, the vb6 IDE may not be the most popular app at the moment, but it's still a good test of Wine. It seems to be getting closer; http://bugs.winehq.org/show_bug.cgi?id=5181 and http://bugs.winehq.org/show_bug.cgi?id=4931 are both a fair bit happier. Still not really usable. There seems to be a regression since June: the "New Project" dialog that pops up at the start of vb6 doesn't get drawn properly, though if you arrow around, the icons in it do then get drawn. (See bug 4931.) - Dan

1 0