January 2007 - Wine-devel - list.winehq.org

Re: DirectPlay should initialize The session guid when creating a session
by Tomas Carnecky 29 Jan '07

29 Jan '07

Alessandro Pignotti wrote: > Hi, > this is my first patch i hope it's well formatted formating is good. > From Microsoft DirectX SDK Documentation it seems that directplay should > initialize the instance guid on session creation, this trivial patch does > that. Two questions: 1. Does windows do this, too? You can't rely on the MS SDK Documentation, always look what windows does and do it likewise. In many cases, a wine test should be written to verify the behavior. 2. Does it solve anything? A bug, a problem with an application? tom

3 2

Wine study
by TRENY Simon 29 Jan '07

29 Jan '07

Hello guys :) We are a team of French students (at ENSEIRB, an engineering school in Bordeaux), and we are studying the Wine project as an example of open source project. We'd like to find out more about how things work from the inside, from any developer's point of view. So we have compiled here our main questions for those who are willing to help us.. Feel free to answer further than the actual question, we are looking for a real insight! :) Sorry in advance for those who are not interested, you can just skip this mail ;) -First, what is the nick under which u commit ? -What is your role in the Wine project? -Which country do u code from? -Who are the programmers you consider to be the "core" of the project? -Who are those you actually ask for help when you need some (e.g. about compatibility issues)? -Do you use means of communicating with the rest of the devs other than irc and the mailing lists? Do you find it (irc and MLs) entirely suited to your needs? -When there is a decision concerning the whole team you wish to see taken, how do u see to that? -Have you developed links with some devs that go beyond working on the same project? -How much time do you spend doing Wine developing (per week and per day, depending on the day)? -What do you do aside from Wine? -When, why and how did you join the Wine project? -Is there any recurrent problem you find to be responsible of unnecessary extra work/loss of time for you or the team? Well, thanks for reading, and greater thanks for answering us if you do.. :) Best regards

1 0

kernel32: allow profile section and key names of zero length
by Claudio Fontana 28 Jan '07

28 Jan '07

Hello, following up on the profile changes started on this thread: http://www.winehq.org/pipermail/wine-devel/2006-December/053009.html I tried a patch in git format made against latest. First attempt at using git, that is. dlls/kernel32/profile.c: allow section and key names of zero length dlls/kernel32/tests/profile.c: add testcases where KEY or SECTION are "". Note: still requires testing on a real Windows 95, to determine if that version behaves differently. If you have access to a Windows 95 installation, please help by applying this patch and: [optional] * run the updated tests in wine (all should pass) * revert changes in dlls/kernel32/profile.c, and run the updated tests in wine (the two new tests should fail) [important] * run the updated test program under a real Windows 95. If tests pass, then Windows 95 behaves exactly the same as later versions. If tests do not pass, then Windows 95 is indeed different, and this patch should be modified accordingly. --- dlls/kernel32/profile.c | 10 ++-------- dlls/kernel32/tests/profile.c | 8 ++++++-- 2 files changed, 8 insertions(+), 10 deletions(-)

1 0

Vacations
by Alexandre Julliard 28 Jan '07

28 Jan '07

Folks, I'm going skiing for a week, so don't be surprised if there aren't any new commits for a while. Now all I need is some snow... -- Alexandre Julliard julliard(a)winehq.org

3 2

Re: USER32: resource.c: add LoadStringW description
by Dmitry Timoshkov 27 Jan '07

27 Jan '07

"Vitaly Lipatov" <lav(a)etersoft.ru> wrote: > Changelog: > Add description for LoadStringW > + * Can be called with buffer = NULL for get size of the requested string That LoadString behaviour in Wine has been questioned already, MSDN keeps silence about that, it needs at least a test case. -- Dmitry.

1 0

Re: [cmd][buildins] Change output resource strings for correctlydisplayed
by Dmitry Timoshkov 26 Jan '07

26 Jan '07

"Anatoly Lyutin" <vostok(a)etersoft.ru> wrote: > --- programs/cmd/builtins.c 23 Jan 2007 12:20:55 -0000 1.5 > +++ programs/cmd/builtins.c 26 Jan 2007 09:23:05 -0000 > @@ -44,6 +44,13 @@ struct env_stack > WCHAR *strings; > }; > > +static inline unsigned int strlenW( const WCHAR *str ) > +{ > + const WCHAR *s = str; > + while (*s) s++; > + return s - str; > +} Please use normal lstrlenW instead of introducing a handmade version. -- Dmitry.

1 0

Re: scroll window fix
by Peter Oberndorfer 26 Jan '07

26 Jan '07

On Thursday 25 January 2007 18:56, Aric Stewart wrote: > finds the case where the scrolling amount exceeds the window but still falls > within the clipping rect. This generates an additional update region > that needs > to be invalidated. > includes a test Hi, I can't argue about the correctness of the patch itself but it adds tabs and a few trailing spaces. Greetings Peter > --- > dlls/user32/painting.c | 21 +++++++++++++++++++++ > dlls/user32/tests/win.c | 9 +++++++++ > 2 files changed, 30 insertions(+), 0 deletions(-) >

2 1

Re: [PATCH 1/4] widl: Handle TKIND_DISPATCH when generating MSFT typelibs.
by Huw Davies 26 Jan '07

26 Jan '07

On Fri, Jan 26, 2007 at 09:13:52PM +0900, Mike McCormack wrote: > diff --git a/tools/widl/write_msft.c b/tools/widl/write_msft.c > index 6248c80..576601b 100644 > --- a/tools/widl/write_msft.c > +++ b/tools/widl/write_msft.c > @@ -126,6 +126,8 @@ typedef struct _msft_typeinfo_t > } msft_typeinfo_t; > > > +static void add_dispinterface_typeinfo(msft_typelib_t *typelib, type_t *dispinterface); Could you move that so it's with all the other forward declarations of add_*_typeinfo funcs (or move all the others to be with this one)? Huw. -- Huw Davies huw(a)codeweavers.com

1 0

Initial MIDI Out support on Mac OS X
by Emmanuel Maillard 26 Jan '07

26 Jan '07

Hi, anything wrong with this patch : http://www.winehq.org/pipermail/wine- patches/2007-January/035027.html thanks Emmanuel

1 0

Is anyone monitoring Transgaming's changes to the LGPL files?
by Scott Ritchie 25 Jan '07

25 Jan '07

I don't know when it started, but Transgaming has been using LGPL chunks of Wine for quite some time. As they're required to, they've released the source for these files, along with whatever changes they've made. However, they're not required to tell us what they did, to send us patches, or to even let us know they've made a change. What this means is that it's possible, even likely, that Transgaming has improved the LGPL parts of Cedega in some important way that would be useful to Wine as well, without us having even known about it. The simplest thing to do is for someone to just track the code they release and diff it against our own stuff, and note if anything new and interesting (eg an implementation of a function) comes up. Then send in a patch if it seems like it could help us too. But, is anyone doing this? Thanks, Scott Ritchie

3 4