January 2007 - Wine-devel - list.winehq.org

make crosstest broken (tmarshal)
by Stefan Leichter 25 Jan '07

25 Jan '07

Hello, the tmarshal tests broke cross compiling. Compiling fails for me with i586-mingw32msvc-gcc -c -I../../../../wine-git/dlls/oleaut32/tests -I. -I../../../../wine-git/include -I../../../include -D_REENTRANT -fPIC -Wall -pipe -fno-strict-aliasing -Wdeclaration-after-statement -Wwrite-strings -Wpointer-arith -g -O2 -o tmarshal.cross.o ../../../../wine-git/dlls/oleaut32/tests/tmarshal.c ../../../../wine-git/dlls/oleaut32/tests/tmarshal.c:1: warning: -fPIC ignored for target (all code is position independent) ../../../../wine-git/dlls/oleaut32/tests/tmarshal.c:28:22: tmarshal.h: Datei oder Verzeichnis nicht gefunden ../../../../wine-git/dlls/oleaut32/tests/tmarshal.c:218: warning: type defaults to `int' in declaration of `IWidgetVtbl' ../../../../wine-git/dlls/oleaut32/tests/tmarshal.c:218: warning: no semicolon at end of struct or union ... make[2]: *** [tmarshal.cross.o] Fehler 1 make[2]: Leaving directory `/usr/src/wine/wine-mingw/dlls/oleaut32/tests' make[1]: *** [oleaut32/tests/__crosstest__] Fehler 2 make[1]: Leaving directory `/usr/src/wine/wine-mingw/dlls' make: *** [dlls/__crosstest__] Fehler 2 The problem is related to the fact that i'm doing out of tree builds. Therefore i have three directories: 1. wine-git : the source tree 2. wine-build : the normal build (unix) 3. wine-mingw : the cross compile build The missing tmarshal.h file is in wine-build/dlls/oleauth32/tests Bye Stefan

4 8

Patch to make X11DRV_GetAsyncKeyState work for TacOps
by Martin Cracauer 25 Jan '07

25 Jan '07

The appended patch against the CVS version fixes one issue for me. The game "TacOps" (a standalone 2D wargame, not to be mixed up with the Unreal mod "Tac Ops") uses home-grown scrollbars. They have autorepeat, that means holding the mouse button on the "down" or "up" icons will continue to scroll until you release the button. Without the appended patch Wine will never notice when you release the mouse button. That effectively means an application hang since you can never do anything else anymore, as the game continue to execute "down" autorepeat. To reproduce, download the demo at http://www.battlefront.com/products/tacops4/demo.html . Set up your units as per the instructions (place from floating window into the grey box). The scrollbars in question are under artillery support and under air support. Clicking on the up/down icons in the scrollbars will hang the application without the patch and will work with the patch. Please mail me if you want a better walkthrough. In case the patch attachment gets stripped by the list I put a copy of the patch here: http://www.cons.org/cracauer/wine-tacops-2.diff Martin -- %%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%% Martin Cracauer <cracauer(a)cons.org> http://www.cons.org/cracauer/ FreeBSD - where you want to go, today. http://www.freebsd.org/

2 2

Re: [kernel32][tests][locale] Add test for CompareStringA for non latin symbols
by Dmitry Timoshkov 25 Jan '07

25 Jan '07

"Anatoly Lyutin" <vostok(a)etersoft.ru> wrote: > --- dlls/kernel32/tests/locale.c 5 Jan 2007 19:37:02 -0000 1.8 > +++ dlls/kernel32/tests/locale.c 24 Jan 2007 14:15:14 -0000 > @@ -35,6 +35,9 @@ > #include "winerror.h" > #include "winnls.h" > > +#include "locale.h" > +#include "tables_CP1251.h" I'd suggest to test specific strings instead of auto-generated tables. Since microsoft apparently uses their own unicode tables that differ from unicode.org ones that's almost impossible to get the exactly same behaviour among Wine and Windows. > +static int compare_string2_non_latin(const void *e1, const void *e2) > +{ > + const char *s1 = (char *)e1; > + const char *s2 = (char *)e2; > + > + return CompareStringA(LOCALE_USER_DEFAULT,0,s1,1, s2,1) - 2; > +} You need to directly specify the locale id, otherwise the test won't pass on a system with different user default locale (like the Alexandre's one). -- Dmitry.

2 2

Debian Etch package
by Paavo Pokkinen 25 Jan '07

25 Jan '07

Hi, I would like to maintain latest Debian Etch(to-be-stable in about month) packages for wine. The download page says "If you can help provide up-to-date Debian packages, please contact Scott Ritchie", but I already contacted, maybe month ago. Didn't get any answer. The debs are located http://blitzkrieg.homelinux.org/~paveq/wine/ I got enough bandwith(10Mb) to host them myself. Comments? -- Paavo Pokkinen paveq2(a)gmail.com

3 2

Re: cabinet: Fix overrun of static array (Coverity)
by Alexandre Julliard 25 Jan '07

25 Jan '07

Andrew Talbot <Andrew.Talbot(a)talbotville.com> writes: > This patch is aimed at fixing Coverity CID-297. The existing code writes > 52 values to a 51-value array. The patch code only writes the first 51. > > Please let me know what is wrong with this patch. It may well be correct, but I think both the old and the new code are very confusing. Initializing this from a static constant would be a lot cleaner. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: [try 4] slist support (2/2) slist declarations and functions
by Mike McCormack 25 Jan '07

25 Jan '07

Damjan Jovanovic wrote: > diff -ur a/include/winbase.h b/include/winbase.h > --- a/include/winbase.h 2007-01-12 20:59:52.000000000 +0200 > +++ b/include/winbase.h 2007-01-24 20:42:35.000000000 +0200 I would recommend you at least split the modifications to winbase into a separate patch, as they are not dependent on your implementation. Mike

1 0

Re: [kernel32][tests][locale] Add test for CompareStringA for non latin symbols
by Mike McCormack 25 Jan '07

25 Jan '07

Anatoly Lyutin wrote: > Changelog: Add test for CompareStringA for non latin symbols. Hmm. > + if (0) test_sorting_non_latin(); Adding a test that won't run... > +/* If you want to get the source code of the program generating a file, > + * please write to me on vostok(a)etersoft.ru. > + * Automatically generated file; DO NOT EDIT!! > + */ without the source code to generate the test data... Seems like it's unlikely this patch will be accepted. What exactly are you trying to show? Mike

1 0

Re: winex11.drv: Copy the GL extensions string because it may be freed.
by Chris Robinson 25 Jan '07

25 Jan '07

On Wednesday 24 January 2007 21:51, Ken Thomases wrote: > + WineGLInfo.glExtensions = strdup((const char *) pglGetString(GL_EXTENSIONS)); Shouldn't this be free'd somewhere? What about the other strings?

2 1

Re: Tests for NtCreateMailslotFile
by Vitaliy Margolen 25 Jan '07

25 Jan '07

Jeff Latimer wrote: > This is the first of some tests for NtCreateMailslotFile. I have > included them in kernel32/tests as I thought it better that the Mailslot > tests be collocated. Why do you need to test NtCreateMailslotFile directly? Why can't you use CreateMailslot instead? Vitaliy.

2 1

Re: cmdlg32: update Russian translation
by Dmitry Timoshkov 25 Jan '07

25 Jan '07

"Vitaly Lipatov" <lav(a)etersoft.ru> wrote: > Changes: > Done Russian translation PD32_NO_DEVICES translation is missing a comma after 'Проверьте'. IDS_COLOR_MAROON translation has a spelling error. -- Dmitry.

1 0