October 2007 - Wine-devel - list.winehq.org

Re: oleaut32: function kind for dispatch interfaces should be FUNC_DISPATCH (with test, fixes bug #9057)
by Alexandre Julliard 10 Oct '07

10 Oct '07

"Mikolaj Zalewski" <mikolajz(a)google.com> writes: > +[uuid(8b05fe77-4a6c-4133-b9cd-8f81747af784)] > +library Test > +{ > + importlib("../../stdole2.tlb/std_ole_v2.tlb"); You shouldn't use an explicit path here. > +#define expect_eq(expr, value, type, format) { type _ret = (expr); ok((value) == _ret, #expr " expected " format " got " format "\n", value, _ret); } > +#define expect_int(expr, value) expect_eq(expr, (LONGLONG)value, LONGLONG, "%lld") > +#define expect_hex(expr, value) expect_eq(expr, (LONGLONG)value, LONGLONG, "0x%llx") Please don't use %ll formats, they aren't portable. -- Alexandre Julliard julliard(a)winehq.org

1 0

revamp categories
by Jan Zerebecki 10 Oct '07

10 Oct '07

1 0

Re: mshtml: Added support for installing Gecko from the local file. [fixed]
by Detlef Riekenberg 10 Oct '07

10 Oct '07

On Mi, 2007-10-10 at 14:44 +0200, Jacek Caban wrote: > + > + file_name = mshtml_alloc(size+sizeof(GECKO_FILE_NAME)); > + res = RegQueryValueExA(hkey, "GeckoCabDir", NULL, &type, > + res = RegQueryValueExA(hkey, "GetckoCabDir", NULL, &type, > (PBYTE)file_name, &size); An advantage with a string defined as const: No Typo -- By by ... Detlef

1 0

Re: [Bug 9962] wine ntfs-3g segfaults
by Kai Blin 10 Oct '07

10 Oct '07

On Wednesday 10 October 2007 11:34:55 wine-bugs(a)winehq.org wrote: Taking this to the mailing list, as it shouldn't be discussed on the bug. > Vitaliy: what functionality specifically do you need from ntfs-3g? Shared > writable mmap support indeed needs an extra kernel patch which is not in > mainline yet but we are not aware of any other widely needed feature. We're > developing ntfs-3g, so people can run application directly from NTFS using > wine. Szabolcs, the biggest reason why we don't tell people to run applications from an NTFS partition is not strictly a technical one but just the fact that people then try to run applications they installed under windows. This will fail for almost every application that depends on certain registry entries being created by the install process. I don't know what other features Vitaly was talking about. Perhaps you can elaborate on that here, Vitaly? Cheers, Kai -- Kai Blin WorldForge developer http://www.worldforge.org/ Wine developer http://wiki.winehq.org/KaiBlin Samba team member http://www.samba.org/samba/team/ -- Will code for cotton.

3 3

wine-sspi category for bugzilla.
by Kai Blin 10 Oct '07

10 Oct '07

Hi folks, I'd like to have a wine-sspi or wine-secur32 category for bugzilla. Cheers, Kai -- Kai Blin WorldForge developer http://www.worldforge.org/ Wine developer http://wiki.winehq.org/KaiBlin Samba team member http://www.samba.org/samba/team/ -- Will code for cotton.

3 3

Re: setupapi(1/16): Test SetupDiInstallClass
by Alexandre Julliard 10 Oct '07

10 Oct '07

"Juan Lang" <juan.lang(a)gmail.com> writes: > From e3c4fd59e419c74431a7062228d023a9513a5af1 Mon Sep 17 00:00:00 2001 > From: Juan Lang <juan.lang(a)gmail.com> > Date: Mon, 8 Oct 2007 17:06:41 -0700 > Subject: [PATCH] Test SetupDiInstallClass > > --- > dlls/setupapi/tests/devinst.c | 36 ++++++++++++++++++++++++++++++++++++ > 1 files changed, 36 insertions(+), 0 deletions(-) This fails here: ../../../tools/runtest -q -P wine -M setupapi.dll -T ../../.. -p setupapi_test.exe.so devinst.c && touch devinst.ok devinst.c:173: Test failed: SetupDiInstallClassA failed: 00000002 make[2]: *** [devinst.ok] Error 1 -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: kernel32/locale.c: partially implement GetUserGeoID()
by Alexandre Julliard 10 Oct '07

10 Oct '07

EA Durbin <ead1234(a)hotmail.com> writes: > + if(!(hkey = create_registry_key())) return ret; > + hSubkey = NLS_RegOpenSubKey( hkey, geoW ); > + count = sizeof(bufferW); > + > + switch( GeoClass ){ > + case GEOCLASS_NATION: > + NtQueryValueKey(hSubkey, &keyW, KeyValuePartialInformation, (LPBYTE)bufferW, count, &count); > + retID = strtolW( (LPCWSTR)info->Data, &end, 10 ); You need some error checking in there, the key and/or value may not exist. > + case GEOCLASS_REGION: > + /* GetUserGeoID returns a GEOID from the table listed here > + http://msdn2.microsoft.com/en-us/library/ms776390.aspx > + Default windows behavior is to post this code to the Geo/Nation Key during SetUserGeoID(), not sure how the region request is handled */ Please don't put URLs in the code, particularly not from MSDN since they change all the time. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: d3dx8: patch 2; Implement D3DXVec2LengthSq
by Alexandre Julliard 10 Oct '07

10 Oct '07

David.Adam(a)math.cnrs.fr writes: > diff --git a/dlls/d3dx8/d3dx8.spec b/dlls/d3dx8/d3dx8.spec > index 3293614..325d0a5 100644 > --- a/dlls/d3dx8/d3dx8.spec > +++ b/dlls/d3dx8/d3dx8.spec > @@ -1,4 +1,5 @@ > @ stub D3DXVec2Normalize > +@ stdcall D3DXVec2LengthSq(ptr) The function is not stdcall, and AFAICS it's supposed to be inline, not exported by the dll. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: mshtml #3: Added support for installing Gecko from the local file.
by Alexandre Julliard 10 Oct '07

10 Oct '07

Jacek Caban <jacek(a)codeweavers.com> writes: > WINE_DEFAULT_DEBUG_CHANNEL(mshtml); > > +#define GECKO_FILE_NAME "wine_gecko-" GECKO_VERSION ".cab" > +#define DEFAULT_CAB_FILE_NAME "/usr/share/wine/gecko/" GECKO_FILE_NAME You need to use wine_get_data_dir() instead of hardcoding the path. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: ftp.c: skip tests if we can't connect to ftp.winehq.org
by Alexandre Julliard 10 Oct '07

10 Oct '07

Dimi Paun <dimi(a)lattica.com> writes: > diff --git a/dlls/wininet/tests/ftp.c b/dlls/wininet/tests/ftp.c This doesn't work for me: ../../../tools/runtest -q -P wine -M wininet.dll -T ../../.. -p wininet_test.exe.so ftp.c && touch ftp.ok ftp.c:790: Test failed: InternetConnect failed : 12015 wine: Unhandled page fault on read access to 0x0067006e at address 0x60568d4e (thread 0009), starting debugger... WineDbg starting on pid 0008 Unhandled exception: page fault on read access to 0x0067006e in 32-bit code (0x60568d4e). Register dump: CS:0023 SS:002b DS:002b ES:002b FS:0063 GS:006b EIP:60568d4e ESP:0033fd30 EBP:0033fd68 EFLAGS:00010206( - 00 - RIP1) EAX:0067006e EBX:60580718 ECX:60586ca0 EDX:60586ca4 ESI:00670046 EDI:00126320 Stack dump: 0x0033fd30: 001100b8 60580718 0033fd68 60568190 0x0033fd40: 60586ca0 00000000 0033fd58 60586ca0 0x0033fd50: 00125558 00000000 00125528 60580718 0x0033fd60: 00000001 6052d1d2 0033fd98 6056a8df 0x0033fd70: 00000001 00000000 00000000 00000000 0x0033fd80: 6052d201 6052d1d2 00000000 6053815c Backtrace: =>1 0x60568d4e WININET_FreeHandle+0xbe(hinternet=0x1) [/home/julliard/wine/wine/dlls/wininet/internet.c:222] in wininet (0x0033fd68) 2 0x6056a8df InternetCloseHandle+0x3f(hInternet=<register ESI not in topmost frame>) [/home/julliard/wine/wine/dlls/wininet/internet.c:1021] in wininet (0x0033fd98) 3 0x60514dea func_ftp+0x19fa() [/home/julliard/wine/wine/dlls/wininet/tests/ftp.c:860] in wininet_test (0x0033fe58) 4 0x6052c938 run_test+0x128(name=0x1103e8) [/home/julliard/wine/wine/dlls/wininet/tests/../../../include/wine/test.h:389] in wininet_test (0x0033fea8) 5 0x6052cfcd main+0x14d(argc=<register ECX not in topmost frame>, argv=<register ECX not in topmost frame>) [/home/julliard/wine/wine/dlls/wininet/tests/../../../include/wine/test.h:437] in wininet_test (0x0033fed8) 6 0x6052d09b __wine_spec_exe_entry+0x5b(peb=0x7ffdf000) [/home/julliard/wine/wine/dlls/winecrt0/exe_entry.c:36] in wininet_test (0x0033ff08) 7 0x7b8746ce start_process+0xee(arg=0x0) [/home/julliard/wine/wine/dlls/kernel32/process.c:839] in kernel32 (0x0033ffe8) 8 0x600289a7 wine_switch_to_stack+0x17() in libwine.so.1 (0x00000000) 0x60568d4e WININET_FreeHandle+0xbe [/home/julliard/wine/wine/dlls/wininet/internet.c:222] in wininet: movl 0x28(%esi),%edx 222 LIST_FOR_EACH_ENTRY_SAFE( child, next, &info->children, WININETHANDLEHEADER, entry ) Wine-dbg> -- Alexandre Julliard julliard(a)winehq.org

1 0