October 2007 - Wine-devel - list.winehq.org

Translations
by Daniel Nylander 14 Oct '07

14 Oct '07

I would like to contribute to the Wine project by submitting Swedish translations. I would really like to translate the graphical tools (such as winecfg) but as I can see it, it's not possible at the moment. Have you thought about implementing some sort of i18n/l10n framework? Regards, Daniel Nylander Stockholm, Sweden

2 4

Re: libs/wine/mmap.c: conditionally provide reserve_area()
by Vitaliy Margolen 14 Oct '07

14 Oct '07

Gerald Pfeifer wrote: > Noticed on FreeBSD; patch tested on FreeBSD 5.4 as well as SUSE Linux > 10.0. > > Gerald > > ChangeLog: > Only provide reserve_area() when we actually use it. > > Index: mmap.c > =================================================================== > RCS file: /home/wine/wine/libs/wine/mmap.c,v > retrieving revision 1.20 > diff -u -3 -p -r1.20 mmap.c > --- mmap.c 26 Jan 2007 13:48:42 -0000 1.20 > +++ mmap.c 14 Oct 2007 11:09:28 -0000 In this and all of your patches, please diff from the top of the tree. The above line should say "+++libs/wine/mmap.c". And it would be even better if you can use GIT instead of cvs. Vitaliy.

2 1

Re: USER32: fix EM_SETLIMITTEXT with zeroed args (with tests)
by Detlef Riekenberg 14 Oct '07

14 Oct '07

On Fr, 2007-10-12 at 19:42 -0500, a_villacis(a)palosanto.com wrote: You must use your real name to get a patch accepted. > + /* Maximum limits set by EM_SETLIMITTEXT vary by OS version */ > + osVersion = GetVersion(); > + if (osVersion < 0x80000000) { > + /* WinNT, Win2K, WinXP */ > + limitSingleLine = 2147483646UL; > + limitMultiLine = 4294967295UL; > + } else { > + /* Win9x, WinME */ > + limitSingleLine = 32766; > + limitMultiLine = 65535; > + } The tests should not depend on the OS-Version. Please handle both possible results in the ok() > + /* Test default limit for single-line control */ > + trace("EDIT: buffer limit for single-line\n"); > + hwEdit = create_editcontrol(ES_AUTOHSCROLL | ES_AUTOVSCROLL, 0); > + r = SendMessage(hwEdit, EM_GETLIMITTEXT, 0, 0); > + ok(r == 30000, "Incorrect default text limit, expected 30000 got > %u\n", r); > + SendMessage(hwEdit, EM_SETLIMITTEXT, 0, 0); > + r = SendMessage(hwEdit, EM_GETLIMITTEXT, 0, 0); /* Win9x+ME: 32766; WinNT: 2147483646UL */ ok( (r == 32766) || (r == 2147483646UL), "got limit %u (expected 32766 or 2147483646)\n", r); > + ok(r == limitSingleLine, "Incorrect default text limit, expected > %u got %u\n", limitSingleLine, r); Your looks like a copy&paste error ("default text limit" is wrong here). Change the multiline-test the same way. To allow an easy review, you can split your patch: one patch for the implementation and a second patch for the test. Thanks for helping wine -- By by ... Detlef

1 0

Re: [PATCH] wininet: NULL terminate url string passed to InternetCrackUrlW from InternetCrackUrlA.txt (try 3)
by Francois Gouget 14 Oct '07

14 Oct '07

On Sat, 13 Oct 2007, Nigel Liang wrote: > Hi, > > InternectCrackUrlW calls strchrW which assumes a NULL-terminated string. Will > crash without NULL termination if you upload/download for long period of time. The MSDN has this to say about InternetCrackUrlW(): dwUrlLength Size of the lpszUrl string, in TCHARs, or zero if lpszUrl is an ASCIIZ string. So if InternetCrackUrlW() assumes that lpwszUrl is zero-terminated then it is buggy. So the fix belong in InternetCrackUrlW(), not in InternetCrackUrlA(). -- Francois Gouget <fgouget(a)free.fr> http://fgouget.free.fr/ It really galls me that most of the computer power in the world is wasted on screen savers. Chris Caldwell from the GIMPS project http://www.mersenne.org/prime.htm

1 0

Wine crashes while trying to use Lexmark Network Scanback utility
by King InuYasha 14 Oct '07

14 Oct '07

Ehh, well, I was trying to use the Lexmark Scanback Utility to operate my Lexmark OptraImage 322 and it crashed after clicking the button to setup a new profile.... Installed original MFC42.DLL in the Scanback program folder... Crash log: [InuTaisho(a)PIIMMX-GTWE4200 ScanBack]$ wine scanwiz.exe wine: Call from 0x40ee68 to unimplemented function MFC42.DLL.6905, aborting wine: Unimplemented function MFC42.DLL.6905 called at address 0x40ee68 (thread 0038), starting debugger... Unhandled exception: unimplemented function MFC42.DLL.6905 called in 32-bit code (0x602e4d4c). Register dump: CS:0073 SS:007b DS:007b ES:007b FS:0033 GS:003b EIP:602e4d4c ESP:0034dbd4 EBP:0034dc38 EFLAGS:00000206( - 00 - -IP1) EAX:00001af9 EBX:6032fa78 ECX:0034e938 EDX:00030068 ESI:0034dbe0 EDI:0003006c Stack dump: 0x0034dbd4: 00000038 00030068 0100101b 80000100 0x0034dbe4: 00000001 00000000 0040ee68 00000002 0x0034dbf4: 0041cca6 00001af9 0034dc3c 6062e98e 0x0034dc04: 5f422d22 00030068 00000000 00000038 0x0034dc14: 00030068 00001036 00000000 00000020 0x0034dc24: 00000000 00000000 00000000 0034e8d8 Backtrace: =>1 0x602e4d4c in ntdll (+0x24d4c) (0x0034dc38) 2 0x0040ee68 in scanwiz (+0xee68) (0x0034e938) 3 0x00000001 (0x00419bc8) 4 0x0040fed0 in scanwiz (+0xfed0) (0x0041524c) 5 0x25ff0041 (0x837c25ff) 6 0x00000000 (0x00000000) 0x602e4d4c: subl $4,%esp Modules: Module Address Debug info Name (67 modules) PE 400000- 420000 Export scanwiz PE 10000000-10035000 Deferred scanwizg ELF 41d2d000-41d4a000 Deferred ld-linux.so.2 ELF 41d4c000-41d60000 Deferred libresolv.so.2 ELF 426fe000-42852000 Deferred libc.so.6 ELF 42854000-4287d000 Deferred libm.so.6 ELF 4287f000-42884000 Deferred libdl.so.2 ELF 4289b000-428b3000 Deferred libpthread.so.0 ELF 428b5000-428b8000 Deferred libxau.so.6 ELF 428ba000-428c0000 Deferred libxdmcp.so.6 ELF 428c2000-429c4000 Deferred libx11.so.6 ELF 429c6000-429d6000 Deferred libxext.so.6 ELF 429d8000-42a62000 Deferred libfreetype.so.6 ELF 42a64000-42a85000 Deferred libexpat.so.0 ELF 42aaf000-42ade000 Deferred libfontconfig.so.1 ELF 42ae0000-42ae9000 Deferred libxrender.so.1 ELF 42af5000-42aff000 Deferred libxcursor.so.1 ELF 42b01000-42b08000 Deferred libxrandr.so.2 ELF 42b0a000-42b0d000 Deferred libxinerama.so.1 ELF 42b0f000-42b14000 Deferred libxfixes.so.3 ELF 42bc5000-42bce000 Deferred libsm.so.6 ELF 42bd0000-42bea000 Deferred libice.so.6 ELF 4347a000-43485000 Deferred libdrm.so.2 ELF 43487000-434f7000 Deferred libgl.so.1 ELF 43fcb000-43fd0000 Deferred libxxf86vm.so.1 PE 5f400000-5f4ed000 Deferred mfc42 ELF 6001d000-60132000 Deferred libwine.so.1 ELF 602a3000-6034b000 Export ntdll<elf> \-PE 602c0000-6034b000 \ ntdll ELF 60374000-60380000 Deferred libnss_files.so.2 ELF 60380000-604b5000 Deferred kernel32<elf> \-PE 603a0000-604b5000 \ kernel32 ELF 604b5000-604cf000 Deferred version<elf> \-PE 604c0000-604cf000 \ version ELF 604cf000-604e3000 Deferred lz32<elf> \-PE 604e0000-604e3000 \ lz32 ELF 604e3000-6054f000 Deferred msvcrt<elf> \-PE 604f0000-6054f000 \ msvcrt ELF 6054f000-6059c000 Deferred advapi32<elf> \-PE 60560000-6059c000 \ advapi32 ELF 6059c000-606ea000 Deferred user32<elf> \-PE 605c0000-606ea000 \ user32 ELF 606ea000-607f6000 Deferred shell32<elf> \-PE 60700000-607f6000 \ shell32 ELF 607f6000-60853000 Deferred shlwapi<elf> \-PE 60800000-60853000 \ shlwapi ELF 60853000-6091a000 Deferred comctl32<elf> \-PE 60860000-6091a000 \ comctl32 ELF 6091a000-60978000 Deferred rpcrt4<elf> \-PE 60930000-60978000 \ rpcrt4 ELF 60978000-60997000 Deferred iphlpapi<elf> \-PE 60980000-60997000 \ iphlpapi ELF 609ab000-609d8000 Deferred ws2_32<elf> \-PE 609b0000-609d8000 \ ws2_32 ELF 60a28000-60abd000 Deferred winex11<elf> \-PE 60a40000-60abd000 \ winex11 ELF 60c8e000-60cac000 Deferred imm32<elf> \-PE 60ca0000-60cac000 \ imm32 ELF 60cbb000-60cef000 Deferred uxtheme<elf> \-PE 60cc0000-60cef000 \ uxtheme ELF 627d4000-62878000 Deferred gdi32<elf> \-PE 627f0000-62878000 \ gdi32 ELF 63167000-63213000 Deferred ole32<elf> \-PE 63180000-63213000 \ ole32 ELF 6875e000-68778000 Deferred wsock32<elf> \-PE 68760000-68778000 \ wsock32 ELF 7bf00000-7bf03000 Deferred <wine-loader> Threads: process tid prio (all id:s are in hex) 00000037 (D) C:\Program Files\Lexmark\ScanBack\scanwiz.exe 00000038 0 <== 00000013 00000015 0 00000014 0 0000000f 00000016 0 00000010 0 0000000a 0000000c 0 0000000b 0 wine: Call from 0x40ee68 to unimplemented function MFC42.DLL.6905, aborting wine: Call from 0x40ee68 to unimplemented function MFC42.DLL.6905, aborting

3 3

Re: RICHED20: EM_SETTEXTEX must support RTF strings too
by Dmitry Timoshkov 14 Oct '07

14 Oct '07

<a_villacis(a)palosanto.com> wrote: > Changelog: > * EM_SETTEXTEX should also support RTF strings, just like WM_SETTEXT It would be helpful to have a test case for this, as well as a unicode version of WM_SETTEXT/EM_SETTEXTEX. -- Dmitry.

1 0

Support GCOV for Wine 1.0?
by Detlef Riekenberg 13 Oct '07

13 Oct '07

Hi. A while ago (2004), there was some work about wine with gcov, with the focus on "Picassa 2": ( http://www.cs.hmc.edu/clinic/projects/2004/google/ ) Final Report: ( http://www.cs.hmc.edu/clinic/projects/2004/google/final_report/main.pdf ) It would be nice, when we can support gcov in current Wine "out of the box". That would help us a lot, when we write more tests for the suggested Wine 1.0 Applications. GCOV: http://gcc.gnu.org/onlinedocs/gcc/Gcov.html -- By by ... Detlef

7 15

WineHQ for Wine 1.0
by Alex Waite 13 Oct '07

13 Oct '07

Awhile ago I sent a few patches in to cleanup some HTML and CSS on WineHQ. I didn't continue with writing more patches since it seemed like we didn't have a clear idea of what direction we wanted to pursue. I am more than happy to help with a rewrite or update of the site, but as long as we have an plan of what we want to accomplish and how to go about it. With the release of Wine 1.0 coming... sometime... in the future, it would make sense if we had an updated website to accompany that release. From my point of view, the following are some big problems with the current site: * Not pretty: while not awful, there are better color schemes and layouts in the world. We can also look at some usability improvements. If people are partial to it, we can still use the winish-red color, but I think we can use it in a more attractive way than we do now. * Table-hell: This is where I tout the joys of <div>'s and CSS. Tables are a pain to deal with and bloat the code quite a bit. Not to mention that they make pages pretty inaccessible. * Accessibility: Tables are the big culprit here, but there's also simple things like making the code valid. There's also some fairly straightforward ways of writing code which help a lot (precede lists with headers, nest headers correctly, etc). While accessibility doesn't have to be perfect, I think it promotes well written code and makes pages more accessible to more people. * Valid code: This is a principal to me. I think if code is to be written, it should be written correctly. Wine is known for not accepting hacks or improper fixes; I think our website should reflect that, especially since the spec is not hard to conform to. Let me know if you are interested in help. I hope everyone is having fun at WineConf. ---Alex

2 1

Re: Call of Dutty 4 works!!
by Mirek Slugeň 13 Oct '07

13 Oct '07

1 0

make test drill
by Jeremy White 13 Oct '07

13 Oct '07

So, in a radical break from tradition, we're trying to accomplish something useful at Wineconf. Specifically, we're making 'make test' work for everyone, not just Alexandre. Maarten Lankhorst is maintaining a tree of all of our test related patches. So, for those that want to play, the thing to do is to git fetch git://repo.or.cz/wine/testsucceed.git master:testsucceed git rebase testsucceed Then you can do a make test (with a clean .wine directory) and share your results. It's useful to use Dan's filter: egrep '__test|make.*ok|Backtrace' <your-log-file-here> Up through the end of day tomorrow, you can send me the results of that egrep and I'll tally and triage. If you have a patch, send it in, and CC Maarten so he can update it. The goal is to have the number of failures as close to 0 as possible, and for the non 0 cases, to at least understand each failure. Cheers, Jeremy

8 14