November 2007 - Wine-devel - list.winehq.org

Re: credui: Show a balloon tip in the credential dialog if CREDUI_FLAGS_INCORRECT_PASSWORD was specified.
by Juan Lang 19 Nov '07

19 Nov '07

Hi Rob, + IDS_INCORRECTPASSWORDTITLE "Logon unsucessful" The typo's your own work too, eh? --Juan

2 1

Re: d3dx8 [patch 1/10] Implement D3DXPlaneFromPointNormal
by Stefan Dösinger 19 Nov '07

19 Nov '07

Hi, It's not really about this patch, but I am curious what the plans about sharing code between the various d3dx?_* libraries are. I think a big amount of functionality can be shared among d3dx8.dll, d3dx9_*.dll, and propably d3dxof.dll and d3drm.dll. I think this was discussed in the past, but I am not sure if there was any outcome. The solution chosen for d3d was to create an internal library wined3d.dll, and have the other libs call it. I guess something similar should be done for d3dx as well. For non COM interfaces this is pretty easy anyway. We can rename d3dx8 to wined3dx at any time and just load the functions into a new d3d8 thunk using the .spec file, without any C code. So I guess we can leave things as they currently are and move over to a shared lib once non-math functions are implemented, or someone starts d3dx9_*.dll Functions like D3DXCreateTextureFromFileA seem to be a bit harder. Since they take an IDirect3DDevice8 * interface pointer d3dx9 cannot use them as is. Making a shared implementation is also not quite possible because it would need a wined3ddevice then, but only d3d8.dll knows how to get a wined3ddevice from a d3ddevice8. Also, d3dx* would depend on wined3d then, which is propably not what we want. David, do you have any plans regarding that? As a sidenote, I really like your patches! The patches are small but still every patch makes sense for itself, and tests in every patch :-) I will write a HLSL compiler at some point, and propably a shader assembler. This will be needed for a complete d3dx8 and d3dx9 implementation, as well as d3d10. I am not yet sure where to put it, but it could be a standalone lib in libs/, to allow using the compiler at build time, or just include it in wined3dx, if we decide to add such a library.

2 2

Re: Unimplemented function KERNEL32.dll.FindFirstVolumeW
by devzero＠web.de 19 Nov '07

19 Nov '07

Hello Marcus, hello Hans, thanks very much - that was a quick fix ! :) I tried the latest snapshot and now was going able start windirstat. great! i can tell , that it basically works and i`m able to scan a disk. despite some minor quirks like crash of the app when i click trough the cushion treemap, there seems some major issue. at least some very weird major issue: when scannnig trough drive z:\ , my notebook reboots ! This happens reproduceably when windirstat is at ~100.000 entries i had absolutely no stability issues with my notebook so far, running it for some days now and using it very very intensive (much i/o, firefox/open with many many windows containing flash etc) i did an test afterwards to see if this is caused by some corrupt files or whatever, but some find / -type f -exec stat {} \; >/dev/null ls -laR / >/dev/null completes without an error. there are around 200.000 files on my notebook. wasn`t wine a userspace application with no kernel related stuff ? so it`s weird, that windirstat is crashing my notebook, isn`t it ? maybe somebody is able to reproduce ? regards roland > -----Ursprüngliche Nachricht----- > Von: "Marcus Meissner" <marcus(a)jet.franken.de> > Gesendet: 19.11.07 07:48:04 > An: devzero(a)web.de > CC: Hans Leidekker <hans(a)it.vu.nl>, wine-devel(a)winehq.org > Betreff: Re: Unimplemented function KERNEL32.dll.FindFirstVolumeW > > On Sun, Nov 18, 2007 at 10:14:17PM +0100, devzero(a)web.de wrote: > > Hello Hans, > > > > thanks for that info. > > > > latest version i tried here is > > > > wine-0.9.49-11.3.i586.rpm > > wine-snapshot-0.9.49.20071118-11.1.i586.rpm > > > > but same error. > > maybe that`s not recent enough ? > > > > do i need to enable special option or add some files ? > > > > sorry, i`m quite new to wine and maybe i should read deeper into the docs instead of posting :) > > It is not yet committed to the mainline repository. Once it > is it will show up in "wine-snapshot" of the openSUSE buildservice > of this day. > > Ciao, Marcus > _______________________________________________________________________ Jetzt neu! Schützen Sie Ihren PC mit McAfee und WEB.DE. 3 Monate kostenlos testen. http://www.pc-sicherheit.web.de/startseite/?mc=022220

2 1

Re: svchost: Added base implementation of svchost (1/27)
by Juan Lang 19 Nov '07

19 Nov '07

Hi Roy, +#define WIN32_LEAN_AND_MEAN That's not needed if you're not including windows.h (which you're not.) + if (unicode[i] > 129) You have an off-by-two error here. 7-bit clean means if (unicode[i] > 127). You can also use something like if (unicode[i] & 0x80). Stylistic note, use or ignore at your option: + HeapFree(GetProcessHeap(), 0, service_param_key); + return FALSE; (snip) + HeapFree(GetProcessHeap(), 0, service_param_key); + RegCloseKey(service_hkey); + return FALSE; (snip) + HeapFree(GetProcessHeap(), 0, service_param_key); + HeapFree(GetProcessHeap(), 0, dll_name_short); + RegCloseKey(service_hkey); + return FALSE; (snip) Some judicious use of goto could reduce code for all your error paths. Remember that HeapFree of a NULL pointer is allowed. + dll_service_main = GetRegValue(service_hkey, service_main); + RegCloseKey(service_hkey); + if (!dll_service_main) + { + service_main_a = UnicodeToAscii(service_main); + } + else + { + service_main_a = UnicodeToAscii(dll_service_main); + HeapFree(GetProcessHeap(), 0, dll_service_main); Why not just query dll_service_main and service_main from the registry as an ASCII value to begin with? --Juan

2 2

imagelist test exception?
by Dan Kegel 19 Nov '07

19 Nov '07

comctl32/tests/imagelist.c seems to throw an exception during GetDIBits(), but for some reason, the test continues and succeeds (except in Valgrind, which is why I noticed). Do other folks also see a seh exception in the +seh log on this test? I narrowed the test case down a bit (see patch). Can anyone clue me in on what's going on here?

3 4

Re: Unimplemented function KERNEL32.dll.FindFirstVolumeW
by devzero＠web.de 19 Nov '07

19 Nov '07

Hello Hans, thanks for that info. latest version i tried here is wine-0.9.49-11.3.i586.rpm wine-snapshot-0.9.49.20071118-11.1.i586.rpm but same error. maybe that`s not recent enough ? do i need to enable special option or add some files ? sorry, i`m quite new to wine and maybe i should read deeper into the docs instead of posting :) regards roland > -----Ursprüngliche Nachricht----- > Von: "Hans Leidekker" <hans(a)it.vu.nl> > Gesendet: 18.11.07 21:45:34 > An: wine-devel(a)winehq.org > Betreff: Re: Unimplemented function KERNEL32.dll.FindFirstVolumeW > > On Sunday 18 November 2007 20:38:34 devzero(a)web.de wrote: > > > i`m new to wine. > > I tried windirstat under wine-0.9.44-15 and crossover-office 6.2.0-1 under opensuse10.3 - but it doesn`t work. > > > > i`m getting > > wine: Call from 0x7b8447d0 to unimplemented function KERNEL32.dll.FindFirstVolumeW, aborting > > wine: Unimplemented function KERNEL32.dll.FindFirstVolumeW called at address 0x7b8447d0 (thread 0019), starting debugger... > > Unhandled exception: unimplemented function KERNEL32.dll.FindFirstVolumeW called in 32-bit code (0x7b844852). > > I submitted a stub implementation for this function which makes > windirstat start up fine here. > > -Hans > ______________________________________________________________________________ Jetzt neu! Im riesigen WEB.DE Club SmartDrive Dateien freigeben und mit Freunden teilen! http://www.freemail.web.de/club/smartdrive_ttc.htm/?mc=021134

3 2

Re: msi: Install Entire Feature
by James Hawkins 19 Nov '07

19 Nov '07

On 11/18/07, Daniel Sim <daniel.ssq89(a)gmail.com> wrote: > "Install entire feature" enabled and implemented. > What is this patch for? Is this to fix a bug? + /* FIXME: Why 0x1000? */ Don't add random comments about things you don't understand in the code. +msi_seltree_install_entire_feature(HWND hwnd, HTREEITEM hItem, MSIPACKAGE *package, UINT r) { Please use the style of the rest of the file (bracket below function). + for ( + child = TreeView_GetChild (hwnd, hItem); + child; + child = TreeView_GetNextSibling (hwnd, child) ) Style changed again...and that's just ugly. + msi_seltree_install_entire_feature (hwnd, child, package, r); Why are you doing this recursively? -- James Hawkins

1 0

Unimplemented function KERNEL32.dll.FindFirstVolumeW
by devzero＠web.de 18 Nov '07

18 Nov '07

Hello ! i`m new to wine. I tried windirstat under wine-0.9.44-15 and crossover-office 6.2.0-1 under opensuse10.3 - but it doesn`t work. i`m getting wine: Call from 0x7b8447d0 to unimplemented function KERNEL32.dll.FindFirstVolumeW, aborting wine: Unimplemented function KERNEL32.dll.FindFirstVolumeW called at address 0x7b8447d0 (thread 0019), starting debugger... Unhandled exception: unimplemented function KERNEL32.dll.FindFirstVolumeW called in 32-bit code (0x7b844852). does somebody know when this function will be available ? is this a rarely used function? http://msdn2.microsoft.com/en-us/library/aa364425.aspx tells "Retrieves the name of a volume on a computer. FindFirstVolume is used to begin scanning the volumes of a computer." regards roland _____________________________________________________________________ Der WEB.DE SmartSurfer hilft bis zu 70% Ihrer Onlinekosten zu sparen! http://smartsurfer.web.de/?mc=100071&distributionid=000000000066

2 1

re: advapi32/service.c -- remove untriggerable check
by Dan Kegel 18 Nov '07

18 Nov '07

Uwe wrote: >Gerald Pfeifer writes: > >> n is of type DWORD which is unsigned, so n < 0 always will >> evaluate to false. > > Is dropping the check the right answer? Shouldn't the check test for high > values like > 0xff00 and report a possible problem? Indeed. IMHO we don't need patches like this, and Gerald is not thinking hard enough. Simplistic just-remove-the-warning patches are a Bad Thing, and we Don't Want To Encourage Them. Please stop. - Dan -- Wine for Windows ISVs: http://kegel.com/wine/isv

2 1

Re: gdi32: Add stub for RemoveFontMemResourceEx
by Dmitry Timoshkov 18 Nov '07

18 Nov '07

"Klaus Layer" <klaus.layer(a)gmx.de> wrote: > Nokia PC Suite installation crashes due to missing function > RemoveFontMemResourceEx. This patch adds function RemoveFontMemResourceEx > which just calls WineEngRemoveFontMemResourceEx as stub You forgot to create WineEngRemoveFontMemResourceEx implementation for a case when HAVE_FREETYPE is not defined. -- Dmitry.

2 1