November 2007 - Wine-devel - list.winehq.org

Re: wineprefixcreate: get xdg-user-dirs environment variables [1/2]
by Alexandre Julliard 22 Nov '07

22 Nov '07

"Lei Zhang" <thestig(a)google.com> writes: > We need to get the "well known" XDG user directories so we can symlink to them. This should be done inside shell32, not in wineprefixcreate. -- Alexandre Julliard julliard(a)winehq.org

3 2

Re: dlls/winedos/int21.c -- type adjustments
by Dmitry Timoshkov 22 Nov '07

22 Nov '07

"Gerald Pfeifer" <gerald(a)pfeifer.com> wrote: > ChangeLog: > Use unsigned long instead of long for return values of SetFilePointer. It wouldn't take more than 30 additional seconds to look up the SetFilePointer prototype in include/ and use real type instead. -- Dmitry.

2 1

Disregard earlier ntdll/tests/env.c patches
by Zac Brown 22 Nov '07

22 Nov '07

Hi, Please disregard any patches prior to the latest patch. It seems my mail server has been a little messed up. The only one to consider is the latest one that the wine-patches list has received. Thank you, Zac Brown -- Zac Brown (817-266-6867) zac(a)zacbrown.org http://zacbrown.org

1 0

Re: d3dx8 [patch 7/7] Implement D3DXMatrixTransformation
by Ivan Gyurdiev 22 Nov '07

22 Nov '07

Any chance the formatting can be improved to include whitespace between blocks and proper indentation?

2 1

re: ntdll: fix uninitialized buffers, found via valgrind
by Dan Kegel 22 Nov '07

22 Nov '07

James wrote: > Why did you move the variable declaration? Because the variable is only used inside the loop. Moving the declaration to the top of the loop is the right scoping. - Dan

1 0

Re: Use GCC's -Wtype-limits
by Alexandre Julliard 22 Nov '07

22 Nov '07

Gerald Pfeifer <gerald(a)pfeifer.com> writes: > If applied, I will commit to address, directly and by engaging others, > the occurrences of such warnings in Wine. I'm not opposed to applying it, but you have to fix the warnings first, as far as possible the default build should not trigger any warnings. -- Alexandre Julliard julliard(a)winehq.org

2 1

Re: ntdll: fix uninitialized buffers, found via valgrind
by James Hawkins 22 Nov '07

22 Nov '07

On Nov 21, 2007 6:08 PM, Zac Brown <zac(a)zacbrown.org> wrote: > Hi, > > Fixes valgrind error: > http://kegel.com/wine/valgrind/20071121/vg-ntdll_env.txt > > Changelog: > * Initialize buffers used in test using memset > > -- > Zac Brown <zac AT zacbrown DOT org> > > > dlls/ntdll/tests/env.c | 7 +++++-- > 1 files changed, 5 insertions(+), 2 deletions(-) > > diff --git a/dlls/ntdll/tests/env.c b/dlls/ntdll/tests/env.c > index d822946..90a3bf1 100644 > --- a/dlls/ntdll/tests/env.c > +++ b/dlls/ntdll/tests/env.c > @@ -80,8 +80,7 @@ static void testQuery(void) > {NULL, 0, 0, NULL} > }; > > - WCHAR bn[257]; > - WCHAR bv[257]; > + > UNICODE_STRING name; > UNICODE_STRING value; > const struct test* test; > @@ -89,6 +88,10 @@ static void testQuery(void) > > for (test = tests; test->var; test++) > { > + WCHAR bn[257]; > + WCHAR bv[257]; > + memset(bn, '\0', 257 * sizeof(WCHAR)); > + memset(bv, '\0', 257 * sizeof(WCHAR)); > name.Length = strlen(test->var) * 2; > name.MaximumLength = name.Length + 2; > name.Buffer = bn; > Why did you move the variable declaration? Also, please don't use magic constants; sizeof(bn) *sizeof(WCHAR) is what you want. -- James Hawkins

2 2

Re: WineD3D: Implement detection of ATI cards with Mesa DRI drivers [try 3]
by Stefan Dösinger 22 Nov '07

22 Nov '07

Hi, > --- a/ChangeLog > +++ b/ChangeLog > @@ -1,3 +1,8 @@ > +2007-11-22 Roman Mamedov <roman(a)rm.pp.ru> > + > + * dlls/wined3d/directx.c: > + wined3d: Implement detection of ATI cards with Mesa DRI drivers. > + Sorry, I missed this in the first patch: You don't have to update the changelog file in the patches. The ChangeLog is autogenerated from the git commit logs(ie, the subject in the patch file). I am not sure if Alexandre's scripts filter that out or if he asks to resend the patch.

1 0

Re: WineD3D: Implement detection of ATI cards with Mesa DRI drivers
by Stefan Dösinger 21 Nov '07

21 Nov '07

Am Donnerstag, 22. November 2007 00:15:30 schrieb Roman Mamedov: > Hello. > > Presently, if an ATI card uses open-source DRI drivers from the Mesa > project ( http://dri.freedesktop.org/wiki/ATI ), Wine will report it to > Windows applications as being some generic nVIDIA model, based on D3D > capabilities of the card. The patch looks good to me content wise, but please attach it as an attachment to the mail instead of copypasting it into the mail. Also I am not sure if we should report R200 cards. They have pixel shader 1.x support on Windows, but Wine cannot implement this because the cards are too limited to support GL_ARB_fragment_program(~ ps 2.0), but there is no common extension that maps 1.x pixel shaders, only an ATI specific one. Any volunteers for a GL_ATI_fragment_shader shader backend :-) ? On the other hand, those cards support a few features that older cards did not have, like vertex shaders or volume textures. Also note that Alexandre is on holiday this week, so the patch won't be committed before next week.

1 0

Re: WineD3D: Implement detection of ATI cards with Mesa DRI drivers
by James Hawkins 21 Nov '07

21 Nov '07

On Nov 21, 2007 5:15 PM, Roman Mamedov <roman(a)rm.pp.ru> wrote: > Hello. > > Presently, if an ATI card uses open-source DRI drivers from the Mesa > project ( http://dri.freedesktop.org/wiki/ATI ), Wine will report it to > Windows applications as being some generic nVIDIA model, based on D3D > capabilities of the card. > > This patch adds detection of the used ATI video card, based on Mesa DRI > module name, which is returned by drivers in GL Renderer string. In my > opinion, returning even an approximate ATI card model should be better, > than the present condition, disguising the ATI card as some equally > generic model from nVIDIA. Also, the patch adds detection of VENDOR_MESA > from GL Renderer string, as Mesa DRI drivers may have various things as > GL Vendor, but the GL Renderer name always contains the string "Mesa". > This patch resolves the bug #7267, "Lineage 2 complains about outdated > NVIDIA drivers using ATI card with Mesa drivers" - > http://bugs.winehq.org/show_bug.cgi?id=7267 . > If you send in a fixed patch, you need to add some variation of 'try X' in the subject, where X is the number of tries you're on. On top of this, you need to say in the body what you've changed between submissions. -- James Hawkins

2 1